feat: add support for DR Congo mobile phone validation (fr-CD) by coolbeatz71 · Pull Request #2041 · validatorjs/validator.js

coolbeatz71 · 2022-09-14T13:40:19Z

fixesshould add support for DR Congo mobile phone validation #2040

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

- fixesvalidatorjs#2040 [delivers]

codecov · 2022-09-14T13:43:18Z

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (34b1099) compared to base (7b47f53).
Patch has no changes to coverable lines.

Additional details and impacted files

@@ Coverage Diff @@## master #2041 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 104 104 Lines 2308 2308 Branches 578 578 =========================================
Hits 2308 2308

Impacted Files	Coverage Δ
src/lib/isMobilePhone.js	`100.00% <ø> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

coolbeatz71 · 2022-10-18T19:58:45Z

Hey @rubiin, can anyone please review this PR?

coolbeatz71 · 2022-11-09T13:53:40Z

Hey @tux-tn @rubiin, can I expect this PR to be merged soon? Or somebody else needs to review it.

coolbeatz71 · 2022-11-15T03:04:18Z

Hey @profnandaa, your review on this PR will be highly appreciated. 😊

pano9000 · 2023-01-22T23:49:11Z

 'fo-FO': /^(\+?298)?\s?\d{2}\s?\d{2}\s?\d{2}$/,
 'fr-BF': /^(\+226|0)[67]\d{7}$/,
 'fr-BJ': /^(\+229)\d{8}$/,
+ 'fr-CD': /^(\+?243|0)?(8|9)\d{8}$/,


If I check the ITU numbering plan (page 1), it looks like the regexp here would be too permissive.
Kindly check the ranges that were officially announced in that document and adjust your regexp accordingly please.

Hey @pano9000, nice catch! thx for the feedback.
You should also note that: the above document is very old 😂(from 2009). Some MNOs in this list are no longer operational. And there are even new operators with different numbering structure.
But I think I can come up with something like /^(\+?243|0)?(8|9)(0|1|2|4|7|8\9)\d{7}$/, so telephones such as +243 902 XXXXXXX can pass the regex.
What do you think about it?

The most recent document provided to ITU is from 2013; https://www.itu.int/oth/T0202000037/en
That document is less clear than those of some other countries but looking at the communication of 15.IX.2010 I would propose the RegExp to be the following; /^(\+?243|0)?(8[0-2|4|8|9]|9[7-9])\d{7}$/.
+243 902 XXXXXXX does not seem to be valid from the official source of the ITU, but if you can provide one from the national authorities that do show that this should be valid we can look at a different RegExp

The most recent document provided to ITU is from 2013; https://www.itu.int/oth/T0202000037/en That document is less clear than those of some other countries but looking at the communication of 15.IX.2010 I would propose the RegExp to be the following; /^(\+?243|0)?(8[0-2|4|8|9]|9[7-9])\d{7}$/. +243 902 XXXXXXX does not seem to be valid from the official source of the ITU, but if you can provide one from the national authorities that do show that this should be valid we can look at a different RegExp
Hey @WikiRik. My actual phone number is +243 902 575 693 from Africel 😂

profnandaa

LGTM.

- fixes#2040 - clean-up #2041 Co-authored-by: coolbeatz71 <sigmacool@gmail.com>

profnandaa · 2023-01-31T19:43:55Z

combined in #2164

coolbeatz71 · 2022-09-14T13:40:19Z

fixesshould add support for DR Congo mobile phone validation #2040

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

- fixesvalidatorjs#2040 [delivers]

codecov · 2022-09-14T13:43:18Z

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (34b1099) compared to base (7b47f53).
Patch has no changes to coverable lines.

Additional details and impacted files

@@ Coverage Diff @@## master #2041 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 104 104 Lines 2308 2308 Branches 578 578 =========================================
Hits 2308 2308

Impacted Files	Coverage Δ
src/lib/isMobilePhone.js	`100.00% <ø> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

coolbeatz71 · 2022-10-18T19:58:45Z

Hey @rubiin, can anyone please review this PR?

coolbeatz71 · 2022-11-09T13:53:40Z

Hey @tux-tn @rubiin, can I expect this PR to be merged soon? Or somebody else needs to review it.

coolbeatz71 · 2022-11-15T03:04:18Z

Hey @profnandaa, your review on this PR will be highly appreciated. 😊

pano9000 · 2023-01-22T23:49:11Z

 'fo-FO': /^(\+?298)?\s?\d{2}\s?\d{2}\s?\d{2}$/,
 'fr-BF': /^(\+226|0)[67]\d{7}$/,
 'fr-BJ': /^(\+229)\d{8}$/,
+ 'fr-CD': /^(\+?243|0)?(8|9)\d{8}$/,


If I check the ITU numbering plan (page 1), it looks like the regexp here would be too permissive.
Kindly check the ranges that were officially announced in that document and adjust your regexp accordingly please.

Hey @pano9000, nice catch! thx for the feedback.
You should also note that: the above document is very old 😂(from 2009). Some MNOs in this list are no longer operational. And there are even new operators with different numbering structure.
But I think I can come up with something like /^(\+?243|0)?(8|9)(0|1|2|4|7|8\9)\d{7}$/, so telephones such as +243 902 XXXXXXX can pass the regex.
What do you think about it?

The most recent document provided to ITU is from 2013; https://www.itu.int/oth/T0202000037/en
That document is less clear than those of some other countries but looking at the communication of 15.IX.2010 I would propose the RegExp to be the following; /^(\+?243|0)?(8[0-2|4|8|9]|9[7-9])\d{7}$/.
+243 902 XXXXXXX does not seem to be valid from the official source of the ITU, but if you can provide one from the national authorities that do show that this should be valid we can look at a different RegExp

The most recent document provided to ITU is from 2013; https://www.itu.int/oth/T0202000037/en That document is less clear than those of some other countries but looking at the communication of 15.IX.2010 I would propose the RegExp to be the following; /^(\+?243|0)?(8[0-2|4|8|9]|9[7-9])\d{7}$/. +243 902 XXXXXXX does not seem to be valid from the official source of the ITU, but if you can provide one from the national authorities that do show that this should be valid we can look at a different RegExp
Hey @WikiRik. My actual phone number is +243 902 575 693 from Africel 😂

profnandaa

LGTM.

- fixes#2040 - clean-up #2041 Co-authored-by: coolbeatz71 <sigmacool@gmail.com>

profnandaa · 2023-01-31T19:43:55Z

combined in #2164

coolbeatz71 · 2022-09-14T13:40:19Z

fixesshould add support for DR Congo mobile phone validation #2040

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

- fixesvalidatorjs#2040 [delivers]

codecov · 2022-09-14T13:43:18Z

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (34b1099) compared to base (7b47f53).
Patch has no changes to coverable lines.

Additional details and impacted files

@@ Coverage Diff @@## master #2041 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 104 104 Lines 2308 2308 Branches 578 578 =========================================
Hits 2308 2308

Impacted Files	Coverage Δ
src/lib/isMobilePhone.js	`100.00% <ø> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

coolbeatz71 · 2022-10-18T19:58:45Z

Hey @rubiin, can anyone please review this PR?

coolbeatz71 · 2022-11-09T13:53:40Z

Hey @tux-tn @rubiin, can I expect this PR to be merged soon? Or somebody else needs to review it.

coolbeatz71 · 2022-11-15T03:04:18Z

Hey @profnandaa, your review on this PR will be highly appreciated. 😊

pano9000 · 2023-01-22T23:49:11Z

 'fo-FO': /^(\+?298)?\s?\d{2}\s?\d{2}\s?\d{2}$/,
 'fr-BF': /^(\+226|0)[67]\d{7}$/,
 'fr-BJ': /^(\+229)\d{8}$/,
+ 'fr-CD': /^(\+?243|0)?(8|9)\d{8}$/,


If I check the ITU numbering plan (page 1), it looks like the regexp here would be too permissive.
Kindly check the ranges that were officially announced in that document and adjust your regexp accordingly please.

Hey @pano9000, nice catch! thx for the feedback.
You should also note that: the above document is very old 😂(from 2009). Some MNOs in this list are no longer operational. And there are even new operators with different numbering structure.
But I think I can come up with something like /^(\+?243|0)?(8|9)(0|1|2|4|7|8\9)\d{7}$/, so telephones such as +243 902 XXXXXXX can pass the regex.
What do you think about it?

The most recent document provided to ITU is from 2013; https://www.itu.int/oth/T0202000037/en
That document is less clear than those of some other countries but looking at the communication of 15.IX.2010 I would propose the RegExp to be the following; /^(\+?243|0)?(8[0-2|4|8|9]|9[7-9])\d{7}$/.
+243 902 XXXXXXX does not seem to be valid from the official source of the ITU, but if you can provide one from the national authorities that do show that this should be valid we can look at a different RegExp

The most recent document provided to ITU is from 2013; https://www.itu.int/oth/T0202000037/en That document is less clear than those of some other countries but looking at the communication of 15.IX.2010 I would propose the RegExp to be the following; /^(\+?243|0)?(8[0-2|4|8|9]|9[7-9])\d{7}$/. +243 902 XXXXXXX does not seem to be valid from the official source of the ITU, but if you can provide one from the national authorities that do show that this should be valid we can look at a different RegExp
Hey @WikiRik. My actual phone number is +243 902 575 693 from Africel 😂

profnandaa

LGTM.

- fixes#2040 - clean-up #2041 Co-authored-by: coolbeatz71 <sigmacool@gmail.com>

profnandaa · 2023-01-31T19:43:55Z

combined in #2164

coolbeatz71 · 2022-09-14T13:40:19Z

fixesshould add support for DR Congo mobile phone validation #2040

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

- fixesvalidatorjs#2040 [delivers]

codecov · 2022-09-14T13:43:18Z

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (34b1099) compared to base (7b47f53).
Patch has no changes to coverable lines.

Additional details and impacted files

@@ Coverage Diff @@## master #2041 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 104 104 Lines 2308 2308 Branches 578 578 =========================================
Hits 2308 2308

Impacted Files	Coverage Δ
src/lib/isMobilePhone.js	`100.00% <ø> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

coolbeatz71 · 2022-10-18T19:58:45Z

Hey @rubiin, can anyone please review this PR?

coolbeatz71 · 2022-11-09T13:53:40Z

Hey @tux-tn @rubiin, can I expect this PR to be merged soon? Or somebody else needs to review it.

coolbeatz71 · 2022-11-15T03:04:18Z

Hey @profnandaa, your review on this PR will be highly appreciated. 😊

pano9000 · 2023-01-22T23:49:11Z

 'fo-FO': /^(\+?298)?\s?\d{2}\s?\d{2}\s?\d{2}$/,
 'fr-BF': /^(\+226|0)[67]\d{7}$/,
 'fr-BJ': /^(\+229)\d{8}$/,
+ 'fr-CD': /^(\+?243|0)?(8|9)\d{8}$/,


If I check the ITU numbering plan (page 1), it looks like the regexp here would be too permissive.
Kindly check the ranges that were officially announced in that document and adjust your regexp accordingly please.

Hey @pano9000, nice catch! thx for the feedback.
You should also note that: the above document is very old 😂(from 2009). Some MNOs in this list are no longer operational. And there are even new operators with different numbering structure.
But I think I can come up with something like /^(\+?243|0)?(8|9)(0|1|2|4|7|8\9)\d{7}$/, so telephones such as +243 902 XXXXXXX can pass the regex.
What do you think about it?

The most recent document provided to ITU is from 2013; https://www.itu.int/oth/T0202000037/en
That document is less clear than those of some other countries but looking at the communication of 15.IX.2010 I would propose the RegExp to be the following; /^(\+?243|0)?(8[0-2|4|8|9]|9[7-9])\d{7}$/.
+243 902 XXXXXXX does not seem to be valid from the official source of the ITU, but if you can provide one from the national authorities that do show that this should be valid we can look at a different RegExp

The most recent document provided to ITU is from 2013; https://www.itu.int/oth/T0202000037/en That document is less clear than those of some other countries but looking at the communication of 15.IX.2010 I would propose the RegExp to be the following; /^(\+?243|0)?(8[0-2|4|8|9]|9[7-9])\d{7}$/. +243 902 XXXXXXX does not seem to be valid from the official source of the ITU, but if you can provide one from the national authorities that do show that this should be valid we can look at a different RegExp
Hey @WikiRik. My actual phone number is +243 902 575 693 from Africel 😂

profnandaa

LGTM.

- fixes#2040 - clean-up #2041 Co-authored-by: coolbeatz71 <sigmacool@gmail.com>

profnandaa · 2023-01-31T19:43:55Z

combined in #2164

coolbeatz71 · 2022-09-14T13:40:19Z

fixesshould add support for DR Congo mobile phone validation #2040

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

- fixesvalidatorjs#2040 [delivers]

codecov · 2022-09-14T13:43:18Z

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (34b1099) compared to base (7b47f53).
Patch has no changes to coverable lines.

Additional details and impacted files

@@ Coverage Diff @@## master #2041 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 104 104 Lines 2308 2308 Branches 578 578 =========================================
Hits 2308 2308

Impacted Files	Coverage Δ
src/lib/isMobilePhone.js	`100.00% <ø> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

coolbeatz71 · 2022-10-18T19:58:45Z

Hey @rubiin, can anyone please review this PR?

coolbeatz71 · 2022-11-09T13:53:40Z

Hey @tux-tn @rubiin, can I expect this PR to be merged soon? Or somebody else needs to review it.

coolbeatz71 · 2022-11-15T03:04:18Z

Hey @profnandaa, your review on this PR will be highly appreciated. 😊

pano9000 · 2023-01-22T23:49:11Z

 'fo-FO': /^(\+?298)?\s?\d{2}\s?\d{2}\s?\d{2}$/,
 'fr-BF': /^(\+226|0)[67]\d{7}$/,
 'fr-BJ': /^(\+229)\d{8}$/,
+ 'fr-CD': /^(\+?243|0)?(8|9)\d{8}$/,


If I check the ITU numbering plan (page 1), it looks like the regexp here would be too permissive.
Kindly check the ranges that were officially announced in that document and adjust your regexp accordingly please.

Hey @pano9000, nice catch! thx for the feedback.
You should also note that: the above document is very old 😂(from 2009). Some MNOs in this list are no longer operational. And there are even new operators with different numbering structure.
But I think I can come up with something like /^(\+?243|0)?(8|9)(0|1|2|4|7|8\9)\d{7}$/, so telephones such as +243 902 XXXXXXX can pass the regex.
What do you think about it?

The most recent document provided to ITU is from 2013; https://www.itu.int/oth/T0202000037/en
That document is less clear than those of some other countries but looking at the communication of 15.IX.2010 I would propose the RegExp to be the following; /^(\+?243|0)?(8[0-2|4|8|9]|9[7-9])\d{7}$/.
+243 902 XXXXXXX does not seem to be valid from the official source of the ITU, but if you can provide one from the national authorities that do show that this should be valid we can look at a different RegExp

The most recent document provided to ITU is from 2013; https://www.itu.int/oth/T0202000037/en That document is less clear than those of some other countries but looking at the communication of 15.IX.2010 I would propose the RegExp to be the following; /^(\+?243|0)?(8[0-2|4|8|9]|9[7-9])\d{7}$/. +243 902 XXXXXXX does not seem to be valid from the official source of the ITU, but if you can provide one from the national authorities that do show that this should be valid we can look at a different RegExp
Hey @WikiRik. My actual phone number is +243 902 575 693 from Africel 😂

profnandaa

LGTM.

- fixes#2040 - clean-up #2041 Co-authored-by: coolbeatz71 <sigmacool@gmail.com>

profnandaa · 2023-01-31T19:43:55Z

combined in #2164

coolbeatz71 · 2022-09-14T13:40:19Z

fixesshould add support for DR Congo mobile phone validation #2040

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

- fixesvalidatorjs#2040 [delivers]

codecov · 2022-09-14T13:43:18Z

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (34b1099) compared to base (7b47f53).
Patch has no changes to coverable lines.

Additional details and impacted files

@@ Coverage Diff @@## master #2041 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 104 104 Lines 2308 2308 Branches 578 578 =========================================
Hits 2308 2308

Impacted Files	Coverage Δ
src/lib/isMobilePhone.js	`100.00% <ø> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

coolbeatz71 · 2022-10-18T19:58:45Z

Hey @rubiin, can anyone please review this PR?

coolbeatz71 · 2022-11-09T13:53:40Z

Hey @tux-tn @rubiin, can I expect this PR to be merged soon? Or somebody else needs to review it.

coolbeatz71 · 2022-11-15T03:04:18Z

Hey @profnandaa, your review on this PR will be highly appreciated. 😊

pano9000 · 2023-01-22T23:49:11Z

 'fo-FO': /^(\+?298)?\s?\d{2}\s?\d{2}\s?\d{2}$/,
 'fr-BF': /^(\+226|0)[67]\d{7}$/,
 'fr-BJ': /^(\+229)\d{8}$/,
+ 'fr-CD': /^(\+?243|0)?(8|9)\d{8}$/,


If I check the ITU numbering plan (page 1), it looks like the regexp here would be too permissive.
Kindly check the ranges that were officially announced in that document and adjust your regexp accordingly please.

Hey @pano9000, nice catch! thx for the feedback.
You should also note that: the above document is very old 😂(from 2009). Some MNOs in this list are no longer operational. And there are even new operators with different numbering structure.
But I think I can come up with something like /^(\+?243|0)?(8|9)(0|1|2|4|7|8\9)\d{7}$/, so telephones such as +243 902 XXXXXXX can pass the regex.
What do you think about it?

The most recent document provided to ITU is from 2013; https://www.itu.int/oth/T0202000037/en
That document is less clear than those of some other countries but looking at the communication of 15.IX.2010 I would propose the RegExp to be the following; /^(\+?243|0)?(8[0-2|4|8|9]|9[7-9])\d{7}$/.
+243 902 XXXXXXX does not seem to be valid from the official source of the ITU, but if you can provide one from the national authorities that do show that this should be valid we can look at a different RegExp

The most recent document provided to ITU is from 2013; https://www.itu.int/oth/T0202000037/en That document is less clear than those of some other countries but looking at the communication of 15.IX.2010 I would propose the RegExp to be the following; /^(\+?243|0)?(8[0-2|4|8|9]|9[7-9])\d{7}$/. +243 902 XXXXXXX does not seem to be valid from the official source of the ITU, but if you can provide one from the national authorities that do show that this should be valid we can look at a different RegExp
Hey @WikiRik. My actual phone number is +243 902 575 693 from Africel 😂

profnandaa

LGTM.

- fixes#2040 - clean-up #2041 Co-authored-by: coolbeatz71 <sigmacool@gmail.com>

profnandaa · 2023-01-31T19:43:55Z

combined in #2164

coolbeatz71 · 2022-09-14T13:40:19Z

fixesshould add support for DR Congo mobile phone validation #2040

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

- fixesvalidatorjs#2040 [delivers]

codecov · 2022-09-14T13:43:18Z

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (34b1099) compared to base (7b47f53).
Patch has no changes to coverable lines.

Additional details and impacted files

@@ Coverage Diff @@## master #2041 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 104 104 Lines 2308 2308 Branches 578 578 =========================================
Hits 2308 2308

Impacted Files	Coverage Δ
src/lib/isMobilePhone.js	`100.00% <ø> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

coolbeatz71 · 2022-10-18T19:58:45Z

Hey @rubiin, can anyone please review this PR?

coolbeatz71 · 2022-11-09T13:53:40Z

Hey @tux-tn @rubiin, can I expect this PR to be merged soon? Or somebody else needs to review it.

coolbeatz71 · 2022-11-15T03:04:18Z

Hey @profnandaa, your review on this PR will be highly appreciated. 😊

pano9000 · 2023-01-22T23:49:11Z

 'fo-FO': /^(\+?298)?\s?\d{2}\s?\d{2}\s?\d{2}$/,
 'fr-BF': /^(\+226|0)[67]\d{7}$/,
 'fr-BJ': /^(\+229)\d{8}$/,
+ 'fr-CD': /^(\+?243|0)?(8|9)\d{8}$/,


If I check the ITU numbering plan (page 1), it looks like the regexp here would be too permissive.
Kindly check the ranges that were officially announced in that document and adjust your regexp accordingly please.

Hey @pano9000, nice catch! thx for the feedback.
You should also note that: the above document is very old 😂(from 2009). Some MNOs in this list are no longer operational. And there are even new operators with different numbering structure.
But I think I can come up with something like /^(\+?243|0)?(8|9)(0|1|2|4|7|8\9)\d{7}$/, so telephones such as +243 902 XXXXXXX can pass the regex.
What do you think about it?

The most recent document provided to ITU is from 2013; https://www.itu.int/oth/T0202000037/en
That document is less clear than those of some other countries but looking at the communication of 15.IX.2010 I would propose the RegExp to be the following; /^(\+?243|0)?(8[0-2|4|8|9]|9[7-9])\d{7}$/.
+243 902 XXXXXXX does not seem to be valid from the official source of the ITU, but if you can provide one from the national authorities that do show that this should be valid we can look at a different RegExp

The most recent document provided to ITU is from 2013; https://www.itu.int/oth/T0202000037/en That document is less clear than those of some other countries but looking at the communication of 15.IX.2010 I would propose the RegExp to be the following; /^(\+?243|0)?(8[0-2|4|8|9]|9[7-9])\d{7}$/. +243 902 XXXXXXX does not seem to be valid from the official source of the ITU, but if you can provide one from the national authorities that do show that this should be valid we can look at a different RegExp
Hey @WikiRik. My actual phone number is +243 902 575 693 from Africel 😂

profnandaa

LGTM.

- fixes#2040 - clean-up #2041 Co-authored-by: coolbeatz71 <sigmacool@gmail.com>

profnandaa · 2023-01-31T19:43:55Z

combined in #2164

coolbeatz71 · 2022-09-14T13:40:19Z

fixesshould add support for DR Congo mobile phone validation #2040

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

- fixesvalidatorjs#2040 [delivers]

codecov · 2022-09-14T13:43:18Z

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (34b1099) compared to base (7b47f53).
Patch has no changes to coverable lines.

Additional details and impacted files

@@ Coverage Diff @@## master #2041 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 104 104 Lines 2308 2308 Branches 578 578 =========================================
Hits 2308 2308

Impacted Files	Coverage Δ
src/lib/isMobilePhone.js	`100.00% <ø> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

coolbeatz71 · 2022-10-18T19:58:45Z

Hey @rubiin, can anyone please review this PR?

coolbeatz71 · 2022-11-09T13:53:40Z

Hey @tux-tn @rubiin, can I expect this PR to be merged soon? Or somebody else needs to review it.

coolbeatz71 · 2022-11-15T03:04:18Z

Hey @profnandaa, your review on this PR will be highly appreciated. 😊

pano9000 · 2023-01-22T23:49:11Z

 'fo-FO': /^(\+?298)?\s?\d{2}\s?\d{2}\s?\d{2}$/,
 'fr-BF': /^(\+226|0)[67]\d{7}$/,
 'fr-BJ': /^(\+229)\d{8}$/,
+ 'fr-CD': /^(\+?243|0)?(8|9)\d{8}$/,


If I check the ITU numbering plan (page 1), it looks like the regexp here would be too permissive.
Kindly check the ranges that were officially announced in that document and adjust your regexp accordingly please.

Hey @pano9000, nice catch! thx for the feedback.
You should also note that: the above document is very old 😂(from 2009). Some MNOs in this list are no longer operational. And there are even new operators with different numbering structure.
But I think I can come up with something like /^(\+?243|0)?(8|9)(0|1|2|4|7|8\9)\d{7}$/, so telephones such as +243 902 XXXXXXX can pass the regex.
What do you think about it?

The most recent document provided to ITU is from 2013; https://www.itu.int/oth/T0202000037/en
That document is less clear than those of some other countries but looking at the communication of 15.IX.2010 I would propose the RegExp to be the following; /^(\+?243|0)?(8[0-2|4|8|9]|9[7-9])\d{7}$/.
+243 902 XXXXXXX does not seem to be valid from the official source of the ITU, but if you can provide one from the national authorities that do show that this should be valid we can look at a different RegExp

The most recent document provided to ITU is from 2013; https://www.itu.int/oth/T0202000037/en That document is less clear than those of some other countries but looking at the communication of 15.IX.2010 I would propose the RegExp to be the following; /^(\+?243|0)?(8[0-2|4|8|9]|9[7-9])\d{7}$/. +243 902 XXXXXXX does not seem to be valid from the official source of the ITU, but if you can provide one from the national authorities that do show that this should be valid we can look at a different RegExp
Hey @WikiRik. My actual phone number is +243 902 575 693 from Africel 😂

profnandaa

LGTM.

- fixes#2040 - clean-up #2041 Co-authored-by: coolbeatz71 <sigmacool@gmail.com>

profnandaa · 2023-01-31T19:43:55Z

combined in #2164

feat: add support for DR Congo mobile phone validation
b1ccd29
- fixesvalidatorjs#2040 [delivers]

coolbeatz71 changed the title ~~feat: add support for DR Congo mobile phone validation~~feat: add support for DR Congo mobile phone validation (fr-CD)Sep 14, 2022

Merge branch 'master' into master
34b1099

rubiin approved these changes Oct 19, 2022
View reviewed changes

tux-tn added ready-to-land For PRs that are reviewed and ready to be landed 🎉 first-pr labels Oct 19, 2022

rubiin requested a review from profnandaa November 9, 2022 13:58

pano9000 suggested changes Jan 22, 2023
View reviewed changes

pano9000 added 🧹 needs-update For PRs that need to be updated before landing and removed ready-to-land For PRs that are reviewed and ready to be landed labels Jan 22, 2023

rubiin added the mc-to-land Just merge-conflict standing between the PR and landing. label Jan 23, 2023

profnandaa approved these changes Jan 31, 2023
View reviewed changes

profnandaa added a commit that referenced this pull request Jan 31, 2023
feat:(isMobilePhone): add fr-CD, DR Congo locale (#2168)
5bb8c91
- fixes#2040 - clean-up #2041 Co-authored-by: coolbeatz71 <sigmacool@gmail.com>

profnandaa closed this Jan 31, 2023

profnandaa added the PR/combined label Jan 31, 2023

profnandaa mentioned this pull request Feb 2, 2023
maintenance: release 2301 prep - v13.9.0 #2166
Closed

rntvicente mentioned this pull request May 24, 2024
[Snyk] Upgrade validator from 13.5.2 to 13.11.0 rntvicente/ts-clean-architecture#25
Open

sahilpawar58 mentioned this pull request May 25, 2024
[Snyk] Upgrade validator from 13.6.0 to 13.11.0 sahilpawar58/Civil-Project#47
Open

ChinmoyHembram mentioned this pull request May 25, 2024
[Snyk] Upgrade validator from 13.7.0 to 13.11.0 ChinmoyHembram/Cocktail-recipel-site#260
Open

fossabotBot mentioned this pull request Oct 28, 2025
Bump validator from 13.7.0 to 13.15.20 in /ui UchihaCortez/conductor#6
Closed