feat(isIBAN): add white and blacklist options to the isIBAN validator by edilson · Pull Request #2235 · validatorjs/validator.js

edilson · 2023-06-14T20:55:24Z

feat(isIBAN): add white and blacklist options to the isIBAN validator

In order to restrict the list of countries that I want to validate the IBAN against now we can pass the whitelist option with the country codes that I want to validate the code. Also if I want to remove a certain country from the validation now I will have the blacklist option and the countries passed there will be removed from validation.

So, if you use the isIBAN validator and pass a the whitelist option and the country from the IBAN code is not on the whitelist, it will return an error:

importisIBANfrom'validator/lib/isIBAN';isIBAN('GB29NWBK60161331926819',{whitelist: ['IT']})Error: IBANcodedoesnotbelongtooneofthecountrieslistedonwhitelist!

And if you use the same validator with the blacklist option it should return an error if the code passed is from one of the countries listed:

importisIBANfrom'validator/lib/isIBAN';isIBAN('GB29NWBK60161331926819',{blacklist: ['GB']})Error: IBANcodebelongstooneofthecountrieslistedonblacklist!

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)
References provided in PR (where applicable)

codecov · 2023-06-14T20:58:18Z

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4f63909) 99.95% compared to head (852c3fb) 99.95%.

❗ Current head 852c3fb differs from pull request most recent head bd34c0b. Consider uploading reports for the commit bd34c0b to get more accurate results

Additional details and impacted files

@@ Coverage Diff @@## master #2235 +/- ##
=======================================
Coverage 99.95% 99.95% =======================================
Files 107 107 Lines 2414 2431 +17 Branches 607 614 +7 =======================================
+ Hits 2413 2430 +17 
Partials 1 1

Impacted Files	Coverage Δ
src/lib/isIBAN.js	`100.00% <100.00%> (ø)`

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

WikiRik · 2023-06-18T10:22:33Z

 **isHexColor(str)** | check if the string is a hexadecimal color.
 **isHSL(str)** | check if the string is an HSL (hue, saturation, lightness, optional alpha) color based on [CSS Colors Level 4 specification][CSS Colors Level 4 Specification].<br/><br/>Comma-separated format supported. Space-separated format supported with the exception of a few edge cases (ex: `hsl(200grad+.1%62%/1)`).
-**isIBAN(str)** | check if the string is an IBAN (International Bank Account Number).
+**isIBAN(str)** | check if the string is an IBAN (International Bank Account Number).<br/><br/>Also allows you to define a whitelist, when you only want to recieve IBAN codes from certain countries or a blacklist, removing some of them from the current list.


Could you elaborate on how you can define this? Like we explain the options object in other validators as well. Also with the list of supported country codes

@WikiRik I have updated and put which attributes it will receive and also the values that can be used in each of them.

WikiRik

Can you undo the style changes in README?

…or without formatting it

edilson · 2023-06-26T17:58:09Z

@WikiRik do you think this could be merged now?

edilson · 2023-07-21T14:20:36Z

@pano9000 @profnandaa could you take a look on this feature, please?

profnandaa · 2023-07-24T13:09:51Z

+ const isoCountryCodeInWhiteList = options.whitelist.includes(isoCountryCode);
+
+ if (!isoCountryCodeInWhiteList) {
+ throw new Error('IBAN code does not belong to one of the countries listed on whitelist!');


nit: the pattern so far has not been to throw errors, just true/false. I'm not sure how to go about this one...

I guess we can continue with the true/false approach and let the user decide how to treat this.

Done @profnandaa

profnandaa

LGTM.

edilson · 2023-08-03T13:23:53Z

Thanks, folks

edilson · 2023-06-14T20:55:24Z

feat(isIBAN): add white and blacklist options to the isIBAN validator

In order to restrict the list of countries that I want to validate the IBAN against now we can pass the whitelist option with the country codes that I want to validate the code. Also if I want to remove a certain country from the validation now I will have the blacklist option and the countries passed there will be removed from validation.

So, if you use the isIBAN validator and pass a the whitelist option and the country from the IBAN code is not on the whitelist, it will return an error:

importisIBANfrom'validator/lib/isIBAN';isIBAN('GB29NWBK60161331926819',{whitelist: ['IT']})Error: IBANcodedoesnotbelongtooneofthecountrieslistedonwhitelist!

And if you use the same validator with the blacklist option it should return an error if the code passed is from one of the countries listed:

importisIBANfrom'validator/lib/isIBAN';isIBAN('GB29NWBK60161331926819',{blacklist: ['GB']})Error: IBANcodebelongstooneofthecountrieslistedonblacklist!

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)
References provided in PR (where applicable)

codecov · 2023-06-14T20:58:18Z

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4f63909) 99.95% compared to head (852c3fb) 99.95%.

❗ Current head 852c3fb differs from pull request most recent head bd34c0b. Consider uploading reports for the commit bd34c0b to get more accurate results

Additional details and impacted files

@@ Coverage Diff @@## master #2235 +/- ##
=======================================
Coverage 99.95% 99.95% =======================================
Files 107 107 Lines 2414 2431 +17 Branches 607 614 +7 =======================================
+ Hits 2413 2430 +17 
Partials 1 1

Impacted Files	Coverage Δ
src/lib/isIBAN.js	`100.00% <100.00%> (ø)`

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

WikiRik · 2023-06-18T10:22:33Z

 **isHexColor(str)** | check if the string is a hexadecimal color.
 **isHSL(str)** | check if the string is an HSL (hue, saturation, lightness, optional alpha) color based on [CSS Colors Level 4 specification][CSS Colors Level 4 Specification].<br/><br/>Comma-separated format supported. Space-separated format supported with the exception of a few edge cases (ex: `hsl(200grad+.1%62%/1)`).
-**isIBAN(str)** | check if the string is an IBAN (International Bank Account Number).
+**isIBAN(str)** | check if the string is an IBAN (International Bank Account Number).<br/><br/>Also allows you to define a whitelist, when you only want to recieve IBAN codes from certain countries or a blacklist, removing some of them from the current list.


Could you elaborate on how you can define this? Like we explain the options object in other validators as well. Also with the list of supported country codes

@WikiRik I have updated and put which attributes it will receive and also the values that can be used in each of them.

WikiRik

Can you undo the style changes in README?

…or without formatting it

edilson · 2023-06-26T17:58:09Z

@WikiRik do you think this could be merged now?

edilson · 2023-07-21T14:20:36Z

@pano9000 @profnandaa could you take a look on this feature, please?

profnandaa · 2023-07-24T13:09:51Z

+ const isoCountryCodeInWhiteList = options.whitelist.includes(isoCountryCode);
+
+ if (!isoCountryCodeInWhiteList) {
+ throw new Error('IBAN code does not belong to one of the countries listed on whitelist!');


nit: the pattern so far has not been to throw errors, just true/false. I'm not sure how to go about this one...

I guess we can continue with the true/false approach and let the user decide how to treat this.

Done @profnandaa

profnandaa

LGTM.

edilson · 2023-08-03T13:23:53Z

Thanks, folks

edilson · 2023-06-14T20:55:24Z

feat(isIBAN): add white and blacklist options to the isIBAN validator

In order to restrict the list of countries that I want to validate the IBAN against now we can pass the whitelist option with the country codes that I want to validate the code. Also if I want to remove a certain country from the validation now I will have the blacklist option and the countries passed there will be removed from validation.

So, if you use the isIBAN validator and pass a the whitelist option and the country from the IBAN code is not on the whitelist, it will return an error:

importisIBANfrom'validator/lib/isIBAN';isIBAN('GB29NWBK60161331926819',{whitelist: ['IT']})Error: IBANcodedoesnotbelongtooneofthecountrieslistedonwhitelist!

And if you use the same validator with the blacklist option it should return an error if the code passed is from one of the countries listed:

importisIBANfrom'validator/lib/isIBAN';isIBAN('GB29NWBK60161331926819',{blacklist: ['GB']})Error: IBANcodebelongstooneofthecountrieslistedonblacklist!

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)
References provided in PR (where applicable)

codecov · 2023-06-14T20:58:18Z

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4f63909) 99.95% compared to head (852c3fb) 99.95%.

❗ Current head 852c3fb differs from pull request most recent head bd34c0b. Consider uploading reports for the commit bd34c0b to get more accurate results

Additional details and impacted files

@@ Coverage Diff @@## master #2235 +/- ##
=======================================
Coverage 99.95% 99.95% =======================================
Files 107 107 Lines 2414 2431 +17 Branches 607 614 +7 =======================================
+ Hits 2413 2430 +17 
Partials 1 1

Impacted Files	Coverage Δ
src/lib/isIBAN.js	`100.00% <100.00%> (ø)`

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

WikiRik · 2023-06-18T10:22:33Z

 **isHexColor(str)** | check if the string is a hexadecimal color.
 **isHSL(str)** | check if the string is an HSL (hue, saturation, lightness, optional alpha) color based on [CSS Colors Level 4 specification][CSS Colors Level 4 Specification].<br/><br/>Comma-separated format supported. Space-separated format supported with the exception of a few edge cases (ex: `hsl(200grad+.1%62%/1)`).
-**isIBAN(str)** | check if the string is an IBAN (International Bank Account Number).
+**isIBAN(str)** | check if the string is an IBAN (International Bank Account Number).<br/><br/>Also allows you to define a whitelist, when you only want to recieve IBAN codes from certain countries or a blacklist, removing some of them from the current list.


Could you elaborate on how you can define this? Like we explain the options object in other validators as well. Also with the list of supported country codes

@WikiRik I have updated and put which attributes it will receive and also the values that can be used in each of them.

WikiRik

Can you undo the style changes in README?

…or without formatting it

edilson · 2023-06-26T17:58:09Z

@WikiRik do you think this could be merged now?

edilson · 2023-07-21T14:20:36Z

@pano9000 @profnandaa could you take a look on this feature, please?

profnandaa · 2023-07-24T13:09:51Z

+ const isoCountryCodeInWhiteList = options.whitelist.includes(isoCountryCode);
+
+ if (!isoCountryCodeInWhiteList) {
+ throw new Error('IBAN code does not belong to one of the countries listed on whitelist!');


nit: the pattern so far has not been to throw errors, just true/false. I'm not sure how to go about this one...

I guess we can continue with the true/false approach and let the user decide how to treat this.

Done @profnandaa

profnandaa

LGTM.

edilson · 2023-08-03T13:23:53Z

Thanks, folks

edilson · 2023-06-14T20:55:24Z

feat(isIBAN): add white and blacklist options to the isIBAN validator

In order to restrict the list of countries that I want to validate the IBAN against now we can pass the whitelist option with the country codes that I want to validate the code. Also if I want to remove a certain country from the validation now I will have the blacklist option and the countries passed there will be removed from validation.

So, if you use the isIBAN validator and pass a the whitelist option and the country from the IBAN code is not on the whitelist, it will return an error:

importisIBANfrom'validator/lib/isIBAN';isIBAN('GB29NWBK60161331926819',{whitelist: ['IT']})Error: IBANcodedoesnotbelongtooneofthecountrieslistedonwhitelist!

And if you use the same validator with the blacklist option it should return an error if the code passed is from one of the countries listed:

importisIBANfrom'validator/lib/isIBAN';isIBAN('GB29NWBK60161331926819',{blacklist: ['GB']})Error: IBANcodebelongstooneofthecountrieslistedonblacklist!

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)
References provided in PR (where applicable)

codecov · 2023-06-14T20:58:18Z

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4f63909) 99.95% compared to head (852c3fb) 99.95%.

❗ Current head 852c3fb differs from pull request most recent head bd34c0b. Consider uploading reports for the commit bd34c0b to get more accurate results

Additional details and impacted files

@@ Coverage Diff @@## master #2235 +/- ##
=======================================
Coverage 99.95% 99.95% =======================================
Files 107 107 Lines 2414 2431 +17 Branches 607 614 +7 =======================================
+ Hits 2413 2430 +17 
Partials 1 1

Impacted Files	Coverage Δ
src/lib/isIBAN.js	`100.00% <100.00%> (ø)`

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

WikiRik · 2023-06-18T10:22:33Z

 **isHexColor(str)** | check if the string is a hexadecimal color.
 **isHSL(str)** | check if the string is an HSL (hue, saturation, lightness, optional alpha) color based on [CSS Colors Level 4 specification][CSS Colors Level 4 Specification].<br/><br/>Comma-separated format supported. Space-separated format supported with the exception of a few edge cases (ex: `hsl(200grad+.1%62%/1)`).
-**isIBAN(str)** | check if the string is an IBAN (International Bank Account Number).
+**isIBAN(str)** | check if the string is an IBAN (International Bank Account Number).<br/><br/>Also allows you to define a whitelist, when you only want to recieve IBAN codes from certain countries or a blacklist, removing some of them from the current list.


Could you elaborate on how you can define this? Like we explain the options object in other validators as well. Also with the list of supported country codes

@WikiRik I have updated and put which attributes it will receive and also the values that can be used in each of them.

WikiRik

Can you undo the style changes in README?

…or without formatting it

edilson · 2023-06-26T17:58:09Z

@WikiRik do you think this could be merged now?

edilson · 2023-07-21T14:20:36Z

@pano9000 @profnandaa could you take a look on this feature, please?

profnandaa · 2023-07-24T13:09:51Z

+ const isoCountryCodeInWhiteList = options.whitelist.includes(isoCountryCode);
+
+ if (!isoCountryCodeInWhiteList) {
+ throw new Error('IBAN code does not belong to one of the countries listed on whitelist!');


nit: the pattern so far has not been to throw errors, just true/false. I'm not sure how to go about this one...

I guess we can continue with the true/false approach and let the user decide how to treat this.

Done @profnandaa

profnandaa

LGTM.

edilson · 2023-08-03T13:23:53Z

Thanks, folks

edilson · 2023-06-14T20:55:24Z

feat(isIBAN): add white and blacklist options to the isIBAN validator

In order to restrict the list of countries that I want to validate the IBAN against now we can pass the whitelist option with the country codes that I want to validate the code. Also if I want to remove a certain country from the validation now I will have the blacklist option and the countries passed there will be removed from validation.

So, if you use the isIBAN validator and pass a the whitelist option and the country from the IBAN code is not on the whitelist, it will return an error:

importisIBANfrom'validator/lib/isIBAN';isIBAN('GB29NWBK60161331926819',{whitelist: ['IT']})Error: IBANcodedoesnotbelongtooneofthecountrieslistedonwhitelist!

And if you use the same validator with the blacklist option it should return an error if the code passed is from one of the countries listed:

importisIBANfrom'validator/lib/isIBAN';isIBAN('GB29NWBK60161331926819',{blacklist: ['GB']})Error: IBANcodebelongstooneofthecountrieslistedonblacklist!

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)
References provided in PR (where applicable)

codecov · 2023-06-14T20:58:18Z

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4f63909) 99.95% compared to head (852c3fb) 99.95%.

❗ Current head 852c3fb differs from pull request most recent head bd34c0b. Consider uploading reports for the commit bd34c0b to get more accurate results

Additional details and impacted files

@@ Coverage Diff @@## master #2235 +/- ##
=======================================
Coverage 99.95% 99.95% =======================================
Files 107 107 Lines 2414 2431 +17 Branches 607 614 +7 =======================================
+ Hits 2413 2430 +17 
Partials 1 1

Impacted Files	Coverage Δ
src/lib/isIBAN.js	`100.00% <100.00%> (ø)`

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

WikiRik · 2023-06-18T10:22:33Z

 **isHexColor(str)** | check if the string is a hexadecimal color.
 **isHSL(str)** | check if the string is an HSL (hue, saturation, lightness, optional alpha) color based on [CSS Colors Level 4 specification][CSS Colors Level 4 Specification].<br/><br/>Comma-separated format supported. Space-separated format supported with the exception of a few edge cases (ex: `hsl(200grad+.1%62%/1)`).
-**isIBAN(str)** | check if the string is an IBAN (International Bank Account Number).
+**isIBAN(str)** | check if the string is an IBAN (International Bank Account Number).<br/><br/>Also allows you to define a whitelist, when you only want to recieve IBAN codes from certain countries or a blacklist, removing some of them from the current list.


Could you elaborate on how you can define this? Like we explain the options object in other validators as well. Also with the list of supported country codes

@WikiRik I have updated and put which attributes it will receive and also the values that can be used in each of them.

WikiRik

Can you undo the style changes in README?

…or without formatting it

edilson · 2023-06-26T17:58:09Z

@WikiRik do you think this could be merged now?

edilson · 2023-07-21T14:20:36Z

@pano9000 @profnandaa could you take a look on this feature, please?

profnandaa · 2023-07-24T13:09:51Z

+ const isoCountryCodeInWhiteList = options.whitelist.includes(isoCountryCode);
+
+ if (!isoCountryCodeInWhiteList) {
+ throw new Error('IBAN code does not belong to one of the countries listed on whitelist!');


nit: the pattern so far has not been to throw errors, just true/false. I'm not sure how to go about this one...

I guess we can continue with the true/false approach and let the user decide how to treat this.

Done @profnandaa

profnandaa

LGTM.

edilson · 2023-08-03T13:23:53Z

Thanks, folks

edilson · 2023-06-14T20:55:24Z

feat(isIBAN): add white and blacklist options to the isIBAN validator

In order to restrict the list of countries that I want to validate the IBAN against now we can pass the whitelist option with the country codes that I want to validate the code. Also if I want to remove a certain country from the validation now I will have the blacklist option and the countries passed there will be removed from validation.

So, if you use the isIBAN validator and pass a the whitelist option and the country from the IBAN code is not on the whitelist, it will return an error:

importisIBANfrom'validator/lib/isIBAN';isIBAN('GB29NWBK60161331926819',{whitelist: ['IT']})Error: IBANcodedoesnotbelongtooneofthecountrieslistedonwhitelist!

And if you use the same validator with the blacklist option it should return an error if the code passed is from one of the countries listed:

importisIBANfrom'validator/lib/isIBAN';isIBAN('GB29NWBK60161331926819',{blacklist: ['GB']})Error: IBANcodebelongstooneofthecountrieslistedonblacklist!

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)
References provided in PR (where applicable)

codecov · 2023-06-14T20:58:18Z

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4f63909) 99.95% compared to head (852c3fb) 99.95%.

❗ Current head 852c3fb differs from pull request most recent head bd34c0b. Consider uploading reports for the commit bd34c0b to get more accurate results

Additional details and impacted files

@@ Coverage Diff @@## master #2235 +/- ##
=======================================
Coverage 99.95% 99.95% =======================================
Files 107 107 Lines 2414 2431 +17 Branches 607 614 +7 =======================================
+ Hits 2413 2430 +17 
Partials 1 1

Impacted Files	Coverage Δ
src/lib/isIBAN.js	`100.00% <100.00%> (ø)`

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

WikiRik · 2023-06-18T10:22:33Z

 **isHexColor(str)** | check if the string is a hexadecimal color.
 **isHSL(str)** | check if the string is an HSL (hue, saturation, lightness, optional alpha) color based on [CSS Colors Level 4 specification][CSS Colors Level 4 Specification].<br/><br/>Comma-separated format supported. Space-separated format supported with the exception of a few edge cases (ex: `hsl(200grad+.1%62%/1)`).
-**isIBAN(str)** | check if the string is an IBAN (International Bank Account Number).
+**isIBAN(str)** | check if the string is an IBAN (International Bank Account Number).<br/><br/>Also allows you to define a whitelist, when you only want to recieve IBAN codes from certain countries or a blacklist, removing some of them from the current list.


Could you elaborate on how you can define this? Like we explain the options object in other validators as well. Also with the list of supported country codes

@WikiRik I have updated and put which attributes it will receive and also the values that can be used in each of them.

WikiRik

Can you undo the style changes in README?

…or without formatting it

edilson · 2023-06-26T17:58:09Z

@WikiRik do you think this could be merged now?

edilson · 2023-07-21T14:20:36Z

@pano9000 @profnandaa could you take a look on this feature, please?

profnandaa · 2023-07-24T13:09:51Z

+ const isoCountryCodeInWhiteList = options.whitelist.includes(isoCountryCode);
+
+ if (!isoCountryCodeInWhiteList) {
+ throw new Error('IBAN code does not belong to one of the countries listed on whitelist!');


nit: the pattern so far has not been to throw errors, just true/false. I'm not sure how to go about this one...

I guess we can continue with the true/false approach and let the user decide how to treat this.

Done @profnandaa

profnandaa

LGTM.

edilson · 2023-08-03T13:23:53Z

Thanks, folks

edilson · 2023-06-14T20:55:24Z

feat(isIBAN): add white and blacklist options to the isIBAN validator

In order to restrict the list of countries that I want to validate the IBAN against now we can pass the whitelist option with the country codes that I want to validate the code. Also if I want to remove a certain country from the validation now I will have the blacklist option and the countries passed there will be removed from validation.

So, if you use the isIBAN validator and pass a the whitelist option and the country from the IBAN code is not on the whitelist, it will return an error:

importisIBANfrom'validator/lib/isIBAN';isIBAN('GB29NWBK60161331926819',{whitelist: ['IT']})Error: IBANcodedoesnotbelongtooneofthecountrieslistedonwhitelist!

And if you use the same validator with the blacklist option it should return an error if the code passed is from one of the countries listed:

importisIBANfrom'validator/lib/isIBAN';isIBAN('GB29NWBK60161331926819',{blacklist: ['GB']})Error: IBANcodebelongstooneofthecountrieslistedonblacklist!

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)
References provided in PR (where applicable)

codecov · 2023-06-14T20:58:18Z

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4f63909) 99.95% compared to head (852c3fb) 99.95%.

❗ Current head 852c3fb differs from pull request most recent head bd34c0b. Consider uploading reports for the commit bd34c0b to get more accurate results

Additional details and impacted files

@@ Coverage Diff @@## master #2235 +/- ##
=======================================
Coverage 99.95% 99.95% =======================================
Files 107 107 Lines 2414 2431 +17 Branches 607 614 +7 =======================================
+ Hits 2413 2430 +17 
Partials 1 1

Impacted Files	Coverage Δ
src/lib/isIBAN.js	`100.00% <100.00%> (ø)`

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

WikiRik · 2023-06-18T10:22:33Z

 **isHexColor(str)** | check if the string is a hexadecimal color.
 **isHSL(str)** | check if the string is an HSL (hue, saturation, lightness, optional alpha) color based on [CSS Colors Level 4 specification][CSS Colors Level 4 Specification].<br/><br/>Comma-separated format supported. Space-separated format supported with the exception of a few edge cases (ex: `hsl(200grad+.1%62%/1)`).
-**isIBAN(str)** | check if the string is an IBAN (International Bank Account Number).
+**isIBAN(str)** | check if the string is an IBAN (International Bank Account Number).<br/><br/>Also allows you to define a whitelist, when you only want to recieve IBAN codes from certain countries or a blacklist, removing some of them from the current list.


Could you elaborate on how you can define this? Like we explain the options object in other validators as well. Also with the list of supported country codes

@WikiRik I have updated and put which attributes it will receive and also the values that can be used in each of them.

WikiRik

Can you undo the style changes in README?

…or without formatting it

edilson · 2023-06-26T17:58:09Z

@WikiRik do you think this could be merged now?

edilson · 2023-07-21T14:20:36Z

@pano9000 @profnandaa could you take a look on this feature, please?

profnandaa · 2023-07-24T13:09:51Z

+ const isoCountryCodeInWhiteList = options.whitelist.includes(isoCountryCode);
+
+ if (!isoCountryCodeInWhiteList) {
+ throw new Error('IBAN code does not belong to one of the countries listed on whitelist!');


nit: the pattern so far has not been to throw errors, just true/false. I'm not sure how to go about this one...

I guess we can continue with the true/false approach and let the user decide how to treat this.

Done @profnandaa

profnandaa

LGTM.

edilson · 2023-08-03T13:23:53Z

Thanks, folks

edilson · 2023-06-14T20:55:24Z

feat(isIBAN): add white and blacklist options to the isIBAN validator

In order to restrict the list of countries that I want to validate the IBAN against now we can pass the whitelist option with the country codes that I want to validate the code. Also if I want to remove a certain country from the validation now I will have the blacklist option and the countries passed there will be removed from validation.

So, if you use the isIBAN validator and pass a the whitelist option and the country from the IBAN code is not on the whitelist, it will return an error:

importisIBANfrom'validator/lib/isIBAN';isIBAN('GB29NWBK60161331926819',{whitelist: ['IT']})Error: IBANcodedoesnotbelongtooneofthecountrieslistedonwhitelist!

And if you use the same validator with the blacklist option it should return an error if the code passed is from one of the countries listed:

importisIBANfrom'validator/lib/isIBAN';isIBAN('GB29NWBK60161331926819',{blacklist: ['GB']})Error: IBANcodebelongstooneofthecountrieslistedonblacklist!

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)
References provided in PR (where applicable)

codecov · 2023-06-14T20:58:18Z

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4f63909) 99.95% compared to head (852c3fb) 99.95%.

❗ Current head 852c3fb differs from pull request most recent head bd34c0b. Consider uploading reports for the commit bd34c0b to get more accurate results

Additional details and impacted files

@@ Coverage Diff @@## master #2235 +/- ##
=======================================
Coverage 99.95% 99.95% =======================================
Files 107 107 Lines 2414 2431 +17 Branches 607 614 +7 =======================================
+ Hits 2413 2430 +17 
Partials 1 1

Impacted Files	Coverage Δ
src/lib/isIBAN.js	`100.00% <100.00%> (ø)`

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

WikiRik · 2023-06-18T10:22:33Z

 **isHexColor(str)** | check if the string is a hexadecimal color.
 **isHSL(str)** | check if the string is an HSL (hue, saturation, lightness, optional alpha) color based on [CSS Colors Level 4 specification][CSS Colors Level 4 Specification].<br/><br/>Comma-separated format supported. Space-separated format supported with the exception of a few edge cases (ex: `hsl(200grad+.1%62%/1)`).
-**isIBAN(str)** | check if the string is an IBAN (International Bank Account Number).
+**isIBAN(str)** | check if the string is an IBAN (International Bank Account Number).<br/><br/>Also allows you to define a whitelist, when you only want to recieve IBAN codes from certain countries or a blacklist, removing some of them from the current list.


Could you elaborate on how you can define this? Like we explain the options object in other validators as well. Also with the list of supported country codes

@WikiRik I have updated and put which attributes it will receive and also the values that can be used in each of them.

WikiRik

Can you undo the style changes in README?

…or without formatting it

edilson · 2023-06-26T17:58:09Z

@WikiRik do you think this could be merged now?

edilson · 2023-07-21T14:20:36Z

@pano9000 @profnandaa could you take a look on this feature, please?

profnandaa · 2023-07-24T13:09:51Z

+ const isoCountryCodeInWhiteList = options.whitelist.includes(isoCountryCode);
+
+ if (!isoCountryCodeInWhiteList) {
+ throw new Error('IBAN code does not belong to one of the countries listed on whitelist!');


nit: the pattern so far has not been to throw errors, just true/false. I'm not sure how to go about this one...

I guess we can continue with the true/false approach and let the user decide how to treat this.

Done @profnandaa

profnandaa

LGTM.

edilson · 2023-08-03T13:23:53Z

Thanks, folks

add white and blacklist options to the isIBAN validator
b76d131

improve coverage for isIBAN validator
53ecf0b

WikiRik reviewed Jun 18, 2023
View reviewed changes

WikiRik requested changes Jun 19, 2023
View reviewed changes

edilson force-pushed the master branch from 852c3fb to 53ecf0bCompare June 21, 2023 15:07

docs: add an explanation for the options object in the isIBAN validat…
e81e6d7
…or without formatting it

WikiRik approved these changes Jul 10, 2023
View reviewed changes

edilson mentioned this pull request Jul 19, 2023
feature: allow to blacklist or whitelist country codes in the IsIBAN decorator typestack/class-validator#2048
Closed

profnandaa added the 🎉 first-pr label Jul 24, 2023

profnandaa reviewed Jul 24, 2023
View reviewed changes

fix: remove errors from the isIBAN validator
bd34c0b

profnandaa approved these changes Aug 3, 2023
View reviewed changes

profnandaa merged commit f303d39 into validatorjs:masterAug 3, 2023

profnandaa mentioned this pull request Aug 3, 2023
maintenance: release 2308 prep - v13.11.0 #2252
Closed

rntvicente mentioned this pull request May 24, 2024
[Snyk] Upgrade validator from 13.5.2 to 13.11.0 rntvicente/ts-clean-architecture#25
Open

sahilpawar58 mentioned this pull request May 25, 2024
[Snyk] Upgrade validator from 13.6.0 to 13.11.0 sahilpawar58/Civil-Project#47
Open

ChinmoyHembram mentioned this pull request May 25, 2024
[Snyk] Upgrade validator from 13.7.0 to 13.11.0 ChinmoyHembram/Cocktail-recipel-site#260
Open

kaifkh20 mentioned this pull request May 30, 2024
[Snyk] Upgrade validator from 13.11.0 to 13.12.0 kaifkh20/community-app#22
Open

Safar123 mentioned this pull request May 30, 2024
[Snyk] Upgrade validator from 13.11.0 to 13.12.0 Safar123/Recipe_Manager#8
Open

IT21149412 mentioned this pull request May 30, 2024
[Snyk] Upgrade validator from 13.11.0 to 13.12.0 ReezanSaleem/Post-Management-Microservice#10
Open

Achmad-Farid mentioned this pull request May 30, 2024
[Snyk] Upgrade validator from 13.11.0 to 13.12.0 FS-8/Final-Project-Backend#8
Open

ahmetilboga2004 mentioned this pull request May 30, 2024
[Snyk] Upgrade validator from 13.11.0 to 13.12.0 ahmetilboga2004/ShortLink#14
Merged

wambugucoder mentioned this pull request May 30, 2024
[Snyk] Upgrade validator from 13.5.1 to 13.12.0 wambugucoder/MERN-STACK-APP-FCC-CHALLENGE#628
Open

TuanNB28 mentioned this pull request May 30, 2024
[Snyk] Upgrade validator from 13.11.0 to 13.12.0 TuanNB28/sdn301_project#4
Open

StemmlerSisters mentioned this pull request May 30, 2024
[Snyk] Upgrade validator from 13.11.0 to 13.12.0 StemmlerSisters/smee-client#2
Open

peterboni mentioned this pull request May 30, 2024
[Snyk] Upgrade validator from 13.11.0 to 13.12.0 peterboni/jarvis-api#4
Open

snyk-ioBot mentioned this pull request Jul 18, 2024
[Snyk] Upgrade validator from 13.5.2 to 13.12.0 DefenderK/nodejs-goof#114
Closed

DefenderK mentioned this pull request Jul 18, 2024
[Snyk] Upgrade validator from 13.5.2 to 13.12.0 DefenderK/nodejs-goof#116
Closed

This was referenced Jul 19, 2024
[Snyk] Upgrade validator from 13.5.2 to 13.12.0 DefenderK/nodejs-goof#119
Closed
[Snyk] Upgrade validator from 13.5.2 to 13.12.0 DefenderK/nodejs-goof#121
Closed
[Snyk] Upgrade validator from 13.5.2 to 13.12.0 DefenderK/nodejs-goof#123
Closed

vky5 mentioned this pull request Jul 30, 2024
[Snyk] Upgrade validator from 13.11.0 to 13.12.0 vky5/onspot#6
Closed

Playgirlkaybraz11 mentioned this pull request Aug 12, 2024
[Snyk] Upgrade validator from 13.11.0 to 13.12.0 Playgirlkaybraz11/lock#5
Open

luizhp mentioned this pull request Aug 21, 2024
[Snyk] Upgrade validator from 13.0.0 to 13.12.0 luizhp/template-api-tdd#8
Open

This was referenced Aug 30, 2024
[Snyk] Upgrade validator from 13.7.0 to 13.12.0 TheJ-Erk400/passbolt_browser_extension#11
Open
[Snyk] Upgrade validator from 13.7.0 to 13.12.0 TheJ-Erk400/passbolt_cli2#4
Open

TheJ-Erk400 mentioned this pull request Sep 7, 2024
[Snyk] Upgrade: , jssha, locutus, openpgp, papaparse, webextension-polyfill, passbolt-styleguide, validator TheJ-Erk400/passbolt_browser_extension#12
Open

sumandas0 mentioned this pull request Sep 8, 2024
[Snyk] Upgrade: lodash, cassandra-driver, validator sumandas0/Cassandra_node#32
Open

TheJ-Erk400 mentioned this pull request Sep 8, 2024
[Snyk] Upgrade: jssha, validator TheJ-Erk400/passbolt_cli2#6
Open

Bastien-Durand mentioned this pull request Sep 9, 2024
[Snyk] Upgrade: chalk, nodemon, validator Bastien-Durand/Node#68
Open

kaifkh20 mentioned this pull request Sep 9, 2024
[Snyk] Upgrade: dotenv, express, pg, validator, sequelize kaifkh20/community-app#24
Merged

This was referenced Sep 10, 2024
[Snyk] Upgrade: axios, react-router-dom, styled-components, swiper, validator MohammadGhajari/information-security#37
Open
[Snyk] Upgrade: axios, react-router-dom, styled-components, swiper, validator MohammadGhajari/information-security#38
Open

harish845 mentioned this pull request Sep 13, 2024
[Snyk] Upgrade: axios, dotenv, mongoose, nodemon, validator harish845/Secure-Software-Development-Project#2
Open

MohammadGhajari mentioned this pull request Sep 14, 2024
[Snyk] Upgrade: axios, react-router-dom, styled-components, swiper, validator MohammadGhajari/information-security#40
Open

harish845 mentioned this pull request Sep 14, 2024
[Snyk] Upgrade: axios, dotenv, mongoose, nodemon, validator harish845/Secure-Software-Development-Project#3
Open

vky5 mentioned this pull request Sep 15, 2024
[Snyk] Upgrade: express-rate-limit, mongoose, nodemailer, validator vky5/onspot#14
Closed

amay0808 mentioned this pull request Sep 16, 2024
[Snyk] Upgrade: jsonwebtoken, validator, winston amay0808/se_project_express#9
Open

IT21269134 mentioned this pull request Sep 17, 2024
[Snyk] Upgrade: dotenv, nodemon, validator IT21269134/Secure_Software_Development_Project---SightSense#2
Open

MohammadGhajari mentioned this pull request Sep 18, 2024
[Snyk] Upgrade: axios, iso-639-1, react-router-dom, styled-components, swiper, validator MohammadGhajari/information-security#41
Open

ch4mi2 mentioned this pull request Sep 19, 2024
[Snyk] Upgrade: bcrypt, bwip-js, dotenv, jsonwebtoken, moment, mongoose, nodemon, validator ch4mi2/Laboratory-Information-Management-System#5
Closed

MohammadGhajari mentioned this pull request Sep 19, 2024
[Snyk] Upgrade: axios, iso-639-1, react-router-dom, styled-components, swiper, validator MohammadGhajari/information-security#42
Open

pasanchamikara99 mentioned this pull request Sep 26, 2024
[Snyk] Upgrade validator from 13.11.0 to 13.12.0 pasanchamikara99/E-commerceWeb#18
Open

KOTTAGENVH mentioned this pull request Sep 27, 2024
[Snyk] Upgrade validator from 13.7.0 to 13.12.0 anjana-madushan/E-COMMERCE-WEB-APP-ITP-PROJ-#11
Open

DefenderK mentioned this pull request Oct 30, 2024
[Snyk] Upgrade validator from 13.5.2 to 13.12.0 DefenderK/nodejs-goof#132
Closed

fossabotBot mentioned this pull request Oct 28, 2025
Bump validator from 13.7.0 to 13.15.20 in /ui UchihaCortez/conductor#6
Closed