Conversation
The length passed to connRdmaHandleRecvImm() is the immediate value chosen by the peer, but it was only checked with an assertion, which is elided with -DNDEBUG. Check it against the space remaining in the receive buffer and return an error instead, comparing against the space left rather than summing since byte_len + rx_offset can wrap. Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Collaborator
Author
|
@pizhenwei Does this seem right? |
pizhenwei
approved these changes
Sep 18, 2026
pizhenwei
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
RdmaContext *ctx = c->privctx;, so only valkeyContext *c is also fine for connRdmaHandleRecvImm. Both styles are fine to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The length passed to
connRdmaHandleRecvImm()is the immediate value chosen by the peer, but it was only checked with an assertion, which is elided with-DNDEBUG.Check it against the space remaining in the receive buffer and return an error instead, comparing against the space left rather than summing since
byte_len + rx_offsetcan wrap.Found during an assert inventory to identify asserts that can be externally triggered.