Uh oh!
There was an error while loading. Please reload this page.
Add langchain standard integration tests - #5
Conversation
2adca13 to
89fcebcCompare0810afa to
6b2a922Compare5edc0b3 to
d865eddCompare| raise RuntimeError(msg) | ||
| time.sleep(1) | ||
| docs = retriever.invoke( |
There was a problem hiding this comment.
we should keep the retries
There was a problem hiding this comment.
The idea is to have the retries in the setup (in the pipeline_id fixture).
Is there a possibility that retrieving docs fails after it has succeeded once ?
There was a problem hiding this comment.
No, in that case it's a different issue and we should fail
There was a problem hiding this comment.
What issue could arise ?
I find it not stable to have an API succeed on one call, then fail on the next one...
There was a problem hiding this comment.
Also the goal of this PR is to add the LangChain integration tests and these don't do retries.
There was a problem hiding this comment.
The idea is to have the retries in the setup (in the pipeline_id fixture).
Note that the retries in the fixture are not on the pipeline creation request but on a doc retrieval request, similar to the one that will be done in the tests just afterwards.
26ba852 to
9d22c08Compareff7c4ef to
bbcb61bCompare
No description provided.