Skip to content

[FIX]: Make parameter opts optional again. - #66

Merged
lucleray merged 1 commit into
vercel:masterfrom
yeldiRium:fix-optional-opts
Jan 2, 2020
Merged

[FIX]: Make parameter opts optional again.#66
lucleray merged 1 commit into
vercel:masterfrom
yeldiRium:fix-optional-opts

Conversation

@yeldiRium

Copy link
Copy Markdown
Contributor

Hi everyone,

with the release of v1.3.0 the parameter opts became mandatory because of this block. Since it checks the original opts instead of the modified options, not passing opts breaks retry.

To commit this change I had to disable the commit hook, since the var declaration not at the top of the function goes against the linter rules, but I thought I should let you decide on how to deal with your code style.

This PR will still break your CI pipeline because of the linter, but the unit tests now pass again.

Kind regards,
yeldiR

@vercel

vercel Bot commented Jan 2, 2020

Copy link
Copy Markdown

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click on the icon next to each commit.

@vercel
vercel Bot requested a deployment to Preview January 2, 2020 12:32 Abandoned
@vercel

vercel Bot commented Jan 2, 2020

Copy link
Copy Markdown

Deployment failed with the following error:

Your `package.json` file is missing a `build` property inside the `scripts` property.

@joecohens joecohens left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yeldiRium!

@lucleray
lucleray merged commit 9b05890 into vercel:master Jan 2, 2020
@lucleray

lucleray commented Jan 2, 2020

Copy link
Copy Markdown
Member

Thanks for reporting and fixing @yeldiRium!

@lucleray

lucleray commented Jan 2, 2020

Copy link
Copy Markdown
Member

Release in 1.3.1.

@yeldiRium
yeldiRium deleted the fix-optional-opts branch January 2, 2020 18:38
@yeldiRium

Copy link
Copy Markdown
Contributor Author

Thanks for the quick reply and release of a new version :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants