[FIX]: Make parameter opts optional again. - #66
Merged
Conversation
|
This pull request is being automatically deployed with ZEIT Now (learn more). |
|
Deployment failed with the following error: |
lucleray
approved these changes
Jan 2, 2020
Member
|
Thanks for reporting and fixing @yeldiRium! |
Member
|
Release in 1.3.1. |
Contributor
Author
|
Thanks for the quick reply and release of a new version :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi everyone,
with the release of v1.3.0 the parameter
optsbecame mandatory because of this block. Since it checks the originaloptsinstead of the modifiedoptions, not passingoptsbreaksretry.To commit this change I had to disable the commit hook, since the var declaration not at the top of the function goes against the linter rules, but I thought I should let you decide on how to deal with your code style.
This PR will still break your CI pipeline because of the linter, but the unit tests now pass again.
Kind regards,
yeldiR