Skip to content

Import config with POSIX path - #728

Merged
dominiksipowicz merged 1 commit into
vercel:mainfrom
markuslewin:windows-import-config
Apr 13, 2022
Merged

Import config with POSIX path#728
dominiksipowicz merged 1 commit into
vercel:mainfrom
markuslewin:windows-import-config

Conversation

@markuslewin

Copy link
Copy Markdown
Contributor

There seems to be an issue in Node.js when importing modules declared in the exports field of a package.json using Windows paths.

Importing a configuration with @vercel/commerce-local/next-config works, but @vercel\commerce-local\next-config (as returned by path.join on Windows systems) does not.

One possible workaround is to use path.posix.join to make sure that the imported path is specified as a POSIX path.

This PR should solve #681.
The exports problem might be related to nodejs/node#30169.

@vercel

vercelBot commented Apr 6, 2022

Copy link
Copy Markdown
Contributor

@markuslewin is attempting to deploy a commit to the Vercel Solutions Team on Vercel.

A member of the Team first needs to authorize it.

@vercel

vercelBot commented Apr 6, 2022

Copy link
Copy Markdown
Contributor

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

commerce-local – ./site

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-local/Ewhpzw6mp5Gg7Qv4QtmFmr4dznHF
✅ Preview: https://commerce-local-git-fork-markus-5ea489-vercel-solutions-vtest314.vercel.app

commerce-saleor – ./site

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-saleor/5pzW1ikBmPpAZvSvoqMwMbiRxgyw
✅ Preview: https://commerce-saleor-git-fork-marku-869769-vercel-solutions-vtest314.vercel.app

commerce-bigcommerce – ./site

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-bigcommerce/25cLRxkAfTAQPL1edPsWvcRbyrPs
✅ Preview: https://commerce-bigcommerce-git-fork-d3902a-vercel-solutions-vtest314.vercel.app

commerce-shopify – ./site

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-shopify/85NxefqhA4d7Sh7kvRDhZ3oFE2M3
✅ Preview: https://commerce-shopify-git-fork-mark-7f42b5-vercel-solutions-vtest314.vercel.app

commerce-vendure – ./site

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-vendure/4UtdYPuGaY9554BcVRmMbnsGo56m
✅ Preview: https://commerce-vendure-git-fork-mark-758518-vercel-solutions-vtest314.vercel.app

commerce-swell – ./site

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-swell/E8ffKqMNnVLGi5NPpxuRjJ7o8aAv
✅ Preview: https://commerce-swell-git-fork-markus-96343e-vercel-solutions-vtest314.vercel.app

commerce-spree – ./site

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-spree/9GtddCbmWoP12f1ck7v3AZwVJkeq
✅ Preview: https://commerce-spree-git-fork-markus-54ca5e-vercel-solutions-vtest314.vercel.app

commerce-commercejs – ./site

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-commercejs/8LGScdqyKr3sAzbjti1bhM32hMer
✅ Preview: https://commerce-commercejs-git-fork-m-7fba8d-vercel-solutions-vtest314.vercel.app

commerce-kibocommerce – ./site

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-kibocommerce/BDGAk3UBXHr9YfBxZ7zCVVvBrCBb
✅ Preview: https://commerce-kibocommerce-git-fork-94c6cd-vercel-solutions-vtest314.vercel.app

commerce-ordercloud – ./site

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/commerce-ordercloud/GnU79qo7EwkdUB9gFzRJt6tSwa6F
✅ Preview: https://commerce-ordercloud-git-fork-m-6836f1-vercel-solutions-vtest314.vercel.app

@ShaffanShaffan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Can confirm this is working on my windows machine 👍🏻

Thanks for this!

@dominiksipowicz
dominiksipowicz merged commit acf14b8 into vercel:mainApr 13, 2022
@dominiksipowicz

Copy link
Copy Markdown
Member

@markuslewin thank you for this contribution. Amazing! 🪟🛫🚀

vannguyenn pushed a commit to reactioncommerce/commerce that referenced this pull request Apr 25, 2022
Signed-off-by: Chloe <pinkcloudvnn@gmail.com>
vannguyenn pushed a commit to reactioncommerce/commerce that referenced this pull request Apr 25, 2022
Signed-off-by: Chloe <pinkcloudvnn@gmail.com>
vannguyenn pushed a commit to reactioncommerce/commerce that referenced this pull request Apr 26, 2022
Signed-off-by: Chloe <pinkcloudvnn@gmail.com>
vannguyenn pushed a commit to reactioncommerce/commerce that referenced this pull request Apr 26, 2022
Signed-off-by: Chloe <pinkcloudvnn@gmail.com>
loan-laux pushed a commit to TrellisCommerce/next-commerce-bigcommerce that referenced this pull request May 11, 2023
djahlor pushed a commit to djahlor/commerce that referenced this pull request Apr 23, 2025
anhdd-kuro pushed a commit to anhdd-kuro/vercel_commerce that referenced this pull request Apr 8, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@markuslewin@dominiksipowicz@lfades@Shaffan