Uh oh!
There was an error while loading. Please reload this page.
[openfeature] allow recovering from bad init - #474
Merged
Conversation
Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
|
AndyBitz
approved these changes
Aug 13, 2026
dferber90
marked this pull request as ready for review
August 13, 2026 19:31
Uh oh!
There was an error while loading. Please reload this page.
Merged
dferber90 added a commit
that referenced
this pull request
Aug 15, 2026
The adapter had no shutdown mechanism. close() now reverts it to its uninitialized state, so the next evaluation initializes it again, per section 2.5 of the OpenFeature provider spec. It first awaits an initialization that is still in flight, so the client that initialization produces is disposed rather than leaked, and it is idempotent. Provider disposal is opt-in through the new onClose option, because the adapter cannot do it on its own: an OpenFeature client has no close of its own, and shutting down providers means closing them on the global OpenFeature API, which would also affect providers this adapter never registered. Follow-up to #474, which fixed#473. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes#473