Skip to content

Remove un-helpful error in with-sentry example - #36902

Merged
kodiakhq[bot] merged 1 commit into
vercel:canaryfrom
ijjk:example/with-sentry
May 13, 2022
Merged

Remove un-helpful error in with-sentry example#36902
kodiakhq[bot] merged 1 commit into
vercel:canaryfrom
ijjk:example/with-sentry

Conversation

@ijjk

@ijjkijjk commented May 13, 2022•
edited
Loading

Copy link
Copy Markdown
Member

The error reported here is unclear and un-helpful so we shouldn't be recommending to report this by default.

x-ref: slack thread

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjkijjk added examples Issue was opened via the examples template. created-by: Next.js team PRs by the Next.js team. labels May 13, 2022
leerob
leerob approved these changes May 13, 2022
View reviewed changes

@leerobleerob left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kodiakhq
kodiakhqBot merged commit 167a91b into vercel:canaryMay 13, 2022
@ijjk
ijjk deleted the example/with-sentry branch May 14, 2022 03:06
@smeubanksmeubank mentioned this pull request May 19, 2022
Closed
@github-actionsgithub-actionsBot locked as resolved and limited conversation to collaborators Jun 13, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@huozhihuozhihuozhi approved these changes
@timneutkenstimneutkensAwaiting requested review from timneutkens
@shudingshudingAwaiting requested review from shuding
@steven-teysteven-teyAwaiting requested review from steven-tey
@balazsorban44balazsorban44Awaiting requested review from balazsorban44
+1 more reviewer
@leerobleerobleerob approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

created-by: Next.js teamPRs by the Next.js team.examplesIssue was opened via the examples template.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ijjk@huozhi@leerob