Uh oh!
There was an error while loading. Please reload this page.
[bench skill] Bench Edge builds of React too - #96234
Merged
Merged
Conversation
Contributor
Stats skippedCommit: 94cf70e |
Contributor
Tests PassedCommit: 94cf70e |
The e2e suite only measures the Node path through a Next.js app. sandbox-ssr.mjs adds the react repo's flight-ssr-bench fixture as a second suite: 8 variants (Fizz and Flight+Fizz x Node and Edge web streams x sync/async), sequential-with-injection plus an HTTP server at c=1/c=10, paired ABBA in the same VM, CPU profiles after the timed runs, same results db and boot-level stats. The fixture is pinned to one ref for both arms; PR edits to it are flagged, not silently benched. React PRs run both suites. bench-common.mjs carries the launcher-independent core (sandbox plumbing, PR/arm resolution with the CI gate, cached react arm builds, snapshots, recovery record, live estimates); sandbox-e2e's dry-run verified byte-identical across the extraction. sbExec now verifies the remote exit itself via an EXIT-trap marker (the CLI can return 0 after a remote failure — observed live). A/A validated with a two-run criterion scaled to suite size (methodology.md). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
gaearonforce-pushed
the
bench/sandbox-bench-ssr
branch
from
July 25, 2026 23:43
c0f5e46 to
94cf70eComparegaearon added a commit
to react/react
that referenced
this pull request
Jul 26, 2026
Things I found while integrating this bench into vercel/next.js#96234. See code. --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
gaearon
marked this pull request as ready for review
July 30, 2026 18:30
timneutkens
approved these changes
Jul 30, 2026
Uh oh!
There was an error while loading. Please reload this page.
m-kawafuji pushed a commit
to m-kawafuji/next.js
that referenced
this pull request
Aug 8, 2026
Extends the bench to run the edge versions of React SSR fixture. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the bench to run the edge versions of React SSR fixture.