Uh oh!
There was an error while loading. Please reload this page.
fix(web): move react-router deps to devDependencies - #1265
Merged
Conversation
🦋 Changeset detectedLatest commit: de1c8b8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 25 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express workflow with 50 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express Promise.all with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express Promise.race with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro Stream Benchmarks(includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests🌍 Community Worlds (56 failed)mongodb (3 failed):
redis (2 failed):
turso (51 failed):
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
✅ 📋 Other
|
Contributor
There was a problem hiding this comment.
Pull request overview
Moves React Router runtime dependencies in @workflow/web from devDependencies to dependencies to address missing peer dependency warnings seen when workflow consumers install the published package.
Changes:
- Add
react-routerand@react-router/expresstopackages/webproductiondependencies. - Remove redundant
@react-router/node/react-routerentries frompackages/webdevDependencies. - Add a Changeset and update
pnpm-lock.yamlaccordingly.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
packages/web/package.json | Shifts React Router-related packages into production dependencies for published installs. |
pnpm-lock.yaml | Lockfile updates reflecting dependency graph changes for packages/web. |
.changeset/fix-web-missing-peer-deps.md | Publishes a patch release note for @workflow/web describing the dependency fix. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Uh oh!
There was an error while loading. Please reload this page.
TooTallNateforce-pushed
the
fix/web-missing-peer-deps
branch
from
March 10, 2026 07:33
51b35d3 to
22ba529CompareAdd a custom entry.server.tsx (based on the default react-router template) so that the @react-router/dev build plugin no longer requires @react-router/node and isbot to be in the dependencies field of package.json. This allows all react-router related packages to be devDependencies since they are fully bundled at build time, leaving express as the sole production dependency.
TooTallNateforce-pushed
the
fix/web-missing-peer-deps
branch
from
March 10, 2026 07:41
238e760 to
6f7db38Compare@react-router/node and isbot to devDependenciesUh oh!
There was an error while loading. Please reload this page.
VaguelySerious
approved these changes
Mar 11, 2026
VaguelySerious
left a comment
Member
There was a problem hiding this comment.
LGTM, note we should add a comment
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Peter Wielander <mittgfu@gmail.com> Signed-off-by: Nathan Rajlich <n@n8.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app/entry.server.tsx(based on the default react-router template) so the@react-router/devbuild plugin no longer requires@react-router/nodeandisbotin thedependenciesfield ofpackage.json@react-router/nodeandisbotfromdependenciestodevDependencies— they are fully bundled into the server output at build time (Vite SSR withnoExternal: true)expressis now the sole production dependency, eliminating peer dependency warnings from transitivereact-routerpeer deps