Uh oh!
There was an error while loading. Please reload this page.
test: improve e2e test failure diagnostics - #1426
Merged
Merged
Conversation
…b annotations When e2e tests fail, automatically dump workflow run diagnostics (status, input/output, error details, event timeline, dashboard link) to the CI logs. Emit GitHub Actions annotations that surface on PR file diffs. Fix collectedRunIds which was declared but never populated, enabling observability links in the PR comment. Enrich the aggregation script to include run IDs and dashboard URLs for failed tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
🦋 Changeset detectedLatest commit: c82f089 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests▲ Vercel Production (1 failed)express (1 failed):
🐘 Local Postgres (2 failed)express-stable (1 failed):
nextjs-turbopack-stable (1 failed):
🌍 Community Worlds (55 failed)mongodb (2 failed):
redis (2 failed):
turso (51 failed):
Details by Category❌ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
❌ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
✅ 📋 Other
❌ Some E2E test jobs failed:
Check the workflow run for details. |
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 25 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 50 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express Promise.all with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro Promise.race with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Stream Benchmarks(includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
- Increase onTestFailed hook timeout to 30s (default was 10s) so diagnostics can fetch run data even after slow test timeouts - parallelSleepWorkflow: increase elapsed threshold from 10s to 25s to accommodate Vercel cold start latency - webhookWorkflow: increase hook polling deadline from 30s to 60s and test timeout from 60s to 120s for slow Vercel webhook registration - readableStreamWorkflow: stop reading once expected content is received instead of waiting for stream close (which can hang on Vercel), and increase test timeout to 120s Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…rces The workflow source files in workbench/ are symlinks that GitHub can't resolve, causing annotations to show raw paths like #L0 instead of linking to code. Now: - utils.ts: omit file= from onTestFailed annotations (just show title) - github-reporter.ts: use the actual test file path (e.g. packages/core/e2e/e2e.test.ts) which GitHub can resolve Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
VaguelySerious
approved these changes
Mar 18, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Improves CI/e2e failure diagnostics by tracking workflow run IDs per test, emitting GitHub Actions annotations, and enriching the aggregation script output with run metadata and observability links.
Changes:
- Add run tracking + automatic diagnostics dump on test failures (status/input/output/error + event timeline + dashboard URL).
- Add a custom Vitest reporter that emits
::errorannotations and writes enriched failure sidecar JSON. - Update CI workflows and the aggregation script to consume/upload new sidecar artifacts and render run IDs/URLs in PR summaries.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/e2e/utils.ts | Adds run tracking, diagnostics fetching, and CI annotations on test failure. |
| packages/core/e2e/github-reporter.ts | New Vitest reporter emitting GitHub annotations + failure sidecar JSON. |
| packages/core/e2e/e2e.test.ts | Wraps start() to auto-track runs; writes metadata + diagnostics sidecar; adjusts a few flaky test timeouts/stream reading. |
| packages/core/e2e/e2e-agent.test.ts | Adds tracking hooks and wraps start() to record runs for diagnostics. |
| .github/workflows/tests.yml | Adds custom reporter to e2e runs; uploads new sidecar artifacts for vercel-prod. |
| .github/workflows/e2e-community-world.yml | Adds custom reporter to community-world e2e runs. |
| .github/scripts/aggregate-e2e-results.js | Loads sidecar diagnostics/failures and prints run IDs/observability URLs in aggregated output. |
| .changeset/fresh-rocks-reply.md | Adds a new changeset file (currently empty). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+1
to
+2
| --- | ||
| --- |
Comment on lines
+668
to
+688
| export function setupRunTracking(testName: string) { | ||
| currentTestName = testName; | ||
| trackedRuns = []; | ||
| onTestFailed( | ||
| async (result) => { | ||
| const errorMessage = result.errors?.[0]?.message || 'Test failed'; | ||
| for (const tracked of trackedRuns) { | ||
| try { | ||
| const diagnostics = await getRunDiagnostics(tracked); | ||
| console.error(diagnostics); | ||
| emitGitHubAnnotation(testName, tracked, errorMessage); | ||
| } catch { | ||
| console.error( | ||
| `[diagnostics] Failed to fetch diagnostics for run ${tracked.run.runId}` | ||
| ); | ||
| } | ||
| } | ||
| }, | ||
| 30_000 // Allow 30s for diagnostics fetching (default hookTimeout is 10s) | ||
| ); |
Comment on lines
+652
to
+658
| const annotation = parts.join(' | '); | ||
| // Write directly to stdout bypassing vitest's console interceptor. | ||
| // Vitest prefixes console.log output with ANSI codes which prevents | ||
| // GitHub Actions from parsing the ::error workflow command. | ||
| process.stdout.write(`\n::error title=E2E: ${testName}::${annotation}\n`); | ||
| } |
Comment on lines
+36
to
+40
| private ctx!: Vitest; | ||
| private failedTests: FailedTestInfo[] = []; | ||
| onInit(ctx: Vitest) { | ||
| this.ctx = ctx; |
Comment on lines
+149
to
+154
| process.stdout.write( | ||
| `\n::error file=${relFile},title=${title}::${body}\n` | ||
| ); | ||
| } | ||
| } | ||
Comment on lines
+118
to
+126
| const byTestName = new Map(entries.map((e) => [e.testName, e])); | ||
| for (const test of this.failedTests) { | ||
| if (test.runId && test.dashboardUrl) continue; // Already have data from error output | ||
| const diag = byTestName.get(test.testName); | ||
| if (diag) { | ||
| test.runId ??= diag.runId; | ||
| test.dashboardUrl ??= diag.dashboardUrl ?? undefined; | ||
| } |
| const entries = JSON.parse(fs.readFileSync(file, 'utf-8')); | ||
| for (const entry of entries) { | ||
| if (entry.testName && entry.runId) { | ||
| diagnostics.set(entry.testName, entry); |
Comment on lines
49
to
+55
| beforeAll(async () => { | ||
| setupWorld(deploymentUrl); | ||
| }); | ||
| beforeEach((ctx) => { | ||
| setupRunTracking(ctx.task.name); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
::errorannotations that surface on PR file diffs pointing at the workflow sourcecollectedRunIdswhich was declared but never populated — observability links in PR comments now workGithubAnnotationReporterthat writes enriched failure sidecar filesTest plan
🤖 Generated with Claude Code