Uh oh!
There was an error while loading. Please reload this page.
fix(next): stabilize deferred canary e2e in nextjs workbenches - #1468
Merged
Conversation
🦋 Changeset detectedLatest commit: a25e1b2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express workflow with 25 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro workflow with 50 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro Promise.all with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.race with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 10 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express workflow with 25 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 50 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 10 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 25 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 50 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express Stream Benchmarks(includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) stream pipeline with 5 transform steps (1MB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) 10 parallel streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) fan-out fan-in 10 streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests🌍 Community Worlds (56 failed)mongodb (3 failed):
redis (2 failed):
turso (51 failed):
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
✅ 📋 Other
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
VaguelySerious
commented
Mar 22, 2026
Member
Awesome! Will look at this tomorrow |
VaguelySerious
approved these changes
Mar 22, 2026
VaguelySerious
left a comment
Member
There was a problem hiding this comment.
Asking for forward compat: we have some users wanting to use lazy imports (#608), which I think don't work with this approach. Would we still want to allow hardcoding a directly for checking for imports, as an optional setting?
Also, this PR probably improves #448 and #1179, but unsure.
I did some digging and there's some other issues I'm not sure are related/affected, could you check? #1374 (step registry), #817 (discovery and "use server" issues), #724 (.md loader)
Separately, feedback from AI here. Is this a valid concern?
The system relies on a timing assumption: all loader socket notifications must arrive and be processed before onBeforeDeferredEntries() reads the discovered sets. If Next.js calls the deferred callback before all loaders have reported (e.g. parallel compilation where some workers are slower), files could be missed. In watch mode this self-heals (the next scheduleDeferredRebuild catches them). In production, it's one shot.
MemberAuthor
The dynamic requiring workflows issue doesn't work with Next.js' or esbuild's bundling in general this isn't specific to deferred building since The microfrontends PR seems unrelated so don't think this will impact there. The esbuild one does seem related and this would alleviate if they opt-in and are compatible version of Next.js to use deferred mode. The non-local world one looks like a quirk with the world they are using relying on some initializing to take place that local world does not. The use server one could be alleviated by this bundling change similar to the esbuild one since it would use proper turbopack/webpack The markdown one is related and was one of the early issues that would be resolved using deferred mode since no esbuild handling for the markdown files.
If this occurs it's a bug in Next.js' handling which we have e2e tests against. |
okueng
commented
Mar 26, 2026
it didn't improve for #1179 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deferred build stabilization (canary)
keepInterimBundleContext: false) to avoid context buildup in canary watch mode.Validation
nextjs-turbopack(Next.js canary): repeatedpackages/core/e2e/dev.test.tsruns passed.nextjs-webpack(Next.js canary):packages/core/e2e/dev.test.tspassed.Brief summary:
test:e2efor bothworkbench/nextjs-webpackandworkbench/nextjs-turbopackwithNEXT_CANARY=1.x-ref: #1400
This reverts commit a2c0c7e.
Edited by Peter (@VaguelySerious):
Closes#523
Closes#691
Closes#525
See also:
#406
#469
#448
#1179
#608
#1374
#817
#724
#1478