Uh oh!
There was an error while loading. Please reload this page.
[builders] Fix transitive local TS dep externalization in step bundles - #1609
Closed
VaguelySerious wants to merge 5 commits into
Closed
[builders] Fix transitive local TS dep externalization in step bundles#1609VaguelySerious wants to merge 5 commits into
VaguelySerious wants to merge 5 commits into
Conversation
Contributor
🦋 Changeset detectedLatest commit: f624c37 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests▲ Vercel Production (2 failed)fastify (1 failed):
sveltekit (1 failed):
💻 Local Development (1 failed)nextjs-webpack-stable-lazy-discovery-disabled (1 failed):
📦 Local Production (1 failed)nextjs-webpack-stable-lazy-discovery-disabled (1 failed):
🐘 Local Postgres (2 failed)nextjs-webpack-stable-lazy-discovery-disabled (2 failed):
📋 Other (2 failed)e2e-local-prod-nest-stable (1 failed):
e2e-local-prod-tanstack-start- (1 failed):
Details by Category❌ ▲ Vercel Production
❌ 💻 Local Development
❌ 📦 Local Production
❌ 🐘 Local Postgres
✅ 🪟 Windows
❌ 📋 Other
❌ Some E2E test jobs failed:
Check the workflow run for details. |
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) workflow with 25 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) workflow with 50 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) Promise.all with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) Promise.race with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro workflow with 10 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) workflow with 25 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) workflow with 50 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) workflow with 10 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro workflow with 25 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro workflow with 50 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro Stream Benchmarks(includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro stream pipeline with 5 transform steps (1MB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro 10 parallel streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) fan-out fan-in 10 streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
❌ Some benchmark jobs failed:
Check the workflow run for details. |
VaguelySerious
marked this pull request as ready for review
May 2, 2026 01:17
TooTallNate
approved these changes
May 2, 2026
TooTallNate
left a comment
Member
There was a problem hiding this comment.
Two well-targeted fixes for the same underlying problem (transitive local TS deps not getting bundled). Verified each piece:
Discover plugin resolver config. The previous promisify(enhancedResolveOriginal) used the library's defaults, which don't include TS extensions. So await enhancedResolve(args.resolveDir, './helpers') would fail when the file is helpers.ts, the if (resolved) branch never fired, and importParents stayed empty for that edge. The new enhancedResolveOriginal.create({ extensions: [...], ... }) config matches the swc plugin's resolver, with the right comment explaining why ("important for parentHasChild() graph lookups"). The added symlinks: true is also subtly important for monorepo setups where local packages resolve via symlinks.
Swc plugin descendant check. The old parentHasChild(normalizedResolvedPath, normalizedEntry) check only handled "this file is an ancestor of an entry," which catches top-level wrappers but misses "this file is a transitive child of an entry" — exactly the helpers/constants case. The new inverse check fixes that with a clear comment.
Tests are well-targeted. Confirmed by reverting just the two production files on this branch and re-running the new tests — both fail without the fix:
discover-entries-esbuild-plugin.test.ts"tracks extensionless relative imports" fails becauseimportParents.get(workflow).has(constants)returnsfalse.swc-esbuild-plugin.test.ts"bundles transitive local dependencies" fails because the output containsimport { MSG } from "../shared/constants.ts"instead of the inlined"world".
So the tests are validating the bug, not just exercising the new code path. All 137 builder tests pass on the branch.
Discovery runs first in production. Verified base-builder.ts:244-260 runs createDiscoverEntriesPlugin in its own esbuild pass before any createSwcPlugin pass. So importParents is populated by the time the new descendant check runs.
PR description's note about broadening onResolve filter from jsTsRegex to /.*/ doesn't match the diff — that change is already on main from an earlier commit. Probably worth tightening the description, but no behavior issue.
Two issues caused local transitive dependencies to be externalized instead of bundled in step/workflow bundles: 1. The discover-entries plugin's onResolve filter only matched imports with explicit file extensions (jsTsRegex). Extensionless imports like `./helpers` were never tracked in the import graph. 2. The swc plugin only checked if a file was an ancestor of an entry (parentHasChild(resolved, entry)) but never checked if it was a descendant (parentHasChild(entry, resolved)). So even with a correct import graph, transitive local deps got externalized. Fixes: configure enhanced-resolve with TS extensions, broaden the onResolve filter to catch all relative imports, and add the reverse parentHasChild check. Add explicit symlinks: true to the discover-entries resolver to align with swc-esbuild-plugin's NODE_ESM_RESOLVE_OPTIONS for monorepos with symlinked packages. Closes#1179 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes#1179
Fixes transitive local TypeScript dependencies being externalized instead of bundled in step/workflow bundles, which caused native ESM crashes in Nuxt dev (and other frameworks) when extensionless relative imports like
./helperscouldn't be resolved by Node.Root cause (two issues):
onResolvefilter only matched imports with explicit file extensions (jsTsRegex). Extensionless imports like./helperswere never tracked inimportParents, leaving the dependency graph incomplete.parentHasChild(resolved, entry)), but never checked if it was a descendant (parentHasChild(entry, resolved)). So even with a correct import graph, transitive local deps got externalized.Fix:
enhanced-resolvein the discover plugin with TS extensions so extensionless imports resolve correctlyonResolvefilter fromjsTsRegexto/^[./]/(relative imports only) to track extensionless local depsparentHasChild(entry, resolved)check in the swc plugin so descendants of entries are bundledTest plan
discover-entries-esbuild-plugin.test.tsswc-esbuild-plugin.test.ts🤖 Generated with Claude Code