Uh oh!
There was an error while loading. Please reload this page.
Gitignore public workflow manifests - #1683
Merged
VaguelySerious merged 6 commits intoMay 22, 2026
Merged
Conversation
Contributor
Contributor
🧪 E2E Test Results✅ All tests passed Summary
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
✅ 📋 Other
|
🦋 Changeset detectedLatest commit: 136eec6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro workflow with 25 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro workflow with 50 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro Promise.all with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) Promise.race with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) workflow with 10 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) workflow with 25 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) workflow with 50 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) workflow with 10 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) workflow with 25 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro workflow with 50 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro Stream Benchmarks(includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) stream pipeline with 5 transform steps (1MB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro 10 parallel streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) fan-out fan-in 10 streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
❌ Some benchmark jobs failed:
Check the workflow run for details. |
pranaygp
marked this pull request as draft
April 10, 2026 05:52
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the builders to write .gitignore files next to generated custom workflow manifest outputs (instead of editing a repo root ignore), and aligns manifest path resolution with the builder workingDir. Also updates the example app to emit the custom manifest under .well-known/workflow/manifest.js.
Changes:
- Add
ensureGeneratedFileGitignore()(with tests) to create/append a colocated.gitignoreentry for generated manifests. - Resolve
workflowManifestPathrelative toworkingDirand invoke the new gitignore writer after emitting the manifest. - Move the example app’s custom manifest output from root
manifest.jsto.well-known/workflow/manifest.js, removing the old ignore/output wiring.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| workbench/example/turbo.json | Removes root manifest.js from Turbo build outputs to match the new manifest location. |
| workbench/example/package.json | Updates example build script to output the manifest under .well-known/workflow/manifest.js. |
| workbench/example/.gitignore | Removes root-level manifest.js ignore since it’s no longer generated there. |
| packages/builders/src/gitignore.ts | New helper that writes/updates colocated .gitignore files for generated outputs. |
| packages/builders/src/gitignore.test.ts | Adds Vitest coverage for the colocated .gitignore behavior. |
| packages/builders/src/base-builder.ts | Resolves manifest paths via workingDir and calls the new gitignore helper after writing the manifest. |
| .changeset/ignore-generated-manifest.md | Changeset entry for the @workflow/builders patch release. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+25
to
+33
| const resolvedWorkingDir = resolve(workingDir); | ||
| const resolvedFilePath = resolve(resolvedWorkingDir, filePath); | ||
| const relativePath = normalizeRelativePath( | ||
| relative(resolvedWorkingDir, resolvedFilePath) | ||
| ); | ||
| if (!relativePath || isOutsideRoot(relativePath)) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
(AI) AI Review: Note
Obsolete — the gitignore.ts helper this comment references was removed in 2ac6942, when the approach simplified to writing .gitignore directly inside each builder. No action needed.
Comment on lines
+40
to
+55
| const gitignorePath = join(outputDir, '.gitignore'); | ||
| const entry = basename(resolvedFilePath); | ||
| let existing = ''; | ||
| try { | ||
| existing = await readFile(gitignorePath, 'utf8'); | ||
| } catch (error) { | ||
| if ((error as NodeJS.ErrnoException).code !== 'ENOENT') { | ||
| throw error; | ||
| } | ||
| } | ||
| const lines = existing.split(/\r?\n/).map((line) => line.trim()); | ||
| if (lines.includes('*') || lines.includes(entry) || lines.includes(`/${entry}`)) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
(AI) AI Review: Note
Obsolete — the gitignore.ts helper this comment references was removed in 2ac6942, when the approach simplified to writing .gitignore directly inside each builder. No action needed.
VaguelySerious
left a comment
Member
There was a problem hiding this comment.
(AI) AI review: no blocking issues
VaguelySerious
approved these changes
May 22, 2026
Contributor
Backport PR opened against |
This was referenced May 22, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.gitignorefiles into the public/static manifest output directories created whenWORKFLOW_PUBLIC_MANIFEST=1.well-known/workflowoutputs instead of touching the project root.gitignoreCloses #1521