Uh oh!
There was an error while loading. Please reload this page.
fix(next): resolve next/package.json from working directory first - #1701
Merged
Conversation
In npm workspaces monorepos, `@workflow/next` can be hoisted to the root
`node_modules/` while `next` stays in a workspace's local `node_modules/`.
The eager `require('next/package.json')` on the fallback path resolved
relative to `@workflow/next`'s own location, failing before the correct
working-directory-relative resolution could run.
Restructure `resolveNextVersion()` to try the working directory path first,
fall back to the package-relative path second, and wrap both in separate
try/catch blocks so neither can crash the process.
Closes#1680Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 5a6bd75 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
workflow with 1 step💻 Local Development
▲ Production (Vercel)
workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
workflow with 25 sequential steps💻 Local Development
▲ Production (Vercel)
workflow with 50 sequential steps💻 Local Development
▲ Production (Vercel)
Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
Promise.all with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
Promise.race with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
workflow with 10 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
workflow with 25 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
workflow with 50 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
workflow with 10 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
workflow with 25 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
workflow with 50 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
Stream Benchmarks(includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
stream pipeline with 5 transform steps (1MB)💻 Local Development
▲ Production (Vercel)
10 parallel streams (1MB each)💻 Local Development
▲ Production (Vercel)
fan-out fan-in 10 streams (1MB each)💻 Local Development
▲ Production (Vercel)
SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
❌ Some benchmark jobs failed:
Check the workflow run for details. |
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests🌍 Community Worlds (74 failed)mongodb (7 failed):
redis (7 failed):
turso (60 failed):
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
✅ 📋 Other
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes @workflow/next failing to detect the installed Next.js version in monorepos (notably npm workspaces) where next is not hoisted alongside @workflow/next, by resolving next/package.json relative to the consuming project’s working directory first.
Changes:
- Update
resolveNextVersion()to resolvenext/package.jsonfromworkingDirfirst, then fall back to package-relative resolution. - Add a clearer hard failure when neither resolution path can determine a Next.js version.
- Add a changeset to ship the fix as a patch release for
@workflow/next.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/next/src/index.ts | Changes Next.js version resolution order to prefer consuming-project resolution and adds a final error if resolution fails. |
| .changeset/fix-next-version-resolution.md | Adds a patch changeset entry documenting the fix. |
Comments suppressed due to low confidence (1)
packages/next/src/index.ts:16
- This change fixes a specific resolution-order bug (workingDir-first, then package-relative), but there is no unit test covering the new behavior or the failure mode when both resolutions fail. Add tests that simulate a monorepo layout (or mock
require.resolve/require) to assert the preferred resolution path is attempted first and that the thrown error is clear.
function resolveNextVersion(workingDir: string): string {
// Try resolving from the consuming project's working directory first.
// This handles monorepo setups where `next` may not be hoisted to the
// same location as `@workflow/next`.
try {
const packageJsonPath = require.resolve('next/package.json', {
paths: [workingDir],
});
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…message Address review feedback: capture caught errors from both resolution attempts and attach them via `cause` on the final thrown error. Include the working directory in the error message to aid debugging in monorepo and CI environments.
ijjk
approved these changes
Apr 11, 2026
TooTallNate
enabled auto-merge (squash)
April 12, 2026 07:11
Uh oh!
There was an error while loading. Please reload this page.
ijjk pushed a commit
that referenced
this pull request
Apr 15, 2026
) * fix(next): resolve next/package.json from working directory first In npm workspaces monorepos, `@workflow/next` can be hoisted to the root `node_modules/` while `next` stays in a workspace's local `node_modules/`. The eager `require('next/package.json')` on the fallback path resolved relative to `@workflow/next`'s own location, failing before the correct working-directory-relative resolution could run. Restructure `resolveNextVersion()` to try the working directory path first, fall back to the package-relative path second, and wrap both in separate try/catch blocks so neither can crash the process. Closes#1680 * fix(next): capture resolution errors and include workingDir in error message Address review feedback: capture caught errors from both resolution attempts and attach them via `cause` on the final thrown error. Include the working directory in the error message to aid debugging in monorepo and CI environments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@workflow/nextfailing to resolvenext/package.jsonin npm workspaces monorepos wherenextis not hoisted to the rootnode_modules/resolveNextVersion()to try the working-directory-relative resolution first (preferred), then fall back to the package-relative resolution, with both paths wrapped in separate try/catch blocksCloses#1680