Uh oh!
There was an error while loading. Please reload this page.
[backport] [vitest] [world-local] Fix local-world data recovery isolation (#1895) - #1898
Merged
Conversation
🦋 Changeset detectedLatest commit: f5eb529 The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests🌍 Community Worlds (82 failed)mongodb (10 failed):
redis (7 failed):
turso (65 failed):
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
✅ 📋 Other
|
Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
|
VaguelySerious
marked this pull request as ready for review
May 2, 2026 12:42
VaguelySerious
enabled auto-merge (squash)
May 3, 2026 02:52
TooTallNate
approved these changes
May 4, 2026
TooTallNate
left a comment
Member
There was a problem hiding this comment.
Verified the backport against the original #1895. All conflict resolutions match the PR description's claims:
packages/vitest/package.json: Confirmed —vitestays at7.1.12(stable's pin),vitest@catalogadded to devDeps. Diff is identical to the corresponding section in #1895 except for the preserved vite version.packages/core/e2e/dev.test.ts: Confirmed — stable still usessupportsDeferredStepCopieswith thecopiedStepDir/__workflow_step_files__mechanism (verified onstabledirectly). The backport correctly:- Adopts the new
afterEachrestore-then-delete reorder + Windows comment ✓ - Adopts the
apiFileretry-on-500 try/catch aroundtriggerWorkflowRun✓ - Bumps the timeout from 30s → 60s ✓
- Does NOT adopt the manifest-based assertion or in-test teardown (those depend on main's deferred builder structure, not stable's) ✓
- Adopts the new
All other files are byte-identical to #1895:
packages/vitest/src/{global-setup,setup-file,index,options,vitest-context.d}.ts,packages/vitest/src/index.test.ts,packages/world-local/src/{config,fs,index,storage/{index,runs-storage}}.ts,packages/world-local/src/{fs.test,reenqueue.test}.ts,docs/content/docs/api-reference/vitest/index.mdx, both changesets. Confirmed via diff of the per-file hunks.
The substance is the same fix I approved in #1895 (vitest project-context isolation, world-local recovery scoped by tag, dedupe of createStorage calls), now correctly adapted to stable's diverged state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #1895 onto `stable`.
Cherry-pick of `2f52d14f38` with conflict resolution for stable's diverged state:
Verified locally:
🤖 Generated with Claude Code