Uh oh!
There was an error while loading. Please reload this page.
[backport] [tarballs] Build workspace deps before packing (#1908) - #1909
Merged
Conversation
The standalone tarballs project's vercel.json sets "buildCommand": "pnpm --filter tarballs build", which only runs the tarballs package's build script (node scripts/pack.ts) and does not trigger turbo's `dependsOn: ["^build"]` chain. Every workspace package gets packed with an empty dist/ directory, so downstream installs fail with errors like "Cannot find module '<pkg>/dist/next.cjs'". The previous docs-based pipeline didn't hit this because Vercel detected docs as a Next.js framework, ran turbo for it, and pack.ts was wired as a prebuild step that ran after deps were already built. Switch the buildCommand to `pnpm turbo build --filter=tarballs` so turbo evaluates the build task for tarballs, fans out via ^build to compile every workspace dependency first, and only then runs tarballs#build (pack.ts) against the populated dist/ directories. Verified locally: a fresh build now produces tarballs containing the full dist/ tree (including dist/next.cjs). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
🦋 Changeset detectedLatest commit: ce72268 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests🌍 Community Worlds (83 failed)mongodb (11 failed):
redis (7 failed):
turso (65 failed):
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
✅ 📋 Other
|
VaguelySerious
enabled auto-merge (squash)
May 4, 2026 05:19
pranaygp
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1908 to
stable.Summary
The
tarballsVercel project'svercel.jsonsets"buildCommand": "pnpm --filter tarballs build", which only runs thetarballspackage'sbuildscript (node scripts/pack.ts) and does not trigger turbo'sdependsOn: ["^build"]chain. As a result every preview tarball gets packed with an emptydist/directory — onlybin/,package.json,README.md, anddocs/make it in. Downstream installs then fail with errors like:The fix flips the build command to
pnpm turbo build --filter=tarballsso turbo fans out via^buildto compile every workspace dependency first, and only then runstarballs#build(pack.ts) against the populateddist/directories.This applies to
stablefor the same reason as onmain: PR #1899 backported the tarballs split (#1893) ontostable, so stable's preview tarballs are broken in the same way.Test plan
workflow/nextcorrectly when installed in a downstream Next.js app.🤖 Generated with Claude Code