Backport #1965: Fix Nitro dev loading of local step dependencies - #1968

Merged
TooTallNate merged 6 commits into
stablefrom
backport/pr-1965-to-stable
May 22, 2026
Merged

Backport #1965: Fix Nitro dev loading of local step dependencies#1968
TooTallNate merged 6 commits into
stablefrom
backport/pr-1965-to-stable

Conversation

@github-actions

@github-actionsgithub-actionsBot commented May 11, 2026

Copy link
Copy Markdown
Contributor

Automated backport of #1965 to stable.

AI recommendation: This is a self-contained bug fix for Nitro dev loading of local step dependencies, with new test coverage. It adds an opt-in flag that defaults to existing behavior elsewhere, so it shouldn't conflict with main-only APIs and is valuable to ship on stable if the affected code paths exist there.

Merge conflicts were resolved by AI (opencode with anthropic/claude-opus-4.7). Please review the conflict resolution carefully before merging.

@github-actions
Fix Nitro dev loading of local step dependencies (#1965)
2f00a85
* Fix local step dependency bundling
* Limit local dependency bundling to Nitro dev
Signed-off-by: JJ Kasper <jj@jjsweb.site>
@github-actionsgithub-actionsBot mentioned this pull request May 11, 2026
Merged
@changeset-bot

changeset-botBot commented May 11, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 186e472

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
NameType
@workflow/buildersPatch
@workflow/astroPatch
@workflow/cliPatch
@workflow/nestPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/vitestPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/web-sharedPatch
@workflow/webPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented May 11, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, CommentMay 22, 2026 6:58pm
example-nextjs-workflow-webpackReadyReadyPreview, CommentMay 22, 2026 6:58pm
example-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-astro-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-express-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-fastify-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-hono-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-nitro-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-nuxt-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-sveltekit-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-tanstack-start-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-vite-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workflow-swc-playgroundReadyReadyPreview, CommentMay 22, 2026 6:58pm
workflow-tarballsReadyReadyPreview, CommentMay 22, 2026 6:58pm
workflow-webReadyReadyPreview, CommentMay 22, 2026 6:58pm
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
workflow-docsSkippedSkippedMay 22, 2026 6:58pm

vercel[bot]
vercelBot reviewed May 11, 2026
View reviewed changes
Comment threadpackages/builders/src/swc-esbuild-plugin.test.ts
@TooTallNate
TooTallNate requested a review from a team as a code ownerMay 22, 2026 16:54
@github-actions

github-actionsBot commented May 22, 2026•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

🧪 E2E Test Results

❌ Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production901067968
✅ 💻 Local Development9700861056
✅ 📦 Local Production9700861056
✅ 🐘 Local Postgres9700861056
✅ 🪟 Windows880088
❌ 🌍 Community Worlds1569084
✅ 📋 Other492036528
Total4406693614836

❌ Failed Tests

🌍 Community Worlds (69 failed)

mongodb-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

redis-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

turso-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

turso (66 failed):

  • addTenWorkflow | wrun_01KS8HKTTW9WBVA0FM02VBPSYR
  • addTenWorkflow | wrun_01KS8HKTTW9WBVA0FM02VBPSYR
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KS8GSH88705N4FSYD9FRQ4TD
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KS8HM1SRMAF4H5XFXQP25NWK
  • promiseRaceWorkflow | wrun_01KS8HM7KTG9PS62ATMZ7VC46Q
  • promiseAnyWorkflow | wrun_01KS8HM9SBQX8DJB8V7CRB7BQF
  • importedStepOnlyWorkflow | wrun_01KS8GSX4PT8SD4KNT47MV3KXB
  • readableStreamWorkflow | wrun_01KS8HMC9SPS1FCEZ0R39T7K9R
  • hookWorkflow | wrun_01KS8HMRZZ3HTY3016Z9DJESK4
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KS8HN0MK1KW4V9T295SBJG8S
  • webhookWorkflow | wrun_01KS8HN5311M5EC889N9M71BZ8
  • sleepingWorkflow | wrun_01KS8HNB78P3N9WG9A9YYA9BEA
  • parallelSleepWorkflow | wrun_01KS8HNTVWY4Z6D96WP2WDDAJK
  • nullByteWorkflow | wrun_01KS8HNYBMY1BWZETSK0VMNFEN
  • workflowAndStepMetadataWorkflow | wrun_01KS8HP0HT4FWTBGFE7A11EGHH
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KS8HRE0E6Z5JYNY0V98AZ6N8
  • fetchWorkflow | wrun_01KS8HRVS9FYNA2323CCHTAVHS
  • promiseRaceStressTestWorkflow | wrun_01KS8HRZKYSXY0NS5RS1P7V2XW
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KS8HWEGPDXEVYVHYRQ4QY76N
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KS8HWWDD0GP1M7FYQAZ6R0Y6
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KS8HXBZA0XKSR8ZESNRQTA6F
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KS8HXX60R3762PPS6V7H14K4
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KS8HY6GSSAXESACFAC6B2NFS
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KS8HYC75GKTKQDS0NY4CH0P0
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KS8HYECSJXQ12S4VX2X6PHRX
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KS8HYYV7MPJN0PX0PSBZ0EH4
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KS8HZ4T4EWZNXY8BP1J24RM9
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KS8HZBZ0Q01P8MS7T6A2VJEQ
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KS8HZJXDRERMDMQRS9AR1DS3
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KS8HZSSSJY84XDW85E4DRC0H
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KS8J0239636SNCPTQ3M8HZ4J
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KS8J09946NQ24E20BF3NV75F
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KS8J0N78M3B0DC2SS2H09J41
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KS8J0YH1Y3KW3S8V1ZADKEGN
  • cancelRun - cancelling a running workflow | wrun_01KS8J16WV7B2CEH955W997097
  • cancelRun via CLI - cancelling a running workflow | wrun_01KS8J1GGBRHY5HG1VMGYEV26T
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KS8J1X0VRXWA0DJH5V8STCQ7
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KS8J2E11966TF78T22BTJYVV
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KS8J2RJXVR9YDC9JACN38WXZ
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KS8J30N70KC61RMM7GF08XYD
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KS8J32Y4FCTAH3PV5CXAVD62
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KS8J35365KQ54Y9NZ86XWVJW

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro8107
✅ example8107
✅ express8107
✅ fastify8107
✅ hono8107
✅ nextjs-turbopack8602
✅ nextjs-webpack8602
✅ nitro8107
✅ nuxt8107
✅ sveltekit8107
✅ vite8107
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack8800
❌ 🌍 Community Worlds
AppPassedFailedSkipped
❌ mongodb-dev410
❌ redis-dev410
❌ turso-dev410
❌ turso3660
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8206
✅ e2e-local-dev-tanstack-start-stable8206
✅ e2e-local-postgres-nest-stable8206
✅ e2e-local-postgres-tanstack-start-stable8206
✅ e2e-local-prod-nest-stable8206
✅ e2e-local-prod-tanstack-start-stable8206

📋 View full workflow run

@vercel
vercelBottemporarily deployed to Preview – workflow-docs May 22, 2026 18:52 Inactive
TooTallNate
TooTallNate approved these changes May 22, 2026
View reviewed changes

@TooTallNateTooTallNate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faithfulness review: yes, with one caveat

Verified by extracting just the additions/deletions (stripping context lines and metadata) from both #1965 (main) and #1968 (stable) per file:

FileOriginal #1965 logic preserved?
.changeset/narrow-step-bundling.mdbyte-identical
packages/builders/src/swc-esbuild-plugin.tsbyte-identical (context lines differ because surrounding code on stable differs, but the +/- lines match exactly)
packages/builders/src/swc-esbuild-plugin.test.tsnew test added by #1965 is byte-identical
packages/nitro/src/builders.tsbyte-identical
packages/builders/src/base-builder.tsOriginal bundleTransitiveLocalStepDependencies plumbing preserved, plus adaptation code (see below)
packages/builders/src/discover-entries-esbuild-plugin.tsOriginal enhancedResolve.create({...}) change preserved, plus adaptation code (see below)

So the core #1965 logic is faithfully ported. The extra deletions/additions in the GitHub diff (+335/-31 vs +307/-2) are entirely from:

What 796dc4235 ("Fix stable backport build failures") added

Three categories of adaptation, all justified:

1. Set-vs-array typing widening (necessary)

The test file from #1965 uses new Set<string>() for discoveredSteps/discoveredWorkflows/discoveredSerdeFiles because on main those fields had already been changed from string[] to Set<string> before #1965 (unrelated commit). On stable they're still string[].

Two valid adaptations:

  • Modify the test to use [] arrays (breaks test fidelity)
  • Widen the types to accept both (preserves test fidelity)

JJ chose option B. Adds:

  • export type DiscoveredEntryCollection = string[] | Set<string> in base-builder.ts
  • addDiscovered() helper in discover-entries-esbuild-plugin.ts to push to either shape
  • [...discoveredSerdeFiles].filter(...) (because Set has no .filter)

Type widening is safe: DiscoveredEntries is not exported from @workflow/builders/index.ts, so it's internal. No external consumer breakage.

2. filter: jsTsRegex → filter: /.*/ in discover-entries plugin (necessary)

The new test's stepFile imports '../../shared/constants' — extensionless. esbuild's filter: jsTsRegex would NOT match extensionless imports because filters are evaluated against the import path string, not the resolved file. Without this change, the test's transitive-discovery wouldn't fire.

Pairs with if (!args.importer) return null; guard to skip the entry-point itself. Necessary for the test to pass. Slight increase in resolve-time work for non-JS/TS imports (CSS, JSON, etc.) but the early-return in enhancedResolve should make those cheap.

3. Omitted createCombinedBundle plumbing (correct)

On main, #1965 also added bundleTransitiveLocalStepDependencies to createCombinedBundle (4 lines). createCombinedBundle does not exist on stable (confirmed via git show origin/stable:base-builder.ts), so omitting the plumbing is correct.

What the three "Revert" commits did

  • d9f53d1a2 Revert runtime workaround changes — undid stray changes to tarballs/, world-testing/, docs/, changeset file
  • 879abd34b Revert DOMException reducer change — undid serialization.ts modification
  • 186e47269 Revert serialization test mock — undid serialization.test.ts modification

Verified the net effect on each of these files between the cherry-pick commit (2f00a8573) and the PR HEAD (186e47269) is zero — the reverts properly undid the unrelated changes. Only the builders files have net changes, and those are the legitimate adaptations.

Caveat: vade[bot] flagged a transient TS error

The vercel[bot] inline comment on line 253 of swc-esbuild-plugin.test.ts says:

Tests pass Set<string> for state fields but createDiscoverEntriesPlugin expects string[], causing TS2345 compilation errors that break all builds.

This was flagged against an EARLIER commit before the type-widening 796dc4235 landed. The current PR HEAD has the union type fix, so this should no longer apply. Verified locally: pnpm turbo run typecheck --filter @workflow/builders ... is clean.

What I verified locally

  • pnpm install --frozen-lockfile ✓
  • pnpm turbo run build --filter @workflow/builders --filter @workflow/nitro ✓
  • pnpm turbo run typecheck --filter @workflow/builders --filter @workflow/nitro --filter @workflow/next --filter @workflow/sveltekit --filter @workflow/astro --filter @workflow/nest ✓
  • pnpm --filter @workflow/builders test ✓ (144/144)
  • pnpm --filter @workflow/builders exec vitest run src/swc-esbuild-plugin.test.ts ✓ (23/23 — confirms the new regression test passes)

CI

  • 81 success, 2 failure, 2 in-progress, 6 skipped
  • All 42 E2E Local jobs pass (Dev + Prod + Postgres across all workbenches) ✓
  • Unit Tests pass ✓
  • E2E Windows Tests pass ✓
  • Failures: 2 of 11 E2E Vercel Prod Tests (astro, vite) — these look like single-run Vercel infrastructure flakes (the workflow run shows up in the Vercel UI but the test asserted failure). Not specific to this PR.
  • ijjk has already approved (the original author of #1965)

Bottom line

Faithful backport. The #1965 logic ports cleanly; the extra changes are all defensible adaptations to make stable's pre-existing code (string[] vs Set, missing createCombinedBundle) work with the new code from #1965. JJ took the higher-fidelity path (preserve the test verbatim, widen the types) rather than modifying the test, which I think is the right call.

Approving.

@VaguelySeriousVaguelySerious mentioned this pull request Jun 2, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vercelvercel[bot]vercel[bot] left review comments
@TooTallNateTooTallNateTooTallNate approved these changes
@ijjkijjkijjk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TooTallNate@ijjk
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Backport #1965: Fix Nitro dev loading of local step dependencies - #1968
Merged
TooTallNate merged 6 commits into
stablefrom 
backport/pr-1965-to-stable
May 22, 2026
Merged
Backport #1965: Fix Nitro dev loading of local step dependencies#1968
TooTallNate merged 6 commits into
stablefrom 
backport/pr-1965-to-stable
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
May 11, 2026

Copy link


Copy Markdown

Contributor
Automated backport of #1965 to stable.
AI recommendation: This is a self-contained bug fix for Nitro dev loading of local step dependencies, with new test coverage. It adds an opt-in flag that defaults to existing behavior elsewhere, so it shouldn't conflict with main-only APIs and is valuable to ship on stable if the affected code paths exist there.
Merge conflicts were resolved by AI (opencode with anthropic/claude-opus-4.7). Please review the conflict resolution carefully before merging.
@github-actions
Fix Nitro dev loading of local step dependencies (#1965)
2f00a85
* Fix local step dependency bundling
* Limit local dependency bundling to Nitro dev
Signed-off-by: JJ Kasper <jj@jjsweb.site>
@github-actionsgithub-actionsBot
mentioned this pull request
May 11, 2026
 Merged

@changeset-bot
changeset-botBot
commented
May 11, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 186e472
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/buildersPatch
@workflow/astroPatch
@workflow/cliPatch
@workflow/nestPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/vitestPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/web-sharedPatch
@workflow/webPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
May 11, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, CommentMay 22, 2026 6:58pm
example-nextjs-workflow-webpackReadyReadyPreview, CommentMay 22, 2026 6:58pm
example-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-astro-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-express-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-fastify-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-hono-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-nitro-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-nuxt-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-sveltekit-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-tanstack-start-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-vite-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workflow-swc-playgroundReadyReadyPreview, CommentMay 22, 2026 6:58pm
workflow-tarballsReadyReadyPreview, CommentMay 22, 2026 6:58pm
workflow-webReadyReadyPreview, CommentMay 22, 2026 6:58pm
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
workflow-docsSkippedSkippedMay 22, 2026 6:58pm
vercel[bot]
vercelBot
reviewed
May 11, 2026
View reviewed changes
Comment threadpackages/builders/src/swc-esbuild-plugin.test.ts
@TooTallNate
TooTallNate
requested a review
from a team
as a code ownerMay 22, 2026 16:54
@github-actions
github-actionsBot
commented
May 22, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
🧪 E2E Test Results
❌ Some tests failed
Summary
PassedFailedSkippedTotal
✅ ▲ Vercel Production901067968
✅ 💻 Local Development9700861056
✅ 📦 Local Production9700861056
✅ 🐘 Local Postgres9700861056
✅ 🪟 Windows880088
❌ 🌍 Community Worlds1569084
✅ 📋 Other492036528
Total4406693614836
❌ Failed Tests
🌍 Community Worlds (69 failed)
mongodb-dev (1 failed):
  • dev e2e should rebuild on imported step dependency change
redis-dev (1 failed):
  • dev e2e should rebuild on imported step dependency change
turso-dev (1 failed):
  • dev e2e should rebuild on imported step dependency change
turso (66 failed):
  • addTenWorkflow | wrun_01KS8HKTTW9WBVA0FM02VBPSYR
  • addTenWorkflow | wrun_01KS8HKTTW9WBVA0FM02VBPSYR
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KS8GSH88705N4FSYD9FRQ4TD
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KS8HM1SRMAF4H5XFXQP25NWK
  • promiseRaceWorkflow | wrun_01KS8HM7KTG9PS62ATMZ7VC46Q
  • promiseAnyWorkflow | wrun_01KS8HM9SBQX8DJB8V7CRB7BQF
  • importedStepOnlyWorkflow | wrun_01KS8GSX4PT8SD4KNT47MV3KXB
  • readableStreamWorkflow | wrun_01KS8HMC9SPS1FCEZ0R39T7K9R
  • hookWorkflow | wrun_01KS8HMRZZ3HTY3016Z9DJESK4
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KS8HN0MK1KW4V9T295SBJG8S
  • webhookWorkflow | wrun_01KS8HN5311M5EC889N9M71BZ8
  • sleepingWorkflow | wrun_01KS8HNB78P3N9WG9A9YYA9BEA
  • parallelSleepWorkflow | wrun_01KS8HNTVWY4Z6D96WP2WDDAJK
  • nullByteWorkflow | wrun_01KS8HNYBMY1BWZETSK0VMNFEN
  • workflowAndStepMetadataWorkflow | wrun_01KS8HP0HT4FWTBGFE7A11EGHH
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KS8HRE0E6Z5JYNY0V98AZ6N8
  • fetchWorkflow | wrun_01KS8HRVS9FYNA2323CCHTAVHS
  • promiseRaceStressTestWorkflow | wrun_01KS8HRZKYSXY0NS5RS1P7V2XW
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KS8HWEGPDXEVYVHYRQ4QY76N
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KS8HWWDD0GP1M7FYQAZ6R0Y6
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KS8HXBZA0XKSR8ZESNRQTA6F
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KS8HXX60R3762PPS6V7H14K4
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KS8HY6GSSAXESACFAC6B2NFS
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KS8HYC75GKTKQDS0NY4CH0P0
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KS8HYECSJXQ12S4VX2X6PHRX
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KS8HYYV7MPJN0PX0PSBZ0EH4
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KS8HZ4T4EWZNXY8BP1J24RM9
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KS8HZBZ0Q01P8MS7T6A2VJEQ
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KS8HZJXDRERMDMQRS9AR1DS3
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KS8HZSSSJY84XDW85E4DRC0H
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KS8J0239636SNCPTQ3M8HZ4J
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KS8J09946NQ24E20BF3NV75F
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KS8J0N78M3B0DC2SS2H09J41
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KS8J0YH1Y3KW3S8V1ZADKEGN
  • cancelRun - cancelling a running workflow | wrun_01KS8J16WV7B2CEH955W997097
  • cancelRun via CLI - cancelling a running workflow | wrun_01KS8J1GGBRHY5HG1VMGYEV26T
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KS8J1X0VRXWA0DJH5V8STCQ7
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KS8J2E11966TF78T22BTJYVV
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KS8J2RJXVR9YDC9JACN38WXZ
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KS8J30N70KC61RMM7GF08XYD
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KS8J32Y4FCTAH3PV5CXAVD62
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KS8J35365KQ54Y9NZ86XWVJW
Details by Category
✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro8107
✅ example8107
✅ express8107
✅ fastify8107
✅ hono8107
✅ nextjs-turbopack8602
✅ nextjs-webpack8602
✅ nitro8107
✅ nuxt8107
✅ sveltekit8107
✅ vite8107
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack8800
❌ 🌍 Community Worlds
AppPassedFailedSkipped
❌ mongodb-dev410
❌ redis-dev410
❌ turso-dev410
❌ turso3660
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8206
✅ e2e-local-dev-tanstack-start-stable8206
✅ e2e-local-postgres-nest-stable8206
✅ e2e-local-postgres-tanstack-start-stable8206
✅ e2e-local-prod-nest-stable8206
✅ e2e-local-prod-tanstack-start-stable8206
📋 View full workflow run
@vercel
vercelBottemporarily deployed
to
Preview – workflow-docs
May 22, 2026 18:52
Inactive

TooTallNate
TooTallNate
approved these changes
May 22, 2026
View reviewed changes
@TooTallNateTooTallNate
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faithfulness review: yes, with one caveat
Verified by extracting just the additions/deletions (stripping context lines and metadata) from both #1965 (main) and #1968 (stable) per file:
FileOriginal #1965 logic preserved?
.changeset/narrow-step-bundling.mdbyte-identical
packages/builders/src/swc-esbuild-plugin.tsbyte-identical (context lines differ because surrounding code on stable differs, but the +/- lines match exactly)
packages/builders/src/swc-esbuild-plugin.test.tsnew test added by #1965 is byte-identical
packages/nitro/src/builders.tsbyte-identical
packages/builders/src/base-builder.tsOriginal bundleTransitiveLocalStepDependencies plumbing preserved, plus adaptation code (see below)
packages/builders/src/discover-entries-esbuild-plugin.tsOriginal enhancedResolve.create({...}) change preserved, plus adaptation code (see below)
So the core #1965 logic is faithfully ported. The extra deletions/additions in the GitHub diff (+335/-31 vs +307/-2) are entirely from:
What 796dc4235 ("Fix stable backport build failures") added
Three categories of adaptation, all justified:
1. Set-vs-array typing widening (necessary)
The test file from #1965 uses new Set<string>() for discoveredSteps/discoveredWorkflows/discoveredSerdeFiles because on main those fields had already been changed from string[] to Set<string> before #1965 (unrelated commit). On stable they're still string[].
Two valid adaptations:
  • Modify the test to use [] arrays (breaks test fidelity)
  • Widen the types to accept both (preserves test fidelity)
JJ chose option B. Adds:
  • export type DiscoveredEntryCollection = string[] | Set<string> in base-builder.ts
  • addDiscovered() helper in discover-entries-esbuild-plugin.ts to push to either shape
  • [...discoveredSerdeFiles].filter(...) (because Set has no .filter)
Type widening is safe: DiscoveredEntries is not exported from @workflow/builders/index.ts, so it's internal. No external consumer breakage.
2. filter: jsTsRegex → filter: /.*/ in discover-entries plugin (necessary)
The new test's stepFile imports '../../shared/constants' — extensionless. esbuild's filter: jsTsRegex would NOT match extensionless imports because filters are evaluated against the import path string, not the resolved file. Without this change, the test's transitive-discovery wouldn't fire.
Pairs with if (!args.importer) return null; guard to skip the entry-point itself. Necessary for the test to pass. Slight increase in resolve-time work for non-JS/TS imports (CSS, JSON, etc.) but the early-return in enhancedResolve should make those cheap.
3. Omitted createCombinedBundle plumbing (correct)
On main, #1965 also added bundleTransitiveLocalStepDependencies to createCombinedBundle (4 lines). createCombinedBundle does not exist on stable (confirmed via git show origin/stable:base-builder.ts), so omitting the plumbing is correct.
What the three "Revert" commits did
  • d9f53d1a2 Revert runtime workaround changes — undid stray changes to tarballs/, world-testing/, docs/, changeset file
  • 879abd34b Revert DOMException reducer change — undid serialization.ts modification
  • 186e47269 Revert serialization test mock — undid serialization.test.ts modification
Verified the net effect on each of these files between the cherry-pick commit (2f00a8573) and the PR HEAD (186e47269) is zero — the reverts properly undid the unrelated changes. Only the builders files have net changes, and those are the legitimate adaptations.
Caveat: vade[bot] flagged a transient TS error
The vercel[bot] inline comment on line 253 of swc-esbuild-plugin.test.ts says:
Tests pass Set<string> for state fields but createDiscoverEntriesPlugin expects string[], causing TS2345 compilation errors that break all builds.
This was flagged against an EARLIER commit before the type-widening 796dc4235 landed. The current PR HEAD has the union type fix, so this should no longer apply. Verified locally: pnpm turbo run typecheck --filter @workflow/builders ... is clean.
What I verified locally
  • pnpm install --frozen-lockfile ✓
  • pnpm turbo run build --filter @workflow/builders --filter @workflow/nitro ✓
  • pnpm turbo run typecheck --filter @workflow/builders --filter @workflow/nitro --filter @workflow/next --filter @workflow/sveltekit --filter @workflow/astro --filter @workflow/nest ✓
  • pnpm --filter @workflow/builders test ✓ (144/144)
  • pnpm --filter @workflow/builders exec vitest run src/swc-esbuild-plugin.test.ts ✓ (23/23 — confirms the new regression test passes)
CI
  • 81 success, 2 failure, 2 in-progress, 6 skipped
  • All 42 E2E Local jobs pass (Dev + Prod + Postgres across all workbenches) ✓
  • Unit Tests pass ✓
  • E2E Windows Tests pass ✓
  • Failures: 2 of 11 E2E Vercel Prod Tests (astro, vite) — these look like single-run Vercel infrastructure flakes (the workflow run shows up in the Vercel UI but the test asserted failure). Not specific to this PR.
  • ijjk has already approved (the original author of #1965)
Bottom line
Faithful backport. The #1965 logic ports cleanly; the extra changes are all defensible adaptations to make stable's pre-existing code (string[] vs Set, missing createCombinedBundle) work with the new code from #1965. JJ took the higher-fidelity path (preserve the test verbatim, widen the types) rather than modifying the test, which I think is the right call.
Approving.
@VaguelySeriousVaguelySerious
mentioned this pull request
Jun 2, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@vercelvercel[bot]vercel[bot] left review comments
@TooTallNateTooTallNateTooTallNate approved these changes
@ijjkijjkijjk approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@TooTallNate@ijjk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Backport #1965: Fix Nitro dev loading of local step dependencies - #1968
Merged
TooTallNate merged 6 commits into
stablefrom 
backport/pr-1965-to-stable
May 22, 2026
Merged
Backport #1965: Fix Nitro dev loading of local step dependencies#1968
TooTallNate merged 6 commits into
stablefrom 
backport/pr-1965-to-stable
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
May 11, 2026

Copy link


Copy Markdown

Contributor
Automated backport of #1965 to stable.
AI recommendation: This is a self-contained bug fix for Nitro dev loading of local step dependencies, with new test coverage. It adds an opt-in flag that defaults to existing behavior elsewhere, so it shouldn't conflict with main-only APIs and is valuable to ship on stable if the affected code paths exist there.
Merge conflicts were resolved by AI (opencode with anthropic/claude-opus-4.7). Please review the conflict resolution carefully before merging.
@github-actions
Fix Nitro dev loading of local step dependencies (#1965)
2f00a85
* Fix local step dependency bundling
* Limit local dependency bundling to Nitro dev
Signed-off-by: JJ Kasper <jj@jjsweb.site>
@github-actionsgithub-actionsBot
mentioned this pull request
May 11, 2026
 Merged

@changeset-bot
changeset-botBot
commented
May 11, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 186e472
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/buildersPatch
@workflow/astroPatch
@workflow/cliPatch
@workflow/nestPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/vitestPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/web-sharedPatch
@workflow/webPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
May 11, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, CommentMay 22, 2026 6:58pm
example-nextjs-workflow-webpackReadyReadyPreview, CommentMay 22, 2026 6:58pm
example-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-astro-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-express-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-fastify-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-hono-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-nitro-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-nuxt-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-sveltekit-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-tanstack-start-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-vite-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workflow-swc-playgroundReadyReadyPreview, CommentMay 22, 2026 6:58pm
workflow-tarballsReadyReadyPreview, CommentMay 22, 2026 6:58pm
workflow-webReadyReadyPreview, CommentMay 22, 2026 6:58pm
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
workflow-docsSkippedSkippedMay 22, 2026 6:58pm
vercel[bot]
vercelBot
reviewed
May 11, 2026
View reviewed changes
Comment threadpackages/builders/src/swc-esbuild-plugin.test.ts
@TooTallNate
TooTallNate
requested a review
from a team
as a code ownerMay 22, 2026 16:54
@github-actions
github-actionsBot
commented
May 22, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
🧪 E2E Test Results
❌ Some tests failed
Summary
PassedFailedSkippedTotal
✅ ▲ Vercel Production901067968
✅ 💻 Local Development9700861056
✅ 📦 Local Production9700861056
✅ 🐘 Local Postgres9700861056
✅ 🪟 Windows880088
❌ 🌍 Community Worlds1569084
✅ 📋 Other492036528
Total4406693614836
❌ Failed Tests
🌍 Community Worlds (69 failed)
mongodb-dev (1 failed):
  • dev e2e should rebuild on imported step dependency change
redis-dev (1 failed):
  • dev e2e should rebuild on imported step dependency change
turso-dev (1 failed):
  • dev e2e should rebuild on imported step dependency change
turso (66 failed):
  • addTenWorkflow | wrun_01KS8HKTTW9WBVA0FM02VBPSYR
  • addTenWorkflow | wrun_01KS8HKTTW9WBVA0FM02VBPSYR
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KS8GSH88705N4FSYD9FRQ4TD
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KS8HM1SRMAF4H5XFXQP25NWK
  • promiseRaceWorkflow | wrun_01KS8HM7KTG9PS62ATMZ7VC46Q
  • promiseAnyWorkflow | wrun_01KS8HM9SBQX8DJB8V7CRB7BQF
  • importedStepOnlyWorkflow | wrun_01KS8GSX4PT8SD4KNT47MV3KXB
  • readableStreamWorkflow | wrun_01KS8HMC9SPS1FCEZ0R39T7K9R
  • hookWorkflow | wrun_01KS8HMRZZ3HTY3016Z9DJESK4
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KS8HN0MK1KW4V9T295SBJG8S
  • webhookWorkflow | wrun_01KS8HN5311M5EC889N9M71BZ8
  • sleepingWorkflow | wrun_01KS8HNB78P3N9WG9A9YYA9BEA
  • parallelSleepWorkflow | wrun_01KS8HNTVWY4Z6D96WP2WDDAJK
  • nullByteWorkflow | wrun_01KS8HNYBMY1BWZETSK0VMNFEN
  • workflowAndStepMetadataWorkflow | wrun_01KS8HP0HT4FWTBGFE7A11EGHH
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KS8HRE0E6Z5JYNY0V98AZ6N8
  • fetchWorkflow | wrun_01KS8HRVS9FYNA2323CCHTAVHS
  • promiseRaceStressTestWorkflow | wrun_01KS8HRZKYSXY0NS5RS1P7V2XW
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KS8HWEGPDXEVYVHYRQ4QY76N
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KS8HWWDD0GP1M7FYQAZ6R0Y6
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KS8HXBZA0XKSR8ZESNRQTA6F
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KS8HXX60R3762PPS6V7H14K4
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KS8HY6GSSAXESACFAC6B2NFS
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KS8HYC75GKTKQDS0NY4CH0P0
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KS8HYECSJXQ12S4VX2X6PHRX
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KS8HYYV7MPJN0PX0PSBZ0EH4
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KS8HZ4T4EWZNXY8BP1J24RM9
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KS8HZBZ0Q01P8MS7T6A2VJEQ
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KS8HZJXDRERMDMQRS9AR1DS3
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KS8HZSSSJY84XDW85E4DRC0H
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KS8J0239636SNCPTQ3M8HZ4J
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KS8J09946NQ24E20BF3NV75F
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KS8J0N78M3B0DC2SS2H09J41
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KS8J0YH1Y3KW3S8V1ZADKEGN
  • cancelRun - cancelling a running workflow | wrun_01KS8J16WV7B2CEH955W997097
  • cancelRun via CLI - cancelling a running workflow | wrun_01KS8J1GGBRHY5HG1VMGYEV26T
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KS8J1X0VRXWA0DJH5V8STCQ7
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KS8J2E11966TF78T22BTJYVV
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KS8J2RJXVR9YDC9JACN38WXZ
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KS8J30N70KC61RMM7GF08XYD
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KS8J32Y4FCTAH3PV5CXAVD62
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KS8J35365KQ54Y9NZ86XWVJW
Details by Category
✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro8107
✅ example8107
✅ express8107
✅ fastify8107
✅ hono8107
✅ nextjs-turbopack8602
✅ nextjs-webpack8602
✅ nitro8107
✅ nuxt8107
✅ sveltekit8107
✅ vite8107
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack8800
❌ 🌍 Community Worlds
AppPassedFailedSkipped
❌ mongodb-dev410
❌ redis-dev410
❌ turso-dev410
❌ turso3660
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8206
✅ e2e-local-dev-tanstack-start-stable8206
✅ e2e-local-postgres-nest-stable8206
✅ e2e-local-postgres-tanstack-start-stable8206
✅ e2e-local-prod-nest-stable8206
✅ e2e-local-prod-tanstack-start-stable8206
📋 View full workflow run
@vercel
vercelBottemporarily deployed
to
Preview – workflow-docs
May 22, 2026 18:52
Inactive

TooTallNate
TooTallNate
approved these changes
May 22, 2026
View reviewed changes
@TooTallNateTooTallNate
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faithfulness review: yes, with one caveat
Verified by extracting just the additions/deletions (stripping context lines and metadata) from both #1965 (main) and #1968 (stable) per file:
FileOriginal #1965 logic preserved?
.changeset/narrow-step-bundling.mdbyte-identical
packages/builders/src/swc-esbuild-plugin.tsbyte-identical (context lines differ because surrounding code on stable differs, but the +/- lines match exactly)
packages/builders/src/swc-esbuild-plugin.test.tsnew test added by #1965 is byte-identical
packages/nitro/src/builders.tsbyte-identical
packages/builders/src/base-builder.tsOriginal bundleTransitiveLocalStepDependencies plumbing preserved, plus adaptation code (see below)
packages/builders/src/discover-entries-esbuild-plugin.tsOriginal enhancedResolve.create({...}) change preserved, plus adaptation code (see below)
So the core #1965 logic is faithfully ported. The extra deletions/additions in the GitHub diff (+335/-31 vs +307/-2) are entirely from:
What 796dc4235 ("Fix stable backport build failures") added
Three categories of adaptation, all justified:
1. Set-vs-array typing widening (necessary)
The test file from #1965 uses new Set<string>() for discoveredSteps/discoveredWorkflows/discoveredSerdeFiles because on main those fields had already been changed from string[] to Set<string> before #1965 (unrelated commit). On stable they're still string[].
Two valid adaptations:
  • Modify the test to use [] arrays (breaks test fidelity)
  • Widen the types to accept both (preserves test fidelity)
JJ chose option B. Adds:
  • export type DiscoveredEntryCollection = string[] | Set<string> in base-builder.ts
  • addDiscovered() helper in discover-entries-esbuild-plugin.ts to push to either shape
  • [...discoveredSerdeFiles].filter(...) (because Set has no .filter)
Type widening is safe: DiscoveredEntries is not exported from @workflow/builders/index.ts, so it's internal. No external consumer breakage.
2. filter: jsTsRegex → filter: /.*/ in discover-entries plugin (necessary)
The new test's stepFile imports '../../shared/constants' — extensionless. esbuild's filter: jsTsRegex would NOT match extensionless imports because filters are evaluated against the import path string, not the resolved file. Without this change, the test's transitive-discovery wouldn't fire.
Pairs with if (!args.importer) return null; guard to skip the entry-point itself. Necessary for the test to pass. Slight increase in resolve-time work for non-JS/TS imports (CSS, JSON, etc.) but the early-return in enhancedResolve should make those cheap.
3. Omitted createCombinedBundle plumbing (correct)
On main, #1965 also added bundleTransitiveLocalStepDependencies to createCombinedBundle (4 lines). createCombinedBundle does not exist on stable (confirmed via git show origin/stable:base-builder.ts), so omitting the plumbing is correct.
What the three "Revert" commits did
  • d9f53d1a2 Revert runtime workaround changes — undid stray changes to tarballs/, world-testing/, docs/, changeset file
  • 879abd34b Revert DOMException reducer change — undid serialization.ts modification
  • 186e47269 Revert serialization test mock — undid serialization.test.ts modification
Verified the net effect on each of these files between the cherry-pick commit (2f00a8573) and the PR HEAD (186e47269) is zero — the reverts properly undid the unrelated changes. Only the builders files have net changes, and those are the legitimate adaptations.
Caveat: vade[bot] flagged a transient TS error
The vercel[bot] inline comment on line 253 of swc-esbuild-plugin.test.ts says:
Tests pass Set<string> for state fields but createDiscoverEntriesPlugin expects string[], causing TS2345 compilation errors that break all builds.
This was flagged against an EARLIER commit before the type-widening 796dc4235 landed. The current PR HEAD has the union type fix, so this should no longer apply. Verified locally: pnpm turbo run typecheck --filter @workflow/builders ... is clean.
What I verified locally
  • pnpm install --frozen-lockfile ✓
  • pnpm turbo run build --filter @workflow/builders --filter @workflow/nitro ✓
  • pnpm turbo run typecheck --filter @workflow/builders --filter @workflow/nitro --filter @workflow/next --filter @workflow/sveltekit --filter @workflow/astro --filter @workflow/nest ✓
  • pnpm --filter @workflow/builders test ✓ (144/144)
  • pnpm --filter @workflow/builders exec vitest run src/swc-esbuild-plugin.test.ts ✓ (23/23 — confirms the new regression test passes)
CI
  • 81 success, 2 failure, 2 in-progress, 6 skipped
  • All 42 E2E Local jobs pass (Dev + Prod + Postgres across all workbenches) ✓
  • Unit Tests pass ✓
  • E2E Windows Tests pass ✓
  • Failures: 2 of 11 E2E Vercel Prod Tests (astro, vite) — these look like single-run Vercel infrastructure flakes (the workflow run shows up in the Vercel UI but the test asserted failure). Not specific to this PR.
  • ijjk has already approved (the original author of #1965)
Bottom line
Faithful backport. The #1965 logic ports cleanly; the extra changes are all defensible adaptations to make stable's pre-existing code (string[] vs Set, missing createCombinedBundle) work with the new code from #1965. JJ took the higher-fidelity path (preserve the test verbatim, widen the types) rather than modifying the test, which I think is the right call.
Approving.
@VaguelySeriousVaguelySerious
mentioned this pull request
Jun 2, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@vercelvercel[bot]vercel[bot] left review comments
@TooTallNateTooTallNateTooTallNate approved these changes
@ijjkijjkijjk approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@TooTallNate@ijjk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Backport #1965: Fix Nitro dev loading of local step dependencies - #1968
Merged
TooTallNate merged 6 commits into
stablefrom 
backport/pr-1965-to-stable
May 22, 2026
Merged
Backport #1965: Fix Nitro dev loading of local step dependencies#1968
TooTallNate merged 6 commits into
stablefrom 
backport/pr-1965-to-stable
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
May 11, 2026

Copy link


Copy Markdown

Contributor
Automated backport of #1965 to stable.
AI recommendation: This is a self-contained bug fix for Nitro dev loading of local step dependencies, with new test coverage. It adds an opt-in flag that defaults to existing behavior elsewhere, so it shouldn't conflict with main-only APIs and is valuable to ship on stable if the affected code paths exist there.
Merge conflicts were resolved by AI (opencode with anthropic/claude-opus-4.7). Please review the conflict resolution carefully before merging.
@github-actions
Fix Nitro dev loading of local step dependencies (#1965)
2f00a85
* Fix local step dependency bundling
* Limit local dependency bundling to Nitro dev
Signed-off-by: JJ Kasper <jj@jjsweb.site>
@github-actionsgithub-actionsBot
mentioned this pull request
May 11, 2026
 Merged

@changeset-bot
changeset-botBot
commented
May 11, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 186e472
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/buildersPatch
@workflow/astroPatch
@workflow/cliPatch
@workflow/nestPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/vitestPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/web-sharedPatch
@workflow/webPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
May 11, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, CommentMay 22, 2026 6:58pm
example-nextjs-workflow-webpackReadyReadyPreview, CommentMay 22, 2026 6:58pm
example-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-astro-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-express-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-fastify-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-hono-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-nitro-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-nuxt-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-sveltekit-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-tanstack-start-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-vite-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workflow-swc-playgroundReadyReadyPreview, CommentMay 22, 2026 6:58pm
workflow-tarballsReadyReadyPreview, CommentMay 22, 2026 6:58pm
workflow-webReadyReadyPreview, CommentMay 22, 2026 6:58pm
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
workflow-docsSkippedSkippedMay 22, 2026 6:58pm
vercel[bot]
vercelBot
reviewed
May 11, 2026
View reviewed changes
Comment threadpackages/builders/src/swc-esbuild-plugin.test.ts
@TooTallNate
TooTallNate
requested a review
from a team
as a code ownerMay 22, 2026 16:54
@github-actions
github-actionsBot
commented
May 22, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
🧪 E2E Test Results
❌ Some tests failed
Summary
PassedFailedSkippedTotal
✅ ▲ Vercel Production901067968
✅ 💻 Local Development9700861056
✅ 📦 Local Production9700861056
✅ 🐘 Local Postgres9700861056
✅ 🪟 Windows880088
❌ 🌍 Community Worlds1569084
✅ 📋 Other492036528
Total4406693614836
❌ Failed Tests
🌍 Community Worlds (69 failed)
mongodb-dev (1 failed):
  • dev e2e should rebuild on imported step dependency change
redis-dev (1 failed):
  • dev e2e should rebuild on imported step dependency change
turso-dev (1 failed):
  • dev e2e should rebuild on imported step dependency change
turso (66 failed):
  • addTenWorkflow | wrun_01KS8HKTTW9WBVA0FM02VBPSYR
  • addTenWorkflow | wrun_01KS8HKTTW9WBVA0FM02VBPSYR
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KS8GSH88705N4FSYD9FRQ4TD
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KS8HM1SRMAF4H5XFXQP25NWK
  • promiseRaceWorkflow | wrun_01KS8HM7KTG9PS62ATMZ7VC46Q
  • promiseAnyWorkflow | wrun_01KS8HM9SBQX8DJB8V7CRB7BQF
  • importedStepOnlyWorkflow | wrun_01KS8GSX4PT8SD4KNT47MV3KXB
  • readableStreamWorkflow | wrun_01KS8HMC9SPS1FCEZ0R39T7K9R
  • hookWorkflow | wrun_01KS8HMRZZ3HTY3016Z9DJESK4
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KS8HN0MK1KW4V9T295SBJG8S
  • webhookWorkflow | wrun_01KS8HN5311M5EC889N9M71BZ8
  • sleepingWorkflow | wrun_01KS8HNB78P3N9WG9A9YYA9BEA
  • parallelSleepWorkflow | wrun_01KS8HNTVWY4Z6D96WP2WDDAJK
  • nullByteWorkflow | wrun_01KS8HNYBMY1BWZETSK0VMNFEN
  • workflowAndStepMetadataWorkflow | wrun_01KS8HP0HT4FWTBGFE7A11EGHH
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KS8HRE0E6Z5JYNY0V98AZ6N8
  • fetchWorkflow | wrun_01KS8HRVS9FYNA2323CCHTAVHS
  • promiseRaceStressTestWorkflow | wrun_01KS8HRZKYSXY0NS5RS1P7V2XW
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KS8HWEGPDXEVYVHYRQ4QY76N
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KS8HWWDD0GP1M7FYQAZ6R0Y6
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KS8HXBZA0XKSR8ZESNRQTA6F
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KS8HXX60R3762PPS6V7H14K4
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KS8HY6GSSAXESACFAC6B2NFS
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KS8HYC75GKTKQDS0NY4CH0P0
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KS8HYECSJXQ12S4VX2X6PHRX
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KS8HYYV7MPJN0PX0PSBZ0EH4
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KS8HZ4T4EWZNXY8BP1J24RM9
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KS8HZBZ0Q01P8MS7T6A2VJEQ
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KS8HZJXDRERMDMQRS9AR1DS3
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KS8HZSSSJY84XDW85E4DRC0H
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KS8J0239636SNCPTQ3M8HZ4J
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KS8J09946NQ24E20BF3NV75F
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KS8J0N78M3B0DC2SS2H09J41
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KS8J0YH1Y3KW3S8V1ZADKEGN
  • cancelRun - cancelling a running workflow | wrun_01KS8J16WV7B2CEH955W997097
  • cancelRun via CLI - cancelling a running workflow | wrun_01KS8J1GGBRHY5HG1VMGYEV26T
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KS8J1X0VRXWA0DJH5V8STCQ7
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KS8J2E11966TF78T22BTJYVV
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KS8J2RJXVR9YDC9JACN38WXZ
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KS8J30N70KC61RMM7GF08XYD
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KS8J32Y4FCTAH3PV5CXAVD62
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KS8J35365KQ54Y9NZ86XWVJW
Details by Category
✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro8107
✅ example8107
✅ express8107
✅ fastify8107
✅ hono8107
✅ nextjs-turbopack8602
✅ nextjs-webpack8602
✅ nitro8107
✅ nuxt8107
✅ sveltekit8107
✅ vite8107
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack8800
❌ 🌍 Community Worlds
AppPassedFailedSkipped
❌ mongodb-dev410
❌ redis-dev410
❌ turso-dev410
❌ turso3660
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8206
✅ e2e-local-dev-tanstack-start-stable8206
✅ e2e-local-postgres-nest-stable8206
✅ e2e-local-postgres-tanstack-start-stable8206
✅ e2e-local-prod-nest-stable8206
✅ e2e-local-prod-tanstack-start-stable8206
📋 View full workflow run
@vercel
vercelBottemporarily deployed
to
Preview – workflow-docs
May 22, 2026 18:52
Inactive

TooTallNate
TooTallNate
approved these changes
May 22, 2026
View reviewed changes
@TooTallNateTooTallNate
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faithfulness review: yes, with one caveat
Verified by extracting just the additions/deletions (stripping context lines and metadata) from both #1965 (main) and #1968 (stable) per file:
FileOriginal #1965 logic preserved?
.changeset/narrow-step-bundling.mdbyte-identical
packages/builders/src/swc-esbuild-plugin.tsbyte-identical (context lines differ because surrounding code on stable differs, but the +/- lines match exactly)
packages/builders/src/swc-esbuild-plugin.test.tsnew test added by #1965 is byte-identical
packages/nitro/src/builders.tsbyte-identical
packages/builders/src/base-builder.tsOriginal bundleTransitiveLocalStepDependencies plumbing preserved, plus adaptation code (see below)
packages/builders/src/discover-entries-esbuild-plugin.tsOriginal enhancedResolve.create({...}) change preserved, plus adaptation code (see below)
So the core #1965 logic is faithfully ported. The extra deletions/additions in the GitHub diff (+335/-31 vs +307/-2) are entirely from:
What 796dc4235 ("Fix stable backport build failures") added
Three categories of adaptation, all justified:
1. Set-vs-array typing widening (necessary)
The test file from #1965 uses new Set<string>() for discoveredSteps/discoveredWorkflows/discoveredSerdeFiles because on main those fields had already been changed from string[] to Set<string> before #1965 (unrelated commit). On stable they're still string[].
Two valid adaptations:
  • Modify the test to use [] arrays (breaks test fidelity)
  • Widen the types to accept both (preserves test fidelity)
JJ chose option B. Adds:
  • export type DiscoveredEntryCollection = string[] | Set<string> in base-builder.ts
  • addDiscovered() helper in discover-entries-esbuild-plugin.ts to push to either shape
  • [...discoveredSerdeFiles].filter(...) (because Set has no .filter)
Type widening is safe: DiscoveredEntries is not exported from @workflow/builders/index.ts, so it's internal. No external consumer breakage.
2. filter: jsTsRegex → filter: /.*/ in discover-entries plugin (necessary)
The new test's stepFile imports '../../shared/constants' — extensionless. esbuild's filter: jsTsRegex would NOT match extensionless imports because filters are evaluated against the import path string, not the resolved file. Without this change, the test's transitive-discovery wouldn't fire.
Pairs with if (!args.importer) return null; guard to skip the entry-point itself. Necessary for the test to pass. Slight increase in resolve-time work for non-JS/TS imports (CSS, JSON, etc.) but the early-return in enhancedResolve should make those cheap.
3. Omitted createCombinedBundle plumbing (correct)
On main, #1965 also added bundleTransitiveLocalStepDependencies to createCombinedBundle (4 lines). createCombinedBundle does not exist on stable (confirmed via git show origin/stable:base-builder.ts), so omitting the plumbing is correct.
What the three "Revert" commits did
  • d9f53d1a2 Revert runtime workaround changes — undid stray changes to tarballs/, world-testing/, docs/, changeset file
  • 879abd34b Revert DOMException reducer change — undid serialization.ts modification
  • 186e47269 Revert serialization test mock — undid serialization.test.ts modification
Verified the net effect on each of these files between the cherry-pick commit (2f00a8573) and the PR HEAD (186e47269) is zero — the reverts properly undid the unrelated changes. Only the builders files have net changes, and those are the legitimate adaptations.
Caveat: vade[bot] flagged a transient TS error
The vercel[bot] inline comment on line 253 of swc-esbuild-plugin.test.ts says:
Tests pass Set<string> for state fields but createDiscoverEntriesPlugin expects string[], causing TS2345 compilation errors that break all builds.
This was flagged against an EARLIER commit before the type-widening 796dc4235 landed. The current PR HEAD has the union type fix, so this should no longer apply. Verified locally: pnpm turbo run typecheck --filter @workflow/builders ... is clean.
What I verified locally
  • pnpm install --frozen-lockfile ✓
  • pnpm turbo run build --filter @workflow/builders --filter @workflow/nitro ✓
  • pnpm turbo run typecheck --filter @workflow/builders --filter @workflow/nitro --filter @workflow/next --filter @workflow/sveltekit --filter @workflow/astro --filter @workflow/nest ✓
  • pnpm --filter @workflow/builders test ✓ (144/144)
  • pnpm --filter @workflow/builders exec vitest run src/swc-esbuild-plugin.test.ts ✓ (23/23 — confirms the new regression test passes)
CI
  • 81 success, 2 failure, 2 in-progress, 6 skipped
  • All 42 E2E Local jobs pass (Dev + Prod + Postgres across all workbenches) ✓
  • Unit Tests pass ✓
  • E2E Windows Tests pass ✓
  • Failures: 2 of 11 E2E Vercel Prod Tests (astro, vite) — these look like single-run Vercel infrastructure flakes (the workflow run shows up in the Vercel UI but the test asserted failure). Not specific to this PR.
  • ijjk has already approved (the original author of #1965)
Bottom line
Faithful backport. The #1965 logic ports cleanly; the extra changes are all defensible adaptations to make stable's pre-existing code (string[] vs Set, missing createCombinedBundle) work with the new code from #1965. JJ took the higher-fidelity path (preserve the test verbatim, widen the types) rather than modifying the test, which I think is the right call.
Approving.
@VaguelySeriousVaguelySerious
mentioned this pull request
Jun 2, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@vercelvercel[bot]vercel[bot] left review comments
@TooTallNateTooTallNateTooTallNate approved these changes
@ijjkijjkijjk approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@TooTallNate@ijjk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Backport #1965: Fix Nitro dev loading of local step dependencies - #1968
Merged
TooTallNate merged 6 commits into
stablefrom 
backport/pr-1965-to-stable
May 22, 2026
Merged
Backport #1965: Fix Nitro dev loading of local step dependencies#1968
TooTallNate merged 6 commits into
stablefrom 
backport/pr-1965-to-stable
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
May 11, 2026

Copy link


Copy Markdown

Contributor
Automated backport of #1965 to stable.
AI recommendation: This is a self-contained bug fix for Nitro dev loading of local step dependencies, with new test coverage. It adds an opt-in flag that defaults to existing behavior elsewhere, so it shouldn't conflict with main-only APIs and is valuable to ship on stable if the affected code paths exist there.
Merge conflicts were resolved by AI (opencode with anthropic/claude-opus-4.7). Please review the conflict resolution carefully before merging.
@github-actions
Fix Nitro dev loading of local step dependencies (#1965)
2f00a85
* Fix local step dependency bundling
* Limit local dependency bundling to Nitro dev
Signed-off-by: JJ Kasper <jj@jjsweb.site>
@github-actionsgithub-actionsBot
mentioned this pull request
May 11, 2026
 Merged

@changeset-bot
changeset-botBot
commented
May 11, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 186e472
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/buildersPatch
@workflow/astroPatch
@workflow/cliPatch
@workflow/nestPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/vitestPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/web-sharedPatch
@workflow/webPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
May 11, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, CommentMay 22, 2026 6:58pm
example-nextjs-workflow-webpackReadyReadyPreview, CommentMay 22, 2026 6:58pm
example-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-astro-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-express-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-fastify-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-hono-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-nitro-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-nuxt-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-sveltekit-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-tanstack-start-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-vite-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workflow-swc-playgroundReadyReadyPreview, CommentMay 22, 2026 6:58pm
workflow-tarballsReadyReadyPreview, CommentMay 22, 2026 6:58pm
workflow-webReadyReadyPreview, CommentMay 22, 2026 6:58pm
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
workflow-docsSkippedSkippedMay 22, 2026 6:58pm
vercel[bot]
vercelBot
reviewed
May 11, 2026
View reviewed changes
Comment threadpackages/builders/src/swc-esbuild-plugin.test.ts
@TooTallNate
TooTallNate
requested a review
from a team
as a code ownerMay 22, 2026 16:54
@github-actions
github-actionsBot
commented
May 22, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
🧪 E2E Test Results
❌ Some tests failed
Summary
PassedFailedSkippedTotal
✅ ▲ Vercel Production901067968
✅ 💻 Local Development9700861056
✅ 📦 Local Production9700861056
✅ 🐘 Local Postgres9700861056
✅ 🪟 Windows880088
❌ 🌍 Community Worlds1569084
✅ 📋 Other492036528
Total4406693614836
❌ Failed Tests
🌍 Community Worlds (69 failed)
mongodb-dev (1 failed):
  • dev e2e should rebuild on imported step dependency change
redis-dev (1 failed):
  • dev e2e should rebuild on imported step dependency change
turso-dev (1 failed):
  • dev e2e should rebuild on imported step dependency change
turso (66 failed):
  • addTenWorkflow | wrun_01KS8HKTTW9WBVA0FM02VBPSYR
  • addTenWorkflow | wrun_01KS8HKTTW9WBVA0FM02VBPSYR
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KS8GSH88705N4FSYD9FRQ4TD
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KS8HM1SRMAF4H5XFXQP25NWK
  • promiseRaceWorkflow | wrun_01KS8HM7KTG9PS62ATMZ7VC46Q
  • promiseAnyWorkflow | wrun_01KS8HM9SBQX8DJB8V7CRB7BQF
  • importedStepOnlyWorkflow | wrun_01KS8GSX4PT8SD4KNT47MV3KXB
  • readableStreamWorkflow | wrun_01KS8HMC9SPS1FCEZ0R39T7K9R
  • hookWorkflow | wrun_01KS8HMRZZ3HTY3016Z9DJESK4
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KS8HN0MK1KW4V9T295SBJG8S
  • webhookWorkflow | wrun_01KS8HN5311M5EC889N9M71BZ8
  • sleepingWorkflow | wrun_01KS8HNB78P3N9WG9A9YYA9BEA
  • parallelSleepWorkflow | wrun_01KS8HNTVWY4Z6D96WP2WDDAJK
  • nullByteWorkflow | wrun_01KS8HNYBMY1BWZETSK0VMNFEN
  • workflowAndStepMetadataWorkflow | wrun_01KS8HP0HT4FWTBGFE7A11EGHH
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KS8HRE0E6Z5JYNY0V98AZ6N8
  • fetchWorkflow | wrun_01KS8HRVS9FYNA2323CCHTAVHS
  • promiseRaceStressTestWorkflow | wrun_01KS8HRZKYSXY0NS5RS1P7V2XW
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KS8HWEGPDXEVYVHYRQ4QY76N
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KS8HWWDD0GP1M7FYQAZ6R0Y6
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KS8HXBZA0XKSR8ZESNRQTA6F
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KS8HXX60R3762PPS6V7H14K4
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KS8HY6GSSAXESACFAC6B2NFS
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KS8HYC75GKTKQDS0NY4CH0P0
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KS8HYECSJXQ12S4VX2X6PHRX
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KS8HYYV7MPJN0PX0PSBZ0EH4
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KS8HZ4T4EWZNXY8BP1J24RM9
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KS8HZBZ0Q01P8MS7T6A2VJEQ
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KS8HZJXDRERMDMQRS9AR1DS3
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KS8HZSSSJY84XDW85E4DRC0H
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KS8J0239636SNCPTQ3M8HZ4J
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KS8J09946NQ24E20BF3NV75F
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KS8J0N78M3B0DC2SS2H09J41
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KS8J0YH1Y3KW3S8V1ZADKEGN
  • cancelRun - cancelling a running workflow | wrun_01KS8J16WV7B2CEH955W997097
  • cancelRun via CLI - cancelling a running workflow | wrun_01KS8J1GGBRHY5HG1VMGYEV26T
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KS8J1X0VRXWA0DJH5V8STCQ7
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KS8J2E11966TF78T22BTJYVV
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KS8J2RJXVR9YDC9JACN38WXZ
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KS8J30N70KC61RMM7GF08XYD
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KS8J32Y4FCTAH3PV5CXAVD62
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KS8J35365KQ54Y9NZ86XWVJW
Details by Category
✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro8107
✅ example8107
✅ express8107
✅ fastify8107
✅ hono8107
✅ nextjs-turbopack8602
✅ nextjs-webpack8602
✅ nitro8107
✅ nuxt8107
✅ sveltekit8107
✅ vite8107
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack8800
❌ 🌍 Community Worlds
AppPassedFailedSkipped
❌ mongodb-dev410
❌ redis-dev410
❌ turso-dev410
❌ turso3660
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8206
✅ e2e-local-dev-tanstack-start-stable8206
✅ e2e-local-postgres-nest-stable8206
✅ e2e-local-postgres-tanstack-start-stable8206
✅ e2e-local-prod-nest-stable8206
✅ e2e-local-prod-tanstack-start-stable8206
📋 View full workflow run
@vercel
vercelBottemporarily deployed
to
Preview – workflow-docs
May 22, 2026 18:52
Inactive

TooTallNate
TooTallNate
approved these changes
May 22, 2026
View reviewed changes
@TooTallNateTooTallNate
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faithfulness review: yes, with one caveat
Verified by extracting just the additions/deletions (stripping context lines and metadata) from both #1965 (main) and #1968 (stable) per file:
FileOriginal #1965 logic preserved?
.changeset/narrow-step-bundling.mdbyte-identical
packages/builders/src/swc-esbuild-plugin.tsbyte-identical (context lines differ because surrounding code on stable differs, but the +/- lines match exactly)
packages/builders/src/swc-esbuild-plugin.test.tsnew test added by #1965 is byte-identical
packages/nitro/src/builders.tsbyte-identical
packages/builders/src/base-builder.tsOriginal bundleTransitiveLocalStepDependencies plumbing preserved, plus adaptation code (see below)
packages/builders/src/discover-entries-esbuild-plugin.tsOriginal enhancedResolve.create({...}) change preserved, plus adaptation code (see below)
So the core #1965 logic is faithfully ported. The extra deletions/additions in the GitHub diff (+335/-31 vs +307/-2) are entirely from:
What 796dc4235 ("Fix stable backport build failures") added
Three categories of adaptation, all justified:
1. Set-vs-array typing widening (necessary)
The test file from #1965 uses new Set<string>() for discoveredSteps/discoveredWorkflows/discoveredSerdeFiles because on main those fields had already been changed from string[] to Set<string> before #1965 (unrelated commit). On stable they're still string[].
Two valid adaptations:
  • Modify the test to use [] arrays (breaks test fidelity)
  • Widen the types to accept both (preserves test fidelity)
JJ chose option B. Adds:
  • export type DiscoveredEntryCollection = string[] | Set<string> in base-builder.ts
  • addDiscovered() helper in discover-entries-esbuild-plugin.ts to push to either shape
  • [...discoveredSerdeFiles].filter(...) (because Set has no .filter)
Type widening is safe: DiscoveredEntries is not exported from @workflow/builders/index.ts, so it's internal. No external consumer breakage.
2. filter: jsTsRegex → filter: /.*/ in discover-entries plugin (necessary)
The new test's stepFile imports '../../shared/constants' — extensionless. esbuild's filter: jsTsRegex would NOT match extensionless imports because filters are evaluated against the import path string, not the resolved file. Without this change, the test's transitive-discovery wouldn't fire.
Pairs with if (!args.importer) return null; guard to skip the entry-point itself. Necessary for the test to pass. Slight increase in resolve-time work for non-JS/TS imports (CSS, JSON, etc.) but the early-return in enhancedResolve should make those cheap.
3. Omitted createCombinedBundle plumbing (correct)
On main, #1965 also added bundleTransitiveLocalStepDependencies to createCombinedBundle (4 lines). createCombinedBundle does not exist on stable (confirmed via git show origin/stable:base-builder.ts), so omitting the plumbing is correct.
What the three "Revert" commits did
  • d9f53d1a2 Revert runtime workaround changes — undid stray changes to tarballs/, world-testing/, docs/, changeset file
  • 879abd34b Revert DOMException reducer change — undid serialization.ts modification
  • 186e47269 Revert serialization test mock — undid serialization.test.ts modification
Verified the net effect on each of these files between the cherry-pick commit (2f00a8573) and the PR HEAD (186e47269) is zero — the reverts properly undid the unrelated changes. Only the builders files have net changes, and those are the legitimate adaptations.
Caveat: vade[bot] flagged a transient TS error
The vercel[bot] inline comment on line 253 of swc-esbuild-plugin.test.ts says:
Tests pass Set<string> for state fields but createDiscoverEntriesPlugin expects string[], causing TS2345 compilation errors that break all builds.
This was flagged against an EARLIER commit before the type-widening 796dc4235 landed. The current PR HEAD has the union type fix, so this should no longer apply. Verified locally: pnpm turbo run typecheck --filter @workflow/builders ... is clean.
What I verified locally
  • pnpm install --frozen-lockfile ✓
  • pnpm turbo run build --filter @workflow/builders --filter @workflow/nitro ✓
  • pnpm turbo run typecheck --filter @workflow/builders --filter @workflow/nitro --filter @workflow/next --filter @workflow/sveltekit --filter @workflow/astro --filter @workflow/nest ✓
  • pnpm --filter @workflow/builders test ✓ (144/144)
  • pnpm --filter @workflow/builders exec vitest run src/swc-esbuild-plugin.test.ts ✓ (23/23 — confirms the new regression test passes)
CI
  • 81 success, 2 failure, 2 in-progress, 6 skipped
  • All 42 E2E Local jobs pass (Dev + Prod + Postgres across all workbenches) ✓
  • Unit Tests pass ✓
  • E2E Windows Tests pass ✓
  • Failures: 2 of 11 E2E Vercel Prod Tests (astro, vite) — these look like single-run Vercel infrastructure flakes (the workflow run shows up in the Vercel UI but the test asserted failure). Not specific to this PR.
  • ijjk has already approved (the original author of #1965)
Bottom line
Faithful backport. The #1965 logic ports cleanly; the extra changes are all defensible adaptations to make stable's pre-existing code (string[] vs Set, missing createCombinedBundle) work with the new code from #1965. JJ took the higher-fidelity path (preserve the test verbatim, widen the types) rather than modifying the test, which I think is the right call.
Approving.
@VaguelySeriousVaguelySerious
mentioned this pull request
Jun 2, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@vercelvercel[bot]vercel[bot] left review comments
@TooTallNateTooTallNateTooTallNate approved these changes
@ijjkijjkijjk approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@TooTallNate@ijjk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Backport #1965: Fix Nitro dev loading of local step dependencies - #1968
Merged
TooTallNate merged 6 commits into
stablefrom 
backport/pr-1965-to-stable
May 22, 2026
Merged
Backport #1965: Fix Nitro dev loading of local step dependencies#1968
TooTallNate merged 6 commits into
stablefrom 
backport/pr-1965-to-stable
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
May 11, 2026

Copy link


Copy Markdown

Contributor
Automated backport of #1965 to stable.
AI recommendation: This is a self-contained bug fix for Nitro dev loading of local step dependencies, with new test coverage. It adds an opt-in flag that defaults to existing behavior elsewhere, so it shouldn't conflict with main-only APIs and is valuable to ship on stable if the affected code paths exist there.
Merge conflicts were resolved by AI (opencode with anthropic/claude-opus-4.7). Please review the conflict resolution carefully before merging.
@github-actions
Fix Nitro dev loading of local step dependencies (#1965)
2f00a85
* Fix local step dependency bundling
* Limit local dependency bundling to Nitro dev
Signed-off-by: JJ Kasper <jj@jjsweb.site>
@github-actionsgithub-actionsBot
mentioned this pull request
May 11, 2026
 Merged

@changeset-bot
changeset-botBot
commented
May 11, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 186e472
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/buildersPatch
@workflow/astroPatch
@workflow/cliPatch
@workflow/nestPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/vitestPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/web-sharedPatch
@workflow/webPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
May 11, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, CommentMay 22, 2026 6:58pm
example-nextjs-workflow-webpackReadyReadyPreview, CommentMay 22, 2026 6:58pm
example-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-astro-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-express-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-fastify-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-hono-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-nitro-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-nuxt-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-sveltekit-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-tanstack-start-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-vite-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workflow-swc-playgroundReadyReadyPreview, CommentMay 22, 2026 6:58pm
workflow-tarballsReadyReadyPreview, CommentMay 22, 2026 6:58pm
workflow-webReadyReadyPreview, CommentMay 22, 2026 6:58pm
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
workflow-docsSkippedSkippedMay 22, 2026 6:58pm
vercel[bot]
vercelBot
reviewed
May 11, 2026
View reviewed changes
Comment threadpackages/builders/src/swc-esbuild-plugin.test.ts
@TooTallNate
TooTallNate
requested a review
from a team
as a code ownerMay 22, 2026 16:54
@github-actions
github-actionsBot
commented
May 22, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
🧪 E2E Test Results
❌ Some tests failed
Summary
PassedFailedSkippedTotal
✅ ▲ Vercel Production901067968
✅ 💻 Local Development9700861056
✅ 📦 Local Production9700861056
✅ 🐘 Local Postgres9700861056
✅ 🪟 Windows880088
❌ 🌍 Community Worlds1569084
✅ 📋 Other492036528
Total4406693614836
❌ Failed Tests
🌍 Community Worlds (69 failed)
mongodb-dev (1 failed):
  • dev e2e should rebuild on imported step dependency change
redis-dev (1 failed):
  • dev e2e should rebuild on imported step dependency change
turso-dev (1 failed):
  • dev e2e should rebuild on imported step dependency change
turso (66 failed):
  • addTenWorkflow | wrun_01KS8HKTTW9WBVA0FM02VBPSYR
  • addTenWorkflow | wrun_01KS8HKTTW9WBVA0FM02VBPSYR
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KS8GSH88705N4FSYD9FRQ4TD
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KS8HM1SRMAF4H5XFXQP25NWK
  • promiseRaceWorkflow | wrun_01KS8HM7KTG9PS62ATMZ7VC46Q
  • promiseAnyWorkflow | wrun_01KS8HM9SBQX8DJB8V7CRB7BQF
  • importedStepOnlyWorkflow | wrun_01KS8GSX4PT8SD4KNT47MV3KXB
  • readableStreamWorkflow | wrun_01KS8HMC9SPS1FCEZ0R39T7K9R
  • hookWorkflow | wrun_01KS8HMRZZ3HTY3016Z9DJESK4
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KS8HN0MK1KW4V9T295SBJG8S
  • webhookWorkflow | wrun_01KS8HN5311M5EC889N9M71BZ8
  • sleepingWorkflow | wrun_01KS8HNB78P3N9WG9A9YYA9BEA
  • parallelSleepWorkflow | wrun_01KS8HNTVWY4Z6D96WP2WDDAJK
  • nullByteWorkflow | wrun_01KS8HNYBMY1BWZETSK0VMNFEN
  • workflowAndStepMetadataWorkflow | wrun_01KS8HP0HT4FWTBGFE7A11EGHH
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KS8HRE0E6Z5JYNY0V98AZ6N8
  • fetchWorkflow | wrun_01KS8HRVS9FYNA2323CCHTAVHS
  • promiseRaceStressTestWorkflow | wrun_01KS8HRZKYSXY0NS5RS1P7V2XW
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KS8HWEGPDXEVYVHYRQ4QY76N
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KS8HWWDD0GP1M7FYQAZ6R0Y6
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KS8HXBZA0XKSR8ZESNRQTA6F
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KS8HXX60R3762PPS6V7H14K4
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KS8HY6GSSAXESACFAC6B2NFS
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KS8HYC75GKTKQDS0NY4CH0P0
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KS8HYECSJXQ12S4VX2X6PHRX
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KS8HYYV7MPJN0PX0PSBZ0EH4
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KS8HZ4T4EWZNXY8BP1J24RM9
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KS8HZBZ0Q01P8MS7T6A2VJEQ
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KS8HZJXDRERMDMQRS9AR1DS3
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KS8HZSSSJY84XDW85E4DRC0H
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KS8J0239636SNCPTQ3M8HZ4J
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KS8J09946NQ24E20BF3NV75F
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KS8J0N78M3B0DC2SS2H09J41
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KS8J0YH1Y3KW3S8V1ZADKEGN
  • cancelRun - cancelling a running workflow | wrun_01KS8J16WV7B2CEH955W997097
  • cancelRun via CLI - cancelling a running workflow | wrun_01KS8J1GGBRHY5HG1VMGYEV26T
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KS8J1X0VRXWA0DJH5V8STCQ7
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KS8J2E11966TF78T22BTJYVV
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KS8J2RJXVR9YDC9JACN38WXZ
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KS8J30N70KC61RMM7GF08XYD
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KS8J32Y4FCTAH3PV5CXAVD62
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KS8J35365KQ54Y9NZ86XWVJW
Details by Category
✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro8107
✅ example8107
✅ express8107
✅ fastify8107
✅ hono8107
✅ nextjs-turbopack8602
✅ nextjs-webpack8602
✅ nitro8107
✅ nuxt8107
✅ sveltekit8107
✅ vite8107
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack8800
❌ 🌍 Community Worlds
AppPassedFailedSkipped
❌ mongodb-dev410
❌ redis-dev410
❌ turso-dev410
❌ turso3660
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8206
✅ e2e-local-dev-tanstack-start-stable8206
✅ e2e-local-postgres-nest-stable8206
✅ e2e-local-postgres-tanstack-start-stable8206
✅ e2e-local-prod-nest-stable8206
✅ e2e-local-prod-tanstack-start-stable8206
📋 View full workflow run
@vercel
vercelBottemporarily deployed
to
Preview – workflow-docs
May 22, 2026 18:52
Inactive

TooTallNate
TooTallNate
approved these changes
May 22, 2026
View reviewed changes
@TooTallNateTooTallNate
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faithfulness review: yes, with one caveat
Verified by extracting just the additions/deletions (stripping context lines and metadata) from both #1965 (main) and #1968 (stable) per file:
FileOriginal #1965 logic preserved?
.changeset/narrow-step-bundling.mdbyte-identical
packages/builders/src/swc-esbuild-plugin.tsbyte-identical (context lines differ because surrounding code on stable differs, but the +/- lines match exactly)
packages/builders/src/swc-esbuild-plugin.test.tsnew test added by #1965 is byte-identical
packages/nitro/src/builders.tsbyte-identical
packages/builders/src/base-builder.tsOriginal bundleTransitiveLocalStepDependencies plumbing preserved, plus adaptation code (see below)
packages/builders/src/discover-entries-esbuild-plugin.tsOriginal enhancedResolve.create({...}) change preserved, plus adaptation code (see below)
So the core #1965 logic is faithfully ported. The extra deletions/additions in the GitHub diff (+335/-31 vs +307/-2) are entirely from:
What 796dc4235 ("Fix stable backport build failures") added
Three categories of adaptation, all justified:
1. Set-vs-array typing widening (necessary)
The test file from #1965 uses new Set<string>() for discoveredSteps/discoveredWorkflows/discoveredSerdeFiles because on main those fields had already been changed from string[] to Set<string> before #1965 (unrelated commit). On stable they're still string[].
Two valid adaptations:
  • Modify the test to use [] arrays (breaks test fidelity)
  • Widen the types to accept both (preserves test fidelity)
JJ chose option B. Adds:
  • export type DiscoveredEntryCollection = string[] | Set<string> in base-builder.ts
  • addDiscovered() helper in discover-entries-esbuild-plugin.ts to push to either shape
  • [...discoveredSerdeFiles].filter(...) (because Set has no .filter)
Type widening is safe: DiscoveredEntries is not exported from @workflow/builders/index.ts, so it's internal. No external consumer breakage.
2. filter: jsTsRegex → filter: /.*/ in discover-entries plugin (necessary)
The new test's stepFile imports '../../shared/constants' — extensionless. esbuild's filter: jsTsRegex would NOT match extensionless imports because filters are evaluated against the import path string, not the resolved file. Without this change, the test's transitive-discovery wouldn't fire.
Pairs with if (!args.importer) return null; guard to skip the entry-point itself. Necessary for the test to pass. Slight increase in resolve-time work for non-JS/TS imports (CSS, JSON, etc.) but the early-return in enhancedResolve should make those cheap.
3. Omitted createCombinedBundle plumbing (correct)
On main, #1965 also added bundleTransitiveLocalStepDependencies to createCombinedBundle (4 lines). createCombinedBundle does not exist on stable (confirmed via git show origin/stable:base-builder.ts), so omitting the plumbing is correct.
What the three "Revert" commits did
  • d9f53d1a2 Revert runtime workaround changes — undid stray changes to tarballs/, world-testing/, docs/, changeset file
  • 879abd34b Revert DOMException reducer change — undid serialization.ts modification
  • 186e47269 Revert serialization test mock — undid serialization.test.ts modification
Verified the net effect on each of these files between the cherry-pick commit (2f00a8573) and the PR HEAD (186e47269) is zero — the reverts properly undid the unrelated changes. Only the builders files have net changes, and those are the legitimate adaptations.
Caveat: vade[bot] flagged a transient TS error
The vercel[bot] inline comment on line 253 of swc-esbuild-plugin.test.ts says:
Tests pass Set<string> for state fields but createDiscoverEntriesPlugin expects string[], causing TS2345 compilation errors that break all builds.
This was flagged against an EARLIER commit before the type-widening 796dc4235 landed. The current PR HEAD has the union type fix, so this should no longer apply. Verified locally: pnpm turbo run typecheck --filter @workflow/builders ... is clean.
What I verified locally
  • pnpm install --frozen-lockfile ✓
  • pnpm turbo run build --filter @workflow/builders --filter @workflow/nitro ✓
  • pnpm turbo run typecheck --filter @workflow/builders --filter @workflow/nitro --filter @workflow/next --filter @workflow/sveltekit --filter @workflow/astro --filter @workflow/nest ✓
  • pnpm --filter @workflow/builders test ✓ (144/144)
  • pnpm --filter @workflow/builders exec vitest run src/swc-esbuild-plugin.test.ts ✓ (23/23 — confirms the new regression test passes)
CI
  • 81 success, 2 failure, 2 in-progress, 6 skipped
  • All 42 E2E Local jobs pass (Dev + Prod + Postgres across all workbenches) ✓
  • Unit Tests pass ✓
  • E2E Windows Tests pass ✓
  • Failures: 2 of 11 E2E Vercel Prod Tests (astro, vite) — these look like single-run Vercel infrastructure flakes (the workflow run shows up in the Vercel UI but the test asserted failure). Not specific to this PR.
  • ijjk has already approved (the original author of #1965)
Bottom line
Faithful backport. The #1965 logic ports cleanly; the extra changes are all defensible adaptations to make stable's pre-existing code (string[] vs Set, missing createCombinedBundle) work with the new code from #1965. JJ took the higher-fidelity path (preserve the test verbatim, widen the types) rather than modifying the test, which I think is the right call.
Approving.
@VaguelySeriousVaguelySerious
mentioned this pull request
Jun 2, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@vercelvercel[bot]vercel[bot] left review comments
@TooTallNateTooTallNateTooTallNate approved these changes
@ijjkijjkijjk approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@TooTallNate@ijjk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Backport #1965: Fix Nitro dev loading of local step dependencies - #1968
Merged
TooTallNate merged 6 commits into
stablefrom 
backport/pr-1965-to-stable
May 22, 2026
Merged
Backport #1965: Fix Nitro dev loading of local step dependencies#1968
TooTallNate merged 6 commits into
stablefrom 
backport/pr-1965-to-stable
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
May 11, 2026

Copy link


Copy Markdown

Contributor
Automated backport of #1965 to stable.
AI recommendation: This is a self-contained bug fix for Nitro dev loading of local step dependencies, with new test coverage. It adds an opt-in flag that defaults to existing behavior elsewhere, so it shouldn't conflict with main-only APIs and is valuable to ship on stable if the affected code paths exist there.
Merge conflicts were resolved by AI (opencode with anthropic/claude-opus-4.7). Please review the conflict resolution carefully before merging.
@github-actions
Fix Nitro dev loading of local step dependencies (#1965)
2f00a85
* Fix local step dependency bundling
* Limit local dependency bundling to Nitro dev
Signed-off-by: JJ Kasper <jj@jjsweb.site>
@github-actionsgithub-actionsBot
mentioned this pull request
May 11, 2026
 Merged

@changeset-bot
changeset-botBot
commented
May 11, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 186e472
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/buildersPatch
@workflow/astroPatch
@workflow/cliPatch
@workflow/nestPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/vitestPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/web-sharedPatch
@workflow/webPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
May 11, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, CommentMay 22, 2026 6:58pm
example-nextjs-workflow-webpackReadyReadyPreview, CommentMay 22, 2026 6:58pm
example-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-astro-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-express-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-fastify-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-hono-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-nitro-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-nuxt-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-sveltekit-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-tanstack-start-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-vite-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workflow-swc-playgroundReadyReadyPreview, CommentMay 22, 2026 6:58pm
workflow-tarballsReadyReadyPreview, CommentMay 22, 2026 6:58pm
workflow-webReadyReadyPreview, CommentMay 22, 2026 6:58pm
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
workflow-docsSkippedSkippedMay 22, 2026 6:58pm
vercel[bot]
vercelBot
reviewed
May 11, 2026
View reviewed changes
Comment threadpackages/builders/src/swc-esbuild-plugin.test.ts
@TooTallNate
TooTallNate
requested a review
from a team
as a code ownerMay 22, 2026 16:54
@github-actions
github-actionsBot
commented
May 22, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
🧪 E2E Test Results
❌ Some tests failed
Summary
PassedFailedSkippedTotal
✅ ▲ Vercel Production901067968
✅ 💻 Local Development9700861056
✅ 📦 Local Production9700861056
✅ 🐘 Local Postgres9700861056
✅ 🪟 Windows880088
❌ 🌍 Community Worlds1569084
✅ 📋 Other492036528
Total4406693614836
❌ Failed Tests
🌍 Community Worlds (69 failed)
mongodb-dev (1 failed):
  • dev e2e should rebuild on imported step dependency change
redis-dev (1 failed):
  • dev e2e should rebuild on imported step dependency change
turso-dev (1 failed):
  • dev e2e should rebuild on imported step dependency change
turso (66 failed):
  • addTenWorkflow | wrun_01KS8HKTTW9WBVA0FM02VBPSYR
  • addTenWorkflow | wrun_01KS8HKTTW9WBVA0FM02VBPSYR
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KS8GSH88705N4FSYD9FRQ4TD
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KS8HM1SRMAF4H5XFXQP25NWK
  • promiseRaceWorkflow | wrun_01KS8HM7KTG9PS62ATMZ7VC46Q
  • promiseAnyWorkflow | wrun_01KS8HM9SBQX8DJB8V7CRB7BQF
  • importedStepOnlyWorkflow | wrun_01KS8GSX4PT8SD4KNT47MV3KXB
  • readableStreamWorkflow | wrun_01KS8HMC9SPS1FCEZ0R39T7K9R
  • hookWorkflow | wrun_01KS8HMRZZ3HTY3016Z9DJESK4
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KS8HN0MK1KW4V9T295SBJG8S
  • webhookWorkflow | wrun_01KS8HN5311M5EC889N9M71BZ8
  • sleepingWorkflow | wrun_01KS8HNB78P3N9WG9A9YYA9BEA
  • parallelSleepWorkflow | wrun_01KS8HNTVWY4Z6D96WP2WDDAJK
  • nullByteWorkflow | wrun_01KS8HNYBMY1BWZETSK0VMNFEN
  • workflowAndStepMetadataWorkflow | wrun_01KS8HP0HT4FWTBGFE7A11EGHH
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KS8HRE0E6Z5JYNY0V98AZ6N8
  • fetchWorkflow | wrun_01KS8HRVS9FYNA2323CCHTAVHS
  • promiseRaceStressTestWorkflow | wrun_01KS8HRZKYSXY0NS5RS1P7V2XW
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KS8HWEGPDXEVYVHYRQ4QY76N
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KS8HWWDD0GP1M7FYQAZ6R0Y6
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KS8HXBZA0XKSR8ZESNRQTA6F
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KS8HXX60R3762PPS6V7H14K4
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KS8HY6GSSAXESACFAC6B2NFS
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KS8HYC75GKTKQDS0NY4CH0P0
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KS8HYECSJXQ12S4VX2X6PHRX
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KS8HYYV7MPJN0PX0PSBZ0EH4
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KS8HZ4T4EWZNXY8BP1J24RM9
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KS8HZBZ0Q01P8MS7T6A2VJEQ
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KS8HZJXDRERMDMQRS9AR1DS3
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KS8HZSSSJY84XDW85E4DRC0H
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KS8J0239636SNCPTQ3M8HZ4J
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KS8J09946NQ24E20BF3NV75F
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KS8J0N78M3B0DC2SS2H09J41
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KS8J0YH1Y3KW3S8V1ZADKEGN
  • cancelRun - cancelling a running workflow | wrun_01KS8J16WV7B2CEH955W997097
  • cancelRun via CLI - cancelling a running workflow | wrun_01KS8J1GGBRHY5HG1VMGYEV26T
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KS8J1X0VRXWA0DJH5V8STCQ7
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KS8J2E11966TF78T22BTJYVV
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KS8J2RJXVR9YDC9JACN38WXZ
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KS8J30N70KC61RMM7GF08XYD
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KS8J32Y4FCTAH3PV5CXAVD62
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KS8J35365KQ54Y9NZ86XWVJW
Details by Category
✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro8107
✅ example8107
✅ express8107
✅ fastify8107
✅ hono8107
✅ nextjs-turbopack8602
✅ nextjs-webpack8602
✅ nitro8107
✅ nuxt8107
✅ sveltekit8107
✅ vite8107
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack8800
❌ 🌍 Community Worlds
AppPassedFailedSkipped
❌ mongodb-dev410
❌ redis-dev410
❌ turso-dev410
❌ turso3660
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8206
✅ e2e-local-dev-tanstack-start-stable8206
✅ e2e-local-postgres-nest-stable8206
✅ e2e-local-postgres-tanstack-start-stable8206
✅ e2e-local-prod-nest-stable8206
✅ e2e-local-prod-tanstack-start-stable8206
📋 View full workflow run
@vercel
vercelBottemporarily deployed
to
Preview – workflow-docs
May 22, 2026 18:52
Inactive

TooTallNate
TooTallNate
approved these changes
May 22, 2026
View reviewed changes
@TooTallNateTooTallNate
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faithfulness review: yes, with one caveat
Verified by extracting just the additions/deletions (stripping context lines and metadata) from both #1965 (main) and #1968 (stable) per file:
FileOriginal #1965 logic preserved?
.changeset/narrow-step-bundling.mdbyte-identical
packages/builders/src/swc-esbuild-plugin.tsbyte-identical (context lines differ because surrounding code on stable differs, but the +/- lines match exactly)
packages/builders/src/swc-esbuild-plugin.test.tsnew test added by #1965 is byte-identical
packages/nitro/src/builders.tsbyte-identical
packages/builders/src/base-builder.tsOriginal bundleTransitiveLocalStepDependencies plumbing preserved, plus adaptation code (see below)
packages/builders/src/discover-entries-esbuild-plugin.tsOriginal enhancedResolve.create({...}) change preserved, plus adaptation code (see below)
So the core #1965 logic is faithfully ported. The extra deletions/additions in the GitHub diff (+335/-31 vs +307/-2) are entirely from:
What 796dc4235 ("Fix stable backport build failures") added
Three categories of adaptation, all justified:
1. Set-vs-array typing widening (necessary)
The test file from #1965 uses new Set<string>() for discoveredSteps/discoveredWorkflows/discoveredSerdeFiles because on main those fields had already been changed from string[] to Set<string> before #1965 (unrelated commit). On stable they're still string[].
Two valid adaptations:
  • Modify the test to use [] arrays (breaks test fidelity)
  • Widen the types to accept both (preserves test fidelity)
JJ chose option B. Adds:
  • export type DiscoveredEntryCollection = string[] | Set<string> in base-builder.ts
  • addDiscovered() helper in discover-entries-esbuild-plugin.ts to push to either shape
  • [...discoveredSerdeFiles].filter(...) (because Set has no .filter)
Type widening is safe: DiscoveredEntries is not exported from @workflow/builders/index.ts, so it's internal. No external consumer breakage.
2. filter: jsTsRegex → filter: /.*/ in discover-entries plugin (necessary)
The new test's stepFile imports '../../shared/constants' — extensionless. esbuild's filter: jsTsRegex would NOT match extensionless imports because filters are evaluated against the import path string, not the resolved file. Without this change, the test's transitive-discovery wouldn't fire.
Pairs with if (!args.importer) return null; guard to skip the entry-point itself. Necessary for the test to pass. Slight increase in resolve-time work for non-JS/TS imports (CSS, JSON, etc.) but the early-return in enhancedResolve should make those cheap.
3. Omitted createCombinedBundle plumbing (correct)
On main, #1965 also added bundleTransitiveLocalStepDependencies to createCombinedBundle (4 lines). createCombinedBundle does not exist on stable (confirmed via git show origin/stable:base-builder.ts), so omitting the plumbing is correct.
What the three "Revert" commits did
  • d9f53d1a2 Revert runtime workaround changes — undid stray changes to tarballs/, world-testing/, docs/, changeset file
  • 879abd34b Revert DOMException reducer change — undid serialization.ts modification
  • 186e47269 Revert serialization test mock — undid serialization.test.ts modification
Verified the net effect on each of these files between the cherry-pick commit (2f00a8573) and the PR HEAD (186e47269) is zero — the reverts properly undid the unrelated changes. Only the builders files have net changes, and those are the legitimate adaptations.
Caveat: vade[bot] flagged a transient TS error
The vercel[bot] inline comment on line 253 of swc-esbuild-plugin.test.ts says:
Tests pass Set<string> for state fields but createDiscoverEntriesPlugin expects string[], causing TS2345 compilation errors that break all builds.
This was flagged against an EARLIER commit before the type-widening 796dc4235 landed. The current PR HEAD has the union type fix, so this should no longer apply. Verified locally: pnpm turbo run typecheck --filter @workflow/builders ... is clean.
What I verified locally
  • pnpm install --frozen-lockfile ✓
  • pnpm turbo run build --filter @workflow/builders --filter @workflow/nitro ✓
  • pnpm turbo run typecheck --filter @workflow/builders --filter @workflow/nitro --filter @workflow/next --filter @workflow/sveltekit --filter @workflow/astro --filter @workflow/nest ✓
  • pnpm --filter @workflow/builders test ✓ (144/144)
  • pnpm --filter @workflow/builders exec vitest run src/swc-esbuild-plugin.test.ts ✓ (23/23 — confirms the new regression test passes)
CI
  • 81 success, 2 failure, 2 in-progress, 6 skipped
  • All 42 E2E Local jobs pass (Dev + Prod + Postgres across all workbenches) ✓
  • Unit Tests pass ✓
  • E2E Windows Tests pass ✓
  • Failures: 2 of 11 E2E Vercel Prod Tests (astro, vite) — these look like single-run Vercel infrastructure flakes (the workflow run shows up in the Vercel UI but the test asserted failure). Not specific to this PR.
  • ijjk has already approved (the original author of #1965)
Bottom line
Faithful backport. The #1965 logic ports cleanly; the extra changes are all defensible adaptations to make stable's pre-existing code (string[] vs Set, missing createCombinedBundle) work with the new code from #1965. JJ took the higher-fidelity path (preserve the test verbatim, widen the types) rather than modifying the test, which I think is the right call.
Approving.
@VaguelySeriousVaguelySerious
mentioned this pull request
Jun 2, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@vercelvercel[bot]vercel[bot] left review comments
@TooTallNateTooTallNateTooTallNate approved these changes
@ijjkijjkijjk approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@TooTallNate@ijjk

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Backport #1965: Fix Nitro dev loading of local step dependencies - #1968
Merged
TooTallNate merged 6 commits into
stablefrom 
backport/pr-1965-to-stable
May 22, 2026
Merged
Backport #1965: Fix Nitro dev loading of local step dependencies#1968
TooTallNate merged 6 commits into
stablefrom 
backport/pr-1965-to-stable
Conversation
@github-actions
@github-actionsgithub-actionsBot
commented
May 11, 2026

Copy link


Copy Markdown

Contributor
Automated backport of #1965 to stable.
AI recommendation: This is a self-contained bug fix for Nitro dev loading of local step dependencies, with new test coverage. It adds an opt-in flag that defaults to existing behavior elsewhere, so it shouldn't conflict with main-only APIs and is valuable to ship on stable if the affected code paths exist there.
Merge conflicts were resolved by AI (opencode with anthropic/claude-opus-4.7). Please review the conflict resolution carefully before merging.
@github-actions
Fix Nitro dev loading of local step dependencies (#1965)
2f00a85
* Fix local step dependency bundling
* Limit local dependency bundling to Nitro dev
Signed-off-by: JJ Kasper <jj@jjsweb.site>
@github-actionsgithub-actionsBot
mentioned this pull request
May 11, 2026
 Merged

@changeset-bot
changeset-botBot
commented
May 11, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 186e472
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/buildersPatch
@workflow/astroPatch
@workflow/cliPatch
@workflow/nestPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/vitestPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/web-sharedPatch
@workflow/webPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
May 11, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, CommentMay 22, 2026 6:58pm
example-nextjs-workflow-webpackReadyReadyPreview, CommentMay 22, 2026 6:58pm
example-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-astro-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-express-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-fastify-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-hono-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-nitro-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-nuxt-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-sveltekit-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-tanstack-start-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workbench-vite-workflowReadyReadyPreview, CommentMay 22, 2026 6:58pm
workflow-swc-playgroundReadyReadyPreview, CommentMay 22, 2026 6:58pm
workflow-tarballsReadyReadyPreview, CommentMay 22, 2026 6:58pm
workflow-webReadyReadyPreview, CommentMay 22, 2026 6:58pm
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
workflow-docsSkippedSkippedMay 22, 2026 6:58pm
vercel[bot]
vercelBot
reviewed
May 11, 2026
View reviewed changes
Comment threadpackages/builders/src/swc-esbuild-plugin.test.ts
@TooTallNate
TooTallNate
requested a review
from a team
as a code ownerMay 22, 2026 16:54
@github-actions
github-actionsBot
commented
May 22, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
🧪 E2E Test Results
❌ Some tests failed
Summary
PassedFailedSkippedTotal
✅ ▲ Vercel Production901067968
✅ 💻 Local Development9700861056
✅ 📦 Local Production9700861056
✅ 🐘 Local Postgres9700861056
✅ 🪟 Windows880088
❌ 🌍 Community Worlds1569084
✅ 📋 Other492036528
Total4406693614836
❌ Failed Tests
🌍 Community Worlds (69 failed)
mongodb-dev (1 failed):
  • dev e2e should rebuild on imported step dependency change
redis-dev (1 failed):
  • dev e2e should rebuild on imported step dependency change
turso-dev (1 failed):
  • dev e2e should rebuild on imported step dependency change
turso (66 failed):
  • addTenWorkflow | wrun_01KS8HKTTW9WBVA0FM02VBPSYR
  • addTenWorkflow | wrun_01KS8HKTTW9WBVA0FM02VBPSYR
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KS8GSH88705N4FSYD9FRQ4TD
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KS8HM1SRMAF4H5XFXQP25NWK
  • promiseRaceWorkflow | wrun_01KS8HM7KTG9PS62ATMZ7VC46Q
  • promiseAnyWorkflow | wrun_01KS8HM9SBQX8DJB8V7CRB7BQF
  • importedStepOnlyWorkflow | wrun_01KS8GSX4PT8SD4KNT47MV3KXB
  • readableStreamWorkflow | wrun_01KS8HMC9SPS1FCEZ0R39T7K9R
  • hookWorkflow | wrun_01KS8HMRZZ3HTY3016Z9DJESK4
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KS8HN0MK1KW4V9T295SBJG8S
  • webhookWorkflow | wrun_01KS8HN5311M5EC889N9M71BZ8
  • sleepingWorkflow | wrun_01KS8HNB78P3N9WG9A9YYA9BEA
  • parallelSleepWorkflow | wrun_01KS8HNTVWY4Z6D96WP2WDDAJK
  • nullByteWorkflow | wrun_01KS8HNYBMY1BWZETSK0VMNFEN
  • workflowAndStepMetadataWorkflow | wrun_01KS8HP0HT4FWTBGFE7A11EGHH
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KS8HRE0E6Z5JYNY0V98AZ6N8
  • fetchWorkflow | wrun_01KS8HRVS9FYNA2323CCHTAVHS
  • promiseRaceStressTestWorkflow | wrun_01KS8HRZKYSXY0NS5RS1P7V2XW
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KS8HWEGPDXEVYVHYRQ4QY76N
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KS8HWWDD0GP1M7FYQAZ6R0Y6
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KS8HXBZA0XKSR8ZESNRQTA6F
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KS8HXX60R3762PPS6V7H14K4
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KS8HY6GSSAXESACFAC6B2NFS
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KS8HYC75GKTKQDS0NY4CH0P0
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KS8HYECSJXQ12S4VX2X6PHRX
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KS8HYYV7MPJN0PX0PSBZ0EH4
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KS8HZ4T4EWZNXY8BP1J24RM9
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KS8HZBZ0Q01P8MS7T6A2VJEQ
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KS8HZJXDRERMDMQRS9AR1DS3
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KS8HZSSSJY84XDW85E4DRC0H
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KS8J0239636SNCPTQ3M8HZ4J
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KS8J09946NQ24E20BF3NV75F
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KS8J0N78M3B0DC2SS2H09J41
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KS8J0YH1Y3KW3S8V1ZADKEGN
  • cancelRun - cancelling a running workflow | wrun_01KS8J16WV7B2CEH955W997097
  • cancelRun via CLI - cancelling a running workflow | wrun_01KS8J1GGBRHY5HG1VMGYEV26T
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KS8J1X0VRXWA0DJH5V8STCQ7
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KS8J2E11966TF78T22BTJYVV
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KS8J2RJXVR9YDC9JACN38WXZ
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KS8J30N70KC61RMM7GF08XYD
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KS8J32Y4FCTAH3PV5CXAVD62
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KS8J35365KQ54Y9NZ86XWVJW
Details by Category
✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro8107
✅ example8107
✅ express8107
✅ fastify8107
✅ hono8107
✅ nextjs-turbopack8602
✅ nextjs-webpack8602
✅ nitro8107
✅ nuxt8107
✅ sveltekit8107
✅ vite8107
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack8800
❌ 🌍 Community Worlds
AppPassedFailedSkipped
❌ mongodb-dev410
❌ redis-dev410
❌ turso-dev410
❌ turso3660
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8206
✅ e2e-local-dev-tanstack-start-stable8206
✅ e2e-local-postgres-nest-stable8206
✅ e2e-local-postgres-tanstack-start-stable8206
✅ e2e-local-prod-nest-stable8206
✅ e2e-local-prod-tanstack-start-stable8206
📋 View full workflow run
@vercel
vercelBottemporarily deployed
to
Preview – workflow-docs
May 22, 2026 18:52
Inactive

TooTallNate
TooTallNate
approved these changes
May 22, 2026
View reviewed changes
@TooTallNateTooTallNate
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faithfulness review: yes, with one caveat
Verified by extracting just the additions/deletions (stripping context lines and metadata) from both #1965 (main) and #1968 (stable) per file:
FileOriginal #1965 logic preserved?
.changeset/narrow-step-bundling.mdbyte-identical
packages/builders/src/swc-esbuild-plugin.tsbyte-identical (context lines differ because surrounding code on stable differs, but the +/- lines match exactly)
packages/builders/src/swc-esbuild-plugin.test.tsnew test added by #1965 is byte-identical
packages/nitro/src/builders.tsbyte-identical
packages/builders/src/base-builder.tsOriginal bundleTransitiveLocalStepDependencies plumbing preserved, plus adaptation code (see below)
packages/builders/src/discover-entries-esbuild-plugin.tsOriginal enhancedResolve.create({...}) change preserved, plus adaptation code (see below)
So the core #1965 logic is faithfully ported. The extra deletions/additions in the GitHub diff (+335/-31 vs +307/-2) are entirely from:
What 796dc4235 ("Fix stable backport build failures") added
Three categories of adaptation, all justified:
1. Set-vs-array typing widening (necessary)
The test file from #1965 uses new Set<string>() for discoveredSteps/discoveredWorkflows/discoveredSerdeFiles because on main those fields had already been changed from string[] to Set<string> before #1965 (unrelated commit). On stable they're still string[].
Two valid adaptations:
  • Modify the test to use [] arrays (breaks test fidelity)
  • Widen the types to accept both (preserves test fidelity)
JJ chose option B. Adds:
  • export type DiscoveredEntryCollection = string[] | Set<string> in base-builder.ts
  • addDiscovered() helper in discover-entries-esbuild-plugin.ts to push to either shape
  • [...discoveredSerdeFiles].filter(...) (because Set has no .filter)
Type widening is safe: DiscoveredEntries is not exported from @workflow/builders/index.ts, so it's internal. No external consumer breakage.
2. filter: jsTsRegex → filter: /.*/ in discover-entries plugin (necessary)
The new test's stepFile imports '../../shared/constants' — extensionless. esbuild's filter: jsTsRegex would NOT match extensionless imports because filters are evaluated against the import path string, not the resolved file. Without this change, the test's transitive-discovery wouldn't fire.
Pairs with if (!args.importer) return null; guard to skip the entry-point itself. Necessary for the test to pass. Slight increase in resolve-time work for non-JS/TS imports (CSS, JSON, etc.) but the early-return in enhancedResolve should make those cheap.
3. Omitted createCombinedBundle plumbing (correct)
On main, #1965 also added bundleTransitiveLocalStepDependencies to createCombinedBundle (4 lines). createCombinedBundle does not exist on stable (confirmed via git show origin/stable:base-builder.ts), so omitting the plumbing is correct.
What the three "Revert" commits did
  • d9f53d1a2 Revert runtime workaround changes — undid stray changes to tarballs/, world-testing/, docs/, changeset file
  • 879abd34b Revert DOMException reducer change — undid serialization.ts modification
  • 186e47269 Revert serialization test mock — undid serialization.test.ts modification
Verified the net effect on each of these files between the cherry-pick commit (2f00a8573) and the PR HEAD (186e47269) is zero — the reverts properly undid the unrelated changes. Only the builders files have net changes, and those are the legitimate adaptations.
Caveat: vade[bot] flagged a transient TS error
The vercel[bot] inline comment on line 253 of swc-esbuild-plugin.test.ts says:
Tests pass Set<string> for state fields but createDiscoverEntriesPlugin expects string[], causing TS2345 compilation errors that break all builds.
This was flagged against an EARLIER commit before the type-widening 796dc4235 landed. The current PR HEAD has the union type fix, so this should no longer apply. Verified locally: pnpm turbo run typecheck --filter @workflow/builders ... is clean.
What I verified locally
  • pnpm install --frozen-lockfile ✓
  • pnpm turbo run build --filter @workflow/builders --filter @workflow/nitro ✓
  • pnpm turbo run typecheck --filter @workflow/builders --filter @workflow/nitro --filter @workflow/next --filter @workflow/sveltekit --filter @workflow/astro --filter @workflow/nest ✓
  • pnpm --filter @workflow/builders test ✓ (144/144)
  • pnpm --filter @workflow/builders exec vitest run src/swc-esbuild-plugin.test.ts ✓ (23/23 — confirms the new regression test passes)
CI
  • 81 success, 2 failure, 2 in-progress, 6 skipped
  • All 42 E2E Local jobs pass (Dev + Prod + Postgres across all workbenches) ✓
  • Unit Tests pass ✓
  • E2E Windows Tests pass ✓
  • Failures: 2 of 11 E2E Vercel Prod Tests (astro, vite) — these look like single-run Vercel infrastructure flakes (the workflow run shows up in the Vercel UI but the test asserted failure). Not specific to this PR.
  • ijjk has already approved (the original author of #1965)
Bottom line
Faithful backport. The #1965 logic ports cleanly; the extra changes are all defensible adaptations to make stable's pre-existing code (string[] vs Set, missing createCombinedBundle) work with the new code from #1965. JJ took the higher-fidelity path (preserve the test verbatim, widen the types) rather than modifying the test, which I think is the right call.
Approving.
@VaguelySeriousVaguelySerious
mentioned this pull request
Jun 2, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@vercelvercel[bot]vercel[bot] left review comments
@TooTallNateTooTallNateTooTallNate approved these changes
@ijjkijjkijjk approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@TooTallNate@ijjk