Uh oh!
There was an error while loading. Please reload this page.
[world-postgres] Bootstrap graphile-worker schema in setup CLI - #2019
Merged
Conversation
`workflow-postgres-setup` now installs the `graphile_worker` schema in addition to the drizzle migrations so that by the time any consumer calls `world.start()`, both schemas already exist. This eliminates the inter-process race on graphile-worker's `installSchema` where concurrent `CREATE SCHEMA IF NOT EXISTS` calls could both pass the MVCC-snapshotted existence check and one would fail with `duplicate key value violates unique constraint "pg_namespace_nspname_index"`. Reproduced locally against a fresh postgres:18-alpine with 8 parallel `makeWorkerUtils().migrate()` calls — 7/8 fail without the pre-bootstrap, 0/8 fail after running `workflow-postgres-setup` first. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
🦋 Changeset detectedLatest commit: 3270e3d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro workflow with 25 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) workflow with 50 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro Promise.all with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) Promise.race with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) workflow with 10 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) workflow with 25 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro workflow with 50 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro workflow with 10 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) workflow with 25 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) workflow with 50 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro Stream Benchmarks(includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro stream pipeline with 5 transform steps (1MB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) 10 parallel streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro fan-out fan-in 10 streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
❌ Some benchmark jobs failed:
Check the workflow run for details. |
Contributor
🧪 E2E Test Results✅ All tests passed Summary
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
✅ 📋 Other
|
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Peter Wielander <mittgfu@gmail.com> Signed-off-by: Peter Wielander <mittgfu@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the @workflow/world-postgres setup CLI (workflow-postgres-setup) to proactively bootstrap Graphile Worker’s database objects so concurrent world.start() calls no longer race on graphile_worker schema creation in fresh databases.
Changes:
- Add a
graphile-workerbootstrap step (makeWorkerUtils().migrate()) to the setup CLI after running Drizzle migrations. - Add a changeset documenting the patch release for
@workflow/world-postgres.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/world-postgres/src/cli.ts | Runs Graphile Worker migration/bootstrap during workflow-postgres-setup to avoid concurrent schema-install races. |
| .changeset/setup-graphile-worker-schema.md | Announces the patch change in release notes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "@workflow/world-postgres": patch | ||
| --- | ||
| `workflow-postgres-setup` now also bootstraps the `graphile_worker` schema, fixing potential race on setup when starting the app and a test runner at the same time |
Uh oh!
There was an error while loading. Please reload this page.
github-actionsBot
added a commit
that referenced
this pull request
May 19, 2026
* fix(world-postgres): bootstrap graphile-worker schema in setup CLI `workflow-postgres-setup` now installs the `graphile_worker` schema in addition to the drizzle migrations so that by the time any consumer calls `world.start()`, both schemas already exist. This eliminates the inter-process race on graphile-worker's `installSchema` where concurrent `CREATE SCHEMA IF NOT EXISTS` calls could both pass the MVCC-snapshotted existence check and one would fail with `duplicate key value violates unique constraint "pg_namespace_nspname_index"`. Reproduced locally against a fresh postgres:18-alpine with 8 parallel `makeWorkerUtils().migrate()` calls — 7/8 fail without the pre-bootstrap, 0/8 fail after running `workflow-postgres-setup` first. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Apply suggestions from code review Co-authored-by: Peter Wielander <mittgfu@gmail.com> Signed-off-by: Peter Wielander <mittgfu@gmail.com> --------- Signed-off-by: Peter Wielander <mittgfu@gmail.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-authored-by: Nathan Rajlich <n@n8.io> Signed-off-by: Peter Wielander <mittgfu@gmail.com>
Contributor
Backport PR opened against |
This was referenced May 19, 2026
pranaygp pushed a commit
that referenced
this pull request
May 20, 2026
#2027) * fix(world-postgres): bootstrap graphile-worker schema in setup CLI `workflow-postgres-setup` now installs the `graphile_worker` schema in addition to the drizzle migrations so that by the time any consumer calls `world.start()`, both schemas already exist. This eliminates the inter-process race on graphile-worker's `installSchema` where concurrent `CREATE SCHEMA IF NOT EXISTS` calls could both pass the MVCC-snapshotted existence check and one would fail with `duplicate key value violates unique constraint "pg_namespace_nspname_index"`. Reproduced locally against a fresh postgres:18-alpine with 8 parallel `makeWorkerUtils().migrate()` calls — 7/8 fail without the pre-bootstrap, 0/8 fail after running `workflow-postgres-setup` first. * Apply suggestions from code review --------- Signed-off-by: Peter Wielander <mittgfu@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-authored-by: Nathan Rajlich <n@n8.io>
This was referenced May 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workflow-postgres-setupnow installs thegraphile_workerschema in addition to the drizzle migrations. Once both schemas exist, laterworld.start()calls find them present and skip the racing DDL path entirely.Why
E2E Local Postgres Testswas flaking on a fresh DB because two processes — the vitest test runner (which initializes a postgres world becauseWORKFLOW_TARGET_WORLD=@workflow/world-postgresis set) and the workbench dev server — both lazily callworld.start()and race in graphile-worker'sinstallSchema. PostgreSQL'sCREATE SCHEMA IF NOT EXISTSis not race-safe across concurrent sessions: both can pass the MVCC-snapshotted existence check and one then fails withduplicate key value violates unique constraint "pg_namespace_nspname_index".Since CI already runs
./packages/world-postgres/bin/setup.jsonce before either process starts (theSetup PostgreSQL Databasestep intests.yml), the cleanest fix is to do the graphile-worker bootstrap there — single-process, serialized, and consumer-agnostic. No lock, no migration changes, no production code path touched.Alternative to #1966.
Verification
pnpm --filter @workflow/world-postgres typecheck✓pnpm --filter @workflow/world-postgres build✓pnpm --filter @workflow/world-postgres test✓ (104 pass; one pre-existing failure instorage.test.ts > should enforce token uniqueness across different runsis also failing onmain, unrelated to this change)postgres:18-alpine: 8 parallelmakeWorkerUtils({pgPool}).migrate()calls. Without the pre-bootstrap, 7/8 fail withpg_namespace_nspname_index. After running the patchedworkflow-postgres-setupfirst, 0/8 fail.