Skip to content

[stable] Backport inline sourcemap remap hardening - #2156

Merged
VaguelySerious merged 1 commit into
stablefrom
peter/backport-inline-sourcemap-stable
May 29, 2026
Merged

[stable] Backport inline sourcemap remap hardening#2156
VaguelySerious merged 1 commit into
stablefrom
peter/backport-inline-sourcemap-stable

Conversation

@VaguelySerious

Copy link
Copy Markdown
Member

Backports 2ff8317 onto stable.

This keeps workflow error stack remapping from running a regex over large inline sourcemap bundles and adds regression coverage.

Validation:

  • pnpm exec vitest run packages/core/src/source-map.test.ts
  • pnpm --filter @workflow/core... build
  • pnpm --filter @workflow/core typecheck
  • pnpm --filter @workflow/core test
  • pnpm exec biome check packages/core/src/source-map.ts packages/core/src/source-map.test.ts .changeset/large-inline-sourcemap-remap.md

Note: pnpm lint currently fails on pre-existing stable-branch diagnostics outside this change (Biome schema drift, node: import rules, generated SvelteKit formatting, and unrelated complexity/unused-variable diagnostics).

@vercel

vercelBot commented May 29, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ca7606b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
NameType
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
workflowPatch
@workflow/world-testingPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented May 29, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production901067968
✅ 💻 Local Development9700861056
✅ 📦 Local Production9700861056
✅ 🐘 Local Postgres9700861056
✅ 🪟 Windows880088
❌ 🌍 Community Worlds1569084
✅ 📋 Other492036528
Total4406693614836

❌ Failed Tests

🌍 Community Worlds (69 failed)

mongodb-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

redis-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

turso-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

turso (66 failed):

  • addTenWorkflow | wrun_01KSSPXR77TG2VCY8RQCRRQGMG
  • addTenWorkflow | wrun_01KSSPXR77TG2VCY8RQCRRQGMG
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KSSPZXD7ZJK9AA2VTTQ2FMJZ
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KSSPY0ZM7N7Q0DP0YFF4KX5E
  • promiseRaceWorkflow | wrun_01KSSPY65M8HA9GG8T4MBZ0STR
  • promiseAnyWorkflow | wrun_01KSSPY8EDHH1GXYZFY4KWRCDE
  • importedStepOnlyWorkflow | wrun_01KSSQ08A2AYKDA9RD0TEHJ9G1
  • readableStreamWorkflow | wrun_01KSSPYD9VNSYQKP6C16JJBG77
  • hookWorkflow | wrun_01KSSPYTCTPRCX1JZ29170ANY8
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KSSPZ551Z0S7CSED1YNV5G9F
  • webhookWorkflow | wrun_01KSSPZA18X24WDCH4DFPGZV2F
  • sleepingWorkflow | wrun_01KSSPZFGV5CDZ31TG267WWSCN
  • parallelSleepWorkflow | wrun_01KSSPZYRREVYF56Y7XC3WJV4Z
  • nullByteWorkflow | wrun_01KSSQ0847NNNN6RB9AVG9PYPH
  • workflowAndStepMetadataWorkflow | wrun_01KSSQ0AXYWB59R06A8V1RNRYH
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KSSQ2PFCSJM290EBFF95Z7AS
  • fetchWorkflow | wrun_01KSSQ347QMW1V8A12XC72YJKN
  • promiseRaceStressTestWorkflow | wrun_01KSSQ37N07M01VF648W3ACK5Y
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KSSQ6SJ0W2PQ0QWRTYRG4CH3
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KSSQ75ANRH2NXMVF7X52WZRQ
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KSSQ7NGSMNQB74Z6WBCA8ARJ
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KSSQ8705MCAJ0G912AYVVC7F
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KSSQ8G7T96PFV0QRZKG56WBD
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KSSQ8P2WDM00QPP192QJPW62
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KSSQ8R98D0EMZ48H0GA2HBMJ
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KSSQ98JFXQ6N2E9FY4W13EP0
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KSSQ9MBK1E6YTTWDSHX1S0SM
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KSSQ9V6HED92FPHJJRTA9H4V
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KSSQA24D7YPNKNCMVFKD218K
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KSSQA96RDABEXVPM07DTT8QM
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KSSQAG0ZXM8EP39588G3R2TG
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KSSQAPZ6401DG0VXTH3J7266
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KSSQB3R6N4JSA9V4MDSA9J6E
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KSSQBCXZEQGKBGG86G4VF1A8
  • cancelRun - cancelling a running workflow | wrun_01KSSQBKV0BZ3J063AY77FHR8X
  • cancelRun via CLI - cancelling a running workflow | wrun_01KSSQBXH343DWH2BSDAYE48DJ
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KSSQCA1WY69CBC0PHPA9WB3D
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KSSQCT3HHS8Q20QGMSGBA6M3
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KSSQD5WSY768PKWEV42PC6K3
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KSSQDE4J6TCSYM03EZNB9KKE
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KSSQDGAEVVV28FVHB26B6S7J
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KSSQDJEK6AP93TJJGS7H1EDF

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro8107
✅ example8107
✅ express8107
✅ fastify8107
✅ hono8107
✅ nextjs-turbopack8602
✅ nextjs-webpack8602
✅ nitro8107
✅ nuxt8107
✅ sveltekit8107
✅ vite8107
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack8800
❌ 🌍 Community Worlds
AppPassedFailedSkipped
❌ mongodb-dev410
❌ redis-dev410
❌ turso-dev410
❌ turso3660
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8206
✅ e2e-local-dev-tanstack-start-stable8206
✅ e2e-local-postgres-nest-stable8206
✅ e2e-local-postgres-tanstack-start-stable8206
✅ e2e-local-prod-nest-stable8206
✅ e2e-local-prod-tanstack-start-stable8206

📋 View full workflow run

@VaguelySerious
VaguelySerious marked this pull request as ready for review May 29, 2026 11:11
@VaguelySerious
VaguelySerious requested a review from a team as a code ownerMay 29, 2026 11:11
@VaguelySerious
VaguelySerious enabled auto-merge (squash) May 29, 2026 16:10
@VaguelySerious
VaguelySerious merged commit ebfeede into stableMay 29, 2026
155 of 162 checks passed
@VaguelySerious
VaguelySerious deleted the peter/backport-inline-sourcemap-stable branch May 29, 2026 17:57
@github-actionsgithub-actionsBot mentioned this pull request May 29, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@VaguelySerious@TooTallNate
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[stable] Backport inline sourcemap remap hardening by VaguelySerious · Pull Request #2156 · vercel/workflow · GitHub
Skip to content

[stable] Backport inline sourcemap remap hardening - #2156

Merged
VaguelySerious merged 1 commit into
stablefrom
peter/backport-inline-sourcemap-stable
May 29, 2026
Merged

[stable] Backport inline sourcemap remap hardening#2156
VaguelySerious merged 1 commit into
stablefrom
peter/backport-inline-sourcemap-stable

Conversation

@VaguelySerious

Copy link
Copy Markdown
Member

Backports 2ff8317 onto stable.

This keeps workflow error stack remapping from running a regex over large inline sourcemap bundles and adds regression coverage.

Validation:

  • pnpm exec vitest run packages/core/src/source-map.test.ts
  • pnpm --filter @workflow/core... build
  • pnpm --filter @workflow/core typecheck
  • pnpm --filter @workflow/core test
  • pnpm exec biome check packages/core/src/source-map.ts packages/core/src/source-map.test.ts .changeset/large-inline-sourcemap-remap.md

Note: pnpm lint currently fails on pre-existing stable-branch diagnostics outside this change (Biome schema drift, node: import rules, generated SvelteKit formatting, and unrelated complexity/unused-variable diagnostics).

@vercel

vercelBot commented May 29, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ca7606b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
NameType
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
workflowPatch
@workflow/world-testingPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented May 29, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production901067968
✅ 💻 Local Development9700861056
✅ 📦 Local Production9700861056
✅ 🐘 Local Postgres9700861056
✅ 🪟 Windows880088
❌ 🌍 Community Worlds1569084
✅ 📋 Other492036528
Total4406693614836

❌ Failed Tests

🌍 Community Worlds (69 failed)

mongodb-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

redis-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

turso-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

turso (66 failed):

  • addTenWorkflow | wrun_01KSSPXR77TG2VCY8RQCRRQGMG
  • addTenWorkflow | wrun_01KSSPXR77TG2VCY8RQCRRQGMG
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KSSPZXD7ZJK9AA2VTTQ2FMJZ
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KSSPY0ZM7N7Q0DP0YFF4KX5E
  • promiseRaceWorkflow | wrun_01KSSPY65M8HA9GG8T4MBZ0STR
  • promiseAnyWorkflow | wrun_01KSSPY8EDHH1GXYZFY4KWRCDE
  • importedStepOnlyWorkflow | wrun_01KSSQ08A2AYKDA9RD0TEHJ9G1
  • readableStreamWorkflow | wrun_01KSSPYD9VNSYQKP6C16JJBG77
  • hookWorkflow | wrun_01KSSPYTCTPRCX1JZ29170ANY8
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KSSPZ551Z0S7CSED1YNV5G9F
  • webhookWorkflow | wrun_01KSSPZA18X24WDCH4DFPGZV2F
  • sleepingWorkflow | wrun_01KSSPZFGV5CDZ31TG267WWSCN
  • parallelSleepWorkflow | wrun_01KSSPZYRREVYF56Y7XC3WJV4Z
  • nullByteWorkflow | wrun_01KSSQ0847NNNN6RB9AVG9PYPH
  • workflowAndStepMetadataWorkflow | wrun_01KSSQ0AXYWB59R06A8V1RNRYH
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KSSQ2PFCSJM290EBFF95Z7AS
  • fetchWorkflow | wrun_01KSSQ347QMW1V8A12XC72YJKN
  • promiseRaceStressTestWorkflow | wrun_01KSSQ37N07M01VF648W3ACK5Y
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KSSQ6SJ0W2PQ0QWRTYRG4CH3
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KSSQ75ANRH2NXMVF7X52WZRQ
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KSSQ7NGSMNQB74Z6WBCA8ARJ
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KSSQ8705MCAJ0G912AYVVC7F
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KSSQ8G7T96PFV0QRZKG56WBD
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KSSQ8P2WDM00QPP192QJPW62
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KSSQ8R98D0EMZ48H0GA2HBMJ
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KSSQ98JFXQ6N2E9FY4W13EP0
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KSSQ9MBK1E6YTTWDSHX1S0SM
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KSSQ9V6HED92FPHJJRTA9H4V
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KSSQA24D7YPNKNCMVFKD218K
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KSSQA96RDABEXVPM07DTT8QM
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KSSQAG0ZXM8EP39588G3R2TG
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KSSQAPZ6401DG0VXTH3J7266
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KSSQB3R6N4JSA9V4MDSA9J6E
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KSSQBCXZEQGKBGG86G4VF1A8
  • cancelRun - cancelling a running workflow | wrun_01KSSQBKV0BZ3J063AY77FHR8X
  • cancelRun via CLI - cancelling a running workflow | wrun_01KSSQBXH343DWH2BSDAYE48DJ
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KSSQCA1WY69CBC0PHPA9WB3D
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KSSQCT3HHS8Q20QGMSGBA6M3
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KSSQD5WSY768PKWEV42PC6K3
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KSSQDE4J6TCSYM03EZNB9KKE
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KSSQDGAEVVV28FVHB26B6S7J
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KSSQDJEK6AP93TJJGS7H1EDF

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro8107
✅ example8107
✅ express8107
✅ fastify8107
✅ hono8107
✅ nextjs-turbopack8602
✅ nextjs-webpack8602
✅ nitro8107
✅ nuxt8107
✅ sveltekit8107
✅ vite8107
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack8800
❌ 🌍 Community Worlds
AppPassedFailedSkipped
❌ mongodb-dev410
❌ redis-dev410
❌ turso-dev410
❌ turso3660
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8206
✅ e2e-local-dev-tanstack-start-stable8206
✅ e2e-local-postgres-nest-stable8206
✅ e2e-local-postgres-tanstack-start-stable8206
✅ e2e-local-prod-nest-stable8206
✅ e2e-local-prod-tanstack-start-stable8206

📋 View full workflow run

@VaguelySerious
VaguelySerious marked this pull request as ready for review May 29, 2026 11:11
@VaguelySerious
VaguelySerious requested a review from a team as a code ownerMay 29, 2026 11:11
@VaguelySerious
VaguelySerious enabled auto-merge (squash) May 29, 2026 16:10
@VaguelySerious
VaguelySerious merged commit ebfeede into stableMay 29, 2026
155 of 162 checks passed
@VaguelySerious
VaguelySerious deleted the peter/backport-inline-sourcemap-stable branch May 29, 2026 17:57
@github-actionsgithub-actionsBot mentioned this pull request May 29, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@VaguelySerious@TooTallNate
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [stable] Backport inline sourcemap remap hardening by VaguelySerious · Pull Request #2156 · vercel/workflow · GitHub
Skip to content

[stable] Backport inline sourcemap remap hardening - #2156

Merged
VaguelySerious merged 1 commit into
stablefrom
peter/backport-inline-sourcemap-stable
May 29, 2026
Merged

[stable] Backport inline sourcemap remap hardening#2156
VaguelySerious merged 1 commit into
stablefrom
peter/backport-inline-sourcemap-stable

Conversation

@VaguelySerious

Copy link
Copy Markdown
Member

Backports 2ff8317 onto stable.

This keeps workflow error stack remapping from running a regex over large inline sourcemap bundles and adds regression coverage.

Validation:

  • pnpm exec vitest run packages/core/src/source-map.test.ts
  • pnpm --filter @workflow/core... build
  • pnpm --filter @workflow/core typecheck
  • pnpm --filter @workflow/core test
  • pnpm exec biome check packages/core/src/source-map.ts packages/core/src/source-map.test.ts .changeset/large-inline-sourcemap-remap.md

Note: pnpm lint currently fails on pre-existing stable-branch diagnostics outside this change (Biome schema drift, node: import rules, generated SvelteKit formatting, and unrelated complexity/unused-variable diagnostics).

@vercel

vercelBot commented May 29, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ca7606b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
NameType
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
workflowPatch
@workflow/world-testingPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented May 29, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production901067968
✅ 💻 Local Development9700861056
✅ 📦 Local Production9700861056
✅ 🐘 Local Postgres9700861056
✅ 🪟 Windows880088
❌ 🌍 Community Worlds1569084
✅ 📋 Other492036528
Total4406693614836

❌ Failed Tests

🌍 Community Worlds (69 failed)

mongodb-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

redis-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

turso-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

turso (66 failed):

  • addTenWorkflow | wrun_01KSSPXR77TG2VCY8RQCRRQGMG
  • addTenWorkflow | wrun_01KSSPXR77TG2VCY8RQCRRQGMG
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KSSPZXD7ZJK9AA2VTTQ2FMJZ
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KSSPY0ZM7N7Q0DP0YFF4KX5E
  • promiseRaceWorkflow | wrun_01KSSPY65M8HA9GG8T4MBZ0STR
  • promiseAnyWorkflow | wrun_01KSSPY8EDHH1GXYZFY4KWRCDE
  • importedStepOnlyWorkflow | wrun_01KSSQ08A2AYKDA9RD0TEHJ9G1
  • readableStreamWorkflow | wrun_01KSSPYD9VNSYQKP6C16JJBG77
  • hookWorkflow | wrun_01KSSPYTCTPRCX1JZ29170ANY8
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KSSPZ551Z0S7CSED1YNV5G9F
  • webhookWorkflow | wrun_01KSSPZA18X24WDCH4DFPGZV2F
  • sleepingWorkflow | wrun_01KSSPZFGV5CDZ31TG267WWSCN
  • parallelSleepWorkflow | wrun_01KSSPZYRREVYF56Y7XC3WJV4Z
  • nullByteWorkflow | wrun_01KSSQ0847NNNN6RB9AVG9PYPH
  • workflowAndStepMetadataWorkflow | wrun_01KSSQ0AXYWB59R06A8V1RNRYH
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KSSQ2PFCSJM290EBFF95Z7AS
  • fetchWorkflow | wrun_01KSSQ347QMW1V8A12XC72YJKN
  • promiseRaceStressTestWorkflow | wrun_01KSSQ37N07M01VF648W3ACK5Y
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KSSQ6SJ0W2PQ0QWRTYRG4CH3
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KSSQ75ANRH2NXMVF7X52WZRQ
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KSSQ7NGSMNQB74Z6WBCA8ARJ
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KSSQ8705MCAJ0G912AYVVC7F
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KSSQ8G7T96PFV0QRZKG56WBD
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KSSQ8P2WDM00QPP192QJPW62
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KSSQ8R98D0EMZ48H0GA2HBMJ
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KSSQ98JFXQ6N2E9FY4W13EP0
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KSSQ9MBK1E6YTTWDSHX1S0SM
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KSSQ9V6HED92FPHJJRTA9H4V
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KSSQA24D7YPNKNCMVFKD218K
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KSSQA96RDABEXVPM07DTT8QM
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KSSQAG0ZXM8EP39588G3R2TG
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KSSQAPZ6401DG0VXTH3J7266
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KSSQB3R6N4JSA9V4MDSA9J6E
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KSSQBCXZEQGKBGG86G4VF1A8
  • cancelRun - cancelling a running workflow | wrun_01KSSQBKV0BZ3J063AY77FHR8X
  • cancelRun via CLI - cancelling a running workflow | wrun_01KSSQBXH343DWH2BSDAYE48DJ
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KSSQCA1WY69CBC0PHPA9WB3D
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KSSQCT3HHS8Q20QGMSGBA6M3
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KSSQD5WSY768PKWEV42PC6K3
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KSSQDE4J6TCSYM03EZNB9KKE
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KSSQDGAEVVV28FVHB26B6S7J
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KSSQDJEK6AP93TJJGS7H1EDF

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro8107
✅ example8107
✅ express8107
✅ fastify8107
✅ hono8107
✅ nextjs-turbopack8602
✅ nextjs-webpack8602
✅ nitro8107
✅ nuxt8107
✅ sveltekit8107
✅ vite8107
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack8800
❌ 🌍 Community Worlds
AppPassedFailedSkipped
❌ mongodb-dev410
❌ redis-dev410
❌ turso-dev410
❌ turso3660
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8206
✅ e2e-local-dev-tanstack-start-stable8206
✅ e2e-local-postgres-nest-stable8206
✅ e2e-local-postgres-tanstack-start-stable8206
✅ e2e-local-prod-nest-stable8206
✅ e2e-local-prod-tanstack-start-stable8206

📋 View full workflow run

@VaguelySerious
VaguelySerious marked this pull request as ready for review May 29, 2026 11:11
@VaguelySerious
VaguelySerious requested a review from a team as a code ownerMay 29, 2026 11:11
@VaguelySerious
VaguelySerious enabled auto-merge (squash) May 29, 2026 16:10
@VaguelySerious
VaguelySerious merged commit ebfeede into stableMay 29, 2026
155 of 162 checks passed
@VaguelySerious
VaguelySerious deleted the peter/backport-inline-sourcemap-stable branch May 29, 2026 17:57
@github-actionsgithub-actionsBot mentioned this pull request May 29, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@VaguelySerious@TooTallNate
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [stable] Backport inline sourcemap remap hardening by VaguelySerious · Pull Request #2156 · vercel/workflow · GitHub
Skip to content

[stable] Backport inline sourcemap remap hardening - #2156

Merged
VaguelySerious merged 1 commit into
stablefrom
peter/backport-inline-sourcemap-stable
May 29, 2026
Merged

[stable] Backport inline sourcemap remap hardening#2156
VaguelySerious merged 1 commit into
stablefrom
peter/backport-inline-sourcemap-stable

Conversation

@VaguelySerious

Copy link
Copy Markdown
Member

Backports 2ff8317 onto stable.

This keeps workflow error stack remapping from running a regex over large inline sourcemap bundles and adds regression coverage.

Validation:

  • pnpm exec vitest run packages/core/src/source-map.test.ts
  • pnpm --filter @workflow/core... build
  • pnpm --filter @workflow/core typecheck
  • pnpm --filter @workflow/core test
  • pnpm exec biome check packages/core/src/source-map.ts packages/core/src/source-map.test.ts .changeset/large-inline-sourcemap-remap.md

Note: pnpm lint currently fails on pre-existing stable-branch diagnostics outside this change (Biome schema drift, node: import rules, generated SvelteKit formatting, and unrelated complexity/unused-variable diagnostics).

@vercel

vercelBot commented May 29, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ca7606b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
NameType
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
workflowPatch
@workflow/world-testingPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented May 29, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production901067968
✅ 💻 Local Development9700861056
✅ 📦 Local Production9700861056
✅ 🐘 Local Postgres9700861056
✅ 🪟 Windows880088
❌ 🌍 Community Worlds1569084
✅ 📋 Other492036528
Total4406693614836

❌ Failed Tests

🌍 Community Worlds (69 failed)

mongodb-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

redis-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

turso-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

turso (66 failed):

  • addTenWorkflow | wrun_01KSSPXR77TG2VCY8RQCRRQGMG
  • addTenWorkflow | wrun_01KSSPXR77TG2VCY8RQCRRQGMG
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KSSPZXD7ZJK9AA2VTTQ2FMJZ
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KSSPY0ZM7N7Q0DP0YFF4KX5E
  • promiseRaceWorkflow | wrun_01KSSPY65M8HA9GG8T4MBZ0STR
  • promiseAnyWorkflow | wrun_01KSSPY8EDHH1GXYZFY4KWRCDE
  • importedStepOnlyWorkflow | wrun_01KSSQ08A2AYKDA9RD0TEHJ9G1
  • readableStreamWorkflow | wrun_01KSSPYD9VNSYQKP6C16JJBG77
  • hookWorkflow | wrun_01KSSPYTCTPRCX1JZ29170ANY8
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KSSPZ551Z0S7CSED1YNV5G9F
  • webhookWorkflow | wrun_01KSSPZA18X24WDCH4DFPGZV2F
  • sleepingWorkflow | wrun_01KSSPZFGV5CDZ31TG267WWSCN
  • parallelSleepWorkflow | wrun_01KSSPZYRREVYF56Y7XC3WJV4Z
  • nullByteWorkflow | wrun_01KSSQ0847NNNN6RB9AVG9PYPH
  • workflowAndStepMetadataWorkflow | wrun_01KSSQ0AXYWB59R06A8V1RNRYH
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KSSQ2PFCSJM290EBFF95Z7AS
  • fetchWorkflow | wrun_01KSSQ347QMW1V8A12XC72YJKN
  • promiseRaceStressTestWorkflow | wrun_01KSSQ37N07M01VF648W3ACK5Y
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KSSQ6SJ0W2PQ0QWRTYRG4CH3
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KSSQ75ANRH2NXMVF7X52WZRQ
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KSSQ7NGSMNQB74Z6WBCA8ARJ
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KSSQ8705MCAJ0G912AYVVC7F
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KSSQ8G7T96PFV0QRZKG56WBD
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KSSQ8P2WDM00QPP192QJPW62
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KSSQ8R98D0EMZ48H0GA2HBMJ
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KSSQ98JFXQ6N2E9FY4W13EP0
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KSSQ9MBK1E6YTTWDSHX1S0SM
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KSSQ9V6HED92FPHJJRTA9H4V
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KSSQA24D7YPNKNCMVFKD218K
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KSSQA96RDABEXVPM07DTT8QM
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KSSQAG0ZXM8EP39588G3R2TG
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KSSQAPZ6401DG0VXTH3J7266
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KSSQB3R6N4JSA9V4MDSA9J6E
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KSSQBCXZEQGKBGG86G4VF1A8
  • cancelRun - cancelling a running workflow | wrun_01KSSQBKV0BZ3J063AY77FHR8X
  • cancelRun via CLI - cancelling a running workflow | wrun_01KSSQBXH343DWH2BSDAYE48DJ
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KSSQCA1WY69CBC0PHPA9WB3D
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KSSQCT3HHS8Q20QGMSGBA6M3
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KSSQD5WSY768PKWEV42PC6K3
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KSSQDE4J6TCSYM03EZNB9KKE
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KSSQDGAEVVV28FVHB26B6S7J
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KSSQDJEK6AP93TJJGS7H1EDF

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro8107
✅ example8107
✅ express8107
✅ fastify8107
✅ hono8107
✅ nextjs-turbopack8602
✅ nextjs-webpack8602
✅ nitro8107
✅ nuxt8107
✅ sveltekit8107
✅ vite8107
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack8800
❌ 🌍 Community Worlds
AppPassedFailedSkipped
❌ mongodb-dev410
❌ redis-dev410
❌ turso-dev410
❌ turso3660
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8206
✅ e2e-local-dev-tanstack-start-stable8206
✅ e2e-local-postgres-nest-stable8206
✅ e2e-local-postgres-tanstack-start-stable8206
✅ e2e-local-prod-nest-stable8206
✅ e2e-local-prod-tanstack-start-stable8206

📋 View full workflow run

@VaguelySerious
VaguelySerious marked this pull request as ready for review May 29, 2026 11:11
@VaguelySerious
VaguelySerious requested a review from a team as a code ownerMay 29, 2026 11:11
@VaguelySerious
VaguelySerious enabled auto-merge (squash) May 29, 2026 16:10
@VaguelySerious
VaguelySerious merged commit ebfeede into stableMay 29, 2026
155 of 162 checks passed
@VaguelySerious
VaguelySerious deleted the peter/backport-inline-sourcemap-stable branch May 29, 2026 17:57
@github-actionsgithub-actionsBot mentioned this pull request May 29, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@VaguelySerious@TooTallNate
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' [stable] Backport inline sourcemap remap hardening by VaguelySerious · Pull Request #2156 · vercel/workflow · GitHub
Skip to content

[stable] Backport inline sourcemap remap hardening - #2156

Merged
VaguelySerious merged 1 commit into
stablefrom
peter/backport-inline-sourcemap-stable
May 29, 2026
Merged

[stable] Backport inline sourcemap remap hardening#2156
VaguelySerious merged 1 commit into
stablefrom
peter/backport-inline-sourcemap-stable

Conversation

@VaguelySerious

Copy link
Copy Markdown
Member

Backports 2ff8317 onto stable.

This keeps workflow error stack remapping from running a regex over large inline sourcemap bundles and adds regression coverage.

Validation:

  • pnpm exec vitest run packages/core/src/source-map.test.ts
  • pnpm --filter @workflow/core... build
  • pnpm --filter @workflow/core typecheck
  • pnpm --filter @workflow/core test
  • pnpm exec biome check packages/core/src/source-map.ts packages/core/src/source-map.test.ts .changeset/large-inline-sourcemap-remap.md

Note: pnpm lint currently fails on pre-existing stable-branch diagnostics outside this change (Biome schema drift, node: import rules, generated SvelteKit formatting, and unrelated complexity/unused-variable diagnostics).

@vercel

vercelBot commented May 29, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ca7606b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
NameType
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
workflowPatch
@workflow/world-testingPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented May 29, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production901067968
✅ 💻 Local Development9700861056
✅ 📦 Local Production9700861056
✅ 🐘 Local Postgres9700861056
✅ 🪟 Windows880088
❌ 🌍 Community Worlds1569084
✅ 📋 Other492036528
Total4406693614836

❌ Failed Tests

🌍 Community Worlds (69 failed)

mongodb-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

redis-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

turso-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

turso (66 failed):

  • addTenWorkflow | wrun_01KSSPXR77TG2VCY8RQCRRQGMG
  • addTenWorkflow | wrun_01KSSPXR77TG2VCY8RQCRRQGMG
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KSSPZXD7ZJK9AA2VTTQ2FMJZ
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KSSPY0ZM7N7Q0DP0YFF4KX5E
  • promiseRaceWorkflow | wrun_01KSSPY65M8HA9GG8T4MBZ0STR
  • promiseAnyWorkflow | wrun_01KSSPY8EDHH1GXYZFY4KWRCDE
  • importedStepOnlyWorkflow | wrun_01KSSQ08A2AYKDA9RD0TEHJ9G1
  • readableStreamWorkflow | wrun_01KSSPYD9VNSYQKP6C16JJBG77
  • hookWorkflow | wrun_01KSSPYTCTPRCX1JZ29170ANY8
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KSSPZ551Z0S7CSED1YNV5G9F
  • webhookWorkflow | wrun_01KSSPZA18X24WDCH4DFPGZV2F
  • sleepingWorkflow | wrun_01KSSPZFGV5CDZ31TG267WWSCN
  • parallelSleepWorkflow | wrun_01KSSPZYRREVYF56Y7XC3WJV4Z
  • nullByteWorkflow | wrun_01KSSQ0847NNNN6RB9AVG9PYPH
  • workflowAndStepMetadataWorkflow | wrun_01KSSQ0AXYWB59R06A8V1RNRYH
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KSSQ2PFCSJM290EBFF95Z7AS
  • fetchWorkflow | wrun_01KSSQ347QMW1V8A12XC72YJKN
  • promiseRaceStressTestWorkflow | wrun_01KSSQ37N07M01VF648W3ACK5Y
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KSSQ6SJ0W2PQ0QWRTYRG4CH3
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KSSQ75ANRH2NXMVF7X52WZRQ
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KSSQ7NGSMNQB74Z6WBCA8ARJ
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KSSQ8705MCAJ0G912AYVVC7F
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KSSQ8G7T96PFV0QRZKG56WBD
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KSSQ8P2WDM00QPP192QJPW62
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KSSQ8R98D0EMZ48H0GA2HBMJ
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KSSQ98JFXQ6N2E9FY4W13EP0
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KSSQ9MBK1E6YTTWDSHX1S0SM
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KSSQ9V6HED92FPHJJRTA9H4V
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KSSQA24D7YPNKNCMVFKD218K
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KSSQA96RDABEXVPM07DTT8QM
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KSSQAG0ZXM8EP39588G3R2TG
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KSSQAPZ6401DG0VXTH3J7266
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KSSQB3R6N4JSA9V4MDSA9J6E
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KSSQBCXZEQGKBGG86G4VF1A8
  • cancelRun - cancelling a running workflow | wrun_01KSSQBKV0BZ3J063AY77FHR8X
  • cancelRun via CLI - cancelling a running workflow | wrun_01KSSQBXH343DWH2BSDAYE48DJ
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KSSQCA1WY69CBC0PHPA9WB3D
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KSSQCT3HHS8Q20QGMSGBA6M3
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KSSQD5WSY768PKWEV42PC6K3
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KSSQDE4J6TCSYM03EZNB9KKE
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KSSQDGAEVVV28FVHB26B6S7J
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KSSQDJEK6AP93TJJGS7H1EDF

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro8107
✅ example8107
✅ express8107
✅ fastify8107
✅ hono8107
✅ nextjs-turbopack8602
✅ nextjs-webpack8602
✅ nitro8107
✅ nuxt8107
✅ sveltekit8107
✅ vite8107
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack8800
❌ 🌍 Community Worlds
AppPassedFailedSkipped
❌ mongodb-dev410
❌ redis-dev410
❌ turso-dev410
❌ turso3660
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8206
✅ e2e-local-dev-tanstack-start-stable8206
✅ e2e-local-postgres-nest-stable8206
✅ e2e-local-postgres-tanstack-start-stable8206
✅ e2e-local-prod-nest-stable8206
✅ e2e-local-prod-tanstack-start-stable8206

📋 View full workflow run

@VaguelySerious
VaguelySerious marked this pull request as ready for review May 29, 2026 11:11
@VaguelySerious
VaguelySerious requested a review from a team as a code ownerMay 29, 2026 11:11
@VaguelySerious
VaguelySerious enabled auto-merge (squash) May 29, 2026 16:10
@VaguelySerious
VaguelySerious merged commit ebfeede into stableMay 29, 2026
155 of 162 checks passed
@VaguelySerious
VaguelySerious deleted the peter/backport-inline-sourcemap-stable branch May 29, 2026 17:57
@github-actionsgithub-actionsBot mentioned this pull request May 29, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@VaguelySerious@TooTallNate
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [stable] Backport inline sourcemap remap hardening by VaguelySerious · Pull Request #2156 · vercel/workflow · GitHub
Skip to content

[stable] Backport inline sourcemap remap hardening - #2156

Merged
VaguelySerious merged 1 commit into
stablefrom
peter/backport-inline-sourcemap-stable
May 29, 2026
Merged

[stable] Backport inline sourcemap remap hardening#2156
VaguelySerious merged 1 commit into
stablefrom
peter/backport-inline-sourcemap-stable

Conversation

@VaguelySerious

Copy link
Copy Markdown
Member

Backports 2ff8317 onto stable.

This keeps workflow error stack remapping from running a regex over large inline sourcemap bundles and adds regression coverage.

Validation:

  • pnpm exec vitest run packages/core/src/source-map.test.ts
  • pnpm --filter @workflow/core... build
  • pnpm --filter @workflow/core typecheck
  • pnpm --filter @workflow/core test
  • pnpm exec biome check packages/core/src/source-map.ts packages/core/src/source-map.test.ts .changeset/large-inline-sourcemap-remap.md

Note: pnpm lint currently fails on pre-existing stable-branch diagnostics outside this change (Biome schema drift, node: import rules, generated SvelteKit formatting, and unrelated complexity/unused-variable diagnostics).

@vercel

vercelBot commented May 29, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ca7606b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
NameType
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
workflowPatch
@workflow/world-testingPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented May 29, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production901067968
✅ 💻 Local Development9700861056
✅ 📦 Local Production9700861056
✅ 🐘 Local Postgres9700861056
✅ 🪟 Windows880088
❌ 🌍 Community Worlds1569084
✅ 📋 Other492036528
Total4406693614836

❌ Failed Tests

🌍 Community Worlds (69 failed)

mongodb-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

redis-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

turso-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

turso (66 failed):

  • addTenWorkflow | wrun_01KSSPXR77TG2VCY8RQCRRQGMG
  • addTenWorkflow | wrun_01KSSPXR77TG2VCY8RQCRRQGMG
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KSSPZXD7ZJK9AA2VTTQ2FMJZ
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KSSPY0ZM7N7Q0DP0YFF4KX5E
  • promiseRaceWorkflow | wrun_01KSSPY65M8HA9GG8T4MBZ0STR
  • promiseAnyWorkflow | wrun_01KSSPY8EDHH1GXYZFY4KWRCDE
  • importedStepOnlyWorkflow | wrun_01KSSQ08A2AYKDA9RD0TEHJ9G1
  • readableStreamWorkflow | wrun_01KSSPYD9VNSYQKP6C16JJBG77
  • hookWorkflow | wrun_01KSSPYTCTPRCX1JZ29170ANY8
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KSSPZ551Z0S7CSED1YNV5G9F
  • webhookWorkflow | wrun_01KSSPZA18X24WDCH4DFPGZV2F
  • sleepingWorkflow | wrun_01KSSPZFGV5CDZ31TG267WWSCN
  • parallelSleepWorkflow | wrun_01KSSPZYRREVYF56Y7XC3WJV4Z
  • nullByteWorkflow | wrun_01KSSQ0847NNNN6RB9AVG9PYPH
  • workflowAndStepMetadataWorkflow | wrun_01KSSQ0AXYWB59R06A8V1RNRYH
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KSSQ2PFCSJM290EBFF95Z7AS
  • fetchWorkflow | wrun_01KSSQ347QMW1V8A12XC72YJKN
  • promiseRaceStressTestWorkflow | wrun_01KSSQ37N07M01VF648W3ACK5Y
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KSSQ6SJ0W2PQ0QWRTYRG4CH3
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KSSQ75ANRH2NXMVF7X52WZRQ
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KSSQ7NGSMNQB74Z6WBCA8ARJ
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KSSQ8705MCAJ0G912AYVVC7F
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KSSQ8G7T96PFV0QRZKG56WBD
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KSSQ8P2WDM00QPP192QJPW62
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KSSQ8R98D0EMZ48H0GA2HBMJ
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KSSQ98JFXQ6N2E9FY4W13EP0
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KSSQ9MBK1E6YTTWDSHX1S0SM
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KSSQ9V6HED92FPHJJRTA9H4V
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KSSQA24D7YPNKNCMVFKD218K
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KSSQA96RDABEXVPM07DTT8QM
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KSSQAG0ZXM8EP39588G3R2TG
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KSSQAPZ6401DG0VXTH3J7266
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KSSQB3R6N4JSA9V4MDSA9J6E
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KSSQBCXZEQGKBGG86G4VF1A8
  • cancelRun - cancelling a running workflow | wrun_01KSSQBKV0BZ3J063AY77FHR8X
  • cancelRun via CLI - cancelling a running workflow | wrun_01KSSQBXH343DWH2BSDAYE48DJ
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KSSQCA1WY69CBC0PHPA9WB3D
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KSSQCT3HHS8Q20QGMSGBA6M3
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KSSQD5WSY768PKWEV42PC6K3
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KSSQDE4J6TCSYM03EZNB9KKE
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KSSQDGAEVVV28FVHB26B6S7J
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KSSQDJEK6AP93TJJGS7H1EDF

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro8107
✅ example8107
✅ express8107
✅ fastify8107
✅ hono8107
✅ nextjs-turbopack8602
✅ nextjs-webpack8602
✅ nitro8107
✅ nuxt8107
✅ sveltekit8107
✅ vite8107
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack8800
❌ 🌍 Community Worlds
AppPassedFailedSkipped
❌ mongodb-dev410
❌ redis-dev410
❌ turso-dev410
❌ turso3660
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8206
✅ e2e-local-dev-tanstack-start-stable8206
✅ e2e-local-postgres-nest-stable8206
✅ e2e-local-postgres-tanstack-start-stable8206
✅ e2e-local-prod-nest-stable8206
✅ e2e-local-prod-tanstack-start-stable8206

📋 View full workflow run

@VaguelySerious
VaguelySerious marked this pull request as ready for review May 29, 2026 11:11
@VaguelySerious
VaguelySerious requested a review from a team as a code ownerMay 29, 2026 11:11
@VaguelySerious
VaguelySerious enabled auto-merge (squash) May 29, 2026 16:10
@VaguelySerious
VaguelySerious merged commit ebfeede into stableMay 29, 2026
155 of 162 checks passed
@VaguelySerious
VaguelySerious deleted the peter/backport-inline-sourcemap-stable branch May 29, 2026 17:57
@github-actionsgithub-actionsBot mentioned this pull request May 29, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@VaguelySerious@TooTallNate
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [stable] Backport inline sourcemap remap hardening by VaguelySerious · Pull Request #2156 · vercel/workflow · GitHub
Skip to content

[stable] Backport inline sourcemap remap hardening - #2156

Merged
VaguelySerious merged 1 commit into
stablefrom
peter/backport-inline-sourcemap-stable
May 29, 2026
Merged

[stable] Backport inline sourcemap remap hardening#2156
VaguelySerious merged 1 commit into
stablefrom
peter/backport-inline-sourcemap-stable

Conversation

@VaguelySerious

Copy link
Copy Markdown
Member

Backports 2ff8317 onto stable.

This keeps workflow error stack remapping from running a regex over large inline sourcemap bundles and adds regression coverage.

Validation:

  • pnpm exec vitest run packages/core/src/source-map.test.ts
  • pnpm --filter @workflow/core... build
  • pnpm --filter @workflow/core typecheck
  • pnpm --filter @workflow/core test
  • pnpm exec biome check packages/core/src/source-map.ts packages/core/src/source-map.test.ts .changeset/large-inline-sourcemap-remap.md

Note: pnpm lint currently fails on pre-existing stable-branch diagnostics outside this change (Biome schema drift, node: import rules, generated SvelteKit formatting, and unrelated complexity/unused-variable diagnostics).

@vercel

vercelBot commented May 29, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ca7606b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
NameType
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
workflowPatch
@workflow/world-testingPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented May 29, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production901067968
✅ 💻 Local Development9700861056
✅ 📦 Local Production9700861056
✅ 🐘 Local Postgres9700861056
✅ 🪟 Windows880088
❌ 🌍 Community Worlds1569084
✅ 📋 Other492036528
Total4406693614836

❌ Failed Tests

🌍 Community Worlds (69 failed)

mongodb-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

redis-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

turso-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

turso (66 failed):

  • addTenWorkflow | wrun_01KSSPXR77TG2VCY8RQCRRQGMG
  • addTenWorkflow | wrun_01KSSPXR77TG2VCY8RQCRRQGMG
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KSSPZXD7ZJK9AA2VTTQ2FMJZ
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KSSPY0ZM7N7Q0DP0YFF4KX5E
  • promiseRaceWorkflow | wrun_01KSSPY65M8HA9GG8T4MBZ0STR
  • promiseAnyWorkflow | wrun_01KSSPY8EDHH1GXYZFY4KWRCDE
  • importedStepOnlyWorkflow | wrun_01KSSQ08A2AYKDA9RD0TEHJ9G1
  • readableStreamWorkflow | wrun_01KSSPYD9VNSYQKP6C16JJBG77
  • hookWorkflow | wrun_01KSSPYTCTPRCX1JZ29170ANY8
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KSSPZ551Z0S7CSED1YNV5G9F
  • webhookWorkflow | wrun_01KSSPZA18X24WDCH4DFPGZV2F
  • sleepingWorkflow | wrun_01KSSPZFGV5CDZ31TG267WWSCN
  • parallelSleepWorkflow | wrun_01KSSPZYRREVYF56Y7XC3WJV4Z
  • nullByteWorkflow | wrun_01KSSQ0847NNNN6RB9AVG9PYPH
  • workflowAndStepMetadataWorkflow | wrun_01KSSQ0AXYWB59R06A8V1RNRYH
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KSSQ2PFCSJM290EBFF95Z7AS
  • fetchWorkflow | wrun_01KSSQ347QMW1V8A12XC72YJKN
  • promiseRaceStressTestWorkflow | wrun_01KSSQ37N07M01VF648W3ACK5Y
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KSSQ6SJ0W2PQ0QWRTYRG4CH3
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KSSQ75ANRH2NXMVF7X52WZRQ
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KSSQ7NGSMNQB74Z6WBCA8ARJ
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KSSQ8705MCAJ0G912AYVVC7F
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KSSQ8G7T96PFV0QRZKG56WBD
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KSSQ8P2WDM00QPP192QJPW62
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KSSQ8R98D0EMZ48H0GA2HBMJ
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KSSQ98JFXQ6N2E9FY4W13EP0
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KSSQ9MBK1E6YTTWDSHX1S0SM
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KSSQ9V6HED92FPHJJRTA9H4V
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KSSQA24D7YPNKNCMVFKD218K
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KSSQA96RDABEXVPM07DTT8QM
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KSSQAG0ZXM8EP39588G3R2TG
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KSSQAPZ6401DG0VXTH3J7266
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KSSQB3R6N4JSA9V4MDSA9J6E
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KSSQBCXZEQGKBGG86G4VF1A8
  • cancelRun - cancelling a running workflow | wrun_01KSSQBKV0BZ3J063AY77FHR8X
  • cancelRun via CLI - cancelling a running workflow | wrun_01KSSQBXH343DWH2BSDAYE48DJ
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KSSQCA1WY69CBC0PHPA9WB3D
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KSSQCT3HHS8Q20QGMSGBA6M3
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KSSQD5WSY768PKWEV42PC6K3
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KSSQDE4J6TCSYM03EZNB9KKE
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KSSQDGAEVVV28FVHB26B6S7J
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KSSQDJEK6AP93TJJGS7H1EDF

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro8107
✅ example8107
✅ express8107
✅ fastify8107
✅ hono8107
✅ nextjs-turbopack8602
✅ nextjs-webpack8602
✅ nitro8107
✅ nuxt8107
✅ sveltekit8107
✅ vite8107
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack8800
❌ 🌍 Community Worlds
AppPassedFailedSkipped
❌ mongodb-dev410
❌ redis-dev410
❌ turso-dev410
❌ turso3660
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8206
✅ e2e-local-dev-tanstack-start-stable8206
✅ e2e-local-postgres-nest-stable8206
✅ e2e-local-postgres-tanstack-start-stable8206
✅ e2e-local-prod-nest-stable8206
✅ e2e-local-prod-tanstack-start-stable8206

📋 View full workflow run

@VaguelySerious
VaguelySerious marked this pull request as ready for review May 29, 2026 11:11
@VaguelySerious
VaguelySerious requested a review from a team as a code ownerMay 29, 2026 11:11
@VaguelySerious
VaguelySerious enabled auto-merge (squash) May 29, 2026 16:10
@VaguelySerious
VaguelySerious merged commit ebfeede into stableMay 29, 2026
155 of 162 checks passed
@VaguelySerious
VaguelySerious deleted the peter/backport-inline-sourcemap-stable branch May 29, 2026 17:57
@github-actionsgithub-actionsBot mentioned this pull request May 29, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@VaguelySerious@TooTallNate
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); [stable] Backport inline sourcemap remap hardening by VaguelySerious · Pull Request #2156 · vercel/workflow · GitHub
Skip to content

[stable] Backport inline sourcemap remap hardening - #2156

Merged
VaguelySerious merged 1 commit into
stablefrom
peter/backport-inline-sourcemap-stable
May 29, 2026
Merged

[stable] Backport inline sourcemap remap hardening#2156
VaguelySerious merged 1 commit into
stablefrom
peter/backport-inline-sourcemap-stable

Conversation

@VaguelySerious

Copy link
Copy Markdown
Member

Backports 2ff8317 onto stable.

This keeps workflow error stack remapping from running a regex over large inline sourcemap bundles and adds regression coverage.

Validation:

  • pnpm exec vitest run packages/core/src/source-map.test.ts
  • pnpm --filter @workflow/core... build
  • pnpm --filter @workflow/core typecheck
  • pnpm --filter @workflow/core test
  • pnpm exec biome check packages/core/src/source-map.ts packages/core/src/source-map.test.ts .changeset/large-inline-sourcemap-remap.md

Note: pnpm lint currently fails on pre-existing stable-branch diagnostics outside this change (Biome schema drift, node: import rules, generated SvelteKit formatting, and unrelated complexity/unused-variable diagnostics).

@vercel

vercelBot commented May 29, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ca7606b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
NameType
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
workflowPatch
@workflow/world-testingPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented May 29, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production901067968
✅ 💻 Local Development9700861056
✅ 📦 Local Production9700861056
✅ 🐘 Local Postgres9700861056
✅ 🪟 Windows880088
❌ 🌍 Community Worlds1569084
✅ 📋 Other492036528
Total4406693614836

❌ Failed Tests

🌍 Community Worlds (69 failed)

mongodb-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

redis-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

turso-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

turso (66 failed):

  • addTenWorkflow | wrun_01KSSPXR77TG2VCY8RQCRRQGMG
  • addTenWorkflow | wrun_01KSSPXR77TG2VCY8RQCRRQGMG
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KSSPZXD7ZJK9AA2VTTQ2FMJZ
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KSSPY0ZM7N7Q0DP0YFF4KX5E
  • promiseRaceWorkflow | wrun_01KSSPY65M8HA9GG8T4MBZ0STR
  • promiseAnyWorkflow | wrun_01KSSPY8EDHH1GXYZFY4KWRCDE
  • importedStepOnlyWorkflow | wrun_01KSSQ08A2AYKDA9RD0TEHJ9G1
  • readableStreamWorkflow | wrun_01KSSPYD9VNSYQKP6C16JJBG77
  • hookWorkflow | wrun_01KSSPYTCTPRCX1JZ29170ANY8
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KSSPZ551Z0S7CSED1YNV5G9F
  • webhookWorkflow | wrun_01KSSPZA18X24WDCH4DFPGZV2F
  • sleepingWorkflow | wrun_01KSSPZFGV5CDZ31TG267WWSCN
  • parallelSleepWorkflow | wrun_01KSSPZYRREVYF56Y7XC3WJV4Z
  • nullByteWorkflow | wrun_01KSSQ0847NNNN6RB9AVG9PYPH
  • workflowAndStepMetadataWorkflow | wrun_01KSSQ0AXYWB59R06A8V1RNRYH
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KSSQ2PFCSJM290EBFF95Z7AS
  • fetchWorkflow | wrun_01KSSQ347QMW1V8A12XC72YJKN
  • promiseRaceStressTestWorkflow | wrun_01KSSQ37N07M01VF648W3ACK5Y
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KSSQ6SJ0W2PQ0QWRTYRG4CH3
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KSSQ75ANRH2NXMVF7X52WZRQ
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KSSQ7NGSMNQB74Z6WBCA8ARJ
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KSSQ8705MCAJ0G912AYVVC7F
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KSSQ8G7T96PFV0QRZKG56WBD
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KSSQ8P2WDM00QPP192QJPW62
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KSSQ8R98D0EMZ48H0GA2HBMJ
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KSSQ98JFXQ6N2E9FY4W13EP0
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KSSQ9MBK1E6YTTWDSHX1S0SM
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KSSQ9V6HED92FPHJJRTA9H4V
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KSSQA24D7YPNKNCMVFKD218K
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KSSQA96RDABEXVPM07DTT8QM
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KSSQAG0ZXM8EP39588G3R2TG
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KSSQAPZ6401DG0VXTH3J7266
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KSSQB3R6N4JSA9V4MDSA9J6E
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KSSQBCXZEQGKBGG86G4VF1A8
  • cancelRun - cancelling a running workflow | wrun_01KSSQBKV0BZ3J063AY77FHR8X
  • cancelRun via CLI - cancelling a running workflow | wrun_01KSSQBXH343DWH2BSDAYE48DJ
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KSSQCA1WY69CBC0PHPA9WB3D
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KSSQCT3HHS8Q20QGMSGBA6M3
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KSSQD5WSY768PKWEV42PC6K3
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KSSQDE4J6TCSYM03EZNB9KKE
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KSSQDGAEVVV28FVHB26B6S7J
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KSSQDJEK6AP93TJJGS7H1EDF

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro8107
✅ example8107
✅ express8107
✅ fastify8107
✅ hono8107
✅ nextjs-turbopack8602
✅ nextjs-webpack8602
✅ nitro8107
✅ nuxt8107
✅ sveltekit8107
✅ vite8107
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8206
✅ express-stable8206
✅ fastify-stable8206
✅ hono-stable8206
✅ nextjs-turbopack-canary69019
✅ nextjs-turbopack-stable8800
✅ nextjs-webpack-canary69019
✅ nextjs-webpack-stable8800
✅ nitro-stable8206
✅ nuxt-stable8206
✅ sveltekit-stable8206
✅ vite-stable8206
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack8800
❌ 🌍 Community Worlds
AppPassedFailedSkipped
❌ mongodb-dev410
❌ redis-dev410
❌ turso-dev410
❌ turso3660
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8206
✅ e2e-local-dev-tanstack-start-stable8206
✅ e2e-local-postgres-nest-stable8206
✅ e2e-local-postgres-tanstack-start-stable8206
✅ e2e-local-prod-nest-stable8206
✅ e2e-local-prod-tanstack-start-stable8206

📋 View full workflow run

@VaguelySerious
VaguelySerious marked this pull request as ready for review May 29, 2026 11:11
@VaguelySerious
VaguelySerious requested a review from a team as a code ownerMay 29, 2026 11:11
@VaguelySerious
VaguelySerious enabled auto-merge (squash) May 29, 2026 16:10
@VaguelySerious
VaguelySerious merged commit ebfeede into stableMay 29, 2026
155 of 162 checks passed
@VaguelySerious
VaguelySerious deleted the peter/backport-inline-sourcemap-stable branch May 29, 2026 17:57
@github-actionsgithub-actionsBot mentioned this pull request May 29, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@VaguelySerious@TooTallNate