Skip to content

Backport #2204: [world-vercel] Retry transient response-body parse failures in the HTTP client - #2207

Merged
pranaygp merged 2 commits into
stablefrom
backport/pr-2204-to-stable
Jun 2, 2026
Merged

Backport #2204: [world-vercel] Retry transient response-body parse failures in the HTTP client#2207
pranaygp merged 2 commits into
stablefrom
backport/pr-2204-to-stable

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated backport of #2204 to stable (backport job run).

AI recommendation: This is a self-contained bug fix in @workflow/world-vercel that retries transient response-body parse failures on idempotent requests, with accompanying tests. Both modified files exist on stable, the fix doesn't depend on any main-only APIs (the paired core change was reverted within this PR), and it addresses a real production issue (events.list PARSE_ERROR) that likely also affects stable.

Merge conflicts were resolved by AI (opencode with anthropic/claude-opus-4.7). Please review the conflict resolution carefully before merging.

…TP client (#2204)
* fix(world-vercel): retry transient response-body parse failures in the HTTP client
A sporadic failure reading/decoding a 2xx response body (truncated or
terminated stream, connection reset mid-body, or a gateway returning a
non-CBOR/JSON body) was surfaced immediately as a PARSE_ERROR. The
shared RetryAgent only retries connection/5xx failures — body
consumption happens after it returns the response, so these escape its
retry logic.
Retry such failures inside `makeRequest` with bounded exponential
backoff, scoped to idempotent methods (GET/HEAD) so writes are never
replayed. This fixes the reported `events.list` parse failure at the
adapter layer.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(core): propagate exhausted transient world errors to the queue
Pairs with the world-vercel in-adapter retry: when a response-body parse
failure survives the adapter's retries (or comes from a non-idempotent
write that is never retried in-process), it must not fail the run.
Re-throw such transient world errors from the replay loop so they
propagate to the queue handler, which replays the whole run — safe
because replay is idempotent. Schema-validation contract errors stay
fatal.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* Revert "fix(core): propagate exhausted transient world errors to the queue"
This reverts commit 7bb62e9.
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Peter Wielander <mittgfu@gmail.com>
@changeset-bot

changeset-botBot commented Jun 1, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f5700f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
NameType
@workflow/world-vercelPatch
@workflow/cliPatch
@workflow/corePatch
@workflow/webPatch
workflowPatch
@workflow/world-testingPatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actionsBot commented Jun 1, 2026

Copy link
Copy Markdown
ContributorAuthor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production923067990
✅ 💻 Local Development9940861080
✅ 📦 Local Production9940861080
✅ 🐘 Local Postgres9940861080
✅ 🪟 Windows900090
❌ 🌍 Community Worlds136920228
✅ 📋 Other504036540
Total4635923615088

❌ Failed Tests

🌍 Community Worlds (92 failed)

mongodb (14 failed):

  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT2SMYKMK32Z8J8QNHXCC9BA
  • webhookWorkflow | wrun_01KT2SN3820TWBZDR0GZTQBY6K
  • sleepingWorkflow | wrun_01KT2SN9RMSMT4AS2J1REPSEMV
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KT2SRC261BFFD30XTRGNJBQN
  • writableForwardedFromWorkflowWorkflow | wrun_01KT2SRTN41MMB6NNTV68QDB06
  • writableForwardedFromStepWorkflow | wrun_01KT2SRZ5XJ1APB25KWEQVDVVG
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT2SX2XNYG96NJ6QQ98Y4SNZ
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT2T3BSBWM4NBBYTYX9WNNV3

redis (9 failed):

  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT2SMYKMK32Z8J8QNHXCC9BA
  • sleepingWorkflow | wrun_01KT2SN9RMSMT4AS2J1REPSEMV
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT2SX2XNYG96NJ6QQ98Y4SNZ
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT2T3BSBWM4NBBYTYX9WNNV3

turso-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

turso (68 failed):

  • addTenWorkflow | wrun_01KT2SKR8TMZ1EQB2C3FSP04PB
  • addTenWorkflow | wrun_01KT2SKR8TMZ1EQB2C3FSP04PB
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KT2SNXWSH81J020A64BEB0HQ
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KT2SKZ1D3G01T0M9JAR577TS
  • promiseRaceWorkflow | wrun_01KT2SM3HESFKJZBENRHVESG4T
  • promiseAnyWorkflow | wrun_01KT2SM677CA3G665Y1PZSE3BC
  • importedStepOnlyWorkflow | wrun_01KT2SP92D5XD73ABM542G087D
  • readableStreamWorkflow | wrun_01KT2SM9KC086XRZVJ995D07QS
  • hookWorkflow | wrun_01KT2SMQ4ETAAVEW81F3E9C8S9
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT2SMYKMK32Z8J8QNHXCC9BA
  • webhookWorkflow | wrun_01KT2SN3820TWBZDR0GZTQBY6K
  • sleepingWorkflow | wrun_01KT2SN9RMSMT4AS2J1REPSEMV
  • parallelSleepWorkflow | wrun_01KT2SNSNTXAR73K6QVMVHY2SQ
  • nullByteWorkflow | wrun_01KT2SNX5GNRHMEETYR6T60KJ2
  • workflowAndStepMetadataWorkflow | wrun_01KT2SNZE08CVATMRS5HKA3354
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KT2SRC261BFFD30XTRGNJBQN
  • writableForwardedFromWorkflowWorkflow | wrun_01KT2SRTN41MMB6NNTV68QDB06
  • writableForwardedFromStepWorkflow | wrun_01KT2SRZ5XJ1APB25KWEQVDVVG
  • fetchWorkflow | wrun_01KT2SS38Y3EDQA66HNGNH5JW4
  • promiseRaceStressTestWorkflow | wrun_01KT2SS7N9PSTW8PZVRQ1DAR0T
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KT2SWNCX7NCK8M5SFDS0FG4D
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT2SX2XNYG96NJ6QQ98Y4SNZ
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KT2SXHYEG06K9SZHHBTNZWBW
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KT2SY1W6RGNC3XY9S6K67463
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KT2SYAYAB0JTBXR3QWKP4T78
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KT2SYGKT0Q1E1G48K3AGMZ02
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KT2SYJR3048JQACTCE71K692
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KT2SZ350ZGKC6036MTW2HG9V
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KT2SZ97YVMP4AXHFMWE1YH53
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KT2SZG2DETJQCNJX8Y22RHC4
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KT2SZPXDNK2XDX6G3FCQW6F8
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KT2SZXREZBZ8AXGB6RW3Q862
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KT2T04KB9H67QJ748WWHHGG5
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KT2T0CX0VGX1Q7A1GNC4YQ7T
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KT2T0V64P78PQ4XJRSPA7361
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KT2T14DXW5YAPH22470DNV65
  • cancelRun - cancelling a running workflow | wrun_01KT2T1CHBCR7BRTD6ZBCQZ0S1
  • cancelRun via CLI - cancelling a running workflow | wrun_01KT2T1P5NX173QZ8634JNDZVP
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KT2T22H4PBRW5KQJSJ30NYBQ
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KT2T2KDFM04D2F6VSBMC4BHS
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KT2T2Z56C7NT9EDNHWKR5ZK5
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KT2T37DPTFPBQ2344GGJKBEG
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KT2T39K7N82HKHH0CND3RQVE
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT2T3BSBWM4NBBYTYX9WNNV3

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro8307
✅ example8307
✅ express8307
✅ fastify8307
✅ hono8307
✅ nextjs-turbopack8802
✅ nextjs-webpack8802
✅ nitro8307
✅ nuxt8307
✅ sveltekit8307
✅ vite8307
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack9000
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev500
❌ mongodb57140
✅ redis-dev500
❌ redis6290
❌ turso-dev410
❌ turso3680
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8406
✅ e2e-local-dev-tanstack-start-stable8406
✅ e2e-local-postgres-nest-stable8406
✅ e2e-local-postgres-tanstack-start-stable8406
✅ e2e-local-prod-nest-stable8406
✅ e2e-local-prod-tanstack-start-stable8406

📋 View full workflow run


⚠️Community world tests failed (non-blocking):

  • Community Worlds: failure

Check the workflow run for details.

@TooTallNateTooTallNate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve — AI-resolved conflicts hold up, retry logic byte-identical to #2204

The backport bot called out that conflicts were AI-resolved, so I went through the diff carefully. The result is faithful.

Byte-identical to original

  • Changeset
  • utils.test.ts ✓ — 113 lines added, identical to main
  • Retry logic ✓ — MAX_BODY_PARSE_RETRIES = 2, BODY_PARSE_RETRY_BASE_MS = 100, the IDEMPOTENT_METHODS Set, the canRetryBody = IDEMPOTENT_METHODS.has(...) derivation, the for (let attempt = 0; ;) retry loop with exponential backoff, and the WorkflowWorldError rethrow with code: 'PARSE_ERROR' — all byte-identical to origin/main:packages/world-vercel/src/utils.ts

Stable-shape adaptations

The +183/-97 numbers in utils.ts look different from main's +297/-124 because the surrounding file shape differs:

  • Stable has getWorkflowServerUrlOverride() (used for preview workflow-server URL routing) — not on main
  • Other small shape divergence from intervening main-only refactors

Spot-checked the exports list — only the new export const MAX_BODY_PARSE_RETRIES = 2; is added; all other exports unchanged.

Correctly omits

The original PR #2204 had 3 commits:

  • 283b52e75 fix(world-vercel): retry transient response-body parse failures
  • 7bb62e9f8 fix(core): propagate exhausted transient world errors to the queue
  • 1706a5e61 Revert "fix(core): propagate exhausted transient world errors to the queue"

So the net effect on main is the world-vercel change WITHOUT the core change (the core change was added then reverted). The backport correctly only ports the world-vercel side. The bot summary noted this explicitly.

Verified locally

  • pnpm install --frozen-lockfile
  • pnpm turbo run build --filter @workflow/world-vercel
  • pnpm --filter @workflow/world-vercel test ✓ (113/113)
  • All three new retry tests pass:
    • retries an idempotent GET when the body read fails, then succeeds
    • throws PARSE_ERROR after exhausting retries for a GET
    • does NOT retry a non-idempotent POST on body-parse failure

CI

  • 85 success, 2 failures, 7 skipped
  • Failures: E2E Community World (Turso) and E2E Community World (Redis) — both pre-existing on stable's baseline (consistent across recent runs). Not caused by this PR.

Behavior summary

Sporadic PARSE_ERROR failures on idempotent reads (e.g., truncated stream body, gateway returning non-CBOR body) are now retried in-process with exponential backoff (100ms, 200ms; max 2 retries = 3 total attempts). Writes (POST/PUT/etc.) are NOT retried — replaying a write could double-apply it. Schema-validation failures remain non-retryable (retrying the same decoded payload would yield the same validation error).

Faithful backport. Approving.

@pranaygp
pranaygp merged commit 5655fcb into stableJun 2, 2026
94 of 97 checks passed
@pranaygp
pranaygp deleted the backport/pr-2204-to-stable branch June 2, 2026 02:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@TooTallNate@pranaygp
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Backport #2204: [world-vercel] Retry transient response-body parse failures in the HTTP client by github-actions[bot] · Pull Request #2207 · vercel/workflow · GitHub
Skip to content

Backport #2204: [world-vercel] Retry transient response-body parse failures in the HTTP client - #2207

Merged
pranaygp merged 2 commits into
stablefrom
backport/pr-2204-to-stable
Jun 2, 2026
Merged

Backport #2204: [world-vercel] Retry transient response-body parse failures in the HTTP client#2207
pranaygp merged 2 commits into
stablefrom
backport/pr-2204-to-stable

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated backport of #2204 to stable (backport job run).

AI recommendation: This is a self-contained bug fix in @workflow/world-vercel that retries transient response-body parse failures on idempotent requests, with accompanying tests. Both modified files exist on stable, the fix doesn't depend on any main-only APIs (the paired core change was reverted within this PR), and it addresses a real production issue (events.list PARSE_ERROR) that likely also affects stable.

Merge conflicts were resolved by AI (opencode with anthropic/claude-opus-4.7). Please review the conflict resolution carefully before merging.

…TP client (#2204)
* fix(world-vercel): retry transient response-body parse failures in the HTTP client
A sporadic failure reading/decoding a 2xx response body (truncated or
terminated stream, connection reset mid-body, or a gateway returning a
non-CBOR/JSON body) was surfaced immediately as a PARSE_ERROR. The
shared RetryAgent only retries connection/5xx failures — body
consumption happens after it returns the response, so these escape its
retry logic.
Retry such failures inside `makeRequest` with bounded exponential
backoff, scoped to idempotent methods (GET/HEAD) so writes are never
replayed. This fixes the reported `events.list` parse failure at the
adapter layer.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(core): propagate exhausted transient world errors to the queue
Pairs with the world-vercel in-adapter retry: when a response-body parse
failure survives the adapter's retries (or comes from a non-idempotent
write that is never retried in-process), it must not fail the run.
Re-throw such transient world errors from the replay loop so they
propagate to the queue handler, which replays the whole run — safe
because replay is idempotent. Schema-validation contract errors stay
fatal.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* Revert "fix(core): propagate exhausted transient world errors to the queue"
This reverts commit 7bb62e9.
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Peter Wielander <mittgfu@gmail.com>
@changeset-bot

changeset-botBot commented Jun 1, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f5700f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
NameType
@workflow/world-vercelPatch
@workflow/cliPatch
@workflow/corePatch
@workflow/webPatch
workflowPatch
@workflow/world-testingPatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actionsBot commented Jun 1, 2026

Copy link
Copy Markdown
ContributorAuthor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production923067990
✅ 💻 Local Development9940861080
✅ 📦 Local Production9940861080
✅ 🐘 Local Postgres9940861080
✅ 🪟 Windows900090
❌ 🌍 Community Worlds136920228
✅ 📋 Other504036540
Total4635923615088

❌ Failed Tests

🌍 Community Worlds (92 failed)

mongodb (14 failed):

  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT2SMYKMK32Z8J8QNHXCC9BA
  • webhookWorkflow | wrun_01KT2SN3820TWBZDR0GZTQBY6K
  • sleepingWorkflow | wrun_01KT2SN9RMSMT4AS2J1REPSEMV
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KT2SRC261BFFD30XTRGNJBQN
  • writableForwardedFromWorkflowWorkflow | wrun_01KT2SRTN41MMB6NNTV68QDB06
  • writableForwardedFromStepWorkflow | wrun_01KT2SRZ5XJ1APB25KWEQVDVVG
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT2SX2XNYG96NJ6QQ98Y4SNZ
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT2T3BSBWM4NBBYTYX9WNNV3

redis (9 failed):

  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT2SMYKMK32Z8J8QNHXCC9BA
  • sleepingWorkflow | wrun_01KT2SN9RMSMT4AS2J1REPSEMV
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT2SX2XNYG96NJ6QQ98Y4SNZ
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT2T3BSBWM4NBBYTYX9WNNV3

turso-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

turso (68 failed):

  • addTenWorkflow | wrun_01KT2SKR8TMZ1EQB2C3FSP04PB
  • addTenWorkflow | wrun_01KT2SKR8TMZ1EQB2C3FSP04PB
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KT2SNXWSH81J020A64BEB0HQ
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KT2SKZ1D3G01T0M9JAR577TS
  • promiseRaceWorkflow | wrun_01KT2SM3HESFKJZBENRHVESG4T
  • promiseAnyWorkflow | wrun_01KT2SM677CA3G665Y1PZSE3BC
  • importedStepOnlyWorkflow | wrun_01KT2SP92D5XD73ABM542G087D
  • readableStreamWorkflow | wrun_01KT2SM9KC086XRZVJ995D07QS
  • hookWorkflow | wrun_01KT2SMQ4ETAAVEW81F3E9C8S9
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT2SMYKMK32Z8J8QNHXCC9BA
  • webhookWorkflow | wrun_01KT2SN3820TWBZDR0GZTQBY6K
  • sleepingWorkflow | wrun_01KT2SN9RMSMT4AS2J1REPSEMV
  • parallelSleepWorkflow | wrun_01KT2SNSNTXAR73K6QVMVHY2SQ
  • nullByteWorkflow | wrun_01KT2SNX5GNRHMEETYR6T60KJ2
  • workflowAndStepMetadataWorkflow | wrun_01KT2SNZE08CVATMRS5HKA3354
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KT2SRC261BFFD30XTRGNJBQN
  • writableForwardedFromWorkflowWorkflow | wrun_01KT2SRTN41MMB6NNTV68QDB06
  • writableForwardedFromStepWorkflow | wrun_01KT2SRZ5XJ1APB25KWEQVDVVG
  • fetchWorkflow | wrun_01KT2SS38Y3EDQA66HNGNH5JW4
  • promiseRaceStressTestWorkflow | wrun_01KT2SS7N9PSTW8PZVRQ1DAR0T
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KT2SWNCX7NCK8M5SFDS0FG4D
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT2SX2XNYG96NJ6QQ98Y4SNZ
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KT2SXHYEG06K9SZHHBTNZWBW
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KT2SY1W6RGNC3XY9S6K67463
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KT2SYAYAB0JTBXR3QWKP4T78
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KT2SYGKT0Q1E1G48K3AGMZ02
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KT2SYJR3048JQACTCE71K692
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KT2SZ350ZGKC6036MTW2HG9V
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KT2SZ97YVMP4AXHFMWE1YH53
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KT2SZG2DETJQCNJX8Y22RHC4
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KT2SZPXDNK2XDX6G3FCQW6F8
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KT2SZXREZBZ8AXGB6RW3Q862
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KT2T04KB9H67QJ748WWHHGG5
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KT2T0CX0VGX1Q7A1GNC4YQ7T
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KT2T0V64P78PQ4XJRSPA7361
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KT2T14DXW5YAPH22470DNV65
  • cancelRun - cancelling a running workflow | wrun_01KT2T1CHBCR7BRTD6ZBCQZ0S1
  • cancelRun via CLI - cancelling a running workflow | wrun_01KT2T1P5NX173QZ8634JNDZVP
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KT2T22H4PBRW5KQJSJ30NYBQ
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KT2T2KDFM04D2F6VSBMC4BHS
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KT2T2Z56C7NT9EDNHWKR5ZK5
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KT2T37DPTFPBQ2344GGJKBEG
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KT2T39K7N82HKHH0CND3RQVE
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT2T3BSBWM4NBBYTYX9WNNV3

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro8307
✅ example8307
✅ express8307
✅ fastify8307
✅ hono8307
✅ nextjs-turbopack8802
✅ nextjs-webpack8802
✅ nitro8307
✅ nuxt8307
✅ sveltekit8307
✅ vite8307
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack9000
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev500
❌ mongodb57140
✅ redis-dev500
❌ redis6290
❌ turso-dev410
❌ turso3680
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8406
✅ e2e-local-dev-tanstack-start-stable8406
✅ e2e-local-postgres-nest-stable8406
✅ e2e-local-postgres-tanstack-start-stable8406
✅ e2e-local-prod-nest-stable8406
✅ e2e-local-prod-tanstack-start-stable8406

📋 View full workflow run


⚠️Community world tests failed (non-blocking):

  • Community Worlds: failure

Check the workflow run for details.

@TooTallNateTooTallNate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve — AI-resolved conflicts hold up, retry logic byte-identical to #2204

The backport bot called out that conflicts were AI-resolved, so I went through the diff carefully. The result is faithful.

Byte-identical to original

  • Changeset
  • utils.test.ts ✓ — 113 lines added, identical to main
  • Retry logic ✓ — MAX_BODY_PARSE_RETRIES = 2, BODY_PARSE_RETRY_BASE_MS = 100, the IDEMPOTENT_METHODS Set, the canRetryBody = IDEMPOTENT_METHODS.has(...) derivation, the for (let attempt = 0; ;) retry loop with exponential backoff, and the WorkflowWorldError rethrow with code: 'PARSE_ERROR' — all byte-identical to origin/main:packages/world-vercel/src/utils.ts

Stable-shape adaptations

The +183/-97 numbers in utils.ts look different from main's +297/-124 because the surrounding file shape differs:

  • Stable has getWorkflowServerUrlOverride() (used for preview workflow-server URL routing) — not on main
  • Other small shape divergence from intervening main-only refactors

Spot-checked the exports list — only the new export const MAX_BODY_PARSE_RETRIES = 2; is added; all other exports unchanged.

Correctly omits

The original PR #2204 had 3 commits:

  • 283b52e75 fix(world-vercel): retry transient response-body parse failures
  • 7bb62e9f8 fix(core): propagate exhausted transient world errors to the queue
  • 1706a5e61 Revert "fix(core): propagate exhausted transient world errors to the queue"

So the net effect on main is the world-vercel change WITHOUT the core change (the core change was added then reverted). The backport correctly only ports the world-vercel side. The bot summary noted this explicitly.

Verified locally

  • pnpm install --frozen-lockfile
  • pnpm turbo run build --filter @workflow/world-vercel
  • pnpm --filter @workflow/world-vercel test ✓ (113/113)
  • All three new retry tests pass:
    • retries an idempotent GET when the body read fails, then succeeds
    • throws PARSE_ERROR after exhausting retries for a GET
    • does NOT retry a non-idempotent POST on body-parse failure

CI

  • 85 success, 2 failures, 7 skipped
  • Failures: E2E Community World (Turso) and E2E Community World (Redis) — both pre-existing on stable's baseline (consistent across recent runs). Not caused by this PR.

Behavior summary

Sporadic PARSE_ERROR failures on idempotent reads (e.g., truncated stream body, gateway returning non-CBOR body) are now retried in-process with exponential backoff (100ms, 200ms; max 2 retries = 3 total attempts). Writes (POST/PUT/etc.) are NOT retried — replaying a write could double-apply it. Schema-validation failures remain non-retryable (retrying the same decoded payload would yield the same validation error).

Faithful backport. Approving.

@pranaygp
pranaygp merged commit 5655fcb into stableJun 2, 2026
94 of 97 checks passed
@pranaygp
pranaygp deleted the backport/pr-2204-to-stable branch June 2, 2026 02:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@TooTallNate@pranaygp
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Backport #2204: [world-vercel] Retry transient response-body parse failures in the HTTP client by github-actions[bot] · Pull Request #2207 · vercel/workflow · GitHub
Skip to content

Backport #2204: [world-vercel] Retry transient response-body parse failures in the HTTP client - #2207

Merged
pranaygp merged 2 commits into
stablefrom
backport/pr-2204-to-stable
Jun 2, 2026
Merged

Backport #2204: [world-vercel] Retry transient response-body parse failures in the HTTP client#2207
pranaygp merged 2 commits into
stablefrom
backport/pr-2204-to-stable

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated backport of #2204 to stable (backport job run).

AI recommendation: This is a self-contained bug fix in @workflow/world-vercel that retries transient response-body parse failures on idempotent requests, with accompanying tests. Both modified files exist on stable, the fix doesn't depend on any main-only APIs (the paired core change was reverted within this PR), and it addresses a real production issue (events.list PARSE_ERROR) that likely also affects stable.

Merge conflicts were resolved by AI (opencode with anthropic/claude-opus-4.7). Please review the conflict resolution carefully before merging.

…TP client (#2204)
* fix(world-vercel): retry transient response-body parse failures in the HTTP client
A sporadic failure reading/decoding a 2xx response body (truncated or
terminated stream, connection reset mid-body, or a gateway returning a
non-CBOR/JSON body) was surfaced immediately as a PARSE_ERROR. The
shared RetryAgent only retries connection/5xx failures — body
consumption happens after it returns the response, so these escape its
retry logic.
Retry such failures inside `makeRequest` with bounded exponential
backoff, scoped to idempotent methods (GET/HEAD) so writes are never
replayed. This fixes the reported `events.list` parse failure at the
adapter layer.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(core): propagate exhausted transient world errors to the queue
Pairs with the world-vercel in-adapter retry: when a response-body parse
failure survives the adapter's retries (or comes from a non-idempotent
write that is never retried in-process), it must not fail the run.
Re-throw such transient world errors from the replay loop so they
propagate to the queue handler, which replays the whole run — safe
because replay is idempotent. Schema-validation contract errors stay
fatal.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* Revert "fix(core): propagate exhausted transient world errors to the queue"
This reverts commit 7bb62e9.
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Peter Wielander <mittgfu@gmail.com>
@changeset-bot

changeset-botBot commented Jun 1, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f5700f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
NameType
@workflow/world-vercelPatch
@workflow/cliPatch
@workflow/corePatch
@workflow/webPatch
workflowPatch
@workflow/world-testingPatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actionsBot commented Jun 1, 2026

Copy link
Copy Markdown
ContributorAuthor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production923067990
✅ 💻 Local Development9940861080
✅ 📦 Local Production9940861080
✅ 🐘 Local Postgres9940861080
✅ 🪟 Windows900090
❌ 🌍 Community Worlds136920228
✅ 📋 Other504036540
Total4635923615088

❌ Failed Tests

🌍 Community Worlds (92 failed)

mongodb (14 failed):

  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT2SMYKMK32Z8J8QNHXCC9BA
  • webhookWorkflow | wrun_01KT2SN3820TWBZDR0GZTQBY6K
  • sleepingWorkflow | wrun_01KT2SN9RMSMT4AS2J1REPSEMV
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KT2SRC261BFFD30XTRGNJBQN
  • writableForwardedFromWorkflowWorkflow | wrun_01KT2SRTN41MMB6NNTV68QDB06
  • writableForwardedFromStepWorkflow | wrun_01KT2SRZ5XJ1APB25KWEQVDVVG
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT2SX2XNYG96NJ6QQ98Y4SNZ
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT2T3BSBWM4NBBYTYX9WNNV3

redis (9 failed):

  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT2SMYKMK32Z8J8QNHXCC9BA
  • sleepingWorkflow | wrun_01KT2SN9RMSMT4AS2J1REPSEMV
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT2SX2XNYG96NJ6QQ98Y4SNZ
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT2T3BSBWM4NBBYTYX9WNNV3

turso-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

turso (68 failed):

  • addTenWorkflow | wrun_01KT2SKR8TMZ1EQB2C3FSP04PB
  • addTenWorkflow | wrun_01KT2SKR8TMZ1EQB2C3FSP04PB
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KT2SNXWSH81J020A64BEB0HQ
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KT2SKZ1D3G01T0M9JAR577TS
  • promiseRaceWorkflow | wrun_01KT2SM3HESFKJZBENRHVESG4T
  • promiseAnyWorkflow | wrun_01KT2SM677CA3G665Y1PZSE3BC
  • importedStepOnlyWorkflow | wrun_01KT2SP92D5XD73ABM542G087D
  • readableStreamWorkflow | wrun_01KT2SM9KC086XRZVJ995D07QS
  • hookWorkflow | wrun_01KT2SMQ4ETAAVEW81F3E9C8S9
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT2SMYKMK32Z8J8QNHXCC9BA
  • webhookWorkflow | wrun_01KT2SN3820TWBZDR0GZTQBY6K
  • sleepingWorkflow | wrun_01KT2SN9RMSMT4AS2J1REPSEMV
  • parallelSleepWorkflow | wrun_01KT2SNSNTXAR73K6QVMVHY2SQ
  • nullByteWorkflow | wrun_01KT2SNX5GNRHMEETYR6T60KJ2
  • workflowAndStepMetadataWorkflow | wrun_01KT2SNZE08CVATMRS5HKA3354
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KT2SRC261BFFD30XTRGNJBQN
  • writableForwardedFromWorkflowWorkflow | wrun_01KT2SRTN41MMB6NNTV68QDB06
  • writableForwardedFromStepWorkflow | wrun_01KT2SRZ5XJ1APB25KWEQVDVVG
  • fetchWorkflow | wrun_01KT2SS38Y3EDQA66HNGNH5JW4
  • promiseRaceStressTestWorkflow | wrun_01KT2SS7N9PSTW8PZVRQ1DAR0T
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KT2SWNCX7NCK8M5SFDS0FG4D
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT2SX2XNYG96NJ6QQ98Y4SNZ
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KT2SXHYEG06K9SZHHBTNZWBW
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KT2SY1W6RGNC3XY9S6K67463
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KT2SYAYAB0JTBXR3QWKP4T78
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KT2SYGKT0Q1E1G48K3AGMZ02
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KT2SYJR3048JQACTCE71K692
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KT2SZ350ZGKC6036MTW2HG9V
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KT2SZ97YVMP4AXHFMWE1YH53
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KT2SZG2DETJQCNJX8Y22RHC4
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KT2SZPXDNK2XDX6G3FCQW6F8
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KT2SZXREZBZ8AXGB6RW3Q862
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KT2T04KB9H67QJ748WWHHGG5
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KT2T0CX0VGX1Q7A1GNC4YQ7T
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KT2T0V64P78PQ4XJRSPA7361
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KT2T14DXW5YAPH22470DNV65
  • cancelRun - cancelling a running workflow | wrun_01KT2T1CHBCR7BRTD6ZBCQZ0S1
  • cancelRun via CLI - cancelling a running workflow | wrun_01KT2T1P5NX173QZ8634JNDZVP
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KT2T22H4PBRW5KQJSJ30NYBQ
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KT2T2KDFM04D2F6VSBMC4BHS
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KT2T2Z56C7NT9EDNHWKR5ZK5
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KT2T37DPTFPBQ2344GGJKBEG
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KT2T39K7N82HKHH0CND3RQVE
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT2T3BSBWM4NBBYTYX9WNNV3

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro8307
✅ example8307
✅ express8307
✅ fastify8307
✅ hono8307
✅ nextjs-turbopack8802
✅ nextjs-webpack8802
✅ nitro8307
✅ nuxt8307
✅ sveltekit8307
✅ vite8307
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack9000
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev500
❌ mongodb57140
✅ redis-dev500
❌ redis6290
❌ turso-dev410
❌ turso3680
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8406
✅ e2e-local-dev-tanstack-start-stable8406
✅ e2e-local-postgres-nest-stable8406
✅ e2e-local-postgres-tanstack-start-stable8406
✅ e2e-local-prod-nest-stable8406
✅ e2e-local-prod-tanstack-start-stable8406

📋 View full workflow run


⚠️Community world tests failed (non-blocking):

  • Community Worlds: failure

Check the workflow run for details.

@TooTallNateTooTallNate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve — AI-resolved conflicts hold up, retry logic byte-identical to #2204

The backport bot called out that conflicts were AI-resolved, so I went through the diff carefully. The result is faithful.

Byte-identical to original

  • Changeset
  • utils.test.ts ✓ — 113 lines added, identical to main
  • Retry logic ✓ — MAX_BODY_PARSE_RETRIES = 2, BODY_PARSE_RETRY_BASE_MS = 100, the IDEMPOTENT_METHODS Set, the canRetryBody = IDEMPOTENT_METHODS.has(...) derivation, the for (let attempt = 0; ;) retry loop with exponential backoff, and the WorkflowWorldError rethrow with code: 'PARSE_ERROR' — all byte-identical to origin/main:packages/world-vercel/src/utils.ts

Stable-shape adaptations

The +183/-97 numbers in utils.ts look different from main's +297/-124 because the surrounding file shape differs:

  • Stable has getWorkflowServerUrlOverride() (used for preview workflow-server URL routing) — not on main
  • Other small shape divergence from intervening main-only refactors

Spot-checked the exports list — only the new export const MAX_BODY_PARSE_RETRIES = 2; is added; all other exports unchanged.

Correctly omits

The original PR #2204 had 3 commits:

  • 283b52e75 fix(world-vercel): retry transient response-body parse failures
  • 7bb62e9f8 fix(core): propagate exhausted transient world errors to the queue
  • 1706a5e61 Revert "fix(core): propagate exhausted transient world errors to the queue"

So the net effect on main is the world-vercel change WITHOUT the core change (the core change was added then reverted). The backport correctly only ports the world-vercel side. The bot summary noted this explicitly.

Verified locally

  • pnpm install --frozen-lockfile
  • pnpm turbo run build --filter @workflow/world-vercel
  • pnpm --filter @workflow/world-vercel test ✓ (113/113)
  • All three new retry tests pass:
    • retries an idempotent GET when the body read fails, then succeeds
    • throws PARSE_ERROR after exhausting retries for a GET
    • does NOT retry a non-idempotent POST on body-parse failure

CI

  • 85 success, 2 failures, 7 skipped
  • Failures: E2E Community World (Turso) and E2E Community World (Redis) — both pre-existing on stable's baseline (consistent across recent runs). Not caused by this PR.

Behavior summary

Sporadic PARSE_ERROR failures on idempotent reads (e.g., truncated stream body, gateway returning non-CBOR body) are now retried in-process with exponential backoff (100ms, 200ms; max 2 retries = 3 total attempts). Writes (POST/PUT/etc.) are NOT retried — replaying a write could double-apply it. Schema-validation failures remain non-retryable (retrying the same decoded payload would yield the same validation error).

Faithful backport. Approving.

@pranaygp
pranaygp merged commit 5655fcb into stableJun 2, 2026
94 of 97 checks passed
@pranaygp
pranaygp deleted the backport/pr-2204-to-stable branch June 2, 2026 02:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@TooTallNate@pranaygp
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Backport #2204: [world-vercel] Retry transient response-body parse failures in the HTTP client by github-actions[bot] · Pull Request #2207 · vercel/workflow · GitHub
Skip to content

Backport #2204: [world-vercel] Retry transient response-body parse failures in the HTTP client - #2207

Merged
pranaygp merged 2 commits into
stablefrom
backport/pr-2204-to-stable
Jun 2, 2026
Merged

Backport #2204: [world-vercel] Retry transient response-body parse failures in the HTTP client#2207
pranaygp merged 2 commits into
stablefrom
backport/pr-2204-to-stable

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated backport of #2204 to stable (backport job run).

AI recommendation: This is a self-contained bug fix in @workflow/world-vercel that retries transient response-body parse failures on idempotent requests, with accompanying tests. Both modified files exist on stable, the fix doesn't depend on any main-only APIs (the paired core change was reverted within this PR), and it addresses a real production issue (events.list PARSE_ERROR) that likely also affects stable.

Merge conflicts were resolved by AI (opencode with anthropic/claude-opus-4.7). Please review the conflict resolution carefully before merging.

…TP client (#2204)
* fix(world-vercel): retry transient response-body parse failures in the HTTP client
A sporadic failure reading/decoding a 2xx response body (truncated or
terminated stream, connection reset mid-body, or a gateway returning a
non-CBOR/JSON body) was surfaced immediately as a PARSE_ERROR. The
shared RetryAgent only retries connection/5xx failures — body
consumption happens after it returns the response, so these escape its
retry logic.
Retry such failures inside `makeRequest` with bounded exponential
backoff, scoped to idempotent methods (GET/HEAD) so writes are never
replayed. This fixes the reported `events.list` parse failure at the
adapter layer.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(core): propagate exhausted transient world errors to the queue
Pairs with the world-vercel in-adapter retry: when a response-body parse
failure survives the adapter's retries (or comes from a non-idempotent
write that is never retried in-process), it must not fail the run.
Re-throw such transient world errors from the replay loop so they
propagate to the queue handler, which replays the whole run — safe
because replay is idempotent. Schema-validation contract errors stay
fatal.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* Revert "fix(core): propagate exhausted transient world errors to the queue"
This reverts commit 7bb62e9.
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Peter Wielander <mittgfu@gmail.com>
@changeset-bot

changeset-botBot commented Jun 1, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f5700f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
NameType
@workflow/world-vercelPatch
@workflow/cliPatch
@workflow/corePatch
@workflow/webPatch
workflowPatch
@workflow/world-testingPatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actionsBot commented Jun 1, 2026

Copy link
Copy Markdown
ContributorAuthor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production923067990
✅ 💻 Local Development9940861080
✅ 📦 Local Production9940861080
✅ 🐘 Local Postgres9940861080
✅ 🪟 Windows900090
❌ 🌍 Community Worlds136920228
✅ 📋 Other504036540
Total4635923615088

❌ Failed Tests

🌍 Community Worlds (92 failed)

mongodb (14 failed):

  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT2SMYKMK32Z8J8QNHXCC9BA
  • webhookWorkflow | wrun_01KT2SN3820TWBZDR0GZTQBY6K
  • sleepingWorkflow | wrun_01KT2SN9RMSMT4AS2J1REPSEMV
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KT2SRC261BFFD30XTRGNJBQN
  • writableForwardedFromWorkflowWorkflow | wrun_01KT2SRTN41MMB6NNTV68QDB06
  • writableForwardedFromStepWorkflow | wrun_01KT2SRZ5XJ1APB25KWEQVDVVG
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT2SX2XNYG96NJ6QQ98Y4SNZ
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT2T3BSBWM4NBBYTYX9WNNV3

redis (9 failed):

  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT2SMYKMK32Z8J8QNHXCC9BA
  • sleepingWorkflow | wrun_01KT2SN9RMSMT4AS2J1REPSEMV
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT2SX2XNYG96NJ6QQ98Y4SNZ
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT2T3BSBWM4NBBYTYX9WNNV3

turso-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

turso (68 failed):

  • addTenWorkflow | wrun_01KT2SKR8TMZ1EQB2C3FSP04PB
  • addTenWorkflow | wrun_01KT2SKR8TMZ1EQB2C3FSP04PB
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KT2SNXWSH81J020A64BEB0HQ
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KT2SKZ1D3G01T0M9JAR577TS
  • promiseRaceWorkflow | wrun_01KT2SM3HESFKJZBENRHVESG4T
  • promiseAnyWorkflow | wrun_01KT2SM677CA3G665Y1PZSE3BC
  • importedStepOnlyWorkflow | wrun_01KT2SP92D5XD73ABM542G087D
  • readableStreamWorkflow | wrun_01KT2SM9KC086XRZVJ995D07QS
  • hookWorkflow | wrun_01KT2SMQ4ETAAVEW81F3E9C8S9
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT2SMYKMK32Z8J8QNHXCC9BA
  • webhookWorkflow | wrun_01KT2SN3820TWBZDR0GZTQBY6K
  • sleepingWorkflow | wrun_01KT2SN9RMSMT4AS2J1REPSEMV
  • parallelSleepWorkflow | wrun_01KT2SNSNTXAR73K6QVMVHY2SQ
  • nullByteWorkflow | wrun_01KT2SNX5GNRHMEETYR6T60KJ2
  • workflowAndStepMetadataWorkflow | wrun_01KT2SNZE08CVATMRS5HKA3354
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KT2SRC261BFFD30XTRGNJBQN
  • writableForwardedFromWorkflowWorkflow | wrun_01KT2SRTN41MMB6NNTV68QDB06
  • writableForwardedFromStepWorkflow | wrun_01KT2SRZ5XJ1APB25KWEQVDVVG
  • fetchWorkflow | wrun_01KT2SS38Y3EDQA66HNGNH5JW4
  • promiseRaceStressTestWorkflow | wrun_01KT2SS7N9PSTW8PZVRQ1DAR0T
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KT2SWNCX7NCK8M5SFDS0FG4D
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT2SX2XNYG96NJ6QQ98Y4SNZ
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KT2SXHYEG06K9SZHHBTNZWBW
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KT2SY1W6RGNC3XY9S6K67463
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KT2SYAYAB0JTBXR3QWKP4T78
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KT2SYGKT0Q1E1G48K3AGMZ02
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KT2SYJR3048JQACTCE71K692
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KT2SZ350ZGKC6036MTW2HG9V
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KT2SZ97YVMP4AXHFMWE1YH53
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KT2SZG2DETJQCNJX8Y22RHC4
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KT2SZPXDNK2XDX6G3FCQW6F8
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KT2SZXREZBZ8AXGB6RW3Q862
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KT2T04KB9H67QJ748WWHHGG5
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KT2T0CX0VGX1Q7A1GNC4YQ7T
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KT2T0V64P78PQ4XJRSPA7361
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KT2T14DXW5YAPH22470DNV65
  • cancelRun - cancelling a running workflow | wrun_01KT2T1CHBCR7BRTD6ZBCQZ0S1
  • cancelRun via CLI - cancelling a running workflow | wrun_01KT2T1P5NX173QZ8634JNDZVP
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KT2T22H4PBRW5KQJSJ30NYBQ
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KT2T2KDFM04D2F6VSBMC4BHS
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KT2T2Z56C7NT9EDNHWKR5ZK5
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KT2T37DPTFPBQ2344GGJKBEG
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KT2T39K7N82HKHH0CND3RQVE
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT2T3BSBWM4NBBYTYX9WNNV3

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro8307
✅ example8307
✅ express8307
✅ fastify8307
✅ hono8307
✅ nextjs-turbopack8802
✅ nextjs-webpack8802
✅ nitro8307
✅ nuxt8307
✅ sveltekit8307
✅ vite8307
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack9000
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev500
❌ mongodb57140
✅ redis-dev500
❌ redis6290
❌ turso-dev410
❌ turso3680
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8406
✅ e2e-local-dev-tanstack-start-stable8406
✅ e2e-local-postgres-nest-stable8406
✅ e2e-local-postgres-tanstack-start-stable8406
✅ e2e-local-prod-nest-stable8406
✅ e2e-local-prod-tanstack-start-stable8406

📋 View full workflow run


⚠️Community world tests failed (non-blocking):

  • Community Worlds: failure

Check the workflow run for details.

@TooTallNateTooTallNate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve — AI-resolved conflicts hold up, retry logic byte-identical to #2204

The backport bot called out that conflicts were AI-resolved, so I went through the diff carefully. The result is faithful.

Byte-identical to original

  • Changeset
  • utils.test.ts ✓ — 113 lines added, identical to main
  • Retry logic ✓ — MAX_BODY_PARSE_RETRIES = 2, BODY_PARSE_RETRY_BASE_MS = 100, the IDEMPOTENT_METHODS Set, the canRetryBody = IDEMPOTENT_METHODS.has(...) derivation, the for (let attempt = 0; ;) retry loop with exponential backoff, and the WorkflowWorldError rethrow with code: 'PARSE_ERROR' — all byte-identical to origin/main:packages/world-vercel/src/utils.ts

Stable-shape adaptations

The +183/-97 numbers in utils.ts look different from main's +297/-124 because the surrounding file shape differs:

  • Stable has getWorkflowServerUrlOverride() (used for preview workflow-server URL routing) — not on main
  • Other small shape divergence from intervening main-only refactors

Spot-checked the exports list — only the new export const MAX_BODY_PARSE_RETRIES = 2; is added; all other exports unchanged.

Correctly omits

The original PR #2204 had 3 commits:

  • 283b52e75 fix(world-vercel): retry transient response-body parse failures
  • 7bb62e9f8 fix(core): propagate exhausted transient world errors to the queue
  • 1706a5e61 Revert "fix(core): propagate exhausted transient world errors to the queue"

So the net effect on main is the world-vercel change WITHOUT the core change (the core change was added then reverted). The backport correctly only ports the world-vercel side. The bot summary noted this explicitly.

Verified locally

  • pnpm install --frozen-lockfile
  • pnpm turbo run build --filter @workflow/world-vercel
  • pnpm --filter @workflow/world-vercel test ✓ (113/113)
  • All three new retry tests pass:
    • retries an idempotent GET when the body read fails, then succeeds
    • throws PARSE_ERROR after exhausting retries for a GET
    • does NOT retry a non-idempotent POST on body-parse failure

CI

  • 85 success, 2 failures, 7 skipped
  • Failures: E2E Community World (Turso) and E2E Community World (Redis) — both pre-existing on stable's baseline (consistent across recent runs). Not caused by this PR.

Behavior summary

Sporadic PARSE_ERROR failures on idempotent reads (e.g., truncated stream body, gateway returning non-CBOR body) are now retried in-process with exponential backoff (100ms, 200ms; max 2 retries = 3 total attempts). Writes (POST/PUT/etc.) are NOT retried — replaying a write could double-apply it. Schema-validation failures remain non-retryable (retrying the same decoded payload would yield the same validation error).

Faithful backport. Approving.

@pranaygp
pranaygp merged commit 5655fcb into stableJun 2, 2026
94 of 97 checks passed
@pranaygp
pranaygp deleted the backport/pr-2204-to-stable branch June 2, 2026 02:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@TooTallNate@pranaygp
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Backport #2204: [world-vercel] Retry transient response-body parse failures in the HTTP client by github-actions[bot] · Pull Request #2207 · vercel/workflow · GitHub
Skip to content

Backport #2204: [world-vercel] Retry transient response-body parse failures in the HTTP client - #2207

Merged
pranaygp merged 2 commits into
stablefrom
backport/pr-2204-to-stable
Jun 2, 2026
Merged

Backport #2204: [world-vercel] Retry transient response-body parse failures in the HTTP client#2207
pranaygp merged 2 commits into
stablefrom
backport/pr-2204-to-stable

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated backport of #2204 to stable (backport job run).

AI recommendation: This is a self-contained bug fix in @workflow/world-vercel that retries transient response-body parse failures on idempotent requests, with accompanying tests. Both modified files exist on stable, the fix doesn't depend on any main-only APIs (the paired core change was reverted within this PR), and it addresses a real production issue (events.list PARSE_ERROR) that likely also affects stable.

Merge conflicts were resolved by AI (opencode with anthropic/claude-opus-4.7). Please review the conflict resolution carefully before merging.

…TP client (#2204)
* fix(world-vercel): retry transient response-body parse failures in the HTTP client
A sporadic failure reading/decoding a 2xx response body (truncated or
terminated stream, connection reset mid-body, or a gateway returning a
non-CBOR/JSON body) was surfaced immediately as a PARSE_ERROR. The
shared RetryAgent only retries connection/5xx failures — body
consumption happens after it returns the response, so these escape its
retry logic.
Retry such failures inside `makeRequest` with bounded exponential
backoff, scoped to idempotent methods (GET/HEAD) so writes are never
replayed. This fixes the reported `events.list` parse failure at the
adapter layer.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(core): propagate exhausted transient world errors to the queue
Pairs with the world-vercel in-adapter retry: when a response-body parse
failure survives the adapter's retries (or comes from a non-idempotent
write that is never retried in-process), it must not fail the run.
Re-throw such transient world errors from the replay loop so they
propagate to the queue handler, which replays the whole run — safe
because replay is idempotent. Schema-validation contract errors stay
fatal.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* Revert "fix(core): propagate exhausted transient world errors to the queue"
This reverts commit 7bb62e9.
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Peter Wielander <mittgfu@gmail.com>
@changeset-bot

changeset-botBot commented Jun 1, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f5700f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
NameType
@workflow/world-vercelPatch
@workflow/cliPatch
@workflow/corePatch
@workflow/webPatch
workflowPatch
@workflow/world-testingPatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actionsBot commented Jun 1, 2026

Copy link
Copy Markdown
ContributorAuthor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production923067990
✅ 💻 Local Development9940861080
✅ 📦 Local Production9940861080
✅ 🐘 Local Postgres9940861080
✅ 🪟 Windows900090
❌ 🌍 Community Worlds136920228
✅ 📋 Other504036540
Total4635923615088

❌ Failed Tests

🌍 Community Worlds (92 failed)

mongodb (14 failed):

  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT2SMYKMK32Z8J8QNHXCC9BA
  • webhookWorkflow | wrun_01KT2SN3820TWBZDR0GZTQBY6K
  • sleepingWorkflow | wrun_01KT2SN9RMSMT4AS2J1REPSEMV
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KT2SRC261BFFD30XTRGNJBQN
  • writableForwardedFromWorkflowWorkflow | wrun_01KT2SRTN41MMB6NNTV68QDB06
  • writableForwardedFromStepWorkflow | wrun_01KT2SRZ5XJ1APB25KWEQVDVVG
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT2SX2XNYG96NJ6QQ98Y4SNZ
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT2T3BSBWM4NBBYTYX9WNNV3

redis (9 failed):

  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT2SMYKMK32Z8J8QNHXCC9BA
  • sleepingWorkflow | wrun_01KT2SN9RMSMT4AS2J1REPSEMV
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT2SX2XNYG96NJ6QQ98Y4SNZ
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT2T3BSBWM4NBBYTYX9WNNV3

turso-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

turso (68 failed):

  • addTenWorkflow | wrun_01KT2SKR8TMZ1EQB2C3FSP04PB
  • addTenWorkflow | wrun_01KT2SKR8TMZ1EQB2C3FSP04PB
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KT2SNXWSH81J020A64BEB0HQ
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KT2SKZ1D3G01T0M9JAR577TS
  • promiseRaceWorkflow | wrun_01KT2SM3HESFKJZBENRHVESG4T
  • promiseAnyWorkflow | wrun_01KT2SM677CA3G665Y1PZSE3BC
  • importedStepOnlyWorkflow | wrun_01KT2SP92D5XD73ABM542G087D
  • readableStreamWorkflow | wrun_01KT2SM9KC086XRZVJ995D07QS
  • hookWorkflow | wrun_01KT2SMQ4ETAAVEW81F3E9C8S9
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT2SMYKMK32Z8J8QNHXCC9BA
  • webhookWorkflow | wrun_01KT2SN3820TWBZDR0GZTQBY6K
  • sleepingWorkflow | wrun_01KT2SN9RMSMT4AS2J1REPSEMV
  • parallelSleepWorkflow | wrun_01KT2SNSNTXAR73K6QVMVHY2SQ
  • nullByteWorkflow | wrun_01KT2SNX5GNRHMEETYR6T60KJ2
  • workflowAndStepMetadataWorkflow | wrun_01KT2SNZE08CVATMRS5HKA3354
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KT2SRC261BFFD30XTRGNJBQN
  • writableForwardedFromWorkflowWorkflow | wrun_01KT2SRTN41MMB6NNTV68QDB06
  • writableForwardedFromStepWorkflow | wrun_01KT2SRZ5XJ1APB25KWEQVDVVG
  • fetchWorkflow | wrun_01KT2SS38Y3EDQA66HNGNH5JW4
  • promiseRaceStressTestWorkflow | wrun_01KT2SS7N9PSTW8PZVRQ1DAR0T
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KT2SWNCX7NCK8M5SFDS0FG4D
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT2SX2XNYG96NJ6QQ98Y4SNZ
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KT2SXHYEG06K9SZHHBTNZWBW
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KT2SY1W6RGNC3XY9S6K67463
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KT2SYAYAB0JTBXR3QWKP4T78
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KT2SYGKT0Q1E1G48K3AGMZ02
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KT2SYJR3048JQACTCE71K692
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KT2SZ350ZGKC6036MTW2HG9V
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KT2SZ97YVMP4AXHFMWE1YH53
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KT2SZG2DETJQCNJX8Y22RHC4
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KT2SZPXDNK2XDX6G3FCQW6F8
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KT2SZXREZBZ8AXGB6RW3Q862
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KT2T04KB9H67QJ748WWHHGG5
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KT2T0CX0VGX1Q7A1GNC4YQ7T
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KT2T0V64P78PQ4XJRSPA7361
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KT2T14DXW5YAPH22470DNV65
  • cancelRun - cancelling a running workflow | wrun_01KT2T1CHBCR7BRTD6ZBCQZ0S1
  • cancelRun via CLI - cancelling a running workflow | wrun_01KT2T1P5NX173QZ8634JNDZVP
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KT2T22H4PBRW5KQJSJ30NYBQ
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KT2T2KDFM04D2F6VSBMC4BHS
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KT2T2Z56C7NT9EDNHWKR5ZK5
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KT2T37DPTFPBQ2344GGJKBEG
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KT2T39K7N82HKHH0CND3RQVE
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT2T3BSBWM4NBBYTYX9WNNV3

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro8307
✅ example8307
✅ express8307
✅ fastify8307
✅ hono8307
✅ nextjs-turbopack8802
✅ nextjs-webpack8802
✅ nitro8307
✅ nuxt8307
✅ sveltekit8307
✅ vite8307
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack9000
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev500
❌ mongodb57140
✅ redis-dev500
❌ redis6290
❌ turso-dev410
❌ turso3680
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8406
✅ e2e-local-dev-tanstack-start-stable8406
✅ e2e-local-postgres-nest-stable8406
✅ e2e-local-postgres-tanstack-start-stable8406
✅ e2e-local-prod-nest-stable8406
✅ e2e-local-prod-tanstack-start-stable8406

📋 View full workflow run


⚠️Community world tests failed (non-blocking):

  • Community Worlds: failure

Check the workflow run for details.

@TooTallNateTooTallNate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve — AI-resolved conflicts hold up, retry logic byte-identical to #2204

The backport bot called out that conflicts were AI-resolved, so I went through the diff carefully. The result is faithful.

Byte-identical to original

  • Changeset
  • utils.test.ts ✓ — 113 lines added, identical to main
  • Retry logic ✓ — MAX_BODY_PARSE_RETRIES = 2, BODY_PARSE_RETRY_BASE_MS = 100, the IDEMPOTENT_METHODS Set, the canRetryBody = IDEMPOTENT_METHODS.has(...) derivation, the for (let attempt = 0; ;) retry loop with exponential backoff, and the WorkflowWorldError rethrow with code: 'PARSE_ERROR' — all byte-identical to origin/main:packages/world-vercel/src/utils.ts

Stable-shape adaptations

The +183/-97 numbers in utils.ts look different from main's +297/-124 because the surrounding file shape differs:

  • Stable has getWorkflowServerUrlOverride() (used for preview workflow-server URL routing) — not on main
  • Other small shape divergence from intervening main-only refactors

Spot-checked the exports list — only the new export const MAX_BODY_PARSE_RETRIES = 2; is added; all other exports unchanged.

Correctly omits

The original PR #2204 had 3 commits:

  • 283b52e75 fix(world-vercel): retry transient response-body parse failures
  • 7bb62e9f8 fix(core): propagate exhausted transient world errors to the queue
  • 1706a5e61 Revert "fix(core): propagate exhausted transient world errors to the queue"

So the net effect on main is the world-vercel change WITHOUT the core change (the core change was added then reverted). The backport correctly only ports the world-vercel side. The bot summary noted this explicitly.

Verified locally

  • pnpm install --frozen-lockfile
  • pnpm turbo run build --filter @workflow/world-vercel
  • pnpm --filter @workflow/world-vercel test ✓ (113/113)
  • All three new retry tests pass:
    • retries an idempotent GET when the body read fails, then succeeds
    • throws PARSE_ERROR after exhausting retries for a GET
    • does NOT retry a non-idempotent POST on body-parse failure

CI

  • 85 success, 2 failures, 7 skipped
  • Failures: E2E Community World (Turso) and E2E Community World (Redis) — both pre-existing on stable's baseline (consistent across recent runs). Not caused by this PR.

Behavior summary

Sporadic PARSE_ERROR failures on idempotent reads (e.g., truncated stream body, gateway returning non-CBOR body) are now retried in-process with exponential backoff (100ms, 200ms; max 2 retries = 3 total attempts). Writes (POST/PUT/etc.) are NOT retried — replaying a write could double-apply it. Schema-validation failures remain non-retryable (retrying the same decoded payload would yield the same validation error).

Faithful backport. Approving.

@pranaygp
pranaygp merged commit 5655fcb into stableJun 2, 2026
94 of 97 checks passed
@pranaygp
pranaygp deleted the backport/pr-2204-to-stable branch June 2, 2026 02:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@TooTallNate@pranaygp
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Backport #2204: [world-vercel] Retry transient response-body parse failures in the HTTP client by github-actions[bot] · Pull Request #2207 · vercel/workflow · GitHub
Skip to content

Backport #2204: [world-vercel] Retry transient response-body parse failures in the HTTP client - #2207

Merged
pranaygp merged 2 commits into
stablefrom
backport/pr-2204-to-stable
Jun 2, 2026
Merged

Backport #2204: [world-vercel] Retry transient response-body parse failures in the HTTP client#2207
pranaygp merged 2 commits into
stablefrom
backport/pr-2204-to-stable

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated backport of #2204 to stable (backport job run).

AI recommendation: This is a self-contained bug fix in @workflow/world-vercel that retries transient response-body parse failures on idempotent requests, with accompanying tests. Both modified files exist on stable, the fix doesn't depend on any main-only APIs (the paired core change was reverted within this PR), and it addresses a real production issue (events.list PARSE_ERROR) that likely also affects stable.

Merge conflicts were resolved by AI (opencode with anthropic/claude-opus-4.7). Please review the conflict resolution carefully before merging.

…TP client (#2204)
* fix(world-vercel): retry transient response-body parse failures in the HTTP client
A sporadic failure reading/decoding a 2xx response body (truncated or
terminated stream, connection reset mid-body, or a gateway returning a
non-CBOR/JSON body) was surfaced immediately as a PARSE_ERROR. The
shared RetryAgent only retries connection/5xx failures — body
consumption happens after it returns the response, so these escape its
retry logic.
Retry such failures inside `makeRequest` with bounded exponential
backoff, scoped to idempotent methods (GET/HEAD) so writes are never
replayed. This fixes the reported `events.list` parse failure at the
adapter layer.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(core): propagate exhausted transient world errors to the queue
Pairs with the world-vercel in-adapter retry: when a response-body parse
failure survives the adapter's retries (or comes from a non-idempotent
write that is never retried in-process), it must not fail the run.
Re-throw such transient world errors from the replay loop so they
propagate to the queue handler, which replays the whole run — safe
because replay is idempotent. Schema-validation contract errors stay
fatal.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* Revert "fix(core): propagate exhausted transient world errors to the queue"
This reverts commit 7bb62e9.
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Peter Wielander <mittgfu@gmail.com>
@changeset-bot

changeset-botBot commented Jun 1, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f5700f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
NameType
@workflow/world-vercelPatch
@workflow/cliPatch
@workflow/corePatch
@workflow/webPatch
workflowPatch
@workflow/world-testingPatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actionsBot commented Jun 1, 2026

Copy link
Copy Markdown
ContributorAuthor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production923067990
✅ 💻 Local Development9940861080
✅ 📦 Local Production9940861080
✅ 🐘 Local Postgres9940861080
✅ 🪟 Windows900090
❌ 🌍 Community Worlds136920228
✅ 📋 Other504036540
Total4635923615088

❌ Failed Tests

🌍 Community Worlds (92 failed)

mongodb (14 failed):

  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT2SMYKMK32Z8J8QNHXCC9BA
  • webhookWorkflow | wrun_01KT2SN3820TWBZDR0GZTQBY6K
  • sleepingWorkflow | wrun_01KT2SN9RMSMT4AS2J1REPSEMV
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KT2SRC261BFFD30XTRGNJBQN
  • writableForwardedFromWorkflowWorkflow | wrun_01KT2SRTN41MMB6NNTV68QDB06
  • writableForwardedFromStepWorkflow | wrun_01KT2SRZ5XJ1APB25KWEQVDVVG
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT2SX2XNYG96NJ6QQ98Y4SNZ
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT2T3BSBWM4NBBYTYX9WNNV3

redis (9 failed):

  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT2SMYKMK32Z8J8QNHXCC9BA
  • sleepingWorkflow | wrun_01KT2SN9RMSMT4AS2J1REPSEMV
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT2SX2XNYG96NJ6QQ98Y4SNZ
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT2T3BSBWM4NBBYTYX9WNNV3

turso-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

turso (68 failed):

  • addTenWorkflow | wrun_01KT2SKR8TMZ1EQB2C3FSP04PB
  • addTenWorkflow | wrun_01KT2SKR8TMZ1EQB2C3FSP04PB
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KT2SNXWSH81J020A64BEB0HQ
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KT2SKZ1D3G01T0M9JAR577TS
  • promiseRaceWorkflow | wrun_01KT2SM3HESFKJZBENRHVESG4T
  • promiseAnyWorkflow | wrun_01KT2SM677CA3G665Y1PZSE3BC
  • importedStepOnlyWorkflow | wrun_01KT2SP92D5XD73ABM542G087D
  • readableStreamWorkflow | wrun_01KT2SM9KC086XRZVJ995D07QS
  • hookWorkflow | wrun_01KT2SMQ4ETAAVEW81F3E9C8S9
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT2SMYKMK32Z8J8QNHXCC9BA
  • webhookWorkflow | wrun_01KT2SN3820TWBZDR0GZTQBY6K
  • sleepingWorkflow | wrun_01KT2SN9RMSMT4AS2J1REPSEMV
  • parallelSleepWorkflow | wrun_01KT2SNSNTXAR73K6QVMVHY2SQ
  • nullByteWorkflow | wrun_01KT2SNX5GNRHMEETYR6T60KJ2
  • workflowAndStepMetadataWorkflow | wrun_01KT2SNZE08CVATMRS5HKA3354
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KT2SRC261BFFD30XTRGNJBQN
  • writableForwardedFromWorkflowWorkflow | wrun_01KT2SRTN41MMB6NNTV68QDB06
  • writableForwardedFromStepWorkflow | wrun_01KT2SRZ5XJ1APB25KWEQVDVVG
  • fetchWorkflow | wrun_01KT2SS38Y3EDQA66HNGNH5JW4
  • promiseRaceStressTestWorkflow | wrun_01KT2SS7N9PSTW8PZVRQ1DAR0T
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KT2SWNCX7NCK8M5SFDS0FG4D
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT2SX2XNYG96NJ6QQ98Y4SNZ
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KT2SXHYEG06K9SZHHBTNZWBW
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KT2SY1W6RGNC3XY9S6K67463
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KT2SYAYAB0JTBXR3QWKP4T78
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KT2SYGKT0Q1E1G48K3AGMZ02
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KT2SYJR3048JQACTCE71K692
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KT2SZ350ZGKC6036MTW2HG9V
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KT2SZ97YVMP4AXHFMWE1YH53
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KT2SZG2DETJQCNJX8Y22RHC4
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KT2SZPXDNK2XDX6G3FCQW6F8
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KT2SZXREZBZ8AXGB6RW3Q862
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KT2T04KB9H67QJ748WWHHGG5
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KT2T0CX0VGX1Q7A1GNC4YQ7T
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KT2T0V64P78PQ4XJRSPA7361
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KT2T14DXW5YAPH22470DNV65
  • cancelRun - cancelling a running workflow | wrun_01KT2T1CHBCR7BRTD6ZBCQZ0S1
  • cancelRun via CLI - cancelling a running workflow | wrun_01KT2T1P5NX173QZ8634JNDZVP
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KT2T22H4PBRW5KQJSJ30NYBQ
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KT2T2KDFM04D2F6VSBMC4BHS
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KT2T2Z56C7NT9EDNHWKR5ZK5
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KT2T37DPTFPBQ2344GGJKBEG
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KT2T39K7N82HKHH0CND3RQVE
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT2T3BSBWM4NBBYTYX9WNNV3

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro8307
✅ example8307
✅ express8307
✅ fastify8307
✅ hono8307
✅ nextjs-turbopack8802
✅ nextjs-webpack8802
✅ nitro8307
✅ nuxt8307
✅ sveltekit8307
✅ vite8307
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack9000
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev500
❌ mongodb57140
✅ redis-dev500
❌ redis6290
❌ turso-dev410
❌ turso3680
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8406
✅ e2e-local-dev-tanstack-start-stable8406
✅ e2e-local-postgres-nest-stable8406
✅ e2e-local-postgres-tanstack-start-stable8406
✅ e2e-local-prod-nest-stable8406
✅ e2e-local-prod-tanstack-start-stable8406

📋 View full workflow run


⚠️Community world tests failed (non-blocking):

  • Community Worlds: failure

Check the workflow run for details.

@TooTallNateTooTallNate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve — AI-resolved conflicts hold up, retry logic byte-identical to #2204

The backport bot called out that conflicts were AI-resolved, so I went through the diff carefully. The result is faithful.

Byte-identical to original

  • Changeset
  • utils.test.ts ✓ — 113 lines added, identical to main
  • Retry logic ✓ — MAX_BODY_PARSE_RETRIES = 2, BODY_PARSE_RETRY_BASE_MS = 100, the IDEMPOTENT_METHODS Set, the canRetryBody = IDEMPOTENT_METHODS.has(...) derivation, the for (let attempt = 0; ;) retry loop with exponential backoff, and the WorkflowWorldError rethrow with code: 'PARSE_ERROR' — all byte-identical to origin/main:packages/world-vercel/src/utils.ts

Stable-shape adaptations

The +183/-97 numbers in utils.ts look different from main's +297/-124 because the surrounding file shape differs:

  • Stable has getWorkflowServerUrlOverride() (used for preview workflow-server URL routing) — not on main
  • Other small shape divergence from intervening main-only refactors

Spot-checked the exports list — only the new export const MAX_BODY_PARSE_RETRIES = 2; is added; all other exports unchanged.

Correctly omits

The original PR #2204 had 3 commits:

  • 283b52e75 fix(world-vercel): retry transient response-body parse failures
  • 7bb62e9f8 fix(core): propagate exhausted transient world errors to the queue
  • 1706a5e61 Revert "fix(core): propagate exhausted transient world errors to the queue"

So the net effect on main is the world-vercel change WITHOUT the core change (the core change was added then reverted). The backport correctly only ports the world-vercel side. The bot summary noted this explicitly.

Verified locally

  • pnpm install --frozen-lockfile
  • pnpm turbo run build --filter @workflow/world-vercel
  • pnpm --filter @workflow/world-vercel test ✓ (113/113)
  • All three new retry tests pass:
    • retries an idempotent GET when the body read fails, then succeeds
    • throws PARSE_ERROR after exhausting retries for a GET
    • does NOT retry a non-idempotent POST on body-parse failure

CI

  • 85 success, 2 failures, 7 skipped
  • Failures: E2E Community World (Turso) and E2E Community World (Redis) — both pre-existing on stable's baseline (consistent across recent runs). Not caused by this PR.

Behavior summary

Sporadic PARSE_ERROR failures on idempotent reads (e.g., truncated stream body, gateway returning non-CBOR body) are now retried in-process with exponential backoff (100ms, 200ms; max 2 retries = 3 total attempts). Writes (POST/PUT/etc.) are NOT retried — replaying a write could double-apply it. Schema-validation failures remain non-retryable (retrying the same decoded payload would yield the same validation error).

Faithful backport. Approving.

@pranaygp
pranaygp merged commit 5655fcb into stableJun 2, 2026
94 of 97 checks passed
@pranaygp
pranaygp deleted the backport/pr-2204-to-stable branch June 2, 2026 02:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@TooTallNate@pranaygp
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Backport #2204: [world-vercel] Retry transient response-body parse failures in the HTTP client by github-actions[bot] · Pull Request #2207 · vercel/workflow · GitHub
Skip to content

Backport #2204: [world-vercel] Retry transient response-body parse failures in the HTTP client - #2207

Merged
pranaygp merged 2 commits into
stablefrom
backport/pr-2204-to-stable
Jun 2, 2026
Merged

Backport #2204: [world-vercel] Retry transient response-body parse failures in the HTTP client#2207
pranaygp merged 2 commits into
stablefrom
backport/pr-2204-to-stable

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated backport of #2204 to stable (backport job run).

AI recommendation: This is a self-contained bug fix in @workflow/world-vercel that retries transient response-body parse failures on idempotent requests, with accompanying tests. Both modified files exist on stable, the fix doesn't depend on any main-only APIs (the paired core change was reverted within this PR), and it addresses a real production issue (events.list PARSE_ERROR) that likely also affects stable.

Merge conflicts were resolved by AI (opencode with anthropic/claude-opus-4.7). Please review the conflict resolution carefully before merging.

…TP client (#2204)
* fix(world-vercel): retry transient response-body parse failures in the HTTP client
A sporadic failure reading/decoding a 2xx response body (truncated or
terminated stream, connection reset mid-body, or a gateway returning a
non-CBOR/JSON body) was surfaced immediately as a PARSE_ERROR. The
shared RetryAgent only retries connection/5xx failures — body
consumption happens after it returns the response, so these escape its
retry logic.
Retry such failures inside `makeRequest` with bounded exponential
backoff, scoped to idempotent methods (GET/HEAD) so writes are never
replayed. This fixes the reported `events.list` parse failure at the
adapter layer.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(core): propagate exhausted transient world errors to the queue
Pairs with the world-vercel in-adapter retry: when a response-body parse
failure survives the adapter's retries (or comes from a non-idempotent
write that is never retried in-process), it must not fail the run.
Re-throw such transient world errors from the replay loop so they
propagate to the queue handler, which replays the whole run — safe
because replay is idempotent. Schema-validation contract errors stay
fatal.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* Revert "fix(core): propagate exhausted transient world errors to the queue"
This reverts commit 7bb62e9.
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Peter Wielander <mittgfu@gmail.com>
@changeset-bot

changeset-botBot commented Jun 1, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f5700f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
NameType
@workflow/world-vercelPatch
@workflow/cliPatch
@workflow/corePatch
@workflow/webPatch
workflowPatch
@workflow/world-testingPatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actionsBot commented Jun 1, 2026

Copy link
Copy Markdown
ContributorAuthor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production923067990
✅ 💻 Local Development9940861080
✅ 📦 Local Production9940861080
✅ 🐘 Local Postgres9940861080
✅ 🪟 Windows900090
❌ 🌍 Community Worlds136920228
✅ 📋 Other504036540
Total4635923615088

❌ Failed Tests

🌍 Community Worlds (92 failed)

mongodb (14 failed):

  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT2SMYKMK32Z8J8QNHXCC9BA
  • webhookWorkflow | wrun_01KT2SN3820TWBZDR0GZTQBY6K
  • sleepingWorkflow | wrun_01KT2SN9RMSMT4AS2J1REPSEMV
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KT2SRC261BFFD30XTRGNJBQN
  • writableForwardedFromWorkflowWorkflow | wrun_01KT2SRTN41MMB6NNTV68QDB06
  • writableForwardedFromStepWorkflow | wrun_01KT2SRZ5XJ1APB25KWEQVDVVG
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT2SX2XNYG96NJ6QQ98Y4SNZ
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT2T3BSBWM4NBBYTYX9WNNV3

redis (9 failed):

  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT2SMYKMK32Z8J8QNHXCC9BA
  • sleepingWorkflow | wrun_01KT2SN9RMSMT4AS2J1REPSEMV
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT2SX2XNYG96NJ6QQ98Y4SNZ
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT2T3BSBWM4NBBYTYX9WNNV3

turso-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

turso (68 failed):

  • addTenWorkflow | wrun_01KT2SKR8TMZ1EQB2C3FSP04PB
  • addTenWorkflow | wrun_01KT2SKR8TMZ1EQB2C3FSP04PB
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KT2SNXWSH81J020A64BEB0HQ
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KT2SKZ1D3G01T0M9JAR577TS
  • promiseRaceWorkflow | wrun_01KT2SM3HESFKJZBENRHVESG4T
  • promiseAnyWorkflow | wrun_01KT2SM677CA3G665Y1PZSE3BC
  • importedStepOnlyWorkflow | wrun_01KT2SP92D5XD73ABM542G087D
  • readableStreamWorkflow | wrun_01KT2SM9KC086XRZVJ995D07QS
  • hookWorkflow | wrun_01KT2SMQ4ETAAVEW81F3E9C8S9
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT2SMYKMK32Z8J8QNHXCC9BA
  • webhookWorkflow | wrun_01KT2SN3820TWBZDR0GZTQBY6K
  • sleepingWorkflow | wrun_01KT2SN9RMSMT4AS2J1REPSEMV
  • parallelSleepWorkflow | wrun_01KT2SNSNTXAR73K6QVMVHY2SQ
  • nullByteWorkflow | wrun_01KT2SNX5GNRHMEETYR6T60KJ2
  • workflowAndStepMetadataWorkflow | wrun_01KT2SNZE08CVATMRS5HKA3354
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KT2SRC261BFFD30XTRGNJBQN
  • writableForwardedFromWorkflowWorkflow | wrun_01KT2SRTN41MMB6NNTV68QDB06
  • writableForwardedFromStepWorkflow | wrun_01KT2SRZ5XJ1APB25KWEQVDVVG
  • fetchWorkflow | wrun_01KT2SS38Y3EDQA66HNGNH5JW4
  • promiseRaceStressTestWorkflow | wrun_01KT2SS7N9PSTW8PZVRQ1DAR0T
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KT2SWNCX7NCK8M5SFDS0FG4D
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT2SX2XNYG96NJ6QQ98Y4SNZ
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KT2SXHYEG06K9SZHHBTNZWBW
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KT2SY1W6RGNC3XY9S6K67463
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KT2SYAYAB0JTBXR3QWKP4T78
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KT2SYGKT0Q1E1G48K3AGMZ02
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KT2SYJR3048JQACTCE71K692
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KT2SZ350ZGKC6036MTW2HG9V
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KT2SZ97YVMP4AXHFMWE1YH53
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KT2SZG2DETJQCNJX8Y22RHC4
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KT2SZPXDNK2XDX6G3FCQW6F8
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KT2SZXREZBZ8AXGB6RW3Q862
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KT2T04KB9H67QJ748WWHHGG5
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KT2T0CX0VGX1Q7A1GNC4YQ7T
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KT2T0V64P78PQ4XJRSPA7361
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KT2T14DXW5YAPH22470DNV65
  • cancelRun - cancelling a running workflow | wrun_01KT2T1CHBCR7BRTD6ZBCQZ0S1
  • cancelRun via CLI - cancelling a running workflow | wrun_01KT2T1P5NX173QZ8634JNDZVP
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KT2T22H4PBRW5KQJSJ30NYBQ
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KT2T2KDFM04D2F6VSBMC4BHS
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KT2T2Z56C7NT9EDNHWKR5ZK5
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KT2T37DPTFPBQ2344GGJKBEG
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KT2T39K7N82HKHH0CND3RQVE
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT2T3BSBWM4NBBYTYX9WNNV3

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro8307
✅ example8307
✅ express8307
✅ fastify8307
✅ hono8307
✅ nextjs-turbopack8802
✅ nextjs-webpack8802
✅ nitro8307
✅ nuxt8307
✅ sveltekit8307
✅ vite8307
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack9000
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev500
❌ mongodb57140
✅ redis-dev500
❌ redis6290
❌ turso-dev410
❌ turso3680
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8406
✅ e2e-local-dev-tanstack-start-stable8406
✅ e2e-local-postgres-nest-stable8406
✅ e2e-local-postgres-tanstack-start-stable8406
✅ e2e-local-prod-nest-stable8406
✅ e2e-local-prod-tanstack-start-stable8406

📋 View full workflow run


⚠️Community world tests failed (non-blocking):

  • Community Worlds: failure

Check the workflow run for details.

@TooTallNateTooTallNate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve — AI-resolved conflicts hold up, retry logic byte-identical to #2204

The backport bot called out that conflicts were AI-resolved, so I went through the diff carefully. The result is faithful.

Byte-identical to original

  • Changeset
  • utils.test.ts ✓ — 113 lines added, identical to main
  • Retry logic ✓ — MAX_BODY_PARSE_RETRIES = 2, BODY_PARSE_RETRY_BASE_MS = 100, the IDEMPOTENT_METHODS Set, the canRetryBody = IDEMPOTENT_METHODS.has(...) derivation, the for (let attempt = 0; ;) retry loop with exponential backoff, and the WorkflowWorldError rethrow with code: 'PARSE_ERROR' — all byte-identical to origin/main:packages/world-vercel/src/utils.ts

Stable-shape adaptations

The +183/-97 numbers in utils.ts look different from main's +297/-124 because the surrounding file shape differs:

  • Stable has getWorkflowServerUrlOverride() (used for preview workflow-server URL routing) — not on main
  • Other small shape divergence from intervening main-only refactors

Spot-checked the exports list — only the new export const MAX_BODY_PARSE_RETRIES = 2; is added; all other exports unchanged.

Correctly omits

The original PR #2204 had 3 commits:

  • 283b52e75 fix(world-vercel): retry transient response-body parse failures
  • 7bb62e9f8 fix(core): propagate exhausted transient world errors to the queue
  • 1706a5e61 Revert "fix(core): propagate exhausted transient world errors to the queue"

So the net effect on main is the world-vercel change WITHOUT the core change (the core change was added then reverted). The backport correctly only ports the world-vercel side. The bot summary noted this explicitly.

Verified locally

  • pnpm install --frozen-lockfile
  • pnpm turbo run build --filter @workflow/world-vercel
  • pnpm --filter @workflow/world-vercel test ✓ (113/113)
  • All three new retry tests pass:
    • retries an idempotent GET when the body read fails, then succeeds
    • throws PARSE_ERROR after exhausting retries for a GET
    • does NOT retry a non-idempotent POST on body-parse failure

CI

  • 85 success, 2 failures, 7 skipped
  • Failures: E2E Community World (Turso) and E2E Community World (Redis) — both pre-existing on stable's baseline (consistent across recent runs). Not caused by this PR.

Behavior summary

Sporadic PARSE_ERROR failures on idempotent reads (e.g., truncated stream body, gateway returning non-CBOR body) are now retried in-process with exponential backoff (100ms, 200ms; max 2 retries = 3 total attempts). Writes (POST/PUT/etc.) are NOT retried — replaying a write could double-apply it. Schema-validation failures remain non-retryable (retrying the same decoded payload would yield the same validation error).

Faithful backport. Approving.

@pranaygp
pranaygp merged commit 5655fcb into stableJun 2, 2026
94 of 97 checks passed
@pranaygp
pranaygp deleted the backport/pr-2204-to-stable branch June 2, 2026 02:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@TooTallNate@pranaygp
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Backport #2204: [world-vercel] Retry transient response-body parse failures in the HTTP client by github-actions[bot] · Pull Request #2207 · vercel/workflow · GitHub
Skip to content

Backport #2204: [world-vercel] Retry transient response-body parse failures in the HTTP client - #2207

Merged
pranaygp merged 2 commits into
stablefrom
backport/pr-2204-to-stable
Jun 2, 2026
Merged

Backport #2204: [world-vercel] Retry transient response-body parse failures in the HTTP client#2207
pranaygp merged 2 commits into
stablefrom
backport/pr-2204-to-stable

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated backport of #2204 to stable (backport job run).

AI recommendation: This is a self-contained bug fix in @workflow/world-vercel that retries transient response-body parse failures on idempotent requests, with accompanying tests. Both modified files exist on stable, the fix doesn't depend on any main-only APIs (the paired core change was reverted within this PR), and it addresses a real production issue (events.list PARSE_ERROR) that likely also affects stable.

Merge conflicts were resolved by AI (opencode with anthropic/claude-opus-4.7). Please review the conflict resolution carefully before merging.

…TP client (#2204)
* fix(world-vercel): retry transient response-body parse failures in the HTTP client
A sporadic failure reading/decoding a 2xx response body (truncated or
terminated stream, connection reset mid-body, or a gateway returning a
non-CBOR/JSON body) was surfaced immediately as a PARSE_ERROR. The
shared RetryAgent only retries connection/5xx failures — body
consumption happens after it returns the response, so these escape its
retry logic.
Retry such failures inside `makeRequest` with bounded exponential
backoff, scoped to idempotent methods (GET/HEAD) so writes are never
replayed. This fixes the reported `events.list` parse failure at the
adapter layer.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* fix(core): propagate exhausted transient world errors to the queue
Pairs with the world-vercel in-adapter retry: when a response-body parse
failure survives the adapter's retries (or comes from a non-idempotent
write that is never retried in-process), it must not fail the run.
Re-throw such transient world errors from the replay loop so they
propagate to the queue handler, which replays the whole run — safe
because replay is idempotent. Schema-validation contract errors stay
fatal.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* Revert "fix(core): propagate exhausted transient world errors to the queue"
This reverts commit 7bb62e9.
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Peter Wielander <mittgfu@gmail.com>
@changeset-bot

changeset-botBot commented Jun 1, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f5700f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
NameType
@workflow/world-vercelPatch
@workflow/cliPatch
@workflow/corePatch
@workflow/webPatch
workflowPatch
@workflow/world-testingPatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actionsBot commented Jun 1, 2026

Copy link
Copy Markdown
ContributorAuthor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production923067990
✅ 💻 Local Development9940861080
✅ 📦 Local Production9940861080
✅ 🐘 Local Postgres9940861080
✅ 🪟 Windows900090
❌ 🌍 Community Worlds136920228
✅ 📋 Other504036540
Total4635923615088

❌ Failed Tests

🌍 Community Worlds (92 failed)

mongodb (14 failed):

  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT2SMYKMK32Z8J8QNHXCC9BA
  • webhookWorkflow | wrun_01KT2SN3820TWBZDR0GZTQBY6K
  • sleepingWorkflow | wrun_01KT2SN9RMSMT4AS2J1REPSEMV
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KT2SRC261BFFD30XTRGNJBQN
  • writableForwardedFromWorkflowWorkflow | wrun_01KT2SRTN41MMB6NNTV68QDB06
  • writableForwardedFromStepWorkflow | wrun_01KT2SRZ5XJ1APB25KWEQVDVVG
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT2SX2XNYG96NJ6QQ98Y4SNZ
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT2T3BSBWM4NBBYTYX9WNNV3

redis (9 failed):

  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT2SMYKMK32Z8J8QNHXCC9BA
  • sleepingWorkflow | wrun_01KT2SN9RMSMT4AS2J1REPSEMV
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT2SX2XNYG96NJ6QQ98Y4SNZ
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT2T3BSBWM4NBBYTYX9WNNV3

turso-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

turso (68 failed):

  • addTenWorkflow | wrun_01KT2SKR8TMZ1EQB2C3FSP04PB
  • addTenWorkflow | wrun_01KT2SKR8TMZ1EQB2C3FSP04PB
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KT2SNXWSH81J020A64BEB0HQ
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KT2SKZ1D3G01T0M9JAR577TS
  • promiseRaceWorkflow | wrun_01KT2SM3HESFKJZBENRHVESG4T
  • promiseAnyWorkflow | wrun_01KT2SM677CA3G665Y1PZSE3BC
  • importedStepOnlyWorkflow | wrun_01KT2SP92D5XD73ABM542G087D
  • readableStreamWorkflow | wrun_01KT2SM9KC086XRZVJ995D07QS
  • hookWorkflow | wrun_01KT2SMQ4ETAAVEW81F3E9C8S9
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT2SMYKMK32Z8J8QNHXCC9BA
  • webhookWorkflow | wrun_01KT2SN3820TWBZDR0GZTQBY6K
  • sleepingWorkflow | wrun_01KT2SN9RMSMT4AS2J1REPSEMV
  • parallelSleepWorkflow | wrun_01KT2SNSNTXAR73K6QVMVHY2SQ
  • nullByteWorkflow | wrun_01KT2SNX5GNRHMEETYR6T60KJ2
  • workflowAndStepMetadataWorkflow | wrun_01KT2SNZE08CVATMRS5HKA3354
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KT2SRC261BFFD30XTRGNJBQN
  • writableForwardedFromWorkflowWorkflow | wrun_01KT2SRTN41MMB6NNTV68QDB06
  • writableForwardedFromStepWorkflow | wrun_01KT2SRZ5XJ1APB25KWEQVDVVG
  • fetchWorkflow | wrun_01KT2SS38Y3EDQA66HNGNH5JW4
  • promiseRaceStressTestWorkflow | wrun_01KT2SS7N9PSTW8PZVRQ1DAR0T
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KT2SWNCX7NCK8M5SFDS0FG4D
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT2SX2XNYG96NJ6QQ98Y4SNZ
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KT2SXHYEG06K9SZHHBTNZWBW
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KT2SY1W6RGNC3XY9S6K67463
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KT2SYAYAB0JTBXR3QWKP4T78
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KT2SYGKT0Q1E1G48K3AGMZ02
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KT2SYJR3048JQACTCE71K692
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KT2SZ350ZGKC6036MTW2HG9V
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KT2SZ97YVMP4AXHFMWE1YH53
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KT2SZG2DETJQCNJX8Y22RHC4
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KT2SZPXDNK2XDX6G3FCQW6F8
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KT2SZXREZBZ8AXGB6RW3Q862
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KT2T04KB9H67QJ748WWHHGG5
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KT2T0CX0VGX1Q7A1GNC4YQ7T
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KT2T0V64P78PQ4XJRSPA7361
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KT2T14DXW5YAPH22470DNV65
  • cancelRun - cancelling a running workflow | wrun_01KT2T1CHBCR7BRTD6ZBCQZ0S1
  • cancelRun via CLI - cancelling a running workflow | wrun_01KT2T1P5NX173QZ8634JNDZVP
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KT2T22H4PBRW5KQJSJ30NYBQ
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KT2T2KDFM04D2F6VSBMC4BHS
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KT2T2Z56C7NT9EDNHWKR5ZK5
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KT2T37DPTFPBQ2344GGJKBEG
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KT2T39K7N82HKHH0CND3RQVE
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT2T3BSBWM4NBBYTYX9WNNV3

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro8307
✅ example8307
✅ express8307
✅ fastify8307
✅ hono8307
✅ nextjs-turbopack8802
✅ nextjs-webpack8802
✅ nitro8307
✅ nuxt8307
✅ sveltekit8307
✅ vite8307
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack9000
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev500
❌ mongodb57140
✅ redis-dev500
❌ redis6290
❌ turso-dev410
❌ turso3680
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8406
✅ e2e-local-dev-tanstack-start-stable8406
✅ e2e-local-postgres-nest-stable8406
✅ e2e-local-postgres-tanstack-start-stable8406
✅ e2e-local-prod-nest-stable8406
✅ e2e-local-prod-tanstack-start-stable8406

📋 View full workflow run


⚠️Community world tests failed (non-blocking):

  • Community Worlds: failure

Check the workflow run for details.

@TooTallNateTooTallNate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve — AI-resolved conflicts hold up, retry logic byte-identical to #2204

The backport bot called out that conflicts were AI-resolved, so I went through the diff carefully. The result is faithful.

Byte-identical to original

  • Changeset
  • utils.test.ts ✓ — 113 lines added, identical to main
  • Retry logic ✓ — MAX_BODY_PARSE_RETRIES = 2, BODY_PARSE_RETRY_BASE_MS = 100, the IDEMPOTENT_METHODS Set, the canRetryBody = IDEMPOTENT_METHODS.has(...) derivation, the for (let attempt = 0; ;) retry loop with exponential backoff, and the WorkflowWorldError rethrow with code: 'PARSE_ERROR' — all byte-identical to origin/main:packages/world-vercel/src/utils.ts

Stable-shape adaptations

The +183/-97 numbers in utils.ts look different from main's +297/-124 because the surrounding file shape differs:

  • Stable has getWorkflowServerUrlOverride() (used for preview workflow-server URL routing) — not on main
  • Other small shape divergence from intervening main-only refactors

Spot-checked the exports list — only the new export const MAX_BODY_PARSE_RETRIES = 2; is added; all other exports unchanged.

Correctly omits

The original PR #2204 had 3 commits:

  • 283b52e75 fix(world-vercel): retry transient response-body parse failures
  • 7bb62e9f8 fix(core): propagate exhausted transient world errors to the queue
  • 1706a5e61 Revert "fix(core): propagate exhausted transient world errors to the queue"

So the net effect on main is the world-vercel change WITHOUT the core change (the core change was added then reverted). The backport correctly only ports the world-vercel side. The bot summary noted this explicitly.

Verified locally

  • pnpm install --frozen-lockfile
  • pnpm turbo run build --filter @workflow/world-vercel
  • pnpm --filter @workflow/world-vercel test ✓ (113/113)
  • All three new retry tests pass:
    • retries an idempotent GET when the body read fails, then succeeds
    • throws PARSE_ERROR after exhausting retries for a GET
    • does NOT retry a non-idempotent POST on body-parse failure

CI

  • 85 success, 2 failures, 7 skipped
  • Failures: E2E Community World (Turso) and E2E Community World (Redis) — both pre-existing on stable's baseline (consistent across recent runs). Not caused by this PR.

Behavior summary

Sporadic PARSE_ERROR failures on idempotent reads (e.g., truncated stream body, gateway returning non-CBOR body) are now retried in-process with exponential backoff (100ms, 200ms; max 2 retries = 3 total attempts). Writes (POST/PUT/etc.) are NOT retried — replaying a write could double-apply it. Schema-validation failures remain non-retryable (retrying the same decoded payload would yield the same validation error).

Faithful backport. Approving.

@pranaygp
pranaygp merged commit 5655fcb into stableJun 2, 2026
94 of 97 checks passed
@pranaygp
pranaygp deleted the backport/pr-2204-to-stable branch June 2, 2026 02:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@TooTallNate@pranaygp