Uh oh!
There was an error while loading. Please reload this page.
fix(core): advance workflow clock only for consumed events on main - #2211
Merged
pranaygp merged 1 commit intoJun 2, 2026
Merged
Conversation
* fix(core): advance workflow clock only for consumed events * test(core): hammer replay branch clock determinism * fix(core): address consumed event replay review feedback * test(core): bound replay regression concurrency (cherry picked from commit 1e32d05)
🦋 Changeset detectedLatest commit: a5d1915 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) workflow with 25 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro workflow with 50 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro Promise.all with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro Promise.race with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro workflow with 10 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) workflow with 25 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) workflow with 50 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro workflow with 10 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) workflow with 25 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) workflow with 50 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) Stream Benchmarks(includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro stream pipeline with 5 transform steps (1MB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro 10 parallel streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) fan-out fan-in 10 streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
❌ Some benchmark jobs failed:
Check the workflow run for details. |
Contributor
🧪 E2E Test Results✅ All tests passed Summary
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
✅ 📋 Other
|
Contributor
There was a problem hiding this comment.
Pull request overview
Forward-ports the fix from #2206 (merged to stable) onto main: workflow deterministic clock advancement is moved from a passive event-log subscriber to EventsConsumer.onConsumedEvent, so the clock only advances after events are actually consumed (not merely inspected). Adds regression tests and a changeset.
Changes:
- Add
onConsumedEventhook toEventsConsumer, invoked after a consumer returnsConsumed/Finished, with try/catch around callback errors. - Replace passive subscriber in
runWorkflowwithonConsumedEvent-drivenupdateTimestamp. - Add a 200-replay regression test ensuring the workflow does not look ahead at future event timestamps via
Date.now(), plus an EventsConsumer test that callback errors don't halt processing; update existing timestamp expectations.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/workflow.ts | Use onConsumedEvent for clock updates; drop passive subscriber. |
| packages/core/src/events-consumer.ts | Add onConsumedEvent option, invoke it on successful consumption with error guard. |
| packages/core/src/workflow.test.ts | Update timestamp expectations and add 200-replay regression test. |
| packages/core/src/events-consumer.test.ts | Add test that onConsumedEvent errors don't halt processing. |
| .changeset/replay-consumed-event-clock.md | Patch changeset for @workflow/core. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
VaguelySerious
approved these changes
Jun 2, 2026
Uh oh!
There was an error while loading. Please reload this page.
pranaygp
deleted the
pranaygp/codex/forward-port-replay-consumed-event-clock
branch
June 2, 2026 06:49
Contributor
No backport to This commit is itself a forward-port to To override, re-run the Backport to stable workflow manually via |
This was referenced Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forward-port the consumed-event workflow clock fix that shipped to
stablein #2206 ontomain.EventsConsumer.onConsumedEventContext
#2206 was merged directly to
stablewhile investigating corrupted event logs from hook/sleep replay races.mainstill had the passive timestamp subscriber shape, so it needs the same fix to keep the runtime lines aligned.Stable merge: #2206 (
1e32d05758d590134f04f82ea41ab9add96104d5)Validation
corepack pnpm exec turbo run build --filter='@workflow/core...'corepack pnpm --filter @workflow/core typecheckcorepack pnpm --filter @workflow/core exec vitest run src/events-consumer.test.ts src/workflow.test.ts(99 tests passed)