Uh oh!
There was an error while loading. Please reload this page.
Retry replay divergence before failing event logs - #2212
Merged
Conversation
(cherry picked from commit 813cd9a)
Contributor
🦋 Changeset detectedLatest commit: 326c11b The changes in this PR will be included in the next version bump. This PR includes changesets to release 21 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro workflow with 25 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express workflow with 50 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro Promise.all with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.race with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 10 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express workflow with 25 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 50 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 10 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express workflow with 25 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 50 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Stream Benchmarks(includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express stream pipeline with 5 transform steps (1MB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) 10 parallel streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) fan-out fan-in 10 streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
Contributor
🧪 E2E Test Results✅ All tests passed Summary
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
✅ 📋 Other
|
pranaygp
marked this pull request as ready for review
June 2, 2026 02:12
pranaygp
enabled auto-merge (squash)
June 2, 2026 02:13
Contributor
There was a problem hiding this comment.
Pull request overview
This PR forward-ports the “replay divergence recovery” behavior into main by introducing a retryable replay-divergence signal and using it to queue bounded recovery replays before a run is marked as having a corrupted event log.
Changes:
- Add
ReplayDivergenceError/REPLAY_DIVERGENCEclassification and propagate divergence state through the workflow invoke payload. - Update sleep/hook/step replay guards to emit
ReplayDivergenceError(instead of immediately failing asCORRUPTED_EVENT_LOG). - Integrate bounded recovery replay redrives in the combined workflow runtime handler, plus docs + changeset.
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/world/src/queue.ts | Extends workflow invoke payload schema with replayDivergence recovery metadata. |
| packages/errors/src/index.ts | Adds ReplayDivergenceError and an ERROR_SLUGS entry for documentation linking. |
| packages/errors/src/error-codes.ts | Introduces RUN_ERROR_CODES.REPLAY_DIVERGENCE. |
| packages/errors/src/replay-divergence-error.test.ts | Adds unit test for the new error type/behavior. |
| packages/core/src/workflow/sleep.ts | Emits ReplayDivergenceError for wait/sleep replay mismatches. |
| packages/core/src/workflow/sleep.test.ts | Updates assertions/messages to expect replay divergence instead of corrupted logs. |
| packages/core/src/workflow/hook.ts | Emits ReplayDivergenceError for hook replay mismatches. |
| packages/core/src/workflow/hook.test.ts | Updates assertions/messages to expect replay divergence instead of corrupted logs. |
| packages/core/src/step.ts | Emits ReplayDivergenceError for step replay mismatches. |
| packages/core/src/step.test.ts | Updates assertions/messages to expect replay divergence instead of corrupted logs. |
| packages/core/src/workflow.ts | Treats replay divergence as a control-flow signal to be handled by the runtime. |
| packages/core/src/workflow.test.ts | Updates error message expectations for unconsumed events. |
| packages/core/src/runtime/constants.ts | Adds REPLAY_DIVERGENCE_MAX_RETRIES. |
| packages/core/src/runtime.ts | Queues bounded recovery replays for replay divergence and only fails as corrupted after budget exhaustion. |
| packages/core/src/runtime.test.ts | Adds coverage for recovery replay behavior and terminal corruption after budget exhaustion. |
| packages/core/src/classify-error.ts | Maps ReplayDivergenceError to RUN_ERROR_CODES.REPLAY_DIVERGENCE. |
| packages/core/src/classify-error.test.ts | Adds classification test for REPLAY_DIVERGENCE. |
| docs/content/docs/v5/errors/replay-divergence.mdx | Documents replay divergence and automatic recovery behavior. |
| docs/content/docs/v5/errors/index.mdx | Adds the replay-divergence card to the error docs index. |
| docs/content/docs/v5/errors/corrupted-event-log.mdx | Updates corrupted-event-log docs to reflect the new recovery-first behavior. |
| .changeset/replay-divergence-redelivery.md | Publishes patch bumps for core/errors/world for the new behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
pranaygp
commented
Jun 2, 2026
ContributorAuthor
Addressed the Vercel Agent abort-hook suggestion in |
pranaygp
commented
Jun 2, 2026
ContributorAuthor
Added the |
VaguelySerious
approved these changes
Jun 2, 2026
Uh oh!
There was an error while loading. Please reload this page.
Contributor
No backport to This commit is explicitly a forward-port of #2208 from To override, re-run the Backport to stable workflow manually via |
This was referenced Jun 2, 2026
TooTallNate added a commit
that referenced
this pull request
Jun 3, 2026
…(diagnostic) We are not observing any failed runs in CI even after many retries, which means the REPLAY_DIVERGENCE recovery-replay redrive (#2208/#2212) is masking real divergences: a subsequent redrive happens to read a consistent snapshot and succeeds, so we lose the signal needed to understand why the log diverged. Remove the recovery-replay redrive so the first ReplayDivergenceError fails the run as a terminal CORRUPTED_EVENT_LOG. Combined with the per-replay event log logging, this makes every divergence immediately visible and lets us capture the exact diverging event log for investigation. This is intentionally aggressive for diagnosis; the recovery budget (REPLAY_DIVERGENCE_MAX_RETRIES) is left defined and can be reinstated once the root cause is understood. Updates the two runtime tests that asserted the redrive behavior to assert immediate failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stabletomain.REPLAY_DIVERGENCE, redrives up to three recovery replays, and only persistsCORRUPTED_EVENT_LOGafter that recovery budget is exhausted.main's combined workflow handler and retains its newer error serialization/runtime behavior.Validation
pnpm --filter '@workflow/core...' build(Nodev22.18.0)pnpm --filter @workflow/core test(1084 passing)pnpm --filter @workflow/errors test(37 passing)pnpm exec biome format $(git diff --name-only origin-https/main...HEAD -- packages | rg '\.ts$')git diff --check origin-https/main...HEADNote
pnpm lintcurrently reports existing repository-wide diagnostics outside this port, including.githubscripts, generateddocs/.sourcefiles, and pre-existing lint findings in touched source files. The changed TypeScript files pass the formatter check above.