[codex] Skip replay for terminal run events - #2214

Merged
pranaygp merged 2 commits into
stablefrom
pranaygp/codex/fix-run-failed-replay
Jun 2, 2026
Merged

[codex] Skip replay for terminal run events#2214
pranaygp merged 2 commits into
stablefrom
pranaygp/codex/fix-run-failed-replay

Conversation

@pranaygp

@pranaygppranaygp commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Skip workflow replay when the loaded event snapshot already contains a terminal run event (run_failed, run_cancelled, or run_completed).
  • Recheck for a terminal event after refreshing history following elapsed wait completion.
  • Add regression coverage for a running materialized run whose event log already records run_failed, plus a patch changeset for @workflow/core.

Root Cause

A replay invocation can observe a materialized run as running while its loaded event snapshot already contains run_failed. The runtime previously proceeded into runWorkflow(), where EventsConsumer had no consumer for that terminal event and reported it as REPLAY_DIVERGENCE, queueing recovery replays for an already-failed run.

Validation

  • pnpm --filter '@workflow/core...' build
  • pnpm changeset status --since=origin/stable
  • pnpm --dir packages/core exec vitest run src/runtime.test.ts src/runtime/wait-completion-replay.test.ts (11 passed)
  • git diff --check
  • pnpm exec biome check packages/core/src/runtime.ts packages/core/src/runtime.test.ts completed with the pre-existing cognitive-complexity warnings in packages/core/src/runtime.ts.

Additional Test Note

pnpm --dir packages/core test fails outside this diff in the untouched src/serialization.test.ts: seven DOMException serialization tests fail with DevalueError: Cannot stringify arbitrary non-POJOs.

@changeset-bot

changeset-botBot commented Jun 2, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a7f337b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
NameType
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
workflowPatch
@workflow/world-testingPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 2, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, CommentJun 2, 2026 4:00am
example-nextjs-workflow-webpackReadyReadyPreview, CommentJun 2, 2026 4:00am
example-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-astro-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-express-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-fastify-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-hono-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-nitro-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-nuxt-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-sveltekit-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-tanstack-start-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-vite-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workflow-swc-playgroundReadyReadyPreview, CommentJun 2, 2026 4:00am
workflow-tarballsReadyReadyPreview, CommentJun 2, 2026 4:00am
workflow-webReadyReadyPreview, CommentJun 2, 2026 4:00am
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
workflow-docsSkippedSkippedJun 2, 2026 4:00am

@github-actions

github-actionsBot commented Jun 2, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

❌ Some tests failed

Summary

PassedFailedSkippedTotal
❌ ▲ Vercel Production922167990
✅ 💻 Local Development9940861080
✅ 📦 Local Production9940861080
✅ 🐘 Local Postgres9940861080
✅ 🪟 Windows900090
❌ 🌍 Community Worlds136920228
✅ 📋 Other504036540
Total4634933615088

❌ Failed Tests

▲ Vercel Production (1 failed)

astro (1 failed):

🌍 Community Worlds (92 failed)

mongodb (14 failed):

  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT37QKQQYVH3ADGWF0SVY1Y0
  • webhookWorkflow | wrun_01KT37QQYQT0YVNCYB23062G69
  • sleepingWorkflow | wrun_01KT37QYC80W3TM2CSHJVJWCJA
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KT37TZ14PVKGQSM4FJYKMZNA
  • writableForwardedFromWorkflowWorkflow | wrun_01KT37VCAAA2QF96BE5EHK2KNP
  • writableForwardedFromStepWorkflow | wrun_01KT37VGS6CSA06P809DJXCA6A
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT37ZT2C25MF5XS7TH8NWTN1
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT3862DTG9DVYKE6QB58T60T

redis (9 failed):

  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT37QKQQYVH3ADGWF0SVY1Y0
  • sleepingWorkflow | wrun_01KT37QYC80W3TM2CSHJVJWCJA
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT37ZT2C25MF5XS7TH8NWTN1
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT3862DTG9DVYKE6QB58T60T

turso-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

turso (68 failed):

  • addTenWorkflow | wrun_01KT37PDX08NJK6TWZ7V9VEYMT
  • addTenWorkflow | wrun_01KT37PDX08NJK6TWZ7V9VEYMT
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KT37R1M73KQ4GH2EQV52Y0VG
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KT37PQ0E1MKJXTZ8QZ3WA007
  • promiseRaceWorkflow | wrun_01KT37PVJM5RNCCM1BGKYG4M96
  • promiseAnyWorkflow | wrun_01KT37PXX1V9TX0NGTKVCBH8SH
  • importedStepOnlyWorkflow | wrun_01KT37REF4YCP684J5PDMGY4HB
  • readableStreamWorkflow | wrun_01KT37Q03TQ46AN44PZYB4PR0B
  • hookWorkflow | wrun_01KT37QCAK29DQ3K7CJS93RMQT
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT37QKQQYVH3ADGWF0SVY1Y0
  • webhookWorkflow | wrun_01KT37QQYQT0YVNCYB23062G69
  • sleepingWorkflow | wrun_01KT37QYC80W3TM2CSHJVJWCJA
  • parallelSleepWorkflow | wrun_01KT37RE0T944TEDMS63JB3WSM
  • nullByteWorkflow | wrun_01KT37RHZDEEC3V5QQNM82CET8
  • workflowAndStepMetadataWorkflow | wrun_01KT37RM497MBVPF5DFDQY15GD
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KT37TZ14PVKGQSM4FJYKMZNA
  • writableForwardedFromWorkflowWorkflow | wrun_01KT37VCAAA2QF96BE5EHK2KNP
  • writableForwardedFromStepWorkflow | wrun_01KT37VGS6CSA06P809DJXCA6A
  • fetchWorkflow | wrun_01KT37VMBRMXD5NTHK0G62976Y
  • promiseRaceStressTestWorkflow | wrun_01KT37VQQ100HMJ9G6VKWWY30W
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KT37ZCC9SFWTFE3GT3GHGG9P
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT37ZT2C25MF5XS7TH8NWTN1
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KT380ASA3B3YH71ESE7TKF21
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KT380TY73PJMFK2WB6SW20X4
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KT38144AMRX81ZR28BBWJR0A
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KT381A641STKB0JT9M30515M
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KT381CE10BY0GYWMH6ZSQMD4
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KT381W5TMHRFYMW4HDY93DTH
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KT382217A0KW15CW0N89WC69
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KT3828YN7A2NQJ0YAR7FZHEE
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KT382FR63GR5CANAHP9PN960
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KT382NRBN5DBT2QKZSQH0BBF
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KT382WN12GNEMMBDDJVFZF8C
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KT3835D2E9F05FM67Q92Z38Z
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KT383KBG3791HGSWZVRKDAY4
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KT383WTM4P8NBRAJARACVW18
  • cancelRun - cancelling a running workflow | wrun_01KT3843SJMHCHXBP5AR25DM6P
  • cancelRun via CLI - cancelling a running workflow | wrun_01KT384D86RHR9BPTHH3NEAJA3
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KT384T8YZ0MRAW0FKFMRBPAN
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KT385AJ5XD3DG0XKCVNWM4CF
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KT385PSCFQK619TGT1DGV14F
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KT385XSF6SKPDJ5QEYBPM4K4
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KT386070DXTEBKMMKEF3CDXP
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT3862DTG9DVYKE6QB58T60T

Details by Category

❌ ▲ Vercel Production
AppPassedFailedSkipped
❌ astro8217
✅ example8307
✅ express8307
✅ fastify8307
✅ hono8307
✅ nextjs-turbopack8802
✅ nextjs-webpack8802
✅ nitro8307
✅ nuxt8307
✅ sveltekit8307
✅ vite8307
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack9000
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev500
❌ mongodb57140
✅ redis-dev500
❌ redis6290
❌ turso-dev410
❌ turso3680
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8406
✅ e2e-local-dev-tanstack-start-stable8406
✅ e2e-local-postgres-nest-stable8406
✅ e2e-local-postgres-tanstack-start-stable8406
✅ e2e-local-prod-nest-stable8406
✅ e2e-local-prod-tanstack-start-stable8406

📋 View full workflow run

❌ Some E2E test jobs failed:

  • Vercel Prod: failure
  • Local Dev: success
  • Local Prod: success
  • Local Postgres: success
  • Windows: success

Check the workflow run for details.

⚠️Community world tests failed (non-blocking):

  • Community Worlds: failure

Check the workflow run for details.

@pranaygp
pranaygp marked this pull request as ready for review June 2, 2026 03:13
@pranaygp
pranaygp requested a review from a team as a code ownerJune 2, 2026 03:13
CopilotAI review requested due to automatic review settings June 2, 2026 03:13
CopilotAI reviewed Jun 2, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR hardens the workflow runtime replay path by detecting terminal run events already present in the loaded event snapshot, preventing unnecessary (and potentially divergent) replays for runs whose outcome is already durably recorded.

Changes:

  • Add a replay guard that skips runWorkflow() when the loaded snapshot already contains a terminal run event (run_failed, run_cancelled, run_completed).
  • Re-check for terminal events after committing elapsed waits and refreshing the event snapshot.
  • Add a regression test for a running materialized run whose preloaded snapshot already includes run_failed, plus a patch changeset for @workflow/core.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

FileDescription
packages/core/src/runtime.tsAdds terminal-event detection to short-circuit replay both on initial snapshot load and after wait-completion refresh.
packages/core/src/runtime.test.tsAdds regression coverage to ensure runs with terminal events in the snapshot do not replay or queue recovery replays.
.changeset/terminal-run-event-replay.mdPublishes a patch changeset documenting the replay-skip behavior change for @workflow/core.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadpackages/core/src/runtime.ts
Comment threadpackages/core/src/runtime.test.ts
Comment threadpackages/core/src/runtime.ts
@pranaygppranaygp mentioned this pull request Jun 2, 2026
Merged
@vercel
vercelBottemporarily deployed to Preview – workflow-docs June 2, 2026 03:56 Inactive
@VaguelySerious

VaguelySerious commented Jun 2, 2026

Copy link
Copy Markdown
Member

Let's not forget to forward-port too

@pranaygp
pranaygp merged commit e959124 into stableJun 2, 2026
91 of 97 checks passed
@pranaygp
pranaygp deleted the pranaygp/codex/fix-run-failed-replay branch June 2, 2026 17:26
@pranaygp

pranaygp commented Jun 2, 2026

Copy link
Copy Markdown
ContributorAuthor

forward ported in #2215

@github-actionsgithub-actionsBot mentioned this pull request Jun 2, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@VaguelySeriousVaguelySeriousVaguelySerious approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pranaygp@VaguelySerious
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[codex] Skip replay for terminal run events - #2214
Merged
pranaygp merged 2 commits into
stablefrom 
pranaygp/codex/fix-run-failed-replay
Jun 2, 2026
Merged
[codex] Skip replay for terminal run events#2214
pranaygp merged 2 commits into
stablefrom 
pranaygp/codex/fix-run-failed-replay
Conversation
@pranaygp
@pranaygppranaygp
commented
Jun 2, 2026

Copy link


Copy Markdown

Contributor
Summary
  • Skip workflow replay when the loaded event snapshot already contains a terminal run event (run_failed, run_cancelled, or run_completed).
  • Recheck for a terminal event after refreshing history following elapsed wait completion.
  • Add regression coverage for a running materialized run whose event log already records run_failed, plus a patch changeset for @workflow/core.
Root Cause
A replay invocation can observe a materialized run as running while its loaded event snapshot already contains run_failed. The runtime previously proceeded into runWorkflow(), where EventsConsumer had no consumer for that terminal event and reported it as REPLAY_DIVERGENCE, queueing recovery replays for an already-failed run.
Validation
  • pnpm --filter '@workflow/core...' build
  • pnpm changeset status --since=origin/stable
  • pnpm --dir packages/core exec vitest run src/runtime.test.ts src/runtime/wait-completion-replay.test.ts (11 passed)
  • git diff --check
  • pnpm exec biome check packages/core/src/runtime.ts packages/core/src/runtime.test.ts completed with the pre-existing cognitive-complexity warnings in packages/core/src/runtime.ts.
Additional Test Note
pnpm --dir packages/core test fails outside this diff in the untouched src/serialization.test.ts: seven DOMException serialization tests fail with DevalueError: Cannot stringify arbitrary non-POJOs.
@changeset-bot
changeset-botBot
commented
Jun 2, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: a7f337b
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
workflowPatch
@workflow/world-testingPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 2, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, CommentJun 2, 2026 4:00am
example-nextjs-workflow-webpackReadyReadyPreview, CommentJun 2, 2026 4:00am
example-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-astro-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-express-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-fastify-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-hono-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-nitro-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-nuxt-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-sveltekit-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-tanstack-start-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-vite-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workflow-swc-playgroundReadyReadyPreview, CommentJun 2, 2026 4:00am
workflow-tarballsReadyReadyPreview, CommentJun 2, 2026 4:00am
workflow-webReadyReadyPreview, CommentJun 2, 2026 4:00am
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
workflow-docsSkippedSkippedJun 2, 2026 4:00am
@github-actions
github-actionsBot
commented
Jun 2, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
🧪 E2E Test Results
❌ Some tests failed
Summary
PassedFailedSkippedTotal
❌ ▲ Vercel Production922167990
✅ 💻 Local Development9940861080
✅ 📦 Local Production9940861080
✅ 🐘 Local Postgres9940861080
✅ 🪟 Windows900090
❌ 🌍 Community Worlds136920228
✅ 📋 Other504036540
Total4634933615088
❌ Failed Tests
▲ Vercel Production (1 failed)
astro (1 failed):
🌍 Community Worlds (92 failed)
mongodb (14 failed):
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT37QKQQYVH3ADGWF0SVY1Y0
  • webhookWorkflow | wrun_01KT37QQYQT0YVNCYB23062G69
  • sleepingWorkflow | wrun_01KT37QYC80W3TM2CSHJVJWCJA
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KT37TZ14PVKGQSM4FJYKMZNA
  • writableForwardedFromWorkflowWorkflow | wrun_01KT37VCAAA2QF96BE5EHK2KNP
  • writableForwardedFromStepWorkflow | wrun_01KT37VGS6CSA06P809DJXCA6A
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT37ZT2C25MF5XS7TH8NWTN1
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT3862DTG9DVYKE6QB58T60T
redis (9 failed):
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT37QKQQYVH3ADGWF0SVY1Y0
  • sleepingWorkflow | wrun_01KT37QYC80W3TM2CSHJVJWCJA
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT37ZT2C25MF5XS7TH8NWTN1
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT3862DTG9DVYKE6QB58T60T
turso-dev (1 failed):
  • dev e2e should rebuild on imported step dependency change
turso (68 failed):
  • addTenWorkflow | wrun_01KT37PDX08NJK6TWZ7V9VEYMT
  • addTenWorkflow | wrun_01KT37PDX08NJK6TWZ7V9VEYMT
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KT37R1M73KQ4GH2EQV52Y0VG
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KT37PQ0E1MKJXTZ8QZ3WA007
  • promiseRaceWorkflow | wrun_01KT37PVJM5RNCCM1BGKYG4M96
  • promiseAnyWorkflow | wrun_01KT37PXX1V9TX0NGTKVCBH8SH
  • importedStepOnlyWorkflow | wrun_01KT37REF4YCP684J5PDMGY4HB
  • readableStreamWorkflow | wrun_01KT37Q03TQ46AN44PZYB4PR0B
  • hookWorkflow | wrun_01KT37QCAK29DQ3K7CJS93RMQT
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT37QKQQYVH3ADGWF0SVY1Y0
  • webhookWorkflow | wrun_01KT37QQYQT0YVNCYB23062G69
  • sleepingWorkflow | wrun_01KT37QYC80W3TM2CSHJVJWCJA
  • parallelSleepWorkflow | wrun_01KT37RE0T944TEDMS63JB3WSM
  • nullByteWorkflow | wrun_01KT37RHZDEEC3V5QQNM82CET8
  • workflowAndStepMetadataWorkflow | wrun_01KT37RM497MBVPF5DFDQY15GD
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KT37TZ14PVKGQSM4FJYKMZNA
  • writableForwardedFromWorkflowWorkflow | wrun_01KT37VCAAA2QF96BE5EHK2KNP
  • writableForwardedFromStepWorkflow | wrun_01KT37VGS6CSA06P809DJXCA6A
  • fetchWorkflow | wrun_01KT37VMBRMXD5NTHK0G62976Y
  • promiseRaceStressTestWorkflow | wrun_01KT37VQQ100HMJ9G6VKWWY30W
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KT37ZCC9SFWTFE3GT3GHGG9P
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT37ZT2C25MF5XS7TH8NWTN1
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KT380ASA3B3YH71ESE7TKF21
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KT380TY73PJMFK2WB6SW20X4
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KT38144AMRX81ZR28BBWJR0A
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KT381A641STKB0JT9M30515M
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KT381CE10BY0GYWMH6ZSQMD4
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KT381W5TMHRFYMW4HDY93DTH
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KT382217A0KW15CW0N89WC69
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KT3828YN7A2NQJ0YAR7FZHEE
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KT382FR63GR5CANAHP9PN960
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KT382NRBN5DBT2QKZSQH0BBF
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KT382WN12GNEMMBDDJVFZF8C
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KT3835D2E9F05FM67Q92Z38Z
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KT383KBG3791HGSWZVRKDAY4
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KT383WTM4P8NBRAJARACVW18
  • cancelRun - cancelling a running workflow | wrun_01KT3843SJMHCHXBP5AR25DM6P
  • cancelRun via CLI - cancelling a running workflow | wrun_01KT384D86RHR9BPTHH3NEAJA3
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KT384T8YZ0MRAW0FKFMRBPAN
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KT385AJ5XD3DG0XKCVNWM4CF
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KT385PSCFQK619TGT1DGV14F
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KT385XSF6SKPDJ5QEYBPM4K4
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KT386070DXTEBKMMKEF3CDXP
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT3862DTG9DVYKE6QB58T60T
Details by Category
❌ ▲ Vercel Production
AppPassedFailedSkipped
❌ astro8217
✅ example8307
✅ express8307
✅ fastify8307
✅ hono8307
✅ nextjs-turbopack8802
✅ nextjs-webpack8802
✅ nitro8307
✅ nuxt8307
✅ sveltekit8307
✅ vite8307
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack9000
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev500
❌ mongodb57140
✅ redis-dev500
❌ redis6290
❌ turso-dev410
❌ turso3680
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8406
✅ e2e-local-dev-tanstack-start-stable8406
✅ e2e-local-postgres-nest-stable8406
✅ e2e-local-postgres-tanstack-start-stable8406
✅ e2e-local-prod-nest-stable8406
✅ e2e-local-prod-tanstack-start-stable8406
📋 View full workflow run
❌ Some E2E test jobs failed:
  • Vercel Prod: failure
  • Local Dev: success
  • Local Prod: success
  • Local Postgres: success
  • Windows: success
Check the workflow run for details.
⚠️Community world tests failed (non-blocking):
  • Community Worlds: failure
Check the workflow run for details.
@pranaygp
pranaygp
marked this pull request as ready for review
June 2, 2026 03:13
@pranaygp
pranaygp
requested a review
from a team
as a code ownerJune 2, 2026 03:13
CopilotAI
review requested due to automatic review settings
June 2, 2026 03:13
CopilotAI
reviewed
Jun 2, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR hardens the workflow runtime replay path by detecting terminal run events already present in the loaded event snapshot, preventing unnecessary (and potentially divergent) replays for runs whose outcome is already durably recorded.
Changes:
  • Add a replay guard that skips runWorkflow() when the loaded snapshot already contains a terminal run event (run_failed, run_cancelled, run_completed).
  • Re-check for terminal events after committing elapsed waits and refreshing the event snapshot.
  • Add a regression test for a running materialized run whose preloaded snapshot already includes run_failed, plus a patch changeset for @workflow/core.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
FileDescription
packages/core/src/runtime.tsAdds terminal-event detection to short-circuit replay both on initial snapshot load and after wait-completion refresh.
packages/core/src/runtime.test.tsAdds regression coverage to ensure runs with terminal events in the snapshot do not replay or queue recovery replays.
.changeset/terminal-run-event-replay.mdPublishes a patch changeset documenting the replay-skip behavior change for @workflow/core.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment threadpackages/core/src/runtime.ts
Comment threadpackages/core/src/runtime.test.ts
Comment threadpackages/core/src/runtime.ts
@pranaygppranaygp
mentioned this pull request
Jun 2, 2026
 Merged

@vercel
vercelBottemporarily deployed
to
Preview – workflow-docs
June 2, 2026 03:56
Inactive

@VaguelySerious
VaguelySerious
commented
Jun 2, 2026

Copy link


Copy Markdown

Member
Let's not forget to forward-port too
@pranaygp
pranaygp
merged commit e959124
into
stableJun 2, 2026

91 of 97 checks passed

@pranaygp
pranaygp
deleted the

pranaygp/codex/fix-run-failed-replay

branch
June 2, 2026 17:26
@pranaygp
pranaygp
commented
Jun 2, 2026

Copy link


Copy Markdown

ContributorAuthor
forward ported in #2215
@github-actionsgithub-actionsBot
mentioned this pull request
Jun 2, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@VaguelySeriousVaguelySeriousVaguelySerious approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@pranaygp@VaguelySerious

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[codex] Skip replay for terminal run events - #2214
Merged
pranaygp merged 2 commits into
stablefrom 
pranaygp/codex/fix-run-failed-replay
Jun 2, 2026
Merged
[codex] Skip replay for terminal run events#2214
pranaygp merged 2 commits into
stablefrom 
pranaygp/codex/fix-run-failed-replay
Conversation
@pranaygp
@pranaygppranaygp
commented
Jun 2, 2026

Copy link


Copy Markdown

Contributor
Summary
  • Skip workflow replay when the loaded event snapshot already contains a terminal run event (run_failed, run_cancelled, or run_completed).
  • Recheck for a terminal event after refreshing history following elapsed wait completion.
  • Add regression coverage for a running materialized run whose event log already records run_failed, plus a patch changeset for @workflow/core.
Root Cause
A replay invocation can observe a materialized run as running while its loaded event snapshot already contains run_failed. The runtime previously proceeded into runWorkflow(), where EventsConsumer had no consumer for that terminal event and reported it as REPLAY_DIVERGENCE, queueing recovery replays for an already-failed run.
Validation
  • pnpm --filter '@workflow/core...' build
  • pnpm changeset status --since=origin/stable
  • pnpm --dir packages/core exec vitest run src/runtime.test.ts src/runtime/wait-completion-replay.test.ts (11 passed)
  • git diff --check
  • pnpm exec biome check packages/core/src/runtime.ts packages/core/src/runtime.test.ts completed with the pre-existing cognitive-complexity warnings in packages/core/src/runtime.ts.
Additional Test Note
pnpm --dir packages/core test fails outside this diff in the untouched src/serialization.test.ts: seven DOMException serialization tests fail with DevalueError: Cannot stringify arbitrary non-POJOs.
@changeset-bot
changeset-botBot
commented
Jun 2, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: a7f337b
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
workflowPatch
@workflow/world-testingPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 2, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, CommentJun 2, 2026 4:00am
example-nextjs-workflow-webpackReadyReadyPreview, CommentJun 2, 2026 4:00am
example-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-astro-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-express-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-fastify-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-hono-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-nitro-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-nuxt-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-sveltekit-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-tanstack-start-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-vite-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workflow-swc-playgroundReadyReadyPreview, CommentJun 2, 2026 4:00am
workflow-tarballsReadyReadyPreview, CommentJun 2, 2026 4:00am
workflow-webReadyReadyPreview, CommentJun 2, 2026 4:00am
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
workflow-docsSkippedSkippedJun 2, 2026 4:00am
@github-actions
github-actionsBot
commented
Jun 2, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
🧪 E2E Test Results
❌ Some tests failed
Summary
PassedFailedSkippedTotal
❌ ▲ Vercel Production922167990
✅ 💻 Local Development9940861080
✅ 📦 Local Production9940861080
✅ 🐘 Local Postgres9940861080
✅ 🪟 Windows900090
❌ 🌍 Community Worlds136920228
✅ 📋 Other504036540
Total4634933615088
❌ Failed Tests
▲ Vercel Production (1 failed)
astro (1 failed):
🌍 Community Worlds (92 failed)
mongodb (14 failed):
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT37QKQQYVH3ADGWF0SVY1Y0
  • webhookWorkflow | wrun_01KT37QQYQT0YVNCYB23062G69
  • sleepingWorkflow | wrun_01KT37QYC80W3TM2CSHJVJWCJA
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KT37TZ14PVKGQSM4FJYKMZNA
  • writableForwardedFromWorkflowWorkflow | wrun_01KT37VCAAA2QF96BE5EHK2KNP
  • writableForwardedFromStepWorkflow | wrun_01KT37VGS6CSA06P809DJXCA6A
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT37ZT2C25MF5XS7TH8NWTN1
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT3862DTG9DVYKE6QB58T60T
redis (9 failed):
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT37QKQQYVH3ADGWF0SVY1Y0
  • sleepingWorkflow | wrun_01KT37QYC80W3TM2CSHJVJWCJA
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT37ZT2C25MF5XS7TH8NWTN1
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT3862DTG9DVYKE6QB58T60T
turso-dev (1 failed):
  • dev e2e should rebuild on imported step dependency change
turso (68 failed):
  • addTenWorkflow | wrun_01KT37PDX08NJK6TWZ7V9VEYMT
  • addTenWorkflow | wrun_01KT37PDX08NJK6TWZ7V9VEYMT
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KT37R1M73KQ4GH2EQV52Y0VG
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KT37PQ0E1MKJXTZ8QZ3WA007
  • promiseRaceWorkflow | wrun_01KT37PVJM5RNCCM1BGKYG4M96
  • promiseAnyWorkflow | wrun_01KT37PXX1V9TX0NGTKVCBH8SH
  • importedStepOnlyWorkflow | wrun_01KT37REF4YCP684J5PDMGY4HB
  • readableStreamWorkflow | wrun_01KT37Q03TQ46AN44PZYB4PR0B
  • hookWorkflow | wrun_01KT37QCAK29DQ3K7CJS93RMQT
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT37QKQQYVH3ADGWF0SVY1Y0
  • webhookWorkflow | wrun_01KT37QQYQT0YVNCYB23062G69
  • sleepingWorkflow | wrun_01KT37QYC80W3TM2CSHJVJWCJA
  • parallelSleepWorkflow | wrun_01KT37RE0T944TEDMS63JB3WSM
  • nullByteWorkflow | wrun_01KT37RHZDEEC3V5QQNM82CET8
  • workflowAndStepMetadataWorkflow | wrun_01KT37RM497MBVPF5DFDQY15GD
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KT37TZ14PVKGQSM4FJYKMZNA
  • writableForwardedFromWorkflowWorkflow | wrun_01KT37VCAAA2QF96BE5EHK2KNP
  • writableForwardedFromStepWorkflow | wrun_01KT37VGS6CSA06P809DJXCA6A
  • fetchWorkflow | wrun_01KT37VMBRMXD5NTHK0G62976Y
  • promiseRaceStressTestWorkflow | wrun_01KT37VQQ100HMJ9G6VKWWY30W
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KT37ZCC9SFWTFE3GT3GHGG9P
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT37ZT2C25MF5XS7TH8NWTN1
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KT380ASA3B3YH71ESE7TKF21
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KT380TY73PJMFK2WB6SW20X4
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KT38144AMRX81ZR28BBWJR0A
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KT381A641STKB0JT9M30515M
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KT381CE10BY0GYWMH6ZSQMD4
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KT381W5TMHRFYMW4HDY93DTH
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KT382217A0KW15CW0N89WC69
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KT3828YN7A2NQJ0YAR7FZHEE
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KT382FR63GR5CANAHP9PN960
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KT382NRBN5DBT2QKZSQH0BBF
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KT382WN12GNEMMBDDJVFZF8C
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KT3835D2E9F05FM67Q92Z38Z
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KT383KBG3791HGSWZVRKDAY4
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KT383WTM4P8NBRAJARACVW18
  • cancelRun - cancelling a running workflow | wrun_01KT3843SJMHCHXBP5AR25DM6P
  • cancelRun via CLI - cancelling a running workflow | wrun_01KT384D86RHR9BPTHH3NEAJA3
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KT384T8YZ0MRAW0FKFMRBPAN
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KT385AJ5XD3DG0XKCVNWM4CF
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KT385PSCFQK619TGT1DGV14F
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KT385XSF6SKPDJ5QEYBPM4K4
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KT386070DXTEBKMMKEF3CDXP
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT3862DTG9DVYKE6QB58T60T
Details by Category
❌ ▲ Vercel Production
AppPassedFailedSkipped
❌ astro8217
✅ example8307
✅ express8307
✅ fastify8307
✅ hono8307
✅ nextjs-turbopack8802
✅ nextjs-webpack8802
✅ nitro8307
✅ nuxt8307
✅ sveltekit8307
✅ vite8307
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack9000
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev500
❌ mongodb57140
✅ redis-dev500
❌ redis6290
❌ turso-dev410
❌ turso3680
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8406
✅ e2e-local-dev-tanstack-start-stable8406
✅ e2e-local-postgres-nest-stable8406
✅ e2e-local-postgres-tanstack-start-stable8406
✅ e2e-local-prod-nest-stable8406
✅ e2e-local-prod-tanstack-start-stable8406
📋 View full workflow run
❌ Some E2E test jobs failed:
  • Vercel Prod: failure
  • Local Dev: success
  • Local Prod: success
  • Local Postgres: success
  • Windows: success
Check the workflow run for details.
⚠️Community world tests failed (non-blocking):
  • Community Worlds: failure
Check the workflow run for details.
@pranaygp
pranaygp
marked this pull request as ready for review
June 2, 2026 03:13
@pranaygp
pranaygp
requested a review
from a team
as a code ownerJune 2, 2026 03:13
CopilotAI
review requested due to automatic review settings
June 2, 2026 03:13
CopilotAI
reviewed
Jun 2, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR hardens the workflow runtime replay path by detecting terminal run events already present in the loaded event snapshot, preventing unnecessary (and potentially divergent) replays for runs whose outcome is already durably recorded.
Changes:
  • Add a replay guard that skips runWorkflow() when the loaded snapshot already contains a terminal run event (run_failed, run_cancelled, run_completed).
  • Re-check for terminal events after committing elapsed waits and refreshing the event snapshot.
  • Add a regression test for a running materialized run whose preloaded snapshot already includes run_failed, plus a patch changeset for @workflow/core.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
FileDescription
packages/core/src/runtime.tsAdds terminal-event detection to short-circuit replay both on initial snapshot load and after wait-completion refresh.
packages/core/src/runtime.test.tsAdds regression coverage to ensure runs with terminal events in the snapshot do not replay or queue recovery replays.
.changeset/terminal-run-event-replay.mdPublishes a patch changeset documenting the replay-skip behavior change for @workflow/core.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment threadpackages/core/src/runtime.ts
Comment threadpackages/core/src/runtime.test.ts
Comment threadpackages/core/src/runtime.ts
@pranaygppranaygp
mentioned this pull request
Jun 2, 2026
 Merged

@vercel
vercelBottemporarily deployed
to
Preview – workflow-docs
June 2, 2026 03:56
Inactive

@VaguelySerious
VaguelySerious
commented
Jun 2, 2026

Copy link


Copy Markdown

Member
Let's not forget to forward-port too
@pranaygp
pranaygp
merged commit e959124
into
stableJun 2, 2026

91 of 97 checks passed

@pranaygp
pranaygp
deleted the

pranaygp/codex/fix-run-failed-replay

branch
June 2, 2026 17:26
@pranaygp
pranaygp
commented
Jun 2, 2026

Copy link


Copy Markdown

ContributorAuthor
forward ported in #2215
@github-actionsgithub-actionsBot
mentioned this pull request
Jun 2, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@VaguelySeriousVaguelySeriousVaguelySerious approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@pranaygp@VaguelySerious

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[codex] Skip replay for terminal run events - #2214
Merged
pranaygp merged 2 commits into
stablefrom 
pranaygp/codex/fix-run-failed-replay
Jun 2, 2026
Merged
[codex] Skip replay for terminal run events#2214
pranaygp merged 2 commits into
stablefrom 
pranaygp/codex/fix-run-failed-replay
Conversation
@pranaygp
@pranaygppranaygp
commented
Jun 2, 2026

Copy link


Copy Markdown

Contributor
Summary
  • Skip workflow replay when the loaded event snapshot already contains a terminal run event (run_failed, run_cancelled, or run_completed).
  • Recheck for a terminal event after refreshing history following elapsed wait completion.
  • Add regression coverage for a running materialized run whose event log already records run_failed, plus a patch changeset for @workflow/core.
Root Cause
A replay invocation can observe a materialized run as running while its loaded event snapshot already contains run_failed. The runtime previously proceeded into runWorkflow(), where EventsConsumer had no consumer for that terminal event and reported it as REPLAY_DIVERGENCE, queueing recovery replays for an already-failed run.
Validation
  • pnpm --filter '@workflow/core...' build
  • pnpm changeset status --since=origin/stable
  • pnpm --dir packages/core exec vitest run src/runtime.test.ts src/runtime/wait-completion-replay.test.ts (11 passed)
  • git diff --check
  • pnpm exec biome check packages/core/src/runtime.ts packages/core/src/runtime.test.ts completed with the pre-existing cognitive-complexity warnings in packages/core/src/runtime.ts.
Additional Test Note
pnpm --dir packages/core test fails outside this diff in the untouched src/serialization.test.ts: seven DOMException serialization tests fail with DevalueError: Cannot stringify arbitrary non-POJOs.
@changeset-bot
changeset-botBot
commented
Jun 2, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: a7f337b
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
workflowPatch
@workflow/world-testingPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 2, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, CommentJun 2, 2026 4:00am
example-nextjs-workflow-webpackReadyReadyPreview, CommentJun 2, 2026 4:00am
example-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-astro-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-express-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-fastify-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-hono-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-nitro-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-nuxt-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-sveltekit-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-tanstack-start-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-vite-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workflow-swc-playgroundReadyReadyPreview, CommentJun 2, 2026 4:00am
workflow-tarballsReadyReadyPreview, CommentJun 2, 2026 4:00am
workflow-webReadyReadyPreview, CommentJun 2, 2026 4:00am
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
workflow-docsSkippedSkippedJun 2, 2026 4:00am
@github-actions
github-actionsBot
commented
Jun 2, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
🧪 E2E Test Results
❌ Some tests failed
Summary
PassedFailedSkippedTotal
❌ ▲ Vercel Production922167990
✅ 💻 Local Development9940861080
✅ 📦 Local Production9940861080
✅ 🐘 Local Postgres9940861080
✅ 🪟 Windows900090
❌ 🌍 Community Worlds136920228
✅ 📋 Other504036540
Total4634933615088
❌ Failed Tests
▲ Vercel Production (1 failed)
astro (1 failed):
🌍 Community Worlds (92 failed)
mongodb (14 failed):
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT37QKQQYVH3ADGWF0SVY1Y0
  • webhookWorkflow | wrun_01KT37QQYQT0YVNCYB23062G69
  • sleepingWorkflow | wrun_01KT37QYC80W3TM2CSHJVJWCJA
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KT37TZ14PVKGQSM4FJYKMZNA
  • writableForwardedFromWorkflowWorkflow | wrun_01KT37VCAAA2QF96BE5EHK2KNP
  • writableForwardedFromStepWorkflow | wrun_01KT37VGS6CSA06P809DJXCA6A
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT37ZT2C25MF5XS7TH8NWTN1
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT3862DTG9DVYKE6QB58T60T
redis (9 failed):
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT37QKQQYVH3ADGWF0SVY1Y0
  • sleepingWorkflow | wrun_01KT37QYC80W3TM2CSHJVJWCJA
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT37ZT2C25MF5XS7TH8NWTN1
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT3862DTG9DVYKE6QB58T60T
turso-dev (1 failed):
  • dev e2e should rebuild on imported step dependency change
turso (68 failed):
  • addTenWorkflow | wrun_01KT37PDX08NJK6TWZ7V9VEYMT
  • addTenWorkflow | wrun_01KT37PDX08NJK6TWZ7V9VEYMT
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KT37R1M73KQ4GH2EQV52Y0VG
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KT37PQ0E1MKJXTZ8QZ3WA007
  • promiseRaceWorkflow | wrun_01KT37PVJM5RNCCM1BGKYG4M96
  • promiseAnyWorkflow | wrun_01KT37PXX1V9TX0NGTKVCBH8SH
  • importedStepOnlyWorkflow | wrun_01KT37REF4YCP684J5PDMGY4HB
  • readableStreamWorkflow | wrun_01KT37Q03TQ46AN44PZYB4PR0B
  • hookWorkflow | wrun_01KT37QCAK29DQ3K7CJS93RMQT
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT37QKQQYVH3ADGWF0SVY1Y0
  • webhookWorkflow | wrun_01KT37QQYQT0YVNCYB23062G69
  • sleepingWorkflow | wrun_01KT37QYC80W3TM2CSHJVJWCJA
  • parallelSleepWorkflow | wrun_01KT37RE0T944TEDMS63JB3WSM
  • nullByteWorkflow | wrun_01KT37RHZDEEC3V5QQNM82CET8
  • workflowAndStepMetadataWorkflow | wrun_01KT37RM497MBVPF5DFDQY15GD
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KT37TZ14PVKGQSM4FJYKMZNA
  • writableForwardedFromWorkflowWorkflow | wrun_01KT37VCAAA2QF96BE5EHK2KNP
  • writableForwardedFromStepWorkflow | wrun_01KT37VGS6CSA06P809DJXCA6A
  • fetchWorkflow | wrun_01KT37VMBRMXD5NTHK0G62976Y
  • promiseRaceStressTestWorkflow | wrun_01KT37VQQ100HMJ9G6VKWWY30W
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KT37ZCC9SFWTFE3GT3GHGG9P
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT37ZT2C25MF5XS7TH8NWTN1
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KT380ASA3B3YH71ESE7TKF21
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KT380TY73PJMFK2WB6SW20X4
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KT38144AMRX81ZR28BBWJR0A
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KT381A641STKB0JT9M30515M
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KT381CE10BY0GYWMH6ZSQMD4
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KT381W5TMHRFYMW4HDY93DTH
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KT382217A0KW15CW0N89WC69
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KT3828YN7A2NQJ0YAR7FZHEE
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KT382FR63GR5CANAHP9PN960
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KT382NRBN5DBT2QKZSQH0BBF
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KT382WN12GNEMMBDDJVFZF8C
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KT3835D2E9F05FM67Q92Z38Z
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KT383KBG3791HGSWZVRKDAY4
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KT383WTM4P8NBRAJARACVW18
  • cancelRun - cancelling a running workflow | wrun_01KT3843SJMHCHXBP5AR25DM6P
  • cancelRun via CLI - cancelling a running workflow | wrun_01KT384D86RHR9BPTHH3NEAJA3
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KT384T8YZ0MRAW0FKFMRBPAN
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KT385AJ5XD3DG0XKCVNWM4CF
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KT385PSCFQK619TGT1DGV14F
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KT385XSF6SKPDJ5QEYBPM4K4
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KT386070DXTEBKMMKEF3CDXP
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT3862DTG9DVYKE6QB58T60T
Details by Category
❌ ▲ Vercel Production
AppPassedFailedSkipped
❌ astro8217
✅ example8307
✅ express8307
✅ fastify8307
✅ hono8307
✅ nextjs-turbopack8802
✅ nextjs-webpack8802
✅ nitro8307
✅ nuxt8307
✅ sveltekit8307
✅ vite8307
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack9000
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev500
❌ mongodb57140
✅ redis-dev500
❌ redis6290
❌ turso-dev410
❌ turso3680
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8406
✅ e2e-local-dev-tanstack-start-stable8406
✅ e2e-local-postgres-nest-stable8406
✅ e2e-local-postgres-tanstack-start-stable8406
✅ e2e-local-prod-nest-stable8406
✅ e2e-local-prod-tanstack-start-stable8406
📋 View full workflow run
❌ Some E2E test jobs failed:
  • Vercel Prod: failure
  • Local Dev: success
  • Local Prod: success
  • Local Postgres: success
  • Windows: success
Check the workflow run for details.
⚠️Community world tests failed (non-blocking):
  • Community Worlds: failure
Check the workflow run for details.
@pranaygp
pranaygp
marked this pull request as ready for review
June 2, 2026 03:13
@pranaygp
pranaygp
requested a review
from a team
as a code ownerJune 2, 2026 03:13
CopilotAI
review requested due to automatic review settings
June 2, 2026 03:13
CopilotAI
reviewed
Jun 2, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR hardens the workflow runtime replay path by detecting terminal run events already present in the loaded event snapshot, preventing unnecessary (and potentially divergent) replays for runs whose outcome is already durably recorded.
Changes:
  • Add a replay guard that skips runWorkflow() when the loaded snapshot already contains a terminal run event (run_failed, run_cancelled, run_completed).
  • Re-check for terminal events after committing elapsed waits and refreshing the event snapshot.
  • Add a regression test for a running materialized run whose preloaded snapshot already includes run_failed, plus a patch changeset for @workflow/core.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
FileDescription
packages/core/src/runtime.tsAdds terminal-event detection to short-circuit replay both on initial snapshot load and after wait-completion refresh.
packages/core/src/runtime.test.tsAdds regression coverage to ensure runs with terminal events in the snapshot do not replay or queue recovery replays.
.changeset/terminal-run-event-replay.mdPublishes a patch changeset documenting the replay-skip behavior change for @workflow/core.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment threadpackages/core/src/runtime.ts
Comment threadpackages/core/src/runtime.test.ts
Comment threadpackages/core/src/runtime.ts
@pranaygppranaygp
mentioned this pull request
Jun 2, 2026
 Merged

@vercel
vercelBottemporarily deployed
to
Preview – workflow-docs
June 2, 2026 03:56
Inactive

@VaguelySerious
VaguelySerious
commented
Jun 2, 2026

Copy link


Copy Markdown

Member
Let's not forget to forward-port too
@pranaygp
pranaygp
merged commit e959124
into
stableJun 2, 2026

91 of 97 checks passed

@pranaygp
pranaygp
deleted the

pranaygp/codex/fix-run-failed-replay

branch
June 2, 2026 17:26
@pranaygp
pranaygp
commented
Jun 2, 2026

Copy link


Copy Markdown

ContributorAuthor
forward ported in #2215
@github-actionsgithub-actionsBot
mentioned this pull request
Jun 2, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@VaguelySeriousVaguelySeriousVaguelySerious approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@pranaygp@VaguelySerious

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[codex] Skip replay for terminal run events - #2214
Merged
pranaygp merged 2 commits into
stablefrom 
pranaygp/codex/fix-run-failed-replay
Jun 2, 2026
Merged
[codex] Skip replay for terminal run events#2214
pranaygp merged 2 commits into
stablefrom 
pranaygp/codex/fix-run-failed-replay
Conversation
@pranaygp
@pranaygppranaygp
commented
Jun 2, 2026

Copy link


Copy Markdown

Contributor
Summary
  • Skip workflow replay when the loaded event snapshot already contains a terminal run event (run_failed, run_cancelled, or run_completed).
  • Recheck for a terminal event after refreshing history following elapsed wait completion.
  • Add regression coverage for a running materialized run whose event log already records run_failed, plus a patch changeset for @workflow/core.
Root Cause
A replay invocation can observe a materialized run as running while its loaded event snapshot already contains run_failed. The runtime previously proceeded into runWorkflow(), where EventsConsumer had no consumer for that terminal event and reported it as REPLAY_DIVERGENCE, queueing recovery replays for an already-failed run.
Validation
  • pnpm --filter '@workflow/core...' build
  • pnpm changeset status --since=origin/stable
  • pnpm --dir packages/core exec vitest run src/runtime.test.ts src/runtime/wait-completion-replay.test.ts (11 passed)
  • git diff --check
  • pnpm exec biome check packages/core/src/runtime.ts packages/core/src/runtime.test.ts completed with the pre-existing cognitive-complexity warnings in packages/core/src/runtime.ts.
Additional Test Note
pnpm --dir packages/core test fails outside this diff in the untouched src/serialization.test.ts: seven DOMException serialization tests fail with DevalueError: Cannot stringify arbitrary non-POJOs.
@changeset-bot
changeset-botBot
commented
Jun 2, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: a7f337b
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
workflowPatch
@workflow/world-testingPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 2, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, CommentJun 2, 2026 4:00am
example-nextjs-workflow-webpackReadyReadyPreview, CommentJun 2, 2026 4:00am
example-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-astro-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-express-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-fastify-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-hono-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-nitro-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-nuxt-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-sveltekit-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-tanstack-start-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-vite-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workflow-swc-playgroundReadyReadyPreview, CommentJun 2, 2026 4:00am
workflow-tarballsReadyReadyPreview, CommentJun 2, 2026 4:00am
workflow-webReadyReadyPreview, CommentJun 2, 2026 4:00am
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
workflow-docsSkippedSkippedJun 2, 2026 4:00am
@github-actions
github-actionsBot
commented
Jun 2, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
🧪 E2E Test Results
❌ Some tests failed
Summary
PassedFailedSkippedTotal
❌ ▲ Vercel Production922167990
✅ 💻 Local Development9940861080
✅ 📦 Local Production9940861080
✅ 🐘 Local Postgres9940861080
✅ 🪟 Windows900090
❌ 🌍 Community Worlds136920228
✅ 📋 Other504036540
Total4634933615088
❌ Failed Tests
▲ Vercel Production (1 failed)
astro (1 failed):
🌍 Community Worlds (92 failed)
mongodb (14 failed):
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT37QKQQYVH3ADGWF0SVY1Y0
  • webhookWorkflow | wrun_01KT37QQYQT0YVNCYB23062G69
  • sleepingWorkflow | wrun_01KT37QYC80W3TM2CSHJVJWCJA
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KT37TZ14PVKGQSM4FJYKMZNA
  • writableForwardedFromWorkflowWorkflow | wrun_01KT37VCAAA2QF96BE5EHK2KNP
  • writableForwardedFromStepWorkflow | wrun_01KT37VGS6CSA06P809DJXCA6A
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT37ZT2C25MF5XS7TH8NWTN1
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT3862DTG9DVYKE6QB58T60T
redis (9 failed):
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT37QKQQYVH3ADGWF0SVY1Y0
  • sleepingWorkflow | wrun_01KT37QYC80W3TM2CSHJVJWCJA
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT37ZT2C25MF5XS7TH8NWTN1
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT3862DTG9DVYKE6QB58T60T
turso-dev (1 failed):
  • dev e2e should rebuild on imported step dependency change
turso (68 failed):
  • addTenWorkflow | wrun_01KT37PDX08NJK6TWZ7V9VEYMT
  • addTenWorkflow | wrun_01KT37PDX08NJK6TWZ7V9VEYMT
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KT37R1M73KQ4GH2EQV52Y0VG
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KT37PQ0E1MKJXTZ8QZ3WA007
  • promiseRaceWorkflow | wrun_01KT37PVJM5RNCCM1BGKYG4M96
  • promiseAnyWorkflow | wrun_01KT37PXX1V9TX0NGTKVCBH8SH
  • importedStepOnlyWorkflow | wrun_01KT37REF4YCP684J5PDMGY4HB
  • readableStreamWorkflow | wrun_01KT37Q03TQ46AN44PZYB4PR0B
  • hookWorkflow | wrun_01KT37QCAK29DQ3K7CJS93RMQT
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT37QKQQYVH3ADGWF0SVY1Y0
  • webhookWorkflow | wrun_01KT37QQYQT0YVNCYB23062G69
  • sleepingWorkflow | wrun_01KT37QYC80W3TM2CSHJVJWCJA
  • parallelSleepWorkflow | wrun_01KT37RE0T944TEDMS63JB3WSM
  • nullByteWorkflow | wrun_01KT37RHZDEEC3V5QQNM82CET8
  • workflowAndStepMetadataWorkflow | wrun_01KT37RM497MBVPF5DFDQY15GD
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KT37TZ14PVKGQSM4FJYKMZNA
  • writableForwardedFromWorkflowWorkflow | wrun_01KT37VCAAA2QF96BE5EHK2KNP
  • writableForwardedFromStepWorkflow | wrun_01KT37VGS6CSA06P809DJXCA6A
  • fetchWorkflow | wrun_01KT37VMBRMXD5NTHK0G62976Y
  • promiseRaceStressTestWorkflow | wrun_01KT37VQQ100HMJ9G6VKWWY30W
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KT37ZCC9SFWTFE3GT3GHGG9P
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT37ZT2C25MF5XS7TH8NWTN1
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KT380ASA3B3YH71ESE7TKF21
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KT380TY73PJMFK2WB6SW20X4
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KT38144AMRX81ZR28BBWJR0A
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KT381A641STKB0JT9M30515M
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KT381CE10BY0GYWMH6ZSQMD4
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KT381W5TMHRFYMW4HDY93DTH
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KT382217A0KW15CW0N89WC69
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KT3828YN7A2NQJ0YAR7FZHEE
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KT382FR63GR5CANAHP9PN960
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KT382NRBN5DBT2QKZSQH0BBF
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KT382WN12GNEMMBDDJVFZF8C
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KT3835D2E9F05FM67Q92Z38Z
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KT383KBG3791HGSWZVRKDAY4
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KT383WTM4P8NBRAJARACVW18
  • cancelRun - cancelling a running workflow | wrun_01KT3843SJMHCHXBP5AR25DM6P
  • cancelRun via CLI - cancelling a running workflow | wrun_01KT384D86RHR9BPTHH3NEAJA3
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KT384T8YZ0MRAW0FKFMRBPAN
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KT385AJ5XD3DG0XKCVNWM4CF
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KT385PSCFQK619TGT1DGV14F
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KT385XSF6SKPDJ5QEYBPM4K4
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KT386070DXTEBKMMKEF3CDXP
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT3862DTG9DVYKE6QB58T60T
Details by Category
❌ ▲ Vercel Production
AppPassedFailedSkipped
❌ astro8217
✅ example8307
✅ express8307
✅ fastify8307
✅ hono8307
✅ nextjs-turbopack8802
✅ nextjs-webpack8802
✅ nitro8307
✅ nuxt8307
✅ sveltekit8307
✅ vite8307
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack9000
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev500
❌ mongodb57140
✅ redis-dev500
❌ redis6290
❌ turso-dev410
❌ turso3680
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8406
✅ e2e-local-dev-tanstack-start-stable8406
✅ e2e-local-postgres-nest-stable8406
✅ e2e-local-postgres-tanstack-start-stable8406
✅ e2e-local-prod-nest-stable8406
✅ e2e-local-prod-tanstack-start-stable8406
📋 View full workflow run
❌ Some E2E test jobs failed:
  • Vercel Prod: failure
  • Local Dev: success
  • Local Prod: success
  • Local Postgres: success
  • Windows: success
Check the workflow run for details.
⚠️Community world tests failed (non-blocking):
  • Community Worlds: failure
Check the workflow run for details.
@pranaygp
pranaygp
marked this pull request as ready for review
June 2, 2026 03:13
@pranaygp
pranaygp
requested a review
from a team
as a code ownerJune 2, 2026 03:13
CopilotAI
review requested due to automatic review settings
June 2, 2026 03:13
CopilotAI
reviewed
Jun 2, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR hardens the workflow runtime replay path by detecting terminal run events already present in the loaded event snapshot, preventing unnecessary (and potentially divergent) replays for runs whose outcome is already durably recorded.
Changes:
  • Add a replay guard that skips runWorkflow() when the loaded snapshot already contains a terminal run event (run_failed, run_cancelled, run_completed).
  • Re-check for terminal events after committing elapsed waits and refreshing the event snapshot.
  • Add a regression test for a running materialized run whose preloaded snapshot already includes run_failed, plus a patch changeset for @workflow/core.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
FileDescription
packages/core/src/runtime.tsAdds terminal-event detection to short-circuit replay both on initial snapshot load and after wait-completion refresh.
packages/core/src/runtime.test.tsAdds regression coverage to ensure runs with terminal events in the snapshot do not replay or queue recovery replays.
.changeset/terminal-run-event-replay.mdPublishes a patch changeset documenting the replay-skip behavior change for @workflow/core.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment threadpackages/core/src/runtime.ts
Comment threadpackages/core/src/runtime.test.ts
Comment threadpackages/core/src/runtime.ts
@pranaygppranaygp
mentioned this pull request
Jun 2, 2026
 Merged

@vercel
vercelBottemporarily deployed
to
Preview – workflow-docs
June 2, 2026 03:56
Inactive

@VaguelySerious
VaguelySerious
commented
Jun 2, 2026

Copy link


Copy Markdown

Member
Let's not forget to forward-port too
@pranaygp
pranaygp
merged commit e959124
into
stableJun 2, 2026

91 of 97 checks passed

@pranaygp
pranaygp
deleted the

pranaygp/codex/fix-run-failed-replay

branch
June 2, 2026 17:26
@pranaygp
pranaygp
commented
Jun 2, 2026

Copy link


Copy Markdown

ContributorAuthor
forward ported in #2215
@github-actionsgithub-actionsBot
mentioned this pull request
Jun 2, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@VaguelySeriousVaguelySeriousVaguelySerious approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@pranaygp@VaguelySerious

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[codex] Skip replay for terminal run events - #2214
Merged
pranaygp merged 2 commits into
stablefrom 
pranaygp/codex/fix-run-failed-replay
Jun 2, 2026
Merged
[codex] Skip replay for terminal run events#2214
pranaygp merged 2 commits into
stablefrom 
pranaygp/codex/fix-run-failed-replay
Conversation
@pranaygp
@pranaygppranaygp
commented
Jun 2, 2026

Copy link


Copy Markdown

Contributor
Summary
  • Skip workflow replay when the loaded event snapshot already contains a terminal run event (run_failed, run_cancelled, or run_completed).
  • Recheck for a terminal event after refreshing history following elapsed wait completion.
  • Add regression coverage for a running materialized run whose event log already records run_failed, plus a patch changeset for @workflow/core.
Root Cause
A replay invocation can observe a materialized run as running while its loaded event snapshot already contains run_failed. The runtime previously proceeded into runWorkflow(), where EventsConsumer had no consumer for that terminal event and reported it as REPLAY_DIVERGENCE, queueing recovery replays for an already-failed run.
Validation
  • pnpm --filter '@workflow/core...' build
  • pnpm changeset status --since=origin/stable
  • pnpm --dir packages/core exec vitest run src/runtime.test.ts src/runtime/wait-completion-replay.test.ts (11 passed)
  • git diff --check
  • pnpm exec biome check packages/core/src/runtime.ts packages/core/src/runtime.test.ts completed with the pre-existing cognitive-complexity warnings in packages/core/src/runtime.ts.
Additional Test Note
pnpm --dir packages/core test fails outside this diff in the untouched src/serialization.test.ts: seven DOMException serialization tests fail with DevalueError: Cannot stringify arbitrary non-POJOs.
@changeset-bot
changeset-botBot
commented
Jun 2, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: a7f337b
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
workflowPatch
@workflow/world-testingPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 2, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, CommentJun 2, 2026 4:00am
example-nextjs-workflow-webpackReadyReadyPreview, CommentJun 2, 2026 4:00am
example-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-astro-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-express-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-fastify-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-hono-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-nitro-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-nuxt-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-sveltekit-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-tanstack-start-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-vite-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workflow-swc-playgroundReadyReadyPreview, CommentJun 2, 2026 4:00am
workflow-tarballsReadyReadyPreview, CommentJun 2, 2026 4:00am
workflow-webReadyReadyPreview, CommentJun 2, 2026 4:00am
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
workflow-docsSkippedSkippedJun 2, 2026 4:00am
@github-actions
github-actionsBot
commented
Jun 2, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
🧪 E2E Test Results
❌ Some tests failed
Summary
PassedFailedSkippedTotal
❌ ▲ Vercel Production922167990
✅ 💻 Local Development9940861080
✅ 📦 Local Production9940861080
✅ 🐘 Local Postgres9940861080
✅ 🪟 Windows900090
❌ 🌍 Community Worlds136920228
✅ 📋 Other504036540
Total4634933615088
❌ Failed Tests
▲ Vercel Production (1 failed)
astro (1 failed):
🌍 Community Worlds (92 failed)
mongodb (14 failed):
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT37QKQQYVH3ADGWF0SVY1Y0
  • webhookWorkflow | wrun_01KT37QQYQT0YVNCYB23062G69
  • sleepingWorkflow | wrun_01KT37QYC80W3TM2CSHJVJWCJA
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KT37TZ14PVKGQSM4FJYKMZNA
  • writableForwardedFromWorkflowWorkflow | wrun_01KT37VCAAA2QF96BE5EHK2KNP
  • writableForwardedFromStepWorkflow | wrun_01KT37VGS6CSA06P809DJXCA6A
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT37ZT2C25MF5XS7TH8NWTN1
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT3862DTG9DVYKE6QB58T60T
redis (9 failed):
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT37QKQQYVH3ADGWF0SVY1Y0
  • sleepingWorkflow | wrun_01KT37QYC80W3TM2CSHJVJWCJA
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT37ZT2C25MF5XS7TH8NWTN1
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT3862DTG9DVYKE6QB58T60T
turso-dev (1 failed):
  • dev e2e should rebuild on imported step dependency change
turso (68 failed):
  • addTenWorkflow | wrun_01KT37PDX08NJK6TWZ7V9VEYMT
  • addTenWorkflow | wrun_01KT37PDX08NJK6TWZ7V9VEYMT
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KT37R1M73KQ4GH2EQV52Y0VG
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KT37PQ0E1MKJXTZ8QZ3WA007
  • promiseRaceWorkflow | wrun_01KT37PVJM5RNCCM1BGKYG4M96
  • promiseAnyWorkflow | wrun_01KT37PXX1V9TX0NGTKVCBH8SH
  • importedStepOnlyWorkflow | wrun_01KT37REF4YCP684J5PDMGY4HB
  • readableStreamWorkflow | wrun_01KT37Q03TQ46AN44PZYB4PR0B
  • hookWorkflow | wrun_01KT37QCAK29DQ3K7CJS93RMQT
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT37QKQQYVH3ADGWF0SVY1Y0
  • webhookWorkflow | wrun_01KT37QQYQT0YVNCYB23062G69
  • sleepingWorkflow | wrun_01KT37QYC80W3TM2CSHJVJWCJA
  • parallelSleepWorkflow | wrun_01KT37RE0T944TEDMS63JB3WSM
  • nullByteWorkflow | wrun_01KT37RHZDEEC3V5QQNM82CET8
  • workflowAndStepMetadataWorkflow | wrun_01KT37RM497MBVPF5DFDQY15GD
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KT37TZ14PVKGQSM4FJYKMZNA
  • writableForwardedFromWorkflowWorkflow | wrun_01KT37VCAAA2QF96BE5EHK2KNP
  • writableForwardedFromStepWorkflow | wrun_01KT37VGS6CSA06P809DJXCA6A
  • fetchWorkflow | wrun_01KT37VMBRMXD5NTHK0G62976Y
  • promiseRaceStressTestWorkflow | wrun_01KT37VQQ100HMJ9G6VKWWY30W
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KT37ZCC9SFWTFE3GT3GHGG9P
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT37ZT2C25MF5XS7TH8NWTN1
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KT380ASA3B3YH71ESE7TKF21
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KT380TY73PJMFK2WB6SW20X4
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KT38144AMRX81ZR28BBWJR0A
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KT381A641STKB0JT9M30515M
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KT381CE10BY0GYWMH6ZSQMD4
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KT381W5TMHRFYMW4HDY93DTH
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KT382217A0KW15CW0N89WC69
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KT3828YN7A2NQJ0YAR7FZHEE
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KT382FR63GR5CANAHP9PN960
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KT382NRBN5DBT2QKZSQH0BBF
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KT382WN12GNEMMBDDJVFZF8C
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KT3835D2E9F05FM67Q92Z38Z
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KT383KBG3791HGSWZVRKDAY4
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KT383WTM4P8NBRAJARACVW18
  • cancelRun - cancelling a running workflow | wrun_01KT3843SJMHCHXBP5AR25DM6P
  • cancelRun via CLI - cancelling a running workflow | wrun_01KT384D86RHR9BPTHH3NEAJA3
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KT384T8YZ0MRAW0FKFMRBPAN
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KT385AJ5XD3DG0XKCVNWM4CF
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KT385PSCFQK619TGT1DGV14F
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KT385XSF6SKPDJ5QEYBPM4K4
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KT386070DXTEBKMMKEF3CDXP
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT3862DTG9DVYKE6QB58T60T
Details by Category
❌ ▲ Vercel Production
AppPassedFailedSkipped
❌ astro8217
✅ example8307
✅ express8307
✅ fastify8307
✅ hono8307
✅ nextjs-turbopack8802
✅ nextjs-webpack8802
✅ nitro8307
✅ nuxt8307
✅ sveltekit8307
✅ vite8307
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack9000
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev500
❌ mongodb57140
✅ redis-dev500
❌ redis6290
❌ turso-dev410
❌ turso3680
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8406
✅ e2e-local-dev-tanstack-start-stable8406
✅ e2e-local-postgres-nest-stable8406
✅ e2e-local-postgres-tanstack-start-stable8406
✅ e2e-local-prod-nest-stable8406
✅ e2e-local-prod-tanstack-start-stable8406
📋 View full workflow run
❌ Some E2E test jobs failed:
  • Vercel Prod: failure
  • Local Dev: success
  • Local Prod: success
  • Local Postgres: success
  • Windows: success
Check the workflow run for details.
⚠️Community world tests failed (non-blocking):
  • Community Worlds: failure
Check the workflow run for details.
@pranaygp
pranaygp
marked this pull request as ready for review
June 2, 2026 03:13
@pranaygp
pranaygp
requested a review
from a team
as a code ownerJune 2, 2026 03:13
CopilotAI
review requested due to automatic review settings
June 2, 2026 03:13
CopilotAI
reviewed
Jun 2, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR hardens the workflow runtime replay path by detecting terminal run events already present in the loaded event snapshot, preventing unnecessary (and potentially divergent) replays for runs whose outcome is already durably recorded.
Changes:
  • Add a replay guard that skips runWorkflow() when the loaded snapshot already contains a terminal run event (run_failed, run_cancelled, run_completed).
  • Re-check for terminal events after committing elapsed waits and refreshing the event snapshot.
  • Add a regression test for a running materialized run whose preloaded snapshot already includes run_failed, plus a patch changeset for @workflow/core.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
FileDescription
packages/core/src/runtime.tsAdds terminal-event detection to short-circuit replay both on initial snapshot load and after wait-completion refresh.
packages/core/src/runtime.test.tsAdds regression coverage to ensure runs with terminal events in the snapshot do not replay or queue recovery replays.
.changeset/terminal-run-event-replay.mdPublishes a patch changeset documenting the replay-skip behavior change for @workflow/core.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment threadpackages/core/src/runtime.ts
Comment threadpackages/core/src/runtime.test.ts
Comment threadpackages/core/src/runtime.ts
@pranaygppranaygp
mentioned this pull request
Jun 2, 2026
 Merged

@vercel
vercelBottemporarily deployed
to
Preview – workflow-docs
June 2, 2026 03:56
Inactive

@VaguelySerious
VaguelySerious
commented
Jun 2, 2026

Copy link


Copy Markdown

Member
Let's not forget to forward-port too
@pranaygp
pranaygp
merged commit e959124
into
stableJun 2, 2026

91 of 97 checks passed

@pranaygp
pranaygp
deleted the

pranaygp/codex/fix-run-failed-replay

branch
June 2, 2026 17:26
@pranaygp
pranaygp
commented
Jun 2, 2026

Copy link


Copy Markdown

ContributorAuthor
forward ported in #2215
@github-actionsgithub-actionsBot
mentioned this pull request
Jun 2, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@VaguelySeriousVaguelySeriousVaguelySerious approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@pranaygp@VaguelySerious

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[codex] Skip replay for terminal run events - #2214
Merged
pranaygp merged 2 commits into
stablefrom 
pranaygp/codex/fix-run-failed-replay
Jun 2, 2026
Merged
[codex] Skip replay for terminal run events#2214
pranaygp merged 2 commits into
stablefrom 
pranaygp/codex/fix-run-failed-replay
Conversation
@pranaygp
@pranaygppranaygp
commented
Jun 2, 2026

Copy link


Copy Markdown

Contributor
Summary
  • Skip workflow replay when the loaded event snapshot already contains a terminal run event (run_failed, run_cancelled, or run_completed).
  • Recheck for a terminal event after refreshing history following elapsed wait completion.
  • Add regression coverage for a running materialized run whose event log already records run_failed, plus a patch changeset for @workflow/core.
Root Cause
A replay invocation can observe a materialized run as running while its loaded event snapshot already contains run_failed. The runtime previously proceeded into runWorkflow(), where EventsConsumer had no consumer for that terminal event and reported it as REPLAY_DIVERGENCE, queueing recovery replays for an already-failed run.
Validation
  • pnpm --filter '@workflow/core...' build
  • pnpm changeset status --since=origin/stable
  • pnpm --dir packages/core exec vitest run src/runtime.test.ts src/runtime/wait-completion-replay.test.ts (11 passed)
  • git diff --check
  • pnpm exec biome check packages/core/src/runtime.ts packages/core/src/runtime.test.ts completed with the pre-existing cognitive-complexity warnings in packages/core/src/runtime.ts.
Additional Test Note
pnpm --dir packages/core test fails outside this diff in the untouched src/serialization.test.ts: seven DOMException serialization tests fail with DevalueError: Cannot stringify arbitrary non-POJOs.
@changeset-bot
changeset-botBot
commented
Jun 2, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: a7f337b
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
workflowPatch
@workflow/world-testingPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 2, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, CommentJun 2, 2026 4:00am
example-nextjs-workflow-webpackReadyReadyPreview, CommentJun 2, 2026 4:00am
example-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-astro-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-express-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-fastify-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-hono-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-nitro-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-nuxt-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-sveltekit-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-tanstack-start-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-vite-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workflow-swc-playgroundReadyReadyPreview, CommentJun 2, 2026 4:00am
workflow-tarballsReadyReadyPreview, CommentJun 2, 2026 4:00am
workflow-webReadyReadyPreview, CommentJun 2, 2026 4:00am
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
workflow-docsSkippedSkippedJun 2, 2026 4:00am
@github-actions
github-actionsBot
commented
Jun 2, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
🧪 E2E Test Results
❌ Some tests failed
Summary
PassedFailedSkippedTotal
❌ ▲ Vercel Production922167990
✅ 💻 Local Development9940861080
✅ 📦 Local Production9940861080
✅ 🐘 Local Postgres9940861080
✅ 🪟 Windows900090
❌ 🌍 Community Worlds136920228
✅ 📋 Other504036540
Total4634933615088
❌ Failed Tests
▲ Vercel Production (1 failed)
astro (1 failed):
🌍 Community Worlds (92 failed)
mongodb (14 failed):
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT37QKQQYVH3ADGWF0SVY1Y0
  • webhookWorkflow | wrun_01KT37QQYQT0YVNCYB23062G69
  • sleepingWorkflow | wrun_01KT37QYC80W3TM2CSHJVJWCJA
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KT37TZ14PVKGQSM4FJYKMZNA
  • writableForwardedFromWorkflowWorkflow | wrun_01KT37VCAAA2QF96BE5EHK2KNP
  • writableForwardedFromStepWorkflow | wrun_01KT37VGS6CSA06P809DJXCA6A
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT37ZT2C25MF5XS7TH8NWTN1
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT3862DTG9DVYKE6QB58T60T
redis (9 failed):
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT37QKQQYVH3ADGWF0SVY1Y0
  • sleepingWorkflow | wrun_01KT37QYC80W3TM2CSHJVJWCJA
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT37ZT2C25MF5XS7TH8NWTN1
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT3862DTG9DVYKE6QB58T60T
turso-dev (1 failed):
  • dev e2e should rebuild on imported step dependency change
turso (68 failed):
  • addTenWorkflow | wrun_01KT37PDX08NJK6TWZ7V9VEYMT
  • addTenWorkflow | wrun_01KT37PDX08NJK6TWZ7V9VEYMT
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KT37R1M73KQ4GH2EQV52Y0VG
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KT37PQ0E1MKJXTZ8QZ3WA007
  • promiseRaceWorkflow | wrun_01KT37PVJM5RNCCM1BGKYG4M96
  • promiseAnyWorkflow | wrun_01KT37PXX1V9TX0NGTKVCBH8SH
  • importedStepOnlyWorkflow | wrun_01KT37REF4YCP684J5PDMGY4HB
  • readableStreamWorkflow | wrun_01KT37Q03TQ46AN44PZYB4PR0B
  • hookWorkflow | wrun_01KT37QCAK29DQ3K7CJS93RMQT
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT37QKQQYVH3ADGWF0SVY1Y0
  • webhookWorkflow | wrun_01KT37QQYQT0YVNCYB23062G69
  • sleepingWorkflow | wrun_01KT37QYC80W3TM2CSHJVJWCJA
  • parallelSleepWorkflow | wrun_01KT37RE0T944TEDMS63JB3WSM
  • nullByteWorkflow | wrun_01KT37RHZDEEC3V5QQNM82CET8
  • workflowAndStepMetadataWorkflow | wrun_01KT37RM497MBVPF5DFDQY15GD
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KT37TZ14PVKGQSM4FJYKMZNA
  • writableForwardedFromWorkflowWorkflow | wrun_01KT37VCAAA2QF96BE5EHK2KNP
  • writableForwardedFromStepWorkflow | wrun_01KT37VGS6CSA06P809DJXCA6A
  • fetchWorkflow | wrun_01KT37VMBRMXD5NTHK0G62976Y
  • promiseRaceStressTestWorkflow | wrun_01KT37VQQ100HMJ9G6VKWWY30W
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KT37ZCC9SFWTFE3GT3GHGG9P
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT37ZT2C25MF5XS7TH8NWTN1
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KT380ASA3B3YH71ESE7TKF21
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KT380TY73PJMFK2WB6SW20X4
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KT38144AMRX81ZR28BBWJR0A
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KT381A641STKB0JT9M30515M
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KT381CE10BY0GYWMH6ZSQMD4
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KT381W5TMHRFYMW4HDY93DTH
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KT382217A0KW15CW0N89WC69
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KT3828YN7A2NQJ0YAR7FZHEE
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KT382FR63GR5CANAHP9PN960
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KT382NRBN5DBT2QKZSQH0BBF
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KT382WN12GNEMMBDDJVFZF8C
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KT3835D2E9F05FM67Q92Z38Z
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KT383KBG3791HGSWZVRKDAY4
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KT383WTM4P8NBRAJARACVW18
  • cancelRun - cancelling a running workflow | wrun_01KT3843SJMHCHXBP5AR25DM6P
  • cancelRun via CLI - cancelling a running workflow | wrun_01KT384D86RHR9BPTHH3NEAJA3
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KT384T8YZ0MRAW0FKFMRBPAN
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KT385AJ5XD3DG0XKCVNWM4CF
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KT385PSCFQK619TGT1DGV14F
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KT385XSF6SKPDJ5QEYBPM4K4
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KT386070DXTEBKMMKEF3CDXP
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT3862DTG9DVYKE6QB58T60T
Details by Category
❌ ▲ Vercel Production
AppPassedFailedSkipped
❌ astro8217
✅ example8307
✅ express8307
✅ fastify8307
✅ hono8307
✅ nextjs-turbopack8802
✅ nextjs-webpack8802
✅ nitro8307
✅ nuxt8307
✅ sveltekit8307
✅ vite8307
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack9000
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev500
❌ mongodb57140
✅ redis-dev500
❌ redis6290
❌ turso-dev410
❌ turso3680
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8406
✅ e2e-local-dev-tanstack-start-stable8406
✅ e2e-local-postgres-nest-stable8406
✅ e2e-local-postgres-tanstack-start-stable8406
✅ e2e-local-prod-nest-stable8406
✅ e2e-local-prod-tanstack-start-stable8406
📋 View full workflow run
❌ Some E2E test jobs failed:
  • Vercel Prod: failure
  • Local Dev: success
  • Local Prod: success
  • Local Postgres: success
  • Windows: success
Check the workflow run for details.
⚠️Community world tests failed (non-blocking):
  • Community Worlds: failure
Check the workflow run for details.
@pranaygp
pranaygp
marked this pull request as ready for review
June 2, 2026 03:13
@pranaygp
pranaygp
requested a review
from a team
as a code ownerJune 2, 2026 03:13
CopilotAI
review requested due to automatic review settings
June 2, 2026 03:13
CopilotAI
reviewed
Jun 2, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR hardens the workflow runtime replay path by detecting terminal run events already present in the loaded event snapshot, preventing unnecessary (and potentially divergent) replays for runs whose outcome is already durably recorded.
Changes:
  • Add a replay guard that skips runWorkflow() when the loaded snapshot already contains a terminal run event (run_failed, run_cancelled, run_completed).
  • Re-check for terminal events after committing elapsed waits and refreshing the event snapshot.
  • Add a regression test for a running materialized run whose preloaded snapshot already includes run_failed, plus a patch changeset for @workflow/core.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
FileDescription
packages/core/src/runtime.tsAdds terminal-event detection to short-circuit replay both on initial snapshot load and after wait-completion refresh.
packages/core/src/runtime.test.tsAdds regression coverage to ensure runs with terminal events in the snapshot do not replay or queue recovery replays.
.changeset/terminal-run-event-replay.mdPublishes a patch changeset documenting the replay-skip behavior change for @workflow/core.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment threadpackages/core/src/runtime.ts
Comment threadpackages/core/src/runtime.test.ts
Comment threadpackages/core/src/runtime.ts
@pranaygppranaygp
mentioned this pull request
Jun 2, 2026
 Merged

@vercel
vercelBottemporarily deployed
to
Preview – workflow-docs
June 2, 2026 03:56
Inactive

@VaguelySerious
VaguelySerious
commented
Jun 2, 2026

Copy link


Copy Markdown

Member
Let's not forget to forward-port too
@pranaygp
pranaygp
merged commit e959124
into
stableJun 2, 2026

91 of 97 checks passed

@pranaygp
pranaygp
deleted the

pranaygp/codex/fix-run-failed-replay

branch
June 2, 2026 17:26
@pranaygp
pranaygp
commented
Jun 2, 2026

Copy link


Copy Markdown

ContributorAuthor
forward ported in #2215
@github-actionsgithub-actionsBot
mentioned this pull request
Jun 2, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@VaguelySeriousVaguelySeriousVaguelySerious approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@pranaygp@VaguelySerious

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[codex] Skip replay for terminal run events - #2214
Merged
pranaygp merged 2 commits into
stablefrom 
pranaygp/codex/fix-run-failed-replay
Jun 2, 2026
Merged
[codex] Skip replay for terminal run events#2214
pranaygp merged 2 commits into
stablefrom 
pranaygp/codex/fix-run-failed-replay
Conversation
@pranaygp
@pranaygppranaygp
commented
Jun 2, 2026

Copy link


Copy Markdown

Contributor
Summary
  • Skip workflow replay when the loaded event snapshot already contains a terminal run event (run_failed, run_cancelled, or run_completed).
  • Recheck for a terminal event after refreshing history following elapsed wait completion.
  • Add regression coverage for a running materialized run whose event log already records run_failed, plus a patch changeset for @workflow/core.
Root Cause
A replay invocation can observe a materialized run as running while its loaded event snapshot already contains run_failed. The runtime previously proceeded into runWorkflow(), where EventsConsumer had no consumer for that terminal event and reported it as REPLAY_DIVERGENCE, queueing recovery replays for an already-failed run.
Validation
  • pnpm --filter '@workflow/core...' build
  • pnpm changeset status --since=origin/stable
  • pnpm --dir packages/core exec vitest run src/runtime.test.ts src/runtime/wait-completion-replay.test.ts (11 passed)
  • git diff --check
  • pnpm exec biome check packages/core/src/runtime.ts packages/core/src/runtime.test.ts completed with the pre-existing cognitive-complexity warnings in packages/core/src/runtime.ts.
Additional Test Note
pnpm --dir packages/core test fails outside this diff in the untouched src/serialization.test.ts: seven DOMException serialization tests fail with DevalueError: Cannot stringify arbitrary non-POJOs.
@changeset-bot
changeset-botBot
commented
Jun 2, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: a7f337b
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
workflowPatch
@workflow/world-testingPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 2, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, CommentJun 2, 2026 4:00am
example-nextjs-workflow-webpackReadyReadyPreview, CommentJun 2, 2026 4:00am
example-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-astro-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-express-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-fastify-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-hono-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-nitro-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-nuxt-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-sveltekit-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-tanstack-start-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workbench-vite-workflowReadyReadyPreview, CommentJun 2, 2026 4:00am
workflow-swc-playgroundReadyReadyPreview, CommentJun 2, 2026 4:00am
workflow-tarballsReadyReadyPreview, CommentJun 2, 2026 4:00am
workflow-webReadyReadyPreview, CommentJun 2, 2026 4:00am
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
workflow-docsSkippedSkippedJun 2, 2026 4:00am
@github-actions
github-actionsBot
commented
Jun 2, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
🧪 E2E Test Results
❌ Some tests failed
Summary
PassedFailedSkippedTotal
❌ ▲ Vercel Production922167990
✅ 💻 Local Development9940861080
✅ 📦 Local Production9940861080
✅ 🐘 Local Postgres9940861080
✅ 🪟 Windows900090
❌ 🌍 Community Worlds136920228
✅ 📋 Other504036540
Total4634933615088
❌ Failed Tests
▲ Vercel Production (1 failed)
astro (1 failed):
🌍 Community Worlds (92 failed)
mongodb (14 failed):
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT37QKQQYVH3ADGWF0SVY1Y0
  • webhookWorkflow | wrun_01KT37QQYQT0YVNCYB23062G69
  • sleepingWorkflow | wrun_01KT37QYC80W3TM2CSHJVJWCJA
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KT37TZ14PVKGQSM4FJYKMZNA
  • writableForwardedFromWorkflowWorkflow | wrun_01KT37VCAAA2QF96BE5EHK2KNP
  • writableForwardedFromStepWorkflow | wrun_01KT37VGS6CSA06P809DJXCA6A
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT37ZT2C25MF5XS7TH8NWTN1
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT3862DTG9DVYKE6QB58T60T
redis (9 failed):
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT37QKQQYVH3ADGWF0SVY1Y0
  • sleepingWorkflow | wrun_01KT37QYC80W3TM2CSHJVJWCJA
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT37ZT2C25MF5XS7TH8NWTN1
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT3862DTG9DVYKE6QB58T60T
turso-dev (1 failed):
  • dev e2e should rebuild on imported step dependency change
turso (68 failed):
  • addTenWorkflow | wrun_01KT37PDX08NJK6TWZ7V9VEYMT
  • addTenWorkflow | wrun_01KT37PDX08NJK6TWZ7V9VEYMT
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KT37R1M73KQ4GH2EQV52Y0VG
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KT37PQ0E1MKJXTZ8QZ3WA007
  • promiseRaceWorkflow | wrun_01KT37PVJM5RNCCM1BGKYG4M96
  • promiseAnyWorkflow | wrun_01KT37PXX1V9TX0NGTKVCBH8SH
  • importedStepOnlyWorkflow | wrun_01KT37REF4YCP684J5PDMGY4HB
  • readableStreamWorkflow | wrun_01KT37Q03TQ46AN44PZYB4PR0B
  • hookWorkflow | wrun_01KT37QCAK29DQ3K7CJS93RMQT
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KT37QKQQYVH3ADGWF0SVY1Y0
  • webhookWorkflow | wrun_01KT37QQYQT0YVNCYB23062G69
  • sleepingWorkflow | wrun_01KT37QYC80W3TM2CSHJVJWCJA
  • parallelSleepWorkflow | wrun_01KT37RE0T944TEDMS63JB3WSM
  • nullByteWorkflow | wrun_01KT37RHZDEEC3V5QQNM82CET8
  • workflowAndStepMetadataWorkflow | wrun_01KT37RM497MBVPF5DFDQY15GD
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KT37TZ14PVKGQSM4FJYKMZNA
  • writableForwardedFromWorkflowWorkflow | wrun_01KT37VCAAA2QF96BE5EHK2KNP
  • writableForwardedFromStepWorkflow | wrun_01KT37VGS6CSA06P809DJXCA6A
  • fetchWorkflow | wrun_01KT37VMBRMXD5NTHK0G62976Y
  • promiseRaceStressTestWorkflow | wrun_01KT37VQQ100HMJ9G6VKWWY30W
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KT37ZCC9SFWTFE3GT3GHGG9P
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KT37ZT2C25MF5XS7TH8NWTN1
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KT380ASA3B3YH71ESE7TKF21
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KT380TY73PJMFK2WB6SW20X4
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KT38144AMRX81ZR28BBWJR0A
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KT381A641STKB0JT9M30515M
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KT381CE10BY0GYWMH6ZSQMD4
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KT381W5TMHRFYMW4HDY93DTH
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KT382217A0KW15CW0N89WC69
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KT3828YN7A2NQJ0YAR7FZHEE
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KT382FR63GR5CANAHP9PN960
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KT382NRBN5DBT2QKZSQH0BBF
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KT382WN12GNEMMBDDJVFZF8C
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KT3835D2E9F05FM67Q92Z38Z
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KT383KBG3791HGSWZVRKDAY4
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KT383WTM4P8NBRAJARACVW18
  • cancelRun - cancelling a running workflow | wrun_01KT3843SJMHCHXBP5AR25DM6P
  • cancelRun via CLI - cancelling a running workflow | wrun_01KT384D86RHR9BPTHH3NEAJA3
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KT384T8YZ0MRAW0FKFMRBPAN
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KT385AJ5XD3DG0XKCVNWM4CF
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KT385PSCFQK619TGT1DGV14F
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KT385XSF6SKPDJ5QEYBPM4K4
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KT386070DXTEBKMMKEF3CDXP
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KT3862DTG9DVYKE6QB58T60T
Details by Category
❌ ▲ Vercel Production
AppPassedFailedSkipped
❌ astro8217
✅ example8307
✅ express8307
✅ fastify8307
✅ hono8307
✅ nextjs-turbopack8802
✅ nextjs-webpack8802
✅ nitro8307
✅ nuxt8307
✅ sveltekit8307
✅ vite8307
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable8406
✅ express-stable8406
✅ fastify-stable8406
✅ hono-stable8406
✅ nextjs-turbopack-canary71019
✅ nextjs-turbopack-stable9000
✅ nextjs-webpack-canary71019
✅ nextjs-webpack-stable9000
✅ nitro-stable8406
✅ nuxt-stable8406
✅ sveltekit-stable8406
✅ vite-stable8406
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack9000
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev500
❌ mongodb57140
✅ redis-dev500
❌ redis6290
❌ turso-dev410
❌ turso3680
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable8406
✅ e2e-local-dev-tanstack-start-stable8406
✅ e2e-local-postgres-nest-stable8406
✅ e2e-local-postgres-tanstack-start-stable8406
✅ e2e-local-prod-nest-stable8406
✅ e2e-local-prod-tanstack-start-stable8406
📋 View full workflow run
❌ Some E2E test jobs failed:
  • Vercel Prod: failure
  • Local Dev: success
  • Local Prod: success
  • Local Postgres: success
  • Windows: success
Check the workflow run for details.
⚠️Community world tests failed (non-blocking):
  • Community Worlds: failure
Check the workflow run for details.
@pranaygp
pranaygp
marked this pull request as ready for review
June 2, 2026 03:13
@pranaygp
pranaygp
requested a review
from a team
as a code ownerJune 2, 2026 03:13
CopilotAI
review requested due to automatic review settings
June 2, 2026 03:13
CopilotAI
reviewed
Jun 2, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
This PR hardens the workflow runtime replay path by detecting terminal run events already present in the loaded event snapshot, preventing unnecessary (and potentially divergent) replays for runs whose outcome is already durably recorded.
Changes:
  • Add a replay guard that skips runWorkflow() when the loaded snapshot already contains a terminal run event (run_failed, run_cancelled, run_completed).
  • Re-check for terminal events after committing elapsed waits and refreshing the event snapshot.
  • Add a regression test for a running materialized run whose preloaded snapshot already includes run_failed, plus a patch changeset for @workflow/core.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
FileDescription
packages/core/src/runtime.tsAdds terminal-event detection to short-circuit replay both on initial snapshot load and after wait-completion refresh.
packages/core/src/runtime.test.tsAdds regression coverage to ensure runs with terminal events in the snapshot do not replay or queue recovery replays.
.changeset/terminal-run-event-replay.mdPublishes a patch changeset documenting the replay-skip behavior change for @workflow/core.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment threadpackages/core/src/runtime.ts
Comment threadpackages/core/src/runtime.test.ts
Comment threadpackages/core/src/runtime.ts
@pranaygppranaygp
mentioned this pull request
Jun 2, 2026
 Merged

@vercel
vercelBottemporarily deployed
to
Preview – workflow-docs
June 2, 2026 03:56
Inactive

@VaguelySerious
VaguelySerious
commented
Jun 2, 2026

Copy link


Copy Markdown

Member
Let's not forget to forward-port too
@pranaygp
pranaygp
merged commit e959124
into
stableJun 2, 2026

91 of 97 checks passed

@pranaygp
pranaygp
deleted the

pranaygp/codex/fix-run-failed-replay

branch
June 2, 2026 17:26
@pranaygp
pranaygp
commented
Jun 2, 2026

Copy link


Copy Markdown

ContributorAuthor
forward ported in #2215
@github-actionsgithub-actionsBot
mentioned this pull request
Jun 2, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@VaguelySeriousVaguelySeriousVaguelySerious approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@pranaygp@VaguelySerious