Uh oh!
There was an error while loading. Please reload this page.
[core] Fix process crash from rejected waitUntil promises - #2336
Merged
Conversation
Promises handed to waitUntil were rethrowing transient errors (e.g. a
network failure on POST /runs/{id}/events during suspension handling),
and since nothing consumes a waitUntil promise, the rejection surfaced
as an unhandledRejection and crashed the process. Introduce
safeWaitUntil() so background flush promises never reject; errors now
propagate through the awaited path so the queue re-drives the message.Contributor
🦋 Changeset detectedLatest commit: 2760e8a The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests▲ Vercel Production (1 failed)nitro (1 failed):
Details by Category❌ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
✅ 📋 Other
❌ Some E2E test jobs failed:
Check the workflow run for details. |
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 25 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 50 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.all with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.race with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro workflow with 10 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro workflow with 25 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 50 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 10 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 25 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 50 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express Stream Benchmarks(includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro stream pipeline with 5 transform steps (1MB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro 10 parallel streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) fan-out fan-in 10 streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
The aggregate is awaited on the next line, so the invocation already stays alive until the ops settle; Promise.all settles on first rejection, so the registration never kept sibling ops alive either.
Signed-off-by: Peter Wielander <mittgfu@gmail.com>
Contributor
Backport PR opened against |
This was referenced Jun 11, 2026
Merged
This was referenced Jun 11, 2026
This was referenced Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A workflow run crashed (
Node.js process exited with exit status: 128) when a transient network error (TypeError: terminated/SocketError: other side closed) causedPOST /v3/runs/{id}/eventsto fail during suspension handling. The error surfaced as an unhandled rejection instead of propagating to the queue handler.Root cause
Several call sites used this pattern:
Nothing consumes a
waitUntilpromise, so the rethrown error becomes anunhandledRejection→ process exit 128. In the suspension handler (the crash site), the same aggregate was also awaited on the next line — that copy already propagates the error to the queue handler so the queue re-drives the message; thewaitUntilcopy only added the crash.Changes
suspension-handler.ts(the crash site —step_created/wait_createdPOSTs): drop thewaitUntilregistration entirely. It was redundant: the immediately-followingawait Promise.all(ops)keeps the invocation alive until the ops settle, and sincePromise.allsettles on first rejection, the registration never kept sibling ops alive in the failure case either.safeWaitUntil()helper (packages/core/src/util.ts) that guarantees the promise given towaitUntilnever rejects:AbortError/ResponseAbortedare ignored, anything else is routed to anonErrorcallback and swallowed. Used by the sites below, wherewaitUntilis legitimately needed because the function can return before the ops settle:step-handler.ts,start.ts,resume-hook.ts: theirops(stream flushes) have no awaited copy, so failures are now logged viaruntimeLogger.warninstead of crashing.step-executor.ts: preserves inline error propagation through the 500msPromise.race(step still fails → retries) while thewaitUntilcopy logs instead of rejecting.Note: in-adapter retries for idempotent GET/HEAD body-parse failures already exist (
MAX_BODY_PARSE_RETRIESin world-vercel). The failing request here was a POST, where queue re-drive + server-side correlationId dedup is the designed retry path — this PR makes that path actually reachable instead of crashing first.Testing
runtime.test.tsreproducing the incident:PARSE_ERRORonstep_created→ asserts the handler invocation rejects (queue re-drive), norun_failedis recorded, and no promise handed towaitUntilrejects. Verified it fails against the old code.safeWaitUntilinutil.test.ts.pnpm typecheck,pnpm build, and allsrc/**unit tests pass (remaininge2e/*failures occur on a clean tree too — they require a running dev server).