Uh oh!
There was an error while loading. Please reload this page.
[core] Import waitUntil in resume-hook.ts to unblock tsc on stable - #2347
Closed
pranaygp wants to merge 1 commit into
Closed
[core] Import waitUntil in resume-hook.ts to unblock tsc on stable#2347pranaygp wants to merge 1 commit into
pranaygp wants to merge 1 commit into
Conversation
resume-hook.ts calls waitUntil at line 165 but only imported waitedUntil, so `tsc --noEmit` fails on a pristine stable checkout with TS2552. Import the lazy local waitUntil from ./wait-until.js (matching the file's existing fire-and-forget usage and avoiding a second static @vercel/functions import, so the runtime module-eval graph is unchanged). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 6fd8c72 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🧪 E2E Test ResultsNo test result files found. ❌ Some E2E test jobs failed:
Check the workflow run for details. |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a TypeScript typecheck failure on stable by adding the missing waitUntil import used in packages/core/src/runtime/resume-hook.ts, sourcing it from the local lazy wrapper to avoid introducing an additional static @vercel/functions import.
Changes:
- Import
waitUntilfrom./wait-until.jsinresume-hook.tsto resolveTS2552: Cannot find name 'waitUntil'. - Add a patch changeset for
@workflow/coredocumenting the fix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/runtime/resume-hook.ts | Adds the missing waitUntil import needed by existing waitUntil(Promise.all(ops)...) usage. |
| .changeset/stable-resume-hook-waituntil-import.md | Declares a patch bump for @workflow/core and documents the stable-branch typecheck unblock. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TooTallNate
commented
Jun 11, 2026
Member
Please see #2344 |
pranaygp
commented
Jun 11, 2026
ContributorAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
One-line fix:
packages/core/src/runtime/resume-hook.tscallswaitUntil(...)at line 165 but only importswaitedUntilfrom../util.js. On a pristinestablecheckout this fails type-checking:This PR adds the missing import, sourcing the lazy local
waitUntilfrom./wait-until.js(which defers@vercel/functionsviavoid import(...)). That matches the file's existing fire-and-forget usage and intentionally avoids adding a second static@vercel/functionsimport, so the runtime module-evaluation graph is unchanged.Why a separate PR
tsccurrently fails onstablebecause of this, which blocks CI for any PR targetingstable— including #2346. Keeping this isolated to a single line means it can land fast and unblock the others without entangling the durability fix.#2346 depends on this landing first (it can't go green on
stableCI untiltscis unblocked).Verification
pnpm --filter @workflow/core typecheck→ exit 0 with the import (clean).TS2552 ... Cannot find name 'waitUntil'atresume-hook.ts:165, exit 1; restoring it returns to exit 0.runtime-import.test.ts("does not load @vercel/functions during module evaluation") still fails for the pre-existing reason —src/util.ts:1's staticimport { waitUntil } from '@vercel/functions'— which is unrelated to this change and not made worse by it (this fix uses the lazy wrapper). That test failure is orthogonal and out of scope here.Related
[core] Never ack orchestrator message before step dispatch sends complete (stable). Depends on this PR to get a greentsconstable.🤖 Generated with Claude Code