Uh oh!
There was an error while loading. Please reload this page.
[codex] Guard release branch major versions - #2437
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 92759f6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Contributor
🧪 E2E Test Results✅ All tests passed Summary
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 📋 Other
❌ Some E2E test jobs failed:
Check the workflow run for details. |
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express workflow with 25 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 50 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.all with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express Promise.race with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 10 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 25 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express workflow with 50 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 10 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 25 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express workflow with 50 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Stream Benchmarks(includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) stream pipeline with 5 transform steps (1MB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) 10 parallel streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) fan-out fan-in 10 streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
karthikscale3force-pushed
the
codex/prevent-ai-peer-major-bumps
branch
from
June 15, 2026 21:54
d4c3cff to
239f578Comparekarthikscale3
marked this pull request as ready for review
June 15, 2026 21:55
karthikscale3force-pushed
the
codex/prevent-ai-peer-major-bumps
branch
from
June 15, 2026 22:30
28830d9 to
34b989cCompare| cache: "pnpm" | ||
| registry-url: 'https://registry.npmjs.org' | ||
| - name: Check for unexpected package major version bumps |
Contributor
There was a problem hiding this comment.
does this actually work? as in - will the script be able to detect the future major versions BEFORE pnpm ci:version is run? I thought that command had to run first before the new major version would appear in the package.json files that this script is trying to find and for detection
Contributor
There was a problem hiding this comment.
I think there's a changeset cli command you can just run (changeset status maybe) that gives you the version numbers - and it can use that to detect the versions in the repo and fail on that
Contributor
There was a problem hiding this comment.
i also don't understand why we're comparing refs and doing PUSH_BEFORE? we should simply fail CI if the branch actively has any workflow package versions that doesn't match the hardcoded major version number
ContributorAuthor
There was a problem hiding this comment.
yeah, using changeset CLI is better. Will update it
ContributorAuthor
There was a problem hiding this comment.
codex: Updated this to remove the ref comparison / PUSH_BEFORE path entirely. The release job now runs node .github/scripts/check-release-major.js "$RELEASE_VERSION" against the checked-out branch before changesets/action, and that script fails if any public, non-ignored workspace package has a major version that does not match the branch-local RELEASE_VERSION. I also renamed the guard/tests, added coverage for ignored/private packages, reran the focused checks, and updated the PR title/description to match.
ContributorAuthor
There was a problem hiding this comment.
codex: I didn’t switch this guard to the Changesets CLI because the thing we need to block is publish, not creation of the Version Packages PR. By the time the release workflow is on the publish path, package.json has already been versioned, so checking the checked-out package manifests against branch-local RELEASE_VERSION is enough and simpler. changeset status would be useful if we also wanted to block producing a bad Version Packages PR earlier, but it isn’t needed to prevent publishing.
Contributor
There was a problem hiding this comment.
already done upstream so this change should go away once you update branch
| --- | ||
| --- | ||
| Only major-bump peer dependents when updated workspace peer ranges fall out of range, and block release publishes that contain package major version upgrades outside the branch's release major. |
Contributor
There was a problem hiding this comment.
this changeset is a noop but that's ok
pranaygp
approved these changes
Jun 15, 2026
Contributor
Backport to This is usually an infrastructure problem (e.g. the configured AI model could not be found, an AI Gateway error, or an opencode crash) rather than a merge conflict. Check the job logs linked above for details. Once the underlying issue is fixed, re-run the Backport to stable workflow manually via |
Contributor
Backport to This is usually an infrastructure problem (e.g. the configured AI model could not be found, an AI Gateway error, or an opencode crash) rather than a merge conflict. Check the job logs linked above for details. Once the underlying issue is fixed, re-run the Backport to stable workflow manually via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RELEASE_VERSIONconstant.RELEASE_VERSION: 5onmain; the stable backport should set it to4.Why
Stable release PR #2352 bumped
@workflow/aifrom6.0.0to7.0.0even though@workflow/aionly received aworkflowpeer dependency update. Changesets does this by default for peer dependents when the peer has a non-patch release, even if the new version is still within the peer range.The Changesets config change prevents that dependency-only major bump class. The release workflow guard is the final lock: before
changesets/actioncan publish, it checks the packages in the checked-out branch and fails if any public, non-ignored workspace package has a major version that does not matchRELEASE_VERSION.Implementation
.changeset/config.jsonopts intoonlyUpdatePeerDependentsWhenOutOfRange..github/scripts/check-release-major.jsreadspackages/*/package.json, skips private and Changesets-ignored packages, and fails on package versions outside the configured release major..github/workflows/release.ymlruns that script before dependency installation and before the Changesets publish step.Validation
node --test .github/scripts/check-release-major.test.jspnpm exec biome check .github/scripts/check-release-major.js .github/scripts/check-release-major.test.js .github/workflows/release.yml .changeset/avoid-peer-major-bumps.md .changeset/config.jsonnode .github/scripts/check-release-major.js 5node .github/scripts/check-release-major.js 4fails as expected on this v5 branch.workflow 4.4.0 -> 4.5.0no longer bumps@workflow/ai, whileworkflow 4.4.0 -> 5.0.0still bumps@workflow/ai.Backport
Backport this to
stable, but setRELEASE_VERSION: 4in.github/workflows/release.ymlon the stable branch.