Uh oh!
There was an error while loading. Please reload this page.
Backport #2397: fix(core): make deploymentId 'latest' a no-op in non-Vercel worlds - #2464
Merged
Conversation
…2397) * fix(core): make deploymentId 'latest' a no-op in non-Vercel worlds Previously, start({ deploymentId: 'latest' }) threw a WorkflowRuntimeError in any World that doesn't implement resolveLatestDeploymentId() (local dev, Postgres). That meant a workflow which opts into 'latest' on Vercel would fail outright in local development. Resolving 'latest' only means something in worlds with atomic, immutable deployments. In other worlds there is nothing to resolve between, so instead of throwing we now log a warning and fall back to the current deployment, making 'latest' an effective no-op there. - start.ts: warn + fall back to currentDeploymentId instead of throwing - start.test.ts: replace the "should throw" test with a warn + fallback test - e2e.test.ts: assert 'latest' completes (no-op) on non-Vercel worlds - docs: note the no-op behavior in v4 + v5 start.mdx Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(core): warn once for deploymentId 'latest' no-op; harden test cleanup Address PR review: - Gate the 'latest'-has-no-effect warning behind a once-per-process guard (mirrors the warnOnce pattern in constants.ts) so a workflow that hardcodes 'latest' for Vercel doesn't flood local/Postgres dev logs on every run. Exposes _resetLatestNoOpWarnForTests() (@internal) for unit tests. - start.test.ts: reset the guard in beforeEach and restore spies in afterEach via vi.restoreAllMocks() so a throwing assertion can't leak the runtimeLogger.warn spy into later tests; drop the manual mockRestore(). - Add a test asserting the warning fires exactly once across repeated 'latest' starts while every run still falls back to the current deployment. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Pranay Prakash <pranay.gp@gmail.com>
🦋 Changeset detectedLatest commit: f07d17d The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated backport of #2397 to
stable(backport job run).AI recommendation: This is a self-contained bug fix to existing functionality that is present on
stable— thedeploymentId === 'latest'throw-on-unsupported-world logic inpackages/core/src/runtime/start.tsexists verbatim onstable(lines 169-175). The change converts the hard failure into a warn-and-fallback no-op so workflows that use'latest'for Vercel still run in local/Postgres dev, and the accompanying test, e2e, anddocs/content/updates all apply equally tostable.Merge conflicts were resolved by AI (opencode with
anthropic/claude-opus-4.8). Please review the conflict resolution carefully before merging.