Uh oh!
There was an error while loading. Please reload this page.
ci: run multi-worker exactly-once test in e2e-restart-recovery (postgres) - #2571
Open
pranaygp wants to merge 1 commit into
Open
ci: run multi-worker exactly-once test in e2e-restart-recovery (postgres)#2571pranaygp wants to merge 1 commit into
pranaygp wants to merge 1 commit into
Conversation
…ostgres) Enable MULTIWORKER_RECOVERY_TEST on the postgres entry of the e2e-restart-recovery job so the multi-worker guarantee test runs in CI. It boots a second worker while a step is in flight on the first and asserts the step body executes exactly once (no duplicate from reenqueueActiveRuns). The local matrix entry skips it via the test's own world gate. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Contributor
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests▲ Vercel Production (1 failed)vite (1 failed):
Details by Category❌ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
✅ 📋 Other
❌ Some E2E test jobs failed:
Check the workflow run for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #2544.
What
Enables
MULTIWORKER_RECOVERY_TEST=1on the postgres entry of thee2e-restart-recoveryjob so the multi-worker exactly-once guarantee test (added in #2544, currently gated off CI) runs in CI.The test it wires up
packages/core/e2e/restart-recovery.test.ts→ "a worker booting does not re-run a step already executing on another worker":sideEffectStepWorkflow); the step records each execution of its body to a shared side-effect log.ensureWorldStarted → reenqueueActiveRuns) re-drives all active runs, including this healthy one.It asserts the step body executes exactly once — proving boot-time recovery does not duplicately execute a step that's healthily in-flight on another worker (the
correlationIdidempotency key + the step's terminal-state guard hold even when another worker re-enqueues the run).Why postgres-only
The duplicate-execution concern only applies to a shared DB + graphile-worker pool. The local matrix entry skips the test via its own world gate (
WORKFLOW_TARGET_WORLD === '@workflow/world-postgres'), so this only affects the postgres entry.Verification
Run locally against a postgres container:
Test passes, VITEST EXIT 0 (robust process-group + lsof teardown so the worker exits cleanly). Adds ~25s + a second server to the postgres entry.
🤖 Generated with Claude Code