Uh oh!
There was an error while loading. Please reload this page.
Backport #2334: [core] Retry stream reopen against the reconnect budget - #2574
Merged
Conversation
Signed-off-by: Peter Wielander <mittgfu@gmail.com>
|
Contributor
Uh oh!
There was an error while loading. Please reload this page.
…s.get`) that don't exist on the stable branch, causing a compile error and a broken test.
This commit fixes the issue reported at packages/core/src/reconnecting-framed-stream.test.ts:212
## Bug
The test `"retries the reopen itself against the budget instead of failing fatally"` (added at `packages/core/src/reconnecting-framed-stream.test.ts:175`) was backported from `main` without adapting it to the `stable` branch API. Two concrete mismatches:
1. **Undeclared identifier `RUN_ID`** — The test called:
```ts
const stream = createReconnectingFramedStream(RUN_ID, 's', 0);
```
`RUN_ID` is never imported or declared anywhere in the file. This is a hard TypeScript compile error (`Cannot find name 'RUN_ID'`) and would be a runtime `ReferenceError`. On the stable branch the signature is `createReconnectingFramedStream(name: string, startIndex?: number)` — no `runId` parameter.
2. **Wrong world mock shape** — The test built a world mock exposing `world.streams.get(runId, name, startIndex)`, but the stable `connect()` calls `world.readFromStream(name, effectiveStartIndex)` (verified in `serialization.ts`). So `world.readFromStream` would be `undefined` and `connect()` would throw, never exercising the intended reopen-retry path.
## Fix
Rewrote the test to match the stable API, matching the existing `makeWorldWithScriptedStreams` pattern used by every other test in the file:
- Mock `readFromStream(_name, startIndex)` instead of `streams.get(...)`.
- Call `createReconnectingFramedStream('s', 0)` (2-arg form).
The test's intent is preserved: index 0 delivers two frames then errors; the first reopen at index 2 throws transiently; the second reopen succeeds. Assertions remain `chunks === [1, 2, 3]` and `calls === [0, 2, 2]`.
This matches the stable `reconnect()` implementation, which retries `connect()` against the reconnect budget — so `readFromStream` is called with `2` twice (failed reopen + successful retry), yielding `[0, 2, 2]`.
Co-authored-by: Vercel <vercel[bot]@users.noreply.github.com>
Co-authored-by: VaguelySerious <mittgfu@gmail.com>ContributorAuthor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests🌍 Community Worlds (99 failed)redis (19 failed):
turso (80 failed):
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
✅ 📋 Other
|
VaguelySerious
approved these changes
Jun 22, 2026
VaguelySerious
enabled auto-merge (squash)
June 22, 2026 22:00
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated backport of #2334 to
stable(backport job run).AI recommendation: This is a self-contained bug fix to
createReconnectingFramedStreaminpackages/core/src/serialization.ts, which exists onstablewith the samereconnect()budget structure. It hardens the existing reconnect path to retry a transientconnect()failure against the reconnect budget instead of failing fatally, and the PR notes the same sequencing applies to the stable line (#1847), so it applies cleanly to functionality present onstable.