Uh oh!
There was an error while loading. Please reload this page.
Fix compressed workflow error display - #2680
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 7008938 The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) workflow with 25 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) workflow with 50 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) Promise.all with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) Promise.race with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express workflow with 10 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) workflow with 25 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) workflow with 50 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) workflow with 10 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) workflow with 25 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) workflow with 50 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) Stream Benchmarks(includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) stream pipeline with 5 transform steps (1MB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) 10 parallel streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) fan-out fan-in 10 streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
❌ Some benchmark jobs failed:
Check the workflow run for details. |
Contributor
🧪 E2E Test Results✅ All tests passed Summary
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
✅ 📋 Other
|
karthikscale3force-pushed
the
kk/zstd-error-display
branch
from
June 26, 2026 23:45
44457f4 to
0ef61c2Compare
karthikscale3
marked this pull request as ready for review
June 27, 2026 00:33
Address review feedback on the compressed-data fix: - world-vercel: keep gzip/zstd decompression on the o11y/display read paths (getStep/getRun/getEvent/getWorkflowRunEvents/getHook) but not on the runtime event-append path (world.events.create, createStep, updateStep). That path is runtime-only and re-hydrates every payload via the decompress-aware helpers, so decompressing at the adapter was redundant work on the TTFB-sensitive run_started/inline-delta path and skewed the runtime's deserialize compression telemetry to `codec: none`. deserializeStep is now shape-only; normalizeStepData runs in the read filter. Adds a regression test pinning the write-path pass-through. - serialized-data: drop dead `errorRef`/`metadataRef` normalization (refs are descriptor objects, never compressed byte payloads). - web: in the wait-entity path, filter events by correlationId before hydrating so an encryption key doesn't decrypt the whole event page. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
VaguelySerious
approved these changes
Jun 29, 2026
Contributor
No backport to This fixes display of To override, re-run the Backport to stable workflow manually via |
This was referenced Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
world-vercelnormalization for gzip- and zstd-prefixed serialized run, step, hook, and v4 event payloads returned from storage.hydrateResourceIOAsync(resource, key?)in@workflow/web-shared; it registers the zstd WASM decoder and hydrates compressed data with or without an encryption key.run_started.inputandstep_started.input.Why
The regression came from compressed serialized payloads being surfaced as raw bytes. A failed step error could be stored as
zstd(devl(...)); when the resolved payload reached display code without being decompressed, the UI renderedUint8Array(...)instead of the hydrated error.Front encrypted payloads are shaped as
encr(zstd(devl(...))), so they must stay encrypted until the browser has the run key. After decryption, the existing web zstd WASM decoder can inflate the inner payload.OSS/local web can use that same decoder too, but it was using the synchronous
hydrateResourceIOpath when no encryption key was present. That path cannot await WASM, so unencrypted compressed payloads needed an async resource hydration path as well.How this fixes it
world-vercelnow decompresses gzip/zstd wrappers at the adapter boundary for server/direct SDK consumers, while leaving encryptedencr(...)payloads untouched.hydrateResourceIOAsyncuseshydrateDataWithKey(..., key | undefined), which already knows how to decrypt when a key exists and decompress gzip/zstd afterward.hydrateResourceIOAsyncfor payload-bearing resources/events, so browser zstd inflation works even without encryption.Validation
pnpm --filter @workflow/world-vercel exec vitest run src/steps.test.tspnpm --filter @workflow/world-vercel typecheckpnpm --filter @workflow/world-vercel testpnpm --filter @workflow/web-shared exec vitest run test/hydration.test.tspnpm --filter @workflow/web-shared typecheckpnpm --filter @workflow/web-shared testpnpm --filter @workflow/web testpnpm --filter @workflow/web-shared buildpnpm --filter @workflow/web buildNotes:
world-vercelsuite needs permission to bind a local HTTP/2 server on127.0.0.1; the sandboxed run fails withlisten EPERM, and the elevated run passes.pnpm exec biome check ...exits successfully for the touched files, with existing warnings in large pre-existing files (events.ts,hydration.ts,run-detail-view.tsx, anduse-events-list-data.ts).