Uh oh!
There was an error while loading. Please reload this page.
Fix Workflow loader source map warnings - #2693
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 954849a The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Contributor
🧪 E2E Test Results✅ All tests passed Summary
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
✅ 📋 Other
|
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 25 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 50 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Promise.all with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.race with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 10 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 25 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 50 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 10 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 25 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 50 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Stream Benchmarks(includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) stream pipeline with 5 transform steps (1MB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) 10 parallel streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) fan-out fan-in 10 streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
ijjkforce-pushed
the
ijjk/workflow-sourcemap-warning-node-modules
branch
from
June 29, 2026 18:55
6512b01 to
f151173Compareijjk
marked this pull request as ready for review
June 29, 2026 19:41
ijjk
enabled auto-merge (squash)
June 29, 2026 19:50
TooTallNate
approved these changes
Jun 29, 2026
TooTallNate
left a comment
Member
There was a problem hiding this comment.
Approve — correctly-scoped source-map-warning fix
The root cause is right: the workflow loader declared sourceMaps: true / inputSourceMap: <upstream> for every transformed file, so node_modules files that carry a dangling sourceMappingURL but no readable .map produced SWC "failed to read input source map" warnings. getLoaderSourceMapOptions disables emission (sourceMaps: false, inputSourceMap: false, inlineSourcesContent: false) for node_modules paths while keeping full maps for app code — exactly the right split (you want maps where you debug, not in deps).
What I verified:
- The
isNodeModulesPathregex is correct under pnpm and Windows. Ran it against the layouts that matter —node_modules/.pnpm/pkg@1/node_modules/pkg/dist/x.js(true),C:\proj\node_modules\pkg(true), and the false-positive trapsmy_node_modules_helper/node_modulesly(both correctly false). The(?:^|[/\\])...(?:[/\\]|$)boundary anchoring handles all of them. - Subtle but intentional: even for app files with no upstream map,
inputSourceMapis nowfalserather thannull/undefined— explicitly disabling SWC's implicit input-map loading, which is what suppresses the warning on the app path too, not just node_modules. Good catch. - Downstream
transformedMaphandling stays safe: when emission is off,result.mapis absent sotransformedMapfalls back to the original input (undefined for typical node_modules) — no broken/mismatched map is emitted. - Test coverage is exactly the three cases (app-with-map, app-without-map, node_modules-with-map), including the realistic pnpm nested path. Loader unit suite green locally (3 tests).
- The e2e regression is the strong part:
dev.test.tsbuilds a node_modules fixture with a danglingsourceMappingURLcomment and no.map(the precise warning trigger), then reads the captured dev-server log and assertsfailed to read input source mapis absent. It no-ops gracefully whenDEV_SERVER_LOG_PATHis unset (local), so no spurious local failures, real CI coverage. The CI change wiring dev/prod server logs viateeto*_SERVER_LOG_PATHis what feeds it, and also lands the orthogonal "capture prod server logs for route-failure diagnosis" improvement.
Changeset correctly scoped (@workflow/next patch). Built @workflow/next. LGTM.
Contributor
Backport to This is usually an infrastructure problem (e.g. the configured AI model could not be found, an AI Gateway error, or an opencode crash) rather than a merge conflict. Check the job logs linked above for details. Once the underlying issue is fixed, re-run the Backport to stable workflow manually via |
This was referenced Jun 30, 2026
NathanColosimo added a commit
that referenced
this pull request
Jul 14, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs vercel/next.js#95255
Testing