Uh oh!
There was an error while loading. Please reload this page.
change timing markers to be precise on the timeline - #2775
Merged
Conversation
🦋 Changeset detectedLatest commit: 53f0baf The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
karthikscale3
approved these changes
Jul 6, 2026
…ts two-decimal output ("45.20s", "1m 0.00s") that no longer matches the trimmed-zero output of `formatDurationPrecise`, so `pnpm test`/CI fails.
This commit fixes the issue reported at packages/web-shared/test/format-duration-precise.test.ts:15
## Bug
The PR changed `formatDurationPrecise` (in `packages/web-shared/src/lib/utils.ts`) to trim trailing zeros by wrapping the fractional value in `Number(x.toFixed(fractionDigits))`:
```ts
if (normalizedMs < MS_IN_MINUTE) {
return `${Number((normalizedMs / MS_IN_SECOND).toFixed(fractionDigits))}s`;
}
...
parts.push(`${Number(seconds.toFixed(fractionDigits))}s`);
```
`Number("45.20")` → `45.2`, `Number("0.00")` → `0`, so whole/half seconds now render without padding.
A new test file `packages/web-shared/src/lib/utils.test.ts` reflects this behavior, but the pre-existing `packages/web-shared/test/format-duration-precise.test.ts` was left untouched and still asserts the **old** padded output.
## Concrete trigger
Reproduced the actual function output (integer decomposition + trimmed zeros):
| Input | Old assertion | New actual output |
|-------|---------------|-------------------|
| `45200` | `45.20s` | `45.2s` |
| `999.6` | `1.00s` | `1s` |
| `999.5` | `1.00s` | `1s` |
| `59999` | `1m 0.00s` | `1m 0s` |
| `59995` | `1m 0.00s` | `1m 0s` |
| `119999` | `2m 0.00s` | `2m 0s` |
| `3659999` | `1h 1m 0.00s` | `1h 1m 0s` |
| `86459999` | `1d 1m 0.00s` | `1d 1m 0s` |
The root `vitest.config.ts` uses default include globs, so `test/*.test.ts` runs and these assertions fail, breaking CI. (I couldn't run vitest directly in the sandbox because dev deps weren't installed / `vitest/config` unresolved, so I reproduced the exact function logic in a standalone Node script to confirm the outputs.)
## Fix
Updated the stale assertions in `test/format-duration-precise.test.ts` to the trimmed-zero outputs, and adjusted the file-level doc comment (which referenced `"1m 0.00s"` / `"60.00s"`) to describe the current behavior.
Co-authored-by: Vercel <vercel[bot]@users.noreply.github.com>
Co-authored-by: mitul-s <mitulxshah@gmail.com>Uh oh!
There was an error while loading. Please reload this page.
Contributor
No backport to This commit builds entirely on To override, re-run the Backport to stable workflow manually via |
This was referenced Jul 6, 2026
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes the timing labels on the trace viewer timeline precise when zoomed in.
When the timeline is zoomed in far enough that the ruler's tick step drops below one second, the tick labels were formatted with whole-second precision. This produced duplicate, imprecise labels — e.g. a ~3s window with a 500ms step rendered
0s, 1s, 1s, 2s, 2s, 3sinstead of distinct values. This PR scales each label's decimal precision to the tick step so every tick reads accurately.Changes
computeTimeMarkers(new-trace-viewer/utils.ts) — derivefractionDigitsfrom the tick interval. Steps>= 1skeep clean whole-second labels; sub-second steps use enough decimals to stay distinct (e.g.500ms,1.5s,2.5s).formatDurationPrecise(lib/utils.ts)fractionDigitsargument (default2) that controls both the number of decimals and the rounding granularity.2.00s→2sand1.50s→1.5s, while sub-second detail is preserved (1626ms→1.63s, never2s).Intl.NumberFormathelper in favor oftoFixed(fractionDigits).formatDurationtoformatDurationPreciseso gap durations and the hovered-time indicator show the same precise values.Tests
computeTimeMarkerstests covering sub-second, whole-second, and millisecond-zoom windows, asserting labels are distinct.formatDurationPrecisetests for millisecond values, sub-second precision, trailing-zero trimming, the customfractionDigitsargument, and minute-plus decomposition.Changeset
Patch release for
@workflow/web-shared.