Centralize workflow event semantics - #2790

Merged
NathanColosimo merged 10 commits into
mainfrom
codex/centralize-event-semantics
Jul 10, 2026
Merged

Centralize workflow event semantics#2790
NathanColosimo merged 10 commits into
mainfrom
codex/centralize-event-semantics

Conversation

@NathanColosimo

@NathanColosimoNathanColosimo commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add targeted event type helpers and lifecycle classifiers in @workflow/world
  • centralize eventData ref/payload field lookup for lazy-start and v4 split handling
  • replace duplicated event/status groups across local, postgres, vercel, web-shared, web, and CLI

Tests

  • ./node_modules/.bin/tsc -p packages/world/tsconfig.json
  • ./node_modules/.bin/tsc -p packages/world-local/tsconfig.json --noEmit
  • ./node_modules/.bin/tsc -p packages/world-postgres/tsconfig.json --noEmit
  • cd packages/world-vercel && ./node_modules/.bin/genversion --es6 src/version.ts && ../../node_modules/.bin/tsc --noEmit
  • ./node_modules/.bin/tsc -p packages/web-shared/tsconfig.json --noEmit
  • ./node_modules/.bin/tsc -p packages/cli/tsconfig.json --noEmit
  • cd packages/world-vercel && ../../node_modules/.bin/vitest run src event
  • cd packages/world-local && ../../node_modules/.bin/vitest run src
  • cd packages/web-shared && ../../node_modules/.bin/vitest run

@changeset-bot

changeset-botBot commented Jul 6, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0b57804

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@workflow/worldMinor
@workflow/corePatch
@workflow/world-localPatch
@workflow/world-postgresPatch
@workflow/world-vercelPatch
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/cliPatch
@workflow/vitestPatch
@workflow/world-testingPatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/nitroPatch
workflowPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/nuxtPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actionsBot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 0b57804 · Thu, 09 Jul 2026 22:23:47 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1266 (+26%)1678 🔴1789 🔴1941 🔴30
TTFShook + stream1509 (+21%)1923 🔴1967 🔴2116 🔴30
STSO1020 steps (1-20)296 (+24%)319 🔴451 🔴500 🔴19
STSO1020 steps (101-120)408 (+0.7%)449 🔴470 🔴548 🔴19
STSO1020 steps (1001-1020)1037 (±0%)953 🔴1274 🔴3804 🔴19
WOstream1266 (+26%)16781789194130
WOhook + stream1509 (+21%)19231967211630
SLstream4132 (-14%)5093 🔴5650 🔴6056 🔴30
SLhook + stream5130 (+2.7%)5733 🔴5821 🔴5961 🔴30
📜 Previous results (1)

b670eda

Thu, 09 Jul 2026 00:30:42 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream23063291 🔴3760 🔴4941 🔴30
TTFShook + stream15481929 🔴2057 🔴2141 🔴30
STSO1020 steps (1-20)274307 🔴368 🔴450 🔴19
STSO1020 steps (101-120)423499 🔴528 🔴546 🔴19
STSO1020 steps (1001-1020)824850 🔴959 🔴969 🔴19
WOstream230632913760494130
WOhook + stream154819292057214130
SLstream43774879 🔴5593 🔴7929 🔴30
SLhook + stream48115405 🔴5592 🔴5881 🔴30

Avg deltas compare against the most recent benchmark run on main at the time of this run.

Metrics — TTFS: time to first step body execution · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (time outside step bodies, client start → last step body exit) · SL: stream latency (first chunk write → visible to the reader)

Scenarios — stream: one step that streams chunks back to the client; no hooks, so the run stays in turbo mode · hook + stream: registers a hook before the same streaming step, which exits turbo mode · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges

🟢/🔴 mark percentiles within/above target. Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

TTFS/WO compare client vs deployment clocks and SL compares the step runner’s clock vs the client’s (NTP-synced in CI). WO ends at the last step body exit, the closest observable proxy for the final step-completion request.

@NathanColosimo
NathanColosimoforce-pushed the codex/centralize-event-semantics branch from dd190fb to 394f4c2CompareJuly 6, 2026 22:19
@github-actions

github-actionsBot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production145302301683
✅ 💻 Local Development161702191836
✅ 📦 Local Production161702191836
✅ 🐘 Local Postgres161702191836
✅ 🪟 Windows15300153
✅ 📋 Other89401771071
Total7351010648415

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126027
✅ example126027
✅ express126027
✅ fastify126027
✅ hono126027
✅ nextjs-turbopack15003
✅ nextjs-webpack15003
✅ nitro126027
✅ nuxt126027
✅ sveltekit14508
✅ vite126027
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15300
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128025
✅ e2e-local-dev-tanstack-start-128025
✅ e2e-local-postgres-nest-stable128025
✅ e2e-local-postgres-tanstack-start-128025
✅ e2e-local-prod-nest-stable128025
✅ e2e-local-prod-tanstack-start-128025
✅ e2e-vercel-prod-tanstack-start126027

📋 View full workflow run

…t-semantics
# Conflicts:
#	packages/cli/src/commands/cancel.ts
…t-semantics
# Conflicts:
#	packages/web-shared/src/components/sidebar/entity-detail-panel.tsx
…t-semantics
# Conflicts:
#	packages/world-local/src/storage/hooks-storage.ts

@VaguelySeriousVaguelySerious left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

human review, ai tbd

Comment threadpackages/cli/src/lib/inspect/hydration.ts

@VaguelySeriousVaguelySerious left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI review: no blocking issues.

This pass only flags possible behavior changes introduced by the event-semantics centralization. None are clearly incorrect, but each is a semantic shift from the code it replaced and worth a maintainer's confirmation. See inline notes.

Comment threadpackages/world/src/events.ts
Comment threadpackages/world/src/events.ts Outdated
Comment threadpackages/world/src/events.ts Outdated
Comment threadpackages/core/src/serialization-format.ts
Comment threadpackages/cli/src/lib/inspect/hydration.ts
Comment threadpackages/web-shared/src/lib/event-materialization.ts
Comment threadpackages/web-shared/src/components/sidebar/events-list.tsx
Comment threadpackages/web-shared/src/components/sidebar/events-list.tsx
Comment threadpackages/web-shared/src/components/sidebar/events-list.tsx
Comment threadpackages/web/app/components/run-detail-view.tsx
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@NathanColosimo@VaguelySerious
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Centralize workflow event semantics - #2790

Merged
NathanColosimo merged 10 commits into
mainfrom
codex/centralize-event-semantics
Jul 10, 2026
Merged

Centralize workflow event semantics#2790
NathanColosimo merged 10 commits into
mainfrom
codex/centralize-event-semantics

Conversation

@NathanColosimo

@NathanColosimoNathanColosimo commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add targeted event type helpers and lifecycle classifiers in @workflow/world
  • centralize eventData ref/payload field lookup for lazy-start and v4 split handling
  • replace duplicated event/status groups across local, postgres, vercel, web-shared, web, and CLI

Tests

  • ./node_modules/.bin/tsc -p packages/world/tsconfig.json
  • ./node_modules/.bin/tsc -p packages/world-local/tsconfig.json --noEmit
  • ./node_modules/.bin/tsc -p packages/world-postgres/tsconfig.json --noEmit
  • cd packages/world-vercel && ./node_modules/.bin/genversion --es6 src/version.ts && ../../node_modules/.bin/tsc --noEmit
  • ./node_modules/.bin/tsc -p packages/web-shared/tsconfig.json --noEmit
  • ./node_modules/.bin/tsc -p packages/cli/tsconfig.json --noEmit
  • cd packages/world-vercel && ../../node_modules/.bin/vitest run src event
  • cd packages/world-local && ../../node_modules/.bin/vitest run src
  • cd packages/web-shared && ../../node_modules/.bin/vitest run

@changeset-bot

changeset-botBot commented Jul 6, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0b57804

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@workflow/worldMinor
@workflow/corePatch
@workflow/world-localPatch
@workflow/world-postgresPatch
@workflow/world-vercelPatch
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/cliPatch
@workflow/vitestPatch
@workflow/world-testingPatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/nitroPatch
workflowPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/nuxtPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actionsBot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 0b57804 · Thu, 09 Jul 2026 22:23:47 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1266 (+26%)1678 🔴1789 🔴1941 🔴30
TTFShook + stream1509 (+21%)1923 🔴1967 🔴2116 🔴30
STSO1020 steps (1-20)296 (+24%)319 🔴451 🔴500 🔴19
STSO1020 steps (101-120)408 (+0.7%)449 🔴470 🔴548 🔴19
STSO1020 steps (1001-1020)1037 (±0%)953 🔴1274 🔴3804 🔴19
WOstream1266 (+26%)16781789194130
WOhook + stream1509 (+21%)19231967211630
SLstream4132 (-14%)5093 🔴5650 🔴6056 🔴30
SLhook + stream5130 (+2.7%)5733 🔴5821 🔴5961 🔴30
📜 Previous results (1)

b670eda

Thu, 09 Jul 2026 00:30:42 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream23063291 🔴3760 🔴4941 🔴30
TTFShook + stream15481929 🔴2057 🔴2141 🔴30
STSO1020 steps (1-20)274307 🔴368 🔴450 🔴19
STSO1020 steps (101-120)423499 🔴528 🔴546 🔴19
STSO1020 steps (1001-1020)824850 🔴959 🔴969 🔴19
WOstream230632913760494130
WOhook + stream154819292057214130
SLstream43774879 🔴5593 🔴7929 🔴30
SLhook + stream48115405 🔴5592 🔴5881 🔴30

Avg deltas compare against the most recent benchmark run on main at the time of this run.

Metrics — TTFS: time to first step body execution · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (time outside step bodies, client start → last step body exit) · SL: stream latency (first chunk write → visible to the reader)

Scenarios — stream: one step that streams chunks back to the client; no hooks, so the run stays in turbo mode · hook + stream: registers a hook before the same streaming step, which exits turbo mode · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges

🟢/🔴 mark percentiles within/above target. Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

TTFS/WO compare client vs deployment clocks and SL compares the step runner’s clock vs the client’s (NTP-synced in CI). WO ends at the last step body exit, the closest observable proxy for the final step-completion request.

@NathanColosimo
NathanColosimoforce-pushed the codex/centralize-event-semantics branch from dd190fb to 394f4c2CompareJuly 6, 2026 22:19
@github-actions

github-actionsBot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production145302301683
✅ 💻 Local Development161702191836
✅ 📦 Local Production161702191836
✅ 🐘 Local Postgres161702191836
✅ 🪟 Windows15300153
✅ 📋 Other89401771071
Total7351010648415

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126027
✅ example126027
✅ express126027
✅ fastify126027
✅ hono126027
✅ nextjs-turbopack15003
✅ nextjs-webpack15003
✅ nitro126027
✅ nuxt126027
✅ sveltekit14508
✅ vite126027
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15300
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128025
✅ e2e-local-dev-tanstack-start-128025
✅ e2e-local-postgres-nest-stable128025
✅ e2e-local-postgres-tanstack-start-128025
✅ e2e-local-prod-nest-stable128025
✅ e2e-local-prod-tanstack-start-128025
✅ e2e-vercel-prod-tanstack-start126027

📋 View full workflow run

…t-semantics
# Conflicts:
#	packages/cli/src/commands/cancel.ts
…t-semantics
# Conflicts:
#	packages/web-shared/src/components/sidebar/entity-detail-panel.tsx
…t-semantics
# Conflicts:
#	packages/world-local/src/storage/hooks-storage.ts

@VaguelySeriousVaguelySerious left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

human review, ai tbd

Comment threadpackages/cli/src/lib/inspect/hydration.ts

@VaguelySeriousVaguelySerious left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI review: no blocking issues.

This pass only flags possible behavior changes introduced by the event-semantics centralization. None are clearly incorrect, but each is a semantic shift from the code it replaced and worth a maintainer's confirmation. See inline notes.

Comment threadpackages/world/src/events.ts
Comment threadpackages/world/src/events.ts Outdated
Comment threadpackages/world/src/events.ts Outdated
Comment threadpackages/core/src/serialization-format.ts
Comment threadpackages/cli/src/lib/inspect/hydration.ts
Comment threadpackages/web-shared/src/lib/event-materialization.ts
Comment threadpackages/web-shared/src/components/sidebar/events-list.tsx
Comment threadpackages/web-shared/src/components/sidebar/events-list.tsx
Comment threadpackages/web-shared/src/components/sidebar/events-list.tsx
Comment threadpackages/web/app/components/run-detail-view.tsx
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@NathanColosimo@VaguelySerious
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Centralize workflow event semantics - #2790

Merged
NathanColosimo merged 10 commits into
mainfrom
codex/centralize-event-semantics
Jul 10, 2026
Merged

Centralize workflow event semantics#2790
NathanColosimo merged 10 commits into
mainfrom
codex/centralize-event-semantics

Conversation

@NathanColosimo

@NathanColosimoNathanColosimo commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add targeted event type helpers and lifecycle classifiers in @workflow/world
  • centralize eventData ref/payload field lookup for lazy-start and v4 split handling
  • replace duplicated event/status groups across local, postgres, vercel, web-shared, web, and CLI

Tests

  • ./node_modules/.bin/tsc -p packages/world/tsconfig.json
  • ./node_modules/.bin/tsc -p packages/world-local/tsconfig.json --noEmit
  • ./node_modules/.bin/tsc -p packages/world-postgres/tsconfig.json --noEmit
  • cd packages/world-vercel && ./node_modules/.bin/genversion --es6 src/version.ts && ../../node_modules/.bin/tsc --noEmit
  • ./node_modules/.bin/tsc -p packages/web-shared/tsconfig.json --noEmit
  • ./node_modules/.bin/tsc -p packages/cli/tsconfig.json --noEmit
  • cd packages/world-vercel && ../../node_modules/.bin/vitest run src event
  • cd packages/world-local && ../../node_modules/.bin/vitest run src
  • cd packages/web-shared && ../../node_modules/.bin/vitest run

@changeset-bot

changeset-botBot commented Jul 6, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0b57804

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@workflow/worldMinor
@workflow/corePatch
@workflow/world-localPatch
@workflow/world-postgresPatch
@workflow/world-vercelPatch
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/cliPatch
@workflow/vitestPatch
@workflow/world-testingPatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/nitroPatch
workflowPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/nuxtPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actionsBot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 0b57804 · Thu, 09 Jul 2026 22:23:47 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1266 (+26%)1678 🔴1789 🔴1941 🔴30
TTFShook + stream1509 (+21%)1923 🔴1967 🔴2116 🔴30
STSO1020 steps (1-20)296 (+24%)319 🔴451 🔴500 🔴19
STSO1020 steps (101-120)408 (+0.7%)449 🔴470 🔴548 🔴19
STSO1020 steps (1001-1020)1037 (±0%)953 🔴1274 🔴3804 🔴19
WOstream1266 (+26%)16781789194130
WOhook + stream1509 (+21%)19231967211630
SLstream4132 (-14%)5093 🔴5650 🔴6056 🔴30
SLhook + stream5130 (+2.7%)5733 🔴5821 🔴5961 🔴30
📜 Previous results (1)

b670eda

Thu, 09 Jul 2026 00:30:42 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream23063291 🔴3760 🔴4941 🔴30
TTFShook + stream15481929 🔴2057 🔴2141 🔴30
STSO1020 steps (1-20)274307 🔴368 🔴450 🔴19
STSO1020 steps (101-120)423499 🔴528 🔴546 🔴19
STSO1020 steps (1001-1020)824850 🔴959 🔴969 🔴19
WOstream230632913760494130
WOhook + stream154819292057214130
SLstream43774879 🔴5593 🔴7929 🔴30
SLhook + stream48115405 🔴5592 🔴5881 🔴30

Avg deltas compare against the most recent benchmark run on main at the time of this run.

Metrics — TTFS: time to first step body execution · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (time outside step bodies, client start → last step body exit) · SL: stream latency (first chunk write → visible to the reader)

Scenarios — stream: one step that streams chunks back to the client; no hooks, so the run stays in turbo mode · hook + stream: registers a hook before the same streaming step, which exits turbo mode · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges

🟢/🔴 mark percentiles within/above target. Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

TTFS/WO compare client vs deployment clocks and SL compares the step runner’s clock vs the client’s (NTP-synced in CI). WO ends at the last step body exit, the closest observable proxy for the final step-completion request.

@NathanColosimo
NathanColosimoforce-pushed the codex/centralize-event-semantics branch from dd190fb to 394f4c2CompareJuly 6, 2026 22:19
@github-actions

github-actionsBot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production145302301683
✅ 💻 Local Development161702191836
✅ 📦 Local Production161702191836
✅ 🐘 Local Postgres161702191836
✅ 🪟 Windows15300153
✅ 📋 Other89401771071
Total7351010648415

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126027
✅ example126027
✅ express126027
✅ fastify126027
✅ hono126027
✅ nextjs-turbopack15003
✅ nextjs-webpack15003
✅ nitro126027
✅ nuxt126027
✅ sveltekit14508
✅ vite126027
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15300
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128025
✅ e2e-local-dev-tanstack-start-128025
✅ e2e-local-postgres-nest-stable128025
✅ e2e-local-postgres-tanstack-start-128025
✅ e2e-local-prod-nest-stable128025
✅ e2e-local-prod-tanstack-start-128025
✅ e2e-vercel-prod-tanstack-start126027

📋 View full workflow run

…t-semantics
# Conflicts:
#	packages/cli/src/commands/cancel.ts
…t-semantics
# Conflicts:
#	packages/web-shared/src/components/sidebar/entity-detail-panel.tsx
…t-semantics
# Conflicts:
#	packages/world-local/src/storage/hooks-storage.ts

@VaguelySeriousVaguelySerious left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

human review, ai tbd

Comment threadpackages/cli/src/lib/inspect/hydration.ts

@VaguelySeriousVaguelySerious left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI review: no blocking issues.

This pass only flags possible behavior changes introduced by the event-semantics centralization. None are clearly incorrect, but each is a semantic shift from the code it replaced and worth a maintainer's confirmation. See inline notes.

Comment threadpackages/world/src/events.ts
Comment threadpackages/world/src/events.ts Outdated
Comment threadpackages/world/src/events.ts Outdated
Comment threadpackages/core/src/serialization-format.ts
Comment threadpackages/cli/src/lib/inspect/hydration.ts
Comment threadpackages/web-shared/src/lib/event-materialization.ts
Comment threadpackages/web-shared/src/components/sidebar/events-list.tsx
Comment threadpackages/web-shared/src/components/sidebar/events-list.tsx
Comment threadpackages/web-shared/src/components/sidebar/events-list.tsx
Comment threadpackages/web/app/components/run-detail-view.tsx
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@NathanColosimo@VaguelySerious
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Centralize workflow event semantics - #2790

Merged
NathanColosimo merged 10 commits into
mainfrom
codex/centralize-event-semantics
Jul 10, 2026
Merged

Centralize workflow event semantics#2790
NathanColosimo merged 10 commits into
mainfrom
codex/centralize-event-semantics

Conversation

@NathanColosimo

@NathanColosimoNathanColosimo commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add targeted event type helpers and lifecycle classifiers in @workflow/world
  • centralize eventData ref/payload field lookup for lazy-start and v4 split handling
  • replace duplicated event/status groups across local, postgres, vercel, web-shared, web, and CLI

Tests

  • ./node_modules/.bin/tsc -p packages/world/tsconfig.json
  • ./node_modules/.bin/tsc -p packages/world-local/tsconfig.json --noEmit
  • ./node_modules/.bin/tsc -p packages/world-postgres/tsconfig.json --noEmit
  • cd packages/world-vercel && ./node_modules/.bin/genversion --es6 src/version.ts && ../../node_modules/.bin/tsc --noEmit
  • ./node_modules/.bin/tsc -p packages/web-shared/tsconfig.json --noEmit
  • ./node_modules/.bin/tsc -p packages/cli/tsconfig.json --noEmit
  • cd packages/world-vercel && ../../node_modules/.bin/vitest run src event
  • cd packages/world-local && ../../node_modules/.bin/vitest run src
  • cd packages/web-shared && ../../node_modules/.bin/vitest run

@changeset-bot

changeset-botBot commented Jul 6, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0b57804

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@workflow/worldMinor
@workflow/corePatch
@workflow/world-localPatch
@workflow/world-postgresPatch
@workflow/world-vercelPatch
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/cliPatch
@workflow/vitestPatch
@workflow/world-testingPatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/nitroPatch
workflowPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/nuxtPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actionsBot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 0b57804 · Thu, 09 Jul 2026 22:23:47 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1266 (+26%)1678 🔴1789 🔴1941 🔴30
TTFShook + stream1509 (+21%)1923 🔴1967 🔴2116 🔴30
STSO1020 steps (1-20)296 (+24%)319 🔴451 🔴500 🔴19
STSO1020 steps (101-120)408 (+0.7%)449 🔴470 🔴548 🔴19
STSO1020 steps (1001-1020)1037 (±0%)953 🔴1274 🔴3804 🔴19
WOstream1266 (+26%)16781789194130
WOhook + stream1509 (+21%)19231967211630
SLstream4132 (-14%)5093 🔴5650 🔴6056 🔴30
SLhook + stream5130 (+2.7%)5733 🔴5821 🔴5961 🔴30
📜 Previous results (1)

b670eda

Thu, 09 Jul 2026 00:30:42 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream23063291 🔴3760 🔴4941 🔴30
TTFShook + stream15481929 🔴2057 🔴2141 🔴30
STSO1020 steps (1-20)274307 🔴368 🔴450 🔴19
STSO1020 steps (101-120)423499 🔴528 🔴546 🔴19
STSO1020 steps (1001-1020)824850 🔴959 🔴969 🔴19
WOstream230632913760494130
WOhook + stream154819292057214130
SLstream43774879 🔴5593 🔴7929 🔴30
SLhook + stream48115405 🔴5592 🔴5881 🔴30

Avg deltas compare against the most recent benchmark run on main at the time of this run.

Metrics — TTFS: time to first step body execution · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (time outside step bodies, client start → last step body exit) · SL: stream latency (first chunk write → visible to the reader)

Scenarios — stream: one step that streams chunks back to the client; no hooks, so the run stays in turbo mode · hook + stream: registers a hook before the same streaming step, which exits turbo mode · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges

🟢/🔴 mark percentiles within/above target. Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

TTFS/WO compare client vs deployment clocks and SL compares the step runner’s clock vs the client’s (NTP-synced in CI). WO ends at the last step body exit, the closest observable proxy for the final step-completion request.

@NathanColosimo
NathanColosimoforce-pushed the codex/centralize-event-semantics branch from dd190fb to 394f4c2CompareJuly 6, 2026 22:19
@github-actions

github-actionsBot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production145302301683
✅ 💻 Local Development161702191836
✅ 📦 Local Production161702191836
✅ 🐘 Local Postgres161702191836
✅ 🪟 Windows15300153
✅ 📋 Other89401771071
Total7351010648415

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126027
✅ example126027
✅ express126027
✅ fastify126027
✅ hono126027
✅ nextjs-turbopack15003
✅ nextjs-webpack15003
✅ nitro126027
✅ nuxt126027
✅ sveltekit14508
✅ vite126027
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15300
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128025
✅ e2e-local-dev-tanstack-start-128025
✅ e2e-local-postgres-nest-stable128025
✅ e2e-local-postgres-tanstack-start-128025
✅ e2e-local-prod-nest-stable128025
✅ e2e-local-prod-tanstack-start-128025
✅ e2e-vercel-prod-tanstack-start126027

📋 View full workflow run

…t-semantics
# Conflicts:
#	packages/cli/src/commands/cancel.ts
…t-semantics
# Conflicts:
#	packages/web-shared/src/components/sidebar/entity-detail-panel.tsx
…t-semantics
# Conflicts:
#	packages/world-local/src/storage/hooks-storage.ts

@VaguelySeriousVaguelySerious left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

human review, ai tbd

Comment threadpackages/cli/src/lib/inspect/hydration.ts

@VaguelySeriousVaguelySerious left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI review: no blocking issues.

This pass only flags possible behavior changes introduced by the event-semantics centralization. None are clearly incorrect, but each is a semantic shift from the code it replaced and worth a maintainer's confirmation. See inline notes.

Comment threadpackages/world/src/events.ts
Comment threadpackages/world/src/events.ts Outdated
Comment threadpackages/world/src/events.ts Outdated
Comment threadpackages/core/src/serialization-format.ts
Comment threadpackages/cli/src/lib/inspect/hydration.ts
Comment threadpackages/web-shared/src/lib/event-materialization.ts
Comment threadpackages/web-shared/src/components/sidebar/events-list.tsx
Comment threadpackages/web-shared/src/components/sidebar/events-list.tsx
Comment threadpackages/web-shared/src/components/sidebar/events-list.tsx
Comment threadpackages/web/app/components/run-detail-view.tsx
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@NathanColosimo@VaguelySerious
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Centralize workflow event semantics - #2790

Merged
NathanColosimo merged 10 commits into
mainfrom
codex/centralize-event-semantics
Jul 10, 2026
Merged

Centralize workflow event semantics#2790
NathanColosimo merged 10 commits into
mainfrom
codex/centralize-event-semantics

Conversation

@NathanColosimo

@NathanColosimoNathanColosimo commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add targeted event type helpers and lifecycle classifiers in @workflow/world
  • centralize eventData ref/payload field lookup for lazy-start and v4 split handling
  • replace duplicated event/status groups across local, postgres, vercel, web-shared, web, and CLI

Tests

  • ./node_modules/.bin/tsc -p packages/world/tsconfig.json
  • ./node_modules/.bin/tsc -p packages/world-local/tsconfig.json --noEmit
  • ./node_modules/.bin/tsc -p packages/world-postgres/tsconfig.json --noEmit
  • cd packages/world-vercel && ./node_modules/.bin/genversion --es6 src/version.ts && ../../node_modules/.bin/tsc --noEmit
  • ./node_modules/.bin/tsc -p packages/web-shared/tsconfig.json --noEmit
  • ./node_modules/.bin/tsc -p packages/cli/tsconfig.json --noEmit
  • cd packages/world-vercel && ../../node_modules/.bin/vitest run src event
  • cd packages/world-local && ../../node_modules/.bin/vitest run src
  • cd packages/web-shared && ../../node_modules/.bin/vitest run

@changeset-bot

changeset-botBot commented Jul 6, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0b57804

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@workflow/worldMinor
@workflow/corePatch
@workflow/world-localPatch
@workflow/world-postgresPatch
@workflow/world-vercelPatch
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/cliPatch
@workflow/vitestPatch
@workflow/world-testingPatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/nitroPatch
workflowPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/nuxtPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actionsBot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 0b57804 · Thu, 09 Jul 2026 22:23:47 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1266 (+26%)1678 🔴1789 🔴1941 🔴30
TTFShook + stream1509 (+21%)1923 🔴1967 🔴2116 🔴30
STSO1020 steps (1-20)296 (+24%)319 🔴451 🔴500 🔴19
STSO1020 steps (101-120)408 (+0.7%)449 🔴470 🔴548 🔴19
STSO1020 steps (1001-1020)1037 (±0%)953 🔴1274 🔴3804 🔴19
WOstream1266 (+26%)16781789194130
WOhook + stream1509 (+21%)19231967211630
SLstream4132 (-14%)5093 🔴5650 🔴6056 🔴30
SLhook + stream5130 (+2.7%)5733 🔴5821 🔴5961 🔴30
📜 Previous results (1)

b670eda

Thu, 09 Jul 2026 00:30:42 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream23063291 🔴3760 🔴4941 🔴30
TTFShook + stream15481929 🔴2057 🔴2141 🔴30
STSO1020 steps (1-20)274307 🔴368 🔴450 🔴19
STSO1020 steps (101-120)423499 🔴528 🔴546 🔴19
STSO1020 steps (1001-1020)824850 🔴959 🔴969 🔴19
WOstream230632913760494130
WOhook + stream154819292057214130
SLstream43774879 🔴5593 🔴7929 🔴30
SLhook + stream48115405 🔴5592 🔴5881 🔴30

Avg deltas compare against the most recent benchmark run on main at the time of this run.

Metrics — TTFS: time to first step body execution · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (time outside step bodies, client start → last step body exit) · SL: stream latency (first chunk write → visible to the reader)

Scenarios — stream: one step that streams chunks back to the client; no hooks, so the run stays in turbo mode · hook + stream: registers a hook before the same streaming step, which exits turbo mode · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges

🟢/🔴 mark percentiles within/above target. Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

TTFS/WO compare client vs deployment clocks and SL compares the step runner’s clock vs the client’s (NTP-synced in CI). WO ends at the last step body exit, the closest observable proxy for the final step-completion request.

@NathanColosimo
NathanColosimoforce-pushed the codex/centralize-event-semantics branch from dd190fb to 394f4c2CompareJuly 6, 2026 22:19
@github-actions

github-actionsBot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production145302301683
✅ 💻 Local Development161702191836
✅ 📦 Local Production161702191836
✅ 🐘 Local Postgres161702191836
✅ 🪟 Windows15300153
✅ 📋 Other89401771071
Total7351010648415

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126027
✅ example126027
✅ express126027
✅ fastify126027
✅ hono126027
✅ nextjs-turbopack15003
✅ nextjs-webpack15003
✅ nitro126027
✅ nuxt126027
✅ sveltekit14508
✅ vite126027
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15300
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128025
✅ e2e-local-dev-tanstack-start-128025
✅ e2e-local-postgres-nest-stable128025
✅ e2e-local-postgres-tanstack-start-128025
✅ e2e-local-prod-nest-stable128025
✅ e2e-local-prod-tanstack-start-128025
✅ e2e-vercel-prod-tanstack-start126027

📋 View full workflow run

…t-semantics
# Conflicts:
#	packages/cli/src/commands/cancel.ts
…t-semantics
# Conflicts:
#	packages/web-shared/src/components/sidebar/entity-detail-panel.tsx
…t-semantics
# Conflicts:
#	packages/world-local/src/storage/hooks-storage.ts

@VaguelySeriousVaguelySerious left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

human review, ai tbd

Comment threadpackages/cli/src/lib/inspect/hydration.ts

@VaguelySeriousVaguelySerious left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI review: no blocking issues.

This pass only flags possible behavior changes introduced by the event-semantics centralization. None are clearly incorrect, but each is a semantic shift from the code it replaced and worth a maintainer's confirmation. See inline notes.

Comment threadpackages/world/src/events.ts
Comment threadpackages/world/src/events.ts Outdated
Comment threadpackages/world/src/events.ts Outdated
Comment threadpackages/core/src/serialization-format.ts
Comment threadpackages/cli/src/lib/inspect/hydration.ts
Comment threadpackages/web-shared/src/lib/event-materialization.ts
Comment threadpackages/web-shared/src/components/sidebar/events-list.tsx
Comment threadpackages/web-shared/src/components/sidebar/events-list.tsx
Comment threadpackages/web-shared/src/components/sidebar/events-list.tsx
Comment threadpackages/web/app/components/run-detail-view.tsx
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@NathanColosimo@VaguelySerious
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Centralize workflow event semantics - #2790

Merged
NathanColosimo merged 10 commits into
mainfrom
codex/centralize-event-semantics
Jul 10, 2026
Merged

Centralize workflow event semantics#2790
NathanColosimo merged 10 commits into
mainfrom
codex/centralize-event-semantics

Conversation

@NathanColosimo

@NathanColosimoNathanColosimo commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add targeted event type helpers and lifecycle classifiers in @workflow/world
  • centralize eventData ref/payload field lookup for lazy-start and v4 split handling
  • replace duplicated event/status groups across local, postgres, vercel, web-shared, web, and CLI

Tests

  • ./node_modules/.bin/tsc -p packages/world/tsconfig.json
  • ./node_modules/.bin/tsc -p packages/world-local/tsconfig.json --noEmit
  • ./node_modules/.bin/tsc -p packages/world-postgres/tsconfig.json --noEmit
  • cd packages/world-vercel && ./node_modules/.bin/genversion --es6 src/version.ts && ../../node_modules/.bin/tsc --noEmit
  • ./node_modules/.bin/tsc -p packages/web-shared/tsconfig.json --noEmit
  • ./node_modules/.bin/tsc -p packages/cli/tsconfig.json --noEmit
  • cd packages/world-vercel && ../../node_modules/.bin/vitest run src event
  • cd packages/world-local && ../../node_modules/.bin/vitest run src
  • cd packages/web-shared && ../../node_modules/.bin/vitest run

@changeset-bot

changeset-botBot commented Jul 6, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0b57804

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@workflow/worldMinor
@workflow/corePatch
@workflow/world-localPatch
@workflow/world-postgresPatch
@workflow/world-vercelPatch
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/cliPatch
@workflow/vitestPatch
@workflow/world-testingPatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/nitroPatch
workflowPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/nuxtPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actionsBot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 0b57804 · Thu, 09 Jul 2026 22:23:47 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1266 (+26%)1678 🔴1789 🔴1941 🔴30
TTFShook + stream1509 (+21%)1923 🔴1967 🔴2116 🔴30
STSO1020 steps (1-20)296 (+24%)319 🔴451 🔴500 🔴19
STSO1020 steps (101-120)408 (+0.7%)449 🔴470 🔴548 🔴19
STSO1020 steps (1001-1020)1037 (±0%)953 🔴1274 🔴3804 🔴19
WOstream1266 (+26%)16781789194130
WOhook + stream1509 (+21%)19231967211630
SLstream4132 (-14%)5093 🔴5650 🔴6056 🔴30
SLhook + stream5130 (+2.7%)5733 🔴5821 🔴5961 🔴30
📜 Previous results (1)

b670eda

Thu, 09 Jul 2026 00:30:42 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream23063291 🔴3760 🔴4941 🔴30
TTFShook + stream15481929 🔴2057 🔴2141 🔴30
STSO1020 steps (1-20)274307 🔴368 🔴450 🔴19
STSO1020 steps (101-120)423499 🔴528 🔴546 🔴19
STSO1020 steps (1001-1020)824850 🔴959 🔴969 🔴19
WOstream230632913760494130
WOhook + stream154819292057214130
SLstream43774879 🔴5593 🔴7929 🔴30
SLhook + stream48115405 🔴5592 🔴5881 🔴30

Avg deltas compare against the most recent benchmark run on main at the time of this run.

Metrics — TTFS: time to first step body execution · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (time outside step bodies, client start → last step body exit) · SL: stream latency (first chunk write → visible to the reader)

Scenarios — stream: one step that streams chunks back to the client; no hooks, so the run stays in turbo mode · hook + stream: registers a hook before the same streaming step, which exits turbo mode · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges

🟢/🔴 mark percentiles within/above target. Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

TTFS/WO compare client vs deployment clocks and SL compares the step runner’s clock vs the client’s (NTP-synced in CI). WO ends at the last step body exit, the closest observable proxy for the final step-completion request.

@NathanColosimo
NathanColosimoforce-pushed the codex/centralize-event-semantics branch from dd190fb to 394f4c2CompareJuly 6, 2026 22:19
@github-actions

github-actionsBot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production145302301683
✅ 💻 Local Development161702191836
✅ 📦 Local Production161702191836
✅ 🐘 Local Postgres161702191836
✅ 🪟 Windows15300153
✅ 📋 Other89401771071
Total7351010648415

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126027
✅ example126027
✅ express126027
✅ fastify126027
✅ hono126027
✅ nextjs-turbopack15003
✅ nextjs-webpack15003
✅ nitro126027
✅ nuxt126027
✅ sveltekit14508
✅ vite126027
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15300
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128025
✅ e2e-local-dev-tanstack-start-128025
✅ e2e-local-postgres-nest-stable128025
✅ e2e-local-postgres-tanstack-start-128025
✅ e2e-local-prod-nest-stable128025
✅ e2e-local-prod-tanstack-start-128025
✅ e2e-vercel-prod-tanstack-start126027

📋 View full workflow run

…t-semantics
# Conflicts:
#	packages/cli/src/commands/cancel.ts
…t-semantics
# Conflicts:
#	packages/web-shared/src/components/sidebar/entity-detail-panel.tsx
…t-semantics
# Conflicts:
#	packages/world-local/src/storage/hooks-storage.ts

@VaguelySeriousVaguelySerious left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

human review, ai tbd

Comment threadpackages/cli/src/lib/inspect/hydration.ts

@VaguelySeriousVaguelySerious left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI review: no blocking issues.

This pass only flags possible behavior changes introduced by the event-semantics centralization. None are clearly incorrect, but each is a semantic shift from the code it replaced and worth a maintainer's confirmation. See inline notes.

Comment threadpackages/world/src/events.ts
Comment threadpackages/world/src/events.ts Outdated
Comment threadpackages/world/src/events.ts Outdated
Comment threadpackages/core/src/serialization-format.ts
Comment threadpackages/cli/src/lib/inspect/hydration.ts
Comment threadpackages/web-shared/src/lib/event-materialization.ts
Comment threadpackages/web-shared/src/components/sidebar/events-list.tsx
Comment threadpackages/web-shared/src/components/sidebar/events-list.tsx
Comment threadpackages/web-shared/src/components/sidebar/events-list.tsx
Comment threadpackages/web/app/components/run-detail-view.tsx
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@NathanColosimo@VaguelySerious
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Centralize workflow event semantics - #2790

Merged
NathanColosimo merged 10 commits into
mainfrom
codex/centralize-event-semantics
Jul 10, 2026
Merged

Centralize workflow event semantics#2790
NathanColosimo merged 10 commits into
mainfrom
codex/centralize-event-semantics

Conversation

@NathanColosimo

@NathanColosimoNathanColosimo commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add targeted event type helpers and lifecycle classifiers in @workflow/world
  • centralize eventData ref/payload field lookup for lazy-start and v4 split handling
  • replace duplicated event/status groups across local, postgres, vercel, web-shared, web, and CLI

Tests

  • ./node_modules/.bin/tsc -p packages/world/tsconfig.json
  • ./node_modules/.bin/tsc -p packages/world-local/tsconfig.json --noEmit
  • ./node_modules/.bin/tsc -p packages/world-postgres/tsconfig.json --noEmit
  • cd packages/world-vercel && ./node_modules/.bin/genversion --es6 src/version.ts && ../../node_modules/.bin/tsc --noEmit
  • ./node_modules/.bin/tsc -p packages/web-shared/tsconfig.json --noEmit
  • ./node_modules/.bin/tsc -p packages/cli/tsconfig.json --noEmit
  • cd packages/world-vercel && ../../node_modules/.bin/vitest run src event
  • cd packages/world-local && ../../node_modules/.bin/vitest run src
  • cd packages/web-shared && ../../node_modules/.bin/vitest run

@changeset-bot

changeset-botBot commented Jul 6, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0b57804

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@workflow/worldMinor
@workflow/corePatch
@workflow/world-localPatch
@workflow/world-postgresPatch
@workflow/world-vercelPatch
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/cliPatch
@workflow/vitestPatch
@workflow/world-testingPatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/nitroPatch
workflowPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/nuxtPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actionsBot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 0b57804 · Thu, 09 Jul 2026 22:23:47 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1266 (+26%)1678 🔴1789 🔴1941 🔴30
TTFShook + stream1509 (+21%)1923 🔴1967 🔴2116 🔴30
STSO1020 steps (1-20)296 (+24%)319 🔴451 🔴500 🔴19
STSO1020 steps (101-120)408 (+0.7%)449 🔴470 🔴548 🔴19
STSO1020 steps (1001-1020)1037 (±0%)953 🔴1274 🔴3804 🔴19
WOstream1266 (+26%)16781789194130
WOhook + stream1509 (+21%)19231967211630
SLstream4132 (-14%)5093 🔴5650 🔴6056 🔴30
SLhook + stream5130 (+2.7%)5733 🔴5821 🔴5961 🔴30
📜 Previous results (1)

b670eda

Thu, 09 Jul 2026 00:30:42 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream23063291 🔴3760 🔴4941 🔴30
TTFShook + stream15481929 🔴2057 🔴2141 🔴30
STSO1020 steps (1-20)274307 🔴368 🔴450 🔴19
STSO1020 steps (101-120)423499 🔴528 🔴546 🔴19
STSO1020 steps (1001-1020)824850 🔴959 🔴969 🔴19
WOstream230632913760494130
WOhook + stream154819292057214130
SLstream43774879 🔴5593 🔴7929 🔴30
SLhook + stream48115405 🔴5592 🔴5881 🔴30

Avg deltas compare against the most recent benchmark run on main at the time of this run.

Metrics — TTFS: time to first step body execution · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (time outside step bodies, client start → last step body exit) · SL: stream latency (first chunk write → visible to the reader)

Scenarios — stream: one step that streams chunks back to the client; no hooks, so the run stays in turbo mode · hook + stream: registers a hook before the same streaming step, which exits turbo mode · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges

🟢/🔴 mark percentiles within/above target. Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

TTFS/WO compare client vs deployment clocks and SL compares the step runner’s clock vs the client’s (NTP-synced in CI). WO ends at the last step body exit, the closest observable proxy for the final step-completion request.

@NathanColosimo
NathanColosimoforce-pushed the codex/centralize-event-semantics branch from dd190fb to 394f4c2CompareJuly 6, 2026 22:19
@github-actions

github-actionsBot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production145302301683
✅ 💻 Local Development161702191836
✅ 📦 Local Production161702191836
✅ 🐘 Local Postgres161702191836
✅ 🪟 Windows15300153
✅ 📋 Other89401771071
Total7351010648415

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126027
✅ example126027
✅ express126027
✅ fastify126027
✅ hono126027
✅ nextjs-turbopack15003
✅ nextjs-webpack15003
✅ nitro126027
✅ nuxt126027
✅ sveltekit14508
✅ vite126027
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15300
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128025
✅ e2e-local-dev-tanstack-start-128025
✅ e2e-local-postgres-nest-stable128025
✅ e2e-local-postgres-tanstack-start-128025
✅ e2e-local-prod-nest-stable128025
✅ e2e-local-prod-tanstack-start-128025
✅ e2e-vercel-prod-tanstack-start126027

📋 View full workflow run

…t-semantics
# Conflicts:
#	packages/cli/src/commands/cancel.ts
…t-semantics
# Conflicts:
#	packages/web-shared/src/components/sidebar/entity-detail-panel.tsx
…t-semantics
# Conflicts:
#	packages/world-local/src/storage/hooks-storage.ts

@VaguelySeriousVaguelySerious left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

human review, ai tbd

Comment threadpackages/cli/src/lib/inspect/hydration.ts

@VaguelySeriousVaguelySerious left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI review: no blocking issues.

This pass only flags possible behavior changes introduced by the event-semantics centralization. None are clearly incorrect, but each is a semantic shift from the code it replaced and worth a maintainer's confirmation. See inline notes.

Comment threadpackages/world/src/events.ts
Comment threadpackages/world/src/events.ts Outdated
Comment threadpackages/world/src/events.ts Outdated
Comment threadpackages/core/src/serialization-format.ts
Comment threadpackages/cli/src/lib/inspect/hydration.ts
Comment threadpackages/web-shared/src/lib/event-materialization.ts
Comment threadpackages/web-shared/src/components/sidebar/events-list.tsx
Comment threadpackages/web-shared/src/components/sidebar/events-list.tsx
Comment threadpackages/web-shared/src/components/sidebar/events-list.tsx
Comment threadpackages/web/app/components/run-detail-view.tsx
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@NathanColosimo@VaguelySerious
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Centralize workflow event semantics - #2790

Merged
NathanColosimo merged 10 commits into
mainfrom
codex/centralize-event-semantics
Jul 10, 2026
Merged

Centralize workflow event semantics#2790
NathanColosimo merged 10 commits into
mainfrom
codex/centralize-event-semantics

Conversation

@NathanColosimo

@NathanColosimoNathanColosimo commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add targeted event type helpers and lifecycle classifiers in @workflow/world
  • centralize eventData ref/payload field lookup for lazy-start and v4 split handling
  • replace duplicated event/status groups across local, postgres, vercel, web-shared, web, and CLI

Tests

  • ./node_modules/.bin/tsc -p packages/world/tsconfig.json
  • ./node_modules/.bin/tsc -p packages/world-local/tsconfig.json --noEmit
  • ./node_modules/.bin/tsc -p packages/world-postgres/tsconfig.json --noEmit
  • cd packages/world-vercel && ./node_modules/.bin/genversion --es6 src/version.ts && ../../node_modules/.bin/tsc --noEmit
  • ./node_modules/.bin/tsc -p packages/web-shared/tsconfig.json --noEmit
  • ./node_modules/.bin/tsc -p packages/cli/tsconfig.json --noEmit
  • cd packages/world-vercel && ../../node_modules/.bin/vitest run src event
  • cd packages/world-local && ../../node_modules/.bin/vitest run src
  • cd packages/web-shared && ../../node_modules/.bin/vitest run

@changeset-bot

changeset-botBot commented Jul 6, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0b57804

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@workflow/worldMinor
@workflow/corePatch
@workflow/world-localPatch
@workflow/world-postgresPatch
@workflow/world-vercelPatch
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/cliPatch
@workflow/vitestPatch
@workflow/world-testingPatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/nitroPatch
workflowPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/nuxtPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actionsBot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 0b57804 · Thu, 09 Jul 2026 22:23:47 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1266 (+26%)1678 🔴1789 🔴1941 🔴30
TTFShook + stream1509 (+21%)1923 🔴1967 🔴2116 🔴30
STSO1020 steps (1-20)296 (+24%)319 🔴451 🔴500 🔴19
STSO1020 steps (101-120)408 (+0.7%)449 🔴470 🔴548 🔴19
STSO1020 steps (1001-1020)1037 (±0%)953 🔴1274 🔴3804 🔴19
WOstream1266 (+26%)16781789194130
WOhook + stream1509 (+21%)19231967211630
SLstream4132 (-14%)5093 🔴5650 🔴6056 🔴30
SLhook + stream5130 (+2.7%)5733 🔴5821 🔴5961 🔴30
📜 Previous results (1)

b670eda

Thu, 09 Jul 2026 00:30:42 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream23063291 🔴3760 🔴4941 🔴30
TTFShook + stream15481929 🔴2057 🔴2141 🔴30
STSO1020 steps (1-20)274307 🔴368 🔴450 🔴19
STSO1020 steps (101-120)423499 🔴528 🔴546 🔴19
STSO1020 steps (1001-1020)824850 🔴959 🔴969 🔴19
WOstream230632913760494130
WOhook + stream154819292057214130
SLstream43774879 🔴5593 🔴7929 🔴30
SLhook + stream48115405 🔴5592 🔴5881 🔴30

Avg deltas compare against the most recent benchmark run on main at the time of this run.

Metrics — TTFS: time to first step body execution · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (time outside step bodies, client start → last step body exit) · SL: stream latency (first chunk write → visible to the reader)

Scenarios — stream: one step that streams chunks back to the client; no hooks, so the run stays in turbo mode · hook + stream: registers a hook before the same streaming step, which exits turbo mode · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges

🟢/🔴 mark percentiles within/above target. Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

TTFS/WO compare client vs deployment clocks and SL compares the step runner’s clock vs the client’s (NTP-synced in CI). WO ends at the last step body exit, the closest observable proxy for the final step-completion request.

@NathanColosimo
NathanColosimoforce-pushed the codex/centralize-event-semantics branch from dd190fb to 394f4c2CompareJuly 6, 2026 22:19
@github-actions

github-actionsBot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production145302301683
✅ 💻 Local Development161702191836
✅ 📦 Local Production161702191836
✅ 🐘 Local Postgres161702191836
✅ 🪟 Windows15300153
✅ 📋 Other89401771071
Total7351010648415

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126027
✅ example126027
✅ express126027
✅ fastify126027
✅ hono126027
✅ nextjs-turbopack15003
✅ nextjs-webpack15003
✅ nitro126027
✅ nuxt126027
✅ sveltekit14508
✅ vite126027
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15300
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128025
✅ e2e-local-dev-tanstack-start-128025
✅ e2e-local-postgres-nest-stable128025
✅ e2e-local-postgres-tanstack-start-128025
✅ e2e-local-prod-nest-stable128025
✅ e2e-local-prod-tanstack-start-128025
✅ e2e-vercel-prod-tanstack-start126027

📋 View full workflow run

…t-semantics
# Conflicts:
#	packages/cli/src/commands/cancel.ts
…t-semantics
# Conflicts:
#	packages/web-shared/src/components/sidebar/entity-detail-panel.tsx
…t-semantics
# Conflicts:
#	packages/world-local/src/storage/hooks-storage.ts

@VaguelySeriousVaguelySerious left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

human review, ai tbd

Comment threadpackages/cli/src/lib/inspect/hydration.ts

@VaguelySeriousVaguelySerious left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI review: no blocking issues.

This pass only flags possible behavior changes introduced by the event-semantics centralization. None are clearly incorrect, but each is a semantic shift from the code it replaced and worth a maintainer's confirmation. See inline notes.

Comment threadpackages/world/src/events.ts
Comment threadpackages/world/src/events.ts Outdated
Comment threadpackages/world/src/events.ts Outdated
Comment threadpackages/core/src/serialization-format.ts
Comment threadpackages/cli/src/lib/inspect/hydration.ts
Comment threadpackages/web-shared/src/lib/event-materialization.ts
Comment threadpackages/web-shared/src/components/sidebar/events-list.tsx
Comment threadpackages/web-shared/src/components/sidebar/events-list.tsx
Comment threadpackages/web-shared/src/components/sidebar/events-list.tsx
Comment threadpackages/web/app/components/run-detail-view.tsx
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@NathanColosimo@VaguelySerious