Uh oh!
There was an error while loading. Please reload this page.
Backport #2830: perf(world-local): index hook lookups instead of scanning the global event log - #2839
Closed
github-actions[bot] wants to merge 1 commit into
Closed
Backport #2830: perf(world-local): index hook lookups instead of scanning the global event log#2839github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…event log (#2830) * perf(world-local): index hook lookups instead of scanning the global event log Hook creation, hook cache rebuilds, and token lookups previously read and parsed every event file ever written across all runs, and run termination read every live hook entity — making every turn of a long-lived local session slower as history accumulated. Maintain durable per-token / per-hookId indexes and per-run hook markers (with a one-time backfill for pre-index data dirs), resolve tokens through the claim file, read directory listings concurrently, reuse compiled filename regexes, and raise the recovery page size. * chore: trim development comments * test(world-local): make hook-index perf guard machine-speed independent The absolute 2s wall-clock bound timed out on Windows CI, where filesystem operations are ~50x slower. Compare hook-creation cost before vs. after seeding foreign event history instead. * review: keep world package untouched, batch backfill reads - Revert the recovery page-size change in @workflow/world; default world-local runs.list to a 200-item page instead - Read backfill event/hook files with bounded concurrency (32), matching paginatedFileSystemQuery, to cut one-time migration cost on large legacy data dirs (slow-fs platforms especially) Signed-off-by: Andrew Barba <barba@hey.com>
🦋 Changeset detectedLatest commit: c394cd4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
VaguelySerious
commented
Jul 9, 2026
Member
Not backporting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated backport of #2830 to
stable(backport job run).AI recommendation: This is a self-contained performance fix to
@workflow/world-localhook lookups and run-termination cleanup, all in files that exist onstable. The full-log-scan behavior it optimizes (findLiveHookCreatedEvent,rebuildLiveHookByTokenFromEventLog,deleteAllHooksForRun) is present onstable, and the change includes a one-time backfill for pre-index data dirs, so it does not depend on any main-only API.Merge conflicts were resolved by AI (opencode with
anthropic/claude-opus-4.8). Please review the conflict resolution carefully before merging.