Skip to content

Backport #2925: Fix duplicate transforms of Nitro build artifacts - #2928

Merged
NathanColosimo merged 2 commits into
stablefrom
backport/pr-2925-to-stable
Jul 14, 2026
Merged

Backport #2925: Fix duplicate transforms of Nitro build artifacts#2928
NathanColosimo merged 2 commits into
stablefrom
backport/pr-2925-to-stable

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated backport of #2925 to stable (backport job run).

AI recommendation: This is a self-contained bug fix that broadens the Nitro transform exclusion from only the pre-built workflow bundle directory to all generated Nitro build artifacts, preventing duplicate class registration. The affected files (packages/nitro/src/index.ts and vite.ts) and the exact workflowBuildDir exclusion logic being fixed exist unchanged on stable, and the change comes with a regression test, so it applies cleanly to the stable branch.

Merge conflicts were resolved by AI (opencode with anthropic/claude-opus-4.8). Please review the conflict resolution carefully before merging.

Signed-off-by: Nathan Colosimo <110621881+NathanColosimo@users.noreply.github.com>
@changeset-bot

changeset-botBot commented Jul 14, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 759ef8b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
NameType
@workflow/nitroPatch
@workflow/nuxtPatch
workflowPatch
@workflow/world-testingPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

@NathanColosimo
NathanColosimo enabled auto-merge (squash) July 14, 2026 22:47
@github-actions

github-actionsBot commented Jul 14, 2026

Copy link
Copy Markdown
ContributorAuthor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production10770781155
✅ 💻 Local Development11740861260
✅ 📦 Local Production11740861260
✅ 🐘 Local Postgres11740861260
✅ 🪟 Windows10500105
❌ 🌍 Community Worlds821029193
✅ 📋 Other594036630
Total53801023815863

❌ Failed Tests

🌍 Community Worlds (102 failed)

redis (19 failed):

  • hookWorkflow | wrun_01KXHEKY8Z3V27355GFY2QXW4X
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KXHEM663CXM1R1FAZP64EKNE
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01KXHEMG6YBMCF2C17TJ0TNDJ0
  • sleepingWorkflow | wrun_01KXHENQB8WQDWT88EG71PCYHF
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KXHEXYD0TATRPA9SH6GV7KK1
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01KXHEYCAESVKWEQ6H19HQKTJV
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01KXHEYMCTDMEMK3V3QSK1S264
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01KXHEZ26S60A40DGF1SCE5YKY
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01KXHEZXNY0B1MJDTVDKC4F54T
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01KXHF02M5B3XCH6B3EMZK7CQX
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01KXHF09HAMS6EAT4PSS0QPEXK
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01KXHF0FRHQ3G1BDGTTDKR21K9
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01KXHF0SRMKCPB452G17ET3N0N
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KXHF712XFC0A3HDP0FKE8BBQ

turso (83 failed):

  • addTenWorkflow | wrun_01KXHEK06WN31QJ8X8CNXPT8DY
  • addTenWorkflow | wrun_01KXHEK06WN31QJ8X8CNXPT8DY
  • deploymentId: 'latest' is a no-op in non-Vercel worlds
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KXHEN6X0MBPT9WHSBAVQVGMS
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KXHEK8X194MFGKY3ZNNVY68F
  • promiseRaceWorkflow | wrun_01KXHEKCV1MX2ZFAJVCRFANSWF
  • promiseAnyWorkflow | wrun_01KXHEKF8A87ZX579R5YKNMRP4
  • importedStepOnlyWorkflow | wrun_01KXHENJHVXXT7BDTM01CPSCBQ
  • readableStreamWorkflow | wrun_01KXHEKHR0EEGJPXNKG3QK1E0H
  • hookWorkflow | wrun_01KXHEKY8Z3V27355GFY2QXW4X
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KXHEM663CXM1R1FAZP64EKNE
  • webhookWorkflow | wrun_01KXHEMASEN4B21TKNCF3Q495B
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01KXHEMG6YBMCF2C17TJ0TNDJ0
  • sleepingWorkflow | wrun_01KXHENQB8WQDWT88EG71PCYHF
  • parallelSleepWorkflow | wrun_01KXHEP777316PRTNSPE04Y91A
  • sleepWinsRaceWorkflow | wrun_01KXHEPAVJ2AGE1B2J36VX48RT
  • stepWinsRaceWorkflow | wrun_01KXHEPEK98BNEMZ5CPPWAJ381
  • nullByteWorkflow | wrun_01KXHEPJ485YNJDAG1GPE97EGG
  • workflowAndStepMetadataWorkflow | wrun_01KXHEPMFY2S21BF283SQY022K
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KXHES49HNSDA2NJXY4CV67P7
  • writableForwardedFromWorkflowWorkflow | wrun_01KXHESHKK3WJWDAD0FPWZJ16N
  • writableForwardedFromStepWorkflow | wrun_01KXHESNW290K514FE74R3HBJQ
  • fetchWorkflow | wrun_01KXHESSG3ZMHT32YTRRT5G8GW
  • promiseRaceStressTestWorkflow | wrun_01KXHESX4SKBTBPJ4V4123P0KW
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KXHEXH0H9QX17CW7JWFWY631
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KXHEXYD0TATRPA9SH6GV7KK1
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01KXHEYCAESVKWEQ6H19HQKTJV
  • 'hookGetConflictWithPriorStepWorkflow' - hook.getConflict() does not block step execution | wrun_01KXHEYF0HP1K7S2JVDWGYYGD4
  • 'hookGetConflictWithParallelStepWorkfl…' - hook.getConflict() does not block step execution | wrun_01KXHEYHPDK3HZPSHHTX6P7QEB
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01KXHEYMCTDMEMK3V3QSK1S264
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01KXHEZ26S60A40DGF1SCE5YKY
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01KXHEZXNY0B1MJDTVDKC4F54T
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01KXHF02M5B3XCH6B3EMZK7CQX
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01KXHF09HAMS6EAT4PSS0QPEXK
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01KXHF0FRHQ3G1BDGTTDKR21K9
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01KXHF0SRMKCPB452G17ET3N0N
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KXHF111RYBYQ7SH6CT80HJFW
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KXHF1J68Y9B5EER5MTN2XCWR
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KXHF1WBNC7E3J0HRT5DE3S06
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KXHF22FB29GZ6RKX5QJK3G9N
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KXHF24X27PH1ZTCKGWBWWM4G
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KXHF2NAJRKGVV5E6M5N7N9VQ
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KXHF2VW65TDQHJ5Y3WKDSP67
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KXHF33B47HMR8FHGJ6RS0T10
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KXHF3ATG14ZAHJND9X74Q53Z
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KXHF3J9RFVQ8A11432VSS5T8
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KXHF3SPHJ0BG8W754YRFJ21P
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KXHF41BWBFMF6S115F80SKXE
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KXHF4FKKWYWYC2BTA84MDV2Z
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KXHF4S7T6Z12RM6NQRJ7M0V5
  • cancelRun - cancelling a running workflow | wrun_01KXHF50HXYW7WX7H03S4V00G4
  • cancelRun via CLI - cancelling a running workflow | wrun_01KXHF55V9D52023GBHV05MCYR
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KXHF5EXCS7GETSHFHJRVWVSV
  • hookWithSleepFinalStepWorkflow - step only on final payload | wrun_01KXHF5Y7MM8N3B8VJ13C9JTMW
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KXHF682EYKGHTK96HR9SG1QQ
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KXHF6MJ5T92TK64Y9G60PHT0
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KXHF6VVW1B7N5DEC0V1BQ4GR
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KXHF6YNXM7VR30FPWGKADB9V
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KXHF712XFC0A3HDP0FKE8BBQ

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro9708
✅ example9708
✅ express9708
✅ fastify9708
✅ hono9708
✅ nextjs-turbopack10203
✅ nextjs-webpack10203
✅ nitro9708
✅ nuxt9708
✅ sveltekit9708
✅ vite9708
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable9906
✅ express-stable9906
✅ fastify-stable9906
✅ hono-stable9906
✅ nextjs-turbopack-canary86019
✅ nextjs-turbopack-stable10500
✅ nextjs-webpack-canary86019
✅ nextjs-webpack-stable10500
✅ nitro-stable9906
✅ nuxt-stable9906
✅ sveltekit-stable9906
✅ vite-stable9906
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable9906
✅ express-stable9906
✅ fastify-stable9906
✅ hono-stable9906
✅ nextjs-turbopack-canary86019
✅ nextjs-turbopack-stable10500
✅ nextjs-webpack-canary86019
✅ nextjs-webpack-stable10500
✅ nitro-stable9906
✅ nuxt-stable9906
✅ sveltekit-stable9906
✅ vite-stable9906
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable9906
✅ express-stable9906
✅ fastify-stable9906
✅ hono-stable9906
✅ nextjs-turbopack-canary86019
✅ nextjs-turbopack-stable10500
✅ nextjs-webpack-canary86019
✅ nextjs-webpack-stable10500
✅ nitro-stable9906
✅ nuxt-stable9906
✅ sveltekit-stable9906
✅ vite-stable9906
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack10500
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev403
✅ redis-dev403
❌ redis67190
✅ turso-dev403
❌ turso3830
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable9906
✅ e2e-local-dev-tanstack-start-stable9906
✅ e2e-local-postgres-nest-stable9906
✅ e2e-local-postgres-tanstack-start-stable9906
✅ e2e-local-prod-nest-stable9906
✅ e2e-local-prod-tanstack-start-stable9906

📋 View full workflow run

@TooTallNateTooTallNate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this backport against the original #2925 (which I reviewed on main earlier today) hunk by hunk, with attention on the AI-resolved conflicts. Approving.

Fidelity:vite.ts and the changeset are byte-identical to the original. The two files that differ are both correct context adaptations, not semantic drift:

  • index.ts: the same workflowBuildDir → whole-buildDir exclusion swap (identical construction, including the trailing-slash discipline), applied against stable's surrounding context, which lacks main's world-target-injection code. I also checked the lint hazard this kind of resolution can create: join from pathe remains used elsewhere in stable's file (manifest handler paths, steps bundle), so no unused import was left behind.
  • index.test.ts: the resolution correctly added the viteWorkflow import that main's test file already had from neighboring tests — stable's smaller test file needed it introduced.

Applicability confirmed: stable does ship the Nitro-in-Vite pipeline (vite.ts exists with the same exclusion logic, and the tanstack-start e2e lanes run on stable), so this fixes a real 4.x exposure rather than backporting dead code.

Verified locally on the branch:@workflow/nitro builds; the regression test passes (does not re-transform generated Nitro build artifacts, exercising both transform hooks with the serde-class crash vector and the sibling-directory negative case); the single biome warning is pre-existing on the stable baseline (identical before/after).

CI: every lane that exercises this change is green — nitro/nuxt/vite/tanstack-start across dev, prod, postgres, and Vercel-prod, plus all four workbench deployments. The 4 failures are the known stable-branch baseline set: Community World Turso (same lane failed on the #2818/#2926 backports), its required-check aggregator, and the chronically flaky hono/sveltekit Vercel-prod lanes — none of which touch the Nitro transform path.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@TooTallNate@NathanColosimo
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Backport #2925: Fix duplicate transforms of Nitro build artifacts by github-actions[bot] · Pull Request #2928 · vercel/workflow · GitHub
Skip to content

Backport #2925: Fix duplicate transforms of Nitro build artifacts - #2928

Merged
NathanColosimo merged 2 commits into
stablefrom
backport/pr-2925-to-stable
Jul 14, 2026
Merged

Backport #2925: Fix duplicate transforms of Nitro build artifacts#2928
NathanColosimo merged 2 commits into
stablefrom
backport/pr-2925-to-stable

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated backport of #2925 to stable (backport job run).

AI recommendation: This is a self-contained bug fix that broadens the Nitro transform exclusion from only the pre-built workflow bundle directory to all generated Nitro build artifacts, preventing duplicate class registration. The affected files (packages/nitro/src/index.ts and vite.ts) and the exact workflowBuildDir exclusion logic being fixed exist unchanged on stable, and the change comes with a regression test, so it applies cleanly to the stable branch.

Merge conflicts were resolved by AI (opencode with anthropic/claude-opus-4.8). Please review the conflict resolution carefully before merging.

Signed-off-by: Nathan Colosimo <110621881+NathanColosimo@users.noreply.github.com>
@changeset-bot

changeset-botBot commented Jul 14, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 759ef8b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
NameType
@workflow/nitroPatch
@workflow/nuxtPatch
workflowPatch
@workflow/world-testingPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

@NathanColosimo
NathanColosimo enabled auto-merge (squash) July 14, 2026 22:47
@github-actions

github-actionsBot commented Jul 14, 2026

Copy link
Copy Markdown
ContributorAuthor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production10770781155
✅ 💻 Local Development11740861260
✅ 📦 Local Production11740861260
✅ 🐘 Local Postgres11740861260
✅ 🪟 Windows10500105
❌ 🌍 Community Worlds821029193
✅ 📋 Other594036630
Total53801023815863

❌ Failed Tests

🌍 Community Worlds (102 failed)

redis (19 failed):

  • hookWorkflow | wrun_01KXHEKY8Z3V27355GFY2QXW4X
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KXHEM663CXM1R1FAZP64EKNE
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01KXHEMG6YBMCF2C17TJ0TNDJ0
  • sleepingWorkflow | wrun_01KXHENQB8WQDWT88EG71PCYHF
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KXHEXYD0TATRPA9SH6GV7KK1
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01KXHEYCAESVKWEQ6H19HQKTJV
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01KXHEYMCTDMEMK3V3QSK1S264
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01KXHEZ26S60A40DGF1SCE5YKY
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01KXHEZXNY0B1MJDTVDKC4F54T
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01KXHF02M5B3XCH6B3EMZK7CQX
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01KXHF09HAMS6EAT4PSS0QPEXK
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01KXHF0FRHQ3G1BDGTTDKR21K9
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01KXHF0SRMKCPB452G17ET3N0N
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KXHF712XFC0A3HDP0FKE8BBQ

turso (83 failed):

  • addTenWorkflow | wrun_01KXHEK06WN31QJ8X8CNXPT8DY
  • addTenWorkflow | wrun_01KXHEK06WN31QJ8X8CNXPT8DY
  • deploymentId: 'latest' is a no-op in non-Vercel worlds
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KXHEN6X0MBPT9WHSBAVQVGMS
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KXHEK8X194MFGKY3ZNNVY68F
  • promiseRaceWorkflow | wrun_01KXHEKCV1MX2ZFAJVCRFANSWF
  • promiseAnyWorkflow | wrun_01KXHEKF8A87ZX579R5YKNMRP4
  • importedStepOnlyWorkflow | wrun_01KXHENJHVXXT7BDTM01CPSCBQ
  • readableStreamWorkflow | wrun_01KXHEKHR0EEGJPXNKG3QK1E0H
  • hookWorkflow | wrun_01KXHEKY8Z3V27355GFY2QXW4X
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KXHEM663CXM1R1FAZP64EKNE
  • webhookWorkflow | wrun_01KXHEMASEN4B21TKNCF3Q495B
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01KXHEMG6YBMCF2C17TJ0TNDJ0
  • sleepingWorkflow | wrun_01KXHENQB8WQDWT88EG71PCYHF
  • parallelSleepWorkflow | wrun_01KXHEP777316PRTNSPE04Y91A
  • sleepWinsRaceWorkflow | wrun_01KXHEPAVJ2AGE1B2J36VX48RT
  • stepWinsRaceWorkflow | wrun_01KXHEPEK98BNEMZ5CPPWAJ381
  • nullByteWorkflow | wrun_01KXHEPJ485YNJDAG1GPE97EGG
  • workflowAndStepMetadataWorkflow | wrun_01KXHEPMFY2S21BF283SQY022K
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KXHES49HNSDA2NJXY4CV67P7
  • writableForwardedFromWorkflowWorkflow | wrun_01KXHESHKK3WJWDAD0FPWZJ16N
  • writableForwardedFromStepWorkflow | wrun_01KXHESNW290K514FE74R3HBJQ
  • fetchWorkflow | wrun_01KXHESSG3ZMHT32YTRRT5G8GW
  • promiseRaceStressTestWorkflow | wrun_01KXHESX4SKBTBPJ4V4123P0KW
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KXHEXH0H9QX17CW7JWFWY631
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KXHEXYD0TATRPA9SH6GV7KK1
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01KXHEYCAESVKWEQ6H19HQKTJV
  • 'hookGetConflictWithPriorStepWorkflow' - hook.getConflict() does not block step execution | wrun_01KXHEYF0HP1K7S2JVDWGYYGD4
  • 'hookGetConflictWithParallelStepWorkfl…' - hook.getConflict() does not block step execution | wrun_01KXHEYHPDK3HZPSHHTX6P7QEB
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01KXHEYMCTDMEMK3V3QSK1S264
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01KXHEZ26S60A40DGF1SCE5YKY
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01KXHEZXNY0B1MJDTVDKC4F54T
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01KXHF02M5B3XCH6B3EMZK7CQX
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01KXHF09HAMS6EAT4PSS0QPEXK
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01KXHF0FRHQ3G1BDGTTDKR21K9
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01KXHF0SRMKCPB452G17ET3N0N
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KXHF111RYBYQ7SH6CT80HJFW
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KXHF1J68Y9B5EER5MTN2XCWR
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KXHF1WBNC7E3J0HRT5DE3S06
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KXHF22FB29GZ6RKX5QJK3G9N
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KXHF24X27PH1ZTCKGWBWWM4G
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KXHF2NAJRKGVV5E6M5N7N9VQ
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KXHF2VW65TDQHJ5Y3WKDSP67
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KXHF33B47HMR8FHGJ6RS0T10
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KXHF3ATG14ZAHJND9X74Q53Z
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KXHF3J9RFVQ8A11432VSS5T8
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KXHF3SPHJ0BG8W754YRFJ21P
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KXHF41BWBFMF6S115F80SKXE
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KXHF4FKKWYWYC2BTA84MDV2Z
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KXHF4S7T6Z12RM6NQRJ7M0V5
  • cancelRun - cancelling a running workflow | wrun_01KXHF50HXYW7WX7H03S4V00G4
  • cancelRun via CLI - cancelling a running workflow | wrun_01KXHF55V9D52023GBHV05MCYR
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KXHF5EXCS7GETSHFHJRVWVSV
  • hookWithSleepFinalStepWorkflow - step only on final payload | wrun_01KXHF5Y7MM8N3B8VJ13C9JTMW
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KXHF682EYKGHTK96HR9SG1QQ
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KXHF6MJ5T92TK64Y9G60PHT0
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KXHF6VVW1B7N5DEC0V1BQ4GR
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KXHF6YNXM7VR30FPWGKADB9V
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KXHF712XFC0A3HDP0FKE8BBQ

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro9708
✅ example9708
✅ express9708
✅ fastify9708
✅ hono9708
✅ nextjs-turbopack10203
✅ nextjs-webpack10203
✅ nitro9708
✅ nuxt9708
✅ sveltekit9708
✅ vite9708
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable9906
✅ express-stable9906
✅ fastify-stable9906
✅ hono-stable9906
✅ nextjs-turbopack-canary86019
✅ nextjs-turbopack-stable10500
✅ nextjs-webpack-canary86019
✅ nextjs-webpack-stable10500
✅ nitro-stable9906
✅ nuxt-stable9906
✅ sveltekit-stable9906
✅ vite-stable9906
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable9906
✅ express-stable9906
✅ fastify-stable9906
✅ hono-stable9906
✅ nextjs-turbopack-canary86019
✅ nextjs-turbopack-stable10500
✅ nextjs-webpack-canary86019
✅ nextjs-webpack-stable10500
✅ nitro-stable9906
✅ nuxt-stable9906
✅ sveltekit-stable9906
✅ vite-stable9906
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable9906
✅ express-stable9906
✅ fastify-stable9906
✅ hono-stable9906
✅ nextjs-turbopack-canary86019
✅ nextjs-turbopack-stable10500
✅ nextjs-webpack-canary86019
✅ nextjs-webpack-stable10500
✅ nitro-stable9906
✅ nuxt-stable9906
✅ sveltekit-stable9906
✅ vite-stable9906
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack10500
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev403
✅ redis-dev403
❌ redis67190
✅ turso-dev403
❌ turso3830
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable9906
✅ e2e-local-dev-tanstack-start-stable9906
✅ e2e-local-postgres-nest-stable9906
✅ e2e-local-postgres-tanstack-start-stable9906
✅ e2e-local-prod-nest-stable9906
✅ e2e-local-prod-tanstack-start-stable9906

📋 View full workflow run

@TooTallNateTooTallNate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this backport against the original #2925 (which I reviewed on main earlier today) hunk by hunk, with attention on the AI-resolved conflicts. Approving.

Fidelity:vite.ts and the changeset are byte-identical to the original. The two files that differ are both correct context adaptations, not semantic drift:

  • index.ts: the same workflowBuildDir → whole-buildDir exclusion swap (identical construction, including the trailing-slash discipline), applied against stable's surrounding context, which lacks main's world-target-injection code. I also checked the lint hazard this kind of resolution can create: join from pathe remains used elsewhere in stable's file (manifest handler paths, steps bundle), so no unused import was left behind.
  • index.test.ts: the resolution correctly added the viteWorkflow import that main's test file already had from neighboring tests — stable's smaller test file needed it introduced.

Applicability confirmed: stable does ship the Nitro-in-Vite pipeline (vite.ts exists with the same exclusion logic, and the tanstack-start e2e lanes run on stable), so this fixes a real 4.x exposure rather than backporting dead code.

Verified locally on the branch:@workflow/nitro builds; the regression test passes (does not re-transform generated Nitro build artifacts, exercising both transform hooks with the serde-class crash vector and the sibling-directory negative case); the single biome warning is pre-existing on the stable baseline (identical before/after).

CI: every lane that exercises this change is green — nitro/nuxt/vite/tanstack-start across dev, prod, postgres, and Vercel-prod, plus all four workbench deployments. The 4 failures are the known stable-branch baseline set: Community World Turso (same lane failed on the #2818/#2926 backports), its required-check aggregator, and the chronically flaky hono/sveltekit Vercel-prod lanes — none of which touch the Nitro transform path.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@TooTallNate@NathanColosimo
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Backport #2925: Fix duplicate transforms of Nitro build artifacts by github-actions[bot] · Pull Request #2928 · vercel/workflow · GitHub
Skip to content

Backport #2925: Fix duplicate transforms of Nitro build artifacts - #2928

Merged
NathanColosimo merged 2 commits into
stablefrom
backport/pr-2925-to-stable
Jul 14, 2026
Merged

Backport #2925: Fix duplicate transforms of Nitro build artifacts#2928
NathanColosimo merged 2 commits into
stablefrom
backport/pr-2925-to-stable

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated backport of #2925 to stable (backport job run).

AI recommendation: This is a self-contained bug fix that broadens the Nitro transform exclusion from only the pre-built workflow bundle directory to all generated Nitro build artifacts, preventing duplicate class registration. The affected files (packages/nitro/src/index.ts and vite.ts) and the exact workflowBuildDir exclusion logic being fixed exist unchanged on stable, and the change comes with a regression test, so it applies cleanly to the stable branch.

Merge conflicts were resolved by AI (opencode with anthropic/claude-opus-4.8). Please review the conflict resolution carefully before merging.

Signed-off-by: Nathan Colosimo <110621881+NathanColosimo@users.noreply.github.com>
@changeset-bot

changeset-botBot commented Jul 14, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 759ef8b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
NameType
@workflow/nitroPatch
@workflow/nuxtPatch
workflowPatch
@workflow/world-testingPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

@NathanColosimo
NathanColosimo enabled auto-merge (squash) July 14, 2026 22:47
@github-actions

github-actionsBot commented Jul 14, 2026

Copy link
Copy Markdown
ContributorAuthor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production10770781155
✅ 💻 Local Development11740861260
✅ 📦 Local Production11740861260
✅ 🐘 Local Postgres11740861260
✅ 🪟 Windows10500105
❌ 🌍 Community Worlds821029193
✅ 📋 Other594036630
Total53801023815863

❌ Failed Tests

🌍 Community Worlds (102 failed)

redis (19 failed):

  • hookWorkflow | wrun_01KXHEKY8Z3V27355GFY2QXW4X
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KXHEM663CXM1R1FAZP64EKNE
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01KXHEMG6YBMCF2C17TJ0TNDJ0
  • sleepingWorkflow | wrun_01KXHENQB8WQDWT88EG71PCYHF
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KXHEXYD0TATRPA9SH6GV7KK1
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01KXHEYCAESVKWEQ6H19HQKTJV
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01KXHEYMCTDMEMK3V3QSK1S264
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01KXHEZ26S60A40DGF1SCE5YKY
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01KXHEZXNY0B1MJDTVDKC4F54T
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01KXHF02M5B3XCH6B3EMZK7CQX
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01KXHF09HAMS6EAT4PSS0QPEXK
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01KXHF0FRHQ3G1BDGTTDKR21K9
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01KXHF0SRMKCPB452G17ET3N0N
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KXHF712XFC0A3HDP0FKE8BBQ

turso (83 failed):

  • addTenWorkflow | wrun_01KXHEK06WN31QJ8X8CNXPT8DY
  • addTenWorkflow | wrun_01KXHEK06WN31QJ8X8CNXPT8DY
  • deploymentId: 'latest' is a no-op in non-Vercel worlds
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KXHEN6X0MBPT9WHSBAVQVGMS
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KXHEK8X194MFGKY3ZNNVY68F
  • promiseRaceWorkflow | wrun_01KXHEKCV1MX2ZFAJVCRFANSWF
  • promiseAnyWorkflow | wrun_01KXHEKF8A87ZX579R5YKNMRP4
  • importedStepOnlyWorkflow | wrun_01KXHENJHVXXT7BDTM01CPSCBQ
  • readableStreamWorkflow | wrun_01KXHEKHR0EEGJPXNKG3QK1E0H
  • hookWorkflow | wrun_01KXHEKY8Z3V27355GFY2QXW4X
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KXHEM663CXM1R1FAZP64EKNE
  • webhookWorkflow | wrun_01KXHEMASEN4B21TKNCF3Q495B
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01KXHEMG6YBMCF2C17TJ0TNDJ0
  • sleepingWorkflow | wrun_01KXHENQB8WQDWT88EG71PCYHF
  • parallelSleepWorkflow | wrun_01KXHEP777316PRTNSPE04Y91A
  • sleepWinsRaceWorkflow | wrun_01KXHEPAVJ2AGE1B2J36VX48RT
  • stepWinsRaceWorkflow | wrun_01KXHEPEK98BNEMZ5CPPWAJ381
  • nullByteWorkflow | wrun_01KXHEPJ485YNJDAG1GPE97EGG
  • workflowAndStepMetadataWorkflow | wrun_01KXHEPMFY2S21BF283SQY022K
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KXHES49HNSDA2NJXY4CV67P7
  • writableForwardedFromWorkflowWorkflow | wrun_01KXHESHKK3WJWDAD0FPWZJ16N
  • writableForwardedFromStepWorkflow | wrun_01KXHESNW290K514FE74R3HBJQ
  • fetchWorkflow | wrun_01KXHESSG3ZMHT32YTRRT5G8GW
  • promiseRaceStressTestWorkflow | wrun_01KXHESX4SKBTBPJ4V4123P0KW
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KXHEXH0H9QX17CW7JWFWY631
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KXHEXYD0TATRPA9SH6GV7KK1
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01KXHEYCAESVKWEQ6H19HQKTJV
  • 'hookGetConflictWithPriorStepWorkflow' - hook.getConflict() does not block step execution | wrun_01KXHEYF0HP1K7S2JVDWGYYGD4
  • 'hookGetConflictWithParallelStepWorkfl…' - hook.getConflict() does not block step execution | wrun_01KXHEYHPDK3HZPSHHTX6P7QEB
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01KXHEYMCTDMEMK3V3QSK1S264
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01KXHEZ26S60A40DGF1SCE5YKY
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01KXHEZXNY0B1MJDTVDKC4F54T
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01KXHF02M5B3XCH6B3EMZK7CQX
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01KXHF09HAMS6EAT4PSS0QPEXK
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01KXHF0FRHQ3G1BDGTTDKR21K9
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01KXHF0SRMKCPB452G17ET3N0N
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KXHF111RYBYQ7SH6CT80HJFW
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KXHF1J68Y9B5EER5MTN2XCWR
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KXHF1WBNC7E3J0HRT5DE3S06
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KXHF22FB29GZ6RKX5QJK3G9N
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KXHF24X27PH1ZTCKGWBWWM4G
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KXHF2NAJRKGVV5E6M5N7N9VQ
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KXHF2VW65TDQHJ5Y3WKDSP67
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KXHF33B47HMR8FHGJ6RS0T10
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KXHF3ATG14ZAHJND9X74Q53Z
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KXHF3J9RFVQ8A11432VSS5T8
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KXHF3SPHJ0BG8W754YRFJ21P
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KXHF41BWBFMF6S115F80SKXE
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KXHF4FKKWYWYC2BTA84MDV2Z
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KXHF4S7T6Z12RM6NQRJ7M0V5
  • cancelRun - cancelling a running workflow | wrun_01KXHF50HXYW7WX7H03S4V00G4
  • cancelRun via CLI - cancelling a running workflow | wrun_01KXHF55V9D52023GBHV05MCYR
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KXHF5EXCS7GETSHFHJRVWVSV
  • hookWithSleepFinalStepWorkflow - step only on final payload | wrun_01KXHF5Y7MM8N3B8VJ13C9JTMW
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KXHF682EYKGHTK96HR9SG1QQ
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KXHF6MJ5T92TK64Y9G60PHT0
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KXHF6VVW1B7N5DEC0V1BQ4GR
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KXHF6YNXM7VR30FPWGKADB9V
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KXHF712XFC0A3HDP0FKE8BBQ

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro9708
✅ example9708
✅ express9708
✅ fastify9708
✅ hono9708
✅ nextjs-turbopack10203
✅ nextjs-webpack10203
✅ nitro9708
✅ nuxt9708
✅ sveltekit9708
✅ vite9708
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable9906
✅ express-stable9906
✅ fastify-stable9906
✅ hono-stable9906
✅ nextjs-turbopack-canary86019
✅ nextjs-turbopack-stable10500
✅ nextjs-webpack-canary86019
✅ nextjs-webpack-stable10500
✅ nitro-stable9906
✅ nuxt-stable9906
✅ sveltekit-stable9906
✅ vite-stable9906
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable9906
✅ express-stable9906
✅ fastify-stable9906
✅ hono-stable9906
✅ nextjs-turbopack-canary86019
✅ nextjs-turbopack-stable10500
✅ nextjs-webpack-canary86019
✅ nextjs-webpack-stable10500
✅ nitro-stable9906
✅ nuxt-stable9906
✅ sveltekit-stable9906
✅ vite-stable9906
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable9906
✅ express-stable9906
✅ fastify-stable9906
✅ hono-stable9906
✅ nextjs-turbopack-canary86019
✅ nextjs-turbopack-stable10500
✅ nextjs-webpack-canary86019
✅ nextjs-webpack-stable10500
✅ nitro-stable9906
✅ nuxt-stable9906
✅ sveltekit-stable9906
✅ vite-stable9906
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack10500
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev403
✅ redis-dev403
❌ redis67190
✅ turso-dev403
❌ turso3830
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable9906
✅ e2e-local-dev-tanstack-start-stable9906
✅ e2e-local-postgres-nest-stable9906
✅ e2e-local-postgres-tanstack-start-stable9906
✅ e2e-local-prod-nest-stable9906
✅ e2e-local-prod-tanstack-start-stable9906

📋 View full workflow run

@TooTallNateTooTallNate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this backport against the original #2925 (which I reviewed on main earlier today) hunk by hunk, with attention on the AI-resolved conflicts. Approving.

Fidelity:vite.ts and the changeset are byte-identical to the original. The two files that differ are both correct context adaptations, not semantic drift:

  • index.ts: the same workflowBuildDir → whole-buildDir exclusion swap (identical construction, including the trailing-slash discipline), applied against stable's surrounding context, which lacks main's world-target-injection code. I also checked the lint hazard this kind of resolution can create: join from pathe remains used elsewhere in stable's file (manifest handler paths, steps bundle), so no unused import was left behind.
  • index.test.ts: the resolution correctly added the viteWorkflow import that main's test file already had from neighboring tests — stable's smaller test file needed it introduced.

Applicability confirmed: stable does ship the Nitro-in-Vite pipeline (vite.ts exists with the same exclusion logic, and the tanstack-start e2e lanes run on stable), so this fixes a real 4.x exposure rather than backporting dead code.

Verified locally on the branch:@workflow/nitro builds; the regression test passes (does not re-transform generated Nitro build artifacts, exercising both transform hooks with the serde-class crash vector and the sibling-directory negative case); the single biome warning is pre-existing on the stable baseline (identical before/after).

CI: every lane that exercises this change is green — nitro/nuxt/vite/tanstack-start across dev, prod, postgres, and Vercel-prod, plus all four workbench deployments. The 4 failures are the known stable-branch baseline set: Community World Turso (same lane failed on the #2818/#2926 backports), its required-check aggregator, and the chronically flaky hono/sveltekit Vercel-prod lanes — none of which touch the Nitro transform path.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@TooTallNate@NathanColosimo
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Backport #2925: Fix duplicate transforms of Nitro build artifacts by github-actions[bot] · Pull Request #2928 · vercel/workflow · GitHub
Skip to content

Backport #2925: Fix duplicate transforms of Nitro build artifacts - #2928

Merged
NathanColosimo merged 2 commits into
stablefrom
backport/pr-2925-to-stable
Jul 14, 2026
Merged

Backport #2925: Fix duplicate transforms of Nitro build artifacts#2928
NathanColosimo merged 2 commits into
stablefrom
backport/pr-2925-to-stable

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated backport of #2925 to stable (backport job run).

AI recommendation: This is a self-contained bug fix that broadens the Nitro transform exclusion from only the pre-built workflow bundle directory to all generated Nitro build artifacts, preventing duplicate class registration. The affected files (packages/nitro/src/index.ts and vite.ts) and the exact workflowBuildDir exclusion logic being fixed exist unchanged on stable, and the change comes with a regression test, so it applies cleanly to the stable branch.

Merge conflicts were resolved by AI (opencode with anthropic/claude-opus-4.8). Please review the conflict resolution carefully before merging.

Signed-off-by: Nathan Colosimo <110621881+NathanColosimo@users.noreply.github.com>
@changeset-bot

changeset-botBot commented Jul 14, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 759ef8b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
NameType
@workflow/nitroPatch
@workflow/nuxtPatch
workflowPatch
@workflow/world-testingPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

@NathanColosimo
NathanColosimo enabled auto-merge (squash) July 14, 2026 22:47
@github-actions

github-actionsBot commented Jul 14, 2026

Copy link
Copy Markdown
ContributorAuthor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production10770781155
✅ 💻 Local Development11740861260
✅ 📦 Local Production11740861260
✅ 🐘 Local Postgres11740861260
✅ 🪟 Windows10500105
❌ 🌍 Community Worlds821029193
✅ 📋 Other594036630
Total53801023815863

❌ Failed Tests

🌍 Community Worlds (102 failed)

redis (19 failed):

  • hookWorkflow | wrun_01KXHEKY8Z3V27355GFY2QXW4X
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KXHEM663CXM1R1FAZP64EKNE
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01KXHEMG6YBMCF2C17TJ0TNDJ0
  • sleepingWorkflow | wrun_01KXHENQB8WQDWT88EG71PCYHF
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KXHEXYD0TATRPA9SH6GV7KK1
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01KXHEYCAESVKWEQ6H19HQKTJV
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01KXHEYMCTDMEMK3V3QSK1S264
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01KXHEZ26S60A40DGF1SCE5YKY
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01KXHEZXNY0B1MJDTVDKC4F54T
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01KXHF02M5B3XCH6B3EMZK7CQX
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01KXHF09HAMS6EAT4PSS0QPEXK
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01KXHF0FRHQ3G1BDGTTDKR21K9
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01KXHF0SRMKCPB452G17ET3N0N
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KXHF712XFC0A3HDP0FKE8BBQ

turso (83 failed):

  • addTenWorkflow | wrun_01KXHEK06WN31QJ8X8CNXPT8DY
  • addTenWorkflow | wrun_01KXHEK06WN31QJ8X8CNXPT8DY
  • deploymentId: 'latest' is a no-op in non-Vercel worlds
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KXHEN6X0MBPT9WHSBAVQVGMS
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KXHEK8X194MFGKY3ZNNVY68F
  • promiseRaceWorkflow | wrun_01KXHEKCV1MX2ZFAJVCRFANSWF
  • promiseAnyWorkflow | wrun_01KXHEKF8A87ZX579R5YKNMRP4
  • importedStepOnlyWorkflow | wrun_01KXHENJHVXXT7BDTM01CPSCBQ
  • readableStreamWorkflow | wrun_01KXHEKHR0EEGJPXNKG3QK1E0H
  • hookWorkflow | wrun_01KXHEKY8Z3V27355GFY2QXW4X
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KXHEM663CXM1R1FAZP64EKNE
  • webhookWorkflow | wrun_01KXHEMASEN4B21TKNCF3Q495B
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01KXHEMG6YBMCF2C17TJ0TNDJ0
  • sleepingWorkflow | wrun_01KXHENQB8WQDWT88EG71PCYHF
  • parallelSleepWorkflow | wrun_01KXHEP777316PRTNSPE04Y91A
  • sleepWinsRaceWorkflow | wrun_01KXHEPAVJ2AGE1B2J36VX48RT
  • stepWinsRaceWorkflow | wrun_01KXHEPEK98BNEMZ5CPPWAJ381
  • nullByteWorkflow | wrun_01KXHEPJ485YNJDAG1GPE97EGG
  • workflowAndStepMetadataWorkflow | wrun_01KXHEPMFY2S21BF283SQY022K
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KXHES49HNSDA2NJXY4CV67P7
  • writableForwardedFromWorkflowWorkflow | wrun_01KXHESHKK3WJWDAD0FPWZJ16N
  • writableForwardedFromStepWorkflow | wrun_01KXHESNW290K514FE74R3HBJQ
  • fetchWorkflow | wrun_01KXHESSG3ZMHT32YTRRT5G8GW
  • promiseRaceStressTestWorkflow | wrun_01KXHESX4SKBTBPJ4V4123P0KW
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KXHEXH0H9QX17CW7JWFWY631
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KXHEXYD0TATRPA9SH6GV7KK1
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01KXHEYCAESVKWEQ6H19HQKTJV
  • 'hookGetConflictWithPriorStepWorkflow' - hook.getConflict() does not block step execution | wrun_01KXHEYF0HP1K7S2JVDWGYYGD4
  • 'hookGetConflictWithParallelStepWorkfl…' - hook.getConflict() does not block step execution | wrun_01KXHEYHPDK3HZPSHHTX6P7QEB
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01KXHEYMCTDMEMK3V3QSK1S264
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01KXHEZ26S60A40DGF1SCE5YKY
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01KXHEZXNY0B1MJDTVDKC4F54T
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01KXHF02M5B3XCH6B3EMZK7CQX
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01KXHF09HAMS6EAT4PSS0QPEXK
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01KXHF0FRHQ3G1BDGTTDKR21K9
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01KXHF0SRMKCPB452G17ET3N0N
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KXHF111RYBYQ7SH6CT80HJFW
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KXHF1J68Y9B5EER5MTN2XCWR
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KXHF1WBNC7E3J0HRT5DE3S06
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KXHF22FB29GZ6RKX5QJK3G9N
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KXHF24X27PH1ZTCKGWBWWM4G
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KXHF2NAJRKGVV5E6M5N7N9VQ
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KXHF2VW65TDQHJ5Y3WKDSP67
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KXHF33B47HMR8FHGJ6RS0T10
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KXHF3ATG14ZAHJND9X74Q53Z
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KXHF3J9RFVQ8A11432VSS5T8
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KXHF3SPHJ0BG8W754YRFJ21P
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KXHF41BWBFMF6S115F80SKXE
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KXHF4FKKWYWYC2BTA84MDV2Z
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KXHF4S7T6Z12RM6NQRJ7M0V5
  • cancelRun - cancelling a running workflow | wrun_01KXHF50HXYW7WX7H03S4V00G4
  • cancelRun via CLI - cancelling a running workflow | wrun_01KXHF55V9D52023GBHV05MCYR
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KXHF5EXCS7GETSHFHJRVWVSV
  • hookWithSleepFinalStepWorkflow - step only on final payload | wrun_01KXHF5Y7MM8N3B8VJ13C9JTMW
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KXHF682EYKGHTK96HR9SG1QQ
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KXHF6MJ5T92TK64Y9G60PHT0
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KXHF6VVW1B7N5DEC0V1BQ4GR
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KXHF6YNXM7VR30FPWGKADB9V
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KXHF712XFC0A3HDP0FKE8BBQ

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro9708
✅ example9708
✅ express9708
✅ fastify9708
✅ hono9708
✅ nextjs-turbopack10203
✅ nextjs-webpack10203
✅ nitro9708
✅ nuxt9708
✅ sveltekit9708
✅ vite9708
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable9906
✅ express-stable9906
✅ fastify-stable9906
✅ hono-stable9906
✅ nextjs-turbopack-canary86019
✅ nextjs-turbopack-stable10500
✅ nextjs-webpack-canary86019
✅ nextjs-webpack-stable10500
✅ nitro-stable9906
✅ nuxt-stable9906
✅ sveltekit-stable9906
✅ vite-stable9906
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable9906
✅ express-stable9906
✅ fastify-stable9906
✅ hono-stable9906
✅ nextjs-turbopack-canary86019
✅ nextjs-turbopack-stable10500
✅ nextjs-webpack-canary86019
✅ nextjs-webpack-stable10500
✅ nitro-stable9906
✅ nuxt-stable9906
✅ sveltekit-stable9906
✅ vite-stable9906
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable9906
✅ express-stable9906
✅ fastify-stable9906
✅ hono-stable9906
✅ nextjs-turbopack-canary86019
✅ nextjs-turbopack-stable10500
✅ nextjs-webpack-canary86019
✅ nextjs-webpack-stable10500
✅ nitro-stable9906
✅ nuxt-stable9906
✅ sveltekit-stable9906
✅ vite-stable9906
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack10500
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev403
✅ redis-dev403
❌ redis67190
✅ turso-dev403
❌ turso3830
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable9906
✅ e2e-local-dev-tanstack-start-stable9906
✅ e2e-local-postgres-nest-stable9906
✅ e2e-local-postgres-tanstack-start-stable9906
✅ e2e-local-prod-nest-stable9906
✅ e2e-local-prod-tanstack-start-stable9906

📋 View full workflow run

@TooTallNateTooTallNate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this backport against the original #2925 (which I reviewed on main earlier today) hunk by hunk, with attention on the AI-resolved conflicts. Approving.

Fidelity:vite.ts and the changeset are byte-identical to the original. The two files that differ are both correct context adaptations, not semantic drift:

  • index.ts: the same workflowBuildDir → whole-buildDir exclusion swap (identical construction, including the trailing-slash discipline), applied against stable's surrounding context, which lacks main's world-target-injection code. I also checked the lint hazard this kind of resolution can create: join from pathe remains used elsewhere in stable's file (manifest handler paths, steps bundle), so no unused import was left behind.
  • index.test.ts: the resolution correctly added the viteWorkflow import that main's test file already had from neighboring tests — stable's smaller test file needed it introduced.

Applicability confirmed: stable does ship the Nitro-in-Vite pipeline (vite.ts exists with the same exclusion logic, and the tanstack-start e2e lanes run on stable), so this fixes a real 4.x exposure rather than backporting dead code.

Verified locally on the branch:@workflow/nitro builds; the regression test passes (does not re-transform generated Nitro build artifacts, exercising both transform hooks with the serde-class crash vector and the sibling-directory negative case); the single biome warning is pre-existing on the stable baseline (identical before/after).

CI: every lane that exercises this change is green — nitro/nuxt/vite/tanstack-start across dev, prod, postgres, and Vercel-prod, plus all four workbench deployments. The 4 failures are the known stable-branch baseline set: Community World Turso (same lane failed on the #2818/#2926 backports), its required-check aggregator, and the chronically flaky hono/sveltekit Vercel-prod lanes — none of which touch the Nitro transform path.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@TooTallNate@NathanColosimo
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Backport #2925: Fix duplicate transforms of Nitro build artifacts by github-actions[bot] · Pull Request #2928 · vercel/workflow · GitHub
Skip to content

Backport #2925: Fix duplicate transforms of Nitro build artifacts - #2928

Merged
NathanColosimo merged 2 commits into
stablefrom
backport/pr-2925-to-stable
Jul 14, 2026
Merged

Backport #2925: Fix duplicate transforms of Nitro build artifacts#2928
NathanColosimo merged 2 commits into
stablefrom
backport/pr-2925-to-stable

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated backport of #2925 to stable (backport job run).

AI recommendation: This is a self-contained bug fix that broadens the Nitro transform exclusion from only the pre-built workflow bundle directory to all generated Nitro build artifacts, preventing duplicate class registration. The affected files (packages/nitro/src/index.ts and vite.ts) and the exact workflowBuildDir exclusion logic being fixed exist unchanged on stable, and the change comes with a regression test, so it applies cleanly to the stable branch.

Merge conflicts were resolved by AI (opencode with anthropic/claude-opus-4.8). Please review the conflict resolution carefully before merging.

Signed-off-by: Nathan Colosimo <110621881+NathanColosimo@users.noreply.github.com>
@changeset-bot

changeset-botBot commented Jul 14, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 759ef8b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
NameType
@workflow/nitroPatch
@workflow/nuxtPatch
workflowPatch
@workflow/world-testingPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

@NathanColosimo
NathanColosimo enabled auto-merge (squash) July 14, 2026 22:47
@github-actions

github-actionsBot commented Jul 14, 2026

Copy link
Copy Markdown
ContributorAuthor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production10770781155
✅ 💻 Local Development11740861260
✅ 📦 Local Production11740861260
✅ 🐘 Local Postgres11740861260
✅ 🪟 Windows10500105
❌ 🌍 Community Worlds821029193
✅ 📋 Other594036630
Total53801023815863

❌ Failed Tests

🌍 Community Worlds (102 failed)

redis (19 failed):

  • hookWorkflow | wrun_01KXHEKY8Z3V27355GFY2QXW4X
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KXHEM663CXM1R1FAZP64EKNE
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01KXHEMG6YBMCF2C17TJ0TNDJ0
  • sleepingWorkflow | wrun_01KXHENQB8WQDWT88EG71PCYHF
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KXHEXYD0TATRPA9SH6GV7KK1
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01KXHEYCAESVKWEQ6H19HQKTJV
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01KXHEYMCTDMEMK3V3QSK1S264
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01KXHEZ26S60A40DGF1SCE5YKY
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01KXHEZXNY0B1MJDTVDKC4F54T
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01KXHF02M5B3XCH6B3EMZK7CQX
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01KXHF09HAMS6EAT4PSS0QPEXK
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01KXHF0FRHQ3G1BDGTTDKR21K9
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01KXHF0SRMKCPB452G17ET3N0N
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KXHF712XFC0A3HDP0FKE8BBQ

turso (83 failed):

  • addTenWorkflow | wrun_01KXHEK06WN31QJ8X8CNXPT8DY
  • addTenWorkflow | wrun_01KXHEK06WN31QJ8X8CNXPT8DY
  • deploymentId: 'latest' is a no-op in non-Vercel worlds
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KXHEN6X0MBPT9WHSBAVQVGMS
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KXHEK8X194MFGKY3ZNNVY68F
  • promiseRaceWorkflow | wrun_01KXHEKCV1MX2ZFAJVCRFANSWF
  • promiseAnyWorkflow | wrun_01KXHEKF8A87ZX579R5YKNMRP4
  • importedStepOnlyWorkflow | wrun_01KXHENJHVXXT7BDTM01CPSCBQ
  • readableStreamWorkflow | wrun_01KXHEKHR0EEGJPXNKG3QK1E0H
  • hookWorkflow | wrun_01KXHEKY8Z3V27355GFY2QXW4X
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KXHEM663CXM1R1FAZP64EKNE
  • webhookWorkflow | wrun_01KXHEMASEN4B21TKNCF3Q495B
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01KXHEMG6YBMCF2C17TJ0TNDJ0
  • sleepingWorkflow | wrun_01KXHENQB8WQDWT88EG71PCYHF
  • parallelSleepWorkflow | wrun_01KXHEP777316PRTNSPE04Y91A
  • sleepWinsRaceWorkflow | wrun_01KXHEPAVJ2AGE1B2J36VX48RT
  • stepWinsRaceWorkflow | wrun_01KXHEPEK98BNEMZ5CPPWAJ381
  • nullByteWorkflow | wrun_01KXHEPJ485YNJDAG1GPE97EGG
  • workflowAndStepMetadataWorkflow | wrun_01KXHEPMFY2S21BF283SQY022K
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KXHES49HNSDA2NJXY4CV67P7
  • writableForwardedFromWorkflowWorkflow | wrun_01KXHESHKK3WJWDAD0FPWZJ16N
  • writableForwardedFromStepWorkflow | wrun_01KXHESNW290K514FE74R3HBJQ
  • fetchWorkflow | wrun_01KXHESSG3ZMHT32YTRRT5G8GW
  • promiseRaceStressTestWorkflow | wrun_01KXHESX4SKBTBPJ4V4123P0KW
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KXHEXH0H9QX17CW7JWFWY631
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KXHEXYD0TATRPA9SH6GV7KK1
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01KXHEYCAESVKWEQ6H19HQKTJV
  • 'hookGetConflictWithPriorStepWorkflow' - hook.getConflict() does not block step execution | wrun_01KXHEYF0HP1K7S2JVDWGYYGD4
  • 'hookGetConflictWithParallelStepWorkfl…' - hook.getConflict() does not block step execution | wrun_01KXHEYHPDK3HZPSHHTX6P7QEB
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01KXHEYMCTDMEMK3V3QSK1S264
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01KXHEZ26S60A40DGF1SCE5YKY
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01KXHEZXNY0B1MJDTVDKC4F54T
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01KXHF02M5B3XCH6B3EMZK7CQX
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01KXHF09HAMS6EAT4PSS0QPEXK
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01KXHF0FRHQ3G1BDGTTDKR21K9
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01KXHF0SRMKCPB452G17ET3N0N
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KXHF111RYBYQ7SH6CT80HJFW
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KXHF1J68Y9B5EER5MTN2XCWR
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KXHF1WBNC7E3J0HRT5DE3S06
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KXHF22FB29GZ6RKX5QJK3G9N
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KXHF24X27PH1ZTCKGWBWWM4G
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KXHF2NAJRKGVV5E6M5N7N9VQ
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KXHF2VW65TDQHJ5Y3WKDSP67
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KXHF33B47HMR8FHGJ6RS0T10
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KXHF3ATG14ZAHJND9X74Q53Z
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KXHF3J9RFVQ8A11432VSS5T8
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KXHF3SPHJ0BG8W754YRFJ21P
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KXHF41BWBFMF6S115F80SKXE
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KXHF4FKKWYWYC2BTA84MDV2Z
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KXHF4S7T6Z12RM6NQRJ7M0V5
  • cancelRun - cancelling a running workflow | wrun_01KXHF50HXYW7WX7H03S4V00G4
  • cancelRun via CLI - cancelling a running workflow | wrun_01KXHF55V9D52023GBHV05MCYR
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KXHF5EXCS7GETSHFHJRVWVSV
  • hookWithSleepFinalStepWorkflow - step only on final payload | wrun_01KXHF5Y7MM8N3B8VJ13C9JTMW
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KXHF682EYKGHTK96HR9SG1QQ
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KXHF6MJ5T92TK64Y9G60PHT0
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KXHF6VVW1B7N5DEC0V1BQ4GR
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KXHF6YNXM7VR30FPWGKADB9V
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KXHF712XFC0A3HDP0FKE8BBQ

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro9708
✅ example9708
✅ express9708
✅ fastify9708
✅ hono9708
✅ nextjs-turbopack10203
✅ nextjs-webpack10203
✅ nitro9708
✅ nuxt9708
✅ sveltekit9708
✅ vite9708
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable9906
✅ express-stable9906
✅ fastify-stable9906
✅ hono-stable9906
✅ nextjs-turbopack-canary86019
✅ nextjs-turbopack-stable10500
✅ nextjs-webpack-canary86019
✅ nextjs-webpack-stable10500
✅ nitro-stable9906
✅ nuxt-stable9906
✅ sveltekit-stable9906
✅ vite-stable9906
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable9906
✅ express-stable9906
✅ fastify-stable9906
✅ hono-stable9906
✅ nextjs-turbopack-canary86019
✅ nextjs-turbopack-stable10500
✅ nextjs-webpack-canary86019
✅ nextjs-webpack-stable10500
✅ nitro-stable9906
✅ nuxt-stable9906
✅ sveltekit-stable9906
✅ vite-stable9906
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable9906
✅ express-stable9906
✅ fastify-stable9906
✅ hono-stable9906
✅ nextjs-turbopack-canary86019
✅ nextjs-turbopack-stable10500
✅ nextjs-webpack-canary86019
✅ nextjs-webpack-stable10500
✅ nitro-stable9906
✅ nuxt-stable9906
✅ sveltekit-stable9906
✅ vite-stable9906
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack10500
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev403
✅ redis-dev403
❌ redis67190
✅ turso-dev403
❌ turso3830
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable9906
✅ e2e-local-dev-tanstack-start-stable9906
✅ e2e-local-postgres-nest-stable9906
✅ e2e-local-postgres-tanstack-start-stable9906
✅ e2e-local-prod-nest-stable9906
✅ e2e-local-prod-tanstack-start-stable9906

📋 View full workflow run

@TooTallNateTooTallNate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this backport against the original #2925 (which I reviewed on main earlier today) hunk by hunk, with attention on the AI-resolved conflicts. Approving.

Fidelity:vite.ts and the changeset are byte-identical to the original. The two files that differ are both correct context adaptations, not semantic drift:

  • index.ts: the same workflowBuildDir → whole-buildDir exclusion swap (identical construction, including the trailing-slash discipline), applied against stable's surrounding context, which lacks main's world-target-injection code. I also checked the lint hazard this kind of resolution can create: join from pathe remains used elsewhere in stable's file (manifest handler paths, steps bundle), so no unused import was left behind.
  • index.test.ts: the resolution correctly added the viteWorkflow import that main's test file already had from neighboring tests — stable's smaller test file needed it introduced.

Applicability confirmed: stable does ship the Nitro-in-Vite pipeline (vite.ts exists with the same exclusion logic, and the tanstack-start e2e lanes run on stable), so this fixes a real 4.x exposure rather than backporting dead code.

Verified locally on the branch:@workflow/nitro builds; the regression test passes (does not re-transform generated Nitro build artifacts, exercising both transform hooks with the serde-class crash vector and the sibling-directory negative case); the single biome warning is pre-existing on the stable baseline (identical before/after).

CI: every lane that exercises this change is green — nitro/nuxt/vite/tanstack-start across dev, prod, postgres, and Vercel-prod, plus all four workbench deployments. The 4 failures are the known stable-branch baseline set: Community World Turso (same lane failed on the #2818/#2926 backports), its required-check aggregator, and the chronically flaky hono/sveltekit Vercel-prod lanes — none of which touch the Nitro transform path.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@TooTallNate@NathanColosimo
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Backport #2925: Fix duplicate transforms of Nitro build artifacts by github-actions[bot] · Pull Request #2928 · vercel/workflow · GitHub
Skip to content

Backport #2925: Fix duplicate transforms of Nitro build artifacts - #2928

Merged
NathanColosimo merged 2 commits into
stablefrom
backport/pr-2925-to-stable
Jul 14, 2026
Merged

Backport #2925: Fix duplicate transforms of Nitro build artifacts#2928
NathanColosimo merged 2 commits into
stablefrom
backport/pr-2925-to-stable

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated backport of #2925 to stable (backport job run).

AI recommendation: This is a self-contained bug fix that broadens the Nitro transform exclusion from only the pre-built workflow bundle directory to all generated Nitro build artifacts, preventing duplicate class registration. The affected files (packages/nitro/src/index.ts and vite.ts) and the exact workflowBuildDir exclusion logic being fixed exist unchanged on stable, and the change comes with a regression test, so it applies cleanly to the stable branch.

Merge conflicts were resolved by AI (opencode with anthropic/claude-opus-4.8). Please review the conflict resolution carefully before merging.

Signed-off-by: Nathan Colosimo <110621881+NathanColosimo@users.noreply.github.com>
@changeset-bot

changeset-botBot commented Jul 14, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 759ef8b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
NameType
@workflow/nitroPatch
@workflow/nuxtPatch
workflowPatch
@workflow/world-testingPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

@NathanColosimo
NathanColosimo enabled auto-merge (squash) July 14, 2026 22:47
@github-actions

github-actionsBot commented Jul 14, 2026

Copy link
Copy Markdown
ContributorAuthor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production10770781155
✅ 💻 Local Development11740861260
✅ 📦 Local Production11740861260
✅ 🐘 Local Postgres11740861260
✅ 🪟 Windows10500105
❌ 🌍 Community Worlds821029193
✅ 📋 Other594036630
Total53801023815863

❌ Failed Tests

🌍 Community Worlds (102 failed)

redis (19 failed):

  • hookWorkflow | wrun_01KXHEKY8Z3V27355GFY2QXW4X
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KXHEM663CXM1R1FAZP64EKNE
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01KXHEMG6YBMCF2C17TJ0TNDJ0
  • sleepingWorkflow | wrun_01KXHENQB8WQDWT88EG71PCYHF
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KXHEXYD0TATRPA9SH6GV7KK1
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01KXHEYCAESVKWEQ6H19HQKTJV
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01KXHEYMCTDMEMK3V3QSK1S264
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01KXHEZ26S60A40DGF1SCE5YKY
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01KXHEZXNY0B1MJDTVDKC4F54T
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01KXHF02M5B3XCH6B3EMZK7CQX
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01KXHF09HAMS6EAT4PSS0QPEXK
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01KXHF0FRHQ3G1BDGTTDKR21K9
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01KXHF0SRMKCPB452G17ET3N0N
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KXHF712XFC0A3HDP0FKE8BBQ

turso (83 failed):

  • addTenWorkflow | wrun_01KXHEK06WN31QJ8X8CNXPT8DY
  • addTenWorkflow | wrun_01KXHEK06WN31QJ8X8CNXPT8DY
  • deploymentId: 'latest' is a no-op in non-Vercel worlds
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KXHEN6X0MBPT9WHSBAVQVGMS
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KXHEK8X194MFGKY3ZNNVY68F
  • promiseRaceWorkflow | wrun_01KXHEKCV1MX2ZFAJVCRFANSWF
  • promiseAnyWorkflow | wrun_01KXHEKF8A87ZX579R5YKNMRP4
  • importedStepOnlyWorkflow | wrun_01KXHENJHVXXT7BDTM01CPSCBQ
  • readableStreamWorkflow | wrun_01KXHEKHR0EEGJPXNKG3QK1E0H
  • hookWorkflow | wrun_01KXHEKY8Z3V27355GFY2QXW4X
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KXHEM663CXM1R1FAZP64EKNE
  • webhookWorkflow | wrun_01KXHEMASEN4B21TKNCF3Q495B
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01KXHEMG6YBMCF2C17TJ0TNDJ0
  • sleepingWorkflow | wrun_01KXHENQB8WQDWT88EG71PCYHF
  • parallelSleepWorkflow | wrun_01KXHEP777316PRTNSPE04Y91A
  • sleepWinsRaceWorkflow | wrun_01KXHEPAVJ2AGE1B2J36VX48RT
  • stepWinsRaceWorkflow | wrun_01KXHEPEK98BNEMZ5CPPWAJ381
  • nullByteWorkflow | wrun_01KXHEPJ485YNJDAG1GPE97EGG
  • workflowAndStepMetadataWorkflow | wrun_01KXHEPMFY2S21BF283SQY022K
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KXHES49HNSDA2NJXY4CV67P7
  • writableForwardedFromWorkflowWorkflow | wrun_01KXHESHKK3WJWDAD0FPWZJ16N
  • writableForwardedFromStepWorkflow | wrun_01KXHESNW290K514FE74R3HBJQ
  • fetchWorkflow | wrun_01KXHESSG3ZMHT32YTRRT5G8GW
  • promiseRaceStressTestWorkflow | wrun_01KXHESX4SKBTBPJ4V4123P0KW
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KXHEXH0H9QX17CW7JWFWY631
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KXHEXYD0TATRPA9SH6GV7KK1
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01KXHEYCAESVKWEQ6H19HQKTJV
  • 'hookGetConflictWithPriorStepWorkflow' - hook.getConflict() does not block step execution | wrun_01KXHEYF0HP1K7S2JVDWGYYGD4
  • 'hookGetConflictWithParallelStepWorkfl…' - hook.getConflict() does not block step execution | wrun_01KXHEYHPDK3HZPSHHTX6P7QEB
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01KXHEYMCTDMEMK3V3QSK1S264
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01KXHEZ26S60A40DGF1SCE5YKY
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01KXHEZXNY0B1MJDTVDKC4F54T
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01KXHF02M5B3XCH6B3EMZK7CQX
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01KXHF09HAMS6EAT4PSS0QPEXK
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01KXHF0FRHQ3G1BDGTTDKR21K9
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01KXHF0SRMKCPB452G17ET3N0N
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KXHF111RYBYQ7SH6CT80HJFW
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KXHF1J68Y9B5EER5MTN2XCWR
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KXHF1WBNC7E3J0HRT5DE3S06
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KXHF22FB29GZ6RKX5QJK3G9N
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KXHF24X27PH1ZTCKGWBWWM4G
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KXHF2NAJRKGVV5E6M5N7N9VQ
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KXHF2VW65TDQHJ5Y3WKDSP67
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KXHF33B47HMR8FHGJ6RS0T10
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KXHF3ATG14ZAHJND9X74Q53Z
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KXHF3J9RFVQ8A11432VSS5T8
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KXHF3SPHJ0BG8W754YRFJ21P
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KXHF41BWBFMF6S115F80SKXE
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KXHF4FKKWYWYC2BTA84MDV2Z
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KXHF4S7T6Z12RM6NQRJ7M0V5
  • cancelRun - cancelling a running workflow | wrun_01KXHF50HXYW7WX7H03S4V00G4
  • cancelRun via CLI - cancelling a running workflow | wrun_01KXHF55V9D52023GBHV05MCYR
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KXHF5EXCS7GETSHFHJRVWVSV
  • hookWithSleepFinalStepWorkflow - step only on final payload | wrun_01KXHF5Y7MM8N3B8VJ13C9JTMW
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KXHF682EYKGHTK96HR9SG1QQ
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KXHF6MJ5T92TK64Y9G60PHT0
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KXHF6VVW1B7N5DEC0V1BQ4GR
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KXHF6YNXM7VR30FPWGKADB9V
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KXHF712XFC0A3HDP0FKE8BBQ

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro9708
✅ example9708
✅ express9708
✅ fastify9708
✅ hono9708
✅ nextjs-turbopack10203
✅ nextjs-webpack10203
✅ nitro9708
✅ nuxt9708
✅ sveltekit9708
✅ vite9708
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable9906
✅ express-stable9906
✅ fastify-stable9906
✅ hono-stable9906
✅ nextjs-turbopack-canary86019
✅ nextjs-turbopack-stable10500
✅ nextjs-webpack-canary86019
✅ nextjs-webpack-stable10500
✅ nitro-stable9906
✅ nuxt-stable9906
✅ sveltekit-stable9906
✅ vite-stable9906
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable9906
✅ express-stable9906
✅ fastify-stable9906
✅ hono-stable9906
✅ nextjs-turbopack-canary86019
✅ nextjs-turbopack-stable10500
✅ nextjs-webpack-canary86019
✅ nextjs-webpack-stable10500
✅ nitro-stable9906
✅ nuxt-stable9906
✅ sveltekit-stable9906
✅ vite-stable9906
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable9906
✅ express-stable9906
✅ fastify-stable9906
✅ hono-stable9906
✅ nextjs-turbopack-canary86019
✅ nextjs-turbopack-stable10500
✅ nextjs-webpack-canary86019
✅ nextjs-webpack-stable10500
✅ nitro-stable9906
✅ nuxt-stable9906
✅ sveltekit-stable9906
✅ vite-stable9906
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack10500
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev403
✅ redis-dev403
❌ redis67190
✅ turso-dev403
❌ turso3830
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable9906
✅ e2e-local-dev-tanstack-start-stable9906
✅ e2e-local-postgres-nest-stable9906
✅ e2e-local-postgres-tanstack-start-stable9906
✅ e2e-local-prod-nest-stable9906
✅ e2e-local-prod-tanstack-start-stable9906

📋 View full workflow run

@TooTallNateTooTallNate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this backport against the original #2925 (which I reviewed on main earlier today) hunk by hunk, with attention on the AI-resolved conflicts. Approving.

Fidelity:vite.ts and the changeset are byte-identical to the original. The two files that differ are both correct context adaptations, not semantic drift:

  • index.ts: the same workflowBuildDir → whole-buildDir exclusion swap (identical construction, including the trailing-slash discipline), applied against stable's surrounding context, which lacks main's world-target-injection code. I also checked the lint hazard this kind of resolution can create: join from pathe remains used elsewhere in stable's file (manifest handler paths, steps bundle), so no unused import was left behind.
  • index.test.ts: the resolution correctly added the viteWorkflow import that main's test file already had from neighboring tests — stable's smaller test file needed it introduced.

Applicability confirmed: stable does ship the Nitro-in-Vite pipeline (vite.ts exists with the same exclusion logic, and the tanstack-start e2e lanes run on stable), so this fixes a real 4.x exposure rather than backporting dead code.

Verified locally on the branch:@workflow/nitro builds; the regression test passes (does not re-transform generated Nitro build artifacts, exercising both transform hooks with the serde-class crash vector and the sibling-directory negative case); the single biome warning is pre-existing on the stable baseline (identical before/after).

CI: every lane that exercises this change is green — nitro/nuxt/vite/tanstack-start across dev, prod, postgres, and Vercel-prod, plus all four workbench deployments. The 4 failures are the known stable-branch baseline set: Community World Turso (same lane failed on the #2818/#2926 backports), its required-check aggregator, and the chronically flaky hono/sveltekit Vercel-prod lanes — none of which touch the Nitro transform path.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@TooTallNate@NathanColosimo
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Backport #2925: Fix duplicate transforms of Nitro build artifacts by github-actions[bot] · Pull Request #2928 · vercel/workflow · GitHub
Skip to content

Backport #2925: Fix duplicate transforms of Nitro build artifacts - #2928

Merged
NathanColosimo merged 2 commits into
stablefrom
backport/pr-2925-to-stable
Jul 14, 2026
Merged

Backport #2925: Fix duplicate transforms of Nitro build artifacts#2928
NathanColosimo merged 2 commits into
stablefrom
backport/pr-2925-to-stable

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated backport of #2925 to stable (backport job run).

AI recommendation: This is a self-contained bug fix that broadens the Nitro transform exclusion from only the pre-built workflow bundle directory to all generated Nitro build artifacts, preventing duplicate class registration. The affected files (packages/nitro/src/index.ts and vite.ts) and the exact workflowBuildDir exclusion logic being fixed exist unchanged on stable, and the change comes with a regression test, so it applies cleanly to the stable branch.

Merge conflicts were resolved by AI (opencode with anthropic/claude-opus-4.8). Please review the conflict resolution carefully before merging.

Signed-off-by: Nathan Colosimo <110621881+NathanColosimo@users.noreply.github.com>
@changeset-bot

changeset-botBot commented Jul 14, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 759ef8b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
NameType
@workflow/nitroPatch
@workflow/nuxtPatch
workflowPatch
@workflow/world-testingPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

@NathanColosimo
NathanColosimo enabled auto-merge (squash) July 14, 2026 22:47
@github-actions

github-actionsBot commented Jul 14, 2026

Copy link
Copy Markdown
ContributorAuthor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production10770781155
✅ 💻 Local Development11740861260
✅ 📦 Local Production11740861260
✅ 🐘 Local Postgres11740861260
✅ 🪟 Windows10500105
❌ 🌍 Community Worlds821029193
✅ 📋 Other594036630
Total53801023815863

❌ Failed Tests

🌍 Community Worlds (102 failed)

redis (19 failed):

  • hookWorkflow | wrun_01KXHEKY8Z3V27355GFY2QXW4X
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KXHEM663CXM1R1FAZP64EKNE
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01KXHEMG6YBMCF2C17TJ0TNDJ0
  • sleepingWorkflow | wrun_01KXHENQB8WQDWT88EG71PCYHF
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KXHEXYD0TATRPA9SH6GV7KK1
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01KXHEYCAESVKWEQ6H19HQKTJV
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01KXHEYMCTDMEMK3V3QSK1S264
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01KXHEZ26S60A40DGF1SCE5YKY
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01KXHEZXNY0B1MJDTVDKC4F54T
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01KXHF02M5B3XCH6B3EMZK7CQX
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01KXHF09HAMS6EAT4PSS0QPEXK
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01KXHF0FRHQ3G1BDGTTDKR21K9
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01KXHF0SRMKCPB452G17ET3N0N
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KXHF712XFC0A3HDP0FKE8BBQ

turso (83 failed):

  • addTenWorkflow | wrun_01KXHEK06WN31QJ8X8CNXPT8DY
  • addTenWorkflow | wrun_01KXHEK06WN31QJ8X8CNXPT8DY
  • deploymentId: 'latest' is a no-op in non-Vercel worlds
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KXHEN6X0MBPT9WHSBAVQVGMS
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KXHEK8X194MFGKY3ZNNVY68F
  • promiseRaceWorkflow | wrun_01KXHEKCV1MX2ZFAJVCRFANSWF
  • promiseAnyWorkflow | wrun_01KXHEKF8A87ZX579R5YKNMRP4
  • importedStepOnlyWorkflow | wrun_01KXHENJHVXXT7BDTM01CPSCBQ
  • readableStreamWorkflow | wrun_01KXHEKHR0EEGJPXNKG3QK1E0H
  • hookWorkflow | wrun_01KXHEKY8Z3V27355GFY2QXW4X
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KXHEM663CXM1R1FAZP64EKNE
  • webhookWorkflow | wrun_01KXHEMASEN4B21TKNCF3Q495B
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01KXHEMG6YBMCF2C17TJ0TNDJ0
  • sleepingWorkflow | wrun_01KXHENQB8WQDWT88EG71PCYHF
  • parallelSleepWorkflow | wrun_01KXHEP777316PRTNSPE04Y91A
  • sleepWinsRaceWorkflow | wrun_01KXHEPAVJ2AGE1B2J36VX48RT
  • stepWinsRaceWorkflow | wrun_01KXHEPEK98BNEMZ5CPPWAJ381
  • nullByteWorkflow | wrun_01KXHEPJ485YNJDAG1GPE97EGG
  • workflowAndStepMetadataWorkflow | wrun_01KXHEPMFY2S21BF283SQY022K
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KXHES49HNSDA2NJXY4CV67P7
  • writableForwardedFromWorkflowWorkflow | wrun_01KXHESHKK3WJWDAD0FPWZJ16N
  • writableForwardedFromStepWorkflow | wrun_01KXHESNW290K514FE74R3HBJQ
  • fetchWorkflow | wrun_01KXHESSG3ZMHT32YTRRT5G8GW
  • promiseRaceStressTestWorkflow | wrun_01KXHESX4SKBTBPJ4V4123P0KW
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KXHEXH0H9QX17CW7JWFWY631
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KXHEXYD0TATRPA9SH6GV7KK1
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01KXHEYCAESVKWEQ6H19HQKTJV
  • 'hookGetConflictWithPriorStepWorkflow' - hook.getConflict() does not block step execution | wrun_01KXHEYF0HP1K7S2JVDWGYYGD4
  • 'hookGetConflictWithParallelStepWorkfl…' - hook.getConflict() does not block step execution | wrun_01KXHEYHPDK3HZPSHHTX6P7QEB
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01KXHEYMCTDMEMK3V3QSK1S264
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01KXHEZ26S60A40DGF1SCE5YKY
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01KXHEZXNY0B1MJDTVDKC4F54T
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01KXHF02M5B3XCH6B3EMZK7CQX
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01KXHF09HAMS6EAT4PSS0QPEXK
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01KXHF0FRHQ3G1BDGTTDKR21K9
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01KXHF0SRMKCPB452G17ET3N0N
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KXHF111RYBYQ7SH6CT80HJFW
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KXHF1J68Y9B5EER5MTN2XCWR
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KXHF1WBNC7E3J0HRT5DE3S06
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KXHF22FB29GZ6RKX5QJK3G9N
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KXHF24X27PH1ZTCKGWBWWM4G
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KXHF2NAJRKGVV5E6M5N7N9VQ
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KXHF2VW65TDQHJ5Y3WKDSP67
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KXHF33B47HMR8FHGJ6RS0T10
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KXHF3ATG14ZAHJND9X74Q53Z
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KXHF3J9RFVQ8A11432VSS5T8
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KXHF3SPHJ0BG8W754YRFJ21P
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KXHF41BWBFMF6S115F80SKXE
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KXHF4FKKWYWYC2BTA84MDV2Z
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KXHF4S7T6Z12RM6NQRJ7M0V5
  • cancelRun - cancelling a running workflow | wrun_01KXHF50HXYW7WX7H03S4V00G4
  • cancelRun via CLI - cancelling a running workflow | wrun_01KXHF55V9D52023GBHV05MCYR
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KXHF5EXCS7GETSHFHJRVWVSV
  • hookWithSleepFinalStepWorkflow - step only on final payload | wrun_01KXHF5Y7MM8N3B8VJ13C9JTMW
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KXHF682EYKGHTK96HR9SG1QQ
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KXHF6MJ5T92TK64Y9G60PHT0
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KXHF6VVW1B7N5DEC0V1BQ4GR
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KXHF6YNXM7VR30FPWGKADB9V
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KXHF712XFC0A3HDP0FKE8BBQ

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro9708
✅ example9708
✅ express9708
✅ fastify9708
✅ hono9708
✅ nextjs-turbopack10203
✅ nextjs-webpack10203
✅ nitro9708
✅ nuxt9708
✅ sveltekit9708
✅ vite9708
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable9906
✅ express-stable9906
✅ fastify-stable9906
✅ hono-stable9906
✅ nextjs-turbopack-canary86019
✅ nextjs-turbopack-stable10500
✅ nextjs-webpack-canary86019
✅ nextjs-webpack-stable10500
✅ nitro-stable9906
✅ nuxt-stable9906
✅ sveltekit-stable9906
✅ vite-stable9906
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable9906
✅ express-stable9906
✅ fastify-stable9906
✅ hono-stable9906
✅ nextjs-turbopack-canary86019
✅ nextjs-turbopack-stable10500
✅ nextjs-webpack-canary86019
✅ nextjs-webpack-stable10500
✅ nitro-stable9906
✅ nuxt-stable9906
✅ sveltekit-stable9906
✅ vite-stable9906
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable9906
✅ express-stable9906
✅ fastify-stable9906
✅ hono-stable9906
✅ nextjs-turbopack-canary86019
✅ nextjs-turbopack-stable10500
✅ nextjs-webpack-canary86019
✅ nextjs-webpack-stable10500
✅ nitro-stable9906
✅ nuxt-stable9906
✅ sveltekit-stable9906
✅ vite-stable9906
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack10500
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev403
✅ redis-dev403
❌ redis67190
✅ turso-dev403
❌ turso3830
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable9906
✅ e2e-local-dev-tanstack-start-stable9906
✅ e2e-local-postgres-nest-stable9906
✅ e2e-local-postgres-tanstack-start-stable9906
✅ e2e-local-prod-nest-stable9906
✅ e2e-local-prod-tanstack-start-stable9906

📋 View full workflow run

@TooTallNateTooTallNate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this backport against the original #2925 (which I reviewed on main earlier today) hunk by hunk, with attention on the AI-resolved conflicts. Approving.

Fidelity:vite.ts and the changeset are byte-identical to the original. The two files that differ are both correct context adaptations, not semantic drift:

  • index.ts: the same workflowBuildDir → whole-buildDir exclusion swap (identical construction, including the trailing-slash discipline), applied against stable's surrounding context, which lacks main's world-target-injection code. I also checked the lint hazard this kind of resolution can create: join from pathe remains used elsewhere in stable's file (manifest handler paths, steps bundle), so no unused import was left behind.
  • index.test.ts: the resolution correctly added the viteWorkflow import that main's test file already had from neighboring tests — stable's smaller test file needed it introduced.

Applicability confirmed: stable does ship the Nitro-in-Vite pipeline (vite.ts exists with the same exclusion logic, and the tanstack-start e2e lanes run on stable), so this fixes a real 4.x exposure rather than backporting dead code.

Verified locally on the branch:@workflow/nitro builds; the regression test passes (does not re-transform generated Nitro build artifacts, exercising both transform hooks with the serde-class crash vector and the sibling-directory negative case); the single biome warning is pre-existing on the stable baseline (identical before/after).

CI: every lane that exercises this change is green — nitro/nuxt/vite/tanstack-start across dev, prod, postgres, and Vercel-prod, plus all four workbench deployments. The 4 failures are the known stable-branch baseline set: Community World Turso (same lane failed on the #2818/#2926 backports), its required-check aggregator, and the chronically flaky hono/sveltekit Vercel-prod lanes — none of which touch the Nitro transform path.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@TooTallNate@NathanColosimo
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Backport #2925: Fix duplicate transforms of Nitro build artifacts by github-actions[bot] · Pull Request #2928 · vercel/workflow · GitHub
Skip to content

Backport #2925: Fix duplicate transforms of Nitro build artifacts - #2928

Merged
NathanColosimo merged 2 commits into
stablefrom
backport/pr-2925-to-stable
Jul 14, 2026
Merged

Backport #2925: Fix duplicate transforms of Nitro build artifacts#2928
NathanColosimo merged 2 commits into
stablefrom
backport/pr-2925-to-stable

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated backport of #2925 to stable (backport job run).

AI recommendation: This is a self-contained bug fix that broadens the Nitro transform exclusion from only the pre-built workflow bundle directory to all generated Nitro build artifacts, preventing duplicate class registration. The affected files (packages/nitro/src/index.ts and vite.ts) and the exact workflowBuildDir exclusion logic being fixed exist unchanged on stable, and the change comes with a regression test, so it applies cleanly to the stable branch.

Merge conflicts were resolved by AI (opencode with anthropic/claude-opus-4.8). Please review the conflict resolution carefully before merging.

Signed-off-by: Nathan Colosimo <110621881+NathanColosimo@users.noreply.github.com>
@changeset-bot

changeset-botBot commented Jul 14, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 759ef8b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
NameType
@workflow/nitroPatch
@workflow/nuxtPatch
workflowPatch
@workflow/world-testingPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

@NathanColosimo
NathanColosimo enabled auto-merge (squash) July 14, 2026 22:47
@github-actions

github-actionsBot commented Jul 14, 2026

Copy link
Copy Markdown
ContributorAuthor

🧪 E2E Test Results

Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production10770781155
✅ 💻 Local Development11740861260
✅ 📦 Local Production11740861260
✅ 🐘 Local Postgres11740861260
✅ 🪟 Windows10500105
❌ 🌍 Community Worlds821029193
✅ 📋 Other594036630
Total53801023815863

❌ Failed Tests

🌍 Community Worlds (102 failed)

redis (19 failed):

  • hookWorkflow | wrun_01KXHEKY8Z3V27355GFY2QXW4X
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KXHEM663CXM1R1FAZP64EKNE
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01KXHEMG6YBMCF2C17TJ0TNDJ0
  • sleepingWorkflow | wrun_01KXHENQB8WQDWT88EG71PCYHF
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KXHEXYD0TATRPA9SH6GV7KK1
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01KXHEYCAESVKWEQ6H19HQKTJV
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01KXHEYMCTDMEMK3V3QSK1S264
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01KXHEZ26S60A40DGF1SCE5YKY
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01KXHEZXNY0B1MJDTVDKC4F54T
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01KXHF02M5B3XCH6B3EMZK7CQX
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01KXHF09HAMS6EAT4PSS0QPEXK
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01KXHF0FRHQ3G1BDGTTDKR21K9
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01KXHF0SRMKCPB452G17ET3N0N
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KXHF712XFC0A3HDP0FKE8BBQ

turso (83 failed):

  • addTenWorkflow | wrun_01KXHEK06WN31QJ8X8CNXPT8DY
  • addTenWorkflow | wrun_01KXHEK06WN31QJ8X8CNXPT8DY
  • deploymentId: 'latest' is a no-op in non-Vercel worlds
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KXHEN6X0MBPT9WHSBAVQVGMS
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KXHEK8X194MFGKY3ZNNVY68F
  • promiseRaceWorkflow | wrun_01KXHEKCV1MX2ZFAJVCRFANSWF
  • promiseAnyWorkflow | wrun_01KXHEKF8A87ZX579R5YKNMRP4
  • importedStepOnlyWorkflow | wrun_01KXHENJHVXXT7BDTM01CPSCBQ
  • readableStreamWorkflow | wrun_01KXHEKHR0EEGJPXNKG3QK1E0H
  • hookWorkflow | wrun_01KXHEKY8Z3V27355GFY2QXW4X
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KXHEM663CXM1R1FAZP64EKNE
  • webhookWorkflow | wrun_01KXHEMASEN4B21TKNCF3Q495B
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01KXHEMG6YBMCF2C17TJ0TNDJ0
  • sleepingWorkflow | wrun_01KXHENQB8WQDWT88EG71PCYHF
  • parallelSleepWorkflow | wrun_01KXHEP777316PRTNSPE04Y91A
  • sleepWinsRaceWorkflow | wrun_01KXHEPAVJ2AGE1B2J36VX48RT
  • stepWinsRaceWorkflow | wrun_01KXHEPEK98BNEMZ5CPPWAJ381
  • nullByteWorkflow | wrun_01KXHEPJ485YNJDAG1GPE97EGG
  • workflowAndStepMetadataWorkflow | wrun_01KXHEPMFY2S21BF283SQY022K
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KXHES49HNSDA2NJXY4CV67P7
  • writableForwardedFromWorkflowWorkflow | wrun_01KXHESHKK3WJWDAD0FPWZJ16N
  • writableForwardedFromStepWorkflow | wrun_01KXHESNW290K514FE74R3HBJQ
  • fetchWorkflow | wrun_01KXHESSG3ZMHT32YTRRT5G8GW
  • promiseRaceStressTestWorkflow | wrun_01KXHESX4SKBTBPJ4V4123P0KW
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KXHEXH0H9QX17CW7JWFWY631
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KXHEXYD0TATRPA9SH6GV7KK1
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01KXHEYCAESVKWEQ6H19HQKTJV
  • 'hookGetConflictWithPriorStepWorkflow' - hook.getConflict() does not block step execution | wrun_01KXHEYF0HP1K7S2JVDWGYYGD4
  • 'hookGetConflictWithParallelStepWorkfl…' - hook.getConflict() does not block step execution | wrun_01KXHEYHPDK3HZPSHHTX6P7QEB
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01KXHEYMCTDMEMK3V3QSK1S264
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01KXHEZ26S60A40DGF1SCE5YKY
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01KXHEZXNY0B1MJDTVDKC4F54T
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01KXHF02M5B3XCH6B3EMZK7CQX
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01KXHF09HAMS6EAT4PSS0QPEXK
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01KXHF0FRHQ3G1BDGTTDKR21K9
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01KXHF0SRMKCPB452G17ET3N0N
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KXHF111RYBYQ7SH6CT80HJFW
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KXHF1J68Y9B5EER5MTN2XCWR
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KXHF1WBNC7E3J0HRT5DE3S06
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KXHF22FB29GZ6RKX5QJK3G9N
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KXHF24X27PH1ZTCKGWBWWM4G
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KXHF2NAJRKGVV5E6M5N7N9VQ
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KXHF2VW65TDQHJ5Y3WKDSP67
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KXHF33B47HMR8FHGJ6RS0T10
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KXHF3ATG14ZAHJND9X74Q53Z
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KXHF3J9RFVQ8A11432VSS5T8
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KXHF3SPHJ0BG8W754YRFJ21P
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KXHF41BWBFMF6S115F80SKXE
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KXHF4FKKWYWYC2BTA84MDV2Z
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KXHF4S7T6Z12RM6NQRJ7M0V5
  • cancelRun - cancelling a running workflow | wrun_01KXHF50HXYW7WX7H03S4V00G4
  • cancelRun via CLI - cancelling a running workflow | wrun_01KXHF55V9D52023GBHV05MCYR
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KXHF5EXCS7GETSHFHJRVWVSV
  • hookWithSleepFinalStepWorkflow - step only on final payload | wrun_01KXHF5Y7MM8N3B8VJ13C9JTMW
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KXHF682EYKGHTK96HR9SG1QQ
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KXHF6MJ5T92TK64Y9G60PHT0
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KXHF6VVW1B7N5DEC0V1BQ4GR
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KXHF6YNXM7VR30FPWGKADB9V
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KXHF712XFC0A3HDP0FKE8BBQ

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro9708
✅ example9708
✅ express9708
✅ fastify9708
✅ hono9708
✅ nextjs-turbopack10203
✅ nextjs-webpack10203
✅ nitro9708
✅ nuxt9708
✅ sveltekit9708
✅ vite9708
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable9906
✅ express-stable9906
✅ fastify-stable9906
✅ hono-stable9906
✅ nextjs-turbopack-canary86019
✅ nextjs-turbopack-stable10500
✅ nextjs-webpack-canary86019
✅ nextjs-webpack-stable10500
✅ nitro-stable9906
✅ nuxt-stable9906
✅ sveltekit-stable9906
✅ vite-stable9906
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable9906
✅ express-stable9906
✅ fastify-stable9906
✅ hono-stable9906
✅ nextjs-turbopack-canary86019
✅ nextjs-turbopack-stable10500
✅ nextjs-webpack-canary86019
✅ nextjs-webpack-stable10500
✅ nitro-stable9906
✅ nuxt-stable9906
✅ sveltekit-stable9906
✅ vite-stable9906
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable9906
✅ express-stable9906
✅ fastify-stable9906
✅ hono-stable9906
✅ nextjs-turbopack-canary86019
✅ nextjs-turbopack-stable10500
✅ nextjs-webpack-canary86019
✅ nextjs-webpack-stable10500
✅ nitro-stable9906
✅ nuxt-stable9906
✅ sveltekit-stable9906
✅ vite-stable9906
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack10500
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev403
✅ redis-dev403
❌ redis67190
✅ turso-dev403
❌ turso3830
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable9906
✅ e2e-local-dev-tanstack-start-stable9906
✅ e2e-local-postgres-nest-stable9906
✅ e2e-local-postgres-tanstack-start-stable9906
✅ e2e-local-prod-nest-stable9906
✅ e2e-local-prod-tanstack-start-stable9906

📋 View full workflow run

@TooTallNateTooTallNate left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this backport against the original #2925 (which I reviewed on main earlier today) hunk by hunk, with attention on the AI-resolved conflicts. Approving.

Fidelity:vite.ts and the changeset are byte-identical to the original. The two files that differ are both correct context adaptations, not semantic drift:

  • index.ts: the same workflowBuildDir → whole-buildDir exclusion swap (identical construction, including the trailing-slash discipline), applied against stable's surrounding context, which lacks main's world-target-injection code. I also checked the lint hazard this kind of resolution can create: join from pathe remains used elsewhere in stable's file (manifest handler paths, steps bundle), so no unused import was left behind.
  • index.test.ts: the resolution correctly added the viteWorkflow import that main's test file already had from neighboring tests — stable's smaller test file needed it introduced.

Applicability confirmed: stable does ship the Nitro-in-Vite pipeline (vite.ts exists with the same exclusion logic, and the tanstack-start e2e lanes run on stable), so this fixes a real 4.x exposure rather than backporting dead code.

Verified locally on the branch:@workflow/nitro builds; the regression test passes (does not re-transform generated Nitro build artifacts, exercising both transform hooks with the serde-class crash vector and the sibling-directory negative case); the single biome warning is pre-existing on the stable baseline (identical before/after).

CI: every lane that exercises this change is green — nitro/nuxt/vite/tanstack-start across dev, prod, postgres, and Vercel-prod, plus all four workbench deployments. The 4 failures are the known stable-branch baseline set: Community World Turso (same lane failed on the #2818/#2926 backports), its required-check aggregator, and the chronically flaky hono/sveltekit Vercel-prod lanes — none of which touch the Nitro transform path.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@TooTallNate@NathanColosimo