Fix legacy structured errors in v4 event reads - #2951

Merged
karthikscale3 merged 1 commit into
mainfrom
kk/fix-legacy-structured-errors
Jul 15, 2026
Merged

Fix legacy structured errors in v4 event reads#2951
karthikscale3 merged 1 commit into
mainfrom
kk/fix-legacy-structured-errors

Conversation

@karthikscale3

Copy link
Copy Markdown
Contributor

What changed

  • Decode stable-line CBOR StructuredError payloads when reading v4 run_failed, step_failed, and step_retrying events.
  • Guard the fallback with known Workflow serialization prefixes and StructuredErrorSchema, preserving current devalue/encrypted payloads and unrelated binary data.
  • Add regression coverage for all affected event types and a patch changeset for @workflow/world-vercel.

Why

Stable runtimes store these errors as backend-materialized CBOR objects. Current @workflow/world-vercel treated every resolved v4 error body as modern format-prefixed Workflow data, so web hydration rejected the CBOR prefix and left a raw Uint8Array for the detail panel to render.

This restores compatibility without decoding modern serialized or encrypted errors.

Validation

  • pnpm --filter @workflow/world-vercel... build
  • pnpm --filter @workflow/world-vercel typecheck
  • pnpm --filter @workflow/world-vercel test — 294 tests passed
  • pnpm exec vitest run packages/world-vercel/src/events.test.ts — 31 tests passed
  • Biome check on changed source/test files; only the two pre-existing complexity warnings in events.ts
  • git diff --check

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7862017

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
NameType
@workflow/world-vercelPatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/corePatch
@workflow/webPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/nuxtPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/vitestPatch
workflowPatch
@workflow/world-testingPatch
@workflow/web-sharedPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actionsBot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production145302301683
✅ 💻 Local Development161702191836
✅ 📦 Local Production161702191836
✅ 🐘 Local Postgres161702191836
✅ 🪟 Windows15300153
✅ 📋 Other89401771071
✅ vercel-multi-region270027
Total7378010648442

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126027
✅ example126027
✅ express126027
✅ fastify126027
✅ hono126027
✅ nextjs-turbopack15003
✅ nextjs-webpack15003
✅ nitro126027
✅ nuxt126027
✅ sveltekit14508
✅ vite126027
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15300
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128025
✅ e2e-local-dev-tanstack-start-128025
✅ e2e-local-postgres-nest-stable128025
✅ e2e-local-postgres-tanstack-start-128025
✅ e2e-local-prod-nest-stable128025
✅ e2e-local-prod-tanstack-start-128025
✅ e2e-vercel-prod-tanstack-start126027
✅ vercel-multi-region
AppPassedFailedSkipped
✅ nextjs-turbopack2700

📋 View full workflow run

@github-actions

github-actionsBot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 7862017 · Wed, 15 Jul 2026 21:19:11 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1437 (+30%)1712 🔴1765 🔴2034 🔴30
TTFShook + stream1852 (+36%)2099 🔴2188 🔴2393 🔴30
STSO1020 steps (1-20)279 (±0%)297 🔴392 🔴420 🔴19
STSO1020 steps (101-120)449 (-0.8%)492 🔴596 🔴622 🔴19
STSO1020 steps (1001-1020)841 (-4.0%)887 🔴993 🔴1017 🔴19
WOstream1437 (+30%)17121765203430
WOhook + stream1852 (+36%)20992188239330
SLstream4450 (-0.7%)5096 🔴5433 🔴5787 🔴30
SLhook + stream4733 (-4.0%)4792 🔴5512 🔴5825 🔴30

Avg deltas compare against the most recent benchmark run on main at the time of this run.

Metrics — TTFS: time to first step body execution · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (time outside step bodies, client start → last step body exit) · SL: stream latency (first chunk write → visible to the reader)

Scenarios — stream: one step that streams chunks back to the client; no hooks, so the run stays in turbo mode · hook + stream: registers a hook before the same streaming step, which exits turbo mode · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges

🟢/🔴 mark percentiles within/above target. Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

TTFS/WO compare client vs deployment clocks and SL compares the step runner’s clock vs the client’s (NTP-synced in CI). WO ends at the last step body exit, the closest observable proxy for the final step-completion request.

@karthikscale3
karthikscale3 merged commit 6f032d7 into mainJul 15, 2026
104 checks passed
@karthikscale3
karthikscale3 deleted the kk/fix-legacy-structured-errors branch July 15, 2026 22:17
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for 6f032d7 (AI decision).

This fixes a main-only regression: main refactored the v4 read path (introducing packages/world-vercel/src/serialized-data.ts and normalizeSerializedData/format-prefix logic, none of which exist on stable) and stopped decoding legacy CBOR structured errors. On stable, buildEventFromV4 already CBOR-decodes these same event types (run_failed, step_failed, step_retrying) correctly, so the bug does not exist there and the fix depends on main-only infrastructure.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

6f032d73fee8103b6cfcd69713f3e87cf8e19140

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@karthikscale3@VaguelySerious
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Fix legacy structured errors in v4 event reads - #2951

Merged
karthikscale3 merged 1 commit into
mainfrom
kk/fix-legacy-structured-errors
Jul 15, 2026
Merged

Fix legacy structured errors in v4 event reads#2951
karthikscale3 merged 1 commit into
mainfrom
kk/fix-legacy-structured-errors

Conversation

@karthikscale3

Copy link
Copy Markdown
Contributor

What changed

  • Decode stable-line CBOR StructuredError payloads when reading v4 run_failed, step_failed, and step_retrying events.
  • Guard the fallback with known Workflow serialization prefixes and StructuredErrorSchema, preserving current devalue/encrypted payloads and unrelated binary data.
  • Add regression coverage for all affected event types and a patch changeset for @workflow/world-vercel.

Why

Stable runtimes store these errors as backend-materialized CBOR objects. Current @workflow/world-vercel treated every resolved v4 error body as modern format-prefixed Workflow data, so web hydration rejected the CBOR prefix and left a raw Uint8Array for the detail panel to render.

This restores compatibility without decoding modern serialized or encrypted errors.

Validation

  • pnpm --filter @workflow/world-vercel... build
  • pnpm --filter @workflow/world-vercel typecheck
  • pnpm --filter @workflow/world-vercel test — 294 tests passed
  • pnpm exec vitest run packages/world-vercel/src/events.test.ts — 31 tests passed
  • Biome check on changed source/test files; only the two pre-existing complexity warnings in events.ts
  • git diff --check

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7862017

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
NameType
@workflow/world-vercelPatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/corePatch
@workflow/webPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/nuxtPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/vitestPatch
workflowPatch
@workflow/world-testingPatch
@workflow/web-sharedPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actionsBot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production145302301683
✅ 💻 Local Development161702191836
✅ 📦 Local Production161702191836
✅ 🐘 Local Postgres161702191836
✅ 🪟 Windows15300153
✅ 📋 Other89401771071
✅ vercel-multi-region270027
Total7378010648442

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126027
✅ example126027
✅ express126027
✅ fastify126027
✅ hono126027
✅ nextjs-turbopack15003
✅ nextjs-webpack15003
✅ nitro126027
✅ nuxt126027
✅ sveltekit14508
✅ vite126027
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15300
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128025
✅ e2e-local-dev-tanstack-start-128025
✅ e2e-local-postgres-nest-stable128025
✅ e2e-local-postgres-tanstack-start-128025
✅ e2e-local-prod-nest-stable128025
✅ e2e-local-prod-tanstack-start-128025
✅ e2e-vercel-prod-tanstack-start126027
✅ vercel-multi-region
AppPassedFailedSkipped
✅ nextjs-turbopack2700

📋 View full workflow run

@github-actions

github-actionsBot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 7862017 · Wed, 15 Jul 2026 21:19:11 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1437 (+30%)1712 🔴1765 🔴2034 🔴30
TTFShook + stream1852 (+36%)2099 🔴2188 🔴2393 🔴30
STSO1020 steps (1-20)279 (±0%)297 🔴392 🔴420 🔴19
STSO1020 steps (101-120)449 (-0.8%)492 🔴596 🔴622 🔴19
STSO1020 steps (1001-1020)841 (-4.0%)887 🔴993 🔴1017 🔴19
WOstream1437 (+30%)17121765203430
WOhook + stream1852 (+36%)20992188239330
SLstream4450 (-0.7%)5096 🔴5433 🔴5787 🔴30
SLhook + stream4733 (-4.0%)4792 🔴5512 🔴5825 🔴30

Avg deltas compare against the most recent benchmark run on main at the time of this run.

Metrics — TTFS: time to first step body execution · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (time outside step bodies, client start → last step body exit) · SL: stream latency (first chunk write → visible to the reader)

Scenarios — stream: one step that streams chunks back to the client; no hooks, so the run stays in turbo mode · hook + stream: registers a hook before the same streaming step, which exits turbo mode · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges

🟢/🔴 mark percentiles within/above target. Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

TTFS/WO compare client vs deployment clocks and SL compares the step runner’s clock vs the client’s (NTP-synced in CI). WO ends at the last step body exit, the closest observable proxy for the final step-completion request.

@karthikscale3
karthikscale3 merged commit 6f032d7 into mainJul 15, 2026
104 checks passed
@karthikscale3
karthikscale3 deleted the kk/fix-legacy-structured-errors branch July 15, 2026 22:17
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for 6f032d7 (AI decision).

This fixes a main-only regression: main refactored the v4 read path (introducing packages/world-vercel/src/serialized-data.ts and normalizeSerializedData/format-prefix logic, none of which exist on stable) and stopped decoding legacy CBOR structured errors. On stable, buildEventFromV4 already CBOR-decodes these same event types (run_failed, step_failed, step_retrying) correctly, so the bug does not exist there and the fix depends on main-only infrastructure.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

6f032d73fee8103b6cfcd69713f3e87cf8e19140

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@karthikscale3@VaguelySerious
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix legacy structured errors in v4 event reads - #2951

Merged
karthikscale3 merged 1 commit into
mainfrom
kk/fix-legacy-structured-errors
Jul 15, 2026
Merged

Fix legacy structured errors in v4 event reads#2951
karthikscale3 merged 1 commit into
mainfrom
kk/fix-legacy-structured-errors

Conversation

@karthikscale3

Copy link
Copy Markdown
Contributor

What changed

  • Decode stable-line CBOR StructuredError payloads when reading v4 run_failed, step_failed, and step_retrying events.
  • Guard the fallback with known Workflow serialization prefixes and StructuredErrorSchema, preserving current devalue/encrypted payloads and unrelated binary data.
  • Add regression coverage for all affected event types and a patch changeset for @workflow/world-vercel.

Why

Stable runtimes store these errors as backend-materialized CBOR objects. Current @workflow/world-vercel treated every resolved v4 error body as modern format-prefixed Workflow data, so web hydration rejected the CBOR prefix and left a raw Uint8Array for the detail panel to render.

This restores compatibility without decoding modern serialized or encrypted errors.

Validation

  • pnpm --filter @workflow/world-vercel... build
  • pnpm --filter @workflow/world-vercel typecheck
  • pnpm --filter @workflow/world-vercel test — 294 tests passed
  • pnpm exec vitest run packages/world-vercel/src/events.test.ts — 31 tests passed
  • Biome check on changed source/test files; only the two pre-existing complexity warnings in events.ts
  • git diff --check

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7862017

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
NameType
@workflow/world-vercelPatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/corePatch
@workflow/webPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/nuxtPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/vitestPatch
workflowPatch
@workflow/world-testingPatch
@workflow/web-sharedPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actionsBot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production145302301683
✅ 💻 Local Development161702191836
✅ 📦 Local Production161702191836
✅ 🐘 Local Postgres161702191836
✅ 🪟 Windows15300153
✅ 📋 Other89401771071
✅ vercel-multi-region270027
Total7378010648442

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126027
✅ example126027
✅ express126027
✅ fastify126027
✅ hono126027
✅ nextjs-turbopack15003
✅ nextjs-webpack15003
✅ nitro126027
✅ nuxt126027
✅ sveltekit14508
✅ vite126027
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15300
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128025
✅ e2e-local-dev-tanstack-start-128025
✅ e2e-local-postgres-nest-stable128025
✅ e2e-local-postgres-tanstack-start-128025
✅ e2e-local-prod-nest-stable128025
✅ e2e-local-prod-tanstack-start-128025
✅ e2e-vercel-prod-tanstack-start126027
✅ vercel-multi-region
AppPassedFailedSkipped
✅ nextjs-turbopack2700

📋 View full workflow run

@github-actions

github-actionsBot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 7862017 · Wed, 15 Jul 2026 21:19:11 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1437 (+30%)1712 🔴1765 🔴2034 🔴30
TTFShook + stream1852 (+36%)2099 🔴2188 🔴2393 🔴30
STSO1020 steps (1-20)279 (±0%)297 🔴392 🔴420 🔴19
STSO1020 steps (101-120)449 (-0.8%)492 🔴596 🔴622 🔴19
STSO1020 steps (1001-1020)841 (-4.0%)887 🔴993 🔴1017 🔴19
WOstream1437 (+30%)17121765203430
WOhook + stream1852 (+36%)20992188239330
SLstream4450 (-0.7%)5096 🔴5433 🔴5787 🔴30
SLhook + stream4733 (-4.0%)4792 🔴5512 🔴5825 🔴30

Avg deltas compare against the most recent benchmark run on main at the time of this run.

Metrics — TTFS: time to first step body execution · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (time outside step bodies, client start → last step body exit) · SL: stream latency (first chunk write → visible to the reader)

Scenarios — stream: one step that streams chunks back to the client; no hooks, so the run stays in turbo mode · hook + stream: registers a hook before the same streaming step, which exits turbo mode · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges

🟢/🔴 mark percentiles within/above target. Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

TTFS/WO compare client vs deployment clocks and SL compares the step runner’s clock vs the client’s (NTP-synced in CI). WO ends at the last step body exit, the closest observable proxy for the final step-completion request.

@karthikscale3
karthikscale3 merged commit 6f032d7 into mainJul 15, 2026
104 checks passed
@karthikscale3
karthikscale3 deleted the kk/fix-legacy-structured-errors branch July 15, 2026 22:17
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for 6f032d7 (AI decision).

This fixes a main-only regression: main refactored the v4 read path (introducing packages/world-vercel/src/serialized-data.ts and normalizeSerializedData/format-prefix logic, none of which exist on stable) and stopped decoding legacy CBOR structured errors. On stable, buildEventFromV4 already CBOR-decodes these same event types (run_failed, step_failed, step_retrying) correctly, so the bug does not exist there and the fix depends on main-only infrastructure.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

6f032d73fee8103b6cfcd69713f3e87cf8e19140

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@karthikscale3@VaguelySerious
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix legacy structured errors in v4 event reads - #2951

Merged
karthikscale3 merged 1 commit into
mainfrom
kk/fix-legacy-structured-errors
Jul 15, 2026
Merged

Fix legacy structured errors in v4 event reads#2951
karthikscale3 merged 1 commit into
mainfrom
kk/fix-legacy-structured-errors

Conversation

@karthikscale3

Copy link
Copy Markdown
Contributor

What changed

  • Decode stable-line CBOR StructuredError payloads when reading v4 run_failed, step_failed, and step_retrying events.
  • Guard the fallback with known Workflow serialization prefixes and StructuredErrorSchema, preserving current devalue/encrypted payloads and unrelated binary data.
  • Add regression coverage for all affected event types and a patch changeset for @workflow/world-vercel.

Why

Stable runtimes store these errors as backend-materialized CBOR objects. Current @workflow/world-vercel treated every resolved v4 error body as modern format-prefixed Workflow data, so web hydration rejected the CBOR prefix and left a raw Uint8Array for the detail panel to render.

This restores compatibility without decoding modern serialized or encrypted errors.

Validation

  • pnpm --filter @workflow/world-vercel... build
  • pnpm --filter @workflow/world-vercel typecheck
  • pnpm --filter @workflow/world-vercel test — 294 tests passed
  • pnpm exec vitest run packages/world-vercel/src/events.test.ts — 31 tests passed
  • Biome check on changed source/test files; only the two pre-existing complexity warnings in events.ts
  • git diff --check

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7862017

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
NameType
@workflow/world-vercelPatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/corePatch
@workflow/webPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/nuxtPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/vitestPatch
workflowPatch
@workflow/world-testingPatch
@workflow/web-sharedPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actionsBot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production145302301683
✅ 💻 Local Development161702191836
✅ 📦 Local Production161702191836
✅ 🐘 Local Postgres161702191836
✅ 🪟 Windows15300153
✅ 📋 Other89401771071
✅ vercel-multi-region270027
Total7378010648442

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126027
✅ example126027
✅ express126027
✅ fastify126027
✅ hono126027
✅ nextjs-turbopack15003
✅ nextjs-webpack15003
✅ nitro126027
✅ nuxt126027
✅ sveltekit14508
✅ vite126027
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15300
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128025
✅ e2e-local-dev-tanstack-start-128025
✅ e2e-local-postgres-nest-stable128025
✅ e2e-local-postgres-tanstack-start-128025
✅ e2e-local-prod-nest-stable128025
✅ e2e-local-prod-tanstack-start-128025
✅ e2e-vercel-prod-tanstack-start126027
✅ vercel-multi-region
AppPassedFailedSkipped
✅ nextjs-turbopack2700

📋 View full workflow run

@github-actions

github-actionsBot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 7862017 · Wed, 15 Jul 2026 21:19:11 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1437 (+30%)1712 🔴1765 🔴2034 🔴30
TTFShook + stream1852 (+36%)2099 🔴2188 🔴2393 🔴30
STSO1020 steps (1-20)279 (±0%)297 🔴392 🔴420 🔴19
STSO1020 steps (101-120)449 (-0.8%)492 🔴596 🔴622 🔴19
STSO1020 steps (1001-1020)841 (-4.0%)887 🔴993 🔴1017 🔴19
WOstream1437 (+30%)17121765203430
WOhook + stream1852 (+36%)20992188239330
SLstream4450 (-0.7%)5096 🔴5433 🔴5787 🔴30
SLhook + stream4733 (-4.0%)4792 🔴5512 🔴5825 🔴30

Avg deltas compare against the most recent benchmark run on main at the time of this run.

Metrics — TTFS: time to first step body execution · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (time outside step bodies, client start → last step body exit) · SL: stream latency (first chunk write → visible to the reader)

Scenarios — stream: one step that streams chunks back to the client; no hooks, so the run stays in turbo mode · hook + stream: registers a hook before the same streaming step, which exits turbo mode · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges

🟢/🔴 mark percentiles within/above target. Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

TTFS/WO compare client vs deployment clocks and SL compares the step runner’s clock vs the client’s (NTP-synced in CI). WO ends at the last step body exit, the closest observable proxy for the final step-completion request.

@karthikscale3
karthikscale3 merged commit 6f032d7 into mainJul 15, 2026
104 checks passed
@karthikscale3
karthikscale3 deleted the kk/fix-legacy-structured-errors branch July 15, 2026 22:17
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for 6f032d7 (AI decision).

This fixes a main-only regression: main refactored the v4 read path (introducing packages/world-vercel/src/serialized-data.ts and normalizeSerializedData/format-prefix logic, none of which exist on stable) and stopped decoding legacy CBOR structured errors. On stable, buildEventFromV4 already CBOR-decodes these same event types (run_failed, step_failed, step_retrying) correctly, so the bug does not exist there and the fix depends on main-only infrastructure.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

6f032d73fee8103b6cfcd69713f3e87cf8e19140

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@karthikscale3@VaguelySerious
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Fix legacy structured errors in v4 event reads - #2951

Merged
karthikscale3 merged 1 commit into
mainfrom
kk/fix-legacy-structured-errors
Jul 15, 2026
Merged

Fix legacy structured errors in v4 event reads#2951
karthikscale3 merged 1 commit into
mainfrom
kk/fix-legacy-structured-errors

Conversation

@karthikscale3

Copy link
Copy Markdown
Contributor

What changed

  • Decode stable-line CBOR StructuredError payloads when reading v4 run_failed, step_failed, and step_retrying events.
  • Guard the fallback with known Workflow serialization prefixes and StructuredErrorSchema, preserving current devalue/encrypted payloads and unrelated binary data.
  • Add regression coverage for all affected event types and a patch changeset for @workflow/world-vercel.

Why

Stable runtimes store these errors as backend-materialized CBOR objects. Current @workflow/world-vercel treated every resolved v4 error body as modern format-prefixed Workflow data, so web hydration rejected the CBOR prefix and left a raw Uint8Array for the detail panel to render.

This restores compatibility without decoding modern serialized or encrypted errors.

Validation

  • pnpm --filter @workflow/world-vercel... build
  • pnpm --filter @workflow/world-vercel typecheck
  • pnpm --filter @workflow/world-vercel test — 294 tests passed
  • pnpm exec vitest run packages/world-vercel/src/events.test.ts — 31 tests passed
  • Biome check on changed source/test files; only the two pre-existing complexity warnings in events.ts
  • git diff --check

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7862017

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
NameType
@workflow/world-vercelPatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/corePatch
@workflow/webPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/nuxtPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/vitestPatch
workflowPatch
@workflow/world-testingPatch
@workflow/web-sharedPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actionsBot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production145302301683
✅ 💻 Local Development161702191836
✅ 📦 Local Production161702191836
✅ 🐘 Local Postgres161702191836
✅ 🪟 Windows15300153
✅ 📋 Other89401771071
✅ vercel-multi-region270027
Total7378010648442

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126027
✅ example126027
✅ express126027
✅ fastify126027
✅ hono126027
✅ nextjs-turbopack15003
✅ nextjs-webpack15003
✅ nitro126027
✅ nuxt126027
✅ sveltekit14508
✅ vite126027
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15300
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128025
✅ e2e-local-dev-tanstack-start-128025
✅ e2e-local-postgres-nest-stable128025
✅ e2e-local-postgres-tanstack-start-128025
✅ e2e-local-prod-nest-stable128025
✅ e2e-local-prod-tanstack-start-128025
✅ e2e-vercel-prod-tanstack-start126027
✅ vercel-multi-region
AppPassedFailedSkipped
✅ nextjs-turbopack2700

📋 View full workflow run

@github-actions

github-actionsBot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 7862017 · Wed, 15 Jul 2026 21:19:11 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1437 (+30%)1712 🔴1765 🔴2034 🔴30
TTFShook + stream1852 (+36%)2099 🔴2188 🔴2393 🔴30
STSO1020 steps (1-20)279 (±0%)297 🔴392 🔴420 🔴19
STSO1020 steps (101-120)449 (-0.8%)492 🔴596 🔴622 🔴19
STSO1020 steps (1001-1020)841 (-4.0%)887 🔴993 🔴1017 🔴19
WOstream1437 (+30%)17121765203430
WOhook + stream1852 (+36%)20992188239330
SLstream4450 (-0.7%)5096 🔴5433 🔴5787 🔴30
SLhook + stream4733 (-4.0%)4792 🔴5512 🔴5825 🔴30

Avg deltas compare against the most recent benchmark run on main at the time of this run.

Metrics — TTFS: time to first step body execution · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (time outside step bodies, client start → last step body exit) · SL: stream latency (first chunk write → visible to the reader)

Scenarios — stream: one step that streams chunks back to the client; no hooks, so the run stays in turbo mode · hook + stream: registers a hook before the same streaming step, which exits turbo mode · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges

🟢/🔴 mark percentiles within/above target. Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

TTFS/WO compare client vs deployment clocks and SL compares the step runner’s clock vs the client’s (NTP-synced in CI). WO ends at the last step body exit, the closest observable proxy for the final step-completion request.

@karthikscale3
karthikscale3 merged commit 6f032d7 into mainJul 15, 2026
104 checks passed
@karthikscale3
karthikscale3 deleted the kk/fix-legacy-structured-errors branch July 15, 2026 22:17
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for 6f032d7 (AI decision).

This fixes a main-only regression: main refactored the v4 read path (introducing packages/world-vercel/src/serialized-data.ts and normalizeSerializedData/format-prefix logic, none of which exist on stable) and stopped decoding legacy CBOR structured errors. On stable, buildEventFromV4 already CBOR-decodes these same event types (run_failed, step_failed, step_retrying) correctly, so the bug does not exist there and the fix depends on main-only infrastructure.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

6f032d73fee8103b6cfcd69713f3e87cf8e19140

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@karthikscale3@VaguelySerious
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix legacy structured errors in v4 event reads - #2951

Merged
karthikscale3 merged 1 commit into
mainfrom
kk/fix-legacy-structured-errors
Jul 15, 2026
Merged

Fix legacy structured errors in v4 event reads#2951
karthikscale3 merged 1 commit into
mainfrom
kk/fix-legacy-structured-errors

Conversation

@karthikscale3

Copy link
Copy Markdown
Contributor

What changed

  • Decode stable-line CBOR StructuredError payloads when reading v4 run_failed, step_failed, and step_retrying events.
  • Guard the fallback with known Workflow serialization prefixes and StructuredErrorSchema, preserving current devalue/encrypted payloads and unrelated binary data.
  • Add regression coverage for all affected event types and a patch changeset for @workflow/world-vercel.

Why

Stable runtimes store these errors as backend-materialized CBOR objects. Current @workflow/world-vercel treated every resolved v4 error body as modern format-prefixed Workflow data, so web hydration rejected the CBOR prefix and left a raw Uint8Array for the detail panel to render.

This restores compatibility without decoding modern serialized or encrypted errors.

Validation

  • pnpm --filter @workflow/world-vercel... build
  • pnpm --filter @workflow/world-vercel typecheck
  • pnpm --filter @workflow/world-vercel test — 294 tests passed
  • pnpm exec vitest run packages/world-vercel/src/events.test.ts — 31 tests passed
  • Biome check on changed source/test files; only the two pre-existing complexity warnings in events.ts
  • git diff --check

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7862017

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
NameType
@workflow/world-vercelPatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/corePatch
@workflow/webPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/nuxtPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/vitestPatch
workflowPatch
@workflow/world-testingPatch
@workflow/web-sharedPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actionsBot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production145302301683
✅ 💻 Local Development161702191836
✅ 📦 Local Production161702191836
✅ 🐘 Local Postgres161702191836
✅ 🪟 Windows15300153
✅ 📋 Other89401771071
✅ vercel-multi-region270027
Total7378010648442

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126027
✅ example126027
✅ express126027
✅ fastify126027
✅ hono126027
✅ nextjs-turbopack15003
✅ nextjs-webpack15003
✅ nitro126027
✅ nuxt126027
✅ sveltekit14508
✅ vite126027
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15300
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128025
✅ e2e-local-dev-tanstack-start-128025
✅ e2e-local-postgres-nest-stable128025
✅ e2e-local-postgres-tanstack-start-128025
✅ e2e-local-prod-nest-stable128025
✅ e2e-local-prod-tanstack-start-128025
✅ e2e-vercel-prod-tanstack-start126027
✅ vercel-multi-region
AppPassedFailedSkipped
✅ nextjs-turbopack2700

📋 View full workflow run

@github-actions

github-actionsBot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 7862017 · Wed, 15 Jul 2026 21:19:11 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1437 (+30%)1712 🔴1765 🔴2034 🔴30
TTFShook + stream1852 (+36%)2099 🔴2188 🔴2393 🔴30
STSO1020 steps (1-20)279 (±0%)297 🔴392 🔴420 🔴19
STSO1020 steps (101-120)449 (-0.8%)492 🔴596 🔴622 🔴19
STSO1020 steps (1001-1020)841 (-4.0%)887 🔴993 🔴1017 🔴19
WOstream1437 (+30%)17121765203430
WOhook + stream1852 (+36%)20992188239330
SLstream4450 (-0.7%)5096 🔴5433 🔴5787 🔴30
SLhook + stream4733 (-4.0%)4792 🔴5512 🔴5825 🔴30

Avg deltas compare against the most recent benchmark run on main at the time of this run.

Metrics — TTFS: time to first step body execution · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (time outside step bodies, client start → last step body exit) · SL: stream latency (first chunk write → visible to the reader)

Scenarios — stream: one step that streams chunks back to the client; no hooks, so the run stays in turbo mode · hook + stream: registers a hook before the same streaming step, which exits turbo mode · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges

🟢/🔴 mark percentiles within/above target. Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

TTFS/WO compare client vs deployment clocks and SL compares the step runner’s clock vs the client’s (NTP-synced in CI). WO ends at the last step body exit, the closest observable proxy for the final step-completion request.

@karthikscale3
karthikscale3 merged commit 6f032d7 into mainJul 15, 2026
104 checks passed
@karthikscale3
karthikscale3 deleted the kk/fix-legacy-structured-errors branch July 15, 2026 22:17
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for 6f032d7 (AI decision).

This fixes a main-only regression: main refactored the v4 read path (introducing packages/world-vercel/src/serialized-data.ts and normalizeSerializedData/format-prefix logic, none of which exist on stable) and stopped decoding legacy CBOR structured errors. On stable, buildEventFromV4 already CBOR-decodes these same event types (run_failed, step_failed, step_retrying) correctly, so the bug does not exist there and the fix depends on main-only infrastructure.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

6f032d73fee8103b6cfcd69713f3e87cf8e19140

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@karthikscale3@VaguelySerious
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Fix legacy structured errors in v4 event reads - #2951

Merged
karthikscale3 merged 1 commit into
mainfrom
kk/fix-legacy-structured-errors
Jul 15, 2026
Merged

Fix legacy structured errors in v4 event reads#2951
karthikscale3 merged 1 commit into
mainfrom
kk/fix-legacy-structured-errors

Conversation

@karthikscale3

Copy link
Copy Markdown
Contributor

What changed

  • Decode stable-line CBOR StructuredError payloads when reading v4 run_failed, step_failed, and step_retrying events.
  • Guard the fallback with known Workflow serialization prefixes and StructuredErrorSchema, preserving current devalue/encrypted payloads and unrelated binary data.
  • Add regression coverage for all affected event types and a patch changeset for @workflow/world-vercel.

Why

Stable runtimes store these errors as backend-materialized CBOR objects. Current @workflow/world-vercel treated every resolved v4 error body as modern format-prefixed Workflow data, so web hydration rejected the CBOR prefix and left a raw Uint8Array for the detail panel to render.

This restores compatibility without decoding modern serialized or encrypted errors.

Validation

  • pnpm --filter @workflow/world-vercel... build
  • pnpm --filter @workflow/world-vercel typecheck
  • pnpm --filter @workflow/world-vercel test — 294 tests passed
  • pnpm exec vitest run packages/world-vercel/src/events.test.ts — 31 tests passed
  • Biome check on changed source/test files; only the two pre-existing complexity warnings in events.ts
  • git diff --check

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7862017

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
NameType
@workflow/world-vercelPatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/corePatch
@workflow/webPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/nuxtPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/vitestPatch
workflowPatch
@workflow/world-testingPatch
@workflow/web-sharedPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actionsBot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production145302301683
✅ 💻 Local Development161702191836
✅ 📦 Local Production161702191836
✅ 🐘 Local Postgres161702191836
✅ 🪟 Windows15300153
✅ 📋 Other89401771071
✅ vercel-multi-region270027
Total7378010648442

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126027
✅ example126027
✅ express126027
✅ fastify126027
✅ hono126027
✅ nextjs-turbopack15003
✅ nextjs-webpack15003
✅ nitro126027
✅ nuxt126027
✅ sveltekit14508
✅ vite126027
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15300
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128025
✅ e2e-local-dev-tanstack-start-128025
✅ e2e-local-postgres-nest-stable128025
✅ e2e-local-postgres-tanstack-start-128025
✅ e2e-local-prod-nest-stable128025
✅ e2e-local-prod-tanstack-start-128025
✅ e2e-vercel-prod-tanstack-start126027
✅ vercel-multi-region
AppPassedFailedSkipped
✅ nextjs-turbopack2700

📋 View full workflow run

@github-actions

github-actionsBot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 7862017 · Wed, 15 Jul 2026 21:19:11 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1437 (+30%)1712 🔴1765 🔴2034 🔴30
TTFShook + stream1852 (+36%)2099 🔴2188 🔴2393 🔴30
STSO1020 steps (1-20)279 (±0%)297 🔴392 🔴420 🔴19
STSO1020 steps (101-120)449 (-0.8%)492 🔴596 🔴622 🔴19
STSO1020 steps (1001-1020)841 (-4.0%)887 🔴993 🔴1017 🔴19
WOstream1437 (+30%)17121765203430
WOhook + stream1852 (+36%)20992188239330
SLstream4450 (-0.7%)5096 🔴5433 🔴5787 🔴30
SLhook + stream4733 (-4.0%)4792 🔴5512 🔴5825 🔴30

Avg deltas compare against the most recent benchmark run on main at the time of this run.

Metrics — TTFS: time to first step body execution · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (time outside step bodies, client start → last step body exit) · SL: stream latency (first chunk write → visible to the reader)

Scenarios — stream: one step that streams chunks back to the client; no hooks, so the run stays in turbo mode · hook + stream: registers a hook before the same streaming step, which exits turbo mode · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges

🟢/🔴 mark percentiles within/above target. Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

TTFS/WO compare client vs deployment clocks and SL compares the step runner’s clock vs the client’s (NTP-synced in CI). WO ends at the last step body exit, the closest observable proxy for the final step-completion request.

@karthikscale3
karthikscale3 merged commit 6f032d7 into mainJul 15, 2026
104 checks passed
@karthikscale3
karthikscale3 deleted the kk/fix-legacy-structured-errors branch July 15, 2026 22:17
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for 6f032d7 (AI decision).

This fixes a main-only regression: main refactored the v4 read path (introducing packages/world-vercel/src/serialized-data.ts and normalizeSerializedData/format-prefix logic, none of which exist on stable) and stopped decoding legacy CBOR structured errors. On stable, buildEventFromV4 already CBOR-decodes these same event types (run_failed, step_failed, step_retrying) correctly, so the bug does not exist there and the fix depends on main-only infrastructure.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

6f032d73fee8103b6cfcd69713f3e87cf8e19140

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@karthikscale3@VaguelySerious
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Fix legacy structured errors in v4 event reads - #2951

Merged
karthikscale3 merged 1 commit into
mainfrom
kk/fix-legacy-structured-errors
Jul 15, 2026
Merged

Fix legacy structured errors in v4 event reads#2951
karthikscale3 merged 1 commit into
mainfrom
kk/fix-legacy-structured-errors

Conversation

@karthikscale3

Copy link
Copy Markdown
Contributor

What changed

  • Decode stable-line CBOR StructuredError payloads when reading v4 run_failed, step_failed, and step_retrying events.
  • Guard the fallback with known Workflow serialization prefixes and StructuredErrorSchema, preserving current devalue/encrypted payloads and unrelated binary data.
  • Add regression coverage for all affected event types and a patch changeset for @workflow/world-vercel.

Why

Stable runtimes store these errors as backend-materialized CBOR objects. Current @workflow/world-vercel treated every resolved v4 error body as modern format-prefixed Workflow data, so web hydration rejected the CBOR prefix and left a raw Uint8Array for the detail panel to render.

This restores compatibility without decoding modern serialized or encrypted errors.

Validation

  • pnpm --filter @workflow/world-vercel... build
  • pnpm --filter @workflow/world-vercel typecheck
  • pnpm --filter @workflow/world-vercel test — 294 tests passed
  • pnpm exec vitest run packages/world-vercel/src/events.test.ts — 31 tests passed
  • Biome check on changed source/test files; only the two pre-existing complexity warnings in events.ts
  • git diff --check

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7862017

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
NameType
@workflow/world-vercelPatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/corePatch
@workflow/webPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/nuxtPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/vitestPatch
workflowPatch
@workflow/world-testingPatch
@workflow/web-sharedPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actionsBot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production145302301683
✅ 💻 Local Development161702191836
✅ 📦 Local Production161702191836
✅ 🐘 Local Postgres161702191836
✅ 🪟 Windows15300153
✅ 📋 Other89401771071
✅ vercel-multi-region270027
Total7378010648442

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126027
✅ example126027
✅ express126027
✅ fastify126027
✅ hono126027
✅ nextjs-turbopack15003
✅ nextjs-webpack15003
✅ nitro126027
✅ nuxt126027
✅ sveltekit14508
✅ vite126027
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128025
✅ express-stable128025
✅ fastify-stable128025
✅ hono-stable128025
✅ nextjs-turbopack-canary134019
✅ nextjs-turbopack-stable15300
✅ nextjs-webpack-canary134019
✅ nextjs-webpack-stable15300
✅ nitro-stable128025
✅ nuxt-stable128025
✅ sveltekit-stable14706
✅ vite-stable128025
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15300
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128025
✅ e2e-local-dev-tanstack-start-128025
✅ e2e-local-postgres-nest-stable128025
✅ e2e-local-postgres-tanstack-start-128025
✅ e2e-local-prod-nest-stable128025
✅ e2e-local-prod-tanstack-start-128025
✅ e2e-vercel-prod-tanstack-start126027
✅ vercel-multi-region
AppPassedFailedSkipped
✅ nextjs-turbopack2700

📋 View full workflow run

@github-actions

github-actionsBot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 7862017 · Wed, 15 Jul 2026 21:19:11 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioAvg (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstream1437 (+30%)1712 🔴1765 🔴2034 🔴30
TTFShook + stream1852 (+36%)2099 🔴2188 🔴2393 🔴30
STSO1020 steps (1-20)279 (±0%)297 🔴392 🔴420 🔴19
STSO1020 steps (101-120)449 (-0.8%)492 🔴596 🔴622 🔴19
STSO1020 steps (1001-1020)841 (-4.0%)887 🔴993 🔴1017 🔴19
WOstream1437 (+30%)17121765203430
WOhook + stream1852 (+36%)20992188239330
SLstream4450 (-0.7%)5096 🔴5433 🔴5787 🔴30
SLhook + stream4733 (-4.0%)4792 🔴5512 🔴5825 🔴30

Avg deltas compare against the most recent benchmark run on main at the time of this run.

Metrics — TTFS: time to first step body execution · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (time outside step bodies, client start → last step body exit) · SL: stream latency (first chunk write → visible to the reader)

Scenarios — stream: one step that streams chunks back to the client; no hooks, so the run stays in turbo mode · hook + stream: registers a hook before the same streaming step, which exits turbo mode · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges

🟢/🔴 mark percentiles within/above target. Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

TTFS/WO compare client vs deployment clocks and SL compares the step runner’s clock vs the client’s (NTP-synced in CI). WO ends at the last step body exit, the closest observable proxy for the final step-completion request.

@karthikscale3
karthikscale3 merged commit 6f032d7 into mainJul 15, 2026
104 checks passed
@karthikscale3
karthikscale3 deleted the kk/fix-legacy-structured-errors branch July 15, 2026 22:17
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for 6f032d7 (AI decision).

This fixes a main-only regression: main refactored the v4 read path (introducing packages/world-vercel/src/serialized-data.ts and normalizeSerializedData/format-prefix logic, none of which exist on stable) and stopped decoding legacy CBOR structured errors. On stable, buildEventFromV4 already CBOR-decodes these same event types (run_failed, step_failed, step_retrying) correctly, so the bug does not exist there and the fix depends on main-only infrastructure.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

6f032d73fee8103b6cfcd69713f3e87cf8e19140

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@karthikscale3@VaguelySerious