Skip to content

docs: fix stale/incorrect v5 API reference details - #3017

Merged
VaguelySerious merged 1 commit into
mainfrom
peter/docs-api-ref-audit
Jul 21, 2026
Merged

docs: fix stale/incorrect v5 API reference details#3017
VaguelySerious merged 1 commit into
mainfrom
peter/docs-api-ref-audit

Conversation

@VaguelySerious

@VaguelySeriousVaguelySerious commented Jul 20, 2026

Copy link
Copy Markdown
Member

Summary

Salvages the still-valid, verified improvements from the stale AI-generated audit in #1516 and drops everything that no longer applies. #1516 predates the v4/v5 docs split and the substantial reference-doc rework since, and several of its claims were wrong. Every change here was checked against current main source before applying.

Scope is v5 only — v5 is the current source of truth. v4 docs describe the shipped 4.x packages and are intentionally left alone (see the error-text note below).

What changed (all verified against source)

  • start error text — "Workflow Development Kit" → "Workflow SDK" in start.mdx + 10 getting-started pages. Source emits the new string (packages/core/src/runtime/start.ts, renamed in Rename 'Workflow Development Kit' / 'DevKit' to 'Workflow SDK' #1595). v4 is not touched: no workflow@4.x tag ever emitted "Workflow SDK", so v4 docs correctly quote the old message.
  • define-hook — corrected a wrong return type. TypedHook.resume() returns Promise<HookEntity> and throws HookNotFoundError; the docs claimed it could return null and the example did a if (!result) check that can never fire. Fixed the signature block and the example (try/catch + HookNotFoundError.is).
  • fatal-error — replaced the broken placeholder TSDoc (interface Error with mangled JSDoc) with the real shape: message + fatal properties and the FatalError.is() static, matching the workflow-errors/* page convention.
  • resume-webhook — the Returns section listed only the manual respondWith() case; now enumerates all three outcomes (default 202 Accepted, configured static Response, manual Response).
  • sleep — it was described as "a special type of step function"; it is a built-in runtime primitive backed by a timer event, not a step.
  • fetch — the custom-wrapper example now calls globalThis.fetch (calling the imported workflow fetch inside a "use step" nests a step in a step); removed a bullet describing a maxRetries option the example never set.

Deliberately dropped from #1516 (not applied)

  • withWorkflowworkflows.lazyDiscovery / WORKFLOW_NEXT_LAZY_DISCOVERY / "Next ≥ 16.2.0-canary.48" — no such option, env var, or version gate exists in packages/next. Fabricated. The current with-workflow.mdx is already correct; applying docs: audit and align API reference with source #1516 would have regressed it (it also mislabeled the WORKFLOW_TARGET_WORLD values).
  • workflow-api overview getWorld move — already done on main (there's a dedicated workflow-runtime section).
  • get-step-metadata / get-workflow-metadata return tables — those pages already auto-render the real types via <TSDoc>; hand tables would duplicate and drift.
  • workflow-ai provider-subpath section — that surface is now documented as deprecated in favor of @ai-sdk/workflow; left to a maintainer.
  • workflow/index execution-context reorg — subjective restructuring; the current page has diverged (adds setAttributes/getWritable) and isn't wrong, just flat.

Validation

  • @workflow/docs-typecheck (test:docs) passes for all changed files — the new/edited code samples typecheck against the built packages.
  • fumadocs-mdx compiles the content collection with no parse errors.

Docs Preview

Base: workflow-docs preview (behind Vercel deployment protection — requires team access).

PagePreview
workflow/define-hookhttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow/define-hook
workflow/fatal-errorhttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow/fatal-error
workflow/fetchhttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow/fetch
workflow/sleephttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow/sleep
workflow-api/resume-webhookhttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow-api/resume-webhook
workflow-api/starthttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow-api/start
getting-started (error-text fix, ×10)e.g. next, express, astro

🤖 Generated with Claude Code

- start error text: "Workflow Development Kit" -> "Workflow SDK" (v5 only;
v4 published packages still emit the old string, so v4 docs are left as-is)
- define-hook: TypedHook.resume returns Promise<HookEntity> and throws
HookNotFoundError; the previous docs claimed it could return null
- fatal-error: document the `fatal` property and FatalError.is(); fix the
broken placeholder TSDoc block
- resume-webhook: enumerate the three Response outcomes (202 / configured
static Response / manual respondWith)
- sleep: it is a built-in runtime timer primitive, not a step function
- fetch: call globalThis.fetch inside the custom "use step" wrapper to avoid
nesting a step in a step; drop the maxRetries bullet describing code the
example never contained
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@VaguelySerious
VaguelySerious requested review from a team and ijjk as code ownersJuly 20, 2026 23:08
@vercel

vercelBot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a67c74c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@VaguelySerious
VaguelySerious merged commit 97a5355 into mainJul 21, 2026
54 checks passed
@VaguelySerious
VaguelySerious deleted the peter/docs-api-ref-audit branch July 21, 2026 18:43
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for 97a5355 (AI decision).

All changes are to v5 docs pages (docs/content/docs/v5/...) that document main-only beta behavior — e.g. the "Workflow SDK" error string introduced by #1595, which no shipped workflow@4.x release emits, and the PR explicitly leaves v4 docs untouched for that reason. Verified via git ls-tree origin/stable that none of the changed files exist on stable (its partial v5 tree covers only other reference sections), so a cherry-pick would only introduce main-only content. The only other change is an empty changeset, which is release plumbing.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

97a53550a41ee900d676f15c7b43bd489812b13b

pranaygp added a commit that referenced this pull request Jul 22, 2026
* origin/main: (162 commits)
Implement `max_events` per run limit (#2986)
[core] Enforce maxRetries for steps that time out (#3035)
[world-vercel] Idempotent retry policy for stream close (5xx retriable) (#3038)
[world] Guard hook_received against a concurrent run termination (#2987)
docs: fix stale/incorrect v5 API reference details (#3017)
Default WORKFLOW_PRECONDITION_GUARD on (#2946)
docs: replace migration guides with a Comparisons section (#2676)
feat(core): add experimental Hook minimum retention (#2865)
test: regression coverage for hook.resume() from isolated route bundles (o2flow beta.26 incident) (#3001)
docs(agents): note lint/format/typecheck are advisory, not blocking (#2886)
Retry transient connection timeouts (#3013)
fix(world-vercel): append caller User-Agent products instead of discarding them (#2998)
[ci] Enable NestJS e2e-vercel-prod and add to docs as "experimental" (#3011)
[ci] Benchmark comment: Best column + best/p75/p99 deltas (drop Avg/P10) (#3005)
docs: fall back to first child page for sidebar folders without an index (#3009)
[nest] Fix NestJS Vercel build output (#2988)
Avoid resolving run data for background steps (#2993)
chore(docs): update @vercel/geistdocs to 1.14.0 (#3002)
fix(docs): add version-switcher fallback redirects for pages missing in one version (#3003)
ci: update opencode to 1.18.4 and switch backport AI model to claude-fable-5 (#3006)
...
# Conflicts:
#	docs/content/docs/v4/deploying/meta.json
#	docs/content/docs/v5/deploying/meta.json
#	packages/core/src/runtime.ts
#	packages/world-local/src/index.ts
#	packages/world-postgres/src/index.ts
#	packages/world/src/events.ts
#	packages/world/src/interfaces.ts
#	packages/world/src/recovery.ts
#	workbench/nest/src/main.ts
#	workbench/sveltekit/src/hooks.server.ts
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@VaguelySerious@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
docs: fix stale/incorrect v5 API reference details by VaguelySerious · Pull Request #3017 · vercel/workflow · GitHub
Skip to content

docs: fix stale/incorrect v5 API reference details - #3017

Merged
VaguelySerious merged 1 commit into
mainfrom
peter/docs-api-ref-audit
Jul 21, 2026
Merged

docs: fix stale/incorrect v5 API reference details#3017
VaguelySerious merged 1 commit into
mainfrom
peter/docs-api-ref-audit

Conversation

@VaguelySerious

@VaguelySeriousVaguelySerious commented Jul 20, 2026

Copy link
Copy Markdown
Member

Summary

Salvages the still-valid, verified improvements from the stale AI-generated audit in #1516 and drops everything that no longer applies. #1516 predates the v4/v5 docs split and the substantial reference-doc rework since, and several of its claims were wrong. Every change here was checked against current main source before applying.

Scope is v5 only — v5 is the current source of truth. v4 docs describe the shipped 4.x packages and are intentionally left alone (see the error-text note below).

What changed (all verified against source)

  • start error text — "Workflow Development Kit" → "Workflow SDK" in start.mdx + 10 getting-started pages. Source emits the new string (packages/core/src/runtime/start.ts, renamed in Rename 'Workflow Development Kit' / 'DevKit' to 'Workflow SDK' #1595). v4 is not touched: no workflow@4.x tag ever emitted "Workflow SDK", so v4 docs correctly quote the old message.
  • define-hook — corrected a wrong return type. TypedHook.resume() returns Promise<HookEntity> and throws HookNotFoundError; the docs claimed it could return null and the example did a if (!result) check that can never fire. Fixed the signature block and the example (try/catch + HookNotFoundError.is).
  • fatal-error — replaced the broken placeholder TSDoc (interface Error with mangled JSDoc) with the real shape: message + fatal properties and the FatalError.is() static, matching the workflow-errors/* page convention.
  • resume-webhook — the Returns section listed only the manual respondWith() case; now enumerates all three outcomes (default 202 Accepted, configured static Response, manual Response).
  • sleep — it was described as "a special type of step function"; it is a built-in runtime primitive backed by a timer event, not a step.
  • fetch — the custom-wrapper example now calls globalThis.fetch (calling the imported workflow fetch inside a "use step" nests a step in a step); removed a bullet describing a maxRetries option the example never set.

Deliberately dropped from #1516 (not applied)

  • withWorkflowworkflows.lazyDiscovery / WORKFLOW_NEXT_LAZY_DISCOVERY / "Next ≥ 16.2.0-canary.48" — no such option, env var, or version gate exists in packages/next. Fabricated. The current with-workflow.mdx is already correct; applying docs: audit and align API reference with source #1516 would have regressed it (it also mislabeled the WORKFLOW_TARGET_WORLD values).
  • workflow-api overview getWorld move — already done on main (there's a dedicated workflow-runtime section).
  • get-step-metadata / get-workflow-metadata return tables — those pages already auto-render the real types via <TSDoc>; hand tables would duplicate and drift.
  • workflow-ai provider-subpath section — that surface is now documented as deprecated in favor of @ai-sdk/workflow; left to a maintainer.
  • workflow/index execution-context reorg — subjective restructuring; the current page has diverged (adds setAttributes/getWritable) and isn't wrong, just flat.

Validation

  • @workflow/docs-typecheck (test:docs) passes for all changed files — the new/edited code samples typecheck against the built packages.
  • fumadocs-mdx compiles the content collection with no parse errors.

Docs Preview

Base: workflow-docs preview (behind Vercel deployment protection — requires team access).

PagePreview
workflow/define-hookhttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow/define-hook
workflow/fatal-errorhttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow/fatal-error
workflow/fetchhttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow/fetch
workflow/sleephttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow/sleep
workflow-api/resume-webhookhttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow-api/resume-webhook
workflow-api/starthttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow-api/start
getting-started (error-text fix, ×10)e.g. next, express, astro

🤖 Generated with Claude Code

- start error text: "Workflow Development Kit" -> "Workflow SDK" (v5 only;
v4 published packages still emit the old string, so v4 docs are left as-is)
- define-hook: TypedHook.resume returns Promise<HookEntity> and throws
HookNotFoundError; the previous docs claimed it could return null
- fatal-error: document the `fatal` property and FatalError.is(); fix the
broken placeholder TSDoc block
- resume-webhook: enumerate the three Response outcomes (202 / configured
static Response / manual respondWith)
- sleep: it is a built-in runtime timer primitive, not a step function
- fetch: call globalThis.fetch inside the custom "use step" wrapper to avoid
nesting a step in a step; drop the maxRetries bullet describing code the
example never contained
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@VaguelySerious
VaguelySerious requested review from a team and ijjk as code ownersJuly 20, 2026 23:08
@vercel

vercelBot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a67c74c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@VaguelySerious
VaguelySerious merged commit 97a5355 into mainJul 21, 2026
54 checks passed
@VaguelySerious
VaguelySerious deleted the peter/docs-api-ref-audit branch July 21, 2026 18:43
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for 97a5355 (AI decision).

All changes are to v5 docs pages (docs/content/docs/v5/...) that document main-only beta behavior — e.g. the "Workflow SDK" error string introduced by #1595, which no shipped workflow@4.x release emits, and the PR explicitly leaves v4 docs untouched for that reason. Verified via git ls-tree origin/stable that none of the changed files exist on stable (its partial v5 tree covers only other reference sections), so a cherry-pick would only introduce main-only content. The only other change is an empty changeset, which is release plumbing.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

97a53550a41ee900d676f15c7b43bd489812b13b

pranaygp added a commit that referenced this pull request Jul 22, 2026
* origin/main: (162 commits)
Implement `max_events` per run limit (#2986)
[core] Enforce maxRetries for steps that time out (#3035)
[world-vercel] Idempotent retry policy for stream close (5xx retriable) (#3038)
[world] Guard hook_received against a concurrent run termination (#2987)
docs: fix stale/incorrect v5 API reference details (#3017)
Default WORKFLOW_PRECONDITION_GUARD on (#2946)
docs: replace migration guides with a Comparisons section (#2676)
feat(core): add experimental Hook minimum retention (#2865)
test: regression coverage for hook.resume() from isolated route bundles (o2flow beta.26 incident) (#3001)
docs(agents): note lint/format/typecheck are advisory, not blocking (#2886)
Retry transient connection timeouts (#3013)
fix(world-vercel): append caller User-Agent products instead of discarding them (#2998)
[ci] Enable NestJS e2e-vercel-prod and add to docs as "experimental" (#3011)
[ci] Benchmark comment: Best column + best/p75/p99 deltas (drop Avg/P10) (#3005)
docs: fall back to first child page for sidebar folders without an index (#3009)
[nest] Fix NestJS Vercel build output (#2988)
Avoid resolving run data for background steps (#2993)
chore(docs): update @vercel/geistdocs to 1.14.0 (#3002)
fix(docs): add version-switcher fallback redirects for pages missing in one version (#3003)
ci: update opencode to 1.18.4 and switch backport AI model to claude-fable-5 (#3006)
...
# Conflicts:
#	docs/content/docs/v4/deploying/meta.json
#	docs/content/docs/v5/deploying/meta.json
#	packages/core/src/runtime.ts
#	packages/world-local/src/index.ts
#	packages/world-postgres/src/index.ts
#	packages/world/src/events.ts
#	packages/world/src/interfaces.ts
#	packages/world/src/recovery.ts
#	workbench/nest/src/main.ts
#	workbench/sveltekit/src/hooks.server.ts
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@VaguelySerious@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' docs: fix stale/incorrect v5 API reference details by VaguelySerious · Pull Request #3017 · vercel/workflow · GitHub
Skip to content

docs: fix stale/incorrect v5 API reference details - #3017

Merged
VaguelySerious merged 1 commit into
mainfrom
peter/docs-api-ref-audit
Jul 21, 2026
Merged

docs: fix stale/incorrect v5 API reference details#3017
VaguelySerious merged 1 commit into
mainfrom
peter/docs-api-ref-audit

Conversation

@VaguelySerious

@VaguelySeriousVaguelySerious commented Jul 20, 2026

Copy link
Copy Markdown
Member

Summary

Salvages the still-valid, verified improvements from the stale AI-generated audit in #1516 and drops everything that no longer applies. #1516 predates the v4/v5 docs split and the substantial reference-doc rework since, and several of its claims were wrong. Every change here was checked against current main source before applying.

Scope is v5 only — v5 is the current source of truth. v4 docs describe the shipped 4.x packages and are intentionally left alone (see the error-text note below).

What changed (all verified against source)

  • start error text — "Workflow Development Kit" → "Workflow SDK" in start.mdx + 10 getting-started pages. Source emits the new string (packages/core/src/runtime/start.ts, renamed in Rename 'Workflow Development Kit' / 'DevKit' to 'Workflow SDK' #1595). v4 is not touched: no workflow@4.x tag ever emitted "Workflow SDK", so v4 docs correctly quote the old message.
  • define-hook — corrected a wrong return type. TypedHook.resume() returns Promise<HookEntity> and throws HookNotFoundError; the docs claimed it could return null and the example did a if (!result) check that can never fire. Fixed the signature block and the example (try/catch + HookNotFoundError.is).
  • fatal-error — replaced the broken placeholder TSDoc (interface Error with mangled JSDoc) with the real shape: message + fatal properties and the FatalError.is() static, matching the workflow-errors/* page convention.
  • resume-webhook — the Returns section listed only the manual respondWith() case; now enumerates all three outcomes (default 202 Accepted, configured static Response, manual Response).
  • sleep — it was described as "a special type of step function"; it is a built-in runtime primitive backed by a timer event, not a step.
  • fetch — the custom-wrapper example now calls globalThis.fetch (calling the imported workflow fetch inside a "use step" nests a step in a step); removed a bullet describing a maxRetries option the example never set.

Deliberately dropped from #1516 (not applied)

  • withWorkflowworkflows.lazyDiscovery / WORKFLOW_NEXT_LAZY_DISCOVERY / "Next ≥ 16.2.0-canary.48" — no such option, env var, or version gate exists in packages/next. Fabricated. The current with-workflow.mdx is already correct; applying docs: audit and align API reference with source #1516 would have regressed it (it also mislabeled the WORKFLOW_TARGET_WORLD values).
  • workflow-api overview getWorld move — already done on main (there's a dedicated workflow-runtime section).
  • get-step-metadata / get-workflow-metadata return tables — those pages already auto-render the real types via <TSDoc>; hand tables would duplicate and drift.
  • workflow-ai provider-subpath section — that surface is now documented as deprecated in favor of @ai-sdk/workflow; left to a maintainer.
  • workflow/index execution-context reorg — subjective restructuring; the current page has diverged (adds setAttributes/getWritable) and isn't wrong, just flat.

Validation

  • @workflow/docs-typecheck (test:docs) passes for all changed files — the new/edited code samples typecheck against the built packages.
  • fumadocs-mdx compiles the content collection with no parse errors.

Docs Preview

Base: workflow-docs preview (behind Vercel deployment protection — requires team access).

PagePreview
workflow/define-hookhttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow/define-hook
workflow/fatal-errorhttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow/fatal-error
workflow/fetchhttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow/fetch
workflow/sleephttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow/sleep
workflow-api/resume-webhookhttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow-api/resume-webhook
workflow-api/starthttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow-api/start
getting-started (error-text fix, ×10)e.g. next, express, astro

🤖 Generated with Claude Code

- start error text: "Workflow Development Kit" -> "Workflow SDK" (v5 only;
v4 published packages still emit the old string, so v4 docs are left as-is)
- define-hook: TypedHook.resume returns Promise<HookEntity> and throws
HookNotFoundError; the previous docs claimed it could return null
- fatal-error: document the `fatal` property and FatalError.is(); fix the
broken placeholder TSDoc block
- resume-webhook: enumerate the three Response outcomes (202 / configured
static Response / manual respondWith)
- sleep: it is a built-in runtime timer primitive, not a step function
- fetch: call globalThis.fetch inside the custom "use step" wrapper to avoid
nesting a step in a step; drop the maxRetries bullet describing code the
example never contained
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@VaguelySerious
VaguelySerious requested review from a team and ijjk as code ownersJuly 20, 2026 23:08
@vercel

vercelBot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a67c74c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@VaguelySerious
VaguelySerious merged commit 97a5355 into mainJul 21, 2026
54 checks passed
@VaguelySerious
VaguelySerious deleted the peter/docs-api-ref-audit branch July 21, 2026 18:43
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for 97a5355 (AI decision).

All changes are to v5 docs pages (docs/content/docs/v5/...) that document main-only beta behavior — e.g. the "Workflow SDK" error string introduced by #1595, which no shipped workflow@4.x release emits, and the PR explicitly leaves v4 docs untouched for that reason. Verified via git ls-tree origin/stable that none of the changed files exist on stable (its partial v5 tree covers only other reference sections), so a cherry-pick would only introduce main-only content. The only other change is an empty changeset, which is release plumbing.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

97a53550a41ee900d676f15c7b43bd489812b13b

pranaygp added a commit that referenced this pull request Jul 22, 2026
* origin/main: (162 commits)
Implement `max_events` per run limit (#2986)
[core] Enforce maxRetries for steps that time out (#3035)
[world-vercel] Idempotent retry policy for stream close (5xx retriable) (#3038)
[world] Guard hook_received against a concurrent run termination (#2987)
docs: fix stale/incorrect v5 API reference details (#3017)
Default WORKFLOW_PRECONDITION_GUARD on (#2946)
docs: replace migration guides with a Comparisons section (#2676)
feat(core): add experimental Hook minimum retention (#2865)
test: regression coverage for hook.resume() from isolated route bundles (o2flow beta.26 incident) (#3001)
docs(agents): note lint/format/typecheck are advisory, not blocking (#2886)
Retry transient connection timeouts (#3013)
fix(world-vercel): append caller User-Agent products instead of discarding them (#2998)
[ci] Enable NestJS e2e-vercel-prod and add to docs as "experimental" (#3011)
[ci] Benchmark comment: Best column + best/p75/p99 deltas (drop Avg/P10) (#3005)
docs: fall back to first child page for sidebar folders without an index (#3009)
[nest] Fix NestJS Vercel build output (#2988)
Avoid resolving run data for background steps (#2993)
chore(docs): update @vercel/geistdocs to 1.14.0 (#3002)
fix(docs): add version-switcher fallback redirects for pages missing in one version (#3003)
ci: update opencode to 1.18.4 and switch backport AI model to claude-fable-5 (#3006)
...
# Conflicts:
#	docs/content/docs/v4/deploying/meta.json
#	docs/content/docs/v5/deploying/meta.json
#	packages/core/src/runtime.ts
#	packages/world-local/src/index.ts
#	packages/world-postgres/src/index.ts
#	packages/world/src/events.ts
#	packages/world/src/interfaces.ts
#	packages/world/src/recovery.ts
#	workbench/nest/src/main.ts
#	workbench/sveltekit/src/hooks.server.ts
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@VaguelySerious@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' docs: fix stale/incorrect v5 API reference details by VaguelySerious · Pull Request #3017 · vercel/workflow · GitHub
Skip to content

docs: fix stale/incorrect v5 API reference details - #3017

Merged
VaguelySerious merged 1 commit into
mainfrom
peter/docs-api-ref-audit
Jul 21, 2026
Merged

docs: fix stale/incorrect v5 API reference details#3017
VaguelySerious merged 1 commit into
mainfrom
peter/docs-api-ref-audit

Conversation

@VaguelySerious

@VaguelySeriousVaguelySerious commented Jul 20, 2026

Copy link
Copy Markdown
Member

Summary

Salvages the still-valid, verified improvements from the stale AI-generated audit in #1516 and drops everything that no longer applies. #1516 predates the v4/v5 docs split and the substantial reference-doc rework since, and several of its claims were wrong. Every change here was checked against current main source before applying.

Scope is v5 only — v5 is the current source of truth. v4 docs describe the shipped 4.x packages and are intentionally left alone (see the error-text note below).

What changed (all verified against source)

  • start error text — "Workflow Development Kit" → "Workflow SDK" in start.mdx + 10 getting-started pages. Source emits the new string (packages/core/src/runtime/start.ts, renamed in Rename 'Workflow Development Kit' / 'DevKit' to 'Workflow SDK' #1595). v4 is not touched: no workflow@4.x tag ever emitted "Workflow SDK", so v4 docs correctly quote the old message.
  • define-hook — corrected a wrong return type. TypedHook.resume() returns Promise<HookEntity> and throws HookNotFoundError; the docs claimed it could return null and the example did a if (!result) check that can never fire. Fixed the signature block and the example (try/catch + HookNotFoundError.is).
  • fatal-error — replaced the broken placeholder TSDoc (interface Error with mangled JSDoc) with the real shape: message + fatal properties and the FatalError.is() static, matching the workflow-errors/* page convention.
  • resume-webhook — the Returns section listed only the manual respondWith() case; now enumerates all three outcomes (default 202 Accepted, configured static Response, manual Response).
  • sleep — it was described as "a special type of step function"; it is a built-in runtime primitive backed by a timer event, not a step.
  • fetch — the custom-wrapper example now calls globalThis.fetch (calling the imported workflow fetch inside a "use step" nests a step in a step); removed a bullet describing a maxRetries option the example never set.

Deliberately dropped from #1516 (not applied)

  • withWorkflowworkflows.lazyDiscovery / WORKFLOW_NEXT_LAZY_DISCOVERY / "Next ≥ 16.2.0-canary.48" — no such option, env var, or version gate exists in packages/next. Fabricated. The current with-workflow.mdx is already correct; applying docs: audit and align API reference with source #1516 would have regressed it (it also mislabeled the WORKFLOW_TARGET_WORLD values).
  • workflow-api overview getWorld move — already done on main (there's a dedicated workflow-runtime section).
  • get-step-metadata / get-workflow-metadata return tables — those pages already auto-render the real types via <TSDoc>; hand tables would duplicate and drift.
  • workflow-ai provider-subpath section — that surface is now documented as deprecated in favor of @ai-sdk/workflow; left to a maintainer.
  • workflow/index execution-context reorg — subjective restructuring; the current page has diverged (adds setAttributes/getWritable) and isn't wrong, just flat.

Validation

  • @workflow/docs-typecheck (test:docs) passes for all changed files — the new/edited code samples typecheck against the built packages.
  • fumadocs-mdx compiles the content collection with no parse errors.

Docs Preview

Base: workflow-docs preview (behind Vercel deployment protection — requires team access).

PagePreview
workflow/define-hookhttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow/define-hook
workflow/fatal-errorhttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow/fatal-error
workflow/fetchhttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow/fetch
workflow/sleephttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow/sleep
workflow-api/resume-webhookhttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow-api/resume-webhook
workflow-api/starthttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow-api/start
getting-started (error-text fix, ×10)e.g. next, express, astro

🤖 Generated with Claude Code

- start error text: "Workflow Development Kit" -> "Workflow SDK" (v5 only;
v4 published packages still emit the old string, so v4 docs are left as-is)
- define-hook: TypedHook.resume returns Promise<HookEntity> and throws
HookNotFoundError; the previous docs claimed it could return null
- fatal-error: document the `fatal` property and FatalError.is(); fix the
broken placeholder TSDoc block
- resume-webhook: enumerate the three Response outcomes (202 / configured
static Response / manual respondWith)
- sleep: it is a built-in runtime timer primitive, not a step function
- fetch: call globalThis.fetch inside the custom "use step" wrapper to avoid
nesting a step in a step; drop the maxRetries bullet describing code the
example never contained
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@VaguelySerious
VaguelySerious requested review from a team and ijjk as code ownersJuly 20, 2026 23:08
@vercel

vercelBot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a67c74c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@VaguelySerious
VaguelySerious merged commit 97a5355 into mainJul 21, 2026
54 checks passed
@VaguelySerious
VaguelySerious deleted the peter/docs-api-ref-audit branch July 21, 2026 18:43
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for 97a5355 (AI decision).

All changes are to v5 docs pages (docs/content/docs/v5/...) that document main-only beta behavior — e.g. the "Workflow SDK" error string introduced by #1595, which no shipped workflow@4.x release emits, and the PR explicitly leaves v4 docs untouched for that reason. Verified via git ls-tree origin/stable that none of the changed files exist on stable (its partial v5 tree covers only other reference sections), so a cherry-pick would only introduce main-only content. The only other change is an empty changeset, which is release plumbing.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

97a53550a41ee900d676f15c7b43bd489812b13b

pranaygp added a commit that referenced this pull request Jul 22, 2026
* origin/main: (162 commits)
Implement `max_events` per run limit (#2986)
[core] Enforce maxRetries for steps that time out (#3035)
[world-vercel] Idempotent retry policy for stream close (5xx retriable) (#3038)
[world] Guard hook_received against a concurrent run termination (#2987)
docs: fix stale/incorrect v5 API reference details (#3017)
Default WORKFLOW_PRECONDITION_GUARD on (#2946)
docs: replace migration guides with a Comparisons section (#2676)
feat(core): add experimental Hook minimum retention (#2865)
test: regression coverage for hook.resume() from isolated route bundles (o2flow beta.26 incident) (#3001)
docs(agents): note lint/format/typecheck are advisory, not blocking (#2886)
Retry transient connection timeouts (#3013)
fix(world-vercel): append caller User-Agent products instead of discarding them (#2998)
[ci] Enable NestJS e2e-vercel-prod and add to docs as "experimental" (#3011)
[ci] Benchmark comment: Best column + best/p75/p99 deltas (drop Avg/P10) (#3005)
docs: fall back to first child page for sidebar folders without an index (#3009)
[nest] Fix NestJS Vercel build output (#2988)
Avoid resolving run data for background steps (#2993)
chore(docs): update @vercel/geistdocs to 1.14.0 (#3002)
fix(docs): add version-switcher fallback redirects for pages missing in one version (#3003)
ci: update opencode to 1.18.4 and switch backport AI model to claude-fable-5 (#3006)
...
# Conflicts:
#	docs/content/docs/v4/deploying/meta.json
#	docs/content/docs/v5/deploying/meta.json
#	packages/core/src/runtime.ts
#	packages/world-local/src/index.ts
#	packages/world-postgres/src/index.ts
#	packages/world/src/events.ts
#	packages/world/src/interfaces.ts
#	packages/world/src/recovery.ts
#	workbench/nest/src/main.ts
#	workbench/sveltekit/src/hooks.server.ts
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@VaguelySerious@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' docs: fix stale/incorrect v5 API reference details by VaguelySerious · Pull Request #3017 · vercel/workflow · GitHub
Skip to content

docs: fix stale/incorrect v5 API reference details - #3017

Merged
VaguelySerious merged 1 commit into
mainfrom
peter/docs-api-ref-audit
Jul 21, 2026
Merged

docs: fix stale/incorrect v5 API reference details#3017
VaguelySerious merged 1 commit into
mainfrom
peter/docs-api-ref-audit

Conversation

@VaguelySerious

@VaguelySeriousVaguelySerious commented Jul 20, 2026

Copy link
Copy Markdown
Member

Summary

Salvages the still-valid, verified improvements from the stale AI-generated audit in #1516 and drops everything that no longer applies. #1516 predates the v4/v5 docs split and the substantial reference-doc rework since, and several of its claims were wrong. Every change here was checked against current main source before applying.

Scope is v5 only — v5 is the current source of truth. v4 docs describe the shipped 4.x packages and are intentionally left alone (see the error-text note below).

What changed (all verified against source)

  • start error text — "Workflow Development Kit" → "Workflow SDK" in start.mdx + 10 getting-started pages. Source emits the new string (packages/core/src/runtime/start.ts, renamed in Rename 'Workflow Development Kit' / 'DevKit' to 'Workflow SDK' #1595). v4 is not touched: no workflow@4.x tag ever emitted "Workflow SDK", so v4 docs correctly quote the old message.
  • define-hook — corrected a wrong return type. TypedHook.resume() returns Promise<HookEntity> and throws HookNotFoundError; the docs claimed it could return null and the example did a if (!result) check that can never fire. Fixed the signature block and the example (try/catch + HookNotFoundError.is).
  • fatal-error — replaced the broken placeholder TSDoc (interface Error with mangled JSDoc) with the real shape: message + fatal properties and the FatalError.is() static, matching the workflow-errors/* page convention.
  • resume-webhook — the Returns section listed only the manual respondWith() case; now enumerates all three outcomes (default 202 Accepted, configured static Response, manual Response).
  • sleep — it was described as "a special type of step function"; it is a built-in runtime primitive backed by a timer event, not a step.
  • fetch — the custom-wrapper example now calls globalThis.fetch (calling the imported workflow fetch inside a "use step" nests a step in a step); removed a bullet describing a maxRetries option the example never set.

Deliberately dropped from #1516 (not applied)

  • withWorkflowworkflows.lazyDiscovery / WORKFLOW_NEXT_LAZY_DISCOVERY / "Next ≥ 16.2.0-canary.48" — no such option, env var, or version gate exists in packages/next. Fabricated. The current with-workflow.mdx is already correct; applying docs: audit and align API reference with source #1516 would have regressed it (it also mislabeled the WORKFLOW_TARGET_WORLD values).
  • workflow-api overview getWorld move — already done on main (there's a dedicated workflow-runtime section).
  • get-step-metadata / get-workflow-metadata return tables — those pages already auto-render the real types via <TSDoc>; hand tables would duplicate and drift.
  • workflow-ai provider-subpath section — that surface is now documented as deprecated in favor of @ai-sdk/workflow; left to a maintainer.
  • workflow/index execution-context reorg — subjective restructuring; the current page has diverged (adds setAttributes/getWritable) and isn't wrong, just flat.

Validation

  • @workflow/docs-typecheck (test:docs) passes for all changed files — the new/edited code samples typecheck against the built packages.
  • fumadocs-mdx compiles the content collection with no parse errors.

Docs Preview

Base: workflow-docs preview (behind Vercel deployment protection — requires team access).

PagePreview
workflow/define-hookhttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow/define-hook
workflow/fatal-errorhttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow/fatal-error
workflow/fetchhttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow/fetch
workflow/sleephttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow/sleep
workflow-api/resume-webhookhttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow-api/resume-webhook
workflow-api/starthttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow-api/start
getting-started (error-text fix, ×10)e.g. next, express, astro

🤖 Generated with Claude Code

- start error text: "Workflow Development Kit" -> "Workflow SDK" (v5 only;
v4 published packages still emit the old string, so v4 docs are left as-is)
- define-hook: TypedHook.resume returns Promise<HookEntity> and throws
HookNotFoundError; the previous docs claimed it could return null
- fatal-error: document the `fatal` property and FatalError.is(); fix the
broken placeholder TSDoc block
- resume-webhook: enumerate the three Response outcomes (202 / configured
static Response / manual respondWith)
- sleep: it is a built-in runtime timer primitive, not a step function
- fetch: call globalThis.fetch inside the custom "use step" wrapper to avoid
nesting a step in a step; drop the maxRetries bullet describing code the
example never contained
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@VaguelySerious
VaguelySerious requested review from a team and ijjk as code ownersJuly 20, 2026 23:08
@vercel

vercelBot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a67c74c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@VaguelySerious
VaguelySerious merged commit 97a5355 into mainJul 21, 2026
54 checks passed
@VaguelySerious
VaguelySerious deleted the peter/docs-api-ref-audit branch July 21, 2026 18:43
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for 97a5355 (AI decision).

All changes are to v5 docs pages (docs/content/docs/v5/...) that document main-only beta behavior — e.g. the "Workflow SDK" error string introduced by #1595, which no shipped workflow@4.x release emits, and the PR explicitly leaves v4 docs untouched for that reason. Verified via git ls-tree origin/stable that none of the changed files exist on stable (its partial v5 tree covers only other reference sections), so a cherry-pick would only introduce main-only content. The only other change is an empty changeset, which is release plumbing.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

97a53550a41ee900d676f15c7b43bd489812b13b

pranaygp added a commit that referenced this pull request Jul 22, 2026
* origin/main: (162 commits)
Implement `max_events` per run limit (#2986)
[core] Enforce maxRetries for steps that time out (#3035)
[world-vercel] Idempotent retry policy for stream close (5xx retriable) (#3038)
[world] Guard hook_received against a concurrent run termination (#2987)
docs: fix stale/incorrect v5 API reference details (#3017)
Default WORKFLOW_PRECONDITION_GUARD on (#2946)
docs: replace migration guides with a Comparisons section (#2676)
feat(core): add experimental Hook minimum retention (#2865)
test: regression coverage for hook.resume() from isolated route bundles (o2flow beta.26 incident) (#3001)
docs(agents): note lint/format/typecheck are advisory, not blocking (#2886)
Retry transient connection timeouts (#3013)
fix(world-vercel): append caller User-Agent products instead of discarding them (#2998)
[ci] Enable NestJS e2e-vercel-prod and add to docs as "experimental" (#3011)
[ci] Benchmark comment: Best column + best/p75/p99 deltas (drop Avg/P10) (#3005)
docs: fall back to first child page for sidebar folders without an index (#3009)
[nest] Fix NestJS Vercel build output (#2988)
Avoid resolving run data for background steps (#2993)
chore(docs): update @vercel/geistdocs to 1.14.0 (#3002)
fix(docs): add version-switcher fallback redirects for pages missing in one version (#3003)
ci: update opencode to 1.18.4 and switch backport AI model to claude-fable-5 (#3006)
...
# Conflicts:
#	docs/content/docs/v4/deploying/meta.json
#	docs/content/docs/v5/deploying/meta.json
#	packages/core/src/runtime.ts
#	packages/world-local/src/index.ts
#	packages/world-postgres/src/index.ts
#	packages/world/src/events.ts
#	packages/world/src/interfaces.ts
#	packages/world/src/recovery.ts
#	workbench/nest/src/main.ts
#	workbench/sveltekit/src/hooks.server.ts
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@VaguelySerious@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' docs: fix stale/incorrect v5 API reference details by VaguelySerious · Pull Request #3017 · vercel/workflow · GitHub
Skip to content

docs: fix stale/incorrect v5 API reference details - #3017

Merged
VaguelySerious merged 1 commit into
mainfrom
peter/docs-api-ref-audit
Jul 21, 2026
Merged

docs: fix stale/incorrect v5 API reference details#3017
VaguelySerious merged 1 commit into
mainfrom
peter/docs-api-ref-audit

Conversation

@VaguelySerious

@VaguelySeriousVaguelySerious commented Jul 20, 2026

Copy link
Copy Markdown
Member

Summary

Salvages the still-valid, verified improvements from the stale AI-generated audit in #1516 and drops everything that no longer applies. #1516 predates the v4/v5 docs split and the substantial reference-doc rework since, and several of its claims were wrong. Every change here was checked against current main source before applying.

Scope is v5 only — v5 is the current source of truth. v4 docs describe the shipped 4.x packages and are intentionally left alone (see the error-text note below).

What changed (all verified against source)

  • start error text — "Workflow Development Kit" → "Workflow SDK" in start.mdx + 10 getting-started pages. Source emits the new string (packages/core/src/runtime/start.ts, renamed in Rename 'Workflow Development Kit' / 'DevKit' to 'Workflow SDK' #1595). v4 is not touched: no workflow@4.x tag ever emitted "Workflow SDK", so v4 docs correctly quote the old message.
  • define-hook — corrected a wrong return type. TypedHook.resume() returns Promise<HookEntity> and throws HookNotFoundError; the docs claimed it could return null and the example did a if (!result) check that can never fire. Fixed the signature block and the example (try/catch + HookNotFoundError.is).
  • fatal-error — replaced the broken placeholder TSDoc (interface Error with mangled JSDoc) with the real shape: message + fatal properties and the FatalError.is() static, matching the workflow-errors/* page convention.
  • resume-webhook — the Returns section listed only the manual respondWith() case; now enumerates all three outcomes (default 202 Accepted, configured static Response, manual Response).
  • sleep — it was described as "a special type of step function"; it is a built-in runtime primitive backed by a timer event, not a step.
  • fetch — the custom-wrapper example now calls globalThis.fetch (calling the imported workflow fetch inside a "use step" nests a step in a step); removed a bullet describing a maxRetries option the example never set.

Deliberately dropped from #1516 (not applied)

  • withWorkflowworkflows.lazyDiscovery / WORKFLOW_NEXT_LAZY_DISCOVERY / "Next ≥ 16.2.0-canary.48" — no such option, env var, or version gate exists in packages/next. Fabricated. The current with-workflow.mdx is already correct; applying docs: audit and align API reference with source #1516 would have regressed it (it also mislabeled the WORKFLOW_TARGET_WORLD values).
  • workflow-api overview getWorld move — already done on main (there's a dedicated workflow-runtime section).
  • get-step-metadata / get-workflow-metadata return tables — those pages already auto-render the real types via <TSDoc>; hand tables would duplicate and drift.
  • workflow-ai provider-subpath section — that surface is now documented as deprecated in favor of @ai-sdk/workflow; left to a maintainer.
  • workflow/index execution-context reorg — subjective restructuring; the current page has diverged (adds setAttributes/getWritable) and isn't wrong, just flat.

Validation

  • @workflow/docs-typecheck (test:docs) passes for all changed files — the new/edited code samples typecheck against the built packages.
  • fumadocs-mdx compiles the content collection with no parse errors.

Docs Preview

Base: workflow-docs preview (behind Vercel deployment protection — requires team access).

PagePreview
workflow/define-hookhttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow/define-hook
workflow/fatal-errorhttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow/fatal-error
workflow/fetchhttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow/fetch
workflow/sleephttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow/sleep
workflow-api/resume-webhookhttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow-api/resume-webhook
workflow-api/starthttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow-api/start
getting-started (error-text fix, ×10)e.g. next, express, astro

🤖 Generated with Claude Code

- start error text: "Workflow Development Kit" -> "Workflow SDK" (v5 only;
v4 published packages still emit the old string, so v4 docs are left as-is)
- define-hook: TypedHook.resume returns Promise<HookEntity> and throws
HookNotFoundError; the previous docs claimed it could return null
- fatal-error: document the `fatal` property and FatalError.is(); fix the
broken placeholder TSDoc block
- resume-webhook: enumerate the three Response outcomes (202 / configured
static Response / manual respondWith)
- sleep: it is a built-in runtime timer primitive, not a step function
- fetch: call globalThis.fetch inside the custom "use step" wrapper to avoid
nesting a step in a step; drop the maxRetries bullet describing code the
example never contained
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@VaguelySerious
VaguelySerious requested review from a team and ijjk as code ownersJuly 20, 2026 23:08
@vercel

vercelBot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a67c74c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@VaguelySerious
VaguelySerious merged commit 97a5355 into mainJul 21, 2026
54 checks passed
@VaguelySerious
VaguelySerious deleted the peter/docs-api-ref-audit branch July 21, 2026 18:43
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for 97a5355 (AI decision).

All changes are to v5 docs pages (docs/content/docs/v5/...) that document main-only beta behavior — e.g. the "Workflow SDK" error string introduced by #1595, which no shipped workflow@4.x release emits, and the PR explicitly leaves v4 docs untouched for that reason. Verified via git ls-tree origin/stable that none of the changed files exist on stable (its partial v5 tree covers only other reference sections), so a cherry-pick would only introduce main-only content. The only other change is an empty changeset, which is release plumbing.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

97a53550a41ee900d676f15c7b43bd489812b13b

pranaygp added a commit that referenced this pull request Jul 22, 2026
* origin/main: (162 commits)
Implement `max_events` per run limit (#2986)
[core] Enforce maxRetries for steps that time out (#3035)
[world-vercel] Idempotent retry policy for stream close (5xx retriable) (#3038)
[world] Guard hook_received against a concurrent run termination (#2987)
docs: fix stale/incorrect v5 API reference details (#3017)
Default WORKFLOW_PRECONDITION_GUARD on (#2946)
docs: replace migration guides with a Comparisons section (#2676)
feat(core): add experimental Hook minimum retention (#2865)
test: regression coverage for hook.resume() from isolated route bundles (o2flow beta.26 incident) (#3001)
docs(agents): note lint/format/typecheck are advisory, not blocking (#2886)
Retry transient connection timeouts (#3013)
fix(world-vercel): append caller User-Agent products instead of discarding them (#2998)
[ci] Enable NestJS e2e-vercel-prod and add to docs as "experimental" (#3011)
[ci] Benchmark comment: Best column + best/p75/p99 deltas (drop Avg/P10) (#3005)
docs: fall back to first child page for sidebar folders without an index (#3009)
[nest] Fix NestJS Vercel build output (#2988)
Avoid resolving run data for background steps (#2993)
chore(docs): update @vercel/geistdocs to 1.14.0 (#3002)
fix(docs): add version-switcher fallback redirects for pages missing in one version (#3003)
ci: update opencode to 1.18.4 and switch backport AI model to claude-fable-5 (#3006)
...
# Conflicts:
#	docs/content/docs/v4/deploying/meta.json
#	docs/content/docs/v5/deploying/meta.json
#	packages/core/src/runtime.ts
#	packages/world-local/src/index.ts
#	packages/world-postgres/src/index.ts
#	packages/world/src/events.ts
#	packages/world/src/interfaces.ts
#	packages/world/src/recovery.ts
#	workbench/nest/src/main.ts
#	workbench/sveltekit/src/hooks.server.ts
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@VaguelySerious@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' docs: fix stale/incorrect v5 API reference details by VaguelySerious · Pull Request #3017 · vercel/workflow · GitHub
Skip to content

docs: fix stale/incorrect v5 API reference details - #3017

Merged
VaguelySerious merged 1 commit into
mainfrom
peter/docs-api-ref-audit
Jul 21, 2026
Merged

docs: fix stale/incorrect v5 API reference details#3017
VaguelySerious merged 1 commit into
mainfrom
peter/docs-api-ref-audit

Conversation

@VaguelySerious

@VaguelySeriousVaguelySerious commented Jul 20, 2026

Copy link
Copy Markdown
Member

Summary

Salvages the still-valid, verified improvements from the stale AI-generated audit in #1516 and drops everything that no longer applies. #1516 predates the v4/v5 docs split and the substantial reference-doc rework since, and several of its claims were wrong. Every change here was checked against current main source before applying.

Scope is v5 only — v5 is the current source of truth. v4 docs describe the shipped 4.x packages and are intentionally left alone (see the error-text note below).

What changed (all verified against source)

  • start error text — "Workflow Development Kit" → "Workflow SDK" in start.mdx + 10 getting-started pages. Source emits the new string (packages/core/src/runtime/start.ts, renamed in Rename 'Workflow Development Kit' / 'DevKit' to 'Workflow SDK' #1595). v4 is not touched: no workflow@4.x tag ever emitted "Workflow SDK", so v4 docs correctly quote the old message.
  • define-hook — corrected a wrong return type. TypedHook.resume() returns Promise<HookEntity> and throws HookNotFoundError; the docs claimed it could return null and the example did a if (!result) check that can never fire. Fixed the signature block and the example (try/catch + HookNotFoundError.is).
  • fatal-error — replaced the broken placeholder TSDoc (interface Error with mangled JSDoc) with the real shape: message + fatal properties and the FatalError.is() static, matching the workflow-errors/* page convention.
  • resume-webhook — the Returns section listed only the manual respondWith() case; now enumerates all three outcomes (default 202 Accepted, configured static Response, manual Response).
  • sleep — it was described as "a special type of step function"; it is a built-in runtime primitive backed by a timer event, not a step.
  • fetch — the custom-wrapper example now calls globalThis.fetch (calling the imported workflow fetch inside a "use step" nests a step in a step); removed a bullet describing a maxRetries option the example never set.

Deliberately dropped from #1516 (not applied)

  • withWorkflowworkflows.lazyDiscovery / WORKFLOW_NEXT_LAZY_DISCOVERY / "Next ≥ 16.2.0-canary.48" — no such option, env var, or version gate exists in packages/next. Fabricated. The current with-workflow.mdx is already correct; applying docs: audit and align API reference with source #1516 would have regressed it (it also mislabeled the WORKFLOW_TARGET_WORLD values).
  • workflow-api overview getWorld move — already done on main (there's a dedicated workflow-runtime section).
  • get-step-metadata / get-workflow-metadata return tables — those pages already auto-render the real types via <TSDoc>; hand tables would duplicate and drift.
  • workflow-ai provider-subpath section — that surface is now documented as deprecated in favor of @ai-sdk/workflow; left to a maintainer.
  • workflow/index execution-context reorg — subjective restructuring; the current page has diverged (adds setAttributes/getWritable) and isn't wrong, just flat.

Validation

  • @workflow/docs-typecheck (test:docs) passes for all changed files — the new/edited code samples typecheck against the built packages.
  • fumadocs-mdx compiles the content collection with no parse errors.

Docs Preview

Base: workflow-docs preview (behind Vercel deployment protection — requires team access).

PagePreview
workflow/define-hookhttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow/define-hook
workflow/fatal-errorhttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow/fatal-error
workflow/fetchhttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow/fetch
workflow/sleephttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow/sleep
workflow-api/resume-webhookhttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow-api/resume-webhook
workflow-api/starthttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow-api/start
getting-started (error-text fix, ×10)e.g. next, express, astro

🤖 Generated with Claude Code

- start error text: "Workflow Development Kit" -> "Workflow SDK" (v5 only;
v4 published packages still emit the old string, so v4 docs are left as-is)
- define-hook: TypedHook.resume returns Promise<HookEntity> and throws
HookNotFoundError; the previous docs claimed it could return null
- fatal-error: document the `fatal` property and FatalError.is(); fix the
broken placeholder TSDoc block
- resume-webhook: enumerate the three Response outcomes (202 / configured
static Response / manual respondWith)
- sleep: it is a built-in runtime timer primitive, not a step function
- fetch: call globalThis.fetch inside the custom "use step" wrapper to avoid
nesting a step in a step; drop the maxRetries bullet describing code the
example never contained
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@VaguelySerious
VaguelySerious requested review from a team and ijjk as code ownersJuly 20, 2026 23:08
@vercel

vercelBot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a67c74c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@VaguelySerious
VaguelySerious merged commit 97a5355 into mainJul 21, 2026
54 checks passed
@VaguelySerious
VaguelySerious deleted the peter/docs-api-ref-audit branch July 21, 2026 18:43
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for 97a5355 (AI decision).

All changes are to v5 docs pages (docs/content/docs/v5/...) that document main-only beta behavior — e.g. the "Workflow SDK" error string introduced by #1595, which no shipped workflow@4.x release emits, and the PR explicitly leaves v4 docs untouched for that reason. Verified via git ls-tree origin/stable that none of the changed files exist on stable (its partial v5 tree covers only other reference sections), so a cherry-pick would only introduce main-only content. The only other change is an empty changeset, which is release plumbing.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

97a53550a41ee900d676f15c7b43bd489812b13b

pranaygp added a commit that referenced this pull request Jul 22, 2026
* origin/main: (162 commits)
Implement `max_events` per run limit (#2986)
[core] Enforce maxRetries for steps that time out (#3035)
[world-vercel] Idempotent retry policy for stream close (5xx retriable) (#3038)
[world] Guard hook_received against a concurrent run termination (#2987)
docs: fix stale/incorrect v5 API reference details (#3017)
Default WORKFLOW_PRECONDITION_GUARD on (#2946)
docs: replace migration guides with a Comparisons section (#2676)
feat(core): add experimental Hook minimum retention (#2865)
test: regression coverage for hook.resume() from isolated route bundles (o2flow beta.26 incident) (#3001)
docs(agents): note lint/format/typecheck are advisory, not blocking (#2886)
Retry transient connection timeouts (#3013)
fix(world-vercel): append caller User-Agent products instead of discarding them (#2998)
[ci] Enable NestJS e2e-vercel-prod and add to docs as "experimental" (#3011)
[ci] Benchmark comment: Best column + best/p75/p99 deltas (drop Avg/P10) (#3005)
docs: fall back to first child page for sidebar folders without an index (#3009)
[nest] Fix NestJS Vercel build output (#2988)
Avoid resolving run data for background steps (#2993)
chore(docs): update @vercel/geistdocs to 1.14.0 (#3002)
fix(docs): add version-switcher fallback redirects for pages missing in one version (#3003)
ci: update opencode to 1.18.4 and switch backport AI model to claude-fable-5 (#3006)
...
# Conflicts:
#	docs/content/docs/v4/deploying/meta.json
#	docs/content/docs/v5/deploying/meta.json
#	packages/core/src/runtime.ts
#	packages/world-local/src/index.ts
#	packages/world-postgres/src/index.ts
#	packages/world/src/events.ts
#	packages/world/src/interfaces.ts
#	packages/world/src/recovery.ts
#	workbench/nest/src/main.ts
#	workbench/sveltekit/src/hooks.server.ts
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@VaguelySerious@karthikscale3
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); docs: fix stale/incorrect v5 API reference details by VaguelySerious · Pull Request #3017 · vercel/workflow · GitHub
Skip to content

docs: fix stale/incorrect v5 API reference details - #3017

Merged
VaguelySerious merged 1 commit into
mainfrom
peter/docs-api-ref-audit
Jul 21, 2026
Merged

docs: fix stale/incorrect v5 API reference details#3017
VaguelySerious merged 1 commit into
mainfrom
peter/docs-api-ref-audit

Conversation

@VaguelySerious

@VaguelySeriousVaguelySerious commented Jul 20, 2026

Copy link
Copy Markdown
Member

Summary

Salvages the still-valid, verified improvements from the stale AI-generated audit in #1516 and drops everything that no longer applies. #1516 predates the v4/v5 docs split and the substantial reference-doc rework since, and several of its claims were wrong. Every change here was checked against current main source before applying.

Scope is v5 only — v5 is the current source of truth. v4 docs describe the shipped 4.x packages and are intentionally left alone (see the error-text note below).

What changed (all verified against source)

  • start error text — "Workflow Development Kit" → "Workflow SDK" in start.mdx + 10 getting-started pages. Source emits the new string (packages/core/src/runtime/start.ts, renamed in Rename 'Workflow Development Kit' / 'DevKit' to 'Workflow SDK' #1595). v4 is not touched: no workflow@4.x tag ever emitted "Workflow SDK", so v4 docs correctly quote the old message.
  • define-hook — corrected a wrong return type. TypedHook.resume() returns Promise<HookEntity> and throws HookNotFoundError; the docs claimed it could return null and the example did a if (!result) check that can never fire. Fixed the signature block and the example (try/catch + HookNotFoundError.is).
  • fatal-error — replaced the broken placeholder TSDoc (interface Error with mangled JSDoc) with the real shape: message + fatal properties and the FatalError.is() static, matching the workflow-errors/* page convention.
  • resume-webhook — the Returns section listed only the manual respondWith() case; now enumerates all three outcomes (default 202 Accepted, configured static Response, manual Response).
  • sleep — it was described as "a special type of step function"; it is a built-in runtime primitive backed by a timer event, not a step.
  • fetch — the custom-wrapper example now calls globalThis.fetch (calling the imported workflow fetch inside a "use step" nests a step in a step); removed a bullet describing a maxRetries option the example never set.

Deliberately dropped from #1516 (not applied)

  • withWorkflowworkflows.lazyDiscovery / WORKFLOW_NEXT_LAZY_DISCOVERY / "Next ≥ 16.2.0-canary.48" — no such option, env var, or version gate exists in packages/next. Fabricated. The current with-workflow.mdx is already correct; applying docs: audit and align API reference with source #1516 would have regressed it (it also mislabeled the WORKFLOW_TARGET_WORLD values).
  • workflow-api overview getWorld move — already done on main (there's a dedicated workflow-runtime section).
  • get-step-metadata / get-workflow-metadata return tables — those pages already auto-render the real types via <TSDoc>; hand tables would duplicate and drift.
  • workflow-ai provider-subpath section — that surface is now documented as deprecated in favor of @ai-sdk/workflow; left to a maintainer.
  • workflow/index execution-context reorg — subjective restructuring; the current page has diverged (adds setAttributes/getWritable) and isn't wrong, just flat.

Validation

  • @workflow/docs-typecheck (test:docs) passes for all changed files — the new/edited code samples typecheck against the built packages.
  • fumadocs-mdx compiles the content collection with no parse errors.

Docs Preview

Base: workflow-docs preview (behind Vercel deployment protection — requires team access).

PagePreview
workflow/define-hookhttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow/define-hook
workflow/fatal-errorhttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow/fatal-error
workflow/fetchhttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow/fetch
workflow/sleephttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow/sleep
workflow-api/resume-webhookhttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow-api/resume-webhook
workflow-api/starthttps://workflow-docs-git-peter-docs-api-ref-audit.vercel.sh/v5/docs/api-reference/workflow-api/start
getting-started (error-text fix, ×10)e.g. next, express, astro

🤖 Generated with Claude Code

- start error text: "Workflow Development Kit" -> "Workflow SDK" (v5 only;
v4 published packages still emit the old string, so v4 docs are left as-is)
- define-hook: TypedHook.resume returns Promise<HookEntity> and throws
HookNotFoundError; the previous docs claimed it could return null
- fatal-error: document the `fatal` property and FatalError.is(); fix the
broken placeholder TSDoc block
- resume-webhook: enumerate the three Response outcomes (202 / configured
static Response / manual respondWith)
- sleep: it is a built-in runtime timer primitive, not a step function
- fetch: call globalThis.fetch inside the custom "use step" wrapper to avoid
nesting a step in a step; drop the maxRetries bullet describing code the
example never contained
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@VaguelySerious
VaguelySerious requested review from a team and ijjk as code ownersJuly 20, 2026 23:08
@vercel

vercelBot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a67c74c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@VaguelySerious
VaguelySerious merged commit 97a5355 into mainJul 21, 2026
54 checks passed
@VaguelySerious
VaguelySerious deleted the peter/docs-api-ref-audit branch July 21, 2026 18:43
@github-actions

Copy link
Copy Markdown
Contributor

No backport to stable for 97a5355 (AI decision).

All changes are to v5 docs pages (docs/content/docs/v5/...) that document main-only beta behavior — e.g. the "Workflow SDK" error string introduced by #1595, which no shipped workflow@4.x release emits, and the PR explicitly leaves v4 docs untouched for that reason. Verified via git ls-tree origin/stable that none of the changed files exist on stable (its partial v5 tree covers only other reference sections), so a cherry-pick would only introduce main-only content. The only other change is an empty changeset, which is release plumbing.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

97a53550a41ee900d676f15c7b43bd489812b13b

pranaygp added a commit that referenced this pull request Jul 22, 2026
* origin/main: (162 commits)
Implement `max_events` per run limit (#2986)
[core] Enforce maxRetries for steps that time out (#3035)
[world-vercel] Idempotent retry policy for stream close (5xx retriable) (#3038)
[world] Guard hook_received against a concurrent run termination (#2987)
docs: fix stale/incorrect v5 API reference details (#3017)
Default WORKFLOW_PRECONDITION_GUARD on (#2946)
docs: replace migration guides with a Comparisons section (#2676)
feat(core): add experimental Hook minimum retention (#2865)
test: regression coverage for hook.resume() from isolated route bundles (o2flow beta.26 incident) (#3001)
docs(agents): note lint/format/typecheck are advisory, not blocking (#2886)
Retry transient connection timeouts (#3013)
fix(world-vercel): append caller User-Agent products instead of discarding them (#2998)
[ci] Enable NestJS e2e-vercel-prod and add to docs as "experimental" (#3011)
[ci] Benchmark comment: Best column + best/p75/p99 deltas (drop Avg/P10) (#3005)
docs: fall back to first child page for sidebar folders without an index (#3009)
[nest] Fix NestJS Vercel build output (#2988)
Avoid resolving run data for background steps (#2993)
chore(docs): update @vercel/geistdocs to 1.14.0 (#3002)
fix(docs): add version-switcher fallback redirects for pages missing in one version (#3003)
ci: update opencode to 1.18.4 and switch backport AI model to claude-fable-5 (#3006)
...
# Conflicts:
#	docs/content/docs/v4/deploying/meta.json
#	docs/content/docs/v5/deploying/meta.json
#	packages/core/src/runtime.ts
#	packages/world-local/src/index.ts
#	packages/world-postgres/src/index.ts
#	packages/world/src/events.ts
#	packages/world/src/interfaces.ts
#	packages/world/src/recovery.ts
#	workbench/nest/src/main.ts
#	workbench/sveltekit/src/hooks.server.ts
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@VaguelySerious@karthikscale3