Skip to content

Optimize processImportSpecifier by computing shouldFollowImportsFromFile once per file - #3052

Merged
VaguelySerious merged 3 commits into
mainfrom
copilot/process-import-specifier-optimization
Jul 24, 2026
Merged

Optimize processImportSpecifier by computing shouldFollowImportsFromFile once per file#3052
VaguelySerious merged 3 commits into
mainfrom
copilot/process-import-specifier-optimization

Conversation

CopilotAI commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Description

processImportSpecifier was calling shouldFollowImportsFromFile(filePath, forceFollowImports) once for every import specifier in a file, even though the result only depends on filePath and forceFollowImports. Hoist that evaluation into processFile and pass the boolean result down:

  • processFile now computes shouldFollow once before iterating specifiers.
  • processImportSpecifier now accepts a shouldFollow: boolean argument instead of forceFollowImports: boolean.
// BeforeawaitPromise.all(specifiers.map((specifier)=>processImportSpecifier(filePath,specifier,forceFollowImports)));// AfterconstshouldFollow=awaitshouldFollowImportsFromFile(filePath,forceFollowImports);// ...awaitPromise.all(specifiers.map((specifier)=>processImportSpecifier(filePath,specifier,shouldFollow)));

How did you test your changes?

  • Ran the @workflow/builders test suite (fast-discovery.test.ts and related files pass).
  • Verified the change with Biome lint/format on the modified file.

PR Checklist - Required to merge

  • 📦 pnpm changeset was run to create a changelog for this PR
    • Use the correct semver bump type: patch for bug fixes, minor for new features, major for breaking changes.
    • Use pnpm changeset --empty if you are changing documentation or workbench apps
  • 🔒 DCO sign-off passes (run git commit --signoff on your commits)
  • 📝 Ping @vercel/workflow in a comment once the PR is ready, and above checklist is complete

@vercel

vercelBot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

changeset-botBot commented Jul 22, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 10fad5b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
NameType
@workflow/buildersPatch
@workflow/astroPatch
@workflow/cliPatch
@workflow/nestPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/nuxtPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/vitestPatch
workflowPatch
@workflow/world-testingPatch
@workflow/corePatch
@workflow/web-sharedPatch
@workflow/webPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@shuding
shuding marked this pull request as ready for review July 22, 2026 15:16
@shuding
shuding requested review from a team and ijjk as code ownersJuly 22, 2026 15:16
@github-actions

github-actionsBot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production145502391694
✅ 💻 Local Development162102271848
✅ 📦 Local Production162102271848
✅ 🐘 Local Postgres162102271848
✅ 🪟 Windows15400154
✅ 📋 Other102002121232
✅ vercel-multi-region270027
Total7519011328651

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126028
✅ example126028
✅ express126028
✅ fastify126028
✅ hono126028
✅ nextjs-turbopack15103
✅ nextjs-webpack15103
✅ nitro126028
✅ nuxt126028
✅ sveltekit14509
✅ vite126028
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15400
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128026
✅ e2e-local-dev-tanstack-start-128026
✅ e2e-local-postgres-nest-stable128026
✅ e2e-local-postgres-tanstack-start-128026
✅ e2e-local-prod-nest-stable128026
✅ e2e-local-prod-tanstack-start-128026
✅ e2e-vercel-prod-nest126028
✅ e2e-vercel-prod-tanstack-start126028
✅ vercel-multi-region
AppPassedFailedSkipped
✅ nextjs-turbopack2700

📋 View full workflow run

@github-actions

github-actionsBot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 10fad5b · Thu, 23 Jul 2026 23:01:48 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep1319 (+32%) 🔻1415 🔴 (+29%) 🔻1497 🔴 (+34%) 🔻1866 🔴 (+10%)30
TTFSstream412 (+9.0%)1408 🔴 (+28%) 🔻1482 🔴 (+31%) 🔻1587 🔴 (+25%) 🔻30
TTFShook + stream1470 (+166%) 🔻1728 🔴 (+23%) 🔻1781 🔴 (+21%) 🔻1897 🔴 (+28%) 🔻30
STSO1020 steps (1-20)185 (+1.1%)294 🔴 (+6.9%)305 🔴 (+4.8%)331 🔴 (±0%)19
STSO1020 steps (101-120)198 (+3.1%)322 🔴 (+1.6%)567 🔴 (+21%) 🔻2199 🔴 (+248%) 🔻19
STSO1020 steps (1001-1020)483 (-4.2%)573 🔴 (-4.0%)599 🔴 (-9.1%)816 🔴 (+12%)19
WO1020 steps403452 (-3.3%)403452 (-3.3%)403452 (-3.3%)403452 (-3.3%)1
SLstream latency107 (+2.9%)157 🔴 (-0.6%)184 🔴 (-9.4%)263 🔴 (-32%) 💚30
📜 Previous results (1)

8c32b94

Wed, 22 Jul 2026 15:32:00 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep146 (+20%) 🔻415 🔴 (+73%) 🔻2121 🔴 (+553%) 🔻2620 🔴 (+508%) 🔻30
TTFSstream136 (-12%)304 🔴 (-10%)2368 🔴 (+542%) 🔻4518 🔴 (+876%) 🔻30
TTFShook + stream259 (-16%) 💚405 🔴 (-12%)511 🔴 (+0.6%)2710 🔴 (+336%) 🔻30
STSO1020 steps (1-20)170 (-11%)289 🔴 (-1.7%)331 🔴 (-1.8%)416 🔴 (+19%) 🔻19
STSO1020 steps (101-120)208 (-6.7%)323 🔴 (+0.6%)384 🔴 (-21%) 💚412 🔴 (-18%) 💚19
STSO1020 steps (1001-1020)513 (-15%) 💚667 🔴 (-15%)713 🔴 (-18%) 💚921 🔴 (-17%) 💚19
WO1020 steps441418 (-17%) 💚441418 (-17%) 💚441418 (-17%) 💚441418 (-17%) 💚1
SLstream latency86 (-4.4%)142 🔴 (-5.3%)226 🔴 (+25%) 🔻402 🔴 (+76%) 🔻30

Best/P75/P90/P99 deltas compare against the most recent benchmark run on main at the time of this run. 🔻 flags a delta worse than +15%, 💚 one better than −15%.

Metrics — TTFS: time to first step body (in-deployment start() → first step body, deployment clocks) · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (whole-run time outside step bodies, in-deployment anchored) · SL: stream latency (in-deployment write → read propagation, readAt - writtenAt)

Scenarios — step: one trivial no-op step, no stream; no hooks, so the run stays in turbo mode (in-process fast path) · stream: one streaming step; no hooks, so the run stays in turbo mode (in-process fast path) · hook + stream: registers a hook before one step, which exits turbo mode (dispatch path) · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges, and WO is the whole-run overhead outside step bodies · stream latency: parallel reader/writer steps on a dedicated stream; SL is the in-deployment write->read propagation (readAt - writtenAt)

🔴 marks a percentile over its target (within target is left unmarked). Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

All metrics are measured from deployment-side timestamps only. Runs are triggered by an in-deployment route that stamps the anchor (clientStart) right before start(), so the CI runner’s request and its path through api.vercel.com sit outside every measured window. TTFS = in-deployment start() → first step body (turbo uses the in-process fast path, non-turbo the dispatch path), and includes the VQS dispatch hop plus any /flow cold start. STSO/WO are measured between step bodies on the deployment. SL is measured inside the workflow (parallel reader/writer steps), so it no longer includes the api.vercel.com read path.

Cold starts are kept in the numbers on purpose — they are part of real bursty-workload latency. The workbench deployment cold-starts the /flow invocation for a large fraction of runs, inflating P75+; the Best column shows the fastest (warm-start) sample for comparison.

@VaguelySerious
VaguelySerious enabled auto-merge (squash) July 23, 2026 23:54
@VaguelySerious
VaguelySerious merged commit b406a04 into mainJul 24, 2026
243 of 248 checks passed
@VaguelySerious
VaguelySerious deleted the copilot/process-import-specifier-optimization branch July 24, 2026 18:29
github-actionsBot added a commit that referenced this pull request Jul 24, 2026
…omFile` once per file (#3052)
Signed-off-by: Copilot <198982749+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Backport PR opened against stable: #3086. (backport job run)

pranaygp added a commit that referenced this pull request Jul 28, 2026
…ry-2
* origin/main: (292 commits)
feat(core): seal forwarded stream writes to the owner's public key (#3098)
feat(core): seal hook payloads to the target run's public key (#3096)
[e2e] Rebuild the event-log corruption repro around step-count divergence (#3147)
feat: decrypt sealed payloads in the dashboard and CLI (#3146)
Prewarm only appended replay payloads (#3131)
feat: publish each run's X25519 public key on the run entity (#3095)
feat(core): route sealed envelopes through the serialization layer (#3094)
docs: redirect retired migration-guides URLs to comparisons (#3127)
feat(core): add `encp` sealed-box encryption primitive (#3093)
chore(core): clarify runtime comments (#3111)
Remove obsolete world factory aliases (#3112)
feat(core): deterministic sandbox hardening (#3045)
Remove retired v1 step route plumbing (#3061)
[core] Don't count racing invocations' duplicate step_started events toward the maxRetries ceiling (#3069)
[world-testing] Isolate each spawned test server's data directory (#3055)
fix: upgrade postcss to >=8.5.18 to address GHSA-r28c-9q8g-f849 (#3102)
[next] Respect .gitignore in dev watcher to avoid EMFILE on large monorepos (#3085)
[ci] Backport only stability fixes to `stable`, default to claude-opus-5 (#3092)
perf(core): immediate leading-edge dispatch for idle streams (flush window default 0) (#3088)
Optimize `processImportSpecifier` by computing `shouldFollowImportsFromFile` once per file (#3052)
...
# Conflicts:
#	docs/components/geistdocs/desktop-menu.tsx
#	docs/components/geistdocs/mobile-menu.tsx
#	docs/content/docs/v5/cookbook/advanced/child-workflows.mdx
#	docs/content/docs/v5/cookbook/advanced/upgrading-workflows.mdx
#	docs/content/docs/v5/cookbook/agent-patterns/agent-cancellation.mdx
#	docs/content/docs/v5/cookbook/agent-patterns/durable-agent.mdx
#	docs/content/docs/v5/cookbook/agent-patterns/human-in-the-loop.mdx
#	docs/content/docs/v5/cookbook/common-patterns/batching.mdx
#	docs/content/docs/v5/cookbook/common-patterns/idempotency.mdx
#	docs/content/docs/v5/cookbook/common-patterns/rate-limiting.mdx
#	docs/content/docs/v5/cookbook/common-patterns/saga.mdx
#	docs/content/docs/v5/cookbook/common-patterns/scheduling.mdx
#	docs/content/docs/v5/cookbook/common-patterns/sequential-and-parallel.mdx
#	docs/content/docs/v5/cookbook/common-patterns/timeouts.mdx
#	docs/content/docs/v5/cookbook/common-patterns/webhooks.mdx
#	docs/content/docs/v5/cookbook/common-patterns/workflow-composition.mdx
#	docs/content/docs/v5/cookbook/index.mdx
#	docs/content/docs/v5/cookbook/integrations/ai-sdk.mdx
#	docs/content/docs/v5/cookbook/integrations/chat-sdk.mdx
#	docs/content/docs/v5/cookbook/integrations/sandbox.mdx
#	docs/next.config.ts
#	docs/proxy.ts
#	docs/scripts/lint.ts
#	pnpm-lock.yaml
#	pnpm-workspace.yaml
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@VaguelySerious@shuding