Implement step sourcemaps - #310

Closed
pranaygp wants to merge 4 commits into
mainfrom
pranaygp/11-12-implement_step_sourcemaps
Closed

Implement step sourcemaps#310
pranaygp wants to merge 4 commits into
mainfrom
pranaygp/11-12-implement_step_sourcemaps

Conversation

@pranaygp

@pranaygppranaygp commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

=== TEST 1: crossFileErrorWorkflow (Workflow Error in VM Context) ===

Starting "crossFileErrorWorkflow" workflow with args:
Error while running "wrun_01K9VGB8JZCJYY0KC7VGTWH8KS" workflow:
Error: Error from workflow helper
at throwWorkflowError (../example/workflows/98_workflow_error_test.ts:4:10)
at workflowErrorHelper (../example/workflows/98_workflow_error_test.ts:7:4)
at crossFileErrorWorkflow (../example/workflows/99_e2e.ts:290:4)
at \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/workflow.ts:574:7)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:94:22)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:362:28)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:94:22)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:57:58)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:280:14)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/world-local/src/queue.ts:148:24)

Call chain (Workflow VM context):
throwWorkflowError (98_workflow_error_test.ts:4)

workflowErrorHelper (98_workflow_error_test.ts:7)

crossFileErrorWorkflow (99_e2e.ts:290)

=== TEST 2: deepStepErrorWorkflow (Step Error in Node.js Context) ===

Starting "deepStepErrorWorkflow" workflow with args:
[Workflows] "wrun_01K9VGBX3N34GG0SP36DC5156E" - Encountered `FatalError` while executing step "step//example/workflows/98_step_error_test.ts//deepStepWithNestedError":
> FatalError: Error from step helper
> at throwStepError (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:7:11)
> at stepErrorHelper (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:10:5)
> at deepStepWithNestedError (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:13:5)
Bubbling up error to parent workflow
FatalError while running "wrun_01K9VGBX3N34GG0SP36DC5156E" workflow:
FatalError: Error from step helper
at throwStepError (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:7:11)
at stepErrorHelper (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:10:5)
at deepStepWithNestedError (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:13:5)
at \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:698:21)
at AsyncLocalStorage.run (node:internal/async_local_storage/async_hooks:91:14)
at \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:680:43)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:94:22)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:57:58)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:576:14)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/world-local/src/queue.ts:148:24)

Call chain (Step Node.js context):
throwStepError (98_step_error_test.ts:7)

stepErrorHelper (98_step_error_test.ts:10)

deepStepWithNestedError (98_step_error_test.ts:13) [STEP FUNCTION]

[Error preserved and propagated to workflow context]

=== KEY OBSERVATIONS ===

  1. WORKFLOW ERROR (Test 1):
    • Error thrown in workflow VM context
    • Stack trace shows: 98_workflow_error_test.ts → 99_e2e.ts
    • Inline sourcemaps in workflow bundle enable proper file/line references
  2. STEP ERROR (Test 2):
    • Error thrown in step Node.js context
    • Stack trace shows full call chain within the step: 98_step_error_test.ts lines 7→10→13
    • Inline sourcemaps in step bundle enable proper file/line references
    • Stack trace PRESERVED when error bubbles up to workflow (fix in step.ts:94-100)
  3. SOURCEMAP CONFIGURATION:
    • Workflow bundle: sourcemap: 'inline' (base-builder.ts:481)
    • Step bundle: sourcemap: 'inline' (base-builder.ts:355)
    • Node.js runtime: NODE_OPTIONS="--enable-source-maps"

@vercel

vercelBot commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentPreviewCommentsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreviewCommentNov 12, 2025 11:59pm
example-nextjs-workflow-webpackReadyReadyPreviewCommentNov 12, 2025 11:59pm
example-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-hono-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-nitro-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-nuxt-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-sveltekit-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-vite-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workflow-docsReadyReadyPreviewCommentNov 12, 2025 11:59pm

@changeset-bot

changeset-botBot commented Nov 12, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8fd157d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
NameType
@workflow/buildersPatch
@workflow/corePatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/sveltekitPatch
@workflow/web-sharedPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/aiPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pranaygpGraphite App

pranaygp commented Nov 12, 2025

Copy link
Copy Markdown
ContributorAuthor

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

pranaygpand others added 4 commits November 12, 2025 18:56
Normalize trigger scripts across workbenches
fix: include hono in local build test
test: include src dir for test
test: add workflow dir config in test to fix sveltekit dev tests
add temp 7_full in example wokrflow
format
fix(sveltekit): detecting workflow folders and customizable dir
Remove 7_full and 1_simple error
replace API symlink in webpack workbench
Fix sveltekit and vite tests
Fix sveltekit symlinks
Test fixes
Fix sveltekit workflows path
Dont symlink routes in vite
Include e2e tests for hono and vite
fix error tests post normalization
wip - attempted fixes
* Proper stacktrace propogation in world
Proper stacktrace propogation in world
* Standardize the error type in the world spec
* Normalize Workbenches
Normalize trigger scripts across workbenches
fix: include hono in local build test
test: include src dir for test
test: add workflow dir config in test to fix sveltekit dev tests
add temp 7_full in example wokrflow
format
fix(sveltekit): detecting workflow folders and customizable dir
Remove 7_full and 1_simple error
replace API symlink in webpack workbench
Fix sveltekit and vite tests
Fix sveltekit symlinks
Test fixes
Fix sveltekit workflows path
Dont symlink routes in vite
Include e2e tests for hono and vite
* fix error tests post normalization
* fix(sveltekit): reading file on hmr delete
* changeset
* fix(vite): add resolve symlink script
* fix(vite): missing building on hmr
* test local builder in vite
* test: increase timeout on hookWorkflow
* test: ignore vite based apps in crossFileWorkflow
* test: fix nitro based apps status codes
* fix: intercept default vite spa handler on 404 workflow routes
* fix: vite hook route returning 422
* test: use 422 for hookWorkflow expected
* test: fix hono returning 404
* chore: add comment to middleware to clarify
* make api route for duplicate case
* revert
* revert: nitro builder
* add back nitro unhandled rejection logic
* test: add hono
* changeset
* fix: unused method
* fix: remove duplicate import
* remove
* chore: add comments to clarify
* test remove vite symlink script
---------
Co-authored-by: Pranay Prakash <pranay.gp@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@pranaygp@adriandlam
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Implement step sourcemaps - #310

Closed
pranaygp wants to merge 4 commits into
mainfrom
pranaygp/11-12-implement_step_sourcemaps
Closed

Implement step sourcemaps#310
pranaygp wants to merge 4 commits into
mainfrom
pranaygp/11-12-implement_step_sourcemaps

Conversation

@pranaygp

@pranaygppranaygp commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

=== TEST 1: crossFileErrorWorkflow (Workflow Error in VM Context) ===

Starting "crossFileErrorWorkflow" workflow with args:
Error while running "wrun_01K9VGB8JZCJYY0KC7VGTWH8KS" workflow:
Error: Error from workflow helper
at throwWorkflowError (../example/workflows/98_workflow_error_test.ts:4:10)
at workflowErrorHelper (../example/workflows/98_workflow_error_test.ts:7:4)
at crossFileErrorWorkflow (../example/workflows/99_e2e.ts:290:4)
at \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/workflow.ts:574:7)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:94:22)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:362:28)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:94:22)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:57:58)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:280:14)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/world-local/src/queue.ts:148:24)

Call chain (Workflow VM context):
throwWorkflowError (98_workflow_error_test.ts:4)

workflowErrorHelper (98_workflow_error_test.ts:7)

crossFileErrorWorkflow (99_e2e.ts:290)

=== TEST 2: deepStepErrorWorkflow (Step Error in Node.js Context) ===

Starting "deepStepErrorWorkflow" workflow with args:
[Workflows] "wrun_01K9VGBX3N34GG0SP36DC5156E" - Encountered `FatalError` while executing step "step//example/workflows/98_step_error_test.ts//deepStepWithNestedError":
> FatalError: Error from step helper
> at throwStepError (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:7:11)
> at stepErrorHelper (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:10:5)
> at deepStepWithNestedError (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:13:5)
Bubbling up error to parent workflow
FatalError while running "wrun_01K9VGBX3N34GG0SP36DC5156E" workflow:
FatalError: Error from step helper
at throwStepError (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:7:11)
at stepErrorHelper (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:10:5)
at deepStepWithNestedError (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:13:5)
at \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:698:21)
at AsyncLocalStorage.run (node:internal/async_local_storage/async_hooks:91:14)
at \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:680:43)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:94:22)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:57:58)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:576:14)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/world-local/src/queue.ts:148:24)

Call chain (Step Node.js context):
throwStepError (98_step_error_test.ts:7)

stepErrorHelper (98_step_error_test.ts:10)

deepStepWithNestedError (98_step_error_test.ts:13) [STEP FUNCTION]

[Error preserved and propagated to workflow context]

=== KEY OBSERVATIONS ===

  1. WORKFLOW ERROR (Test 1):
    • Error thrown in workflow VM context
    • Stack trace shows: 98_workflow_error_test.ts → 99_e2e.ts
    • Inline sourcemaps in workflow bundle enable proper file/line references
  2. STEP ERROR (Test 2):
    • Error thrown in step Node.js context
    • Stack trace shows full call chain within the step: 98_step_error_test.ts lines 7→10→13
    • Inline sourcemaps in step bundle enable proper file/line references
    • Stack trace PRESERVED when error bubbles up to workflow (fix in step.ts:94-100)
  3. SOURCEMAP CONFIGURATION:
    • Workflow bundle: sourcemap: 'inline' (base-builder.ts:481)
    • Step bundle: sourcemap: 'inline' (base-builder.ts:355)
    • Node.js runtime: NODE_OPTIONS="--enable-source-maps"

@vercel

vercelBot commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentPreviewCommentsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreviewCommentNov 12, 2025 11:59pm
example-nextjs-workflow-webpackReadyReadyPreviewCommentNov 12, 2025 11:59pm
example-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-hono-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-nitro-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-nuxt-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-sveltekit-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-vite-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workflow-docsReadyReadyPreviewCommentNov 12, 2025 11:59pm

@changeset-bot

changeset-botBot commented Nov 12, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8fd157d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
NameType
@workflow/buildersPatch
@workflow/corePatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/sveltekitPatch
@workflow/web-sharedPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/aiPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pranaygpGraphite App

pranaygp commented Nov 12, 2025

Copy link
Copy Markdown
ContributorAuthor

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

pranaygpand others added 4 commits November 12, 2025 18:56
Normalize trigger scripts across workbenches
fix: include hono in local build test
test: include src dir for test
test: add workflow dir config in test to fix sveltekit dev tests
add temp 7_full in example wokrflow
format
fix(sveltekit): detecting workflow folders and customizable dir
Remove 7_full and 1_simple error
replace API symlink in webpack workbench
Fix sveltekit and vite tests
Fix sveltekit symlinks
Test fixes
Fix sveltekit workflows path
Dont symlink routes in vite
Include e2e tests for hono and vite
fix error tests post normalization
wip - attempted fixes
* Proper stacktrace propogation in world
Proper stacktrace propogation in world
* Standardize the error type in the world spec
* Normalize Workbenches
Normalize trigger scripts across workbenches
fix: include hono in local build test
test: include src dir for test
test: add workflow dir config in test to fix sveltekit dev tests
add temp 7_full in example wokrflow
format
fix(sveltekit): detecting workflow folders and customizable dir
Remove 7_full and 1_simple error
replace API symlink in webpack workbench
Fix sveltekit and vite tests
Fix sveltekit symlinks
Test fixes
Fix sveltekit workflows path
Dont symlink routes in vite
Include e2e tests for hono and vite
* fix error tests post normalization
* fix(sveltekit): reading file on hmr delete
* changeset
* fix(vite): add resolve symlink script
* fix(vite): missing building on hmr
* test local builder in vite
* test: increase timeout on hookWorkflow
* test: ignore vite based apps in crossFileWorkflow
* test: fix nitro based apps status codes
* fix: intercept default vite spa handler on 404 workflow routes
* fix: vite hook route returning 422
* test: use 422 for hookWorkflow expected
* test: fix hono returning 404
* chore: add comment to middleware to clarify
* make api route for duplicate case
* revert
* revert: nitro builder
* add back nitro unhandled rejection logic
* test: add hono
* changeset
* fix: unused method
* fix: remove duplicate import
* remove
* chore: add comments to clarify
* test remove vite symlink script
---------
Co-authored-by: Pranay Prakash <pranay.gp@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@pranaygp@adriandlam
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Implement step sourcemaps - #310

Closed
pranaygp wants to merge 4 commits into
mainfrom
pranaygp/11-12-implement_step_sourcemaps
Closed

Implement step sourcemaps#310
pranaygp wants to merge 4 commits into
mainfrom
pranaygp/11-12-implement_step_sourcemaps

Conversation

@pranaygp

@pranaygppranaygp commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

=== TEST 1: crossFileErrorWorkflow (Workflow Error in VM Context) ===

Starting "crossFileErrorWorkflow" workflow with args:
Error while running "wrun_01K9VGB8JZCJYY0KC7VGTWH8KS" workflow:
Error: Error from workflow helper
at throwWorkflowError (../example/workflows/98_workflow_error_test.ts:4:10)
at workflowErrorHelper (../example/workflows/98_workflow_error_test.ts:7:4)
at crossFileErrorWorkflow (../example/workflows/99_e2e.ts:290:4)
at \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/workflow.ts:574:7)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:94:22)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:362:28)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:94:22)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:57:58)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:280:14)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/world-local/src/queue.ts:148:24)

Call chain (Workflow VM context):
throwWorkflowError (98_workflow_error_test.ts:4)

workflowErrorHelper (98_workflow_error_test.ts:7)

crossFileErrorWorkflow (99_e2e.ts:290)

=== TEST 2: deepStepErrorWorkflow (Step Error in Node.js Context) ===

Starting "deepStepErrorWorkflow" workflow with args:
[Workflows] "wrun_01K9VGBX3N34GG0SP36DC5156E" - Encountered `FatalError` while executing step "step//example/workflows/98_step_error_test.ts//deepStepWithNestedError":
> FatalError: Error from step helper
> at throwStepError (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:7:11)
> at stepErrorHelper (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:10:5)
> at deepStepWithNestedError (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:13:5)
Bubbling up error to parent workflow
FatalError while running "wrun_01K9VGBX3N34GG0SP36DC5156E" workflow:
FatalError: Error from step helper
at throwStepError (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:7:11)
at stepErrorHelper (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:10:5)
at deepStepWithNestedError (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:13:5)
at \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:698:21)
at AsyncLocalStorage.run (node:internal/async_local_storage/async_hooks:91:14)
at \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:680:43)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:94:22)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:57:58)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:576:14)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/world-local/src/queue.ts:148:24)

Call chain (Step Node.js context):
throwStepError (98_step_error_test.ts:7)

stepErrorHelper (98_step_error_test.ts:10)

deepStepWithNestedError (98_step_error_test.ts:13) [STEP FUNCTION]

[Error preserved and propagated to workflow context]

=== KEY OBSERVATIONS ===

  1. WORKFLOW ERROR (Test 1):
    • Error thrown in workflow VM context
    • Stack trace shows: 98_workflow_error_test.ts → 99_e2e.ts
    • Inline sourcemaps in workflow bundle enable proper file/line references
  2. STEP ERROR (Test 2):
    • Error thrown in step Node.js context
    • Stack trace shows full call chain within the step: 98_step_error_test.ts lines 7→10→13
    • Inline sourcemaps in step bundle enable proper file/line references
    • Stack trace PRESERVED when error bubbles up to workflow (fix in step.ts:94-100)
  3. SOURCEMAP CONFIGURATION:
    • Workflow bundle: sourcemap: 'inline' (base-builder.ts:481)
    • Step bundle: sourcemap: 'inline' (base-builder.ts:355)
    • Node.js runtime: NODE_OPTIONS="--enable-source-maps"

@vercel

vercelBot commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentPreviewCommentsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreviewCommentNov 12, 2025 11:59pm
example-nextjs-workflow-webpackReadyReadyPreviewCommentNov 12, 2025 11:59pm
example-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-hono-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-nitro-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-nuxt-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-sveltekit-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-vite-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workflow-docsReadyReadyPreviewCommentNov 12, 2025 11:59pm

@changeset-bot

changeset-botBot commented Nov 12, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8fd157d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
NameType
@workflow/buildersPatch
@workflow/corePatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/sveltekitPatch
@workflow/web-sharedPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/aiPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pranaygpGraphite App

pranaygp commented Nov 12, 2025

Copy link
Copy Markdown
ContributorAuthor

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

pranaygpand others added 4 commits November 12, 2025 18:56
Normalize trigger scripts across workbenches
fix: include hono in local build test
test: include src dir for test
test: add workflow dir config in test to fix sveltekit dev tests
add temp 7_full in example wokrflow
format
fix(sveltekit): detecting workflow folders and customizable dir
Remove 7_full and 1_simple error
replace API symlink in webpack workbench
Fix sveltekit and vite tests
Fix sveltekit symlinks
Test fixes
Fix sveltekit workflows path
Dont symlink routes in vite
Include e2e tests for hono and vite
fix error tests post normalization
wip - attempted fixes
* Proper stacktrace propogation in world
Proper stacktrace propogation in world
* Standardize the error type in the world spec
* Normalize Workbenches
Normalize trigger scripts across workbenches
fix: include hono in local build test
test: include src dir for test
test: add workflow dir config in test to fix sveltekit dev tests
add temp 7_full in example wokrflow
format
fix(sveltekit): detecting workflow folders and customizable dir
Remove 7_full and 1_simple error
replace API symlink in webpack workbench
Fix sveltekit and vite tests
Fix sveltekit symlinks
Test fixes
Fix sveltekit workflows path
Dont symlink routes in vite
Include e2e tests for hono and vite
* fix error tests post normalization
* fix(sveltekit): reading file on hmr delete
* changeset
* fix(vite): add resolve symlink script
* fix(vite): missing building on hmr
* test local builder in vite
* test: increase timeout on hookWorkflow
* test: ignore vite based apps in crossFileWorkflow
* test: fix nitro based apps status codes
* fix: intercept default vite spa handler on 404 workflow routes
* fix: vite hook route returning 422
* test: use 422 for hookWorkflow expected
* test: fix hono returning 404
* chore: add comment to middleware to clarify
* make api route for duplicate case
* revert
* revert: nitro builder
* add back nitro unhandled rejection logic
* test: add hono
* changeset
* fix: unused method
* fix: remove duplicate import
* remove
* chore: add comments to clarify
* test remove vite symlink script
---------
Co-authored-by: Pranay Prakash <pranay.gp@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@pranaygp@adriandlam
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Implement step sourcemaps - #310

Closed
pranaygp wants to merge 4 commits into
mainfrom
pranaygp/11-12-implement_step_sourcemaps
Closed

Implement step sourcemaps#310
pranaygp wants to merge 4 commits into
mainfrom
pranaygp/11-12-implement_step_sourcemaps

Conversation

@pranaygp

@pranaygppranaygp commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

=== TEST 1: crossFileErrorWorkflow (Workflow Error in VM Context) ===

Starting "crossFileErrorWorkflow" workflow with args:
Error while running "wrun_01K9VGB8JZCJYY0KC7VGTWH8KS" workflow:
Error: Error from workflow helper
at throwWorkflowError (../example/workflows/98_workflow_error_test.ts:4:10)
at workflowErrorHelper (../example/workflows/98_workflow_error_test.ts:7:4)
at crossFileErrorWorkflow (../example/workflows/99_e2e.ts:290:4)
at \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/workflow.ts:574:7)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:94:22)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:362:28)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:94:22)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:57:58)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:280:14)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/world-local/src/queue.ts:148:24)

Call chain (Workflow VM context):
throwWorkflowError (98_workflow_error_test.ts:4)

workflowErrorHelper (98_workflow_error_test.ts:7)

crossFileErrorWorkflow (99_e2e.ts:290)

=== TEST 2: deepStepErrorWorkflow (Step Error in Node.js Context) ===

Starting "deepStepErrorWorkflow" workflow with args:
[Workflows] "wrun_01K9VGBX3N34GG0SP36DC5156E" - Encountered `FatalError` while executing step "step//example/workflows/98_step_error_test.ts//deepStepWithNestedError":
> FatalError: Error from step helper
> at throwStepError (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:7:11)
> at stepErrorHelper (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:10:5)
> at deepStepWithNestedError (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:13:5)
Bubbling up error to parent workflow
FatalError while running "wrun_01K9VGBX3N34GG0SP36DC5156E" workflow:
FatalError: Error from step helper
at throwStepError (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:7:11)
at stepErrorHelper (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:10:5)
at deepStepWithNestedError (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:13:5)
at \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:698:21)
at AsyncLocalStorage.run (node:internal/async_local_storage/async_hooks:91:14)
at \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:680:43)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:94:22)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:57:58)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:576:14)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/world-local/src/queue.ts:148:24)

Call chain (Step Node.js context):
throwStepError (98_step_error_test.ts:7)

stepErrorHelper (98_step_error_test.ts:10)

deepStepWithNestedError (98_step_error_test.ts:13) [STEP FUNCTION]

[Error preserved and propagated to workflow context]

=== KEY OBSERVATIONS ===

  1. WORKFLOW ERROR (Test 1):
    • Error thrown in workflow VM context
    • Stack trace shows: 98_workflow_error_test.ts → 99_e2e.ts
    • Inline sourcemaps in workflow bundle enable proper file/line references
  2. STEP ERROR (Test 2):
    • Error thrown in step Node.js context
    • Stack trace shows full call chain within the step: 98_step_error_test.ts lines 7→10→13
    • Inline sourcemaps in step bundle enable proper file/line references
    • Stack trace PRESERVED when error bubbles up to workflow (fix in step.ts:94-100)
  3. SOURCEMAP CONFIGURATION:
    • Workflow bundle: sourcemap: 'inline' (base-builder.ts:481)
    • Step bundle: sourcemap: 'inline' (base-builder.ts:355)
    • Node.js runtime: NODE_OPTIONS="--enable-source-maps"

@vercel

vercelBot commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentPreviewCommentsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreviewCommentNov 12, 2025 11:59pm
example-nextjs-workflow-webpackReadyReadyPreviewCommentNov 12, 2025 11:59pm
example-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-hono-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-nitro-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-nuxt-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-sveltekit-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-vite-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workflow-docsReadyReadyPreviewCommentNov 12, 2025 11:59pm

@changeset-bot

changeset-botBot commented Nov 12, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8fd157d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
NameType
@workflow/buildersPatch
@workflow/corePatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/sveltekitPatch
@workflow/web-sharedPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/aiPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pranaygpGraphite App

pranaygp commented Nov 12, 2025

Copy link
Copy Markdown
ContributorAuthor

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

pranaygpand others added 4 commits November 12, 2025 18:56
Normalize trigger scripts across workbenches
fix: include hono in local build test
test: include src dir for test
test: add workflow dir config in test to fix sveltekit dev tests
add temp 7_full in example wokrflow
format
fix(sveltekit): detecting workflow folders and customizable dir
Remove 7_full and 1_simple error
replace API symlink in webpack workbench
Fix sveltekit and vite tests
Fix sveltekit symlinks
Test fixes
Fix sveltekit workflows path
Dont symlink routes in vite
Include e2e tests for hono and vite
fix error tests post normalization
wip - attempted fixes
* Proper stacktrace propogation in world
Proper stacktrace propogation in world
* Standardize the error type in the world spec
* Normalize Workbenches
Normalize trigger scripts across workbenches
fix: include hono in local build test
test: include src dir for test
test: add workflow dir config in test to fix sveltekit dev tests
add temp 7_full in example wokrflow
format
fix(sveltekit): detecting workflow folders and customizable dir
Remove 7_full and 1_simple error
replace API symlink in webpack workbench
Fix sveltekit and vite tests
Fix sveltekit symlinks
Test fixes
Fix sveltekit workflows path
Dont symlink routes in vite
Include e2e tests for hono and vite
* fix error tests post normalization
* fix(sveltekit): reading file on hmr delete
* changeset
* fix(vite): add resolve symlink script
* fix(vite): missing building on hmr
* test local builder in vite
* test: increase timeout on hookWorkflow
* test: ignore vite based apps in crossFileWorkflow
* test: fix nitro based apps status codes
* fix: intercept default vite spa handler on 404 workflow routes
* fix: vite hook route returning 422
* test: use 422 for hookWorkflow expected
* test: fix hono returning 404
* chore: add comment to middleware to clarify
* make api route for duplicate case
* revert
* revert: nitro builder
* add back nitro unhandled rejection logic
* test: add hono
* changeset
* fix: unused method
* fix: remove duplicate import
* remove
* chore: add comments to clarify
* test remove vite symlink script
---------
Co-authored-by: Pranay Prakash <pranay.gp@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@pranaygp@adriandlam
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Implement step sourcemaps - #310

Closed
pranaygp wants to merge 4 commits into
mainfrom
pranaygp/11-12-implement_step_sourcemaps
Closed

Implement step sourcemaps#310
pranaygp wants to merge 4 commits into
mainfrom
pranaygp/11-12-implement_step_sourcemaps

Conversation

@pranaygp

@pranaygppranaygp commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

=== TEST 1: crossFileErrorWorkflow (Workflow Error in VM Context) ===

Starting "crossFileErrorWorkflow" workflow with args:
Error while running "wrun_01K9VGB8JZCJYY0KC7VGTWH8KS" workflow:
Error: Error from workflow helper
at throwWorkflowError (../example/workflows/98_workflow_error_test.ts:4:10)
at workflowErrorHelper (../example/workflows/98_workflow_error_test.ts:7:4)
at crossFileErrorWorkflow (../example/workflows/99_e2e.ts:290:4)
at \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/workflow.ts:574:7)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:94:22)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:362:28)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:94:22)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:57:58)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:280:14)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/world-local/src/queue.ts:148:24)

Call chain (Workflow VM context):
throwWorkflowError (98_workflow_error_test.ts:4)

workflowErrorHelper (98_workflow_error_test.ts:7)

crossFileErrorWorkflow (99_e2e.ts:290)

=== TEST 2: deepStepErrorWorkflow (Step Error in Node.js Context) ===

Starting "deepStepErrorWorkflow" workflow with args:
[Workflows] "wrun_01K9VGBX3N34GG0SP36DC5156E" - Encountered `FatalError` while executing step "step//example/workflows/98_step_error_test.ts//deepStepWithNestedError":
> FatalError: Error from step helper
> at throwStepError (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:7:11)
> at stepErrorHelper (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:10:5)
> at deepStepWithNestedError (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:13:5)
Bubbling up error to parent workflow
FatalError while running "wrun_01K9VGBX3N34GG0SP36DC5156E" workflow:
FatalError: Error from step helper
at throwStepError (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:7:11)
at stepErrorHelper (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:10:5)
at deepStepWithNestedError (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:13:5)
at \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:698:21)
at AsyncLocalStorage.run (node:internal/async_local_storage/async_hooks:91:14)
at \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:680:43)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:94:22)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:57:58)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:576:14)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/world-local/src/queue.ts:148:24)

Call chain (Step Node.js context):
throwStepError (98_step_error_test.ts:7)

stepErrorHelper (98_step_error_test.ts:10)

deepStepWithNestedError (98_step_error_test.ts:13) [STEP FUNCTION]

[Error preserved and propagated to workflow context]

=== KEY OBSERVATIONS ===

  1. WORKFLOW ERROR (Test 1):
    • Error thrown in workflow VM context
    • Stack trace shows: 98_workflow_error_test.ts → 99_e2e.ts
    • Inline sourcemaps in workflow bundle enable proper file/line references
  2. STEP ERROR (Test 2):
    • Error thrown in step Node.js context
    • Stack trace shows full call chain within the step: 98_step_error_test.ts lines 7→10→13
    • Inline sourcemaps in step bundle enable proper file/line references
    • Stack trace PRESERVED when error bubbles up to workflow (fix in step.ts:94-100)
  3. SOURCEMAP CONFIGURATION:
    • Workflow bundle: sourcemap: 'inline' (base-builder.ts:481)
    • Step bundle: sourcemap: 'inline' (base-builder.ts:355)
    • Node.js runtime: NODE_OPTIONS="--enable-source-maps"

@vercel

vercelBot commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentPreviewCommentsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreviewCommentNov 12, 2025 11:59pm
example-nextjs-workflow-webpackReadyReadyPreviewCommentNov 12, 2025 11:59pm
example-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-hono-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-nitro-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-nuxt-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-sveltekit-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-vite-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workflow-docsReadyReadyPreviewCommentNov 12, 2025 11:59pm

@changeset-bot

changeset-botBot commented Nov 12, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8fd157d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
NameType
@workflow/buildersPatch
@workflow/corePatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/sveltekitPatch
@workflow/web-sharedPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/aiPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pranaygpGraphite App

pranaygp commented Nov 12, 2025

Copy link
Copy Markdown
ContributorAuthor

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

pranaygpand others added 4 commits November 12, 2025 18:56
Normalize trigger scripts across workbenches
fix: include hono in local build test
test: include src dir for test
test: add workflow dir config in test to fix sveltekit dev tests
add temp 7_full in example wokrflow
format
fix(sveltekit): detecting workflow folders and customizable dir
Remove 7_full and 1_simple error
replace API symlink in webpack workbench
Fix sveltekit and vite tests
Fix sveltekit symlinks
Test fixes
Fix sveltekit workflows path
Dont symlink routes in vite
Include e2e tests for hono and vite
fix error tests post normalization
wip - attempted fixes
* Proper stacktrace propogation in world
Proper stacktrace propogation in world
* Standardize the error type in the world spec
* Normalize Workbenches
Normalize trigger scripts across workbenches
fix: include hono in local build test
test: include src dir for test
test: add workflow dir config in test to fix sveltekit dev tests
add temp 7_full in example wokrflow
format
fix(sveltekit): detecting workflow folders and customizable dir
Remove 7_full and 1_simple error
replace API symlink in webpack workbench
Fix sveltekit and vite tests
Fix sveltekit symlinks
Test fixes
Fix sveltekit workflows path
Dont symlink routes in vite
Include e2e tests for hono and vite
* fix error tests post normalization
* fix(sveltekit): reading file on hmr delete
* changeset
* fix(vite): add resolve symlink script
* fix(vite): missing building on hmr
* test local builder in vite
* test: increase timeout on hookWorkflow
* test: ignore vite based apps in crossFileWorkflow
* test: fix nitro based apps status codes
* fix: intercept default vite spa handler on 404 workflow routes
* fix: vite hook route returning 422
* test: use 422 for hookWorkflow expected
* test: fix hono returning 404
* chore: add comment to middleware to clarify
* make api route for duplicate case
* revert
* revert: nitro builder
* add back nitro unhandled rejection logic
* test: add hono
* changeset
* fix: unused method
* fix: remove duplicate import
* remove
* chore: add comments to clarify
* test remove vite symlink script
---------
Co-authored-by: Pranay Prakash <pranay.gp@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@pranaygp@adriandlam
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Implement step sourcemaps - #310

Closed
pranaygp wants to merge 4 commits into
mainfrom
pranaygp/11-12-implement_step_sourcemaps
Closed

Implement step sourcemaps#310
pranaygp wants to merge 4 commits into
mainfrom
pranaygp/11-12-implement_step_sourcemaps

Conversation

@pranaygp

@pranaygppranaygp commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

=== TEST 1: crossFileErrorWorkflow (Workflow Error in VM Context) ===

Starting "crossFileErrorWorkflow" workflow with args:
Error while running "wrun_01K9VGB8JZCJYY0KC7VGTWH8KS" workflow:
Error: Error from workflow helper
at throwWorkflowError (../example/workflows/98_workflow_error_test.ts:4:10)
at workflowErrorHelper (../example/workflows/98_workflow_error_test.ts:7:4)
at crossFileErrorWorkflow (../example/workflows/99_e2e.ts:290:4)
at \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/workflow.ts:574:7)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:94:22)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:362:28)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:94:22)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:57:58)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:280:14)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/world-local/src/queue.ts:148:24)

Call chain (Workflow VM context):
throwWorkflowError (98_workflow_error_test.ts:4)

workflowErrorHelper (98_workflow_error_test.ts:7)

crossFileErrorWorkflow (99_e2e.ts:290)

=== TEST 2: deepStepErrorWorkflow (Step Error in Node.js Context) ===

Starting "deepStepErrorWorkflow" workflow with args:
[Workflows] "wrun_01K9VGBX3N34GG0SP36DC5156E" - Encountered `FatalError` while executing step "step//example/workflows/98_step_error_test.ts//deepStepWithNestedError":
> FatalError: Error from step helper
> at throwStepError (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:7:11)
> at stepErrorHelper (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:10:5)
> at deepStepWithNestedError (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:13:5)
Bubbling up error to parent workflow
FatalError while running "wrun_01K9VGBX3N34GG0SP36DC5156E" workflow:
FatalError: Error from step helper
at throwStepError (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:7:11)
at stepErrorHelper (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:10:5)
at deepStepWithNestedError (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:13:5)
at \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:698:21)
at AsyncLocalStorage.run (node:internal/async_local_storage/async_hooks:91:14)
at \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:680:43)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:94:22)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:57:58)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:576:14)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/world-local/src/queue.ts:148:24)

Call chain (Step Node.js context):
throwStepError (98_step_error_test.ts:7)

stepErrorHelper (98_step_error_test.ts:10)

deepStepWithNestedError (98_step_error_test.ts:13) [STEP FUNCTION]

[Error preserved and propagated to workflow context]

=== KEY OBSERVATIONS ===

  1. WORKFLOW ERROR (Test 1):
    • Error thrown in workflow VM context
    • Stack trace shows: 98_workflow_error_test.ts → 99_e2e.ts
    • Inline sourcemaps in workflow bundle enable proper file/line references
  2. STEP ERROR (Test 2):
    • Error thrown in step Node.js context
    • Stack trace shows full call chain within the step: 98_step_error_test.ts lines 7→10→13
    • Inline sourcemaps in step bundle enable proper file/line references
    • Stack trace PRESERVED when error bubbles up to workflow (fix in step.ts:94-100)
  3. SOURCEMAP CONFIGURATION:
    • Workflow bundle: sourcemap: 'inline' (base-builder.ts:481)
    • Step bundle: sourcemap: 'inline' (base-builder.ts:355)
    • Node.js runtime: NODE_OPTIONS="--enable-source-maps"

@vercel

vercelBot commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentPreviewCommentsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreviewCommentNov 12, 2025 11:59pm
example-nextjs-workflow-webpackReadyReadyPreviewCommentNov 12, 2025 11:59pm
example-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-hono-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-nitro-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-nuxt-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-sveltekit-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-vite-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workflow-docsReadyReadyPreviewCommentNov 12, 2025 11:59pm

@changeset-bot

changeset-botBot commented Nov 12, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8fd157d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
NameType
@workflow/buildersPatch
@workflow/corePatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/sveltekitPatch
@workflow/web-sharedPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/aiPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pranaygpGraphite App

pranaygp commented Nov 12, 2025

Copy link
Copy Markdown
ContributorAuthor

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

pranaygpand others added 4 commits November 12, 2025 18:56
Normalize trigger scripts across workbenches
fix: include hono in local build test
test: include src dir for test
test: add workflow dir config in test to fix sveltekit dev tests
add temp 7_full in example wokrflow
format
fix(sveltekit): detecting workflow folders and customizable dir
Remove 7_full and 1_simple error
replace API symlink in webpack workbench
Fix sveltekit and vite tests
Fix sveltekit symlinks
Test fixes
Fix sveltekit workflows path
Dont symlink routes in vite
Include e2e tests for hono and vite
fix error tests post normalization
wip - attempted fixes
* Proper stacktrace propogation in world
Proper stacktrace propogation in world
* Standardize the error type in the world spec
* Normalize Workbenches
Normalize trigger scripts across workbenches
fix: include hono in local build test
test: include src dir for test
test: add workflow dir config in test to fix sveltekit dev tests
add temp 7_full in example wokrflow
format
fix(sveltekit): detecting workflow folders and customizable dir
Remove 7_full and 1_simple error
replace API symlink in webpack workbench
Fix sveltekit and vite tests
Fix sveltekit symlinks
Test fixes
Fix sveltekit workflows path
Dont symlink routes in vite
Include e2e tests for hono and vite
* fix error tests post normalization
* fix(sveltekit): reading file on hmr delete
* changeset
* fix(vite): add resolve symlink script
* fix(vite): missing building on hmr
* test local builder in vite
* test: increase timeout on hookWorkflow
* test: ignore vite based apps in crossFileWorkflow
* test: fix nitro based apps status codes
* fix: intercept default vite spa handler on 404 workflow routes
* fix: vite hook route returning 422
* test: use 422 for hookWorkflow expected
* test: fix hono returning 404
* chore: add comment to middleware to clarify
* make api route for duplicate case
* revert
* revert: nitro builder
* add back nitro unhandled rejection logic
* test: add hono
* changeset
* fix: unused method
* fix: remove duplicate import
* remove
* chore: add comments to clarify
* test remove vite symlink script
---------
Co-authored-by: Pranay Prakash <pranay.gp@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@pranaygp@adriandlam
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Implement step sourcemaps - #310

Closed
pranaygp wants to merge 4 commits into
mainfrom
pranaygp/11-12-implement_step_sourcemaps
Closed

Implement step sourcemaps#310
pranaygp wants to merge 4 commits into
mainfrom
pranaygp/11-12-implement_step_sourcemaps

Conversation

@pranaygp

@pranaygppranaygp commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

=== TEST 1: crossFileErrorWorkflow (Workflow Error in VM Context) ===

Starting "crossFileErrorWorkflow" workflow with args:
Error while running "wrun_01K9VGB8JZCJYY0KC7VGTWH8KS" workflow:
Error: Error from workflow helper
at throwWorkflowError (../example/workflows/98_workflow_error_test.ts:4:10)
at workflowErrorHelper (../example/workflows/98_workflow_error_test.ts:7:4)
at crossFileErrorWorkflow (../example/workflows/99_e2e.ts:290:4)
at \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/workflow.ts:574:7)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:94:22)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:362:28)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:94:22)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:57:58)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:280:14)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/world-local/src/queue.ts:148:24)

Call chain (Workflow VM context):
throwWorkflowError (98_workflow_error_test.ts:4)

workflowErrorHelper (98_workflow_error_test.ts:7)

crossFileErrorWorkflow (99_e2e.ts:290)

=== TEST 2: deepStepErrorWorkflow (Step Error in Node.js Context) ===

Starting "deepStepErrorWorkflow" workflow with args:
[Workflows] "wrun_01K9VGBX3N34GG0SP36DC5156E" - Encountered `FatalError` while executing step "step//example/workflows/98_step_error_test.ts//deepStepWithNestedError":
> FatalError: Error from step helper
> at throwStepError (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:7:11)
> at stepErrorHelper (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:10:5)
> at deepStepWithNestedError (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:13:5)
Bubbling up error to parent workflow
FatalError while running "wrun_01K9VGBX3N34GG0SP36DC5156E" workflow:
FatalError: Error from step helper
at throwStepError (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:7:11)
at stepErrorHelper (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:10:5)
at deepStepWithNestedError (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:13:5)
at \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:698:21)
at AsyncLocalStorage.run (node:internal/async_local_storage/async_hooks:91:14)
at \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:680:43)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:94:22)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:57:58)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:576:14)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/world-local/src/queue.ts:148:24)

Call chain (Step Node.js context):
throwStepError (98_step_error_test.ts:7)

stepErrorHelper (98_step_error_test.ts:10)

deepStepWithNestedError (98_step_error_test.ts:13) [STEP FUNCTION]

[Error preserved and propagated to workflow context]

=== KEY OBSERVATIONS ===

  1. WORKFLOW ERROR (Test 1):
    • Error thrown in workflow VM context
    • Stack trace shows: 98_workflow_error_test.ts → 99_e2e.ts
    • Inline sourcemaps in workflow bundle enable proper file/line references
  2. STEP ERROR (Test 2):
    • Error thrown in step Node.js context
    • Stack trace shows full call chain within the step: 98_step_error_test.ts lines 7→10→13
    • Inline sourcemaps in step bundle enable proper file/line references
    • Stack trace PRESERVED when error bubbles up to workflow (fix in step.ts:94-100)
  3. SOURCEMAP CONFIGURATION:
    • Workflow bundle: sourcemap: 'inline' (base-builder.ts:481)
    • Step bundle: sourcemap: 'inline' (base-builder.ts:355)
    • Node.js runtime: NODE_OPTIONS="--enable-source-maps"

@vercel

vercelBot commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentPreviewCommentsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreviewCommentNov 12, 2025 11:59pm
example-nextjs-workflow-webpackReadyReadyPreviewCommentNov 12, 2025 11:59pm
example-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-hono-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-nitro-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-nuxt-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-sveltekit-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-vite-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workflow-docsReadyReadyPreviewCommentNov 12, 2025 11:59pm

@changeset-bot

changeset-botBot commented Nov 12, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8fd157d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
NameType
@workflow/buildersPatch
@workflow/corePatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/sveltekitPatch
@workflow/web-sharedPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/aiPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pranaygpGraphite App

pranaygp commented Nov 12, 2025

Copy link
Copy Markdown
ContributorAuthor

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

pranaygpand others added 4 commits November 12, 2025 18:56
Normalize trigger scripts across workbenches
fix: include hono in local build test
test: include src dir for test
test: add workflow dir config in test to fix sveltekit dev tests
add temp 7_full in example wokrflow
format
fix(sveltekit): detecting workflow folders and customizable dir
Remove 7_full and 1_simple error
replace API symlink in webpack workbench
Fix sveltekit and vite tests
Fix sveltekit symlinks
Test fixes
Fix sveltekit workflows path
Dont symlink routes in vite
Include e2e tests for hono and vite
fix error tests post normalization
wip - attempted fixes
* Proper stacktrace propogation in world
Proper stacktrace propogation in world
* Standardize the error type in the world spec
* Normalize Workbenches
Normalize trigger scripts across workbenches
fix: include hono in local build test
test: include src dir for test
test: add workflow dir config in test to fix sveltekit dev tests
add temp 7_full in example wokrflow
format
fix(sveltekit): detecting workflow folders and customizable dir
Remove 7_full and 1_simple error
replace API symlink in webpack workbench
Fix sveltekit and vite tests
Fix sveltekit symlinks
Test fixes
Fix sveltekit workflows path
Dont symlink routes in vite
Include e2e tests for hono and vite
* fix error tests post normalization
* fix(sveltekit): reading file on hmr delete
* changeset
* fix(vite): add resolve symlink script
* fix(vite): missing building on hmr
* test local builder in vite
* test: increase timeout on hookWorkflow
* test: ignore vite based apps in crossFileWorkflow
* test: fix nitro based apps status codes
* fix: intercept default vite spa handler on 404 workflow routes
* fix: vite hook route returning 422
* test: use 422 for hookWorkflow expected
* test: fix hono returning 404
* chore: add comment to middleware to clarify
* make api route for duplicate case
* revert
* revert: nitro builder
* add back nitro unhandled rejection logic
* test: add hono
* changeset
* fix: unused method
* fix: remove duplicate import
* remove
* chore: add comments to clarify
* test remove vite symlink script
---------
Co-authored-by: Pranay Prakash <pranay.gp@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@pranaygp@adriandlam
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Implement step sourcemaps - #310

Closed
pranaygp wants to merge 4 commits into
mainfrom
pranaygp/11-12-implement_step_sourcemaps
Closed

Implement step sourcemaps#310
pranaygp wants to merge 4 commits into
mainfrom
pranaygp/11-12-implement_step_sourcemaps

Conversation

@pranaygp

@pranaygppranaygp commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

=== TEST 1: crossFileErrorWorkflow (Workflow Error in VM Context) ===

Starting "crossFileErrorWorkflow" workflow with args:
Error while running "wrun_01K9VGB8JZCJYY0KC7VGTWH8KS" workflow:
Error: Error from workflow helper
at throwWorkflowError (../example/workflows/98_workflow_error_test.ts:4:10)
at workflowErrorHelper (../example/workflows/98_workflow_error_test.ts:7:4)
at crossFileErrorWorkflow (../example/workflows/99_e2e.ts:290:4)
at \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/workflow.ts:574:7)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:94:22)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:362:28)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:94:22)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:57:58)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:280:14)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/world-local/src/queue.ts:148:24)

Call chain (Workflow VM context):
throwWorkflowError (98_workflow_error_test.ts:4)

workflowErrorHelper (98_workflow_error_test.ts:7)

crossFileErrorWorkflow (99_e2e.ts:290)

=== TEST 2: deepStepErrorWorkflow (Step Error in Node.js Context) ===

Starting "deepStepErrorWorkflow" workflow with args:
[Workflows] "wrun_01K9VGBX3N34GG0SP36DC5156E" - Encountered `FatalError` while executing step "step//example/workflows/98_step_error_test.ts//deepStepWithNestedError":
> FatalError: Error from step helper
> at throwStepError (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:7:11)
> at stepErrorHelper (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:10:5)
> at deepStepWithNestedError (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:13:5)
Bubbling up error to parent workflow
FatalError while running "wrun_01K9VGBX3N34GG0SP36DC5156E" workflow:
FatalError: Error from step helper
at throwStepError (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:7:11)
at stepErrorHelper (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:10:5)
at deepStepWithNestedError (/Users/pranaygp/github/vercel/workflow/workbench/example/workflows/98_step_error_test.ts:13:5)
at \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:698:21)
at AsyncLocalStorage.run (node:internal/async_local_storage/async_hooks:91:14)
at \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:680:43)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:94:22)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/telemetry.ts:57:58)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/core/src/runtime.ts:576:14)
at async \<anonymous> (/Users/pranaygp/github/vercel/workflow/packages/world-local/src/queue.ts:148:24)

Call chain (Step Node.js context):
throwStepError (98_step_error_test.ts:7)

stepErrorHelper (98_step_error_test.ts:10)

deepStepWithNestedError (98_step_error_test.ts:13) [STEP FUNCTION]

[Error preserved and propagated to workflow context]

=== KEY OBSERVATIONS ===

  1. WORKFLOW ERROR (Test 1):
    • Error thrown in workflow VM context
    • Stack trace shows: 98_workflow_error_test.ts → 99_e2e.ts
    • Inline sourcemaps in workflow bundle enable proper file/line references
  2. STEP ERROR (Test 2):
    • Error thrown in step Node.js context
    • Stack trace shows full call chain within the step: 98_step_error_test.ts lines 7→10→13
    • Inline sourcemaps in step bundle enable proper file/line references
    • Stack trace PRESERVED when error bubbles up to workflow (fix in step.ts:94-100)
  3. SOURCEMAP CONFIGURATION:
    • Workflow bundle: sourcemap: 'inline' (base-builder.ts:481)
    • Step bundle: sourcemap: 'inline' (base-builder.ts:355)
    • Node.js runtime: NODE_OPTIONS="--enable-source-maps"

@vercel

vercelBot commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentPreviewCommentsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreviewCommentNov 12, 2025 11:59pm
example-nextjs-workflow-webpackReadyReadyPreviewCommentNov 12, 2025 11:59pm
example-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-hono-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-nitro-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-nuxt-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-sveltekit-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workbench-vite-workflowReadyReadyPreviewCommentNov 12, 2025 11:59pm
workflow-docsReadyReadyPreviewCommentNov 12, 2025 11:59pm

@changeset-bot

changeset-botBot commented Nov 12, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8fd157d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
NameType
@workflow/buildersPatch
@workflow/corePatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/sveltekitPatch
@workflow/web-sharedPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/aiPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pranaygpGraphite App

pranaygp commented Nov 12, 2025

Copy link
Copy Markdown
ContributorAuthor

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

pranaygpand others added 4 commits November 12, 2025 18:56
Normalize trigger scripts across workbenches
fix: include hono in local build test
test: include src dir for test
test: add workflow dir config in test to fix sveltekit dev tests
add temp 7_full in example wokrflow
format
fix(sveltekit): detecting workflow folders and customizable dir
Remove 7_full and 1_simple error
replace API symlink in webpack workbench
Fix sveltekit and vite tests
Fix sveltekit symlinks
Test fixes
Fix sveltekit workflows path
Dont symlink routes in vite
Include e2e tests for hono and vite
fix error tests post normalization
wip - attempted fixes
* Proper stacktrace propogation in world
Proper stacktrace propogation in world
* Standardize the error type in the world spec
* Normalize Workbenches
Normalize trigger scripts across workbenches
fix: include hono in local build test
test: include src dir for test
test: add workflow dir config in test to fix sveltekit dev tests
add temp 7_full in example wokrflow
format
fix(sveltekit): detecting workflow folders and customizable dir
Remove 7_full and 1_simple error
replace API symlink in webpack workbench
Fix sveltekit and vite tests
Fix sveltekit symlinks
Test fixes
Fix sveltekit workflows path
Dont symlink routes in vite
Include e2e tests for hono and vite
* fix error tests post normalization
* fix(sveltekit): reading file on hmr delete
* changeset
* fix(vite): add resolve symlink script
* fix(vite): missing building on hmr
* test local builder in vite
* test: increase timeout on hookWorkflow
* test: ignore vite based apps in crossFileWorkflow
* test: fix nitro based apps status codes
* fix: intercept default vite spa handler on 404 workflow routes
* fix: vite hook route returning 422
* test: use 422 for hookWorkflow expected
* test: fix hono returning 404
* chore: add comment to middleware to clarify
* make api route for duplicate case
* revert
* revert: nitro builder
* add back nitro unhandled rejection logic
* test: add hono
* changeset
* fix: unused method
* fix: remove duplicate import
* remove
* chore: add comments to clarify
* test remove vite symlink script
---------
Co-authored-by: Pranay Prakash <pranay.gp@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@pranaygp@adriandlam