Skip to content

Fix Biome lint violations and add Biome CI check - #3222

Merged
TooTallNate merged 2 commits into
mainfrom
lint/biome-vcs-ignore-and-ci
Jul 30, 2026
Merged

Fix Biome lint violations and add Biome CI check#3222
TooTallNate merged 2 commits into
mainfrom
lint/biome-vcs-ignore-and-ci

Conversation

@TooTallNate

@TooTallNateTooTallNate commented Jul 30, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Summary

pnpm lint (biome check) was reporting 13,355 diagnostics (7,445 errors) and nobody was watching the output. This PR gets the repo to zero lint errors and adds a CI gate so it stays that way.

Root cause

Biome was not configured to respect .gitignore, so ~92% of all diagnostics came from gitignored build artifacts (packages/web/build, workbench/sveltekit/.svelte-kit, workbench/sveltekit/build, docs/.source, wasm pkg output).

Changes

biome.json

  • Enable vcs.useIgnoreFile so Biome skips gitignored files (13,355 → 921 diagnostics). This also keeps local runs consistent with CI, where those artifacts don't exist in a fresh checkout.
  • Fix stale $schema version (2.3.3 → 2.4.4, matching the pinned CLI).
  • Downgrade a11y rules (noSvgWithoutTitle, useSemanticElements, useKeyWithClickEvents, useFocusableInteractive, noStaticElementInteractions, noNoninteractiveElementToInteractiveRole) and security/noDangerouslySetInnerHtml from error → warn. The 30 hits are all in internal dev-tools UI / docs marketing components and need design-level fixes; this matches how the repo already treats noNonNullAssertion, useExhaustiveDependencies, etc.

Auto-fixes (~115 files)

  • biome check --write safe fixes: formatting, import ordering, useImportType, useConst, etc.
  • Targeted --unsafe --only=correctness/noUnusedVariables: _-prefixes for unused catch params and loop vars.

Manual fixes

  • 8 unused destructured bindings (test files + BenchmarkChart.tsx).
  • 3 noAssignInExpressions: context-storage.ts global-singleton init rewritten as an IIFE with ??=; writable-stream.ts cache init hoisted out of the expression; extractor.tswhile ((match = re.exec(...))) → matchAll().
  • 3 useIterableCallbackReturn: forEach arrow bodies wrapped in braces (context-violation-error.ts, @workflow/errors, workbench script).
  • 2 missing type="button" (workbench/nextjs-turbopack/app/app-shell.tsx).

CI

  • New biome job in .github/workflows/lint.yml running pnpm exec biome ci --max-diagnostics=200. Fails on errors, annotates PRs via the GitHub reporter, and uses the repo-pinned Biome version via pnpm.

What's left (non-blocking)

696 warnings and 58 infos remain visible in biome check output (mostly noExcessiveCognitiveComplexity, useTemplate, noNonNullAssertion — pre-existing warn-level rules). These do not fail biome ci.

Verification

  • pnpm lint / pnpm exec biome ci exit 0 (0 errors)
  • pnpm typecheck passes
  • Tests: packages/core src suite (1,652 passed), @workflow/errors (38), @workflow/docs-typecheck (1,255), @workflow/ai agent tests, and core src/step suites all green
  • Empty changeset included — all changes are behavior-preserving, so no release is needed; the code ships with the next regular release

Review notes

  • packages/core/src/serialization.ts: organize-imports merged two ./sealed-box.js import statements; both sealed-box.ts and get-world-lazy.ts are side-effect-free at module scope, so evaluation order is unaffected.
  • workbench/vitest/workflows/cookbook/saga.ts: entitlementId → _entitlementId — flagging in case that snippet is quoted verbatim in docs.

@TooTallNate
Fix Biome lint violations and add Biome CI check
f87e9b6
Biome was not configured to respect .gitignore, so ~92% of the 13,355
reported diagnostics came from gitignored build artifacts. Enable VCS
integration (useIgnoreFile), apply safe auto-fixes across the repo, fix
the remaining mechanical errors by hand, downgrade judgment-call a11y /
dangerouslySetInnerHTML rules to warnings, and add a 'biome ci' job to
the Lint workflow so violations block PRs going forward.
@TooTallNate
TooTallNate requested review from a team and ijjk as code ownersJuly 30, 2026 19:38
CopilotAI review requested due to automatic review settings July 30, 2026 19:38
@TooTallNate
TooTallNate requested a review from a team as a code ownerJuly 30, 2026 19:38
@vercel

vercelBot commented Jul 30, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreviewJul 30, 2026 8:00pm
example-nextjs-workflow-webpackReadyReadyPreviewJul 30, 2026 8:00pm
example-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-astro-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-express-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-fastify-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-hono-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-nestjs-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-nitro-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-nuxt-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-sveltekit-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-tanstack-start-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-vite-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workflow-docsReadyReadyPreview, v0Jul 30, 2026 8:00pm
workflow-swc-playgroundReadyReadyPreviewJul 30, 2026 8:00pm
workflow-tarballsReadyReadyPreviewJul 30, 2026 8:00pm
workflow-webReadyReadyPreviewJul 30, 2026 8:00pm

@changeset-bot

changeset-botBot commented Jul 30, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 40a973c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

CopilotAI reviewed Jul 30, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

github-actionsBot commented Jul 30, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

✅ All tests passed

E2E Test Summary

Summary
PassedFailedSkippedTotal
✅ ▲ Vercel Production145502391694
✅ 💻 Local Development162102271848
✅ 📦 Local Production162102271848
✅ 🐘 Local Postgres162102271848
✅ 🪟 Windows15400154
✅ 📋 Other102002121232
✅ vercel-multi-region270027
Total7519011328651
Details by Category

✅ ▲ Vercel Production

AppPassedFailedSkipped
✅ astro126028
✅ example126028
✅ express126028
✅ fastify126028
✅ hono126028
✅ nextjs-turbopack15103
✅ nextjs-webpack15103
✅ nitro126028
✅ nuxt126028
✅ sveltekit14509
✅ vite126028

✅ 💻 Local Development

AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026

✅ 📦 Local Production

AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026

✅ 🐘 Local Postgres

AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026

✅ 🪟 Windows

AppPassedFailedSkipped
✅ nextjs-turbopack15400

✅ 📋 Other

AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128026
✅ e2e-local-dev-tanstack-start-128026
✅ e2e-local-postgres-nest-stable128026
✅ e2e-local-postgres-tanstack-start-128026
✅ e2e-local-prod-nest-stable128026
✅ e2e-local-prod-tanstack-start-128026
✅ e2e-vercel-prod-nest126028
✅ e2e-vercel-prod-tanstack-start126028

✅ vercel-multi-region

AppPassedFailedSkipped
✅ nextjs-turbopack2700

📋 View full workflow run

@github-actions

github-actionsBot commented Jul 30, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 40a973c · Thu, 30 Jul 2026 20:18:13 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep1281 (+320%) 🔻1386 🔴 (+29%) 🔻1403 🔴 (+27%) 🔻1766 🔴 (+30%) 🔻30
TTFSstream245 (-75%) 💚1350 🔴 (+31%) 🔻1364 🔴 (+32%) 🔻1508 🔴 (+32%) 🔻30
TTFShook + stream1499 (+20%) 🔻1661 🔴 (+23%) 🔻1831 🔴 (+31%) 🔻5934 🔴 (+305%) 🔻30
STSO1020 steps (1-20)175 (+2.9%)282 🔴 (-8.4%)326 🔴 (-8.9%)332 🔴 (-25%) 💚19
STSO1020 steps (101-120)192 (-2.0%)269 🔴 (+5.9%)304 🔴 (+5.6%)341 🔴 (-25%) 💚19
STSO1020 steps (1001-1020)521 (+1.8%)596 🔴 (+2.8%)638 🔴 (-0.8%)660 🔴 (+1.4%)19
WO1020 steps407279 (+2.1%)407279 (+2.1%)407279 (+2.1%)407279 (+2.1%)1
SLstream latency116 (+33%) 🔻195 🔴 (+28%) 🔻235 🔴 (+19%) 🔻463 🔴 (+20%) 🔻30
SOstream overhead (text)118 (+1.7%)186 (-4.6%)225 (-54%) 💚293 (-61%) 💚30
SOstream overhead (structured)112 (+8.7%)176 (-17%) 💚216 (-15%)288 (-36%) 💚30
ℹ️ Metric definitions & methodology

Best/P75/P90/P99 deltas compare against the most recent benchmark run on main at the time of this run. 🔻 flags a delta worse than +15%, 💚 one better than −15%.

Metrics — TTFS: time to first step body (in-deployment start() → first step body, deployment clocks) · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (whole-run time outside step bodies, in-deployment anchored) · SL: stream latency (in-deployment write → read propagation, readAt - writtenAt) · SO: stream overhead (end-to-end write+consume time beyond the modelled generation window)

Scenarios — step: one trivial no-op step, no stream; no hooks, so the run stays in turbo mode (in-process fast path) · stream: one streaming step; no hooks, so the run stays in turbo mode (in-process fast path) · hook + stream: registers a hook before one step, which exits turbo mode (dispatch path) · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges, and WO is the whole-run overhead outside step bodies · stream latency: parallel reader/writer steps on a dedicated stream; SL is the in-deployment write->read propagation (readAt - writtenAt) · stream overhead (text): writer streams 300 variable-length text token deltas paced at 100/s for 3s (a haiku-size LLM's token throughput) while a parallel reader drains the whole stream; SO is the end-to-end write+consume time beyond the 3s generation window (overhead/backpressure) · stream overhead (structured): same workload as stream overhead (text), but each delta is an AI-SDK-style structured object ({ type: 'text-delta', id, text }) instead of a raw string, so the SO gap vs the text scenario is the added serialization cost

🔴 marks a percentile over its target (within target is left unmarked). Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · SO 250/500/1000 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120

All metrics are measured from deployment-side timestamps only. Runs are triggered by an in-deployment route that stamps the anchor (clientStart) right before start(), so the CI runner’s request and its path through api.vercel.com sit outside every measured window. TTFS = in-deployment start() → first step body (turbo uses the in-process fast path, non-turbo the dispatch path), and includes the VQS dispatch hop plus any /flow cold start. STSO/WO are measured between step bodies on the deployment. SL is measured inside the workflow (parallel reader/writer steps), so it no longer includes the api.vercel.com read path.

Cold starts are kept in the numbers on purpose — they are part of real bursty-workload latency. The workbench deployment cold-starts the /flow invocation for a large fraction of runs, inflating P75+; the Best column shows the fastest (warm-start) sample for comparison.

@TooTallNate
TooTallNate enabled auto-merge (squash) July 30, 2026 19:56
@TooTallNate
TooTallNate merged commit 32ac8e7 into mainJul 30, 2026
175 of 177 checks passed
@TooTallNate
TooTallNate deleted the lint/biome-vcs-ignore-and-ci branch July 30, 2026 22:32
@github-actions

github-actionsBot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

No backport to stable for 32ac8e7 (AI decision).

This is a repo-wide lint cleanup (import reordering, _-prefixing unused bindings, small refactors like the context-storage.ts IIFE and extractor.tsmatchAll() rewrite) plus a new biome ci gate and Biome config changes — all explicitly behavior-preserving, shipped with an empty changeset. Adding a new CI enforcement job and mechanically churning ~115 files is tooling/hygiene work, not a fix needed to keep stable buildable, testable, or releasable. The large mechanical diff also carries backport-conflict risk on a maintenance line for zero user-visible benefit.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

32ac8e73fd42ce5b1b89ec243294b1f815e4b5e0

@VaguelySeriousVaguelySerious mentioned this pull request Jul 30, 2026
Merged
@pranaygppranaygp mentioned this pull request Jul 30, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@VaguelySeriousVaguelySeriousVaguelySerious approved these changes
@ijjkijjkAwaiting requested review from ijjk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TooTallNate@VaguelySerious
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Fix Biome lint violations and add Biome CI check by TooTallNate · Pull Request #3222 · vercel/workflow · GitHub
Skip to content
Fix Biome lint violations and add Biome CI check - #3222
Merged
TooTallNate merged 2 commits into
mainfrom 
lint/biome-vcs-ignore-and-ci
Jul 30, 2026
Merged
Fix Biome lint violations and add Biome CI check#3222
TooTallNate merged 2 commits into
mainfrom 
lint/biome-vcs-ignore-and-ci
Conversation
@TooTallNate
@TooTallNateTooTallNate
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Summary
pnpm lint (biome check) was reporting 13,355 diagnostics (7,445 errors) and nobody was watching the output. This PR gets the repo to zero lint errors and adds a CI gate so it stays that way.
Root cause
Biome was not configured to respect .gitignore, so ~92% of all diagnostics came from gitignored build artifacts (packages/web/build, workbench/sveltekit/.svelte-kit, workbench/sveltekit/build, docs/.source, wasm pkg output).
Changes
biome.json
  • Enable vcs.useIgnoreFile so Biome skips gitignored files (13,355 → 921 diagnostics). This also keeps local runs consistent with CI, where those artifacts don't exist in a fresh checkout.
  • Fix stale $schema version (2.3.3 → 2.4.4, matching the pinned CLI).
  • Downgrade a11y rules (noSvgWithoutTitle, useSemanticElements, useKeyWithClickEvents, useFocusableInteractive, noStaticElementInteractions, noNoninteractiveElementToInteractiveRole) and security/noDangerouslySetInnerHtml from error → warn. The 30 hits are all in internal dev-tools UI / docs marketing components and need design-level fixes; this matches how the repo already treats noNonNullAssertion, useExhaustiveDependencies, etc.
Auto-fixes (~115 files)
  • biome check --write safe fixes: formatting, import ordering, useImportType, useConst, etc.
  • Targeted --unsafe --only=correctness/noUnusedVariables: _-prefixes for unused catch params and loop vars.
Manual fixes
  • 8 unused destructured bindings (test files + BenchmarkChart.tsx).
  • 3 noAssignInExpressions: context-storage.ts global-singleton init rewritten as an IIFE with ??=; writable-stream.ts cache init hoisted out of the expression; extractor.tswhile ((match = re.exec(...))) → matchAll().
  • 3 useIterableCallbackReturn: forEach arrow bodies wrapped in braces (context-violation-error.ts, @workflow/errors, workbench script).
  • 2 missing type="button" (workbench/nextjs-turbopack/app/app-shell.tsx).
CI
  • New biome job in .github/workflows/lint.yml running pnpm exec biome ci --max-diagnostics=200. Fails on errors, annotates PRs via the GitHub reporter, and uses the repo-pinned Biome version via pnpm.
What's left (non-blocking)
696 warnings and 58 infos remain visible in biome check output (mostly noExcessiveCognitiveComplexity, useTemplate, noNonNullAssertion — pre-existing warn-level rules). These do not fail biome ci.
Verification
  • pnpm lint / pnpm exec biome ci exit 0 (0 errors)
  • pnpm typecheck passes
  • Tests: packages/core src suite (1,652 passed), @workflow/errors (38), @workflow/docs-typecheck (1,255), @workflow/ai agent tests, and core src/step suites all green
  • Empty changeset included — all changes are behavior-preserving, so no release is needed; the code ships with the next regular release
Review notes
  • packages/core/src/serialization.ts: organize-imports merged two ./sealed-box.js import statements; both sealed-box.ts and get-world-lazy.ts are side-effect-free at module scope, so evaluation order is unaffected.
  • workbench/vitest/workflows/cookbook/saga.ts: entitlementId → _entitlementId — flagging in case that snippet is quoted verbatim in docs.
@TooTallNate
Fix Biome lint violations and add Biome CI check
f87e9b6
Biome was not configured to respect .gitignore, so ~92% of the 13,355
reported diagnostics came from gitignored build artifacts. Enable VCS
integration (useIgnoreFile), apply safe auto-fixes across the repo, fix
the remaining mechanical errors by hand, downgrade judgment-call a11y /
dangerouslySetInnerHTML rules to warnings, and add a 'biome ci' job to
the Lint workflow so violations block PRs going forward.
@TooTallNate
TooTallNate
requested review from
a team and ijjk
as code ownersJuly 30, 2026 19:38
CopilotAI
review requested due to automatic review settings
July 30, 2026 19:38
@TooTallNate
TooTallNate
requested a review
from a team
as a code ownerJuly 30, 2026 19:38
@vercel
vercelBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreviewJul 30, 2026 8:00pm
example-nextjs-workflow-webpackReadyReadyPreviewJul 30, 2026 8:00pm
example-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-astro-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-express-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-fastify-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-hono-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-nestjs-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-nitro-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-nuxt-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-sveltekit-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-tanstack-start-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-vite-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workflow-docsReadyReadyPreview, v0Jul 30, 2026 8:00pm
workflow-swc-playgroundReadyReadyPreviewJul 30, 2026 8:00pm
workflow-tarballsReadyReadyPreviewJul 30, 2026 8:00pm
workflow-webReadyReadyPreviewJul 30, 2026 8:00pm
@changeset-bot
changeset-botBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 40a973c
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
CopilotAI
reviewed
Jul 30, 2026
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
@github-actions
github-actionsBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
🧪 E2E Test Results
✅ All tests passed
E2E Test Summary
Summary
PassedFailedSkippedTotal
✅ ▲ Vercel Production145502391694
✅ 💻 Local Development162102271848
✅ 📦 Local Production162102271848
✅ 🐘 Local Postgres162102271848
✅ 🪟 Windows15400154
✅ 📋 Other102002121232
✅ vercel-multi-region270027
Total7519011328651
Details by Category
✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126028
✅ example126028
✅ express126028
✅ fastify126028
✅ hono126028
✅ nextjs-turbopack15103
✅ nextjs-webpack15103
✅ nitro126028
✅ nuxt126028
✅ sveltekit14509
✅ vite126028
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15400
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128026
✅ e2e-local-dev-tanstack-start-128026
✅ e2e-local-postgres-nest-stable128026
✅ e2e-local-postgres-tanstack-start-128026
✅ e2e-local-prod-nest-stable128026
✅ e2e-local-prod-tanstack-start-128026
✅ e2e-vercel-prod-nest126028
✅ e2e-vercel-prod-tanstack-start126028
✅ vercel-multi-region
AppPassedFailedSkipped
✅ nextjs-turbopack2700
📋 View full workflow run
@github-actions
github-actionsBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📊 Workflow Benchmarks
commit 40a973c · Thu, 30 Jul 2026 20:18:13 GMT · run logs
Backend: vercel · app: nextjs-turbopack
MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep1281 (+320%) 🔻1386 🔴 (+29%) 🔻1403 🔴 (+27%) 🔻1766 🔴 (+30%) 🔻30
TTFSstream245 (-75%) 💚1350 🔴 (+31%) 🔻1364 🔴 (+32%) 🔻1508 🔴 (+32%) 🔻30
TTFShook + stream1499 (+20%) 🔻1661 🔴 (+23%) 🔻1831 🔴 (+31%) 🔻5934 🔴 (+305%) 🔻30
STSO1020 steps (1-20)175 (+2.9%)282 🔴 (-8.4%)326 🔴 (-8.9%)332 🔴 (-25%) 💚19
STSO1020 steps (101-120)192 (-2.0%)269 🔴 (+5.9%)304 🔴 (+5.6%)341 🔴 (-25%) 💚19
STSO1020 steps (1001-1020)521 (+1.8%)596 🔴 (+2.8%)638 🔴 (-0.8%)660 🔴 (+1.4%)19
WO1020 steps407279 (+2.1%)407279 (+2.1%)407279 (+2.1%)407279 (+2.1%)1
SLstream latency116 (+33%) 🔻195 🔴 (+28%) 🔻235 🔴 (+19%) 🔻463 🔴 (+20%) 🔻30
SOstream overhead (text)118 (+1.7%)186 (-4.6%)225 (-54%) 💚293 (-61%) 💚30
SOstream overhead (structured)112 (+8.7%)176 (-17%) 💚216 (-15%)288 (-36%) 💚30
ℹ️ Metric definitions & methodology
Best/P75/P90/P99 deltas compare against the most recent benchmark run on main at the time of this run. 🔻 flags a delta worse than +15%, 💚 one better than −15%.
Metrics — TTFS: time to first step body (in-deployment start() → first step body, deployment clocks) · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (whole-run time outside step bodies, in-deployment anchored) · SL: stream latency (in-deployment write → read propagation, readAt - writtenAt) · SO: stream overhead (end-to-end write+consume time beyond the modelled generation window)
Scenarios — step: one trivial no-op step, no stream; no hooks, so the run stays in turbo mode (in-process fast path) · stream: one streaming step; no hooks, so the run stays in turbo mode (in-process fast path) · hook + stream: registers a hook before one step, which exits turbo mode (dispatch path) · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges, and WO is the whole-run overhead outside step bodies · stream latency: parallel reader/writer steps on a dedicated stream; SL is the in-deployment write->read propagation (readAt - writtenAt) · stream overhead (text): writer streams 300 variable-length text token deltas paced at 100/s for 3s (a haiku-size LLM's token throughput) while a parallel reader drains the whole stream; SO is the end-to-end write+consume time beyond the 3s generation window (overhead/backpressure) · stream overhead (structured): same workload as stream overhead (text), but each delta is an AI-SDK-style structured object ({ type: 'text-delta', id, text }) instead of a raw string, so the SO gap vs the text scenario is the added serialization cost
🔴 marks a percentile over its target (within target is left unmarked). Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · SO 250/500/1000 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120
All metrics are measured from deployment-side timestamps only. Runs are triggered by an in-deployment route that stamps the anchor (clientStart) right before start(), so the CI runner’s request and its path through api.vercel.com sit outside every measured window. TTFS = in-deployment start() → first step body (turbo uses the in-process fast path, non-turbo the dispatch path), and includes the VQS dispatch hop plus any /flow cold start. STSO/WO are measured between step bodies on the deployment. SL is measured inside the workflow (parallel reader/writer steps), so it no longer includes the api.vercel.com read path.
Cold starts are kept in the numbers on purpose — they are part of real bursty-workload latency. The workbench deployment cold-starts the /flow invocation for a large fraction of runs, inflating P75+; the Best column shows the fastest (warm-start) sample for comparison.
@TooTallNate
TooTallNate
enabled auto-merge (squash)
July 30, 2026 19:56
@TooTallNate
TooTallNate
merged commit 32ac8e7
into
mainJul 30, 2026

175 of 177 checks passed

@TooTallNate
TooTallNate
deleted the

lint/biome-vcs-ignore-and-ci

branch
July 30, 2026 22:32
@github-actions
github-actionsBot
commented
Jul 30, 2026

Copy link


Copy Markdown

Contributor
No backport to stable for 32ac8e7 (AI decision).
This is a repo-wide lint cleanup (import reordering, _-prefixing unused bindings, small refactors like the context-storage.ts IIFE and extractor.tsmatchAll() rewrite) plus a new biome ci gate and Biome config changes — all explicitly behavior-preserving, shipped with an empty changeset. Adding a new CI enforcement job and mechanically churning ~115 files is tooling/hygiene work, not a fix needed to keep stable buildable, testable, or releasable. The large mechanical diff also carries backport-conflict risk on a maintenance line for zero user-visible benefit.
To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:
32ac8e73fd42ce5b1b89ec243294b1f815e4b5e0

@VaguelySeriousVaguelySerious
mentioned this pull request
Jul 30, 2026
 Merged

@pranaygppranaygp
mentioned this pull request
Jul 30, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@VaguelySeriousVaguelySeriousVaguelySerious approved these changes
@ijjkijjkAwaiting requested review from ijjk

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@TooTallNate@VaguelySerious

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix Biome lint violations and add Biome CI check by TooTallNate · Pull Request #3222 · vercel/workflow · GitHub
Skip to content
Fix Biome lint violations and add Biome CI check - #3222
Merged
TooTallNate merged 2 commits into
mainfrom 
lint/biome-vcs-ignore-and-ci
Jul 30, 2026
Merged
Fix Biome lint violations and add Biome CI check#3222
TooTallNate merged 2 commits into
mainfrom 
lint/biome-vcs-ignore-and-ci
Conversation
@TooTallNate
@TooTallNateTooTallNate
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Summary
pnpm lint (biome check) was reporting 13,355 diagnostics (7,445 errors) and nobody was watching the output. This PR gets the repo to zero lint errors and adds a CI gate so it stays that way.
Root cause
Biome was not configured to respect .gitignore, so ~92% of all diagnostics came from gitignored build artifacts (packages/web/build, workbench/sveltekit/.svelte-kit, workbench/sveltekit/build, docs/.source, wasm pkg output).
Changes
biome.json
  • Enable vcs.useIgnoreFile so Biome skips gitignored files (13,355 → 921 diagnostics). This also keeps local runs consistent with CI, where those artifacts don't exist in a fresh checkout.
  • Fix stale $schema version (2.3.3 → 2.4.4, matching the pinned CLI).
  • Downgrade a11y rules (noSvgWithoutTitle, useSemanticElements, useKeyWithClickEvents, useFocusableInteractive, noStaticElementInteractions, noNoninteractiveElementToInteractiveRole) and security/noDangerouslySetInnerHtml from error → warn. The 30 hits are all in internal dev-tools UI / docs marketing components and need design-level fixes; this matches how the repo already treats noNonNullAssertion, useExhaustiveDependencies, etc.
Auto-fixes (~115 files)
  • biome check --write safe fixes: formatting, import ordering, useImportType, useConst, etc.
  • Targeted --unsafe --only=correctness/noUnusedVariables: _-prefixes for unused catch params and loop vars.
Manual fixes
  • 8 unused destructured bindings (test files + BenchmarkChart.tsx).
  • 3 noAssignInExpressions: context-storage.ts global-singleton init rewritten as an IIFE with ??=; writable-stream.ts cache init hoisted out of the expression; extractor.tswhile ((match = re.exec(...))) → matchAll().
  • 3 useIterableCallbackReturn: forEach arrow bodies wrapped in braces (context-violation-error.ts, @workflow/errors, workbench script).
  • 2 missing type="button" (workbench/nextjs-turbopack/app/app-shell.tsx).
CI
  • New biome job in .github/workflows/lint.yml running pnpm exec biome ci --max-diagnostics=200. Fails on errors, annotates PRs via the GitHub reporter, and uses the repo-pinned Biome version via pnpm.
What's left (non-blocking)
696 warnings and 58 infos remain visible in biome check output (mostly noExcessiveCognitiveComplexity, useTemplate, noNonNullAssertion — pre-existing warn-level rules). These do not fail biome ci.
Verification
  • pnpm lint / pnpm exec biome ci exit 0 (0 errors)
  • pnpm typecheck passes
  • Tests: packages/core src suite (1,652 passed), @workflow/errors (38), @workflow/docs-typecheck (1,255), @workflow/ai agent tests, and core src/step suites all green
  • Empty changeset included — all changes are behavior-preserving, so no release is needed; the code ships with the next regular release
Review notes
  • packages/core/src/serialization.ts: organize-imports merged two ./sealed-box.js import statements; both sealed-box.ts and get-world-lazy.ts are side-effect-free at module scope, so evaluation order is unaffected.
  • workbench/vitest/workflows/cookbook/saga.ts: entitlementId → _entitlementId — flagging in case that snippet is quoted verbatim in docs.
@TooTallNate
Fix Biome lint violations and add Biome CI check
f87e9b6
Biome was not configured to respect .gitignore, so ~92% of the 13,355
reported diagnostics came from gitignored build artifacts. Enable VCS
integration (useIgnoreFile), apply safe auto-fixes across the repo, fix
the remaining mechanical errors by hand, downgrade judgment-call a11y /
dangerouslySetInnerHTML rules to warnings, and add a 'biome ci' job to
the Lint workflow so violations block PRs going forward.
@TooTallNate
TooTallNate
requested review from
a team and ijjk
as code ownersJuly 30, 2026 19:38
CopilotAI
review requested due to automatic review settings
July 30, 2026 19:38
@TooTallNate
TooTallNate
requested a review
from a team
as a code ownerJuly 30, 2026 19:38
@vercel
vercelBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreviewJul 30, 2026 8:00pm
example-nextjs-workflow-webpackReadyReadyPreviewJul 30, 2026 8:00pm
example-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-astro-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-express-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-fastify-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-hono-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-nestjs-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-nitro-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-nuxt-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-sveltekit-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-tanstack-start-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-vite-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workflow-docsReadyReadyPreview, v0Jul 30, 2026 8:00pm
workflow-swc-playgroundReadyReadyPreviewJul 30, 2026 8:00pm
workflow-tarballsReadyReadyPreviewJul 30, 2026 8:00pm
workflow-webReadyReadyPreviewJul 30, 2026 8:00pm
@changeset-bot
changeset-botBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 40a973c
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
CopilotAI
reviewed
Jul 30, 2026
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
@github-actions
github-actionsBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
🧪 E2E Test Results
✅ All tests passed
E2E Test Summary
Summary
PassedFailedSkippedTotal
✅ ▲ Vercel Production145502391694
✅ 💻 Local Development162102271848
✅ 📦 Local Production162102271848
✅ 🐘 Local Postgres162102271848
✅ 🪟 Windows15400154
✅ 📋 Other102002121232
✅ vercel-multi-region270027
Total7519011328651
Details by Category
✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126028
✅ example126028
✅ express126028
✅ fastify126028
✅ hono126028
✅ nextjs-turbopack15103
✅ nextjs-webpack15103
✅ nitro126028
✅ nuxt126028
✅ sveltekit14509
✅ vite126028
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15400
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128026
✅ e2e-local-dev-tanstack-start-128026
✅ e2e-local-postgres-nest-stable128026
✅ e2e-local-postgres-tanstack-start-128026
✅ e2e-local-prod-nest-stable128026
✅ e2e-local-prod-tanstack-start-128026
✅ e2e-vercel-prod-nest126028
✅ e2e-vercel-prod-tanstack-start126028
✅ vercel-multi-region
AppPassedFailedSkipped
✅ nextjs-turbopack2700
📋 View full workflow run
@github-actions
github-actionsBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📊 Workflow Benchmarks
commit 40a973c · Thu, 30 Jul 2026 20:18:13 GMT · run logs
Backend: vercel · app: nextjs-turbopack
MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep1281 (+320%) 🔻1386 🔴 (+29%) 🔻1403 🔴 (+27%) 🔻1766 🔴 (+30%) 🔻30
TTFSstream245 (-75%) 💚1350 🔴 (+31%) 🔻1364 🔴 (+32%) 🔻1508 🔴 (+32%) 🔻30
TTFShook + stream1499 (+20%) 🔻1661 🔴 (+23%) 🔻1831 🔴 (+31%) 🔻5934 🔴 (+305%) 🔻30
STSO1020 steps (1-20)175 (+2.9%)282 🔴 (-8.4%)326 🔴 (-8.9%)332 🔴 (-25%) 💚19
STSO1020 steps (101-120)192 (-2.0%)269 🔴 (+5.9%)304 🔴 (+5.6%)341 🔴 (-25%) 💚19
STSO1020 steps (1001-1020)521 (+1.8%)596 🔴 (+2.8%)638 🔴 (-0.8%)660 🔴 (+1.4%)19
WO1020 steps407279 (+2.1%)407279 (+2.1%)407279 (+2.1%)407279 (+2.1%)1
SLstream latency116 (+33%) 🔻195 🔴 (+28%) 🔻235 🔴 (+19%) 🔻463 🔴 (+20%) 🔻30
SOstream overhead (text)118 (+1.7%)186 (-4.6%)225 (-54%) 💚293 (-61%) 💚30
SOstream overhead (structured)112 (+8.7%)176 (-17%) 💚216 (-15%)288 (-36%) 💚30
ℹ️ Metric definitions & methodology
Best/P75/P90/P99 deltas compare against the most recent benchmark run on main at the time of this run. 🔻 flags a delta worse than +15%, 💚 one better than −15%.
Metrics — TTFS: time to first step body (in-deployment start() → first step body, deployment clocks) · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (whole-run time outside step bodies, in-deployment anchored) · SL: stream latency (in-deployment write → read propagation, readAt - writtenAt) · SO: stream overhead (end-to-end write+consume time beyond the modelled generation window)
Scenarios — step: one trivial no-op step, no stream; no hooks, so the run stays in turbo mode (in-process fast path) · stream: one streaming step; no hooks, so the run stays in turbo mode (in-process fast path) · hook + stream: registers a hook before one step, which exits turbo mode (dispatch path) · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges, and WO is the whole-run overhead outside step bodies · stream latency: parallel reader/writer steps on a dedicated stream; SL is the in-deployment write->read propagation (readAt - writtenAt) · stream overhead (text): writer streams 300 variable-length text token deltas paced at 100/s for 3s (a haiku-size LLM's token throughput) while a parallel reader drains the whole stream; SO is the end-to-end write+consume time beyond the 3s generation window (overhead/backpressure) · stream overhead (structured): same workload as stream overhead (text), but each delta is an AI-SDK-style structured object ({ type: 'text-delta', id, text }) instead of a raw string, so the SO gap vs the text scenario is the added serialization cost
🔴 marks a percentile over its target (within target is left unmarked). Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · SO 250/500/1000 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120
All metrics are measured from deployment-side timestamps only. Runs are triggered by an in-deployment route that stamps the anchor (clientStart) right before start(), so the CI runner’s request and its path through api.vercel.com sit outside every measured window. TTFS = in-deployment start() → first step body (turbo uses the in-process fast path, non-turbo the dispatch path), and includes the VQS dispatch hop plus any /flow cold start. STSO/WO are measured between step bodies on the deployment. SL is measured inside the workflow (parallel reader/writer steps), so it no longer includes the api.vercel.com read path.
Cold starts are kept in the numbers on purpose — they are part of real bursty-workload latency. The workbench deployment cold-starts the /flow invocation for a large fraction of runs, inflating P75+; the Best column shows the fastest (warm-start) sample for comparison.
@TooTallNate
TooTallNate
enabled auto-merge (squash)
July 30, 2026 19:56
@TooTallNate
TooTallNate
merged commit 32ac8e7
into
mainJul 30, 2026

175 of 177 checks passed

@TooTallNate
TooTallNate
deleted the

lint/biome-vcs-ignore-and-ci

branch
July 30, 2026 22:32
@github-actions
github-actionsBot
commented
Jul 30, 2026

Copy link


Copy Markdown

Contributor
No backport to stable for 32ac8e7 (AI decision).
This is a repo-wide lint cleanup (import reordering, _-prefixing unused bindings, small refactors like the context-storage.ts IIFE and extractor.tsmatchAll() rewrite) plus a new biome ci gate and Biome config changes — all explicitly behavior-preserving, shipped with an empty changeset. Adding a new CI enforcement job and mechanically churning ~115 files is tooling/hygiene work, not a fix needed to keep stable buildable, testable, or releasable. The large mechanical diff also carries backport-conflict risk on a maintenance line for zero user-visible benefit.
To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:
32ac8e73fd42ce5b1b89ec243294b1f815e4b5e0

@VaguelySeriousVaguelySerious
mentioned this pull request
Jul 30, 2026
 Merged

@pranaygppranaygp
mentioned this pull request
Jul 30, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@VaguelySeriousVaguelySeriousVaguelySerious approved these changes
@ijjkijjkAwaiting requested review from ijjk

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@TooTallNate@VaguelySerious

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix Biome lint violations and add Biome CI check by TooTallNate · Pull Request #3222 · vercel/workflow · GitHub
Skip to content
Fix Biome lint violations and add Biome CI check - #3222
Merged
TooTallNate merged 2 commits into
mainfrom 
lint/biome-vcs-ignore-and-ci
Jul 30, 2026
Merged
Fix Biome lint violations and add Biome CI check#3222
TooTallNate merged 2 commits into
mainfrom 
lint/biome-vcs-ignore-and-ci
Conversation
@TooTallNate
@TooTallNateTooTallNate
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Summary
pnpm lint (biome check) was reporting 13,355 diagnostics (7,445 errors) and nobody was watching the output. This PR gets the repo to zero lint errors and adds a CI gate so it stays that way.
Root cause
Biome was not configured to respect .gitignore, so ~92% of all diagnostics came from gitignored build artifacts (packages/web/build, workbench/sveltekit/.svelte-kit, workbench/sveltekit/build, docs/.source, wasm pkg output).
Changes
biome.json
  • Enable vcs.useIgnoreFile so Biome skips gitignored files (13,355 → 921 diagnostics). This also keeps local runs consistent with CI, where those artifacts don't exist in a fresh checkout.
  • Fix stale $schema version (2.3.3 → 2.4.4, matching the pinned CLI).
  • Downgrade a11y rules (noSvgWithoutTitle, useSemanticElements, useKeyWithClickEvents, useFocusableInteractive, noStaticElementInteractions, noNoninteractiveElementToInteractiveRole) and security/noDangerouslySetInnerHtml from error → warn. The 30 hits are all in internal dev-tools UI / docs marketing components and need design-level fixes; this matches how the repo already treats noNonNullAssertion, useExhaustiveDependencies, etc.
Auto-fixes (~115 files)
  • biome check --write safe fixes: formatting, import ordering, useImportType, useConst, etc.
  • Targeted --unsafe --only=correctness/noUnusedVariables: _-prefixes for unused catch params and loop vars.
Manual fixes
  • 8 unused destructured bindings (test files + BenchmarkChart.tsx).
  • 3 noAssignInExpressions: context-storage.ts global-singleton init rewritten as an IIFE with ??=; writable-stream.ts cache init hoisted out of the expression; extractor.tswhile ((match = re.exec(...))) → matchAll().
  • 3 useIterableCallbackReturn: forEach arrow bodies wrapped in braces (context-violation-error.ts, @workflow/errors, workbench script).
  • 2 missing type="button" (workbench/nextjs-turbopack/app/app-shell.tsx).
CI
  • New biome job in .github/workflows/lint.yml running pnpm exec biome ci --max-diagnostics=200. Fails on errors, annotates PRs via the GitHub reporter, and uses the repo-pinned Biome version via pnpm.
What's left (non-blocking)
696 warnings and 58 infos remain visible in biome check output (mostly noExcessiveCognitiveComplexity, useTemplate, noNonNullAssertion — pre-existing warn-level rules). These do not fail biome ci.
Verification
  • pnpm lint / pnpm exec biome ci exit 0 (0 errors)
  • pnpm typecheck passes
  • Tests: packages/core src suite (1,652 passed), @workflow/errors (38), @workflow/docs-typecheck (1,255), @workflow/ai agent tests, and core src/step suites all green
  • Empty changeset included — all changes are behavior-preserving, so no release is needed; the code ships with the next regular release
Review notes
  • packages/core/src/serialization.ts: organize-imports merged two ./sealed-box.js import statements; both sealed-box.ts and get-world-lazy.ts are side-effect-free at module scope, so evaluation order is unaffected.
  • workbench/vitest/workflows/cookbook/saga.ts: entitlementId → _entitlementId — flagging in case that snippet is quoted verbatim in docs.
@TooTallNate
Fix Biome lint violations and add Biome CI check
f87e9b6
Biome was not configured to respect .gitignore, so ~92% of the 13,355
reported diagnostics came from gitignored build artifacts. Enable VCS
integration (useIgnoreFile), apply safe auto-fixes across the repo, fix
the remaining mechanical errors by hand, downgrade judgment-call a11y /
dangerouslySetInnerHTML rules to warnings, and add a 'biome ci' job to
the Lint workflow so violations block PRs going forward.
@TooTallNate
TooTallNate
requested review from
a team and ijjk
as code ownersJuly 30, 2026 19:38
CopilotAI
review requested due to automatic review settings
July 30, 2026 19:38
@TooTallNate
TooTallNate
requested a review
from a team
as a code ownerJuly 30, 2026 19:38
@vercel
vercelBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreviewJul 30, 2026 8:00pm
example-nextjs-workflow-webpackReadyReadyPreviewJul 30, 2026 8:00pm
example-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-astro-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-express-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-fastify-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-hono-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-nestjs-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-nitro-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-nuxt-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-sveltekit-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-tanstack-start-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-vite-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workflow-docsReadyReadyPreview, v0Jul 30, 2026 8:00pm
workflow-swc-playgroundReadyReadyPreviewJul 30, 2026 8:00pm
workflow-tarballsReadyReadyPreviewJul 30, 2026 8:00pm
workflow-webReadyReadyPreviewJul 30, 2026 8:00pm
@changeset-bot
changeset-botBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 40a973c
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
CopilotAI
reviewed
Jul 30, 2026
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
@github-actions
github-actionsBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
🧪 E2E Test Results
✅ All tests passed
E2E Test Summary
Summary
PassedFailedSkippedTotal
✅ ▲ Vercel Production145502391694
✅ 💻 Local Development162102271848
✅ 📦 Local Production162102271848
✅ 🐘 Local Postgres162102271848
✅ 🪟 Windows15400154
✅ 📋 Other102002121232
✅ vercel-multi-region270027
Total7519011328651
Details by Category
✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126028
✅ example126028
✅ express126028
✅ fastify126028
✅ hono126028
✅ nextjs-turbopack15103
✅ nextjs-webpack15103
✅ nitro126028
✅ nuxt126028
✅ sveltekit14509
✅ vite126028
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15400
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128026
✅ e2e-local-dev-tanstack-start-128026
✅ e2e-local-postgres-nest-stable128026
✅ e2e-local-postgres-tanstack-start-128026
✅ e2e-local-prod-nest-stable128026
✅ e2e-local-prod-tanstack-start-128026
✅ e2e-vercel-prod-nest126028
✅ e2e-vercel-prod-tanstack-start126028
✅ vercel-multi-region
AppPassedFailedSkipped
✅ nextjs-turbopack2700
📋 View full workflow run
@github-actions
github-actionsBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📊 Workflow Benchmarks
commit 40a973c · Thu, 30 Jul 2026 20:18:13 GMT · run logs
Backend: vercel · app: nextjs-turbopack
MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep1281 (+320%) 🔻1386 🔴 (+29%) 🔻1403 🔴 (+27%) 🔻1766 🔴 (+30%) 🔻30
TTFSstream245 (-75%) 💚1350 🔴 (+31%) 🔻1364 🔴 (+32%) 🔻1508 🔴 (+32%) 🔻30
TTFShook + stream1499 (+20%) 🔻1661 🔴 (+23%) 🔻1831 🔴 (+31%) 🔻5934 🔴 (+305%) 🔻30
STSO1020 steps (1-20)175 (+2.9%)282 🔴 (-8.4%)326 🔴 (-8.9%)332 🔴 (-25%) 💚19
STSO1020 steps (101-120)192 (-2.0%)269 🔴 (+5.9%)304 🔴 (+5.6%)341 🔴 (-25%) 💚19
STSO1020 steps (1001-1020)521 (+1.8%)596 🔴 (+2.8%)638 🔴 (-0.8%)660 🔴 (+1.4%)19
WO1020 steps407279 (+2.1%)407279 (+2.1%)407279 (+2.1%)407279 (+2.1%)1
SLstream latency116 (+33%) 🔻195 🔴 (+28%) 🔻235 🔴 (+19%) 🔻463 🔴 (+20%) 🔻30
SOstream overhead (text)118 (+1.7%)186 (-4.6%)225 (-54%) 💚293 (-61%) 💚30
SOstream overhead (structured)112 (+8.7%)176 (-17%) 💚216 (-15%)288 (-36%) 💚30
ℹ️ Metric definitions & methodology
Best/P75/P90/P99 deltas compare against the most recent benchmark run on main at the time of this run. 🔻 flags a delta worse than +15%, 💚 one better than −15%.
Metrics — TTFS: time to first step body (in-deployment start() → first step body, deployment clocks) · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (whole-run time outside step bodies, in-deployment anchored) · SL: stream latency (in-deployment write → read propagation, readAt - writtenAt) · SO: stream overhead (end-to-end write+consume time beyond the modelled generation window)
Scenarios — step: one trivial no-op step, no stream; no hooks, so the run stays in turbo mode (in-process fast path) · stream: one streaming step; no hooks, so the run stays in turbo mode (in-process fast path) · hook + stream: registers a hook before one step, which exits turbo mode (dispatch path) · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges, and WO is the whole-run overhead outside step bodies · stream latency: parallel reader/writer steps on a dedicated stream; SL is the in-deployment write->read propagation (readAt - writtenAt) · stream overhead (text): writer streams 300 variable-length text token deltas paced at 100/s for 3s (a haiku-size LLM's token throughput) while a parallel reader drains the whole stream; SO is the end-to-end write+consume time beyond the 3s generation window (overhead/backpressure) · stream overhead (structured): same workload as stream overhead (text), but each delta is an AI-SDK-style structured object ({ type: 'text-delta', id, text }) instead of a raw string, so the SO gap vs the text scenario is the added serialization cost
🔴 marks a percentile over its target (within target is left unmarked). Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · SO 250/500/1000 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120
All metrics are measured from deployment-side timestamps only. Runs are triggered by an in-deployment route that stamps the anchor (clientStart) right before start(), so the CI runner’s request and its path through api.vercel.com sit outside every measured window. TTFS = in-deployment start() → first step body (turbo uses the in-process fast path, non-turbo the dispatch path), and includes the VQS dispatch hop plus any /flow cold start. STSO/WO are measured between step bodies on the deployment. SL is measured inside the workflow (parallel reader/writer steps), so it no longer includes the api.vercel.com read path.
Cold starts are kept in the numbers on purpose — they are part of real bursty-workload latency. The workbench deployment cold-starts the /flow invocation for a large fraction of runs, inflating P75+; the Best column shows the fastest (warm-start) sample for comparison.
@TooTallNate
TooTallNate
enabled auto-merge (squash)
July 30, 2026 19:56
@TooTallNate
TooTallNate
merged commit 32ac8e7
into
mainJul 30, 2026

175 of 177 checks passed

@TooTallNate
TooTallNate
deleted the

lint/biome-vcs-ignore-and-ci

branch
July 30, 2026 22:32
@github-actions
github-actionsBot
commented
Jul 30, 2026

Copy link


Copy Markdown

Contributor
No backport to stable for 32ac8e7 (AI decision).
This is a repo-wide lint cleanup (import reordering, _-prefixing unused bindings, small refactors like the context-storage.ts IIFE and extractor.tsmatchAll() rewrite) plus a new biome ci gate and Biome config changes — all explicitly behavior-preserving, shipped with an empty changeset. Adding a new CI enforcement job and mechanically churning ~115 files is tooling/hygiene work, not a fix needed to keep stable buildable, testable, or releasable. The large mechanical diff also carries backport-conflict risk on a maintenance line for zero user-visible benefit.
To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:
32ac8e73fd42ce5b1b89ec243294b1f815e4b5e0

@VaguelySeriousVaguelySerious
mentioned this pull request
Jul 30, 2026
 Merged

@pranaygppranaygp
mentioned this pull request
Jul 30, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@VaguelySeriousVaguelySeriousVaguelySerious approved these changes
@ijjkijjkAwaiting requested review from ijjk

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@TooTallNate@VaguelySerious

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Fix Biome lint violations and add Biome CI check by TooTallNate · Pull Request #3222 · vercel/workflow · GitHub
Skip to content
Fix Biome lint violations and add Biome CI check - #3222
Merged
TooTallNate merged 2 commits into
mainfrom 
lint/biome-vcs-ignore-and-ci
Jul 30, 2026
Merged
Fix Biome lint violations and add Biome CI check#3222
TooTallNate merged 2 commits into
mainfrom 
lint/biome-vcs-ignore-and-ci
Conversation
@TooTallNate
@TooTallNateTooTallNate
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Summary
pnpm lint (biome check) was reporting 13,355 diagnostics (7,445 errors) and nobody was watching the output. This PR gets the repo to zero lint errors and adds a CI gate so it stays that way.
Root cause
Biome was not configured to respect .gitignore, so ~92% of all diagnostics came from gitignored build artifacts (packages/web/build, workbench/sveltekit/.svelte-kit, workbench/sveltekit/build, docs/.source, wasm pkg output).
Changes
biome.json
  • Enable vcs.useIgnoreFile so Biome skips gitignored files (13,355 → 921 diagnostics). This also keeps local runs consistent with CI, where those artifacts don't exist in a fresh checkout.
  • Fix stale $schema version (2.3.3 → 2.4.4, matching the pinned CLI).
  • Downgrade a11y rules (noSvgWithoutTitle, useSemanticElements, useKeyWithClickEvents, useFocusableInteractive, noStaticElementInteractions, noNoninteractiveElementToInteractiveRole) and security/noDangerouslySetInnerHtml from error → warn. The 30 hits are all in internal dev-tools UI / docs marketing components and need design-level fixes; this matches how the repo already treats noNonNullAssertion, useExhaustiveDependencies, etc.
Auto-fixes (~115 files)
  • biome check --write safe fixes: formatting, import ordering, useImportType, useConst, etc.
  • Targeted --unsafe --only=correctness/noUnusedVariables: _-prefixes for unused catch params and loop vars.
Manual fixes
  • 8 unused destructured bindings (test files + BenchmarkChart.tsx).
  • 3 noAssignInExpressions: context-storage.ts global-singleton init rewritten as an IIFE with ??=; writable-stream.ts cache init hoisted out of the expression; extractor.tswhile ((match = re.exec(...))) → matchAll().
  • 3 useIterableCallbackReturn: forEach arrow bodies wrapped in braces (context-violation-error.ts, @workflow/errors, workbench script).
  • 2 missing type="button" (workbench/nextjs-turbopack/app/app-shell.tsx).
CI
  • New biome job in .github/workflows/lint.yml running pnpm exec biome ci --max-diagnostics=200. Fails on errors, annotates PRs via the GitHub reporter, and uses the repo-pinned Biome version via pnpm.
What's left (non-blocking)
696 warnings and 58 infos remain visible in biome check output (mostly noExcessiveCognitiveComplexity, useTemplate, noNonNullAssertion — pre-existing warn-level rules). These do not fail biome ci.
Verification
  • pnpm lint / pnpm exec biome ci exit 0 (0 errors)
  • pnpm typecheck passes
  • Tests: packages/core src suite (1,652 passed), @workflow/errors (38), @workflow/docs-typecheck (1,255), @workflow/ai agent tests, and core src/step suites all green
  • Empty changeset included — all changes are behavior-preserving, so no release is needed; the code ships with the next regular release
Review notes
  • packages/core/src/serialization.ts: organize-imports merged two ./sealed-box.js import statements; both sealed-box.ts and get-world-lazy.ts are side-effect-free at module scope, so evaluation order is unaffected.
  • workbench/vitest/workflows/cookbook/saga.ts: entitlementId → _entitlementId — flagging in case that snippet is quoted verbatim in docs.
@TooTallNate
Fix Biome lint violations and add Biome CI check
f87e9b6
Biome was not configured to respect .gitignore, so ~92% of the 13,355
reported diagnostics came from gitignored build artifacts. Enable VCS
integration (useIgnoreFile), apply safe auto-fixes across the repo, fix
the remaining mechanical errors by hand, downgrade judgment-call a11y /
dangerouslySetInnerHTML rules to warnings, and add a 'biome ci' job to
the Lint workflow so violations block PRs going forward.
@TooTallNate
TooTallNate
requested review from
a team and ijjk
as code ownersJuly 30, 2026 19:38
CopilotAI
review requested due to automatic review settings
July 30, 2026 19:38
@TooTallNate
TooTallNate
requested a review
from a team
as a code ownerJuly 30, 2026 19:38
@vercel
vercelBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreviewJul 30, 2026 8:00pm
example-nextjs-workflow-webpackReadyReadyPreviewJul 30, 2026 8:00pm
example-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-astro-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-express-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-fastify-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-hono-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-nestjs-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-nitro-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-nuxt-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-sveltekit-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-tanstack-start-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-vite-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workflow-docsReadyReadyPreview, v0Jul 30, 2026 8:00pm
workflow-swc-playgroundReadyReadyPreviewJul 30, 2026 8:00pm
workflow-tarballsReadyReadyPreviewJul 30, 2026 8:00pm
workflow-webReadyReadyPreviewJul 30, 2026 8:00pm
@changeset-bot
changeset-botBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 40a973c
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
CopilotAI
reviewed
Jul 30, 2026
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
@github-actions
github-actionsBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
🧪 E2E Test Results
✅ All tests passed
E2E Test Summary
Summary
PassedFailedSkippedTotal
✅ ▲ Vercel Production145502391694
✅ 💻 Local Development162102271848
✅ 📦 Local Production162102271848
✅ 🐘 Local Postgres162102271848
✅ 🪟 Windows15400154
✅ 📋 Other102002121232
✅ vercel-multi-region270027
Total7519011328651
Details by Category
✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126028
✅ example126028
✅ express126028
✅ fastify126028
✅ hono126028
✅ nextjs-turbopack15103
✅ nextjs-webpack15103
✅ nitro126028
✅ nuxt126028
✅ sveltekit14509
✅ vite126028
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15400
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128026
✅ e2e-local-dev-tanstack-start-128026
✅ e2e-local-postgres-nest-stable128026
✅ e2e-local-postgres-tanstack-start-128026
✅ e2e-local-prod-nest-stable128026
✅ e2e-local-prod-tanstack-start-128026
✅ e2e-vercel-prod-nest126028
✅ e2e-vercel-prod-tanstack-start126028
✅ vercel-multi-region
AppPassedFailedSkipped
✅ nextjs-turbopack2700
📋 View full workflow run
@github-actions
github-actionsBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📊 Workflow Benchmarks
commit 40a973c · Thu, 30 Jul 2026 20:18:13 GMT · run logs
Backend: vercel · app: nextjs-turbopack
MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep1281 (+320%) 🔻1386 🔴 (+29%) 🔻1403 🔴 (+27%) 🔻1766 🔴 (+30%) 🔻30
TTFSstream245 (-75%) 💚1350 🔴 (+31%) 🔻1364 🔴 (+32%) 🔻1508 🔴 (+32%) 🔻30
TTFShook + stream1499 (+20%) 🔻1661 🔴 (+23%) 🔻1831 🔴 (+31%) 🔻5934 🔴 (+305%) 🔻30
STSO1020 steps (1-20)175 (+2.9%)282 🔴 (-8.4%)326 🔴 (-8.9%)332 🔴 (-25%) 💚19
STSO1020 steps (101-120)192 (-2.0%)269 🔴 (+5.9%)304 🔴 (+5.6%)341 🔴 (-25%) 💚19
STSO1020 steps (1001-1020)521 (+1.8%)596 🔴 (+2.8%)638 🔴 (-0.8%)660 🔴 (+1.4%)19
WO1020 steps407279 (+2.1%)407279 (+2.1%)407279 (+2.1%)407279 (+2.1%)1
SLstream latency116 (+33%) 🔻195 🔴 (+28%) 🔻235 🔴 (+19%) 🔻463 🔴 (+20%) 🔻30
SOstream overhead (text)118 (+1.7%)186 (-4.6%)225 (-54%) 💚293 (-61%) 💚30
SOstream overhead (structured)112 (+8.7%)176 (-17%) 💚216 (-15%)288 (-36%) 💚30
ℹ️ Metric definitions & methodology
Best/P75/P90/P99 deltas compare against the most recent benchmark run on main at the time of this run. 🔻 flags a delta worse than +15%, 💚 one better than −15%.
Metrics — TTFS: time to first step body (in-deployment start() → first step body, deployment clocks) · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (whole-run time outside step bodies, in-deployment anchored) · SL: stream latency (in-deployment write → read propagation, readAt - writtenAt) · SO: stream overhead (end-to-end write+consume time beyond the modelled generation window)
Scenarios — step: one trivial no-op step, no stream; no hooks, so the run stays in turbo mode (in-process fast path) · stream: one streaming step; no hooks, so the run stays in turbo mode (in-process fast path) · hook + stream: registers a hook before one step, which exits turbo mode (dispatch path) · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges, and WO is the whole-run overhead outside step bodies · stream latency: parallel reader/writer steps on a dedicated stream; SL is the in-deployment write->read propagation (readAt - writtenAt) · stream overhead (text): writer streams 300 variable-length text token deltas paced at 100/s for 3s (a haiku-size LLM's token throughput) while a parallel reader drains the whole stream; SO is the end-to-end write+consume time beyond the 3s generation window (overhead/backpressure) · stream overhead (structured): same workload as stream overhead (text), but each delta is an AI-SDK-style structured object ({ type: 'text-delta', id, text }) instead of a raw string, so the SO gap vs the text scenario is the added serialization cost
🔴 marks a percentile over its target (within target is left unmarked). Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · SO 250/500/1000 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120
All metrics are measured from deployment-side timestamps only. Runs are triggered by an in-deployment route that stamps the anchor (clientStart) right before start(), so the CI runner’s request and its path through api.vercel.com sit outside every measured window. TTFS = in-deployment start() → first step body (turbo uses the in-process fast path, non-turbo the dispatch path), and includes the VQS dispatch hop plus any /flow cold start. STSO/WO are measured between step bodies on the deployment. SL is measured inside the workflow (parallel reader/writer steps), so it no longer includes the api.vercel.com read path.
Cold starts are kept in the numbers on purpose — they are part of real bursty-workload latency. The workbench deployment cold-starts the /flow invocation for a large fraction of runs, inflating P75+; the Best column shows the fastest (warm-start) sample for comparison.
@TooTallNate
TooTallNate
enabled auto-merge (squash)
July 30, 2026 19:56
@TooTallNate
TooTallNate
merged commit 32ac8e7
into
mainJul 30, 2026

175 of 177 checks passed

@TooTallNate
TooTallNate
deleted the

lint/biome-vcs-ignore-and-ci

branch
July 30, 2026 22:32
@github-actions
github-actionsBot
commented
Jul 30, 2026

Copy link


Copy Markdown

Contributor
No backport to stable for 32ac8e7 (AI decision).
This is a repo-wide lint cleanup (import reordering, _-prefixing unused bindings, small refactors like the context-storage.ts IIFE and extractor.tsmatchAll() rewrite) plus a new biome ci gate and Biome config changes — all explicitly behavior-preserving, shipped with an empty changeset. Adding a new CI enforcement job and mechanically churning ~115 files is tooling/hygiene work, not a fix needed to keep stable buildable, testable, or releasable. The large mechanical diff also carries backport-conflict risk on a maintenance line for zero user-visible benefit.
To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:
32ac8e73fd42ce5b1b89ec243294b1f815e4b5e0

@VaguelySeriousVaguelySerious
mentioned this pull request
Jul 30, 2026
 Merged

@pranaygppranaygp
mentioned this pull request
Jul 30, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@VaguelySeriousVaguelySeriousVaguelySerious approved these changes
@ijjkijjkAwaiting requested review from ijjk

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@TooTallNate@VaguelySerious

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix Biome lint violations and add Biome CI check by TooTallNate · Pull Request #3222 · vercel/workflow · GitHub
Skip to content
Fix Biome lint violations and add Biome CI check - #3222
Merged
TooTallNate merged 2 commits into
mainfrom 
lint/biome-vcs-ignore-and-ci
Jul 30, 2026
Merged
Fix Biome lint violations and add Biome CI check#3222
TooTallNate merged 2 commits into
mainfrom 
lint/biome-vcs-ignore-and-ci
Conversation
@TooTallNate
@TooTallNateTooTallNate
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Summary
pnpm lint (biome check) was reporting 13,355 diagnostics (7,445 errors) and nobody was watching the output. This PR gets the repo to zero lint errors and adds a CI gate so it stays that way.
Root cause
Biome was not configured to respect .gitignore, so ~92% of all diagnostics came from gitignored build artifacts (packages/web/build, workbench/sveltekit/.svelte-kit, workbench/sveltekit/build, docs/.source, wasm pkg output).
Changes
biome.json
  • Enable vcs.useIgnoreFile so Biome skips gitignored files (13,355 → 921 diagnostics). This also keeps local runs consistent with CI, where those artifacts don't exist in a fresh checkout.
  • Fix stale $schema version (2.3.3 → 2.4.4, matching the pinned CLI).
  • Downgrade a11y rules (noSvgWithoutTitle, useSemanticElements, useKeyWithClickEvents, useFocusableInteractive, noStaticElementInteractions, noNoninteractiveElementToInteractiveRole) and security/noDangerouslySetInnerHtml from error → warn. The 30 hits are all in internal dev-tools UI / docs marketing components and need design-level fixes; this matches how the repo already treats noNonNullAssertion, useExhaustiveDependencies, etc.
Auto-fixes (~115 files)
  • biome check --write safe fixes: formatting, import ordering, useImportType, useConst, etc.
  • Targeted --unsafe --only=correctness/noUnusedVariables: _-prefixes for unused catch params and loop vars.
Manual fixes
  • 8 unused destructured bindings (test files + BenchmarkChart.tsx).
  • 3 noAssignInExpressions: context-storage.ts global-singleton init rewritten as an IIFE with ??=; writable-stream.ts cache init hoisted out of the expression; extractor.tswhile ((match = re.exec(...))) → matchAll().
  • 3 useIterableCallbackReturn: forEach arrow bodies wrapped in braces (context-violation-error.ts, @workflow/errors, workbench script).
  • 2 missing type="button" (workbench/nextjs-turbopack/app/app-shell.tsx).
CI
  • New biome job in .github/workflows/lint.yml running pnpm exec biome ci --max-diagnostics=200. Fails on errors, annotates PRs via the GitHub reporter, and uses the repo-pinned Biome version via pnpm.
What's left (non-blocking)
696 warnings and 58 infos remain visible in biome check output (mostly noExcessiveCognitiveComplexity, useTemplate, noNonNullAssertion — pre-existing warn-level rules). These do not fail biome ci.
Verification
  • pnpm lint / pnpm exec biome ci exit 0 (0 errors)
  • pnpm typecheck passes
  • Tests: packages/core src suite (1,652 passed), @workflow/errors (38), @workflow/docs-typecheck (1,255), @workflow/ai agent tests, and core src/step suites all green
  • Empty changeset included — all changes are behavior-preserving, so no release is needed; the code ships with the next regular release
Review notes
  • packages/core/src/serialization.ts: organize-imports merged two ./sealed-box.js import statements; both sealed-box.ts and get-world-lazy.ts are side-effect-free at module scope, so evaluation order is unaffected.
  • workbench/vitest/workflows/cookbook/saga.ts: entitlementId → _entitlementId — flagging in case that snippet is quoted verbatim in docs.
@TooTallNate
Fix Biome lint violations and add Biome CI check
f87e9b6
Biome was not configured to respect .gitignore, so ~92% of the 13,355
reported diagnostics came from gitignored build artifacts. Enable VCS
integration (useIgnoreFile), apply safe auto-fixes across the repo, fix
the remaining mechanical errors by hand, downgrade judgment-call a11y /
dangerouslySetInnerHTML rules to warnings, and add a 'biome ci' job to
the Lint workflow so violations block PRs going forward.
@TooTallNate
TooTallNate
requested review from
a team and ijjk
as code ownersJuly 30, 2026 19:38
CopilotAI
review requested due to automatic review settings
July 30, 2026 19:38
@TooTallNate
TooTallNate
requested a review
from a team
as a code ownerJuly 30, 2026 19:38
@vercel
vercelBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreviewJul 30, 2026 8:00pm
example-nextjs-workflow-webpackReadyReadyPreviewJul 30, 2026 8:00pm
example-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-astro-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-express-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-fastify-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-hono-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-nestjs-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-nitro-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-nuxt-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-sveltekit-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-tanstack-start-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-vite-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workflow-docsReadyReadyPreview, v0Jul 30, 2026 8:00pm
workflow-swc-playgroundReadyReadyPreviewJul 30, 2026 8:00pm
workflow-tarballsReadyReadyPreviewJul 30, 2026 8:00pm
workflow-webReadyReadyPreviewJul 30, 2026 8:00pm
@changeset-bot
changeset-botBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 40a973c
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
CopilotAI
reviewed
Jul 30, 2026
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
@github-actions
github-actionsBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
🧪 E2E Test Results
✅ All tests passed
E2E Test Summary
Summary
PassedFailedSkippedTotal
✅ ▲ Vercel Production145502391694
✅ 💻 Local Development162102271848
✅ 📦 Local Production162102271848
✅ 🐘 Local Postgres162102271848
✅ 🪟 Windows15400154
✅ 📋 Other102002121232
✅ vercel-multi-region270027
Total7519011328651
Details by Category
✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126028
✅ example126028
✅ express126028
✅ fastify126028
✅ hono126028
✅ nextjs-turbopack15103
✅ nextjs-webpack15103
✅ nitro126028
✅ nuxt126028
✅ sveltekit14509
✅ vite126028
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15400
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128026
✅ e2e-local-dev-tanstack-start-128026
✅ e2e-local-postgres-nest-stable128026
✅ e2e-local-postgres-tanstack-start-128026
✅ e2e-local-prod-nest-stable128026
✅ e2e-local-prod-tanstack-start-128026
✅ e2e-vercel-prod-nest126028
✅ e2e-vercel-prod-tanstack-start126028
✅ vercel-multi-region
AppPassedFailedSkipped
✅ nextjs-turbopack2700
📋 View full workflow run
@github-actions
github-actionsBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📊 Workflow Benchmarks
commit 40a973c · Thu, 30 Jul 2026 20:18:13 GMT · run logs
Backend: vercel · app: nextjs-turbopack
MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep1281 (+320%) 🔻1386 🔴 (+29%) 🔻1403 🔴 (+27%) 🔻1766 🔴 (+30%) 🔻30
TTFSstream245 (-75%) 💚1350 🔴 (+31%) 🔻1364 🔴 (+32%) 🔻1508 🔴 (+32%) 🔻30
TTFShook + stream1499 (+20%) 🔻1661 🔴 (+23%) 🔻1831 🔴 (+31%) 🔻5934 🔴 (+305%) 🔻30
STSO1020 steps (1-20)175 (+2.9%)282 🔴 (-8.4%)326 🔴 (-8.9%)332 🔴 (-25%) 💚19
STSO1020 steps (101-120)192 (-2.0%)269 🔴 (+5.9%)304 🔴 (+5.6%)341 🔴 (-25%) 💚19
STSO1020 steps (1001-1020)521 (+1.8%)596 🔴 (+2.8%)638 🔴 (-0.8%)660 🔴 (+1.4%)19
WO1020 steps407279 (+2.1%)407279 (+2.1%)407279 (+2.1%)407279 (+2.1%)1
SLstream latency116 (+33%) 🔻195 🔴 (+28%) 🔻235 🔴 (+19%) 🔻463 🔴 (+20%) 🔻30
SOstream overhead (text)118 (+1.7%)186 (-4.6%)225 (-54%) 💚293 (-61%) 💚30
SOstream overhead (structured)112 (+8.7%)176 (-17%) 💚216 (-15%)288 (-36%) 💚30
ℹ️ Metric definitions & methodology
Best/P75/P90/P99 deltas compare against the most recent benchmark run on main at the time of this run. 🔻 flags a delta worse than +15%, 💚 one better than −15%.
Metrics — TTFS: time to first step body (in-deployment start() → first step body, deployment clocks) · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (whole-run time outside step bodies, in-deployment anchored) · SL: stream latency (in-deployment write → read propagation, readAt - writtenAt) · SO: stream overhead (end-to-end write+consume time beyond the modelled generation window)
Scenarios — step: one trivial no-op step, no stream; no hooks, so the run stays in turbo mode (in-process fast path) · stream: one streaming step; no hooks, so the run stays in turbo mode (in-process fast path) · hook + stream: registers a hook before one step, which exits turbo mode (dispatch path) · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges, and WO is the whole-run overhead outside step bodies · stream latency: parallel reader/writer steps on a dedicated stream; SL is the in-deployment write->read propagation (readAt - writtenAt) · stream overhead (text): writer streams 300 variable-length text token deltas paced at 100/s for 3s (a haiku-size LLM's token throughput) while a parallel reader drains the whole stream; SO is the end-to-end write+consume time beyond the 3s generation window (overhead/backpressure) · stream overhead (structured): same workload as stream overhead (text), but each delta is an AI-SDK-style structured object ({ type: 'text-delta', id, text }) instead of a raw string, so the SO gap vs the text scenario is the added serialization cost
🔴 marks a percentile over its target (within target is left unmarked). Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · SO 250/500/1000 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120
All metrics are measured from deployment-side timestamps only. Runs are triggered by an in-deployment route that stamps the anchor (clientStart) right before start(), so the CI runner’s request and its path through api.vercel.com sit outside every measured window. TTFS = in-deployment start() → first step body (turbo uses the in-process fast path, non-turbo the dispatch path), and includes the VQS dispatch hop plus any /flow cold start. STSO/WO are measured between step bodies on the deployment. SL is measured inside the workflow (parallel reader/writer steps), so it no longer includes the api.vercel.com read path.
Cold starts are kept in the numbers on purpose — they are part of real bursty-workload latency. The workbench deployment cold-starts the /flow invocation for a large fraction of runs, inflating P75+; the Best column shows the fastest (warm-start) sample for comparison.
@TooTallNate
TooTallNate
enabled auto-merge (squash)
July 30, 2026 19:56
@TooTallNate
TooTallNate
merged commit 32ac8e7
into
mainJul 30, 2026

175 of 177 checks passed

@TooTallNate
TooTallNate
deleted the

lint/biome-vcs-ignore-and-ci

branch
July 30, 2026 22:32
@github-actions
github-actionsBot
commented
Jul 30, 2026

Copy link


Copy Markdown

Contributor
No backport to stable for 32ac8e7 (AI decision).
This is a repo-wide lint cleanup (import reordering, _-prefixing unused bindings, small refactors like the context-storage.ts IIFE and extractor.tsmatchAll() rewrite) plus a new biome ci gate and Biome config changes — all explicitly behavior-preserving, shipped with an empty changeset. Adding a new CI enforcement job and mechanically churning ~115 files is tooling/hygiene work, not a fix needed to keep stable buildable, testable, or releasable. The large mechanical diff also carries backport-conflict risk on a maintenance line for zero user-visible benefit.
To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:
32ac8e73fd42ce5b1b89ec243294b1f815e4b5e0

@VaguelySeriousVaguelySerious
mentioned this pull request
Jul 30, 2026
 Merged

@pranaygppranaygp
mentioned this pull request
Jul 30, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@VaguelySeriousVaguelySeriousVaguelySerious approved these changes
@ijjkijjkAwaiting requested review from ijjk

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@TooTallNate@VaguelySerious

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix Biome lint violations and add Biome CI check by TooTallNate · Pull Request #3222 · vercel/workflow · GitHub
Skip to content
Fix Biome lint violations and add Biome CI check - #3222
Merged
TooTallNate merged 2 commits into
mainfrom 
lint/biome-vcs-ignore-and-ci
Jul 30, 2026
Merged
Fix Biome lint violations and add Biome CI check#3222
TooTallNate merged 2 commits into
mainfrom 
lint/biome-vcs-ignore-and-ci
Conversation
@TooTallNate
@TooTallNateTooTallNate
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Summary
pnpm lint (biome check) was reporting 13,355 diagnostics (7,445 errors) and nobody was watching the output. This PR gets the repo to zero lint errors and adds a CI gate so it stays that way.
Root cause
Biome was not configured to respect .gitignore, so ~92% of all diagnostics came from gitignored build artifacts (packages/web/build, workbench/sveltekit/.svelte-kit, workbench/sveltekit/build, docs/.source, wasm pkg output).
Changes
biome.json
  • Enable vcs.useIgnoreFile so Biome skips gitignored files (13,355 → 921 diagnostics). This also keeps local runs consistent with CI, where those artifacts don't exist in a fresh checkout.
  • Fix stale $schema version (2.3.3 → 2.4.4, matching the pinned CLI).
  • Downgrade a11y rules (noSvgWithoutTitle, useSemanticElements, useKeyWithClickEvents, useFocusableInteractive, noStaticElementInteractions, noNoninteractiveElementToInteractiveRole) and security/noDangerouslySetInnerHtml from error → warn. The 30 hits are all in internal dev-tools UI / docs marketing components and need design-level fixes; this matches how the repo already treats noNonNullAssertion, useExhaustiveDependencies, etc.
Auto-fixes (~115 files)
  • biome check --write safe fixes: formatting, import ordering, useImportType, useConst, etc.
  • Targeted --unsafe --only=correctness/noUnusedVariables: _-prefixes for unused catch params and loop vars.
Manual fixes
  • 8 unused destructured bindings (test files + BenchmarkChart.tsx).
  • 3 noAssignInExpressions: context-storage.ts global-singleton init rewritten as an IIFE with ??=; writable-stream.ts cache init hoisted out of the expression; extractor.tswhile ((match = re.exec(...))) → matchAll().
  • 3 useIterableCallbackReturn: forEach arrow bodies wrapped in braces (context-violation-error.ts, @workflow/errors, workbench script).
  • 2 missing type="button" (workbench/nextjs-turbopack/app/app-shell.tsx).
CI
  • New biome job in .github/workflows/lint.yml running pnpm exec biome ci --max-diagnostics=200. Fails on errors, annotates PRs via the GitHub reporter, and uses the repo-pinned Biome version via pnpm.
What's left (non-blocking)
696 warnings and 58 infos remain visible in biome check output (mostly noExcessiveCognitiveComplexity, useTemplate, noNonNullAssertion — pre-existing warn-level rules). These do not fail biome ci.
Verification
  • pnpm lint / pnpm exec biome ci exit 0 (0 errors)
  • pnpm typecheck passes
  • Tests: packages/core src suite (1,652 passed), @workflow/errors (38), @workflow/docs-typecheck (1,255), @workflow/ai agent tests, and core src/step suites all green
  • Empty changeset included — all changes are behavior-preserving, so no release is needed; the code ships with the next regular release
Review notes
  • packages/core/src/serialization.ts: organize-imports merged two ./sealed-box.js import statements; both sealed-box.ts and get-world-lazy.ts are side-effect-free at module scope, so evaluation order is unaffected.
  • workbench/vitest/workflows/cookbook/saga.ts: entitlementId → _entitlementId — flagging in case that snippet is quoted verbatim in docs.
@TooTallNate
Fix Biome lint violations and add Biome CI check
f87e9b6
Biome was not configured to respect .gitignore, so ~92% of the 13,355
reported diagnostics came from gitignored build artifacts. Enable VCS
integration (useIgnoreFile), apply safe auto-fixes across the repo, fix
the remaining mechanical errors by hand, downgrade judgment-call a11y /
dangerouslySetInnerHTML rules to warnings, and add a 'biome ci' job to
the Lint workflow so violations block PRs going forward.
@TooTallNate
TooTallNate
requested review from
a team and ijjk
as code ownersJuly 30, 2026 19:38
CopilotAI
review requested due to automatic review settings
July 30, 2026 19:38
@TooTallNate
TooTallNate
requested a review
from a team
as a code ownerJuly 30, 2026 19:38
@vercel
vercelBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreviewJul 30, 2026 8:00pm
example-nextjs-workflow-webpackReadyReadyPreviewJul 30, 2026 8:00pm
example-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-astro-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-express-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-fastify-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-hono-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-nestjs-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-nitro-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-nuxt-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-sveltekit-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-tanstack-start-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-vite-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workflow-docsReadyReadyPreview, v0Jul 30, 2026 8:00pm
workflow-swc-playgroundReadyReadyPreviewJul 30, 2026 8:00pm
workflow-tarballsReadyReadyPreviewJul 30, 2026 8:00pm
workflow-webReadyReadyPreviewJul 30, 2026 8:00pm
@changeset-bot
changeset-botBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 40a973c
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
CopilotAI
reviewed
Jul 30, 2026
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
@github-actions
github-actionsBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
🧪 E2E Test Results
✅ All tests passed
E2E Test Summary
Summary
PassedFailedSkippedTotal
✅ ▲ Vercel Production145502391694
✅ 💻 Local Development162102271848
✅ 📦 Local Production162102271848
✅ 🐘 Local Postgres162102271848
✅ 🪟 Windows15400154
✅ 📋 Other102002121232
✅ vercel-multi-region270027
Total7519011328651
Details by Category
✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126028
✅ example126028
✅ express126028
✅ fastify126028
✅ hono126028
✅ nextjs-turbopack15103
✅ nextjs-webpack15103
✅ nitro126028
✅ nuxt126028
✅ sveltekit14509
✅ vite126028
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15400
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128026
✅ e2e-local-dev-tanstack-start-128026
✅ e2e-local-postgres-nest-stable128026
✅ e2e-local-postgres-tanstack-start-128026
✅ e2e-local-prod-nest-stable128026
✅ e2e-local-prod-tanstack-start-128026
✅ e2e-vercel-prod-nest126028
✅ e2e-vercel-prod-tanstack-start126028
✅ vercel-multi-region
AppPassedFailedSkipped
✅ nextjs-turbopack2700
📋 View full workflow run
@github-actions
github-actionsBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📊 Workflow Benchmarks
commit 40a973c · Thu, 30 Jul 2026 20:18:13 GMT · run logs
Backend: vercel · app: nextjs-turbopack
MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep1281 (+320%) 🔻1386 🔴 (+29%) 🔻1403 🔴 (+27%) 🔻1766 🔴 (+30%) 🔻30
TTFSstream245 (-75%) 💚1350 🔴 (+31%) 🔻1364 🔴 (+32%) 🔻1508 🔴 (+32%) 🔻30
TTFShook + stream1499 (+20%) 🔻1661 🔴 (+23%) 🔻1831 🔴 (+31%) 🔻5934 🔴 (+305%) 🔻30
STSO1020 steps (1-20)175 (+2.9%)282 🔴 (-8.4%)326 🔴 (-8.9%)332 🔴 (-25%) 💚19
STSO1020 steps (101-120)192 (-2.0%)269 🔴 (+5.9%)304 🔴 (+5.6%)341 🔴 (-25%) 💚19
STSO1020 steps (1001-1020)521 (+1.8%)596 🔴 (+2.8%)638 🔴 (-0.8%)660 🔴 (+1.4%)19
WO1020 steps407279 (+2.1%)407279 (+2.1%)407279 (+2.1%)407279 (+2.1%)1
SLstream latency116 (+33%) 🔻195 🔴 (+28%) 🔻235 🔴 (+19%) 🔻463 🔴 (+20%) 🔻30
SOstream overhead (text)118 (+1.7%)186 (-4.6%)225 (-54%) 💚293 (-61%) 💚30
SOstream overhead (structured)112 (+8.7%)176 (-17%) 💚216 (-15%)288 (-36%) 💚30
ℹ️ Metric definitions & methodology
Best/P75/P90/P99 deltas compare against the most recent benchmark run on main at the time of this run. 🔻 flags a delta worse than +15%, 💚 one better than −15%.
Metrics — TTFS: time to first step body (in-deployment start() → first step body, deployment clocks) · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (whole-run time outside step bodies, in-deployment anchored) · SL: stream latency (in-deployment write → read propagation, readAt - writtenAt) · SO: stream overhead (end-to-end write+consume time beyond the modelled generation window)
Scenarios — step: one trivial no-op step, no stream; no hooks, so the run stays in turbo mode (in-process fast path) · stream: one streaming step; no hooks, so the run stays in turbo mode (in-process fast path) · hook + stream: registers a hook before one step, which exits turbo mode (dispatch path) · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges, and WO is the whole-run overhead outside step bodies · stream latency: parallel reader/writer steps on a dedicated stream; SL is the in-deployment write->read propagation (readAt - writtenAt) · stream overhead (text): writer streams 300 variable-length text token deltas paced at 100/s for 3s (a haiku-size LLM's token throughput) while a parallel reader drains the whole stream; SO is the end-to-end write+consume time beyond the 3s generation window (overhead/backpressure) · stream overhead (structured): same workload as stream overhead (text), but each delta is an AI-SDK-style structured object ({ type: 'text-delta', id, text }) instead of a raw string, so the SO gap vs the text scenario is the added serialization cost
🔴 marks a percentile over its target (within target is left unmarked). Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · SO 250/500/1000 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120
All metrics are measured from deployment-side timestamps only. Runs are triggered by an in-deployment route that stamps the anchor (clientStart) right before start(), so the CI runner’s request and its path through api.vercel.com sit outside every measured window. TTFS = in-deployment start() → first step body (turbo uses the in-process fast path, non-turbo the dispatch path), and includes the VQS dispatch hop plus any /flow cold start. STSO/WO are measured between step bodies on the deployment. SL is measured inside the workflow (parallel reader/writer steps), so it no longer includes the api.vercel.com read path.
Cold starts are kept in the numbers on purpose — they are part of real bursty-workload latency. The workbench deployment cold-starts the /flow invocation for a large fraction of runs, inflating P75+; the Best column shows the fastest (warm-start) sample for comparison.
@TooTallNate
TooTallNate
enabled auto-merge (squash)
July 30, 2026 19:56
@TooTallNate
TooTallNate
merged commit 32ac8e7
into
mainJul 30, 2026

175 of 177 checks passed

@TooTallNate
TooTallNate
deleted the

lint/biome-vcs-ignore-and-ci

branch
July 30, 2026 22:32
@github-actions
github-actionsBot
commented
Jul 30, 2026

Copy link


Copy Markdown

Contributor
No backport to stable for 32ac8e7 (AI decision).
This is a repo-wide lint cleanup (import reordering, _-prefixing unused bindings, small refactors like the context-storage.ts IIFE and extractor.tsmatchAll() rewrite) plus a new biome ci gate and Biome config changes — all explicitly behavior-preserving, shipped with an empty changeset. Adding a new CI enforcement job and mechanically churning ~115 files is tooling/hygiene work, not a fix needed to keep stable buildable, testable, or releasable. The large mechanical diff also carries backport-conflict risk on a maintenance line for zero user-visible benefit.
To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:
32ac8e73fd42ce5b1b89ec243294b1f815e4b5e0

@VaguelySeriousVaguelySerious
mentioned this pull request
Jul 30, 2026
 Merged

@pranaygppranaygp
mentioned this pull request
Jul 30, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@VaguelySeriousVaguelySeriousVaguelySerious approved these changes
@ijjkijjkAwaiting requested review from ijjk

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@TooTallNate@VaguelySerious

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Fix Biome lint violations and add Biome CI check by TooTallNate · Pull Request #3222 · vercel/workflow · GitHub
Skip to content
Fix Biome lint violations and add Biome CI check - #3222
Merged
TooTallNate merged 2 commits into
mainfrom 
lint/biome-vcs-ignore-and-ci
Jul 30, 2026
Merged
Fix Biome lint violations and add Biome CI check#3222
TooTallNate merged 2 commits into
mainfrom 
lint/biome-vcs-ignore-and-ci
Conversation
@TooTallNate
@TooTallNateTooTallNate
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Summary
pnpm lint (biome check) was reporting 13,355 diagnostics (7,445 errors) and nobody was watching the output. This PR gets the repo to zero lint errors and adds a CI gate so it stays that way.
Root cause
Biome was not configured to respect .gitignore, so ~92% of all diagnostics came from gitignored build artifacts (packages/web/build, workbench/sveltekit/.svelte-kit, workbench/sveltekit/build, docs/.source, wasm pkg output).
Changes
biome.json
  • Enable vcs.useIgnoreFile so Biome skips gitignored files (13,355 → 921 diagnostics). This also keeps local runs consistent with CI, where those artifacts don't exist in a fresh checkout.
  • Fix stale $schema version (2.3.3 → 2.4.4, matching the pinned CLI).
  • Downgrade a11y rules (noSvgWithoutTitle, useSemanticElements, useKeyWithClickEvents, useFocusableInteractive, noStaticElementInteractions, noNoninteractiveElementToInteractiveRole) and security/noDangerouslySetInnerHtml from error → warn. The 30 hits are all in internal dev-tools UI / docs marketing components and need design-level fixes; this matches how the repo already treats noNonNullAssertion, useExhaustiveDependencies, etc.
Auto-fixes (~115 files)
  • biome check --write safe fixes: formatting, import ordering, useImportType, useConst, etc.
  • Targeted --unsafe --only=correctness/noUnusedVariables: _-prefixes for unused catch params and loop vars.
Manual fixes
  • 8 unused destructured bindings (test files + BenchmarkChart.tsx).
  • 3 noAssignInExpressions: context-storage.ts global-singleton init rewritten as an IIFE with ??=; writable-stream.ts cache init hoisted out of the expression; extractor.tswhile ((match = re.exec(...))) → matchAll().
  • 3 useIterableCallbackReturn: forEach arrow bodies wrapped in braces (context-violation-error.ts, @workflow/errors, workbench script).
  • 2 missing type="button" (workbench/nextjs-turbopack/app/app-shell.tsx).
CI
  • New biome job in .github/workflows/lint.yml running pnpm exec biome ci --max-diagnostics=200. Fails on errors, annotates PRs via the GitHub reporter, and uses the repo-pinned Biome version via pnpm.
What's left (non-blocking)
696 warnings and 58 infos remain visible in biome check output (mostly noExcessiveCognitiveComplexity, useTemplate, noNonNullAssertion — pre-existing warn-level rules). These do not fail biome ci.
Verification
  • pnpm lint / pnpm exec biome ci exit 0 (0 errors)
  • pnpm typecheck passes
  • Tests: packages/core src suite (1,652 passed), @workflow/errors (38), @workflow/docs-typecheck (1,255), @workflow/ai agent tests, and core src/step suites all green
  • Empty changeset included — all changes are behavior-preserving, so no release is needed; the code ships with the next regular release
Review notes
  • packages/core/src/serialization.ts: organize-imports merged two ./sealed-box.js import statements; both sealed-box.ts and get-world-lazy.ts are side-effect-free at module scope, so evaluation order is unaffected.
  • workbench/vitest/workflows/cookbook/saga.ts: entitlementId → _entitlementId — flagging in case that snippet is quoted verbatim in docs.
@TooTallNate
Fix Biome lint violations and add Biome CI check
f87e9b6
Biome was not configured to respect .gitignore, so ~92% of the 13,355
reported diagnostics came from gitignored build artifacts. Enable VCS
integration (useIgnoreFile), apply safe auto-fixes across the repo, fix
the remaining mechanical errors by hand, downgrade judgment-call a11y /
dangerouslySetInnerHTML rules to warnings, and add a 'biome ci' job to
the Lint workflow so violations block PRs going forward.
@TooTallNate
TooTallNate
requested review from
a team and ijjk
as code ownersJuly 30, 2026 19:38
CopilotAI
review requested due to automatic review settings
July 30, 2026 19:38
@TooTallNate
TooTallNate
requested a review
from a team
as a code ownerJuly 30, 2026 19:38
@vercel
vercelBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreviewJul 30, 2026 8:00pm
example-nextjs-workflow-webpackReadyReadyPreviewJul 30, 2026 8:00pm
example-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-astro-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-express-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-fastify-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-hono-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-nestjs-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-nitro-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-nuxt-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-sveltekit-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-tanstack-start-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workbench-vite-workflowReadyReadyPreviewJul 30, 2026 8:00pm
workflow-docsReadyReadyPreview, v0Jul 30, 2026 8:00pm
workflow-swc-playgroundReadyReadyPreviewJul 30, 2026 8:00pm
workflow-tarballsReadyReadyPreviewJul 30, 2026 8:00pm
workflow-webReadyReadyPreviewJul 30, 2026 8:00pm
@changeset-bot
changeset-botBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 40a973c
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
CopilotAI
reviewed
Jul 30, 2026
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
@github-actions
github-actionsBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
🧪 E2E Test Results
✅ All tests passed
E2E Test Summary
Summary
PassedFailedSkippedTotal
✅ ▲ Vercel Production145502391694
✅ 💻 Local Development162102271848
✅ 📦 Local Production162102271848
✅ 🐘 Local Postgres162102271848
✅ 🪟 Windows15400154
✅ 📋 Other102002121232
✅ vercel-multi-region270027
Total7519011328651
Details by Category
✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro126028
✅ example126028
✅ express126028
✅ fastify126028
✅ hono126028
✅ nextjs-turbopack15103
✅ nextjs-webpack15103
✅ nitro126028
✅ nuxt126028
✅ sveltekit14509
✅ vite126028
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable128026
✅ express-stable128026
✅ fastify-stable128026
✅ hono-stable128026
✅ nextjs-turbopack-canary135019
✅ nextjs-turbopack-stable15400
✅ nextjs-webpack-canary135019
✅ nextjs-webpack-stable15400
✅ nitro-stable128026
✅ nuxt-stable128026
✅ sveltekit-stable14707
✅ vite-stable128026
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack15400
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable128026
✅ e2e-local-dev-tanstack-start-128026
✅ e2e-local-postgres-nest-stable128026
✅ e2e-local-postgres-tanstack-start-128026
✅ e2e-local-prod-nest-stable128026
✅ e2e-local-prod-tanstack-start-128026
✅ e2e-vercel-prod-nest126028
✅ e2e-vercel-prod-tanstack-start126028
✅ vercel-multi-region
AppPassedFailedSkipped
✅ nextjs-turbopack2700
📋 View full workflow run
@github-actions
github-actionsBot
commented
Jul 30, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📊 Workflow Benchmarks
commit 40a973c · Thu, 30 Jul 2026 20:18:13 GMT · run logs
Backend: vercel · app: nextjs-turbopack
MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep1281 (+320%) 🔻1386 🔴 (+29%) 🔻1403 🔴 (+27%) 🔻1766 🔴 (+30%) 🔻30
TTFSstream245 (-75%) 💚1350 🔴 (+31%) 🔻1364 🔴 (+32%) 🔻1508 🔴 (+32%) 🔻30
TTFShook + stream1499 (+20%) 🔻1661 🔴 (+23%) 🔻1831 🔴 (+31%) 🔻5934 🔴 (+305%) 🔻30
STSO1020 steps (1-20)175 (+2.9%)282 🔴 (-8.4%)326 🔴 (-8.9%)332 🔴 (-25%) 💚19
STSO1020 steps (101-120)192 (-2.0%)269 🔴 (+5.9%)304 🔴 (+5.6%)341 🔴 (-25%) 💚19
STSO1020 steps (1001-1020)521 (+1.8%)596 🔴 (+2.8%)638 🔴 (-0.8%)660 🔴 (+1.4%)19
WO1020 steps407279 (+2.1%)407279 (+2.1%)407279 (+2.1%)407279 (+2.1%)1
SLstream latency116 (+33%) 🔻195 🔴 (+28%) 🔻235 🔴 (+19%) 🔻463 🔴 (+20%) 🔻30
SOstream overhead (text)118 (+1.7%)186 (-4.6%)225 (-54%) 💚293 (-61%) 💚30
SOstream overhead (structured)112 (+8.7%)176 (-17%) 💚216 (-15%)288 (-36%) 💚30
ℹ️ Metric definitions & methodology
Best/P75/P90/P99 deltas compare against the most recent benchmark run on main at the time of this run. 🔻 flags a delta worse than +15%, 💚 one better than −15%.
Metrics — TTFS: time to first step body (in-deployment start() → first step body, deployment clocks) · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (whole-run time outside step bodies, in-deployment anchored) · SL: stream latency (in-deployment write → read propagation, readAt - writtenAt) · SO: stream overhead (end-to-end write+consume time beyond the modelled generation window)
Scenarios — step: one trivial no-op step, no stream; no hooks, so the run stays in turbo mode (in-process fast path) · stream: one streaming step; no hooks, so the run stays in turbo mode (in-process fast path) · hook + stream: registers a hook before one step, which exits turbo mode (dispatch path) · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges, and WO is the whole-run overhead outside step bodies · stream latency: parallel reader/writer steps on a dedicated stream; SL is the in-deployment write->read propagation (readAt - writtenAt) · stream overhead (text): writer streams 300 variable-length text token deltas paced at 100/s for 3s (a haiku-size LLM's token throughput) while a parallel reader drains the whole stream; SO is the end-to-end write+consume time beyond the 3s generation window (overhead/backpressure) · stream overhead (structured): same workload as stream overhead (text), but each delta is an AI-SDK-style structured object ({ type: 'text-delta', id, text }) instead of a raw string, so the SO gap vs the text scenario is the added serialization cost
🔴 marks a percentile over its target (within target is left unmarked). Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · SO 250/500/1000 · STSO (1-20) 20/30/60 · STSO (101-120) 30/45/90 · STSO (1001-1020) 40/60/120
All metrics are measured from deployment-side timestamps only. Runs are triggered by an in-deployment route that stamps the anchor (clientStart) right before start(), so the CI runner’s request and its path through api.vercel.com sit outside every measured window. TTFS = in-deployment start() → first step body (turbo uses the in-process fast path, non-turbo the dispatch path), and includes the VQS dispatch hop plus any /flow cold start. STSO/WO are measured between step bodies on the deployment. SL is measured inside the workflow (parallel reader/writer steps), so it no longer includes the api.vercel.com read path.
Cold starts are kept in the numbers on purpose — they are part of real bursty-workload latency. The workbench deployment cold-starts the /flow invocation for a large fraction of runs, inflating P75+; the Best column shows the fastest (warm-start) sample for comparison.
@TooTallNate
TooTallNate
enabled auto-merge (squash)
July 30, 2026 19:56
@TooTallNate
TooTallNate
merged commit 32ac8e7
into
mainJul 30, 2026

175 of 177 checks passed

@TooTallNate
TooTallNate
deleted the

lint/biome-vcs-ignore-and-ci

branch
July 30, 2026 22:32
@github-actions
github-actionsBot
commented
Jul 30, 2026

Copy link


Copy Markdown

Contributor
No backport to stable for 32ac8e7 (AI decision).
This is a repo-wide lint cleanup (import reordering, _-prefixing unused bindings, small refactors like the context-storage.ts IIFE and extractor.tsmatchAll() rewrite) plus a new biome ci gate and Biome config changes — all explicitly behavior-preserving, shipped with an empty changeset. Adding a new CI enforcement job and mechanically churning ~115 files is tooling/hygiene work, not a fix needed to keep stable buildable, testable, or releasable. The large mechanical diff also carries backport-conflict risk on a maintenance line for zero user-visible benefit.
To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:
32ac8e73fd42ce5b1b89ec243294b1f815e4b5e0

@VaguelySeriousVaguelySerious
mentioned this pull request
Jul 30, 2026
 Merged

@pranaygppranaygp
mentioned this pull request
Jul 30, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@VaguelySeriousVaguelySeriousVaguelySerious approved these changes
@ijjkijjkAwaiting requested review from ijjk

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@TooTallNate@VaguelySerious