Uh oh!
There was an error while loading. Please reload this page.
[repro] Bisect: known-good base + #3190 only - #3239
Closed
pranaygp wants to merge 1 commit into
Closed
Conversation
(cherry picked from commit 34975f6) Signed-off-by: Pranay Prakash <pranay.gp@gmail.com>
🦋 Changeset detectedLatest commit: b194678 The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
This PR is a “bisect companion” that isolates the #3190 change set on top of a known-good base, focusing specifically on @workflow/world-vercel’s events-path HTTP/2 transport behavior (multiplexing) and documenting the related runtime tuning knob.
Changes:
- Split shared undici agent options so
pipeliningis configured per-agent (H1 default vs H2 events multiplexing vs H2 stream write isolation). - Add an undici dispatcher interceptor (
h2MultiplexInterceptor) and event/stream dispatcher factory functions to ensure H2 multiplexing actually happens for events traffic while keeping stream writes serialized. - Add loopback HTTP/2 multiplexing regression tests, document
WORKFLOW_H2_MULTIPLEX, and include a changeset for@workflow/world-vercel.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/world-vercel/src/http-client.ts | Introduces per-agent pipelining config, an H2 multiplexing interceptor, and dispatcher factories to ensure events traffic multiplexes while stream writes remain isolated. |
| packages/world-vercel/src/http-client.test.ts | Adds regression tests that measure true HTTP/2 multiplexing behavior (streams/connections) and validates retry + kill-switch behavior. |
| docs/content/docs/v5/configuration/runtime-tuning.mdx | Documents the WORKFLOW_H2_MULTIPLEX runtime tuning flag for the Vercel World. |
| .changeset/h2-events-multiplexing.md | Declares a patch changeset for the world-vercel transport behavior change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storm bisect companion (see the #3198-only PR): known-good e8934ad + cherry-pick of #3190 (world-vercel HTTP/2 events-path multiplexing) ONLY. Transport-timing change on the exact path this corruption class is sensitive to. Known-good base measured hook-storm 145/600 (run 30494191064). Not for merge.
🤖 Generated with Claude Code