Skip to content

feat(core): mirror replay lineage into a reserved $replayedFromRunId attribute - #3329

Draft
mitul-s wants to merge 2 commits into
mainfrom
mitul/replay-lineage-attribute
Draft

feat(core): mirror replay lineage into a reserved $replayedFromRunId attribute#3329
mitul-s wants to merge 2 commits into
mainfrom
mitul/replay-lineage-attribute

Conversation

@mitul-s

Copy link
Copy Markdown
Contributor

Summary

recreateRunFromExisting records its source run only on the new run's executionContext (replayedFromRunId, #2872). Attribute-indexed observability stores never see executionContext — the ClickHouse workflow_run_attributes table behind the Vercel dashboard's runs list only carries run attributes — so surfacing "which runs are replays" in a list currently requires a per-run world read (see vercel/front#79769, which fans out runs.getMany for every listed page).

This mirrors the replay lineage into the reserved $replayedFromRunId attribute, riding the exact mechanism $rootRunId/$parentRunId already use:

  • @workflow/world: export REPLAYED_FROM_RUN_ID_ATTRIBUTE ($replayedFromRunId) alongside the existing lineage attribute keys.
  • @workflow/corestart(): when replayedFromRunId is set and the spec version supports native attributes (v4+), seed the attribute on both the run_created event and the resilient-start queue input (with allowReservedAttributes, like parent lineage). Pre-v4 runs skip the attribute silently and keep the unconditional executionContext record, so replaying an old run never fails.
  • Validation of replayedFromRunId now runs before the attribute seed is composed; behavior is otherwise unchanged (a plain start() still emits no attributes field at all).

Once ingested, the dashboard's runs list can serve replay lineage straight from the attributes table and drop the per-run world fan-out.

Testing

  • packages/core: pnpm vitest run src/runtime/start.test.ts src/runtime/runs.test.ts — 82 passed, including new coverage: attribute seeded on both payloads, merges with caller attributes (caller keys last), skipped on pre-v4 spec with executionContext intact, and no empty attributes object on plain starts.
  • packages/world: full unit suite — 84 passed.
  • Biome and tsc show no new findings (the quickjs-runtime.ts typecheck errors and complexity warnings exist on main).

Made with Cursor

…attribute
recreateRunFromExisting records its source run only in the new run's
executionContext, which attribute-indexed observability stores (e.g. the
ClickHouse workflow_run_attributes table behind the dashboard runs list)
never see — so surfacing 'which runs are replays' in a list requires a
per-run world read. Seed the same value as the reserved
$replayedFromRunId attribute (like $rootRunId/$parentRunId) on worlds
with native attributes; pre-v4 spec versions skip the attribute silently
and keep the executionContext record.
Co-authored-by: Cursor <cursoragent@cursor.com>
@mitul-s
mitul-s requested a review from a team as a code ownerAugust 4, 2026 17:43
@vercel

vercelBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

changeset-botBot commented Aug 4, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1f2440a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@workflow/coreMinor
@workflow/worldMinor
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
workflowMinor
@workflow/world-testingPatch
@workflow/world-localPatch
@workflow/world-postgresPatch
@workflow/world-vercelPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

Some tests failed

❌ Failed E2E Tests

▲ Vercel Production (1 failed)

nextjs-webpack-node (1 failed):

  • outputStreamWorkflow positive startIndex (skips first chunk)
💻 Local Development (11 failed)

astro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

express-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

fastify-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

hono-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nitro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nuxt-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

sveltekit-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

vite-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable
📦 Local Production (13 failed)

astro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

express-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

fastify-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

hono-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nitro-stable-node (1 failed):

  • webhookWorkflow | wrun_41KZ6ZPQSC0GP0M9EQ9JGAEX80

nitro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nuxt-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

sveltekit-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

vite-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable
🐘 Local Postgres (12 failed)

astro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

express-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

fastify-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

hono-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nitro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nuxt-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

sveltekit-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

vite-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

🪟 Windows (1 failed)

nextjs-turbopack-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

📋 Other (6 failed)

e2e-local-dev-nest-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-dev-tanstack-start-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-postgres-nest-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-postgres-tanstack-start-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-prod-nest-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-prod-tanstack-start-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

E2E Test Summary

Summary
PassedFailedSkippedTotal
❌ ▲ Vercel Production277914963276
❌ 💻 Local Development3142114353588
❌ 📦 Local Production3277134543744
❌ 🐘 Local Postgres3278124543744
❌ 🪟 Windows31110312
❌ 📋 Other206264282496
✅ vercel-multi-region270027
Total1487644226717187
Details by Category

❌ ▲ Vercel Production

AppPassedFailedSkipped
✅ astro-node127029
✅ astro-quickjs127029
✅ example-node127029
✅ example-quickjs127029
✅ express-node127029
✅ express-quickjs127029
✅ fastify-node127029
✅ fastify-quickjs127029
✅ hono-node127029
✅ hono-quickjs127029
✅ nextjs-turbopack-node15204
❌ nextjs-webpack-node15114
✅ nextjs-webpack-quickjs15204
✅ nitro-node127029
✅ nitro-quickjs127029
✅ nuxt-node127029
✅ nuxt-quickjs127029
✅ sveltekit-node146010
✅ sveltekit-quickjs146010
✅ vite-node127029
✅ vite-quickjs127029

❌ 💻 Local Development

AppPassedFailedSkipped
✅ astro-stable-node130026
❌ astro-stable-quickjs129126
✅ express-stable-node130026
❌ express-stable-quickjs129126
✅ fastify-stable-node130026
❌ fastify-stable-quickjs129126
✅ hono-stable-node130026
❌ hono-stable-quickjs129126
✅ nextjs-turbopack-canary-node137019
❌ nextjs-turbopack-canary-quickjs136119
✅ nextjs-turbopack-stable-node15600
❌ nextjs-turbopack-stable-quickjs15510
✅ nextjs-webpack-canary-node137019
✅ nextjs-webpack-stable-node15600
❌ nextjs-webpack-stable-quickjs15510
✅ nitro-stable-node130026
❌ nitro-stable-quickjs129126
✅ nuxt-stable-node130026
❌ nuxt-stable-quickjs129126
✅ sveltekit-stable-node14907
❌ sveltekit-stable-quickjs14817
✅ vite-stable-node130026
❌ vite-stable-quickjs129126

❌ 📦 Local Production

AppPassedFailedSkipped
✅ astro-stable-node130026
❌ astro-stable-quickjs129126
✅ express-stable-node130026
❌ express-stable-quickjs129126
✅ fastify-stable-node130026
❌ fastify-stable-quickjs129126
✅ hono-stable-node130026
❌ hono-stable-quickjs129126
✅ nextjs-turbopack-canary-node137019
❌ nextjs-turbopack-canary-quickjs136119
✅ nextjs-turbopack-stable-node15600
❌ nextjs-turbopack-stable-quickjs15510
✅ nextjs-webpack-canary-node137019
❌ nextjs-webpack-canary-quickjs136119
✅ nextjs-webpack-stable-node15600
❌ nextjs-webpack-stable-quickjs15510
❌ nitro-stable-node129126
❌ nitro-stable-quickjs129126
✅ nuxt-stable-node130026
❌ nuxt-stable-quickjs129126
✅ sveltekit-stable-node14907
❌ sveltekit-stable-quickjs14817
✅ vite-stable-node130026
❌ vite-stable-quickjs129126

❌ 🐘 Local Postgres

AppPassedFailedSkipped
✅ astro-stable-node130026
❌ astro-stable-quickjs129126
✅ express-stable-node130026
❌ express-stable-quickjs129126
✅ fastify-stable-node130026
❌ fastify-stable-quickjs129126
✅ hono-stable-node130026
❌ hono-stable-quickjs129126
✅ nextjs-turbopack-canary-node137019
❌ nextjs-turbopack-canary-quickjs136119
✅ nextjs-turbopack-stable-node15600
❌ nextjs-turbopack-stable-quickjs15510
✅ nextjs-webpack-canary-node137019
❌ nextjs-webpack-canary-quickjs136119
✅ nextjs-webpack-stable-node15600
❌ nextjs-webpack-stable-quickjs15510
✅ nitro-stable-node130026
❌ nitro-stable-quickjs129126
✅ nuxt-stable-node130026
❌ nuxt-stable-quickjs129126
✅ sveltekit-stable-node14907
❌ sveltekit-stable-quickjs14817
✅ vite-stable-node130026
❌ vite-stable-quickjs129126

❌ 🪟 Windows

AppPassedFailedSkipped
✅ nextjs-turbopack-node15600
❌ nextjs-turbopack-quickjs15510

❌ 📋 Other

AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable-node130026
❌ e2e-local-dev-nest-stable-quickjs129126
✅ e2e-local-dev-tanstack-start-node130026
❌ e2e-local-dev-tanstack-start-quickjs129126
✅ e2e-local-postgres-nest-stable-node130026
❌ e2e-local-postgres-nest-stable-quickjs129126
✅ e2e-local-postgres-tanstack-start-node130026
❌ e2e-local-postgres-tanstack-start-quickjs129126
✅ e2e-local-prod-nest-stable-node130026
❌ e2e-local-prod-nest-stable-quickjs129126
✅ e2e-local-prod-tanstack-start-node130026
❌ e2e-local-prod-tanstack-start-quickjs129126
✅ e2e-vercel-prod-nest-node127029
✅ e2e-vercel-prod-nest-quickjs127029
✅ e2e-vercel-prod-tanstack-start-node127029
✅ e2e-vercel-prod-tanstack-start-quickjs127029

✅ vercel-multi-region

AppPassedFailedSkipped
✅ nextjs-turbopack2700

📋 View full workflow run

@github-actions

github-actionsBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 1f2440a · Tue, 04 Aug 2026 18:27:48 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep313 (+22%) 🔻1329 🔴 (+19%) 🔻1352 🔴 (+16%) 🔻1606 🔴 (+34%) 🔻30
TTFSstream1286 (+423%) 🔻1354 🔴 (+20%) 🔻1372 🔴 (+18%) 🔻1380 🔴 (+13%)30
TTFShook + stream1536 (+295%) 🔻1622 🔴 (+18%) 🔻1657 🔴 (+10%)1681 🔴 (-38%) 💚30
STSO1020 steps (inline)95 (-4.0%)128 (-16%) 💚145 (-21%) 💚237 (-29%) 💚1018
STSO1020 steps (queue-hop)3139 (+6.0%)3139 (+6.0%)3139 (+6.0%)3139 (+6.0%)1
WO1020 steps134775 (-12%)134775 (-12%)134775 (-12%)134775 (-12%)1
SLstream latency102 (+5.2%)142 🔴 (+3.6%)147 🔴 (-5.2%)159 🔴 (-76%) 💚30
SOstream overhead (text)102 (-18%) 💚144 (-66%) 💚154 (-81%) 💚224 (-93%) 💚30
SOstream overhead (structured)102 (-4.7%)165 (-45%) 💚197 (-65%) 💚293 (-68%) 💚30
📈 STSO distribution vs main (inline / queue-hop histograms)

1020 steps (inline)

Cumulative STSO time: main 149536ms → this run 130313ms (Δ -19223ms, -13%)

 50-100 ms ┃ main 1 this 6 +5
100-150 ms ███████████████████░░░░┃ main 721 this 930 +209
150-200 ms █┃████ main 227 this 65 -162
200-250 ms ┃ main 40 this 7 -33
250-300 ms ┃ main 12 this 5 -7
300-350 ms ┃ main 8 this 0 -8
350-400 ms ┃ main 5 this 3 -2
400-450 ms ┃ main 2 this 0 -2
550-600 ms ┃ main 1 this 1 +0
1100-1150 ms ┃ main 1 this 0 -1
4400-4450 ms ┃ main 0 this 1 +1

1020 steps (queue-hop)

Cumulative STSO time: main 2962ms → this run 3139ms (Δ +177ms, +6%)

2500-3000 ms ┃███████████████████████ main 1 this 0 -1
3000-3500 ms ░░░░░░░░░░░░░░░░░░░░░░░┃ main 0 this 1 +1
📜 Previous results (1)

70cc37f

Tue, 04 Aug 2026 18:00:52 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep1160 (+351%) 🔻1326 🔴 (+19%) 🔻1383 🔴 (+19%) 🔻1460 🔴 (+21%) 🔻30
TTFSstream1140 (+363%) 🔻1207 🔴 (+7.4%)1216 🔴 (+4.6%)1301 🔴 (+6.6%)30
TTFShook + stream1394 (+258%) 🔻1495 🔴 (+9.2%)1601 🔴 (+6.4%)5432 🔴 (+100%) 🔻30
STSO1020 steps (inline)83 (-16%) 💚118 (-23%) 💚137 (-25%) 💚201 (-40%) 💚1019
WO1020 steps118702 (-23%) 💚118702 (-23%) 💚118702 (-23%) 💚118702 (-23%) 💚1
SLstream latency94 (-3.1%)150 🔴 (+9.5%)176 🔴 (+14%)246 🔴 (-63%) 💚30
SOstream overhead (text)106 (-15%)162 (-61%) 💚229 (-72%) 💚3596 🔴 (+20%) 🔻30
SOstream overhead (structured)100 (-6.5%)147 (-51%) 💚173 (-69%) 💚215 (-77%) 💚30
ℹ️ Metric definitions & methodology

The collapsed STSO distribution section above buckets every step gap of the sequential-steps run (not a sampled window), split by whether the step ending the gap ran inline — in the same warm process as the step before it, so the gap is pure framework overhead — or after a queue-hop — the first step of a fresh process, which pays queue dispatch, client reinit and event-log replay. Bars overlay the two runs: is main, marks where this run lands, bridges the gap when this run has more samples in a bucket.

Best/P75/P90/P99 deltas compare against the most recent benchmark run on main at the time of this run. 🔻 flags a delta worse than +15%, 💚 one better than −15%.

Metrics — TTFS: time to first step body (in-deployment start() → first step body, deployment clocks) · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (whole-run time outside step bodies, in-deployment anchored) · SL: stream latency (in-deployment write → read propagation, readAt - writtenAt) · SO: stream overhead (end-to-end write+consume time beyond the modelled generation window)

Scenarios — step: one trivial no-op step, no stream; no hooks, so the run stays in turbo mode (in-process fast path) · stream: one streaming step; no hooks, so the run stays in turbo mode (in-process fast path) · hook + stream: registers a hook before one step, which exits turbo mode (dispatch path) · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges, and WO is the whole-run overhead outside step bodies · stream latency: parallel reader/writer steps on a dedicated stream; SL is the in-deployment write->read propagation (readAt - writtenAt) · stream overhead (text): writer streams 300 variable-length text token deltas paced at 100/s for 3s (a haiku-size LLM's token throughput) while a parallel reader drains the whole stream; SO is the end-to-end write+consume time beyond the 3s generation window (overhead/backpressure) · stream overhead (structured): same workload as stream overhead (text), but each delta is an AI-SDK-style structured object ({ type: 'text-delta', id, text }) instead of a raw string, so the SO gap vs the text scenario is the added serialization cost

🔴 marks a percentile over its target (within target is left unmarked). Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · SO 250/500/1000

All metrics are measured from deployment-side timestamps only. Runs are triggered by an in-deployment route that stamps the anchor (clientStart) right before start(), so the CI runner’s request and its path through api.vercel.com sit outside every measured window. TTFS = in-deployment start() → first step body (turbo uses the in-process fast path, non-turbo the dispatch path), and includes the VQS dispatch hop plus any /flow cold start. STSO/WO are measured between step bodies on the deployment. SL is measured inside the workflow (parallel reader/writer steps), so it no longer includes the api.vercel.com read path.

Cold starts are kept in the numbers on purpose — they are part of real bursty-workload latency. The workbench deployment cold-starts the /flow invocation for a large fraction of runs, inflating P75+; the Best column shows the fastest (warm-start) sample for comparison.

@mitul-s
mitul-s marked this pull request as draft August 4, 2026 17:44
Composing the replay key around the resolver forced an empty-object
sentinel and a separate hasLineage concept; making the resolver own all
lineage attributes returns undefined for no-lineage runs and keeps the
seed call site in its original shape.
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@mitul-s
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat(core): mirror replay lineage into a reserved $replayedFromRunId attribute by mitul-s · Pull Request #3329 · vercel/workflow · GitHub
Skip to content

feat(core): mirror replay lineage into a reserved $replayedFromRunId attribute - #3329

Draft
mitul-s wants to merge 2 commits into
mainfrom
mitul/replay-lineage-attribute
Draft

feat(core): mirror replay lineage into a reserved $replayedFromRunId attribute#3329
mitul-s wants to merge 2 commits into
mainfrom
mitul/replay-lineage-attribute

Conversation

@mitul-s

Copy link
Copy Markdown
Contributor

Summary

recreateRunFromExisting records its source run only on the new run's executionContext (replayedFromRunId, #2872). Attribute-indexed observability stores never see executionContext — the ClickHouse workflow_run_attributes table behind the Vercel dashboard's runs list only carries run attributes — so surfacing "which runs are replays" in a list currently requires a per-run world read (see vercel/front#79769, which fans out runs.getMany for every listed page).

This mirrors the replay lineage into the reserved $replayedFromRunId attribute, riding the exact mechanism $rootRunId/$parentRunId already use:

  • @workflow/world: export REPLAYED_FROM_RUN_ID_ATTRIBUTE ($replayedFromRunId) alongside the existing lineage attribute keys.
  • @workflow/corestart(): when replayedFromRunId is set and the spec version supports native attributes (v4+), seed the attribute on both the run_created event and the resilient-start queue input (with allowReservedAttributes, like parent lineage). Pre-v4 runs skip the attribute silently and keep the unconditional executionContext record, so replaying an old run never fails.
  • Validation of replayedFromRunId now runs before the attribute seed is composed; behavior is otherwise unchanged (a plain start() still emits no attributes field at all).

Once ingested, the dashboard's runs list can serve replay lineage straight from the attributes table and drop the per-run world fan-out.

Testing

  • packages/core: pnpm vitest run src/runtime/start.test.ts src/runtime/runs.test.ts — 82 passed, including new coverage: attribute seeded on both payloads, merges with caller attributes (caller keys last), skipped on pre-v4 spec with executionContext intact, and no empty attributes object on plain starts.
  • packages/world: full unit suite — 84 passed.
  • Biome and tsc show no new findings (the quickjs-runtime.ts typecheck errors and complexity warnings exist on main).

Made with Cursor

…attribute
recreateRunFromExisting records its source run only in the new run's
executionContext, which attribute-indexed observability stores (e.g. the
ClickHouse workflow_run_attributes table behind the dashboard runs list)
never see — so surfacing 'which runs are replays' in a list requires a
per-run world read. Seed the same value as the reserved
$replayedFromRunId attribute (like $rootRunId/$parentRunId) on worlds
with native attributes; pre-v4 spec versions skip the attribute silently
and keep the executionContext record.
Co-authored-by: Cursor <cursoragent@cursor.com>
@mitul-s
mitul-s requested a review from a team as a code ownerAugust 4, 2026 17:43
@vercel

vercelBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

changeset-botBot commented Aug 4, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1f2440a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@workflow/coreMinor
@workflow/worldMinor
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
workflowMinor
@workflow/world-testingPatch
@workflow/world-localPatch
@workflow/world-postgresPatch
@workflow/world-vercelPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

Some tests failed

❌ Failed E2E Tests

▲ Vercel Production (1 failed)

nextjs-webpack-node (1 failed):

  • outputStreamWorkflow positive startIndex (skips first chunk)
💻 Local Development (11 failed)

astro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

express-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

fastify-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

hono-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nitro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nuxt-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

sveltekit-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

vite-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable
📦 Local Production (13 failed)

astro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

express-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

fastify-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

hono-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nitro-stable-node (1 failed):

  • webhookWorkflow | wrun_41KZ6ZPQSC0GP0M9EQ9JGAEX80

nitro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nuxt-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

sveltekit-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

vite-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable
🐘 Local Postgres (12 failed)

astro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

express-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

fastify-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

hono-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nitro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nuxt-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

sveltekit-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

vite-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

🪟 Windows (1 failed)

nextjs-turbopack-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

📋 Other (6 failed)

e2e-local-dev-nest-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-dev-tanstack-start-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-postgres-nest-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-postgres-tanstack-start-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-prod-nest-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-prod-tanstack-start-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

E2E Test Summary

Summary
PassedFailedSkippedTotal
❌ ▲ Vercel Production277914963276
❌ 💻 Local Development3142114353588
❌ 📦 Local Production3277134543744
❌ 🐘 Local Postgres3278124543744
❌ 🪟 Windows31110312
❌ 📋 Other206264282496
✅ vercel-multi-region270027
Total1487644226717187
Details by Category

❌ ▲ Vercel Production

AppPassedFailedSkipped
✅ astro-node127029
✅ astro-quickjs127029
✅ example-node127029
✅ example-quickjs127029
✅ express-node127029
✅ express-quickjs127029
✅ fastify-node127029
✅ fastify-quickjs127029
✅ hono-node127029
✅ hono-quickjs127029
✅ nextjs-turbopack-node15204
❌ nextjs-webpack-node15114
✅ nextjs-webpack-quickjs15204
✅ nitro-node127029
✅ nitro-quickjs127029
✅ nuxt-node127029
✅ nuxt-quickjs127029
✅ sveltekit-node146010
✅ sveltekit-quickjs146010
✅ vite-node127029
✅ vite-quickjs127029

❌ 💻 Local Development

AppPassedFailedSkipped
✅ astro-stable-node130026
❌ astro-stable-quickjs129126
✅ express-stable-node130026
❌ express-stable-quickjs129126
✅ fastify-stable-node130026
❌ fastify-stable-quickjs129126
✅ hono-stable-node130026
❌ hono-stable-quickjs129126
✅ nextjs-turbopack-canary-node137019
❌ nextjs-turbopack-canary-quickjs136119
✅ nextjs-turbopack-stable-node15600
❌ nextjs-turbopack-stable-quickjs15510
✅ nextjs-webpack-canary-node137019
✅ nextjs-webpack-stable-node15600
❌ nextjs-webpack-stable-quickjs15510
✅ nitro-stable-node130026
❌ nitro-stable-quickjs129126
✅ nuxt-stable-node130026
❌ nuxt-stable-quickjs129126
✅ sveltekit-stable-node14907
❌ sveltekit-stable-quickjs14817
✅ vite-stable-node130026
❌ vite-stable-quickjs129126

❌ 📦 Local Production

AppPassedFailedSkipped
✅ astro-stable-node130026
❌ astro-stable-quickjs129126
✅ express-stable-node130026
❌ express-stable-quickjs129126
✅ fastify-stable-node130026
❌ fastify-stable-quickjs129126
✅ hono-stable-node130026
❌ hono-stable-quickjs129126
✅ nextjs-turbopack-canary-node137019
❌ nextjs-turbopack-canary-quickjs136119
✅ nextjs-turbopack-stable-node15600
❌ nextjs-turbopack-stable-quickjs15510
✅ nextjs-webpack-canary-node137019
❌ nextjs-webpack-canary-quickjs136119
✅ nextjs-webpack-stable-node15600
❌ nextjs-webpack-stable-quickjs15510
❌ nitro-stable-node129126
❌ nitro-stable-quickjs129126
✅ nuxt-stable-node130026
❌ nuxt-stable-quickjs129126
✅ sveltekit-stable-node14907
❌ sveltekit-stable-quickjs14817
✅ vite-stable-node130026
❌ vite-stable-quickjs129126

❌ 🐘 Local Postgres

AppPassedFailedSkipped
✅ astro-stable-node130026
❌ astro-stable-quickjs129126
✅ express-stable-node130026
❌ express-stable-quickjs129126
✅ fastify-stable-node130026
❌ fastify-stable-quickjs129126
✅ hono-stable-node130026
❌ hono-stable-quickjs129126
✅ nextjs-turbopack-canary-node137019
❌ nextjs-turbopack-canary-quickjs136119
✅ nextjs-turbopack-stable-node15600
❌ nextjs-turbopack-stable-quickjs15510
✅ nextjs-webpack-canary-node137019
❌ nextjs-webpack-canary-quickjs136119
✅ nextjs-webpack-stable-node15600
❌ nextjs-webpack-stable-quickjs15510
✅ nitro-stable-node130026
❌ nitro-stable-quickjs129126
✅ nuxt-stable-node130026
❌ nuxt-stable-quickjs129126
✅ sveltekit-stable-node14907
❌ sveltekit-stable-quickjs14817
✅ vite-stable-node130026
❌ vite-stable-quickjs129126

❌ 🪟 Windows

AppPassedFailedSkipped
✅ nextjs-turbopack-node15600
❌ nextjs-turbopack-quickjs15510

❌ 📋 Other

AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable-node130026
❌ e2e-local-dev-nest-stable-quickjs129126
✅ e2e-local-dev-tanstack-start-node130026
❌ e2e-local-dev-tanstack-start-quickjs129126
✅ e2e-local-postgres-nest-stable-node130026
❌ e2e-local-postgres-nest-stable-quickjs129126
✅ e2e-local-postgres-tanstack-start-node130026
❌ e2e-local-postgres-tanstack-start-quickjs129126
✅ e2e-local-prod-nest-stable-node130026
❌ e2e-local-prod-nest-stable-quickjs129126
✅ e2e-local-prod-tanstack-start-node130026
❌ e2e-local-prod-tanstack-start-quickjs129126
✅ e2e-vercel-prod-nest-node127029
✅ e2e-vercel-prod-nest-quickjs127029
✅ e2e-vercel-prod-tanstack-start-node127029
✅ e2e-vercel-prod-tanstack-start-quickjs127029

✅ vercel-multi-region

AppPassedFailedSkipped
✅ nextjs-turbopack2700

📋 View full workflow run

@github-actions

github-actionsBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 1f2440a · Tue, 04 Aug 2026 18:27:48 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep313 (+22%) 🔻1329 🔴 (+19%) 🔻1352 🔴 (+16%) 🔻1606 🔴 (+34%) 🔻30
TTFSstream1286 (+423%) 🔻1354 🔴 (+20%) 🔻1372 🔴 (+18%) 🔻1380 🔴 (+13%)30
TTFShook + stream1536 (+295%) 🔻1622 🔴 (+18%) 🔻1657 🔴 (+10%)1681 🔴 (-38%) 💚30
STSO1020 steps (inline)95 (-4.0%)128 (-16%) 💚145 (-21%) 💚237 (-29%) 💚1018
STSO1020 steps (queue-hop)3139 (+6.0%)3139 (+6.0%)3139 (+6.0%)3139 (+6.0%)1
WO1020 steps134775 (-12%)134775 (-12%)134775 (-12%)134775 (-12%)1
SLstream latency102 (+5.2%)142 🔴 (+3.6%)147 🔴 (-5.2%)159 🔴 (-76%) 💚30
SOstream overhead (text)102 (-18%) 💚144 (-66%) 💚154 (-81%) 💚224 (-93%) 💚30
SOstream overhead (structured)102 (-4.7%)165 (-45%) 💚197 (-65%) 💚293 (-68%) 💚30
📈 STSO distribution vs main (inline / queue-hop histograms)

1020 steps (inline)

Cumulative STSO time: main 149536ms → this run 130313ms (Δ -19223ms, -13%)

 50-100 ms ┃ main 1 this 6 +5
100-150 ms ███████████████████░░░░┃ main 721 this 930 +209
150-200 ms █┃████ main 227 this 65 -162
200-250 ms ┃ main 40 this 7 -33
250-300 ms ┃ main 12 this 5 -7
300-350 ms ┃ main 8 this 0 -8
350-400 ms ┃ main 5 this 3 -2
400-450 ms ┃ main 2 this 0 -2
550-600 ms ┃ main 1 this 1 +0
1100-1150 ms ┃ main 1 this 0 -1
4400-4450 ms ┃ main 0 this 1 +1

1020 steps (queue-hop)

Cumulative STSO time: main 2962ms → this run 3139ms (Δ +177ms, +6%)

2500-3000 ms ┃███████████████████████ main 1 this 0 -1
3000-3500 ms ░░░░░░░░░░░░░░░░░░░░░░░┃ main 0 this 1 +1
📜 Previous results (1)

70cc37f

Tue, 04 Aug 2026 18:00:52 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep1160 (+351%) 🔻1326 🔴 (+19%) 🔻1383 🔴 (+19%) 🔻1460 🔴 (+21%) 🔻30
TTFSstream1140 (+363%) 🔻1207 🔴 (+7.4%)1216 🔴 (+4.6%)1301 🔴 (+6.6%)30
TTFShook + stream1394 (+258%) 🔻1495 🔴 (+9.2%)1601 🔴 (+6.4%)5432 🔴 (+100%) 🔻30
STSO1020 steps (inline)83 (-16%) 💚118 (-23%) 💚137 (-25%) 💚201 (-40%) 💚1019
WO1020 steps118702 (-23%) 💚118702 (-23%) 💚118702 (-23%) 💚118702 (-23%) 💚1
SLstream latency94 (-3.1%)150 🔴 (+9.5%)176 🔴 (+14%)246 🔴 (-63%) 💚30
SOstream overhead (text)106 (-15%)162 (-61%) 💚229 (-72%) 💚3596 🔴 (+20%) 🔻30
SOstream overhead (structured)100 (-6.5%)147 (-51%) 💚173 (-69%) 💚215 (-77%) 💚30
ℹ️ Metric definitions & methodology

The collapsed STSO distribution section above buckets every step gap of the sequential-steps run (not a sampled window), split by whether the step ending the gap ran inline — in the same warm process as the step before it, so the gap is pure framework overhead — or after a queue-hop — the first step of a fresh process, which pays queue dispatch, client reinit and event-log replay. Bars overlay the two runs: is main, marks where this run lands, bridges the gap when this run has more samples in a bucket.

Best/P75/P90/P99 deltas compare against the most recent benchmark run on main at the time of this run. 🔻 flags a delta worse than +15%, 💚 one better than −15%.

Metrics — TTFS: time to first step body (in-deployment start() → first step body, deployment clocks) · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (whole-run time outside step bodies, in-deployment anchored) · SL: stream latency (in-deployment write → read propagation, readAt - writtenAt) · SO: stream overhead (end-to-end write+consume time beyond the modelled generation window)

Scenarios — step: one trivial no-op step, no stream; no hooks, so the run stays in turbo mode (in-process fast path) · stream: one streaming step; no hooks, so the run stays in turbo mode (in-process fast path) · hook + stream: registers a hook before one step, which exits turbo mode (dispatch path) · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges, and WO is the whole-run overhead outside step bodies · stream latency: parallel reader/writer steps on a dedicated stream; SL is the in-deployment write->read propagation (readAt - writtenAt) · stream overhead (text): writer streams 300 variable-length text token deltas paced at 100/s for 3s (a haiku-size LLM's token throughput) while a parallel reader drains the whole stream; SO is the end-to-end write+consume time beyond the 3s generation window (overhead/backpressure) · stream overhead (structured): same workload as stream overhead (text), but each delta is an AI-SDK-style structured object ({ type: 'text-delta', id, text }) instead of a raw string, so the SO gap vs the text scenario is the added serialization cost

🔴 marks a percentile over its target (within target is left unmarked). Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · SO 250/500/1000

All metrics are measured from deployment-side timestamps only. Runs are triggered by an in-deployment route that stamps the anchor (clientStart) right before start(), so the CI runner’s request and its path through api.vercel.com sit outside every measured window. TTFS = in-deployment start() → first step body (turbo uses the in-process fast path, non-turbo the dispatch path), and includes the VQS dispatch hop plus any /flow cold start. STSO/WO are measured between step bodies on the deployment. SL is measured inside the workflow (parallel reader/writer steps), so it no longer includes the api.vercel.com read path.

Cold starts are kept in the numbers on purpose — they are part of real bursty-workload latency. The workbench deployment cold-starts the /flow invocation for a large fraction of runs, inflating P75+; the Best column shows the fastest (warm-start) sample for comparison.

@mitul-s
mitul-s marked this pull request as draft August 4, 2026 17:44
Composing the replay key around the resolver forced an empty-object
sentinel and a separate hasLineage concept; making the resolver own all
lineage attributes returns undefined for no-lineage runs and keeps the
seed call site in its original shape.
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@mitul-s
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(core): mirror replay lineage into a reserved $replayedFromRunId attribute by mitul-s · Pull Request #3329 · vercel/workflow · GitHub
Skip to content

feat(core): mirror replay lineage into a reserved $replayedFromRunId attribute - #3329

Draft
mitul-s wants to merge 2 commits into
mainfrom
mitul/replay-lineage-attribute
Draft

feat(core): mirror replay lineage into a reserved $replayedFromRunId attribute#3329
mitul-s wants to merge 2 commits into
mainfrom
mitul/replay-lineage-attribute

Conversation

@mitul-s

Copy link
Copy Markdown
Contributor

Summary

recreateRunFromExisting records its source run only on the new run's executionContext (replayedFromRunId, #2872). Attribute-indexed observability stores never see executionContext — the ClickHouse workflow_run_attributes table behind the Vercel dashboard's runs list only carries run attributes — so surfacing "which runs are replays" in a list currently requires a per-run world read (see vercel/front#79769, which fans out runs.getMany for every listed page).

This mirrors the replay lineage into the reserved $replayedFromRunId attribute, riding the exact mechanism $rootRunId/$parentRunId already use:

  • @workflow/world: export REPLAYED_FROM_RUN_ID_ATTRIBUTE ($replayedFromRunId) alongside the existing lineage attribute keys.
  • @workflow/corestart(): when replayedFromRunId is set and the spec version supports native attributes (v4+), seed the attribute on both the run_created event and the resilient-start queue input (with allowReservedAttributes, like parent lineage). Pre-v4 runs skip the attribute silently and keep the unconditional executionContext record, so replaying an old run never fails.
  • Validation of replayedFromRunId now runs before the attribute seed is composed; behavior is otherwise unchanged (a plain start() still emits no attributes field at all).

Once ingested, the dashboard's runs list can serve replay lineage straight from the attributes table and drop the per-run world fan-out.

Testing

  • packages/core: pnpm vitest run src/runtime/start.test.ts src/runtime/runs.test.ts — 82 passed, including new coverage: attribute seeded on both payloads, merges with caller attributes (caller keys last), skipped on pre-v4 spec with executionContext intact, and no empty attributes object on plain starts.
  • packages/world: full unit suite — 84 passed.
  • Biome and tsc show no new findings (the quickjs-runtime.ts typecheck errors and complexity warnings exist on main).

Made with Cursor

…attribute
recreateRunFromExisting records its source run only in the new run's
executionContext, which attribute-indexed observability stores (e.g. the
ClickHouse workflow_run_attributes table behind the dashboard runs list)
never see — so surfacing 'which runs are replays' in a list requires a
per-run world read. Seed the same value as the reserved
$replayedFromRunId attribute (like $rootRunId/$parentRunId) on worlds
with native attributes; pre-v4 spec versions skip the attribute silently
and keep the executionContext record.
Co-authored-by: Cursor <cursoragent@cursor.com>
@mitul-s
mitul-s requested a review from a team as a code ownerAugust 4, 2026 17:43
@vercel

vercelBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

changeset-botBot commented Aug 4, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1f2440a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@workflow/coreMinor
@workflow/worldMinor
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
workflowMinor
@workflow/world-testingPatch
@workflow/world-localPatch
@workflow/world-postgresPatch
@workflow/world-vercelPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

Some tests failed

❌ Failed E2E Tests

▲ Vercel Production (1 failed)

nextjs-webpack-node (1 failed):

  • outputStreamWorkflow positive startIndex (skips first chunk)
💻 Local Development (11 failed)

astro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

express-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

fastify-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

hono-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nitro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nuxt-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

sveltekit-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

vite-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable
📦 Local Production (13 failed)

astro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

express-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

fastify-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

hono-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nitro-stable-node (1 failed):

  • webhookWorkflow | wrun_41KZ6ZPQSC0GP0M9EQ9JGAEX80

nitro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nuxt-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

sveltekit-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

vite-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable
🐘 Local Postgres (12 failed)

astro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

express-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

fastify-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

hono-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nitro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nuxt-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

sveltekit-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

vite-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

🪟 Windows (1 failed)

nextjs-turbopack-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

📋 Other (6 failed)

e2e-local-dev-nest-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-dev-tanstack-start-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-postgres-nest-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-postgres-tanstack-start-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-prod-nest-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-prod-tanstack-start-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

E2E Test Summary

Summary
PassedFailedSkippedTotal
❌ ▲ Vercel Production277914963276
❌ 💻 Local Development3142114353588
❌ 📦 Local Production3277134543744
❌ 🐘 Local Postgres3278124543744
❌ 🪟 Windows31110312
❌ 📋 Other206264282496
✅ vercel-multi-region270027
Total1487644226717187
Details by Category

❌ ▲ Vercel Production

AppPassedFailedSkipped
✅ astro-node127029
✅ astro-quickjs127029
✅ example-node127029
✅ example-quickjs127029
✅ express-node127029
✅ express-quickjs127029
✅ fastify-node127029
✅ fastify-quickjs127029
✅ hono-node127029
✅ hono-quickjs127029
✅ nextjs-turbopack-node15204
❌ nextjs-webpack-node15114
✅ nextjs-webpack-quickjs15204
✅ nitro-node127029
✅ nitro-quickjs127029
✅ nuxt-node127029
✅ nuxt-quickjs127029
✅ sveltekit-node146010
✅ sveltekit-quickjs146010
✅ vite-node127029
✅ vite-quickjs127029

❌ 💻 Local Development

AppPassedFailedSkipped
✅ astro-stable-node130026
❌ astro-stable-quickjs129126
✅ express-stable-node130026
❌ express-stable-quickjs129126
✅ fastify-stable-node130026
❌ fastify-stable-quickjs129126
✅ hono-stable-node130026
❌ hono-stable-quickjs129126
✅ nextjs-turbopack-canary-node137019
❌ nextjs-turbopack-canary-quickjs136119
✅ nextjs-turbopack-stable-node15600
❌ nextjs-turbopack-stable-quickjs15510
✅ nextjs-webpack-canary-node137019
✅ nextjs-webpack-stable-node15600
❌ nextjs-webpack-stable-quickjs15510
✅ nitro-stable-node130026
❌ nitro-stable-quickjs129126
✅ nuxt-stable-node130026
❌ nuxt-stable-quickjs129126
✅ sveltekit-stable-node14907
❌ sveltekit-stable-quickjs14817
✅ vite-stable-node130026
❌ vite-stable-quickjs129126

❌ 📦 Local Production

AppPassedFailedSkipped
✅ astro-stable-node130026
❌ astro-stable-quickjs129126
✅ express-stable-node130026
❌ express-stable-quickjs129126
✅ fastify-stable-node130026
❌ fastify-stable-quickjs129126
✅ hono-stable-node130026
❌ hono-stable-quickjs129126
✅ nextjs-turbopack-canary-node137019
❌ nextjs-turbopack-canary-quickjs136119
✅ nextjs-turbopack-stable-node15600
❌ nextjs-turbopack-stable-quickjs15510
✅ nextjs-webpack-canary-node137019
❌ nextjs-webpack-canary-quickjs136119
✅ nextjs-webpack-stable-node15600
❌ nextjs-webpack-stable-quickjs15510
❌ nitro-stable-node129126
❌ nitro-stable-quickjs129126
✅ nuxt-stable-node130026
❌ nuxt-stable-quickjs129126
✅ sveltekit-stable-node14907
❌ sveltekit-stable-quickjs14817
✅ vite-stable-node130026
❌ vite-stable-quickjs129126

❌ 🐘 Local Postgres

AppPassedFailedSkipped
✅ astro-stable-node130026
❌ astro-stable-quickjs129126
✅ express-stable-node130026
❌ express-stable-quickjs129126
✅ fastify-stable-node130026
❌ fastify-stable-quickjs129126
✅ hono-stable-node130026
❌ hono-stable-quickjs129126
✅ nextjs-turbopack-canary-node137019
❌ nextjs-turbopack-canary-quickjs136119
✅ nextjs-turbopack-stable-node15600
❌ nextjs-turbopack-stable-quickjs15510
✅ nextjs-webpack-canary-node137019
❌ nextjs-webpack-canary-quickjs136119
✅ nextjs-webpack-stable-node15600
❌ nextjs-webpack-stable-quickjs15510
✅ nitro-stable-node130026
❌ nitro-stable-quickjs129126
✅ nuxt-stable-node130026
❌ nuxt-stable-quickjs129126
✅ sveltekit-stable-node14907
❌ sveltekit-stable-quickjs14817
✅ vite-stable-node130026
❌ vite-stable-quickjs129126

❌ 🪟 Windows

AppPassedFailedSkipped
✅ nextjs-turbopack-node15600
❌ nextjs-turbopack-quickjs15510

❌ 📋 Other

AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable-node130026
❌ e2e-local-dev-nest-stable-quickjs129126
✅ e2e-local-dev-tanstack-start-node130026
❌ e2e-local-dev-tanstack-start-quickjs129126
✅ e2e-local-postgres-nest-stable-node130026
❌ e2e-local-postgres-nest-stable-quickjs129126
✅ e2e-local-postgres-tanstack-start-node130026
❌ e2e-local-postgres-tanstack-start-quickjs129126
✅ e2e-local-prod-nest-stable-node130026
❌ e2e-local-prod-nest-stable-quickjs129126
✅ e2e-local-prod-tanstack-start-node130026
❌ e2e-local-prod-tanstack-start-quickjs129126
✅ e2e-vercel-prod-nest-node127029
✅ e2e-vercel-prod-nest-quickjs127029
✅ e2e-vercel-prod-tanstack-start-node127029
✅ e2e-vercel-prod-tanstack-start-quickjs127029

✅ vercel-multi-region

AppPassedFailedSkipped
✅ nextjs-turbopack2700

📋 View full workflow run

@github-actions

github-actionsBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 1f2440a · Tue, 04 Aug 2026 18:27:48 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep313 (+22%) 🔻1329 🔴 (+19%) 🔻1352 🔴 (+16%) 🔻1606 🔴 (+34%) 🔻30
TTFSstream1286 (+423%) 🔻1354 🔴 (+20%) 🔻1372 🔴 (+18%) 🔻1380 🔴 (+13%)30
TTFShook + stream1536 (+295%) 🔻1622 🔴 (+18%) 🔻1657 🔴 (+10%)1681 🔴 (-38%) 💚30
STSO1020 steps (inline)95 (-4.0%)128 (-16%) 💚145 (-21%) 💚237 (-29%) 💚1018
STSO1020 steps (queue-hop)3139 (+6.0%)3139 (+6.0%)3139 (+6.0%)3139 (+6.0%)1
WO1020 steps134775 (-12%)134775 (-12%)134775 (-12%)134775 (-12%)1
SLstream latency102 (+5.2%)142 🔴 (+3.6%)147 🔴 (-5.2%)159 🔴 (-76%) 💚30
SOstream overhead (text)102 (-18%) 💚144 (-66%) 💚154 (-81%) 💚224 (-93%) 💚30
SOstream overhead (structured)102 (-4.7%)165 (-45%) 💚197 (-65%) 💚293 (-68%) 💚30
📈 STSO distribution vs main (inline / queue-hop histograms)

1020 steps (inline)

Cumulative STSO time: main 149536ms → this run 130313ms (Δ -19223ms, -13%)

 50-100 ms ┃ main 1 this 6 +5
100-150 ms ███████████████████░░░░┃ main 721 this 930 +209
150-200 ms █┃████ main 227 this 65 -162
200-250 ms ┃ main 40 this 7 -33
250-300 ms ┃ main 12 this 5 -7
300-350 ms ┃ main 8 this 0 -8
350-400 ms ┃ main 5 this 3 -2
400-450 ms ┃ main 2 this 0 -2
550-600 ms ┃ main 1 this 1 +0
1100-1150 ms ┃ main 1 this 0 -1
4400-4450 ms ┃ main 0 this 1 +1

1020 steps (queue-hop)

Cumulative STSO time: main 2962ms → this run 3139ms (Δ +177ms, +6%)

2500-3000 ms ┃███████████████████████ main 1 this 0 -1
3000-3500 ms ░░░░░░░░░░░░░░░░░░░░░░░┃ main 0 this 1 +1
📜 Previous results (1)

70cc37f

Tue, 04 Aug 2026 18:00:52 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep1160 (+351%) 🔻1326 🔴 (+19%) 🔻1383 🔴 (+19%) 🔻1460 🔴 (+21%) 🔻30
TTFSstream1140 (+363%) 🔻1207 🔴 (+7.4%)1216 🔴 (+4.6%)1301 🔴 (+6.6%)30
TTFShook + stream1394 (+258%) 🔻1495 🔴 (+9.2%)1601 🔴 (+6.4%)5432 🔴 (+100%) 🔻30
STSO1020 steps (inline)83 (-16%) 💚118 (-23%) 💚137 (-25%) 💚201 (-40%) 💚1019
WO1020 steps118702 (-23%) 💚118702 (-23%) 💚118702 (-23%) 💚118702 (-23%) 💚1
SLstream latency94 (-3.1%)150 🔴 (+9.5%)176 🔴 (+14%)246 🔴 (-63%) 💚30
SOstream overhead (text)106 (-15%)162 (-61%) 💚229 (-72%) 💚3596 🔴 (+20%) 🔻30
SOstream overhead (structured)100 (-6.5%)147 (-51%) 💚173 (-69%) 💚215 (-77%) 💚30
ℹ️ Metric definitions & methodology

The collapsed STSO distribution section above buckets every step gap of the sequential-steps run (not a sampled window), split by whether the step ending the gap ran inline — in the same warm process as the step before it, so the gap is pure framework overhead — or after a queue-hop — the first step of a fresh process, which pays queue dispatch, client reinit and event-log replay. Bars overlay the two runs: is main, marks where this run lands, bridges the gap when this run has more samples in a bucket.

Best/P75/P90/P99 deltas compare against the most recent benchmark run on main at the time of this run. 🔻 flags a delta worse than +15%, 💚 one better than −15%.

Metrics — TTFS: time to first step body (in-deployment start() → first step body, deployment clocks) · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (whole-run time outside step bodies, in-deployment anchored) · SL: stream latency (in-deployment write → read propagation, readAt - writtenAt) · SO: stream overhead (end-to-end write+consume time beyond the modelled generation window)

Scenarios — step: one trivial no-op step, no stream; no hooks, so the run stays in turbo mode (in-process fast path) · stream: one streaming step; no hooks, so the run stays in turbo mode (in-process fast path) · hook + stream: registers a hook before one step, which exits turbo mode (dispatch path) · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges, and WO is the whole-run overhead outside step bodies · stream latency: parallel reader/writer steps on a dedicated stream; SL is the in-deployment write->read propagation (readAt - writtenAt) · stream overhead (text): writer streams 300 variable-length text token deltas paced at 100/s for 3s (a haiku-size LLM's token throughput) while a parallel reader drains the whole stream; SO is the end-to-end write+consume time beyond the 3s generation window (overhead/backpressure) · stream overhead (structured): same workload as stream overhead (text), but each delta is an AI-SDK-style structured object ({ type: 'text-delta', id, text }) instead of a raw string, so the SO gap vs the text scenario is the added serialization cost

🔴 marks a percentile over its target (within target is left unmarked). Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · SO 250/500/1000

All metrics are measured from deployment-side timestamps only. Runs are triggered by an in-deployment route that stamps the anchor (clientStart) right before start(), so the CI runner’s request and its path through api.vercel.com sit outside every measured window. TTFS = in-deployment start() → first step body (turbo uses the in-process fast path, non-turbo the dispatch path), and includes the VQS dispatch hop plus any /flow cold start. STSO/WO are measured between step bodies on the deployment. SL is measured inside the workflow (parallel reader/writer steps), so it no longer includes the api.vercel.com read path.

Cold starts are kept in the numbers on purpose — they are part of real bursty-workload latency. The workbench deployment cold-starts the /flow invocation for a large fraction of runs, inflating P75+; the Best column shows the fastest (warm-start) sample for comparison.

@mitul-s
mitul-s marked this pull request as draft August 4, 2026 17:44
Composing the replay key around the resolver forced an empty-object
sentinel and a separate hasLineage concept; making the resolver own all
lineage attributes returns undefined for no-lineage runs and keeps the
seed call site in its original shape.
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@mitul-s
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(core): mirror replay lineage into a reserved $replayedFromRunId attribute by mitul-s · Pull Request #3329 · vercel/workflow · GitHub
Skip to content

feat(core): mirror replay lineage into a reserved $replayedFromRunId attribute - #3329

Draft
mitul-s wants to merge 2 commits into
mainfrom
mitul/replay-lineage-attribute
Draft

feat(core): mirror replay lineage into a reserved $replayedFromRunId attribute#3329
mitul-s wants to merge 2 commits into
mainfrom
mitul/replay-lineage-attribute

Conversation

@mitul-s

Copy link
Copy Markdown
Contributor

Summary

recreateRunFromExisting records its source run only on the new run's executionContext (replayedFromRunId, #2872). Attribute-indexed observability stores never see executionContext — the ClickHouse workflow_run_attributes table behind the Vercel dashboard's runs list only carries run attributes — so surfacing "which runs are replays" in a list currently requires a per-run world read (see vercel/front#79769, which fans out runs.getMany for every listed page).

This mirrors the replay lineage into the reserved $replayedFromRunId attribute, riding the exact mechanism $rootRunId/$parentRunId already use:

  • @workflow/world: export REPLAYED_FROM_RUN_ID_ATTRIBUTE ($replayedFromRunId) alongside the existing lineage attribute keys.
  • @workflow/corestart(): when replayedFromRunId is set and the spec version supports native attributes (v4+), seed the attribute on both the run_created event and the resilient-start queue input (with allowReservedAttributes, like parent lineage). Pre-v4 runs skip the attribute silently and keep the unconditional executionContext record, so replaying an old run never fails.
  • Validation of replayedFromRunId now runs before the attribute seed is composed; behavior is otherwise unchanged (a plain start() still emits no attributes field at all).

Once ingested, the dashboard's runs list can serve replay lineage straight from the attributes table and drop the per-run world fan-out.

Testing

  • packages/core: pnpm vitest run src/runtime/start.test.ts src/runtime/runs.test.ts — 82 passed, including new coverage: attribute seeded on both payloads, merges with caller attributes (caller keys last), skipped on pre-v4 spec with executionContext intact, and no empty attributes object on plain starts.
  • packages/world: full unit suite — 84 passed.
  • Biome and tsc show no new findings (the quickjs-runtime.ts typecheck errors and complexity warnings exist on main).

Made with Cursor

…attribute
recreateRunFromExisting records its source run only in the new run's
executionContext, which attribute-indexed observability stores (e.g. the
ClickHouse workflow_run_attributes table behind the dashboard runs list)
never see — so surfacing 'which runs are replays' in a list requires a
per-run world read. Seed the same value as the reserved
$replayedFromRunId attribute (like $rootRunId/$parentRunId) on worlds
with native attributes; pre-v4 spec versions skip the attribute silently
and keep the executionContext record.
Co-authored-by: Cursor <cursoragent@cursor.com>
@mitul-s
mitul-s requested a review from a team as a code ownerAugust 4, 2026 17:43
@vercel

vercelBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

changeset-botBot commented Aug 4, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1f2440a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@workflow/coreMinor
@workflow/worldMinor
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
workflowMinor
@workflow/world-testingPatch
@workflow/world-localPatch
@workflow/world-postgresPatch
@workflow/world-vercelPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

Some tests failed

❌ Failed E2E Tests

▲ Vercel Production (1 failed)

nextjs-webpack-node (1 failed):

  • outputStreamWorkflow positive startIndex (skips first chunk)
💻 Local Development (11 failed)

astro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

express-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

fastify-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

hono-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nitro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nuxt-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

sveltekit-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

vite-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable
📦 Local Production (13 failed)

astro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

express-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

fastify-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

hono-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nitro-stable-node (1 failed):

  • webhookWorkflow | wrun_41KZ6ZPQSC0GP0M9EQ9JGAEX80

nitro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nuxt-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

sveltekit-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

vite-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable
🐘 Local Postgres (12 failed)

astro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

express-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

fastify-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

hono-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nitro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nuxt-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

sveltekit-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

vite-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

🪟 Windows (1 failed)

nextjs-turbopack-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

📋 Other (6 failed)

e2e-local-dev-nest-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-dev-tanstack-start-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-postgres-nest-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-postgres-tanstack-start-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-prod-nest-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-prod-tanstack-start-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

E2E Test Summary

Summary
PassedFailedSkippedTotal
❌ ▲ Vercel Production277914963276
❌ 💻 Local Development3142114353588
❌ 📦 Local Production3277134543744
❌ 🐘 Local Postgres3278124543744
❌ 🪟 Windows31110312
❌ 📋 Other206264282496
✅ vercel-multi-region270027
Total1487644226717187
Details by Category

❌ ▲ Vercel Production

AppPassedFailedSkipped
✅ astro-node127029
✅ astro-quickjs127029
✅ example-node127029
✅ example-quickjs127029
✅ express-node127029
✅ express-quickjs127029
✅ fastify-node127029
✅ fastify-quickjs127029
✅ hono-node127029
✅ hono-quickjs127029
✅ nextjs-turbopack-node15204
❌ nextjs-webpack-node15114
✅ nextjs-webpack-quickjs15204
✅ nitro-node127029
✅ nitro-quickjs127029
✅ nuxt-node127029
✅ nuxt-quickjs127029
✅ sveltekit-node146010
✅ sveltekit-quickjs146010
✅ vite-node127029
✅ vite-quickjs127029

❌ 💻 Local Development

AppPassedFailedSkipped
✅ astro-stable-node130026
❌ astro-stable-quickjs129126
✅ express-stable-node130026
❌ express-stable-quickjs129126
✅ fastify-stable-node130026
❌ fastify-stable-quickjs129126
✅ hono-stable-node130026
❌ hono-stable-quickjs129126
✅ nextjs-turbopack-canary-node137019
❌ nextjs-turbopack-canary-quickjs136119
✅ nextjs-turbopack-stable-node15600
❌ nextjs-turbopack-stable-quickjs15510
✅ nextjs-webpack-canary-node137019
✅ nextjs-webpack-stable-node15600
❌ nextjs-webpack-stable-quickjs15510
✅ nitro-stable-node130026
❌ nitro-stable-quickjs129126
✅ nuxt-stable-node130026
❌ nuxt-stable-quickjs129126
✅ sveltekit-stable-node14907
❌ sveltekit-stable-quickjs14817
✅ vite-stable-node130026
❌ vite-stable-quickjs129126

❌ 📦 Local Production

AppPassedFailedSkipped
✅ astro-stable-node130026
❌ astro-stable-quickjs129126
✅ express-stable-node130026
❌ express-stable-quickjs129126
✅ fastify-stable-node130026
❌ fastify-stable-quickjs129126
✅ hono-stable-node130026
❌ hono-stable-quickjs129126
✅ nextjs-turbopack-canary-node137019
❌ nextjs-turbopack-canary-quickjs136119
✅ nextjs-turbopack-stable-node15600
❌ nextjs-turbopack-stable-quickjs15510
✅ nextjs-webpack-canary-node137019
❌ nextjs-webpack-canary-quickjs136119
✅ nextjs-webpack-stable-node15600
❌ nextjs-webpack-stable-quickjs15510
❌ nitro-stable-node129126
❌ nitro-stable-quickjs129126
✅ nuxt-stable-node130026
❌ nuxt-stable-quickjs129126
✅ sveltekit-stable-node14907
❌ sveltekit-stable-quickjs14817
✅ vite-stable-node130026
❌ vite-stable-quickjs129126

❌ 🐘 Local Postgres

AppPassedFailedSkipped
✅ astro-stable-node130026
❌ astro-stable-quickjs129126
✅ express-stable-node130026
❌ express-stable-quickjs129126
✅ fastify-stable-node130026
❌ fastify-stable-quickjs129126
✅ hono-stable-node130026
❌ hono-stable-quickjs129126
✅ nextjs-turbopack-canary-node137019
❌ nextjs-turbopack-canary-quickjs136119
✅ nextjs-turbopack-stable-node15600
❌ nextjs-turbopack-stable-quickjs15510
✅ nextjs-webpack-canary-node137019
❌ nextjs-webpack-canary-quickjs136119
✅ nextjs-webpack-stable-node15600
❌ nextjs-webpack-stable-quickjs15510
✅ nitro-stable-node130026
❌ nitro-stable-quickjs129126
✅ nuxt-stable-node130026
❌ nuxt-stable-quickjs129126
✅ sveltekit-stable-node14907
❌ sveltekit-stable-quickjs14817
✅ vite-stable-node130026
❌ vite-stable-quickjs129126

❌ 🪟 Windows

AppPassedFailedSkipped
✅ nextjs-turbopack-node15600
❌ nextjs-turbopack-quickjs15510

❌ 📋 Other

AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable-node130026
❌ e2e-local-dev-nest-stable-quickjs129126
✅ e2e-local-dev-tanstack-start-node130026
❌ e2e-local-dev-tanstack-start-quickjs129126
✅ e2e-local-postgres-nest-stable-node130026
❌ e2e-local-postgres-nest-stable-quickjs129126
✅ e2e-local-postgres-tanstack-start-node130026
❌ e2e-local-postgres-tanstack-start-quickjs129126
✅ e2e-local-prod-nest-stable-node130026
❌ e2e-local-prod-nest-stable-quickjs129126
✅ e2e-local-prod-tanstack-start-node130026
❌ e2e-local-prod-tanstack-start-quickjs129126
✅ e2e-vercel-prod-nest-node127029
✅ e2e-vercel-prod-nest-quickjs127029
✅ e2e-vercel-prod-tanstack-start-node127029
✅ e2e-vercel-prod-tanstack-start-quickjs127029

✅ vercel-multi-region

AppPassedFailedSkipped
✅ nextjs-turbopack2700

📋 View full workflow run

@github-actions

github-actionsBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 1f2440a · Tue, 04 Aug 2026 18:27:48 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep313 (+22%) 🔻1329 🔴 (+19%) 🔻1352 🔴 (+16%) 🔻1606 🔴 (+34%) 🔻30
TTFSstream1286 (+423%) 🔻1354 🔴 (+20%) 🔻1372 🔴 (+18%) 🔻1380 🔴 (+13%)30
TTFShook + stream1536 (+295%) 🔻1622 🔴 (+18%) 🔻1657 🔴 (+10%)1681 🔴 (-38%) 💚30
STSO1020 steps (inline)95 (-4.0%)128 (-16%) 💚145 (-21%) 💚237 (-29%) 💚1018
STSO1020 steps (queue-hop)3139 (+6.0%)3139 (+6.0%)3139 (+6.0%)3139 (+6.0%)1
WO1020 steps134775 (-12%)134775 (-12%)134775 (-12%)134775 (-12%)1
SLstream latency102 (+5.2%)142 🔴 (+3.6%)147 🔴 (-5.2%)159 🔴 (-76%) 💚30
SOstream overhead (text)102 (-18%) 💚144 (-66%) 💚154 (-81%) 💚224 (-93%) 💚30
SOstream overhead (structured)102 (-4.7%)165 (-45%) 💚197 (-65%) 💚293 (-68%) 💚30
📈 STSO distribution vs main (inline / queue-hop histograms)

1020 steps (inline)

Cumulative STSO time: main 149536ms → this run 130313ms (Δ -19223ms, -13%)

 50-100 ms ┃ main 1 this 6 +5
100-150 ms ███████████████████░░░░┃ main 721 this 930 +209
150-200 ms █┃████ main 227 this 65 -162
200-250 ms ┃ main 40 this 7 -33
250-300 ms ┃ main 12 this 5 -7
300-350 ms ┃ main 8 this 0 -8
350-400 ms ┃ main 5 this 3 -2
400-450 ms ┃ main 2 this 0 -2
550-600 ms ┃ main 1 this 1 +0
1100-1150 ms ┃ main 1 this 0 -1
4400-4450 ms ┃ main 0 this 1 +1

1020 steps (queue-hop)

Cumulative STSO time: main 2962ms → this run 3139ms (Δ +177ms, +6%)

2500-3000 ms ┃███████████████████████ main 1 this 0 -1
3000-3500 ms ░░░░░░░░░░░░░░░░░░░░░░░┃ main 0 this 1 +1
📜 Previous results (1)

70cc37f

Tue, 04 Aug 2026 18:00:52 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep1160 (+351%) 🔻1326 🔴 (+19%) 🔻1383 🔴 (+19%) 🔻1460 🔴 (+21%) 🔻30
TTFSstream1140 (+363%) 🔻1207 🔴 (+7.4%)1216 🔴 (+4.6%)1301 🔴 (+6.6%)30
TTFShook + stream1394 (+258%) 🔻1495 🔴 (+9.2%)1601 🔴 (+6.4%)5432 🔴 (+100%) 🔻30
STSO1020 steps (inline)83 (-16%) 💚118 (-23%) 💚137 (-25%) 💚201 (-40%) 💚1019
WO1020 steps118702 (-23%) 💚118702 (-23%) 💚118702 (-23%) 💚118702 (-23%) 💚1
SLstream latency94 (-3.1%)150 🔴 (+9.5%)176 🔴 (+14%)246 🔴 (-63%) 💚30
SOstream overhead (text)106 (-15%)162 (-61%) 💚229 (-72%) 💚3596 🔴 (+20%) 🔻30
SOstream overhead (structured)100 (-6.5%)147 (-51%) 💚173 (-69%) 💚215 (-77%) 💚30
ℹ️ Metric definitions & methodology

The collapsed STSO distribution section above buckets every step gap of the sequential-steps run (not a sampled window), split by whether the step ending the gap ran inline — in the same warm process as the step before it, so the gap is pure framework overhead — or after a queue-hop — the first step of a fresh process, which pays queue dispatch, client reinit and event-log replay. Bars overlay the two runs: is main, marks where this run lands, bridges the gap when this run has more samples in a bucket.

Best/P75/P90/P99 deltas compare against the most recent benchmark run on main at the time of this run. 🔻 flags a delta worse than +15%, 💚 one better than −15%.

Metrics — TTFS: time to first step body (in-deployment start() → first step body, deployment clocks) · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (whole-run time outside step bodies, in-deployment anchored) · SL: stream latency (in-deployment write → read propagation, readAt - writtenAt) · SO: stream overhead (end-to-end write+consume time beyond the modelled generation window)

Scenarios — step: one trivial no-op step, no stream; no hooks, so the run stays in turbo mode (in-process fast path) · stream: one streaming step; no hooks, so the run stays in turbo mode (in-process fast path) · hook + stream: registers a hook before one step, which exits turbo mode (dispatch path) · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges, and WO is the whole-run overhead outside step bodies · stream latency: parallel reader/writer steps on a dedicated stream; SL is the in-deployment write->read propagation (readAt - writtenAt) · stream overhead (text): writer streams 300 variable-length text token deltas paced at 100/s for 3s (a haiku-size LLM's token throughput) while a parallel reader drains the whole stream; SO is the end-to-end write+consume time beyond the 3s generation window (overhead/backpressure) · stream overhead (structured): same workload as stream overhead (text), but each delta is an AI-SDK-style structured object ({ type: 'text-delta', id, text }) instead of a raw string, so the SO gap vs the text scenario is the added serialization cost

🔴 marks a percentile over its target (within target is left unmarked). Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · SO 250/500/1000

All metrics are measured from deployment-side timestamps only. Runs are triggered by an in-deployment route that stamps the anchor (clientStart) right before start(), so the CI runner’s request and its path through api.vercel.com sit outside every measured window. TTFS = in-deployment start() → first step body (turbo uses the in-process fast path, non-turbo the dispatch path), and includes the VQS dispatch hop plus any /flow cold start. STSO/WO are measured between step bodies on the deployment. SL is measured inside the workflow (parallel reader/writer steps), so it no longer includes the api.vercel.com read path.

Cold starts are kept in the numbers on purpose — they are part of real bursty-workload latency. The workbench deployment cold-starts the /flow invocation for a large fraction of runs, inflating P75+; the Best column shows the fastest (warm-start) sample for comparison.

@mitul-s
mitul-s marked this pull request as draft August 4, 2026 17:44
Composing the replay key around the resolver forced an empty-object
sentinel and a separate hasLineage concept; making the resolver own all
lineage attributes returns undefined for no-lineage runs and keeps the
seed call site in its original shape.
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@mitul-s
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' feat(core): mirror replay lineage into a reserved $replayedFromRunId attribute by mitul-s · Pull Request #3329 · vercel/workflow · GitHub
Skip to content

feat(core): mirror replay lineage into a reserved $replayedFromRunId attribute - #3329

Draft
mitul-s wants to merge 2 commits into
mainfrom
mitul/replay-lineage-attribute
Draft

feat(core): mirror replay lineage into a reserved $replayedFromRunId attribute#3329
mitul-s wants to merge 2 commits into
mainfrom
mitul/replay-lineage-attribute

Conversation

@mitul-s

Copy link
Copy Markdown
Contributor

Summary

recreateRunFromExisting records its source run only on the new run's executionContext (replayedFromRunId, #2872). Attribute-indexed observability stores never see executionContext — the ClickHouse workflow_run_attributes table behind the Vercel dashboard's runs list only carries run attributes — so surfacing "which runs are replays" in a list currently requires a per-run world read (see vercel/front#79769, which fans out runs.getMany for every listed page).

This mirrors the replay lineage into the reserved $replayedFromRunId attribute, riding the exact mechanism $rootRunId/$parentRunId already use:

  • @workflow/world: export REPLAYED_FROM_RUN_ID_ATTRIBUTE ($replayedFromRunId) alongside the existing lineage attribute keys.
  • @workflow/corestart(): when replayedFromRunId is set and the spec version supports native attributes (v4+), seed the attribute on both the run_created event and the resilient-start queue input (with allowReservedAttributes, like parent lineage). Pre-v4 runs skip the attribute silently and keep the unconditional executionContext record, so replaying an old run never fails.
  • Validation of replayedFromRunId now runs before the attribute seed is composed; behavior is otherwise unchanged (a plain start() still emits no attributes field at all).

Once ingested, the dashboard's runs list can serve replay lineage straight from the attributes table and drop the per-run world fan-out.

Testing

  • packages/core: pnpm vitest run src/runtime/start.test.ts src/runtime/runs.test.ts — 82 passed, including new coverage: attribute seeded on both payloads, merges with caller attributes (caller keys last), skipped on pre-v4 spec with executionContext intact, and no empty attributes object on plain starts.
  • packages/world: full unit suite — 84 passed.
  • Biome and tsc show no new findings (the quickjs-runtime.ts typecheck errors and complexity warnings exist on main).

Made with Cursor

…attribute
recreateRunFromExisting records its source run only in the new run's
executionContext, which attribute-indexed observability stores (e.g. the
ClickHouse workflow_run_attributes table behind the dashboard runs list)
never see — so surfacing 'which runs are replays' in a list requires a
per-run world read. Seed the same value as the reserved
$replayedFromRunId attribute (like $rootRunId/$parentRunId) on worlds
with native attributes; pre-v4 spec versions skip the attribute silently
and keep the executionContext record.
Co-authored-by: Cursor <cursoragent@cursor.com>
@mitul-s
mitul-s requested a review from a team as a code ownerAugust 4, 2026 17:43
@vercel

vercelBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

changeset-botBot commented Aug 4, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1f2440a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@workflow/coreMinor
@workflow/worldMinor
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
workflowMinor
@workflow/world-testingPatch
@workflow/world-localPatch
@workflow/world-postgresPatch
@workflow/world-vercelPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

Some tests failed

❌ Failed E2E Tests

▲ Vercel Production (1 failed)

nextjs-webpack-node (1 failed):

  • outputStreamWorkflow positive startIndex (skips first chunk)
💻 Local Development (11 failed)

astro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

express-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

fastify-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

hono-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nitro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nuxt-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

sveltekit-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

vite-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable
📦 Local Production (13 failed)

astro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

express-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

fastify-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

hono-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nitro-stable-node (1 failed):

  • webhookWorkflow | wrun_41KZ6ZPQSC0GP0M9EQ9JGAEX80

nitro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nuxt-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

sveltekit-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

vite-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable
🐘 Local Postgres (12 failed)

astro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

express-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

fastify-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

hono-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nitro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nuxt-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

sveltekit-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

vite-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

🪟 Windows (1 failed)

nextjs-turbopack-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

📋 Other (6 failed)

e2e-local-dev-nest-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-dev-tanstack-start-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-postgres-nest-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-postgres-tanstack-start-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-prod-nest-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-prod-tanstack-start-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

E2E Test Summary

Summary
PassedFailedSkippedTotal
❌ ▲ Vercel Production277914963276
❌ 💻 Local Development3142114353588
❌ 📦 Local Production3277134543744
❌ 🐘 Local Postgres3278124543744
❌ 🪟 Windows31110312
❌ 📋 Other206264282496
✅ vercel-multi-region270027
Total1487644226717187
Details by Category

❌ ▲ Vercel Production

AppPassedFailedSkipped
✅ astro-node127029
✅ astro-quickjs127029
✅ example-node127029
✅ example-quickjs127029
✅ express-node127029
✅ express-quickjs127029
✅ fastify-node127029
✅ fastify-quickjs127029
✅ hono-node127029
✅ hono-quickjs127029
✅ nextjs-turbopack-node15204
❌ nextjs-webpack-node15114
✅ nextjs-webpack-quickjs15204
✅ nitro-node127029
✅ nitro-quickjs127029
✅ nuxt-node127029
✅ nuxt-quickjs127029
✅ sveltekit-node146010
✅ sveltekit-quickjs146010
✅ vite-node127029
✅ vite-quickjs127029

❌ 💻 Local Development

AppPassedFailedSkipped
✅ astro-stable-node130026
❌ astro-stable-quickjs129126
✅ express-stable-node130026
❌ express-stable-quickjs129126
✅ fastify-stable-node130026
❌ fastify-stable-quickjs129126
✅ hono-stable-node130026
❌ hono-stable-quickjs129126
✅ nextjs-turbopack-canary-node137019
❌ nextjs-turbopack-canary-quickjs136119
✅ nextjs-turbopack-stable-node15600
❌ nextjs-turbopack-stable-quickjs15510
✅ nextjs-webpack-canary-node137019
✅ nextjs-webpack-stable-node15600
❌ nextjs-webpack-stable-quickjs15510
✅ nitro-stable-node130026
❌ nitro-stable-quickjs129126
✅ nuxt-stable-node130026
❌ nuxt-stable-quickjs129126
✅ sveltekit-stable-node14907
❌ sveltekit-stable-quickjs14817
✅ vite-stable-node130026
❌ vite-stable-quickjs129126

❌ 📦 Local Production

AppPassedFailedSkipped
✅ astro-stable-node130026
❌ astro-stable-quickjs129126
✅ express-stable-node130026
❌ express-stable-quickjs129126
✅ fastify-stable-node130026
❌ fastify-stable-quickjs129126
✅ hono-stable-node130026
❌ hono-stable-quickjs129126
✅ nextjs-turbopack-canary-node137019
❌ nextjs-turbopack-canary-quickjs136119
✅ nextjs-turbopack-stable-node15600
❌ nextjs-turbopack-stable-quickjs15510
✅ nextjs-webpack-canary-node137019
❌ nextjs-webpack-canary-quickjs136119
✅ nextjs-webpack-stable-node15600
❌ nextjs-webpack-stable-quickjs15510
❌ nitro-stable-node129126
❌ nitro-stable-quickjs129126
✅ nuxt-stable-node130026
❌ nuxt-stable-quickjs129126
✅ sveltekit-stable-node14907
❌ sveltekit-stable-quickjs14817
✅ vite-stable-node130026
❌ vite-stable-quickjs129126

❌ 🐘 Local Postgres

AppPassedFailedSkipped
✅ astro-stable-node130026
❌ astro-stable-quickjs129126
✅ express-stable-node130026
❌ express-stable-quickjs129126
✅ fastify-stable-node130026
❌ fastify-stable-quickjs129126
✅ hono-stable-node130026
❌ hono-stable-quickjs129126
✅ nextjs-turbopack-canary-node137019
❌ nextjs-turbopack-canary-quickjs136119
✅ nextjs-turbopack-stable-node15600
❌ nextjs-turbopack-stable-quickjs15510
✅ nextjs-webpack-canary-node137019
❌ nextjs-webpack-canary-quickjs136119
✅ nextjs-webpack-stable-node15600
❌ nextjs-webpack-stable-quickjs15510
✅ nitro-stable-node130026
❌ nitro-stable-quickjs129126
✅ nuxt-stable-node130026
❌ nuxt-stable-quickjs129126
✅ sveltekit-stable-node14907
❌ sveltekit-stable-quickjs14817
✅ vite-stable-node130026
❌ vite-stable-quickjs129126

❌ 🪟 Windows

AppPassedFailedSkipped
✅ nextjs-turbopack-node15600
❌ nextjs-turbopack-quickjs15510

❌ 📋 Other

AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable-node130026
❌ e2e-local-dev-nest-stable-quickjs129126
✅ e2e-local-dev-tanstack-start-node130026
❌ e2e-local-dev-tanstack-start-quickjs129126
✅ e2e-local-postgres-nest-stable-node130026
❌ e2e-local-postgres-nest-stable-quickjs129126
✅ e2e-local-postgres-tanstack-start-node130026
❌ e2e-local-postgres-tanstack-start-quickjs129126
✅ e2e-local-prod-nest-stable-node130026
❌ e2e-local-prod-nest-stable-quickjs129126
✅ e2e-local-prod-tanstack-start-node130026
❌ e2e-local-prod-tanstack-start-quickjs129126
✅ e2e-vercel-prod-nest-node127029
✅ e2e-vercel-prod-nest-quickjs127029
✅ e2e-vercel-prod-tanstack-start-node127029
✅ e2e-vercel-prod-tanstack-start-quickjs127029

✅ vercel-multi-region

AppPassedFailedSkipped
✅ nextjs-turbopack2700

📋 View full workflow run

@github-actions

github-actionsBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 1f2440a · Tue, 04 Aug 2026 18:27:48 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep313 (+22%) 🔻1329 🔴 (+19%) 🔻1352 🔴 (+16%) 🔻1606 🔴 (+34%) 🔻30
TTFSstream1286 (+423%) 🔻1354 🔴 (+20%) 🔻1372 🔴 (+18%) 🔻1380 🔴 (+13%)30
TTFShook + stream1536 (+295%) 🔻1622 🔴 (+18%) 🔻1657 🔴 (+10%)1681 🔴 (-38%) 💚30
STSO1020 steps (inline)95 (-4.0%)128 (-16%) 💚145 (-21%) 💚237 (-29%) 💚1018
STSO1020 steps (queue-hop)3139 (+6.0%)3139 (+6.0%)3139 (+6.0%)3139 (+6.0%)1
WO1020 steps134775 (-12%)134775 (-12%)134775 (-12%)134775 (-12%)1
SLstream latency102 (+5.2%)142 🔴 (+3.6%)147 🔴 (-5.2%)159 🔴 (-76%) 💚30
SOstream overhead (text)102 (-18%) 💚144 (-66%) 💚154 (-81%) 💚224 (-93%) 💚30
SOstream overhead (structured)102 (-4.7%)165 (-45%) 💚197 (-65%) 💚293 (-68%) 💚30
📈 STSO distribution vs main (inline / queue-hop histograms)

1020 steps (inline)

Cumulative STSO time: main 149536ms → this run 130313ms (Δ -19223ms, -13%)

 50-100 ms ┃ main 1 this 6 +5
100-150 ms ███████████████████░░░░┃ main 721 this 930 +209
150-200 ms █┃████ main 227 this 65 -162
200-250 ms ┃ main 40 this 7 -33
250-300 ms ┃ main 12 this 5 -7
300-350 ms ┃ main 8 this 0 -8
350-400 ms ┃ main 5 this 3 -2
400-450 ms ┃ main 2 this 0 -2
550-600 ms ┃ main 1 this 1 +0
1100-1150 ms ┃ main 1 this 0 -1
4400-4450 ms ┃ main 0 this 1 +1

1020 steps (queue-hop)

Cumulative STSO time: main 2962ms → this run 3139ms (Δ +177ms, +6%)

2500-3000 ms ┃███████████████████████ main 1 this 0 -1
3000-3500 ms ░░░░░░░░░░░░░░░░░░░░░░░┃ main 0 this 1 +1
📜 Previous results (1)

70cc37f

Tue, 04 Aug 2026 18:00:52 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep1160 (+351%) 🔻1326 🔴 (+19%) 🔻1383 🔴 (+19%) 🔻1460 🔴 (+21%) 🔻30
TTFSstream1140 (+363%) 🔻1207 🔴 (+7.4%)1216 🔴 (+4.6%)1301 🔴 (+6.6%)30
TTFShook + stream1394 (+258%) 🔻1495 🔴 (+9.2%)1601 🔴 (+6.4%)5432 🔴 (+100%) 🔻30
STSO1020 steps (inline)83 (-16%) 💚118 (-23%) 💚137 (-25%) 💚201 (-40%) 💚1019
WO1020 steps118702 (-23%) 💚118702 (-23%) 💚118702 (-23%) 💚118702 (-23%) 💚1
SLstream latency94 (-3.1%)150 🔴 (+9.5%)176 🔴 (+14%)246 🔴 (-63%) 💚30
SOstream overhead (text)106 (-15%)162 (-61%) 💚229 (-72%) 💚3596 🔴 (+20%) 🔻30
SOstream overhead (structured)100 (-6.5%)147 (-51%) 💚173 (-69%) 💚215 (-77%) 💚30
ℹ️ Metric definitions & methodology

The collapsed STSO distribution section above buckets every step gap of the sequential-steps run (not a sampled window), split by whether the step ending the gap ran inline — in the same warm process as the step before it, so the gap is pure framework overhead — or after a queue-hop — the first step of a fresh process, which pays queue dispatch, client reinit and event-log replay. Bars overlay the two runs: is main, marks where this run lands, bridges the gap when this run has more samples in a bucket.

Best/P75/P90/P99 deltas compare against the most recent benchmark run on main at the time of this run. 🔻 flags a delta worse than +15%, 💚 one better than −15%.

Metrics — TTFS: time to first step body (in-deployment start() → first step body, deployment clocks) · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (whole-run time outside step bodies, in-deployment anchored) · SL: stream latency (in-deployment write → read propagation, readAt - writtenAt) · SO: stream overhead (end-to-end write+consume time beyond the modelled generation window)

Scenarios — step: one trivial no-op step, no stream; no hooks, so the run stays in turbo mode (in-process fast path) · stream: one streaming step; no hooks, so the run stays in turbo mode (in-process fast path) · hook + stream: registers a hook before one step, which exits turbo mode (dispatch path) · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges, and WO is the whole-run overhead outside step bodies · stream latency: parallel reader/writer steps on a dedicated stream; SL is the in-deployment write->read propagation (readAt - writtenAt) · stream overhead (text): writer streams 300 variable-length text token deltas paced at 100/s for 3s (a haiku-size LLM's token throughput) while a parallel reader drains the whole stream; SO is the end-to-end write+consume time beyond the 3s generation window (overhead/backpressure) · stream overhead (structured): same workload as stream overhead (text), but each delta is an AI-SDK-style structured object ({ type: 'text-delta', id, text }) instead of a raw string, so the SO gap vs the text scenario is the added serialization cost

🔴 marks a percentile over its target (within target is left unmarked). Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · SO 250/500/1000

All metrics are measured from deployment-side timestamps only. Runs are triggered by an in-deployment route that stamps the anchor (clientStart) right before start(), so the CI runner’s request and its path through api.vercel.com sit outside every measured window. TTFS = in-deployment start() → first step body (turbo uses the in-process fast path, non-turbo the dispatch path), and includes the VQS dispatch hop plus any /flow cold start. STSO/WO are measured between step bodies on the deployment. SL is measured inside the workflow (parallel reader/writer steps), so it no longer includes the api.vercel.com read path.

Cold starts are kept in the numbers on purpose — they are part of real bursty-workload latency. The workbench deployment cold-starts the /flow invocation for a large fraction of runs, inflating P75+; the Best column shows the fastest (warm-start) sample for comparison.

@mitul-s
mitul-s marked this pull request as draft August 4, 2026 17:44
Composing the replay key around the resolver forced an empty-object
sentinel and a separate hasLineage concept; making the resolver own all
lineage attributes returns undefined for no-lineage runs and keeps the
seed call site in its original shape.
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@mitul-s
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(core): mirror replay lineage into a reserved $replayedFromRunId attribute by mitul-s · Pull Request #3329 · vercel/workflow · GitHub
Skip to content

feat(core): mirror replay lineage into a reserved $replayedFromRunId attribute - #3329

Draft
mitul-s wants to merge 2 commits into
mainfrom
mitul/replay-lineage-attribute
Draft

feat(core): mirror replay lineage into a reserved $replayedFromRunId attribute#3329
mitul-s wants to merge 2 commits into
mainfrom
mitul/replay-lineage-attribute

Conversation

@mitul-s

Copy link
Copy Markdown
Contributor

Summary

recreateRunFromExisting records its source run only on the new run's executionContext (replayedFromRunId, #2872). Attribute-indexed observability stores never see executionContext — the ClickHouse workflow_run_attributes table behind the Vercel dashboard's runs list only carries run attributes — so surfacing "which runs are replays" in a list currently requires a per-run world read (see vercel/front#79769, which fans out runs.getMany for every listed page).

This mirrors the replay lineage into the reserved $replayedFromRunId attribute, riding the exact mechanism $rootRunId/$parentRunId already use:

  • @workflow/world: export REPLAYED_FROM_RUN_ID_ATTRIBUTE ($replayedFromRunId) alongside the existing lineage attribute keys.
  • @workflow/corestart(): when replayedFromRunId is set and the spec version supports native attributes (v4+), seed the attribute on both the run_created event and the resilient-start queue input (with allowReservedAttributes, like parent lineage). Pre-v4 runs skip the attribute silently and keep the unconditional executionContext record, so replaying an old run never fails.
  • Validation of replayedFromRunId now runs before the attribute seed is composed; behavior is otherwise unchanged (a plain start() still emits no attributes field at all).

Once ingested, the dashboard's runs list can serve replay lineage straight from the attributes table and drop the per-run world fan-out.

Testing

  • packages/core: pnpm vitest run src/runtime/start.test.ts src/runtime/runs.test.ts — 82 passed, including new coverage: attribute seeded on both payloads, merges with caller attributes (caller keys last), skipped on pre-v4 spec with executionContext intact, and no empty attributes object on plain starts.
  • packages/world: full unit suite — 84 passed.
  • Biome and tsc show no new findings (the quickjs-runtime.ts typecheck errors and complexity warnings exist on main).

Made with Cursor

…attribute
recreateRunFromExisting records its source run only in the new run's
executionContext, which attribute-indexed observability stores (e.g. the
ClickHouse workflow_run_attributes table behind the dashboard runs list)
never see — so surfacing 'which runs are replays' in a list requires a
per-run world read. Seed the same value as the reserved
$replayedFromRunId attribute (like $rootRunId/$parentRunId) on worlds
with native attributes; pre-v4 spec versions skip the attribute silently
and keep the executionContext record.
Co-authored-by: Cursor <cursoragent@cursor.com>
@mitul-s
mitul-s requested a review from a team as a code ownerAugust 4, 2026 17:43
@vercel

vercelBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

changeset-botBot commented Aug 4, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1f2440a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@workflow/coreMinor
@workflow/worldMinor
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
workflowMinor
@workflow/world-testingPatch
@workflow/world-localPatch
@workflow/world-postgresPatch
@workflow/world-vercelPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

Some tests failed

❌ Failed E2E Tests

▲ Vercel Production (1 failed)

nextjs-webpack-node (1 failed):

  • outputStreamWorkflow positive startIndex (skips first chunk)
💻 Local Development (11 failed)

astro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

express-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

fastify-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

hono-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nitro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nuxt-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

sveltekit-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

vite-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable
📦 Local Production (13 failed)

astro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

express-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

fastify-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

hono-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nitro-stable-node (1 failed):

  • webhookWorkflow | wrun_41KZ6ZPQSC0GP0M9EQ9JGAEX80

nitro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nuxt-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

sveltekit-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

vite-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable
🐘 Local Postgres (12 failed)

astro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

express-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

fastify-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

hono-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nitro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nuxt-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

sveltekit-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

vite-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

🪟 Windows (1 failed)

nextjs-turbopack-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

📋 Other (6 failed)

e2e-local-dev-nest-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-dev-tanstack-start-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-postgres-nest-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-postgres-tanstack-start-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-prod-nest-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-prod-tanstack-start-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

E2E Test Summary

Summary
PassedFailedSkippedTotal
❌ ▲ Vercel Production277914963276
❌ 💻 Local Development3142114353588
❌ 📦 Local Production3277134543744
❌ 🐘 Local Postgres3278124543744
❌ 🪟 Windows31110312
❌ 📋 Other206264282496
✅ vercel-multi-region270027
Total1487644226717187
Details by Category

❌ ▲ Vercel Production

AppPassedFailedSkipped
✅ astro-node127029
✅ astro-quickjs127029
✅ example-node127029
✅ example-quickjs127029
✅ express-node127029
✅ express-quickjs127029
✅ fastify-node127029
✅ fastify-quickjs127029
✅ hono-node127029
✅ hono-quickjs127029
✅ nextjs-turbopack-node15204
❌ nextjs-webpack-node15114
✅ nextjs-webpack-quickjs15204
✅ nitro-node127029
✅ nitro-quickjs127029
✅ nuxt-node127029
✅ nuxt-quickjs127029
✅ sveltekit-node146010
✅ sveltekit-quickjs146010
✅ vite-node127029
✅ vite-quickjs127029

❌ 💻 Local Development

AppPassedFailedSkipped
✅ astro-stable-node130026
❌ astro-stable-quickjs129126
✅ express-stable-node130026
❌ express-stable-quickjs129126
✅ fastify-stable-node130026
❌ fastify-stable-quickjs129126
✅ hono-stable-node130026
❌ hono-stable-quickjs129126
✅ nextjs-turbopack-canary-node137019
❌ nextjs-turbopack-canary-quickjs136119
✅ nextjs-turbopack-stable-node15600
❌ nextjs-turbopack-stable-quickjs15510
✅ nextjs-webpack-canary-node137019
✅ nextjs-webpack-stable-node15600
❌ nextjs-webpack-stable-quickjs15510
✅ nitro-stable-node130026
❌ nitro-stable-quickjs129126
✅ nuxt-stable-node130026
❌ nuxt-stable-quickjs129126
✅ sveltekit-stable-node14907
❌ sveltekit-stable-quickjs14817
✅ vite-stable-node130026
❌ vite-stable-quickjs129126

❌ 📦 Local Production

AppPassedFailedSkipped
✅ astro-stable-node130026
❌ astro-stable-quickjs129126
✅ express-stable-node130026
❌ express-stable-quickjs129126
✅ fastify-stable-node130026
❌ fastify-stable-quickjs129126
✅ hono-stable-node130026
❌ hono-stable-quickjs129126
✅ nextjs-turbopack-canary-node137019
❌ nextjs-turbopack-canary-quickjs136119
✅ nextjs-turbopack-stable-node15600
❌ nextjs-turbopack-stable-quickjs15510
✅ nextjs-webpack-canary-node137019
❌ nextjs-webpack-canary-quickjs136119
✅ nextjs-webpack-stable-node15600
❌ nextjs-webpack-stable-quickjs15510
❌ nitro-stable-node129126
❌ nitro-stable-quickjs129126
✅ nuxt-stable-node130026
❌ nuxt-stable-quickjs129126
✅ sveltekit-stable-node14907
❌ sveltekit-stable-quickjs14817
✅ vite-stable-node130026
❌ vite-stable-quickjs129126

❌ 🐘 Local Postgres

AppPassedFailedSkipped
✅ astro-stable-node130026
❌ astro-stable-quickjs129126
✅ express-stable-node130026
❌ express-stable-quickjs129126
✅ fastify-stable-node130026
❌ fastify-stable-quickjs129126
✅ hono-stable-node130026
❌ hono-stable-quickjs129126
✅ nextjs-turbopack-canary-node137019
❌ nextjs-turbopack-canary-quickjs136119
✅ nextjs-turbopack-stable-node15600
❌ nextjs-turbopack-stable-quickjs15510
✅ nextjs-webpack-canary-node137019
❌ nextjs-webpack-canary-quickjs136119
✅ nextjs-webpack-stable-node15600
❌ nextjs-webpack-stable-quickjs15510
✅ nitro-stable-node130026
❌ nitro-stable-quickjs129126
✅ nuxt-stable-node130026
❌ nuxt-stable-quickjs129126
✅ sveltekit-stable-node14907
❌ sveltekit-stable-quickjs14817
✅ vite-stable-node130026
❌ vite-stable-quickjs129126

❌ 🪟 Windows

AppPassedFailedSkipped
✅ nextjs-turbopack-node15600
❌ nextjs-turbopack-quickjs15510

❌ 📋 Other

AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable-node130026
❌ e2e-local-dev-nest-stable-quickjs129126
✅ e2e-local-dev-tanstack-start-node130026
❌ e2e-local-dev-tanstack-start-quickjs129126
✅ e2e-local-postgres-nest-stable-node130026
❌ e2e-local-postgres-nest-stable-quickjs129126
✅ e2e-local-postgres-tanstack-start-node130026
❌ e2e-local-postgres-tanstack-start-quickjs129126
✅ e2e-local-prod-nest-stable-node130026
❌ e2e-local-prod-nest-stable-quickjs129126
✅ e2e-local-prod-tanstack-start-node130026
❌ e2e-local-prod-tanstack-start-quickjs129126
✅ e2e-vercel-prod-nest-node127029
✅ e2e-vercel-prod-nest-quickjs127029
✅ e2e-vercel-prod-tanstack-start-node127029
✅ e2e-vercel-prod-tanstack-start-quickjs127029

✅ vercel-multi-region

AppPassedFailedSkipped
✅ nextjs-turbopack2700

📋 View full workflow run

@github-actions

github-actionsBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 1f2440a · Tue, 04 Aug 2026 18:27:48 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep313 (+22%) 🔻1329 🔴 (+19%) 🔻1352 🔴 (+16%) 🔻1606 🔴 (+34%) 🔻30
TTFSstream1286 (+423%) 🔻1354 🔴 (+20%) 🔻1372 🔴 (+18%) 🔻1380 🔴 (+13%)30
TTFShook + stream1536 (+295%) 🔻1622 🔴 (+18%) 🔻1657 🔴 (+10%)1681 🔴 (-38%) 💚30
STSO1020 steps (inline)95 (-4.0%)128 (-16%) 💚145 (-21%) 💚237 (-29%) 💚1018
STSO1020 steps (queue-hop)3139 (+6.0%)3139 (+6.0%)3139 (+6.0%)3139 (+6.0%)1
WO1020 steps134775 (-12%)134775 (-12%)134775 (-12%)134775 (-12%)1
SLstream latency102 (+5.2%)142 🔴 (+3.6%)147 🔴 (-5.2%)159 🔴 (-76%) 💚30
SOstream overhead (text)102 (-18%) 💚144 (-66%) 💚154 (-81%) 💚224 (-93%) 💚30
SOstream overhead (structured)102 (-4.7%)165 (-45%) 💚197 (-65%) 💚293 (-68%) 💚30
📈 STSO distribution vs main (inline / queue-hop histograms)

1020 steps (inline)

Cumulative STSO time: main 149536ms → this run 130313ms (Δ -19223ms, -13%)

 50-100 ms ┃ main 1 this 6 +5
100-150 ms ███████████████████░░░░┃ main 721 this 930 +209
150-200 ms █┃████ main 227 this 65 -162
200-250 ms ┃ main 40 this 7 -33
250-300 ms ┃ main 12 this 5 -7
300-350 ms ┃ main 8 this 0 -8
350-400 ms ┃ main 5 this 3 -2
400-450 ms ┃ main 2 this 0 -2
550-600 ms ┃ main 1 this 1 +0
1100-1150 ms ┃ main 1 this 0 -1
4400-4450 ms ┃ main 0 this 1 +1

1020 steps (queue-hop)

Cumulative STSO time: main 2962ms → this run 3139ms (Δ +177ms, +6%)

2500-3000 ms ┃███████████████████████ main 1 this 0 -1
3000-3500 ms ░░░░░░░░░░░░░░░░░░░░░░░┃ main 0 this 1 +1
📜 Previous results (1)

70cc37f

Tue, 04 Aug 2026 18:00:52 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep1160 (+351%) 🔻1326 🔴 (+19%) 🔻1383 🔴 (+19%) 🔻1460 🔴 (+21%) 🔻30
TTFSstream1140 (+363%) 🔻1207 🔴 (+7.4%)1216 🔴 (+4.6%)1301 🔴 (+6.6%)30
TTFShook + stream1394 (+258%) 🔻1495 🔴 (+9.2%)1601 🔴 (+6.4%)5432 🔴 (+100%) 🔻30
STSO1020 steps (inline)83 (-16%) 💚118 (-23%) 💚137 (-25%) 💚201 (-40%) 💚1019
WO1020 steps118702 (-23%) 💚118702 (-23%) 💚118702 (-23%) 💚118702 (-23%) 💚1
SLstream latency94 (-3.1%)150 🔴 (+9.5%)176 🔴 (+14%)246 🔴 (-63%) 💚30
SOstream overhead (text)106 (-15%)162 (-61%) 💚229 (-72%) 💚3596 🔴 (+20%) 🔻30
SOstream overhead (structured)100 (-6.5%)147 (-51%) 💚173 (-69%) 💚215 (-77%) 💚30
ℹ️ Metric definitions & methodology

The collapsed STSO distribution section above buckets every step gap of the sequential-steps run (not a sampled window), split by whether the step ending the gap ran inline — in the same warm process as the step before it, so the gap is pure framework overhead — or after a queue-hop — the first step of a fresh process, which pays queue dispatch, client reinit and event-log replay. Bars overlay the two runs: is main, marks where this run lands, bridges the gap when this run has more samples in a bucket.

Best/P75/P90/P99 deltas compare against the most recent benchmark run on main at the time of this run. 🔻 flags a delta worse than +15%, 💚 one better than −15%.

Metrics — TTFS: time to first step body (in-deployment start() → first step body, deployment clocks) · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (whole-run time outside step bodies, in-deployment anchored) · SL: stream latency (in-deployment write → read propagation, readAt - writtenAt) · SO: stream overhead (end-to-end write+consume time beyond the modelled generation window)

Scenarios — step: one trivial no-op step, no stream; no hooks, so the run stays in turbo mode (in-process fast path) · stream: one streaming step; no hooks, so the run stays in turbo mode (in-process fast path) · hook + stream: registers a hook before one step, which exits turbo mode (dispatch path) · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges, and WO is the whole-run overhead outside step bodies · stream latency: parallel reader/writer steps on a dedicated stream; SL is the in-deployment write->read propagation (readAt - writtenAt) · stream overhead (text): writer streams 300 variable-length text token deltas paced at 100/s for 3s (a haiku-size LLM's token throughput) while a parallel reader drains the whole stream; SO is the end-to-end write+consume time beyond the 3s generation window (overhead/backpressure) · stream overhead (structured): same workload as stream overhead (text), but each delta is an AI-SDK-style structured object ({ type: 'text-delta', id, text }) instead of a raw string, so the SO gap vs the text scenario is the added serialization cost

🔴 marks a percentile over its target (within target is left unmarked). Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · SO 250/500/1000

All metrics are measured from deployment-side timestamps only. Runs are triggered by an in-deployment route that stamps the anchor (clientStart) right before start(), so the CI runner’s request and its path through api.vercel.com sit outside every measured window. TTFS = in-deployment start() → first step body (turbo uses the in-process fast path, non-turbo the dispatch path), and includes the VQS dispatch hop plus any /flow cold start. STSO/WO are measured between step bodies on the deployment. SL is measured inside the workflow (parallel reader/writer steps), so it no longer includes the api.vercel.com read path.

Cold starts are kept in the numbers on purpose — they are part of real bursty-workload latency. The workbench deployment cold-starts the /flow invocation for a large fraction of runs, inflating P75+; the Best column shows the fastest (warm-start) sample for comparison.

@mitul-s
mitul-s marked this pull request as draft August 4, 2026 17:44
Composing the replay key around the resolver forced an empty-object
sentinel and a separate hasLineage concept; making the resolver own all
lineage attributes returns undefined for no-lineage runs and keeps the
seed call site in its original shape.
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@mitul-s
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(core): mirror replay lineage into a reserved $replayedFromRunId attribute by mitul-s · Pull Request #3329 · vercel/workflow · GitHub
Skip to content

feat(core): mirror replay lineage into a reserved $replayedFromRunId attribute - #3329

Draft
mitul-s wants to merge 2 commits into
mainfrom
mitul/replay-lineage-attribute
Draft

feat(core): mirror replay lineage into a reserved $replayedFromRunId attribute#3329
mitul-s wants to merge 2 commits into
mainfrom
mitul/replay-lineage-attribute

Conversation

@mitul-s

Copy link
Copy Markdown
Contributor

Summary

recreateRunFromExisting records its source run only on the new run's executionContext (replayedFromRunId, #2872). Attribute-indexed observability stores never see executionContext — the ClickHouse workflow_run_attributes table behind the Vercel dashboard's runs list only carries run attributes — so surfacing "which runs are replays" in a list currently requires a per-run world read (see vercel/front#79769, which fans out runs.getMany for every listed page).

This mirrors the replay lineage into the reserved $replayedFromRunId attribute, riding the exact mechanism $rootRunId/$parentRunId already use:

  • @workflow/world: export REPLAYED_FROM_RUN_ID_ATTRIBUTE ($replayedFromRunId) alongside the existing lineage attribute keys.
  • @workflow/corestart(): when replayedFromRunId is set and the spec version supports native attributes (v4+), seed the attribute on both the run_created event and the resilient-start queue input (with allowReservedAttributes, like parent lineage). Pre-v4 runs skip the attribute silently and keep the unconditional executionContext record, so replaying an old run never fails.
  • Validation of replayedFromRunId now runs before the attribute seed is composed; behavior is otherwise unchanged (a plain start() still emits no attributes field at all).

Once ingested, the dashboard's runs list can serve replay lineage straight from the attributes table and drop the per-run world fan-out.

Testing

  • packages/core: pnpm vitest run src/runtime/start.test.ts src/runtime/runs.test.ts — 82 passed, including new coverage: attribute seeded on both payloads, merges with caller attributes (caller keys last), skipped on pre-v4 spec with executionContext intact, and no empty attributes object on plain starts.
  • packages/world: full unit suite — 84 passed.
  • Biome and tsc show no new findings (the quickjs-runtime.ts typecheck errors and complexity warnings exist on main).

Made with Cursor

…attribute
recreateRunFromExisting records its source run only in the new run's
executionContext, which attribute-indexed observability stores (e.g. the
ClickHouse workflow_run_attributes table behind the dashboard runs list)
never see — so surfacing 'which runs are replays' in a list requires a
per-run world read. Seed the same value as the reserved
$replayedFromRunId attribute (like $rootRunId/$parentRunId) on worlds
with native attributes; pre-v4 spec versions skip the attribute silently
and keep the executionContext record.
Co-authored-by: Cursor <cursoragent@cursor.com>
@mitul-s
mitul-s requested a review from a team as a code ownerAugust 4, 2026 17:43
@vercel

vercelBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

changeset-botBot commented Aug 4, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1f2440a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@workflow/coreMinor
@workflow/worldMinor
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
workflowMinor
@workflow/world-testingPatch
@workflow/world-localPatch
@workflow/world-postgresPatch
@workflow/world-vercelPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

Some tests failed

❌ Failed E2E Tests

▲ Vercel Production (1 failed)

nextjs-webpack-node (1 failed):

  • outputStreamWorkflow positive startIndex (skips first chunk)
💻 Local Development (11 failed)

astro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

express-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

fastify-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

hono-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nitro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nuxt-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

sveltekit-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

vite-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable
📦 Local Production (13 failed)

astro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

express-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

fastify-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

hono-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nitro-stable-node (1 failed):

  • webhookWorkflow | wrun_41KZ6ZPQSC0GP0M9EQ9JGAEX80

nitro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nuxt-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

sveltekit-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

vite-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable
🐘 Local Postgres (12 failed)

astro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

express-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

fastify-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

hono-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nitro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nuxt-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

sveltekit-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

vite-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

🪟 Windows (1 failed)

nextjs-turbopack-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

📋 Other (6 failed)

e2e-local-dev-nest-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-dev-tanstack-start-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-postgres-nest-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-postgres-tanstack-start-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-prod-nest-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-prod-tanstack-start-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

E2E Test Summary

Summary
PassedFailedSkippedTotal
❌ ▲ Vercel Production277914963276
❌ 💻 Local Development3142114353588
❌ 📦 Local Production3277134543744
❌ 🐘 Local Postgres3278124543744
❌ 🪟 Windows31110312
❌ 📋 Other206264282496
✅ vercel-multi-region270027
Total1487644226717187
Details by Category

❌ ▲ Vercel Production

AppPassedFailedSkipped
✅ astro-node127029
✅ astro-quickjs127029
✅ example-node127029
✅ example-quickjs127029
✅ express-node127029
✅ express-quickjs127029
✅ fastify-node127029
✅ fastify-quickjs127029
✅ hono-node127029
✅ hono-quickjs127029
✅ nextjs-turbopack-node15204
❌ nextjs-webpack-node15114
✅ nextjs-webpack-quickjs15204
✅ nitro-node127029
✅ nitro-quickjs127029
✅ nuxt-node127029
✅ nuxt-quickjs127029
✅ sveltekit-node146010
✅ sveltekit-quickjs146010
✅ vite-node127029
✅ vite-quickjs127029

❌ 💻 Local Development

AppPassedFailedSkipped
✅ astro-stable-node130026
❌ astro-stable-quickjs129126
✅ express-stable-node130026
❌ express-stable-quickjs129126
✅ fastify-stable-node130026
❌ fastify-stable-quickjs129126
✅ hono-stable-node130026
❌ hono-stable-quickjs129126
✅ nextjs-turbopack-canary-node137019
❌ nextjs-turbopack-canary-quickjs136119
✅ nextjs-turbopack-stable-node15600
❌ nextjs-turbopack-stable-quickjs15510
✅ nextjs-webpack-canary-node137019
✅ nextjs-webpack-stable-node15600
❌ nextjs-webpack-stable-quickjs15510
✅ nitro-stable-node130026
❌ nitro-stable-quickjs129126
✅ nuxt-stable-node130026
❌ nuxt-stable-quickjs129126
✅ sveltekit-stable-node14907
❌ sveltekit-stable-quickjs14817
✅ vite-stable-node130026
❌ vite-stable-quickjs129126

❌ 📦 Local Production

AppPassedFailedSkipped
✅ astro-stable-node130026
❌ astro-stable-quickjs129126
✅ express-stable-node130026
❌ express-stable-quickjs129126
✅ fastify-stable-node130026
❌ fastify-stable-quickjs129126
✅ hono-stable-node130026
❌ hono-stable-quickjs129126
✅ nextjs-turbopack-canary-node137019
❌ nextjs-turbopack-canary-quickjs136119
✅ nextjs-turbopack-stable-node15600
❌ nextjs-turbopack-stable-quickjs15510
✅ nextjs-webpack-canary-node137019
❌ nextjs-webpack-canary-quickjs136119
✅ nextjs-webpack-stable-node15600
❌ nextjs-webpack-stable-quickjs15510
❌ nitro-stable-node129126
❌ nitro-stable-quickjs129126
✅ nuxt-stable-node130026
❌ nuxt-stable-quickjs129126
✅ sveltekit-stable-node14907
❌ sveltekit-stable-quickjs14817
✅ vite-stable-node130026
❌ vite-stable-quickjs129126

❌ 🐘 Local Postgres

AppPassedFailedSkipped
✅ astro-stable-node130026
❌ astro-stable-quickjs129126
✅ express-stable-node130026
❌ express-stable-quickjs129126
✅ fastify-stable-node130026
❌ fastify-stable-quickjs129126
✅ hono-stable-node130026
❌ hono-stable-quickjs129126
✅ nextjs-turbopack-canary-node137019
❌ nextjs-turbopack-canary-quickjs136119
✅ nextjs-turbopack-stable-node15600
❌ nextjs-turbopack-stable-quickjs15510
✅ nextjs-webpack-canary-node137019
❌ nextjs-webpack-canary-quickjs136119
✅ nextjs-webpack-stable-node15600
❌ nextjs-webpack-stable-quickjs15510
✅ nitro-stable-node130026
❌ nitro-stable-quickjs129126
✅ nuxt-stable-node130026
❌ nuxt-stable-quickjs129126
✅ sveltekit-stable-node14907
❌ sveltekit-stable-quickjs14817
✅ vite-stable-node130026
❌ vite-stable-quickjs129126

❌ 🪟 Windows

AppPassedFailedSkipped
✅ nextjs-turbopack-node15600
❌ nextjs-turbopack-quickjs15510

❌ 📋 Other

AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable-node130026
❌ e2e-local-dev-nest-stable-quickjs129126
✅ e2e-local-dev-tanstack-start-node130026
❌ e2e-local-dev-tanstack-start-quickjs129126
✅ e2e-local-postgres-nest-stable-node130026
❌ e2e-local-postgres-nest-stable-quickjs129126
✅ e2e-local-postgres-tanstack-start-node130026
❌ e2e-local-postgres-tanstack-start-quickjs129126
✅ e2e-local-prod-nest-stable-node130026
❌ e2e-local-prod-nest-stable-quickjs129126
✅ e2e-local-prod-tanstack-start-node130026
❌ e2e-local-prod-tanstack-start-quickjs129126
✅ e2e-vercel-prod-nest-node127029
✅ e2e-vercel-prod-nest-quickjs127029
✅ e2e-vercel-prod-tanstack-start-node127029
✅ e2e-vercel-prod-tanstack-start-quickjs127029

✅ vercel-multi-region

AppPassedFailedSkipped
✅ nextjs-turbopack2700

📋 View full workflow run

@github-actions

github-actionsBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 1f2440a · Tue, 04 Aug 2026 18:27:48 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep313 (+22%) 🔻1329 🔴 (+19%) 🔻1352 🔴 (+16%) 🔻1606 🔴 (+34%) 🔻30
TTFSstream1286 (+423%) 🔻1354 🔴 (+20%) 🔻1372 🔴 (+18%) 🔻1380 🔴 (+13%)30
TTFShook + stream1536 (+295%) 🔻1622 🔴 (+18%) 🔻1657 🔴 (+10%)1681 🔴 (-38%) 💚30
STSO1020 steps (inline)95 (-4.0%)128 (-16%) 💚145 (-21%) 💚237 (-29%) 💚1018
STSO1020 steps (queue-hop)3139 (+6.0%)3139 (+6.0%)3139 (+6.0%)3139 (+6.0%)1
WO1020 steps134775 (-12%)134775 (-12%)134775 (-12%)134775 (-12%)1
SLstream latency102 (+5.2%)142 🔴 (+3.6%)147 🔴 (-5.2%)159 🔴 (-76%) 💚30
SOstream overhead (text)102 (-18%) 💚144 (-66%) 💚154 (-81%) 💚224 (-93%) 💚30
SOstream overhead (structured)102 (-4.7%)165 (-45%) 💚197 (-65%) 💚293 (-68%) 💚30
📈 STSO distribution vs main (inline / queue-hop histograms)

1020 steps (inline)

Cumulative STSO time: main 149536ms → this run 130313ms (Δ -19223ms, -13%)

 50-100 ms ┃ main 1 this 6 +5
100-150 ms ███████████████████░░░░┃ main 721 this 930 +209
150-200 ms █┃████ main 227 this 65 -162
200-250 ms ┃ main 40 this 7 -33
250-300 ms ┃ main 12 this 5 -7
300-350 ms ┃ main 8 this 0 -8
350-400 ms ┃ main 5 this 3 -2
400-450 ms ┃ main 2 this 0 -2
550-600 ms ┃ main 1 this 1 +0
1100-1150 ms ┃ main 1 this 0 -1
4400-4450 ms ┃ main 0 this 1 +1

1020 steps (queue-hop)

Cumulative STSO time: main 2962ms → this run 3139ms (Δ +177ms, +6%)

2500-3000 ms ┃███████████████████████ main 1 this 0 -1
3000-3500 ms ░░░░░░░░░░░░░░░░░░░░░░░┃ main 0 this 1 +1
📜 Previous results (1)

70cc37f

Tue, 04 Aug 2026 18:00:52 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep1160 (+351%) 🔻1326 🔴 (+19%) 🔻1383 🔴 (+19%) 🔻1460 🔴 (+21%) 🔻30
TTFSstream1140 (+363%) 🔻1207 🔴 (+7.4%)1216 🔴 (+4.6%)1301 🔴 (+6.6%)30
TTFShook + stream1394 (+258%) 🔻1495 🔴 (+9.2%)1601 🔴 (+6.4%)5432 🔴 (+100%) 🔻30
STSO1020 steps (inline)83 (-16%) 💚118 (-23%) 💚137 (-25%) 💚201 (-40%) 💚1019
WO1020 steps118702 (-23%) 💚118702 (-23%) 💚118702 (-23%) 💚118702 (-23%) 💚1
SLstream latency94 (-3.1%)150 🔴 (+9.5%)176 🔴 (+14%)246 🔴 (-63%) 💚30
SOstream overhead (text)106 (-15%)162 (-61%) 💚229 (-72%) 💚3596 🔴 (+20%) 🔻30
SOstream overhead (structured)100 (-6.5%)147 (-51%) 💚173 (-69%) 💚215 (-77%) 💚30
ℹ️ Metric definitions & methodology

The collapsed STSO distribution section above buckets every step gap of the sequential-steps run (not a sampled window), split by whether the step ending the gap ran inline — in the same warm process as the step before it, so the gap is pure framework overhead — or after a queue-hop — the first step of a fresh process, which pays queue dispatch, client reinit and event-log replay. Bars overlay the two runs: is main, marks where this run lands, bridges the gap when this run has more samples in a bucket.

Best/P75/P90/P99 deltas compare against the most recent benchmark run on main at the time of this run. 🔻 flags a delta worse than +15%, 💚 one better than −15%.

Metrics — TTFS: time to first step body (in-deployment start() → first step body, deployment clocks) · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (whole-run time outside step bodies, in-deployment anchored) · SL: stream latency (in-deployment write → read propagation, readAt - writtenAt) · SO: stream overhead (end-to-end write+consume time beyond the modelled generation window)

Scenarios — step: one trivial no-op step, no stream; no hooks, so the run stays in turbo mode (in-process fast path) · stream: one streaming step; no hooks, so the run stays in turbo mode (in-process fast path) · hook + stream: registers a hook before one step, which exits turbo mode (dispatch path) · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges, and WO is the whole-run overhead outside step bodies · stream latency: parallel reader/writer steps on a dedicated stream; SL is the in-deployment write->read propagation (readAt - writtenAt) · stream overhead (text): writer streams 300 variable-length text token deltas paced at 100/s for 3s (a haiku-size LLM's token throughput) while a parallel reader drains the whole stream; SO is the end-to-end write+consume time beyond the 3s generation window (overhead/backpressure) · stream overhead (structured): same workload as stream overhead (text), but each delta is an AI-SDK-style structured object ({ type: 'text-delta', id, text }) instead of a raw string, so the SO gap vs the text scenario is the added serialization cost

🔴 marks a percentile over its target (within target is left unmarked). Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · SO 250/500/1000

All metrics are measured from deployment-side timestamps only. Runs are triggered by an in-deployment route that stamps the anchor (clientStart) right before start(), so the CI runner’s request and its path through api.vercel.com sit outside every measured window. TTFS = in-deployment start() → first step body (turbo uses the in-process fast path, non-turbo the dispatch path), and includes the VQS dispatch hop plus any /flow cold start. STSO/WO are measured between step bodies on the deployment. SL is measured inside the workflow (parallel reader/writer steps), so it no longer includes the api.vercel.com read path.

Cold starts are kept in the numbers on purpose — they are part of real bursty-workload latency. The workbench deployment cold-starts the /flow invocation for a large fraction of runs, inflating P75+; the Best column shows the fastest (warm-start) sample for comparison.

@mitul-s
mitul-s marked this pull request as draft August 4, 2026 17:44
Composing the replay key around the resolver forced an empty-object
sentinel and a separate hasLineage concept; making the resolver own all
lineage attributes returns undefined for no-lineage runs and keeps the
seed call site in its original shape.
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@mitul-s
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); feat(core): mirror replay lineage into a reserved $replayedFromRunId attribute by mitul-s · Pull Request #3329 · vercel/workflow · GitHub
Skip to content

feat(core): mirror replay lineage into a reserved $replayedFromRunId attribute - #3329

Draft
mitul-s wants to merge 2 commits into
mainfrom
mitul/replay-lineage-attribute
Draft

feat(core): mirror replay lineage into a reserved $replayedFromRunId attribute#3329
mitul-s wants to merge 2 commits into
mainfrom
mitul/replay-lineage-attribute

Conversation

@mitul-s

Copy link
Copy Markdown
Contributor

Summary

recreateRunFromExisting records its source run only on the new run's executionContext (replayedFromRunId, #2872). Attribute-indexed observability stores never see executionContext — the ClickHouse workflow_run_attributes table behind the Vercel dashboard's runs list only carries run attributes — so surfacing "which runs are replays" in a list currently requires a per-run world read (see vercel/front#79769, which fans out runs.getMany for every listed page).

This mirrors the replay lineage into the reserved $replayedFromRunId attribute, riding the exact mechanism $rootRunId/$parentRunId already use:

  • @workflow/world: export REPLAYED_FROM_RUN_ID_ATTRIBUTE ($replayedFromRunId) alongside the existing lineage attribute keys.
  • @workflow/corestart(): when replayedFromRunId is set and the spec version supports native attributes (v4+), seed the attribute on both the run_created event and the resilient-start queue input (with allowReservedAttributes, like parent lineage). Pre-v4 runs skip the attribute silently and keep the unconditional executionContext record, so replaying an old run never fails.
  • Validation of replayedFromRunId now runs before the attribute seed is composed; behavior is otherwise unchanged (a plain start() still emits no attributes field at all).

Once ingested, the dashboard's runs list can serve replay lineage straight from the attributes table and drop the per-run world fan-out.

Testing

  • packages/core: pnpm vitest run src/runtime/start.test.ts src/runtime/runs.test.ts — 82 passed, including new coverage: attribute seeded on both payloads, merges with caller attributes (caller keys last), skipped on pre-v4 spec with executionContext intact, and no empty attributes object on plain starts.
  • packages/world: full unit suite — 84 passed.
  • Biome and tsc show no new findings (the quickjs-runtime.ts typecheck errors and complexity warnings exist on main).

Made with Cursor

…attribute
recreateRunFromExisting records its source run only in the new run's
executionContext, which attribute-indexed observability stores (e.g. the
ClickHouse workflow_run_attributes table behind the dashboard runs list)
never see — so surfacing 'which runs are replays' in a list requires a
per-run world read. Seed the same value as the reserved
$replayedFromRunId attribute (like $rootRunId/$parentRunId) on worlds
with native attributes; pre-v4 spec versions skip the attribute silently
and keep the executionContext record.
Co-authored-by: Cursor <cursoragent@cursor.com>
@mitul-s
mitul-s requested a review from a team as a code ownerAugust 4, 2026 17:43
@vercel

vercelBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

@changeset-bot

changeset-botBot commented Aug 4, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1f2440a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@workflow/coreMinor
@workflow/worldMinor
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
workflowMinor
@workflow/world-testingPatch
@workflow/world-localPatch
@workflow/world-postgresPatch
@workflow/world-vercelPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

Some tests failed

❌ Failed E2E Tests

▲ Vercel Production (1 failed)

nextjs-webpack-node (1 failed):

  • outputStreamWorkflow positive startIndex (skips first chunk)
💻 Local Development (11 failed)

astro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

express-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

fastify-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

hono-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nitro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nuxt-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

sveltekit-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

vite-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable
📦 Local Production (13 failed)

astro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

express-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

fastify-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

hono-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nitro-stable-node (1 failed):

  • webhookWorkflow | wrun_41KZ6ZPQSC0GP0M9EQ9JGAEX80

nitro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nuxt-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

sveltekit-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

vite-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable
🐘 Local Postgres (12 failed)

astro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

express-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

fastify-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

hono-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-turbopack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-canary-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nextjs-webpack-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nitro-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

nuxt-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

sveltekit-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

vite-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

🪟 Windows (1 failed)

nextjs-turbopack-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

📋 Other (6 failed)

e2e-local-dev-nest-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-dev-tanstack-start-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-postgres-nest-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-postgres-tanstack-start-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-prod-nest-stable-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

e2e-local-prod-tanstack-start-quickjs (1 failed):

  • hookMinRetentionWorkflow - terminal Hook cannot resume and its token stays unavailable

E2E Test Summary

Summary
PassedFailedSkippedTotal
❌ ▲ Vercel Production277914963276
❌ 💻 Local Development3142114353588
❌ 📦 Local Production3277134543744
❌ 🐘 Local Postgres3278124543744
❌ 🪟 Windows31110312
❌ 📋 Other206264282496
✅ vercel-multi-region270027
Total1487644226717187
Details by Category

❌ ▲ Vercel Production

AppPassedFailedSkipped
✅ astro-node127029
✅ astro-quickjs127029
✅ example-node127029
✅ example-quickjs127029
✅ express-node127029
✅ express-quickjs127029
✅ fastify-node127029
✅ fastify-quickjs127029
✅ hono-node127029
✅ hono-quickjs127029
✅ nextjs-turbopack-node15204
❌ nextjs-webpack-node15114
✅ nextjs-webpack-quickjs15204
✅ nitro-node127029
✅ nitro-quickjs127029
✅ nuxt-node127029
✅ nuxt-quickjs127029
✅ sveltekit-node146010
✅ sveltekit-quickjs146010
✅ vite-node127029
✅ vite-quickjs127029

❌ 💻 Local Development

AppPassedFailedSkipped
✅ astro-stable-node130026
❌ astro-stable-quickjs129126
✅ express-stable-node130026
❌ express-stable-quickjs129126
✅ fastify-stable-node130026
❌ fastify-stable-quickjs129126
✅ hono-stable-node130026
❌ hono-stable-quickjs129126
✅ nextjs-turbopack-canary-node137019
❌ nextjs-turbopack-canary-quickjs136119
✅ nextjs-turbopack-stable-node15600
❌ nextjs-turbopack-stable-quickjs15510
✅ nextjs-webpack-canary-node137019
✅ nextjs-webpack-stable-node15600
❌ nextjs-webpack-stable-quickjs15510
✅ nitro-stable-node130026
❌ nitro-stable-quickjs129126
✅ nuxt-stable-node130026
❌ nuxt-stable-quickjs129126
✅ sveltekit-stable-node14907
❌ sveltekit-stable-quickjs14817
✅ vite-stable-node130026
❌ vite-stable-quickjs129126

❌ 📦 Local Production

AppPassedFailedSkipped
✅ astro-stable-node130026
❌ astro-stable-quickjs129126
✅ express-stable-node130026
❌ express-stable-quickjs129126
✅ fastify-stable-node130026
❌ fastify-stable-quickjs129126
✅ hono-stable-node130026
❌ hono-stable-quickjs129126
✅ nextjs-turbopack-canary-node137019
❌ nextjs-turbopack-canary-quickjs136119
✅ nextjs-turbopack-stable-node15600
❌ nextjs-turbopack-stable-quickjs15510
✅ nextjs-webpack-canary-node137019
❌ nextjs-webpack-canary-quickjs136119
✅ nextjs-webpack-stable-node15600
❌ nextjs-webpack-stable-quickjs15510
❌ nitro-stable-node129126
❌ nitro-stable-quickjs129126
✅ nuxt-stable-node130026
❌ nuxt-stable-quickjs129126
✅ sveltekit-stable-node14907
❌ sveltekit-stable-quickjs14817
✅ vite-stable-node130026
❌ vite-stable-quickjs129126

❌ 🐘 Local Postgres

AppPassedFailedSkipped
✅ astro-stable-node130026
❌ astro-stable-quickjs129126
✅ express-stable-node130026
❌ express-stable-quickjs129126
✅ fastify-stable-node130026
❌ fastify-stable-quickjs129126
✅ hono-stable-node130026
❌ hono-stable-quickjs129126
✅ nextjs-turbopack-canary-node137019
❌ nextjs-turbopack-canary-quickjs136119
✅ nextjs-turbopack-stable-node15600
❌ nextjs-turbopack-stable-quickjs15510
✅ nextjs-webpack-canary-node137019
❌ nextjs-webpack-canary-quickjs136119
✅ nextjs-webpack-stable-node15600
❌ nextjs-webpack-stable-quickjs15510
✅ nitro-stable-node130026
❌ nitro-stable-quickjs129126
✅ nuxt-stable-node130026
❌ nuxt-stable-quickjs129126
✅ sveltekit-stable-node14907
❌ sveltekit-stable-quickjs14817
✅ vite-stable-node130026
❌ vite-stable-quickjs129126

❌ 🪟 Windows

AppPassedFailedSkipped
✅ nextjs-turbopack-node15600
❌ nextjs-turbopack-quickjs15510

❌ 📋 Other

AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable-node130026
❌ e2e-local-dev-nest-stable-quickjs129126
✅ e2e-local-dev-tanstack-start-node130026
❌ e2e-local-dev-tanstack-start-quickjs129126
✅ e2e-local-postgres-nest-stable-node130026
❌ e2e-local-postgres-nest-stable-quickjs129126
✅ e2e-local-postgres-tanstack-start-node130026
❌ e2e-local-postgres-tanstack-start-quickjs129126
✅ e2e-local-prod-nest-stable-node130026
❌ e2e-local-prod-nest-stable-quickjs129126
✅ e2e-local-prod-tanstack-start-node130026
❌ e2e-local-prod-tanstack-start-quickjs129126
✅ e2e-vercel-prod-nest-node127029
✅ e2e-vercel-prod-nest-quickjs127029
✅ e2e-vercel-prod-tanstack-start-node127029
✅ e2e-vercel-prod-tanstack-start-quickjs127029

✅ vercel-multi-region

AppPassedFailedSkipped
✅ nextjs-turbopack2700

📋 View full workflow run

@github-actions

github-actionsBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 1f2440a · Tue, 04 Aug 2026 18:27:48 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep313 (+22%) 🔻1329 🔴 (+19%) 🔻1352 🔴 (+16%) 🔻1606 🔴 (+34%) 🔻30
TTFSstream1286 (+423%) 🔻1354 🔴 (+20%) 🔻1372 🔴 (+18%) 🔻1380 🔴 (+13%)30
TTFShook + stream1536 (+295%) 🔻1622 🔴 (+18%) 🔻1657 🔴 (+10%)1681 🔴 (-38%) 💚30
STSO1020 steps (inline)95 (-4.0%)128 (-16%) 💚145 (-21%) 💚237 (-29%) 💚1018
STSO1020 steps (queue-hop)3139 (+6.0%)3139 (+6.0%)3139 (+6.0%)3139 (+6.0%)1
WO1020 steps134775 (-12%)134775 (-12%)134775 (-12%)134775 (-12%)1
SLstream latency102 (+5.2%)142 🔴 (+3.6%)147 🔴 (-5.2%)159 🔴 (-76%) 💚30
SOstream overhead (text)102 (-18%) 💚144 (-66%) 💚154 (-81%) 💚224 (-93%) 💚30
SOstream overhead (structured)102 (-4.7%)165 (-45%) 💚197 (-65%) 💚293 (-68%) 💚30
📈 STSO distribution vs main (inline / queue-hop histograms)

1020 steps (inline)

Cumulative STSO time: main 149536ms → this run 130313ms (Δ -19223ms, -13%)

 50-100 ms ┃ main 1 this 6 +5
100-150 ms ███████████████████░░░░┃ main 721 this 930 +209
150-200 ms █┃████ main 227 this 65 -162
200-250 ms ┃ main 40 this 7 -33
250-300 ms ┃ main 12 this 5 -7
300-350 ms ┃ main 8 this 0 -8
350-400 ms ┃ main 5 this 3 -2
400-450 ms ┃ main 2 this 0 -2
550-600 ms ┃ main 1 this 1 +0
1100-1150 ms ┃ main 1 this 0 -1
4400-4450 ms ┃ main 0 this 1 +1

1020 steps (queue-hop)

Cumulative STSO time: main 2962ms → this run 3139ms (Δ +177ms, +6%)

2500-3000 ms ┃███████████████████████ main 1 this 0 -1
3000-3500 ms ░░░░░░░░░░░░░░░░░░░░░░░┃ main 0 this 1 +1
📜 Previous results (1)

70cc37f

Tue, 04 Aug 2026 18:00:52 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep1160 (+351%) 🔻1326 🔴 (+19%) 🔻1383 🔴 (+19%) 🔻1460 🔴 (+21%) 🔻30
TTFSstream1140 (+363%) 🔻1207 🔴 (+7.4%)1216 🔴 (+4.6%)1301 🔴 (+6.6%)30
TTFShook + stream1394 (+258%) 🔻1495 🔴 (+9.2%)1601 🔴 (+6.4%)5432 🔴 (+100%) 🔻30
STSO1020 steps (inline)83 (-16%) 💚118 (-23%) 💚137 (-25%) 💚201 (-40%) 💚1019
WO1020 steps118702 (-23%) 💚118702 (-23%) 💚118702 (-23%) 💚118702 (-23%) 💚1
SLstream latency94 (-3.1%)150 🔴 (+9.5%)176 🔴 (+14%)246 🔴 (-63%) 💚30
SOstream overhead (text)106 (-15%)162 (-61%) 💚229 (-72%) 💚3596 🔴 (+20%) 🔻30
SOstream overhead (structured)100 (-6.5%)147 (-51%) 💚173 (-69%) 💚215 (-77%) 💚30
ℹ️ Metric definitions & methodology

The collapsed STSO distribution section above buckets every step gap of the sequential-steps run (not a sampled window), split by whether the step ending the gap ran inline — in the same warm process as the step before it, so the gap is pure framework overhead — or after a queue-hop — the first step of a fresh process, which pays queue dispatch, client reinit and event-log replay. Bars overlay the two runs: is main, marks where this run lands, bridges the gap when this run has more samples in a bucket.

Best/P75/P90/P99 deltas compare against the most recent benchmark run on main at the time of this run. 🔻 flags a delta worse than +15%, 💚 one better than −15%.

Metrics — TTFS: time to first step body (in-deployment start() → first step body, deployment clocks) · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (whole-run time outside step bodies, in-deployment anchored) · SL: stream latency (in-deployment write → read propagation, readAt - writtenAt) · SO: stream overhead (end-to-end write+consume time beyond the modelled generation window)

Scenarios — step: one trivial no-op step, no stream; no hooks, so the run stays in turbo mode (in-process fast path) · stream: one streaming step; no hooks, so the run stays in turbo mode (in-process fast path) · hook + stream: registers a hook before one step, which exits turbo mode (dispatch path) · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges, and WO is the whole-run overhead outside step bodies · stream latency: parallel reader/writer steps on a dedicated stream; SL is the in-deployment write->read propagation (readAt - writtenAt) · stream overhead (text): writer streams 300 variable-length text token deltas paced at 100/s for 3s (a haiku-size LLM's token throughput) while a parallel reader drains the whole stream; SO is the end-to-end write+consume time beyond the 3s generation window (overhead/backpressure) · stream overhead (structured): same workload as stream overhead (text), but each delta is an AI-SDK-style structured object ({ type: 'text-delta', id, text }) instead of a raw string, so the SO gap vs the text scenario is the added serialization cost

🔴 marks a percentile over its target (within target is left unmarked). Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · SO 250/500/1000

All metrics are measured from deployment-side timestamps only. Runs are triggered by an in-deployment route that stamps the anchor (clientStart) right before start(), so the CI runner’s request and its path through api.vercel.com sit outside every measured window. TTFS = in-deployment start() → first step body (turbo uses the in-process fast path, non-turbo the dispatch path), and includes the VQS dispatch hop plus any /flow cold start. STSO/WO are measured between step bodies on the deployment. SL is measured inside the workflow (parallel reader/writer steps), so it no longer includes the api.vercel.com read path.

Cold starts are kept in the numbers on purpose — they are part of real bursty-workload latency. The workbench deployment cold-starts the /flow invocation for a large fraction of runs, inflating P75+; the Best column shows the fastest (warm-start) sample for comparison.

@mitul-s
mitul-s marked this pull request as draft August 4, 2026 17:44
Composing the replay key around the resolver forced an empty-object
sentinel and a separate hasLineage concept; making the resolver own all
lineage attributes returns undefined for no-lineage runs and keeps the
seed call site in its original shape.
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@mitul-s