') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Backport #3439: [core] Gate the unconsumed-event check on delivery idleness by github-actions[bot] · Pull Request #3442 · vercel/workflow · GitHub
Skip to content

Backport #3439: [core] Gate the unconsumed-event check on delivery idleness - #3442

Merged
VaguelySerious merged 1 commit into
stablefrom
backport/pr-3439-to-stable
Aug 11, 2026
Merged

Backport #3439: [core] Gate the unconsumed-event check on delivery idleness#3442
VaguelySerious merged 1 commit into
stablefrom
backport/pr-3439-to-stable

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Automated backport of #3439 to stable (backport job run).

AI recommendation: This is a pure correctness fix (patch changeset) for a real defect that exists on stable: the unconsumed-event check's fixed DEFERRED_CHECK_DELAY_MS window races in-flight deliveries and raises a spurious ReplayDivergenceError, which escalates to CorruptedEventLogError and kills otherwise healthy runs. The touched files (packages/core/src/events-consumer.ts, private.ts, workflow.ts) all exist on stable with the same timing-bet logic, and the change adds only an internal predicate plus tests, no user-facing API or feature. Note that stable lacks the hasParkedCommittedDelivery/delivery-barrier machinery from #3183, so the cherry-pick will need adaptation and careful review.

Merge conflicts were resolved by AI (opencode with anthropic/claude-opus-5). Please review the conflict resolution carefully before merging.

@github-actions
github-actionsBot requested review from a team and ijjk as code ownersAugust 11, 2026 00:42
@github-actionsgithub-actionsBot mentioned this pull request Aug 11, 2026
Merged
@changeset-bot

changeset-botBot commented Aug 11, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6233a82

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
NameType
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
workflowPatch
@workflow/world-testingPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Aug 11, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreviewAug 11, 2026 2:05am
example-nextjs-workflow-webpackReadyReadyPreviewAug 11, 2026 2:05am
example-workflowReadyReadyPreviewAug 11, 2026 2:05am
workbench-astro-workflowReadyReadyPreviewAug 11, 2026 2:05am
workbench-express-workflowReadyReadyPreviewAug 11, 2026 2:05am
workbench-fastify-workflowReadyReadyPreviewAug 11, 2026 2:05am
workbench-hono-workflowReadyReadyPreviewAug 11, 2026 2:05am
workbench-nestjs-workflowReadyReadyPreviewAug 11, 2026 2:05am
workbench-nitro-workflowReadyReadyPreviewAug 11, 2026 2:05am
workbench-nuxt-workflowReadyReadyPreviewAug 11, 2026 2:05am
workbench-python-workflowErrorErrorAug 11, 2026 2:05am
workbench-sveltekit-workflowReadyReadyPreviewAug 11, 2026 2:05am
workbench-tanstack-start-workflowReadyReadyPreviewAug 11, 2026 2:05am
workbench-vite-workflowReadyReadyPreviewAug 11, 2026 2:05am
workflow-docsReadyReadyPreview, v0Aug 11, 2026 2:05am
workflow-swc-playgroundReadyReadyPreviewAug 11, 2026 2:05am
workflow-tarballsReadyReadyPreviewAug 11, 2026 2:05am
workflow-webReadyReadyPreviewAug 11, 2026 2:05am

@github-actions@VaguelySerious
Gate the unconsumed-event check on delivery idleness (#3439)
6233a82
Signed-off-by: Peter Wielander <mittgfu@gmail.com>
@VaguelySerious
VaguelySeriousforce-pushed the backport/pr-3439-to-stable branch from feb1545 to 6233a82CompareAugust 11, 2026 02:02
@github-actions

github-actionsBot commented Aug 11, 2026•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

🧪 E2E Test Results

❌ Some tests failed

Summary

PassedFailedSkippedTotal
✅ ▲ Vercel Production10770781155
✅ 💻 Local Development11740861260
✅ 📦 Local Production11740861260
✅ 🐘 Local Postgres11740861260
✅ 🪟 Windows10500105
❌ 🌍 Community Worlds831019193
✅ 📋 Other594036630
Total53811013815863

❌ Failed Tests

🌍 Community Worlds (101 failed)

redis (18 failed):

  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KZQ91099BNMFAV93QM7R9JE3
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01KZQ91AX9BNX430NDCJN3HFCR
  • sleepingWorkflow | wrun_01KZQ928Z7PE25C6YGFSHFSPCV
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KZQ99XW60JKF5HQR6B21RR0P
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01KZQ9A9SDH5F834AT3FYZ055Z
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01KZQ9AHM9FENG810P7BHGD4KX
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01KZQ9AZ1W52AQNA0NY5SQ14J4
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01KZQ9BSAEN47TCBEXX0G9D46G
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01KZQ9BXRK5Z0Z1H68HTMYHQ7E
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01KZQ9C4045VG13BDRNM6ZW7M0
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01KZQ9C95JGT7MDH87ZFTCCFJ4
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01KZQ9CJ3D597EV6XYHZ8WC6Y7
  • pages router sleepingWorkflow via pages router
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KZQ9HW5ME6E6J64JJG61FYG1

turso (83 failed):

  • addTenWorkflow | wrun_01KZQ8ZVK0YF5SK4QG58P4VA47
  • addTenWorkflow | wrun_01KZQ8ZVK0YF5SK4QG58P4VA47
  • deploymentId: 'latest' is a no-op in non-Vercel worlds
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KZQ90BAKJMCHC42B4ZMHX8JH
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KZQ9027VG9NKQAMBQ9HGPK2Z
  • promiseRaceWorkflow | wrun_01KZQ906XDPXNCDYSWVY13YCBD
  • promiseAnyWorkflow | wrun_01KZQ9099SEP0BKRKRTBRVEY67
  • importedStepOnlyWorkflow | wrun_01KZQ90N6J21830V15CCSNJ0MK
  • readableStreamWorkflow | wrun_01KZQ90BRWREBGXQVHS0W4VCCA
  • hookWorkflow | wrun_01KZQ90R5BW5AWQYCAF1EFT9RW
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KZQ91099BNMFAV93QM7R9JE3
  • webhookWorkflow | wrun_01KZQ914NW9G09R0J9PS4Y8N97
  • parallelStepsThenWebhookWorkflow - no hook_conflict from same-tick replay race | wrun_01KZQ91AX9BNX430NDCJN3HFCR
  • sleepingWorkflow | wrun_01KZQ928Z7PE25C6YGFSHFSPCV
  • parallelSleepWorkflow | wrun_01KZQ92RHNXZY1AB8RHF2KCWGB
  • sleepWinsRaceWorkflow | wrun_01KZQ92W1TN7S79RYBS3YP53T9
  • stepWinsRaceWorkflow | wrun_01KZQ92ZQ607662NR91285KHT0
  • nullByteWorkflow | wrun_01KZQ9338X51SP18MDP3SR0RK6
  • workflowAndStepMetadataWorkflow | wrun_01KZQ935KWR758HWGHTD476W9T
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KZQ95DZ4Y1A78TE27DHPGMF7
  • writableForwardedFromWorkflowWorkflow | wrun_01KZQ95VTVA0TD163QE9K3DQB2
  • writableForwardedFromStepWorkflow | wrun_01KZQ9609ARY2XY1WTMS7V6X1H
  • fetchWorkflow | wrun_01KZQ963YC88701QHHVF5HG1PC
  • promiseRaceStressTestWorkflow | wrun_01KZQ967DJBXSEKZ2FNGH1PH7Z
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KZQ99GQDTQ80FC487ZZ76S45
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KZQ99XW60JKF5HQR6B21RR0P
  • hookGetConflictWorkflow - awaiting hook.getConflict() registers hook without payload | wrun_01KZQ9A9SDH5F834AT3FYZ055Z
  • 'hookGetConflictWithPriorStepWorkflow' - hook.getConflict() does not block step execution | wrun_01KZQ9ACCS140ZWGERK1J9GJ84
  • 'hookGetConflictWithParallelStepWorkfl…' - hook.getConflict() does not block step execution | wrun_01KZQ9AEVTFJ4KFY92PT798EY3
  • hookGetConflictThenStepParallelWorkflow - hook.getConflict() continuation step runs alongside other steps | wrun_01KZQ9AHM9FENG810P7BHGD4KX
  • hookGetConflictWorkflow - hook.getConflict() resolves with the conflicting run when token is already registered | wrun_01KZQ9AZ1W52AQNA0NY5SQ14J4
  • hookClaimOnlyMutexWorkflow - hook works as a pure run mutex without payload data | wrun_01KZQ9BSAEN47TCBEXX0G9D46G
  • hookAdoptOwnerResultWorkflow - duplicate adopts the owner result via conflict.returnValue | wrun_01KZQ9BXRK5Z0Z1H68HTMYHQ7E
  • hookSignalOwnerWorkflow - duplicate forwards its payload to the owner via resumeHook | wrun_01KZQ9C4045VG13BDRNM6ZW7M0
  • hookSupersedeOwnerWorkflow - duplicate cancels the owner and claims the released token | wrun_01KZQ9C95JGT7MDH87ZFTCCFJ4
  • resume-or-start route pattern - resumeHook retried after start() reaches the new run | wrun_01KZQ9CJ3D597EV6XYHZ8WC6Y7
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KZQ9CS9HN2CY2NABW7NF94K6
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KZQ9D8G3P1ZA7J0QB873G1XD
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KZQ9DGXMASBNM8HFPB8KBF64
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KZQ9DPB9HVMVFBAK37B7RY9F
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KZQ9DRXWSCREPX17MPTQVJFJ
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KZQ9E7000PTYJ5D2KQHHBN9V
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KZQ9ECC3PQ9Z1XEWJ33H3JR8
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KZQ9EHMSYP7RTFVPHK97150B
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KZQ9EQ5R4F91VKX6P08785AJ
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KZQ9EXQ6J9PXMN0E31RG96AN
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KZQ9F4HVA67H3FD6HWY6FR05
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KZQ9FB0S8YTQ8GG9C9A2MSDH
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KZQ9FNZ2H0M3B1ZRQAYJCVZR
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KZQ9FXY8TH8S58CX099PYQ9P
  • cancelRun - cancelling a running workflow | wrun_01KZQ9G4F6PB565CK5A7DNBVGP
  • cancelRun via CLI - cancelling a running workflow | wrun_01KZQ9G929255HPSH785M6RAVK
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KZQ9GFZ2YRBMQEZGFFDBBW68
  • hookWithSleepFinalStepWorkflow - step only on final payload | wrun_01KZQ9GVZD93VACY6V5WZC8DZY
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KZQ9H4G7KRCSG70ZER6EB1EP
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KZQ9HFH6FZEW7T1MW55PAJGE
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KZQ9HQ8P79N7S04R6WJS4E8M
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KZQ9HSNPVN9VX2PSD8PB5084
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KZQ9HW5ME6E6J64JJG61FYG1

Details by Category

✅ ▲ Vercel Production
AppPassedFailedSkipped
✅ astro9708
✅ example9708
✅ express9708
✅ fastify9708
✅ hono9708
✅ nextjs-turbopack10203
✅ nextjs-webpack10203
✅ nitro9708
✅ nuxt9708
✅ sveltekit9708
✅ vite9708
✅ 💻 Local Development
AppPassedFailedSkipped
✅ astro-stable9906
✅ express-stable9906
✅ fastify-stable9906
✅ hono-stable9906
✅ nextjs-turbopack-canary86019
✅ nextjs-turbopack-stable10500
✅ nextjs-webpack-canary86019
✅ nextjs-webpack-stable10500
✅ nitro-stable9906
✅ nuxt-stable9906
✅ sveltekit-stable9906
✅ vite-stable9906
✅ 📦 Local Production
AppPassedFailedSkipped
✅ astro-stable9906
✅ express-stable9906
✅ fastify-stable9906
✅ hono-stable9906
✅ nextjs-turbopack-canary86019
✅ nextjs-turbopack-stable10500
✅ nextjs-webpack-canary86019
✅ nextjs-webpack-stable10500
✅ nitro-stable9906
✅ nuxt-stable9906
✅ sveltekit-stable9906
✅ vite-stable9906
✅ 🐘 Local Postgres
AppPassedFailedSkipped
✅ astro-stable9906
✅ express-stable9906
✅ fastify-stable9906
✅ hono-stable9906
✅ nextjs-turbopack-canary86019
✅ nextjs-turbopack-stable10500
✅ nextjs-webpack-canary86019
✅ nextjs-webpack-stable10500
✅ nitro-stable9906
✅ nuxt-stable9906
✅ sveltekit-stable9906
✅ vite-stable9906
✅ 🪟 Windows
AppPassedFailedSkipped
✅ nextjs-turbopack10500
❌ 🌍 Community Worlds
AppPassedFailedSkipped
✅ mongodb-dev403
✅ redis-dev403
❌ redis68180
✅ turso-dev403
❌ turso3830
✅ 📋 Other
AppPassedFailedSkipped
✅ e2e-local-dev-nest-stable9906
✅ e2e-local-dev-tanstack-start-stable9906
✅ e2e-local-postgres-nest-stable9906
✅ e2e-local-postgres-tanstack-start-stable9906
✅ e2e-local-prod-nest-stable9906
✅ e2e-local-prod-tanstack-start-stable9906

📋 View full workflow run

@VaguelySerious

VaguelySerious commented Aug 11, 2026

Copy link
Copy Markdown
Member

(AI) Rebased onto current stable and resolved the conflict.

What caused it: the branch was cut when stable was at e822a6a173. Since then #3173 (backport of #3139) landed, which adds the delivery-barrier machinery to private.ts. The PR description's note that "stable lacks the hasParkedCommittedDelivery/delivery-barrier machinery" is now stale.

Resolution: because stable now has hasParkedCommittedDelivery and awaitEarlierDeliveries, the adaptation is no longer needed and the change converges on upstream. isDeliveryIdle / scheduleWhenIdle are now byte-identical to main:

exportfunctionisDeliveryIdle(ctx: WorkflowOrchestratorContext): boolean{returnctx.pendingDeliveries===0&&!hasParkedCommittedDelivery(ctx);}

The previous resolution had adapted this to pendingDeliveries === 0 alone. Keeping that would have been a regression: scheduleWhenIdle on stable checks pendingDeliveries > 0 || hasParkedCommittedDelivery(ctx), so routing it through a predicate that drops the second half would have silently reverted part of #3173. hasParkedCommittedDelivery stays unexported (nothing on stable imports it); the only other deviation from main is the two pre-existing stable gaps, no retained-session append() and no WORKFLOW_DEFERRED_CHECK_DELAY_MS override knob (envNumber does not exist in stable's world package), so the delay stays the DEFERRED_CHECK_DELAY_MS constant.

Validation:@workflow/core builds, typechecks, and all 836 src/ unit tests pass (the 6 e2e/ failures locally are the usual unbuilt-workbench/env-dependent ones).

Worth flagging for review: the shipped unconsumed-check-delivery-idle.test.ts only ever drives pendingDeliveries and leaves pendingDeliveryBarriers empty, so it passes under either version of the predicate. I wrote a throwaway test (not committed) that registers an armed step barrier with pendingDeliveries === 0, the parked-committed window from #3183. It fails 2/2 under the dropped-guard version and passes here. delivery-barrier-coverage.test.ts:536 also catches it, so CI would have gone red rather than merging the regression silently.

The workbench-python-workflow deployment failure is pre-existing: it fails on stable (6f301ba396) and on the previous PR head too.

@VaguelySerious
VaguelySerious enabled auto-merge (squash) August 11, 2026 02:07
@VaguelySerious
VaguelySerious merged commit 86bc000 into stableAug 11, 2026
94 of 98 checks passed
@VaguelySerious
VaguelySerious deleted the backport/pr-3439-to-stable branch August 11, 2026 02:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VaguelySeriousVaguelySeriousVaguelySerious approved these changes
@ijjkijjkAwaiting requested review from ijjkijjk is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@VaguelySerious