') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); fix(core): replay ordering - preserve adjacent hook delivery order by AndrewBarba · Pull Request #3552 · vercel/workflow · GitHub
Skip to content

fix(core): replay ordering - preserve adjacent hook delivery order - #3552

Merged
VaguelySerious merged 2 commits into
mainfrom
barba/fix-hook-delivery-ordering
Aug 14, 2026
Merged

fix(core): replay ordering - preserve adjacent hook delivery order#3552
VaguelySerious merged 2 commits into
mainfrom
barba/fix-hook-delivery-ordering

Conversation

@AndrewBarba

@AndrewBarbaAndrewBarba commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Description

#2473's synchronous replay drain can consume adjacent hook_received events before either workflow continuation runs. The delivery barriers added in #3139 order hooks against earlier waits and steps, but not against earlier hooks, so a later hook with a shorter consumer path can claim the next deterministic step ID first and permanently diverge from the event log.

This reproduced in eve's local-world unified HTTP session lifecycle: the reset-command hook was committed before the turn-result hook, but replay reached notifyTurnCallerStep where history required forwardTurnCancellationStep. Hook deliveries now defer behind earlier hook barriers as well, preserving the committed order across independent hook consumers.

How did you test your changes?

pnpm --filter @workflow/core test passes all 95 core test files (2,118 passing tests and 3 expected failures), including new coverage that reproduces the production ReplayDivergenceError without the fix. pnpm turbo build --filter=@workflow/core and the core typecheck also pass.

I linked the patched core into eve and ran EVE_E2E_MODEL=mock pnpm exec eve eval cancellation/unified-http-session-operations --strict four consecutive times. All four completed 28/28 gates without replay divergence; the stock core deterministically reproduced CORRUPTED_EVENT_LOG. The workspace-wide build remains unavailable locally because the unrelated SWC plugin requires Rust, which is not installed.

PR Checklist - Required to merge

  • 📦 pnpm changeset was run to create a changelog for this PR
    • Patch changeset for @workflow/core.
  • 🔒 DCO sign-off passes (git commit --signoff)
  • 📝 Ping @vercel/workflow in a comment once the PR is ready, and the above checklist is complete

Signed-off-by: Andrew Barba <barba@hey.com>
@vercel

vercelBot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreviewAug 14, 2026 5:13pm
example-nextjs-workflow-webpackReadyReadyPreviewAug 14, 2026 5:13pm
example-workflowReadyReadyPreviewAug 14, 2026 5:13pm
workbench-astro-workflowReadyReadyPreviewAug 14, 2026 5:13pm
workbench-express-workflowReadyReadyPreviewAug 14, 2026 5:13pm
workbench-fastify-workflowReadyReadyPreviewAug 14, 2026 5:13pm
workbench-hono-workflowReadyReadyPreviewAug 14, 2026 5:13pm
workbench-nestjs-workflowReadyReadyPreviewAug 14, 2026 5:13pm
workbench-nitro-workflowReadyReadyPreviewAug 14, 2026 5:13pm
workbench-nuxt-workflowReadyReadyPreviewAug 14, 2026 5:13pm
workbench-python-workflowErrorErrorAug 14, 2026 5:13pm
workbench-sveltekit-workflowReadyReadyPreviewAug 14, 2026 5:13pm
workbench-tanstack-start-workflowReadyReadyPreviewAug 14, 2026 5:13pm
workbench-vite-workflowReadyReadyPreviewAug 14, 2026 5:13pm
workflow-docsReadyReadyPreview, v0Aug 14, 2026 5:13pm
workflow-swc-playgroundReadyReadyPreviewAug 14, 2026 5:13pm
workflow-tarballsReadyReadyPreviewAug 14, 2026 5:13pm
workflow-webReadyReadyPreviewAug 14, 2026 5:13pm

@changeset-bot

changeset-botBot commented Aug 14, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 4f9757d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
NameType
@workflow/corePatch
@workflow/buildersPatch
@workflow/cliPatch
@workflow/nextPatch
@workflow/nitroPatch
@workflow/vitestPatch
@workflow/web-sharedPatch
@workflow/webPatch
workflowPatch
@workflow/world-testingPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
@workflow/nuxtPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AndrewBarba

Copy link
Copy Markdown
ContributorAuthor

@vercel/workflow ready for review.

@github-actions

github-actionsBot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

🧪 E2E Test Results

All tests passed

E2E Test Summary

Summary
PassedFailedSkippedTotal
✅ ▲ Vercel Production346605904056
✅ 💻 Local Development353605204056
✅ 📦 Local Production381005584368
✅ 🐘 Local Postgres381005584368
✅ 🪟 Windows31200312
✅ vercel-multi-region270027
Total149610222617187
Details by Category

✅ ▲ Vercel Production

AppPassedFailedSkipped
✅ astro-node128028
✅ astro-quickjs128028
✅ example-node128028
✅ example-quickjs128028
✅ express-node128028
✅ express-quickjs128028
✅ fastify-node128028
✅ fastify-quickjs128028
✅ hono-node128028
✅ hono-quickjs128028
✅ nest-node128028
✅ nest-quickjs128028
✅ nextjs-turbopack-node15303
✅ nextjs-turbopack-quickjs15303
✅ nextjs-webpack-node15303
✅ nextjs-webpack-quickjs15303
✅ nitro-node128028
✅ nitro-quickjs128028
✅ nuxt-node128028
✅ nuxt-quickjs128028
✅ sveltekit-node14709
✅ sveltekit-quickjs14709
✅ tanstack-start-node128028
✅ tanstack-start-quickjs128028
✅ vite-node128028
✅ vite-quickjs128028

✅ 💻 Local Development

AppPassedFailedSkipped
✅ astro-stable-node130026
✅ astro-stable-quickjs130026
✅ express-stable-node130026
✅ express-stable-quickjs130026
✅ fastify-stable-node130026
✅ fastify-stable-quickjs130026
✅ hono-stable-node130026
✅ hono-stable-quickjs130026
✅ nest-stable-node130026
✅ nest-stable-quickjs130026
✅ nextjs-turbopack-canary-node137019
✅ nextjs-turbopack-canary-quickjs137019
✅ nextjs-turbopack-stable-node15600
✅ nextjs-turbopack-stable-quickjs15600
✅ nextjs-webpack-stable-node15600
✅ nextjs-webpack-stable-quickjs15600
✅ nitro-stable-node130026
✅ nitro-stable-quickjs130026
✅ nuxt-stable-node130026
✅ nuxt-stable-quickjs130026
✅ sveltekit-stable-node14907
✅ sveltekit-stable-quickjs14907
✅ tanstack-start-node130026
✅ tanstack-start-quickjs130026
✅ vite-stable-node130026
✅ vite-stable-quickjs130026

✅ 📦 Local Production

AppPassedFailedSkipped
✅ astro-stable-node130026
✅ astro-stable-quickjs130026
✅ express-stable-node130026
✅ express-stable-quickjs130026
✅ fastify-stable-node130026
✅ fastify-stable-quickjs130026
✅ hono-stable-node130026
✅ hono-stable-quickjs130026
✅ nest-stable-node130026
✅ nest-stable-quickjs130026
✅ nextjs-turbopack-canary-node137019
✅ nextjs-turbopack-canary-quickjs137019
✅ nextjs-turbopack-stable-node15600
✅ nextjs-turbopack-stable-quickjs15600
✅ nextjs-webpack-canary-node137019
✅ nextjs-webpack-canary-quickjs137019
✅ nextjs-webpack-stable-node15600
✅ nextjs-webpack-stable-quickjs15600
✅ nitro-stable-node130026
✅ nitro-stable-quickjs130026
✅ nuxt-stable-node130026
✅ nuxt-stable-quickjs130026
✅ sveltekit-stable-node14907
✅ sveltekit-stable-quickjs14907
✅ tanstack-start-node130026
✅ tanstack-start-quickjs130026
✅ vite-stable-node130026
✅ vite-stable-quickjs130026

✅ 🐘 Local Postgres

AppPassedFailedSkipped
✅ astro-stable-node130026
✅ astro-stable-quickjs130026
✅ express-stable-node130026
✅ express-stable-quickjs130026
✅ fastify-stable-node130026
✅ fastify-stable-quickjs130026
✅ hono-stable-node130026
✅ hono-stable-quickjs130026
✅ nest-stable-node130026
✅ nest-stable-quickjs130026
✅ nextjs-turbopack-canary-node137019
✅ nextjs-turbopack-canary-quickjs137019
✅ nextjs-turbopack-stable-node15600
✅ nextjs-turbopack-stable-quickjs15600
✅ nextjs-webpack-canary-node137019
✅ nextjs-webpack-canary-quickjs137019
✅ nextjs-webpack-stable-node15600
✅ nextjs-webpack-stable-quickjs15600
✅ nitro-stable-node130026
✅ nitro-stable-quickjs130026
✅ nuxt-stable-node130026
✅ nuxt-stable-quickjs130026
✅ sveltekit-stable-node14907
✅ sveltekit-stable-quickjs14907
✅ tanstack-start-node130026
✅ tanstack-start-quickjs130026
✅ vite-stable-node130026
✅ vite-stable-quickjs130026

✅ 🪟 Windows

AppPassedFailedSkipped
✅ nextjs-turbopack-node15600
✅ nextjs-turbopack-quickjs15600

✅ vercel-multi-region

AppPassedFailedSkipped
✅ nextjs-turbopack2700

📋 View full workflow run

@github-actions

github-actionsBot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

📊 Workflow Benchmarks

commit 4f9757d · Fri, 14 Aug 2026 17:32:06 GMT · run logs

Backend: vercel · app: nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep1308 (+243%) 🔻1367 🔴 (+22%) 🔻1393 🔴 (+23%) 🔻1456 🔴 (-5.0%)30
TTFSstream1288 (+28%) 🔻1375 🔴 (+30%) 🔻1393 🔴 (+30%) 🔻1569 🔴 (+42%) 🔻30
TTFShook + stream1593 (+25%) 🔻1677 🔴 (+21%) 🔻1710 🔴 (+20%) 🔻1919 🔴 (+18%) 🔻30
Fan-out TTFSPromise.all(100 steps)8998 (+0.9%)10395 (+4.5%)10497 (+4.1%)15746 (+16%) 🔻10
Fan-out TTLSPromise.all(100 steps)17557 (-0.7%)19183 (+1.7%)19966 (+5.1%)24374 (+4.0%)10
STSO1020 steps (inline)130 (+5.7%)181 (-5.2%)203 (-11%)365 (-37%) 💚1019
WO1020 steps181172 (-7.3%)181172 (-7.3%)181172 (-7.3%)181172 (-7.3%)1
SLstream latency87 (+10%)138 🔴 (+25%) 🔻283 🔴 (+119%) 🔻380 🔴 (+11%)30
SOstream overhead (text)100 (-9.9%)162 (-10%)349 (+69%) 🔻1950 🔴 (+223%) 🔻30
SOstream overhead (structured)104 (+8.3%)155 (-0.6%)170 (+1.8%)398 (+119%) 🔻30
📈 STSO distribution vs main (inline / queue-hop histograms)

1020 steps (inline)

Cumulative STSO time: main 194368ms → this run 180976ms (Δ -13392ms, -7%)

 100-150 ms █████┃ main 180 this 175 -5
150-200 ms █████████████████████░░┃ main 627 this 723 +96
200-250 ms ██┃█ main 134 this 93 -41
250-300 ms ┃ main 29 this 13 -16
300-350 ms ┃ main 15 this 4 -11
350-400 ms ┃ main 11 this 3 -8
400-450 ms ┃ main 4 this 2 -2
450-500 ms ┃ main 5 this 0 -5
500-550 ms ┃ main 3 this 3 +0
550-600 ms ┃ main 1 this 1 +0
600-650 ms ┃ main 5 this 0 -5
650-700 ms ┃ main 1 this 0 -1
750-800 ms ┃ main 1 this 0 -1
800-850 ms ┃ main 1 this 1 +0
1100-1150 ms ┃ main 1 this 0 -1
4450-4500 ms ┃ main 1 this 0 -1
4750-4800 ms ┃ main 0 this 1 +1
📜 Previous results (1)

5dd4753

Fri, 14 Aug 2026 14:29:58 GMT · run logs

vercel / nextjs-turbopack

MetricScenarioBest (ms)P75 (ms)P90 (ms)P99 (ms)Samples
TTFSstep293 (-23%) 💚1374 🔴 (+23%) 🔻1405 🔴 (+24%) 🔻1477 🔴 (-3.6%)30
TTFSstream197 (-80%) 💚1345 🔴 (+27%) 🔻1354 🔴 (+27%) 🔻1486 🔴 (+34%) 🔻30
TTFShook + stream1585 (+24%) 🔻1670 🔴 (+20%) 🔻1754 🔴 (+23%) 🔻1946 🔴 (+20%) 🔻30
Fan-out TTFSPromise.all(100 steps)8905 (±0%)9353 (-6.0%)10490 (+4.1%)14498 (+7.2%)10
Fan-out TTLSPromise.all(100 steps)17443 (-1.3%)19081 (+1.1%)24466 (+29%) 🔻313435 (+1237%) 🔻10
STSO1020 steps (inline)111 (-9.8%)161 (-16%) 💚179 (-22%) 💚244 (-58%) 💚1019
WO1020 steps159023 (-19%) 💚159023 (-19%) 💚159023 (-19%) 💚159023 (-19%) 💚1
SLstream latency78 (-1.3%)105 🔴 (-4.5%)133 🔴 (+3.1%)207 🔴 (-40%) 💚30
SOstream overhead (text)104 (-6.3%)147 (-18%) 💚152 (-26%) 💚168 (-72%) 💚30
SOstream overhead (structured)114 (+19%) 🔻154 (-1.3%)180 (+7.8%)311 (+71%) 🔻30
ℹ️ Metric definitions & methodology

The collapsed STSO distribution section above buckets every step gap of the sequential-steps run (not a sampled window), split by whether the step ending the gap ran inline — in the same warm process as the step before it, so the gap is pure framework overhead — or after a queue-hop — the first step of a fresh process, which pays queue dispatch, client reinit and event-log replay. Bars overlay the two runs: is main, marks where this run lands, bridges the gap when this run has more samples in a bucket.

Best/P75/P90/P99 deltas compare against the most recent benchmark run on main at the time of this run. 🔻 flags a delta worse than +15%, 💚 one better than −15%.

Metrics — TTFS: time to first step body (in-deployment start() → first step body, deployment clocks) · Fan-out TTFS: fan-out time to first step (in-deployment start() → first of the parallel step bodies to complete) · Fan-out TTLS: fan-out time to last step (in-deployment start() → last of the parallel step bodies to complete, i.e. when the Promise.all resolves) · STSO: step-to-step overhead (gap between consecutive step bodies) · WO: workflow overhead (whole-run time outside step bodies, in-deployment anchored) · SL: stream latency (in-deployment write → read propagation, readAt - writtenAt) · SO: stream overhead (end-to-end write+consume time beyond the modelled generation window)

Scenarios — step: one trivial no-op step, no stream; no hooks, so the run stays in turbo mode (in-process fast path) · stream: one streaming step; no hooks, so the run stays in turbo mode (in-process fast path) · hook + stream: registers a hook before one step, which exits turbo mode (dispatch path) · 1020 steps: 1020 trivial sequential steps; STSO is measured between consecutive steps in the given step ranges, and WO is the whole-run overhead outside step bodies · Promise.all(100 steps): 100 trivial no-op steps started together in a single Promise.all; Fan-out TTFS is the first of them to complete and Fan-out TTLS the last, both from the in-deployment clientStart, so their gap is the spread the runtime adds across the fan-out · stream latency: parallel reader/writer steps on a dedicated stream; SL is the in-deployment write->read propagation (readAt - writtenAt) · stream overhead (text): writer streams 300 variable-length text token deltas paced at 100/s for 3s (a haiku-size LLM's token throughput) while a parallel reader drains the whole stream; SO is the end-to-end write+consume time beyond the 3s generation window (overhead/backpressure) · stream overhead (structured): same workload as stream overhead (text), but each delta is an AI-SDK-style structured object ({ type: 'text-delta', id, text }) instead of a raw string, so the SO gap vs the text scenario is the added serialization cost

🔴 marks a percentile over its target (within target is left unmarked). Targets (p75/p90/p99, ms) — TTFS 200/300/600 · SL 50/60/125 · SO 250/500/1000

All metrics are measured from deployment-side timestamps only. Runs are triggered by an in-deployment route that stamps the anchor (clientStart) right before start(), so the CI runner’s request and its path through api.vercel.com sit outside every measured window. TTFS = in-deployment start() → first step body (turbo uses the in-process fast path, non-turbo the dispatch path), and includes the VQS dispatch hop plus any /flow cold start. Fan-out TTFS/TTLS are the first and last step completions of a single Promise.all over trivial steps, from the same anchor, so the gap between the two rows is the spread the runtime adds across the fan-out. STSO/WO are measured between step bodies on the deployment. SL is measured inside the workflow (parallel reader/writer steps), so it no longer includes the api.vercel.com read path.

Cold starts are kept in the numbers on purpose — they are part of real bursty-workload latency. The workbench deployment cold-starts the /flow invocation for a large fraction of runs, inflating P75+; the Best column shows the fastest (warm-start) sample for comparison.

@github-actions

github-actionsBot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Sim World

Simulated world deterministic testing for races. Traces

🟠 Mint-ordered log — 3 fail of 41 total

log=mint-ordered · fence=per-spec

scenariooutcomeeventsvirtreplayviolations
smoke-no-stepscompleted30msok0
smoke-one-stepcompleted60msok0
hook-at-step-startedcompleted120msok0
hook-at-step-completedcompleted120msok0
hook-at-hook-createdcompleted120msok0
deadline-hook-winscompleted71.0hok0
deadline-expirescompleted71.0hok0
long-sleepcompleted1130.0dok0
hook-never-arrivesstalled30msskipped0
step-retries-twicecompleted102.0sok0
parallel-stepscompleted90msok0
hook-on-execution-statecompleted120msok0
peek-hook-before-branchcompleted120msok0
peek-hook-after-branchcompleted120msok0
peek-hook-at-registrationcompleted120msok0
race-hook-before-probecompleted120msok0
race-hook-after-probecompleted120msok0
race-duplicate-deliverycompleted130msok0
attr-hook-before-stepcompleted110msok0
attr-hook-after-stepcompleted110msok0
attr-from-step-bodycompleted130msok0
fork-hook-after-timeoutcompleted141.0mok0
fork-hook-before-timeoutcompleted141.0mok0
count-hook-after-timeoutcompleted171.0mok0
count-hook-before-timeoutcompleted201.0mok0
stale-read-step-count-forkcompleted201.0mok0
stale-read-equal-step-countscompleted141.0mok0
step-vs-step-forkcompleted120msok0
step-vs-step-fork-fencedcompleted120msok0
fence-catches-benign-directioncompleted125msok0
in-flight-before-decisionfailed91.0mMISMATCH1
in-flight-before-decision-countedfailed91.0mMISMATCH1
in-flight-after-decisionfailed91.0mMISMATCH1
stale-read-step-count-fork-fencedcompleted201.0mok0
fork-hook-winscompleted131.0mok0
fork-timeout-winscompleted131.0mok0
unclaimed-payload-under-forkcompleted171.0mok0
claimed-payload-under-forkcompleted171.0mok0
writers-independent-step-bodiescompleted120msok0
writers-scripted-tempocompleted120msok0
cancel-mid-stepcancelled70msskipped0

Full trace: world-sim-mint.txt

🟢 Append-only log — 0 fail of 41 total

log=append-only · fence=per-spec

scenariooutcomeeventsvirtreplayviolations
smoke-no-stepscompleted30msok0
smoke-one-stepcompleted60msok0
hook-at-step-startedcompleted120msok0
hook-at-step-completedcompleted120msok0
hook-at-hook-createdcompleted120msok0
deadline-hook-winscompleted71.0hok0
deadline-expirescompleted71.0hok0
long-sleepcompleted1130.0dok0
hook-never-arrivesstalled30msskipped0
step-retries-twicecompleted102.0sok0
parallel-stepscompleted90msok0
hook-on-execution-statecompleted120msok0
peek-hook-before-branchcompleted120msok0
peek-hook-after-branchcompleted120msok0
peek-hook-at-registrationcompleted120msok0
race-hook-before-probecompleted120msok0
race-hook-after-probecompleted120msok0
race-duplicate-deliverycompleted130msok0
attr-hook-before-stepcompleted110msok0
attr-hook-after-stepcompleted110msok0
attr-from-step-bodycompleted130msok0
fork-hook-after-timeoutcompleted141.0mok0
fork-hook-before-timeoutcompleted141.0mok0
count-hook-after-timeoutcompleted171.0mok0
count-hook-before-timeoutcompleted201.0mok0
stale-read-step-count-forkcompleted201.0mok0
stale-read-equal-step-countscompleted141.0mok0
step-vs-step-forkcompleted120msok0
step-vs-step-fork-fencedcompleted120msok0
fence-catches-benign-directioncompleted125msok0
in-flight-before-decisioncompleted171.0mok0
in-flight-before-decision-countedcompleted171.0mok0
in-flight-after-decisioncompleted192.0mok0
stale-read-step-count-fork-fencedcompleted201.0mok0
fork-hook-winscompleted131.0mok0
fork-timeout-winscompleted131.0mok0
unclaimed-payload-under-forkcompleted171.0mok0
claimed-payload-under-forkcompleted171.0mok0
writers-independent-step-bodiescompleted120msok0
writers-scripted-tempocompleted120msok0
cancel-mid-stepcancelled70msskipped0

Full trace: world-sim-append-only.txt

@VaguelySeriousVaguelySerious added the event-log-race-repro Run the event log race reproduction job label Aug 14, 2026

@VaguelySeriousVaguelySerious left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for a few test jobs to complete before approving

@github-actions

github-actionsBot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Event Log Race Repro

No event-log regressions in the latest repro job.

Run History

Metric2026-08-14 16:41 UTC #1
logs / deploy
2026-08-14 17:15 UTC #1
logs / deploy
Resultno regressionsno regressions
Total1414
completed1414
CORRUPTED_EVENT_LOG00
USER_ERROR00
RUNTIME_ERROR00
stuck00
other00
infra00
Config14 runs / step-storm 6, hook-storm 6, hook-sleep 2 / c8 / 6x814 runs / step-storm 6, hook-storm 6, hook-sleep 2 / c8 / 6x8
Timingwatchdog 2500ms / step 2200±250ms / stagger 400ms / poke 750ms / timeout 240000mswatchdog 2500ms / step 2200±250ms / stagger 400ms / poke 750ms / timeout 240000ms

Latest Scenario Breakdown

ScenarioTotalcompletedCORRUPTED_EVENT_LOGUSER_ERRORRUNTIME_ERRORstuckotherinfra
step-storm66000000
hook-storm66000000
hook-sleep22000000

@github-actions

github-actionsBot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Event Log Race Repro (world-postgres)

6 of 14 latest repro runs hit event-log regressions.

Run History

Metric2026-08-14 16:45 UTC #1
logs / deploy
2026-08-14 17:18 UTC #1
logs / deploy
Result6/14 regressions6/14 regressions
Total1414
completed88
CORRUPTED_EVENT_LOG00
USER_ERROR00
RUNTIME_ERROR00
stuck66
other00
infra00
Config14 runs / step-storm 6, hook-storm 6, hook-sleep 2 / c8 / 6x814 runs / step-storm 6, hook-storm 6, hook-sleep 2 / c8 / 6x8
Timingwatchdog 2500ms / step 2200±250ms / stagger 400ms / poke 750ms / timeout 240000mswatchdog 2500ms / step 2200±250ms / stagger 400ms / poke 750ms / timeout 240000ms

Latest Scenario Breakdown

ScenarioTotalcompletedCORRUPTED_EVENT_LOGUSER_ERRORRUNTIME_ERRORstuckotherinfra
step-storm60000600
hook-storm66000000
hook-sleep22000000

Latest Non-Completed Runs

ScenarioAttemptOutcomeStatusError codeRun
step-storm2stuckrunningwrun_01M00M50D2RPZ0ZPB9SFM3PRY8
step-storm1stuckrunningwrun_01M00M50D2RPZ0ZPB9SFM3PRY7
step-storm4stuckrunningwrun_01M00M50D2RPZ0ZPB9SFM3PRY4
step-storm5stuckrunningwrun_01M00M50D2RPZ0ZPB9SFM3PRY5
step-storm6stuckrunningwrun_01M00M50D2RPZ0ZPB9SFM3PRY6
step-storm3stuckrunningwrun_01M00M50D2RPZ0ZPB9SFM3PRY3

@AndrewBarba
AndrewBarba enabled auto-merge (squash) August 14, 2026 17:14
@VaguelySerious
VaguelySerious merged commit 3560218 into mainAug 14, 2026
166 of 170 checks passed
@VaguelySerious
VaguelySerious deleted the barba/fix-hook-delivery-ordering branch August 14, 2026 17:51
@github-actionsgithub-actionsBot mentioned this pull request Aug 14, 2026
github-actionsBot added a commit that referenced this pull request Aug 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Backport PR opened against stable: #3557. Merge conflicts were resolved by AI — please review carefully. (backport job run)

pranaygp pushed a commit that referenced this pull request Aug 24, 2026
)
Signed-off-by: Andrew Barba <barba@hey.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actionsgithub-actionsBot mentioned this pull request Aug 24, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

event-log-race-reproRun the event log race reproduction job

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AndrewBarba@VaguelySerious