[web-shared] Optimize MiddleTruncate resize measurements - #3630

Merged
mitul-s merged 1 commit into
mainfrom
c+ms/update-middle-truncate-2065
Aug 18, 2026
Merged

[web-shared] Optimize MiddleTruncate resize measurements#3630
mitul-s merged 1 commit into
mainfrom
c+ms/update-middle-truncate-2065

Conversation

@mitul-s

@mitul-smitul-s commented Aug 18, 2026•
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Ports the MiddleTruncate resize-performance changes from vercel/front#80351 into the observability UI copy. Resize work is now coalesced across instances, all layout reads happen before text-measurement writes, and unchanged text measurements are cached.

The copy-selection path also avoids unnecessary range calculations and handles invalid DOM ranges defensively.

How did you test your changes?

  • pnpm turbo build --filter="@workflow/web-shared..."
  • pnpm --filter @workflow/web-shared typecheck
  • pnpm --filter @workflow/web-shared test on Node 22.22.2 (201 tests passed)
  • pnpm --filter @workflow/web-shared lint (exits successfully with the package's existing warnings)
  • Added focused regressions for cross-instance read/write batching, repeated resize coalescing, and cleanup on unmount

PR Checklist - Required to merge

  • 📦 pnpm changeset was run to create a changelog for this PR
  • 🔒 DCO sign-off passes (run git commit --signoff on your commits)
  • 📝 Ping @vercel/workflow in a comment once the PR is ready, and the above checklist is complete
Open in WebOpen in Cursor

@vercel

vercelBot commented Aug 18, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreviewAug 18, 2026 9:50pm
example-nextjs-workflow-webpackReadyReadyPreviewAug 18, 2026 9:50pm
example-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-astro-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-express-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-fastify-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-hono-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-nestjs-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-nitro-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-nuxt-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-python-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-sveltekit-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-tanstack-start-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-vite-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workflow-docsReadyReadyPreview, v0Aug 18, 2026 9:50pm
workflow-swc-playgroundReadyReadyPreviewAug 18, 2026 9:50pm
workflow-tarballsReadyReadyPreviewAug 18, 2026 9:50pm
workflow-webReadyReadyPreviewAug 18, 2026 9:50pm

@changeset-bot

changeset-botBot commented Aug 18, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 06dcc45

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
NameType
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/cliPatch
@workflow/nitroPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Sim World

Simulated world deterministic testing for races. Traces

🟠 world-sim scenario book — 1 fail of 41 total

fence=per-spec

scenariooutcomeeventsvirtreplayviolations
✅ smoke-no-stepscompleted30msok0
✅ smoke-one-stepcompleted60msok0
✅ hook-at-step-startedcompleted120msok0
✅ hook-at-step-completedcompleted120msok0
✅ hook-at-hook-createdcompleted120msok0
✅ deadline-hook-winscompleted71.0hok0
✅ deadline-expirescompleted71.0hok0
✅ long-sleepcompleted1130.0dok0
✅ hook-never-arrivesstalled30msskipped0
✅ step-retries-twicecompleted102.0sok0
✅ parallel-stepscompleted90msok0
✅ hook-on-execution-statecompleted120msok0
✅ peek-hook-before-branchcompleted120msok0
✅ peek-hook-after-branchcompleted120msok0
✅ peek-hook-at-registrationcompleted120msok0
✅ race-hook-before-probecompleted120msok0
✅ race-hook-after-probecompleted120msok0
✅ race-duplicate-deliverycompleted130msok0
✅ attr-hook-before-stepcompleted110msok0
✅ attr-hook-after-stepcompleted110msok0
✅ attr-from-step-bodycompleted130msok0
✅ fork-hook-after-timeoutcompleted141.0mok0
✅ fork-hook-before-timeoutcompleted141.0mok0
✅ count-hook-after-timeoutcompleted171.0mok0
✅ count-hook-before-timeoutcompleted201.0mok0
✅ stale-read-step-count-forkcompleted201.0mok0
✅ stale-read-equal-step-countscompleted141.0mok0
✅ step-vs-step-forkcompleted120msok0
✅ step-vs-step-fork-fencedcompleted120msok0
✅ fence-catches-benign-directioncompleted125msok0
✅ in-flight-before-decisioncompleted171.0mok0
❌ in-flight-before-decision-countedcompleted171.0mok0
✅ in-flight-after-decisioncompleted192.0mok0
✅ stale-read-step-count-fork-fencedcompleted201.0mok0
✅ fork-hook-winscompleted131.0mok0
✅ fork-timeout-winscompleted131.0mok0
✅ unclaimed-payload-under-forkcompleted171.0mok0
✅ claimed-payload-under-forkcompleted171.0mok0
✅ writers-independent-step-bodiescompleted120msok0
✅ writers-scripted-tempocompleted120msok0
✅ cancel-mid-stepcancelled70msskipped0

Full trace: world-sim.txt

@mitul-s
mitul-s marked this pull request as ready for review August 18, 2026 21:52
@mitul-s
mitul-s requested a review from a team as a code ownerAugust 18, 2026 21:52
@mitul-s
mitul-s enabled auto-merge (squash) August 18, 2026 21:52
karthikscale3
karthikscale3 approved these changes Aug 18, 2026
View reviewed changes

@karthikscale3karthikscale3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Keep the window resize listener when ResizeObserver exists. The new if (!ro) condition means viewport resizing no longer schedules recalculation in modern browsers. ResizeObserver only fires when the observed element’s box changes; responsive typography can change at a media-query breakpoint while its fixed-width container remains unchanged. The cached truncation then reflects the old font metrics. Registering the coalesced window listener unconditionally preserves the previous behavior. use-middle-truncate.ts:227

@mitul-s
mitul-s merged commit 6ca2f1b into mainAug 18, 2026
63 checks passed
@mitul-s
mitul-s deleted the c+ms/update-middle-truncate-2065 branch August 18, 2026 22:39
@github-actions

github-actionsBot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

No backport to stable for 6ca2f1b (AI decision).

This is a performance optimization: it batches/coalesces MiddleTruncate resize measurements across instances and caches text widths, which is not fixing a user-visible stability defect on stable (the existing per-instance rAF debounce already worked, just less efficiently). The only defect-like parts are incidental — a try/catch around invalid DOM Range construction in getRangeOffsets and the selectionText.includes(ELLIPSIS) guard in the copy handler — so a human could split those out and force a backport via workflow_dispatch if desired.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

6ca2f1b3b78dbb811476cdc2848755db108d3022

@github-actionsgithub-actionsBot mentioned this pull request Aug 18, 2026
Closed
This was referenced Aug 19, 2026
Open
Closed
Open
Merged
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karthikscale3karthikscale3karthikscale3 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mitul-s@karthikscale3@cursoragent
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[web-shared] Optimize MiddleTruncate resize measurements - #3630
Merged
mitul-s merged 1 commit into
mainfrom 
c+ms/update-middle-truncate-2065
Aug 18, 2026
Merged
[web-shared] Optimize MiddleTruncate resize measurements#3630
mitul-s merged 1 commit into
mainfrom 
c+ms/update-middle-truncate-2065
Conversation
@mitul-s
@mitul-smitul-s
commented
Aug 18, 2026•

edited by cursor
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
Ports the MiddleTruncate resize-performance changes from vercel/front#80351 into the observability UI copy. Resize work is now coalesced across instances, all layout reads happen before text-measurement writes, and unchanged text measurements are cached.
The copy-selection path also avoids unnecessary range calculations and handles invalid DOM ranges defensively.
How did you test your changes?
  • pnpm turbo build --filter="@workflow/web-shared..."
  • pnpm --filter @workflow/web-shared typecheck
  • pnpm --filter @workflow/web-shared test on Node 22.22.2 (201 tests passed)
  • pnpm --filter @workflow/web-shared lint (exits successfully with the package's existing warnings)
  • Added focused regressions for cross-instance read/write batching, repeated resize coalescing, and cleanup on unmount
PR Checklist - Required to merge
  •  📦 pnpm changeset was run to create a changelog for this PR
  •  🔒 DCO sign-off passes (run git commit --signoff on your commits)
  •  📝 Ping @vercel/workflow in a comment once the PR is ready, and the above checklist is complete
Open in WebOpen in Cursor
@vercel
vercelBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreviewAug 18, 2026 9:50pm
example-nextjs-workflow-webpackReadyReadyPreviewAug 18, 2026 9:50pm
example-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-astro-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-express-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-fastify-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-hono-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-nestjs-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-nitro-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-nuxt-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-python-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-sveltekit-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-tanstack-start-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-vite-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workflow-docsReadyReadyPreview, v0Aug 18, 2026 9:50pm
workflow-swc-playgroundReadyReadyPreviewAug 18, 2026 9:50pm
workflow-tarballsReadyReadyPreviewAug 18, 2026 9:50pm
workflow-webReadyReadyPreviewAug 18, 2026 9:50pm
@changeset-bot
changeset-botBot
commented
Aug 18, 2026

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 06dcc45
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/cliPatch
@workflow/nitroPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@github-actions
github-actionsBot
commented
Aug 18, 2026

Copy link


Copy Markdown

Contributor
Sim World
Simulated world deterministic testing for races. Traces
🟠 world-sim scenario book — 1 fail of 41 total
fence=per-spec
scenariooutcomeeventsvirtreplayviolations
✅ smoke-no-stepscompleted30msok0
✅ smoke-one-stepcompleted60msok0
✅ hook-at-step-startedcompleted120msok0
✅ hook-at-step-completedcompleted120msok0
✅ hook-at-hook-createdcompleted120msok0
✅ deadline-hook-winscompleted71.0hok0
✅ deadline-expirescompleted71.0hok0
✅ long-sleepcompleted1130.0dok0
✅ hook-never-arrivesstalled30msskipped0
✅ step-retries-twicecompleted102.0sok0
✅ parallel-stepscompleted90msok0
✅ hook-on-execution-statecompleted120msok0
✅ peek-hook-before-branchcompleted120msok0
✅ peek-hook-after-branchcompleted120msok0
✅ peek-hook-at-registrationcompleted120msok0
✅ race-hook-before-probecompleted120msok0
✅ race-hook-after-probecompleted120msok0
✅ race-duplicate-deliverycompleted130msok0
✅ attr-hook-before-stepcompleted110msok0
✅ attr-hook-after-stepcompleted110msok0
✅ attr-from-step-bodycompleted130msok0
✅ fork-hook-after-timeoutcompleted141.0mok0
✅ fork-hook-before-timeoutcompleted141.0mok0
✅ count-hook-after-timeoutcompleted171.0mok0
✅ count-hook-before-timeoutcompleted201.0mok0
✅ stale-read-step-count-forkcompleted201.0mok0
✅ stale-read-equal-step-countscompleted141.0mok0
✅ step-vs-step-forkcompleted120msok0
✅ step-vs-step-fork-fencedcompleted120msok0
✅ fence-catches-benign-directioncompleted125msok0
✅ in-flight-before-decisioncompleted171.0mok0
❌ in-flight-before-decision-countedcompleted171.0mok0
✅ in-flight-after-decisioncompleted192.0mok0
✅ stale-read-step-count-fork-fencedcompleted201.0mok0
✅ fork-hook-winscompleted131.0mok0
✅ fork-timeout-winscompleted131.0mok0
✅ unclaimed-payload-under-forkcompleted171.0mok0
✅ claimed-payload-under-forkcompleted171.0mok0
✅ writers-independent-step-bodiescompleted120msok0
✅ writers-scripted-tempocompleted120msok0
✅ cancel-mid-stepcancelled70msskipped0
Full trace: world-sim.txt
@mitul-s
mitul-s
marked this pull request as ready for review
August 18, 2026 21:52
@mitul-s
mitul-s
requested a review
from a team
as a code ownerAugust 18, 2026 21:52
@mitul-s
mitul-s
enabled auto-merge (squash)
August 18, 2026 21:52
karthikscale3
karthikscale3
approved these changes
Aug 18, 2026
View reviewed changes
@karthikscale3karthikscale3
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Keep the window resize listener when ResizeObserver exists. The new if (!ro) condition means viewport resizing no longer schedules recalculation in modern browsers. ResizeObserver only fires when the observed element’s box changes; responsive typography can change at a media-query breakpoint while its fixed-width container remains unchanged. The cached truncation then reflects the old font metrics. Registering the coalesced window listener unconditionally preserves the previous behavior. use-middle-truncate.ts:227
@mitul-s
mitul-s
merged commit 6ca2f1b
into
mainAug 18, 2026

63 checks passed

@mitul-s
mitul-s
deleted the

c+ms/update-middle-truncate-2065

branch
August 18, 2026 22:39
@github-actions
github-actionsBot
commented
Aug 18, 2026

Copy link


Copy Markdown

Contributor
No backport to stable for 6ca2f1b (AI decision).
This is a performance optimization: it batches/coalesces MiddleTruncate resize measurements across instances and caches text widths, which is not fixing a user-visible stability defect on stable (the existing per-instance rAF debounce already worked, just less efficiently). The only defect-like parts are incidental — a try/catch around invalid DOM Range construction in getRangeOffsets and the selectionText.includes(ELLIPSIS) guard in the copy handler — so a human could split those out and force a backport via workflow_dispatch if desired.
To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:
6ca2f1b3b78dbb811476cdc2848755db108d3022

@github-actionsgithub-actionsBot
mentioned this pull request
Aug 18, 2026
 Closed


This was referenced Aug 19, 2026
 Open

 Closed

 Open

 Merged

 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@karthikscale3karthikscale3karthikscale3 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@mitul-s@karthikscale3@cursoragent

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[web-shared] Optimize MiddleTruncate resize measurements - #3630
Merged
mitul-s merged 1 commit into
mainfrom 
c+ms/update-middle-truncate-2065
Aug 18, 2026
Merged
[web-shared] Optimize MiddleTruncate resize measurements#3630
mitul-s merged 1 commit into
mainfrom 
c+ms/update-middle-truncate-2065
Conversation
@mitul-s
@mitul-smitul-s
commented
Aug 18, 2026•

edited by cursor
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
Ports the MiddleTruncate resize-performance changes from vercel/front#80351 into the observability UI copy. Resize work is now coalesced across instances, all layout reads happen before text-measurement writes, and unchanged text measurements are cached.
The copy-selection path also avoids unnecessary range calculations and handles invalid DOM ranges defensively.
How did you test your changes?
  • pnpm turbo build --filter="@workflow/web-shared..."
  • pnpm --filter @workflow/web-shared typecheck
  • pnpm --filter @workflow/web-shared test on Node 22.22.2 (201 tests passed)
  • pnpm --filter @workflow/web-shared lint (exits successfully with the package's existing warnings)
  • Added focused regressions for cross-instance read/write batching, repeated resize coalescing, and cleanup on unmount
PR Checklist - Required to merge
  •  📦 pnpm changeset was run to create a changelog for this PR
  •  🔒 DCO sign-off passes (run git commit --signoff on your commits)
  •  📝 Ping @vercel/workflow in a comment once the PR is ready, and the above checklist is complete
Open in WebOpen in Cursor
@vercel
vercelBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreviewAug 18, 2026 9:50pm
example-nextjs-workflow-webpackReadyReadyPreviewAug 18, 2026 9:50pm
example-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-astro-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-express-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-fastify-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-hono-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-nestjs-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-nitro-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-nuxt-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-python-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-sveltekit-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-tanstack-start-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-vite-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workflow-docsReadyReadyPreview, v0Aug 18, 2026 9:50pm
workflow-swc-playgroundReadyReadyPreviewAug 18, 2026 9:50pm
workflow-tarballsReadyReadyPreviewAug 18, 2026 9:50pm
workflow-webReadyReadyPreviewAug 18, 2026 9:50pm
@changeset-bot
changeset-botBot
commented
Aug 18, 2026

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 06dcc45
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/cliPatch
@workflow/nitroPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@github-actions
github-actionsBot
commented
Aug 18, 2026

Copy link


Copy Markdown

Contributor
Sim World
Simulated world deterministic testing for races. Traces
🟠 world-sim scenario book — 1 fail of 41 total
fence=per-spec
scenariooutcomeeventsvirtreplayviolations
✅ smoke-no-stepscompleted30msok0
✅ smoke-one-stepcompleted60msok0
✅ hook-at-step-startedcompleted120msok0
✅ hook-at-step-completedcompleted120msok0
✅ hook-at-hook-createdcompleted120msok0
✅ deadline-hook-winscompleted71.0hok0
✅ deadline-expirescompleted71.0hok0
✅ long-sleepcompleted1130.0dok0
✅ hook-never-arrivesstalled30msskipped0
✅ step-retries-twicecompleted102.0sok0
✅ parallel-stepscompleted90msok0
✅ hook-on-execution-statecompleted120msok0
✅ peek-hook-before-branchcompleted120msok0
✅ peek-hook-after-branchcompleted120msok0
✅ peek-hook-at-registrationcompleted120msok0
✅ race-hook-before-probecompleted120msok0
✅ race-hook-after-probecompleted120msok0
✅ race-duplicate-deliverycompleted130msok0
✅ attr-hook-before-stepcompleted110msok0
✅ attr-hook-after-stepcompleted110msok0
✅ attr-from-step-bodycompleted130msok0
✅ fork-hook-after-timeoutcompleted141.0mok0
✅ fork-hook-before-timeoutcompleted141.0mok0
✅ count-hook-after-timeoutcompleted171.0mok0
✅ count-hook-before-timeoutcompleted201.0mok0
✅ stale-read-step-count-forkcompleted201.0mok0
✅ stale-read-equal-step-countscompleted141.0mok0
✅ step-vs-step-forkcompleted120msok0
✅ step-vs-step-fork-fencedcompleted120msok0
✅ fence-catches-benign-directioncompleted125msok0
✅ in-flight-before-decisioncompleted171.0mok0
❌ in-flight-before-decision-countedcompleted171.0mok0
✅ in-flight-after-decisioncompleted192.0mok0
✅ stale-read-step-count-fork-fencedcompleted201.0mok0
✅ fork-hook-winscompleted131.0mok0
✅ fork-timeout-winscompleted131.0mok0
✅ unclaimed-payload-under-forkcompleted171.0mok0
✅ claimed-payload-under-forkcompleted171.0mok0
✅ writers-independent-step-bodiescompleted120msok0
✅ writers-scripted-tempocompleted120msok0
✅ cancel-mid-stepcancelled70msskipped0
Full trace: world-sim.txt
@mitul-s
mitul-s
marked this pull request as ready for review
August 18, 2026 21:52
@mitul-s
mitul-s
requested a review
from a team
as a code ownerAugust 18, 2026 21:52
@mitul-s
mitul-s
enabled auto-merge (squash)
August 18, 2026 21:52
karthikscale3
karthikscale3
approved these changes
Aug 18, 2026
View reviewed changes
@karthikscale3karthikscale3
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Keep the window resize listener when ResizeObserver exists. The new if (!ro) condition means viewport resizing no longer schedules recalculation in modern browsers. ResizeObserver only fires when the observed element’s box changes; responsive typography can change at a media-query breakpoint while its fixed-width container remains unchanged. The cached truncation then reflects the old font metrics. Registering the coalesced window listener unconditionally preserves the previous behavior. use-middle-truncate.ts:227
@mitul-s
mitul-s
merged commit 6ca2f1b
into
mainAug 18, 2026

63 checks passed

@mitul-s
mitul-s
deleted the

c+ms/update-middle-truncate-2065

branch
August 18, 2026 22:39
@github-actions
github-actionsBot
commented
Aug 18, 2026

Copy link


Copy Markdown

Contributor
No backport to stable for 6ca2f1b (AI decision).
This is a performance optimization: it batches/coalesces MiddleTruncate resize measurements across instances and caches text widths, which is not fixing a user-visible stability defect on stable (the existing per-instance rAF debounce already worked, just less efficiently). The only defect-like parts are incidental — a try/catch around invalid DOM Range construction in getRangeOffsets and the selectionText.includes(ELLIPSIS) guard in the copy handler — so a human could split those out and force a backport via workflow_dispatch if desired.
To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:
6ca2f1b3b78dbb811476cdc2848755db108d3022

@github-actionsgithub-actionsBot
mentioned this pull request
Aug 18, 2026
 Closed


This was referenced Aug 19, 2026
 Open

 Closed

 Open

 Merged

 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@karthikscale3karthikscale3karthikscale3 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@mitul-s@karthikscale3@cursoragent

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[web-shared] Optimize MiddleTruncate resize measurements - #3630
Merged
mitul-s merged 1 commit into
mainfrom 
c+ms/update-middle-truncate-2065
Aug 18, 2026
Merged
[web-shared] Optimize MiddleTruncate resize measurements#3630
mitul-s merged 1 commit into
mainfrom 
c+ms/update-middle-truncate-2065
Conversation
@mitul-s
@mitul-smitul-s
commented
Aug 18, 2026•

edited by cursor
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
Ports the MiddleTruncate resize-performance changes from vercel/front#80351 into the observability UI copy. Resize work is now coalesced across instances, all layout reads happen before text-measurement writes, and unchanged text measurements are cached.
The copy-selection path also avoids unnecessary range calculations and handles invalid DOM ranges defensively.
How did you test your changes?
  • pnpm turbo build --filter="@workflow/web-shared..."
  • pnpm --filter @workflow/web-shared typecheck
  • pnpm --filter @workflow/web-shared test on Node 22.22.2 (201 tests passed)
  • pnpm --filter @workflow/web-shared lint (exits successfully with the package's existing warnings)
  • Added focused regressions for cross-instance read/write batching, repeated resize coalescing, and cleanup on unmount
PR Checklist - Required to merge
  •  📦 pnpm changeset was run to create a changelog for this PR
  •  🔒 DCO sign-off passes (run git commit --signoff on your commits)
  •  📝 Ping @vercel/workflow in a comment once the PR is ready, and the above checklist is complete
Open in WebOpen in Cursor
@vercel
vercelBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreviewAug 18, 2026 9:50pm
example-nextjs-workflow-webpackReadyReadyPreviewAug 18, 2026 9:50pm
example-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-astro-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-express-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-fastify-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-hono-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-nestjs-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-nitro-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-nuxt-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-python-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-sveltekit-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-tanstack-start-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-vite-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workflow-docsReadyReadyPreview, v0Aug 18, 2026 9:50pm
workflow-swc-playgroundReadyReadyPreviewAug 18, 2026 9:50pm
workflow-tarballsReadyReadyPreviewAug 18, 2026 9:50pm
workflow-webReadyReadyPreviewAug 18, 2026 9:50pm
@changeset-bot
changeset-botBot
commented
Aug 18, 2026

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 06dcc45
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/cliPatch
@workflow/nitroPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@github-actions
github-actionsBot
commented
Aug 18, 2026

Copy link


Copy Markdown

Contributor
Sim World
Simulated world deterministic testing for races. Traces
🟠 world-sim scenario book — 1 fail of 41 total
fence=per-spec
scenariooutcomeeventsvirtreplayviolations
✅ smoke-no-stepscompleted30msok0
✅ smoke-one-stepcompleted60msok0
✅ hook-at-step-startedcompleted120msok0
✅ hook-at-step-completedcompleted120msok0
✅ hook-at-hook-createdcompleted120msok0
✅ deadline-hook-winscompleted71.0hok0
✅ deadline-expirescompleted71.0hok0
✅ long-sleepcompleted1130.0dok0
✅ hook-never-arrivesstalled30msskipped0
✅ step-retries-twicecompleted102.0sok0
✅ parallel-stepscompleted90msok0
✅ hook-on-execution-statecompleted120msok0
✅ peek-hook-before-branchcompleted120msok0
✅ peek-hook-after-branchcompleted120msok0
✅ peek-hook-at-registrationcompleted120msok0
✅ race-hook-before-probecompleted120msok0
✅ race-hook-after-probecompleted120msok0
✅ race-duplicate-deliverycompleted130msok0
✅ attr-hook-before-stepcompleted110msok0
✅ attr-hook-after-stepcompleted110msok0
✅ attr-from-step-bodycompleted130msok0
✅ fork-hook-after-timeoutcompleted141.0mok0
✅ fork-hook-before-timeoutcompleted141.0mok0
✅ count-hook-after-timeoutcompleted171.0mok0
✅ count-hook-before-timeoutcompleted201.0mok0
✅ stale-read-step-count-forkcompleted201.0mok0
✅ stale-read-equal-step-countscompleted141.0mok0
✅ step-vs-step-forkcompleted120msok0
✅ step-vs-step-fork-fencedcompleted120msok0
✅ fence-catches-benign-directioncompleted125msok0
✅ in-flight-before-decisioncompleted171.0mok0
❌ in-flight-before-decision-countedcompleted171.0mok0
✅ in-flight-after-decisioncompleted192.0mok0
✅ stale-read-step-count-fork-fencedcompleted201.0mok0
✅ fork-hook-winscompleted131.0mok0
✅ fork-timeout-winscompleted131.0mok0
✅ unclaimed-payload-under-forkcompleted171.0mok0
✅ claimed-payload-under-forkcompleted171.0mok0
✅ writers-independent-step-bodiescompleted120msok0
✅ writers-scripted-tempocompleted120msok0
✅ cancel-mid-stepcancelled70msskipped0
Full trace: world-sim.txt
@mitul-s
mitul-s
marked this pull request as ready for review
August 18, 2026 21:52
@mitul-s
mitul-s
requested a review
from a team
as a code ownerAugust 18, 2026 21:52
@mitul-s
mitul-s
enabled auto-merge (squash)
August 18, 2026 21:52
karthikscale3
karthikscale3
approved these changes
Aug 18, 2026
View reviewed changes
@karthikscale3karthikscale3
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Keep the window resize listener when ResizeObserver exists. The new if (!ro) condition means viewport resizing no longer schedules recalculation in modern browsers. ResizeObserver only fires when the observed element’s box changes; responsive typography can change at a media-query breakpoint while its fixed-width container remains unchanged. The cached truncation then reflects the old font metrics. Registering the coalesced window listener unconditionally preserves the previous behavior. use-middle-truncate.ts:227
@mitul-s
mitul-s
merged commit 6ca2f1b
into
mainAug 18, 2026

63 checks passed

@mitul-s
mitul-s
deleted the

c+ms/update-middle-truncate-2065

branch
August 18, 2026 22:39
@github-actions
github-actionsBot
commented
Aug 18, 2026

Copy link


Copy Markdown

Contributor
No backport to stable for 6ca2f1b (AI decision).
This is a performance optimization: it batches/coalesces MiddleTruncate resize measurements across instances and caches text widths, which is not fixing a user-visible stability defect on stable (the existing per-instance rAF debounce already worked, just less efficiently). The only defect-like parts are incidental — a try/catch around invalid DOM Range construction in getRangeOffsets and the selectionText.includes(ELLIPSIS) guard in the copy handler — so a human could split those out and force a backport via workflow_dispatch if desired.
To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:
6ca2f1b3b78dbb811476cdc2848755db108d3022

@github-actionsgithub-actionsBot
mentioned this pull request
Aug 18, 2026
 Closed


This was referenced Aug 19, 2026
 Open

 Closed

 Open

 Merged

 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@karthikscale3karthikscale3karthikscale3 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@mitul-s@karthikscale3@cursoragent

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[web-shared] Optimize MiddleTruncate resize measurements - #3630
Merged
mitul-s merged 1 commit into
mainfrom 
c+ms/update-middle-truncate-2065
Aug 18, 2026
Merged
[web-shared] Optimize MiddleTruncate resize measurements#3630
mitul-s merged 1 commit into
mainfrom 
c+ms/update-middle-truncate-2065
Conversation
@mitul-s
@mitul-smitul-s
commented
Aug 18, 2026•

edited by cursor
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
Ports the MiddleTruncate resize-performance changes from vercel/front#80351 into the observability UI copy. Resize work is now coalesced across instances, all layout reads happen before text-measurement writes, and unchanged text measurements are cached.
The copy-selection path also avoids unnecessary range calculations and handles invalid DOM ranges defensively.
How did you test your changes?
  • pnpm turbo build --filter="@workflow/web-shared..."
  • pnpm --filter @workflow/web-shared typecheck
  • pnpm --filter @workflow/web-shared test on Node 22.22.2 (201 tests passed)
  • pnpm --filter @workflow/web-shared lint (exits successfully with the package's existing warnings)
  • Added focused regressions for cross-instance read/write batching, repeated resize coalescing, and cleanup on unmount
PR Checklist - Required to merge
  •  📦 pnpm changeset was run to create a changelog for this PR
  •  🔒 DCO sign-off passes (run git commit --signoff on your commits)
  •  📝 Ping @vercel/workflow in a comment once the PR is ready, and the above checklist is complete
Open in WebOpen in Cursor
@vercel
vercelBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreviewAug 18, 2026 9:50pm
example-nextjs-workflow-webpackReadyReadyPreviewAug 18, 2026 9:50pm
example-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-astro-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-express-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-fastify-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-hono-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-nestjs-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-nitro-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-nuxt-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-python-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-sveltekit-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-tanstack-start-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-vite-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workflow-docsReadyReadyPreview, v0Aug 18, 2026 9:50pm
workflow-swc-playgroundReadyReadyPreviewAug 18, 2026 9:50pm
workflow-tarballsReadyReadyPreviewAug 18, 2026 9:50pm
workflow-webReadyReadyPreviewAug 18, 2026 9:50pm
@changeset-bot
changeset-botBot
commented
Aug 18, 2026

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 06dcc45
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/cliPatch
@workflow/nitroPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@github-actions
github-actionsBot
commented
Aug 18, 2026

Copy link


Copy Markdown

Contributor
Sim World
Simulated world deterministic testing for races. Traces
🟠 world-sim scenario book — 1 fail of 41 total
fence=per-spec
scenariooutcomeeventsvirtreplayviolations
✅ smoke-no-stepscompleted30msok0
✅ smoke-one-stepcompleted60msok0
✅ hook-at-step-startedcompleted120msok0
✅ hook-at-step-completedcompleted120msok0
✅ hook-at-hook-createdcompleted120msok0
✅ deadline-hook-winscompleted71.0hok0
✅ deadline-expirescompleted71.0hok0
✅ long-sleepcompleted1130.0dok0
✅ hook-never-arrivesstalled30msskipped0
✅ step-retries-twicecompleted102.0sok0
✅ parallel-stepscompleted90msok0
✅ hook-on-execution-statecompleted120msok0
✅ peek-hook-before-branchcompleted120msok0
✅ peek-hook-after-branchcompleted120msok0
✅ peek-hook-at-registrationcompleted120msok0
✅ race-hook-before-probecompleted120msok0
✅ race-hook-after-probecompleted120msok0
✅ race-duplicate-deliverycompleted130msok0
✅ attr-hook-before-stepcompleted110msok0
✅ attr-hook-after-stepcompleted110msok0
✅ attr-from-step-bodycompleted130msok0
✅ fork-hook-after-timeoutcompleted141.0mok0
✅ fork-hook-before-timeoutcompleted141.0mok0
✅ count-hook-after-timeoutcompleted171.0mok0
✅ count-hook-before-timeoutcompleted201.0mok0
✅ stale-read-step-count-forkcompleted201.0mok0
✅ stale-read-equal-step-countscompleted141.0mok0
✅ step-vs-step-forkcompleted120msok0
✅ step-vs-step-fork-fencedcompleted120msok0
✅ fence-catches-benign-directioncompleted125msok0
✅ in-flight-before-decisioncompleted171.0mok0
❌ in-flight-before-decision-countedcompleted171.0mok0
✅ in-flight-after-decisioncompleted192.0mok0
✅ stale-read-step-count-fork-fencedcompleted201.0mok0
✅ fork-hook-winscompleted131.0mok0
✅ fork-timeout-winscompleted131.0mok0
✅ unclaimed-payload-under-forkcompleted171.0mok0
✅ claimed-payload-under-forkcompleted171.0mok0
✅ writers-independent-step-bodiescompleted120msok0
✅ writers-scripted-tempocompleted120msok0
✅ cancel-mid-stepcancelled70msskipped0
Full trace: world-sim.txt
@mitul-s
mitul-s
marked this pull request as ready for review
August 18, 2026 21:52
@mitul-s
mitul-s
requested a review
from a team
as a code ownerAugust 18, 2026 21:52
@mitul-s
mitul-s
enabled auto-merge (squash)
August 18, 2026 21:52
karthikscale3
karthikscale3
approved these changes
Aug 18, 2026
View reviewed changes
@karthikscale3karthikscale3
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Keep the window resize listener when ResizeObserver exists. The new if (!ro) condition means viewport resizing no longer schedules recalculation in modern browsers. ResizeObserver only fires when the observed element’s box changes; responsive typography can change at a media-query breakpoint while its fixed-width container remains unchanged. The cached truncation then reflects the old font metrics. Registering the coalesced window listener unconditionally preserves the previous behavior. use-middle-truncate.ts:227
@mitul-s
mitul-s
merged commit 6ca2f1b
into
mainAug 18, 2026

63 checks passed

@mitul-s
mitul-s
deleted the

c+ms/update-middle-truncate-2065

branch
August 18, 2026 22:39
@github-actions
github-actionsBot
commented
Aug 18, 2026

Copy link


Copy Markdown

Contributor
No backport to stable for 6ca2f1b (AI decision).
This is a performance optimization: it batches/coalesces MiddleTruncate resize measurements across instances and caches text widths, which is not fixing a user-visible stability defect on stable (the existing per-instance rAF debounce already worked, just less efficiently). The only defect-like parts are incidental — a try/catch around invalid DOM Range construction in getRangeOffsets and the selectionText.includes(ELLIPSIS) guard in the copy handler — so a human could split those out and force a backport via workflow_dispatch if desired.
To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:
6ca2f1b3b78dbb811476cdc2848755db108d3022

@github-actionsgithub-actionsBot
mentioned this pull request
Aug 18, 2026
 Closed


This was referenced Aug 19, 2026
 Open

 Closed

 Open

 Merged

 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@karthikscale3karthikscale3karthikscale3 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@mitul-s@karthikscale3@cursoragent

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[web-shared] Optimize MiddleTruncate resize measurements - #3630
Merged
mitul-s merged 1 commit into
mainfrom 
c+ms/update-middle-truncate-2065
Aug 18, 2026
Merged
[web-shared] Optimize MiddleTruncate resize measurements#3630
mitul-s merged 1 commit into
mainfrom 
c+ms/update-middle-truncate-2065
Conversation
@mitul-s
@mitul-smitul-s
commented
Aug 18, 2026•

edited by cursor
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
Ports the MiddleTruncate resize-performance changes from vercel/front#80351 into the observability UI copy. Resize work is now coalesced across instances, all layout reads happen before text-measurement writes, and unchanged text measurements are cached.
The copy-selection path also avoids unnecessary range calculations and handles invalid DOM ranges defensively.
How did you test your changes?
  • pnpm turbo build --filter="@workflow/web-shared..."
  • pnpm --filter @workflow/web-shared typecheck
  • pnpm --filter @workflow/web-shared test on Node 22.22.2 (201 tests passed)
  • pnpm --filter @workflow/web-shared lint (exits successfully with the package's existing warnings)
  • Added focused regressions for cross-instance read/write batching, repeated resize coalescing, and cleanup on unmount
PR Checklist - Required to merge
  •  📦 pnpm changeset was run to create a changelog for this PR
  •  🔒 DCO sign-off passes (run git commit --signoff on your commits)
  •  📝 Ping @vercel/workflow in a comment once the PR is ready, and the above checklist is complete
Open in WebOpen in Cursor
@vercel
vercelBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreviewAug 18, 2026 9:50pm
example-nextjs-workflow-webpackReadyReadyPreviewAug 18, 2026 9:50pm
example-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-astro-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-express-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-fastify-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-hono-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-nestjs-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-nitro-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-nuxt-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-python-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-sveltekit-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-tanstack-start-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-vite-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workflow-docsReadyReadyPreview, v0Aug 18, 2026 9:50pm
workflow-swc-playgroundReadyReadyPreviewAug 18, 2026 9:50pm
workflow-tarballsReadyReadyPreviewAug 18, 2026 9:50pm
workflow-webReadyReadyPreviewAug 18, 2026 9:50pm
@changeset-bot
changeset-botBot
commented
Aug 18, 2026

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 06dcc45
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/cliPatch
@workflow/nitroPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@github-actions
github-actionsBot
commented
Aug 18, 2026

Copy link


Copy Markdown

Contributor
Sim World
Simulated world deterministic testing for races. Traces
🟠 world-sim scenario book — 1 fail of 41 total
fence=per-spec
scenariooutcomeeventsvirtreplayviolations
✅ smoke-no-stepscompleted30msok0
✅ smoke-one-stepcompleted60msok0
✅ hook-at-step-startedcompleted120msok0
✅ hook-at-step-completedcompleted120msok0
✅ hook-at-hook-createdcompleted120msok0
✅ deadline-hook-winscompleted71.0hok0
✅ deadline-expirescompleted71.0hok0
✅ long-sleepcompleted1130.0dok0
✅ hook-never-arrivesstalled30msskipped0
✅ step-retries-twicecompleted102.0sok0
✅ parallel-stepscompleted90msok0
✅ hook-on-execution-statecompleted120msok0
✅ peek-hook-before-branchcompleted120msok0
✅ peek-hook-after-branchcompleted120msok0
✅ peek-hook-at-registrationcompleted120msok0
✅ race-hook-before-probecompleted120msok0
✅ race-hook-after-probecompleted120msok0
✅ race-duplicate-deliverycompleted130msok0
✅ attr-hook-before-stepcompleted110msok0
✅ attr-hook-after-stepcompleted110msok0
✅ attr-from-step-bodycompleted130msok0
✅ fork-hook-after-timeoutcompleted141.0mok0
✅ fork-hook-before-timeoutcompleted141.0mok0
✅ count-hook-after-timeoutcompleted171.0mok0
✅ count-hook-before-timeoutcompleted201.0mok0
✅ stale-read-step-count-forkcompleted201.0mok0
✅ stale-read-equal-step-countscompleted141.0mok0
✅ step-vs-step-forkcompleted120msok0
✅ step-vs-step-fork-fencedcompleted120msok0
✅ fence-catches-benign-directioncompleted125msok0
✅ in-flight-before-decisioncompleted171.0mok0
❌ in-flight-before-decision-countedcompleted171.0mok0
✅ in-flight-after-decisioncompleted192.0mok0
✅ stale-read-step-count-fork-fencedcompleted201.0mok0
✅ fork-hook-winscompleted131.0mok0
✅ fork-timeout-winscompleted131.0mok0
✅ unclaimed-payload-under-forkcompleted171.0mok0
✅ claimed-payload-under-forkcompleted171.0mok0
✅ writers-independent-step-bodiescompleted120msok0
✅ writers-scripted-tempocompleted120msok0
✅ cancel-mid-stepcancelled70msskipped0
Full trace: world-sim.txt
@mitul-s
mitul-s
marked this pull request as ready for review
August 18, 2026 21:52
@mitul-s
mitul-s
requested a review
from a team
as a code ownerAugust 18, 2026 21:52
@mitul-s
mitul-s
enabled auto-merge (squash)
August 18, 2026 21:52
karthikscale3
karthikscale3
approved these changes
Aug 18, 2026
View reviewed changes
@karthikscale3karthikscale3
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Keep the window resize listener when ResizeObserver exists. The new if (!ro) condition means viewport resizing no longer schedules recalculation in modern browsers. ResizeObserver only fires when the observed element’s box changes; responsive typography can change at a media-query breakpoint while its fixed-width container remains unchanged. The cached truncation then reflects the old font metrics. Registering the coalesced window listener unconditionally preserves the previous behavior. use-middle-truncate.ts:227
@mitul-s
mitul-s
merged commit 6ca2f1b
into
mainAug 18, 2026

63 checks passed

@mitul-s
mitul-s
deleted the

c+ms/update-middle-truncate-2065

branch
August 18, 2026 22:39
@github-actions
github-actionsBot
commented
Aug 18, 2026

Copy link


Copy Markdown

Contributor
No backport to stable for 6ca2f1b (AI decision).
This is a performance optimization: it batches/coalesces MiddleTruncate resize measurements across instances and caches text widths, which is not fixing a user-visible stability defect on stable (the existing per-instance rAF debounce already worked, just less efficiently). The only defect-like parts are incidental — a try/catch around invalid DOM Range construction in getRangeOffsets and the selectionText.includes(ELLIPSIS) guard in the copy handler — so a human could split those out and force a backport via workflow_dispatch if desired.
To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:
6ca2f1b3b78dbb811476cdc2848755db108d3022

@github-actionsgithub-actionsBot
mentioned this pull request
Aug 18, 2026
 Closed


This was referenced Aug 19, 2026
 Open

 Closed

 Open

 Merged

 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@karthikscale3karthikscale3karthikscale3 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@mitul-s@karthikscale3@cursoragent

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[web-shared] Optimize MiddleTruncate resize measurements - #3630
Merged
mitul-s merged 1 commit into
mainfrom 
c+ms/update-middle-truncate-2065
Aug 18, 2026
Merged
[web-shared] Optimize MiddleTruncate resize measurements#3630
mitul-s merged 1 commit into
mainfrom 
c+ms/update-middle-truncate-2065
Conversation
@mitul-s
@mitul-smitul-s
commented
Aug 18, 2026•

edited by cursor
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
Ports the MiddleTruncate resize-performance changes from vercel/front#80351 into the observability UI copy. Resize work is now coalesced across instances, all layout reads happen before text-measurement writes, and unchanged text measurements are cached.
The copy-selection path also avoids unnecessary range calculations and handles invalid DOM ranges defensively.
How did you test your changes?
  • pnpm turbo build --filter="@workflow/web-shared..."
  • pnpm --filter @workflow/web-shared typecheck
  • pnpm --filter @workflow/web-shared test on Node 22.22.2 (201 tests passed)
  • pnpm --filter @workflow/web-shared lint (exits successfully with the package's existing warnings)
  • Added focused regressions for cross-instance read/write batching, repeated resize coalescing, and cleanup on unmount
PR Checklist - Required to merge
  •  📦 pnpm changeset was run to create a changelog for this PR
  •  🔒 DCO sign-off passes (run git commit --signoff on your commits)
  •  📝 Ping @vercel/workflow in a comment once the PR is ready, and the above checklist is complete
Open in WebOpen in Cursor
@vercel
vercelBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreviewAug 18, 2026 9:50pm
example-nextjs-workflow-webpackReadyReadyPreviewAug 18, 2026 9:50pm
example-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-astro-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-express-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-fastify-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-hono-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-nestjs-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-nitro-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-nuxt-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-python-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-sveltekit-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-tanstack-start-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-vite-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workflow-docsReadyReadyPreview, v0Aug 18, 2026 9:50pm
workflow-swc-playgroundReadyReadyPreviewAug 18, 2026 9:50pm
workflow-tarballsReadyReadyPreviewAug 18, 2026 9:50pm
workflow-webReadyReadyPreviewAug 18, 2026 9:50pm
@changeset-bot
changeset-botBot
commented
Aug 18, 2026

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 06dcc45
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/cliPatch
@workflow/nitroPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@github-actions
github-actionsBot
commented
Aug 18, 2026

Copy link


Copy Markdown

Contributor
Sim World
Simulated world deterministic testing for races. Traces
🟠 world-sim scenario book — 1 fail of 41 total
fence=per-spec
scenariooutcomeeventsvirtreplayviolations
✅ smoke-no-stepscompleted30msok0
✅ smoke-one-stepcompleted60msok0
✅ hook-at-step-startedcompleted120msok0
✅ hook-at-step-completedcompleted120msok0
✅ hook-at-hook-createdcompleted120msok0
✅ deadline-hook-winscompleted71.0hok0
✅ deadline-expirescompleted71.0hok0
✅ long-sleepcompleted1130.0dok0
✅ hook-never-arrivesstalled30msskipped0
✅ step-retries-twicecompleted102.0sok0
✅ parallel-stepscompleted90msok0
✅ hook-on-execution-statecompleted120msok0
✅ peek-hook-before-branchcompleted120msok0
✅ peek-hook-after-branchcompleted120msok0
✅ peek-hook-at-registrationcompleted120msok0
✅ race-hook-before-probecompleted120msok0
✅ race-hook-after-probecompleted120msok0
✅ race-duplicate-deliverycompleted130msok0
✅ attr-hook-before-stepcompleted110msok0
✅ attr-hook-after-stepcompleted110msok0
✅ attr-from-step-bodycompleted130msok0
✅ fork-hook-after-timeoutcompleted141.0mok0
✅ fork-hook-before-timeoutcompleted141.0mok0
✅ count-hook-after-timeoutcompleted171.0mok0
✅ count-hook-before-timeoutcompleted201.0mok0
✅ stale-read-step-count-forkcompleted201.0mok0
✅ stale-read-equal-step-countscompleted141.0mok0
✅ step-vs-step-forkcompleted120msok0
✅ step-vs-step-fork-fencedcompleted120msok0
✅ fence-catches-benign-directioncompleted125msok0
✅ in-flight-before-decisioncompleted171.0mok0
❌ in-flight-before-decision-countedcompleted171.0mok0
✅ in-flight-after-decisioncompleted192.0mok0
✅ stale-read-step-count-fork-fencedcompleted201.0mok0
✅ fork-hook-winscompleted131.0mok0
✅ fork-timeout-winscompleted131.0mok0
✅ unclaimed-payload-under-forkcompleted171.0mok0
✅ claimed-payload-under-forkcompleted171.0mok0
✅ writers-independent-step-bodiescompleted120msok0
✅ writers-scripted-tempocompleted120msok0
✅ cancel-mid-stepcancelled70msskipped0
Full trace: world-sim.txt
@mitul-s
mitul-s
marked this pull request as ready for review
August 18, 2026 21:52
@mitul-s
mitul-s
requested a review
from a team
as a code ownerAugust 18, 2026 21:52
@mitul-s
mitul-s
enabled auto-merge (squash)
August 18, 2026 21:52
karthikscale3
karthikscale3
approved these changes
Aug 18, 2026
View reviewed changes
@karthikscale3karthikscale3
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Keep the window resize listener when ResizeObserver exists. The new if (!ro) condition means viewport resizing no longer schedules recalculation in modern browsers. ResizeObserver only fires when the observed element’s box changes; responsive typography can change at a media-query breakpoint while its fixed-width container remains unchanged. The cached truncation then reflects the old font metrics. Registering the coalesced window listener unconditionally preserves the previous behavior. use-middle-truncate.ts:227
@mitul-s
mitul-s
merged commit 6ca2f1b
into
mainAug 18, 2026

63 checks passed

@mitul-s
mitul-s
deleted the

c+ms/update-middle-truncate-2065

branch
August 18, 2026 22:39
@github-actions
github-actionsBot
commented
Aug 18, 2026

Copy link


Copy Markdown

Contributor
No backport to stable for 6ca2f1b (AI decision).
This is a performance optimization: it batches/coalesces MiddleTruncate resize measurements across instances and caches text widths, which is not fixing a user-visible stability defect on stable (the existing per-instance rAF debounce already worked, just less efficiently). The only defect-like parts are incidental — a try/catch around invalid DOM Range construction in getRangeOffsets and the selectionText.includes(ELLIPSIS) guard in the copy handler — so a human could split those out and force a backport via workflow_dispatch if desired.
To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:
6ca2f1b3b78dbb811476cdc2848755db108d3022

@github-actionsgithub-actionsBot
mentioned this pull request
Aug 18, 2026
 Closed


This was referenced Aug 19, 2026
 Open

 Closed

 Open

 Merged

 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@karthikscale3karthikscale3karthikscale3 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@mitul-s@karthikscale3@cursoragent

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[web-shared] Optimize MiddleTruncate resize measurements - #3630
Merged
mitul-s merged 1 commit into
mainfrom 
c+ms/update-middle-truncate-2065
Aug 18, 2026
Merged
[web-shared] Optimize MiddleTruncate resize measurements#3630
mitul-s merged 1 commit into
mainfrom 
c+ms/update-middle-truncate-2065
Conversation
@mitul-s
@mitul-smitul-s
commented
Aug 18, 2026•

edited by cursor
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
Ports the MiddleTruncate resize-performance changes from vercel/front#80351 into the observability UI copy. Resize work is now coalesced across instances, all layout reads happen before text-measurement writes, and unchanged text measurements are cached.
The copy-selection path also avoids unnecessary range calculations and handles invalid DOM ranges defensively.
How did you test your changes?
  • pnpm turbo build --filter="@workflow/web-shared..."
  • pnpm --filter @workflow/web-shared typecheck
  • pnpm --filter @workflow/web-shared test on Node 22.22.2 (201 tests passed)
  • pnpm --filter @workflow/web-shared lint (exits successfully with the package's existing warnings)
  • Added focused regressions for cross-instance read/write batching, repeated resize coalescing, and cleanup on unmount
PR Checklist - Required to merge
  •  📦 pnpm changeset was run to create a changelog for this PR
  •  🔒 DCO sign-off passes (run git commit --signoff on your commits)
  •  📝 Ping @vercel/workflow in a comment once the PR is ready, and the above checklist is complete
Open in WebOpen in Cursor
@vercel
vercelBot
commented
Aug 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreviewAug 18, 2026 9:50pm
example-nextjs-workflow-webpackReadyReadyPreviewAug 18, 2026 9:50pm
example-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-astro-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-express-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-fastify-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-hono-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-nestjs-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-nitro-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-nuxt-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-python-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-sveltekit-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-tanstack-start-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workbench-vite-workflowReadyReadyPreviewAug 18, 2026 9:50pm
workflow-docsReadyReadyPreview, v0Aug 18, 2026 9:50pm
workflow-swc-playgroundReadyReadyPreviewAug 18, 2026 9:50pm
workflow-tarballsReadyReadyPreviewAug 18, 2026 9:50pm
workflow-webReadyReadyPreviewAug 18, 2026 9:50pm
@changeset-bot
changeset-botBot
commented
Aug 18, 2026

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 06dcc45
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/cliPatch
@workflow/nitroPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@github-actions
github-actionsBot
commented
Aug 18, 2026

Copy link


Copy Markdown

Contributor
Sim World
Simulated world deterministic testing for races. Traces
🟠 world-sim scenario book — 1 fail of 41 total
fence=per-spec
scenariooutcomeeventsvirtreplayviolations
✅ smoke-no-stepscompleted30msok0
✅ smoke-one-stepcompleted60msok0
✅ hook-at-step-startedcompleted120msok0
✅ hook-at-step-completedcompleted120msok0
✅ hook-at-hook-createdcompleted120msok0
✅ deadline-hook-winscompleted71.0hok0
✅ deadline-expirescompleted71.0hok0
✅ long-sleepcompleted1130.0dok0
✅ hook-never-arrivesstalled30msskipped0
✅ step-retries-twicecompleted102.0sok0
✅ parallel-stepscompleted90msok0
✅ hook-on-execution-statecompleted120msok0
✅ peek-hook-before-branchcompleted120msok0
✅ peek-hook-after-branchcompleted120msok0
✅ peek-hook-at-registrationcompleted120msok0
✅ race-hook-before-probecompleted120msok0
✅ race-hook-after-probecompleted120msok0
✅ race-duplicate-deliverycompleted130msok0
✅ attr-hook-before-stepcompleted110msok0
✅ attr-hook-after-stepcompleted110msok0
✅ attr-from-step-bodycompleted130msok0
✅ fork-hook-after-timeoutcompleted141.0mok0
✅ fork-hook-before-timeoutcompleted141.0mok0
✅ count-hook-after-timeoutcompleted171.0mok0
✅ count-hook-before-timeoutcompleted201.0mok0
✅ stale-read-step-count-forkcompleted201.0mok0
✅ stale-read-equal-step-countscompleted141.0mok0
✅ step-vs-step-forkcompleted120msok0
✅ step-vs-step-fork-fencedcompleted120msok0
✅ fence-catches-benign-directioncompleted125msok0
✅ in-flight-before-decisioncompleted171.0mok0
❌ in-flight-before-decision-countedcompleted171.0mok0
✅ in-flight-after-decisioncompleted192.0mok0
✅ stale-read-step-count-fork-fencedcompleted201.0mok0
✅ fork-hook-winscompleted131.0mok0
✅ fork-timeout-winscompleted131.0mok0
✅ unclaimed-payload-under-forkcompleted171.0mok0
✅ claimed-payload-under-forkcompleted171.0mok0
✅ writers-independent-step-bodiescompleted120msok0
✅ writers-scripted-tempocompleted120msok0
✅ cancel-mid-stepcancelled70msskipped0
Full trace: world-sim.txt
@mitul-s
mitul-s
marked this pull request as ready for review
August 18, 2026 21:52
@mitul-s
mitul-s
requested a review
from a team
as a code ownerAugust 18, 2026 21:52
@mitul-s
mitul-s
enabled auto-merge (squash)
August 18, 2026 21:52
karthikscale3
karthikscale3
approved these changes
Aug 18, 2026
View reviewed changes
@karthikscale3karthikscale3
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Keep the window resize listener when ResizeObserver exists. The new if (!ro) condition means viewport resizing no longer schedules recalculation in modern browsers. ResizeObserver only fires when the observed element’s box changes; responsive typography can change at a media-query breakpoint while its fixed-width container remains unchanged. The cached truncation then reflects the old font metrics. Registering the coalesced window listener unconditionally preserves the previous behavior. use-middle-truncate.ts:227
@mitul-s
mitul-s
merged commit 6ca2f1b
into
mainAug 18, 2026

63 checks passed

@mitul-s
mitul-s
deleted the

c+ms/update-middle-truncate-2065

branch
August 18, 2026 22:39
@github-actions
github-actionsBot
commented
Aug 18, 2026

Copy link


Copy Markdown

Contributor
No backport to stable for 6ca2f1b (AI decision).
This is a performance optimization: it batches/coalesces MiddleTruncate resize measurements across instances and caches text widths, which is not fixing a user-visible stability defect on stable (the existing per-instance rAF debounce already worked, just less efficiently). The only defect-like parts are incidental — a try/catch around invalid DOM Range construction in getRangeOffsets and the selectionText.includes(ELLIPSIS) guard in the copy handler — so a human could split those out and force a backport via workflow_dispatch if desired.
To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:
6ca2f1b3b78dbb811476cdc2848755db108d3022

@github-actionsgithub-actionsBot
mentioned this pull request
Aug 18, 2026
 Closed


This was referenced Aug 19, 2026
 Open

 Closed

 Open

 Merged

 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@karthikscale3karthikscale3karthikscale3 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@mitul-s@karthikscale3@cursoragent