Uh oh!
There was an error while loading. Please reload this page.
Backport #3824: fix(world-local): abort deliveries on shutdown - #3827
Merged
Conversation
Signed-off-by: Andrew Barba <barba@hey.com>
3 tasks
🦋 Changeset detectedLatest commit: 5e33e46 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated backport of #3824 to
stable(backport job run).AI recommendation: This is a hang fix:
world-local's close path released the undici agent while an in-flight delivery was still active, soAgent.close()could wait indefinitely when transport timeouts are disabled.stablehas the same shape (packages/world-local/src/queue.tsthere setsheadersTimeout: 0and itsclose()just destroys/closes the agents with no abort signal), so the defect applies to the maintenance line, and the commit is a smallpatchfix plus a regression test with no feature work. Note thatstablehas no shutdownAbortController/closeSignalyet, so the cherry-pick will likely need adaptation (thread a close signal into both HTTP transports).Merge conflicts were resolved by AI (opencode with
anthropic/claude-opus-5). Please review the conflict resolution carefully before merging.