Alt-click focus behavior - #3872

Merged
mitul-s merged 7 commits into
mainfrom
c+ms/fix-alt-hover-c934
Aug 28, 2026
Merged

Alt-click focus behavior#3872
mitul-s merged 7 commits into
mainfrom
c+ms/fix-alt-hover-c934

Conversation

@mitul-s

@mitul-smitul-s commented Aug 27, 2026•
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

After you click a span in the trace, holding Alt no longer showed the selected-to-hovered delta. Other spans also lost hover until you switched out of Chrome and back.

Chrome treats Alt as a menu-bar shortcut. That blurs the page, which cleared altHeld and stopped hover from updating. useAltHeld now calls preventDefault on Alt (except in inputs, textareas, and contenteditable) so the menu bar does not take over. Listeners run in capture. pointermove.altKey recovers if keydown was missed. Blur still clears the flag so the overlay cannot stick after Alt+Tab.

The new hook is packages/web-shared/src/components/trace-viewer/components/use-alt-held.ts. The only other change is wiring it in trace-viewer.tsx.

How did you test your changes?

No unit tests. The failure is Chrome stealing Alt after a click, which jsdom cannot reproduce. Manual check: select a span, keep the cursor in the timeline, hold Alt, hover another span. The delta overlay should appear without leaving the tab. Typing in the search box with Option on macOS should still compose characters.

PR Checklist - Required to merge

  • 📦 pnpm changeset was run to create a changelog for this PR
    • Use the correct semver bump type: patch for bug fixes, minor for new features, major for breaking changes.
    • Use pnpm changeset --empty if you are changing documentation or workbench apps
  • 🔒 DCO sign-off passes (run git commit --signoff on your commits)
  • 📝 Ping @vercel/workflow in a comment once the PR is ready, and the above checklist is complete
Open in WebOpen in Cursor

@cursoragent
fix(web-shared): keep Alt+hover working after selecting a span
be353e2
Chrome's Alt menu-bar handling blurred the page and cleared the overlay
flag, which also killed span hover until the window was refocused.
@cursoragent
test(web-shared): drop useAltHeld unit tests
4948af5
@cursoragent
refactor(web-shared): let useAltHeld own Alt tracking
11bb233
Drop the event union, reducer, and timeline mouse-move graft. The hook
listens for keys, blur, and window pointermove itself and returns only
altHeld.
@cursor

cursorBot commented Aug 27, 2026

Copy link
Copy Markdown

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@vercel

vercelBot commented Aug 27, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, v0Aug 28, 2026 6:32pm
example-nextjs-workflow-webpackReadyReadyPreview, v0Aug 28, 2026 6:32pm
example-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-astro-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-express-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-fastify-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-hono-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-nestjs-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-nitro-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-nuxt-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-python-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-sveltekit-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-tanstack-start-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-vite-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workflow-docsReadyReadyPreview, v0Aug 28, 2026 6:32pm
workflow-swc-playgroundReadyReadyPreview, v0Aug 28, 2026 6:32pm
workflow-tarballsReadyReadyPreview, v0Aug 28, 2026 6:32pm
workflow-webReadyReadyPreview, v0Aug 28, 2026 6:32pm

@changeset-bot

changeset-botBot commented Aug 27, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a73a5ed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
NameType
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/cliPatch
@workflow/nitroPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mitul-s
mitul-s marked this pull request as ready for review August 27, 2026 22:44
@mitul-s
mitul-s requested a review from a team as a code ownerAugust 27, 2026 22:44
@github-actions

github-actionsBot commented Aug 27, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Sim World

Simulated world deterministic testing for races. Traces

🟠 world-sim scenario book — 1 fail of 41 total

fence=per-spec

scenariooutcomeeventsvirtreplayviolations
✅ smoke-no-stepscompleted30msok0
✅ smoke-one-stepcompleted60msok0
✅ hook-at-step-startedcompleted120msok0
✅ hook-at-step-completedcompleted120msok0
✅ hook-at-hook-createdcompleted120msok0
✅ deadline-hook-winscompleted71.0hok0
✅ deadline-expirescompleted71.0hok0
✅ long-sleepcompleted1130.0dok0
✅ hook-never-arrivesstalled30msskipped0
✅ step-retries-twicecompleted102.0sok0
✅ parallel-stepscompleted90msok0
✅ hook-on-execution-statecompleted120msok0
✅ peek-hook-before-branchcompleted120msok0
✅ peek-hook-after-branchcompleted120msok0
✅ peek-hook-at-registrationcompleted120msok0
✅ race-hook-before-probecompleted120msok0
✅ race-hook-after-probecompleted120msok0
✅ race-duplicate-deliverycompleted130msok0
✅ attr-hook-before-stepcompleted110msok0
✅ attr-hook-after-stepcompleted110msok0
✅ attr-from-step-bodycompleted130msok0
✅ fork-hook-after-timeoutcompleted141.0mok0
✅ fork-hook-before-timeoutcompleted141.0mok0
✅ count-hook-after-timeoutcompleted171.0mok0
✅ count-hook-before-timeoutcompleted201.0mok0
✅ stale-read-step-count-forkcompleted201.0mok0
✅ stale-read-equal-step-countscompleted141.0mok0
✅ step-vs-step-forkcompleted120msok0
✅ step-vs-step-fork-fencedcompleted120msok0
✅ fence-catches-benign-directioncompleted125msok0
✅ in-flight-before-decisioncompleted171.0mok0
❌ in-flight-before-decision-countedcompleted171.0mok0
✅ in-flight-after-decisioncompleted192.0mok0
✅ stale-read-step-count-fork-fencedcompleted201.0mok0
✅ fork-hook-winscompleted131.0mok0
✅ fork-timeout-winscompleted131.0mok0
✅ unclaimed-payload-under-forkcompleted171.0mok0
✅ claimed-payload-under-forkcompleted171.0mok0
✅ writers-independent-step-bodiescompleted120msok0
✅ writers-scripted-tempocompleted120msok0
✅ cancel-mid-stepcancelled70msskipped0

Full trace: world-sim.txt

@cursoragent
fix(web-shared): keep Alt gap overlay when nothing is selected
ba14290
pointermove was copying e.altKey, so Chrome's post-preventDefault
pointermove with altKey false cleared the flag on Alt press.
@mitul-s
mitul-s enabled auto-merge (squash) August 28, 2026 18:29
karthikscale3
karthikscale3 approved these changes Aug 28, 2026
View reviewed changes

@karthikscale3karthikscale3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@github-actions

github-actionsBot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

No backport to stable for 4d5852b (AI decision).

This fixes the trace viewer's Alt+hover delta overlay, but that functionality does not exist on stable: git grep altHeld|altKey origin/stable -- packages/web-shared returns nothing and origin/stable:packages/web-shared/src/components/trace-viewer/trace-viewer.tsx has no Alt handling at all. The commit therefore fixes a main-only feature and has nothing to repair on the maintenance line.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

4d5852b901951b8cac3948e5478e8922dc60a8ce

This was referenced Aug 28, 2026
Merged
Open
Open
Open
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karthikscale3karthikscale3karthikscale3 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mitul-s@karthikscale3@cursoragent
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Alt-click focus behavior - #3872
Merged
mitul-s merged 7 commits into
mainfrom 
c+ms/fix-alt-hover-c934
Aug 28, 2026
Merged
Alt-click focus behavior#3872
mitul-s merged 7 commits into
mainfrom 
c+ms/fix-alt-hover-c934
Conversation
@mitul-s
@mitul-smitul-s
commented
Aug 27, 2026•

edited by cursor
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
After you click a span in the trace, holding Alt no longer showed the selected-to-hovered delta. Other spans also lost hover until you switched out of Chrome and back.
Chrome treats Alt as a menu-bar shortcut. That blurs the page, which cleared altHeld and stopped hover from updating. useAltHeld now calls preventDefault on Alt (except in inputs, textareas, and contenteditable) so the menu bar does not take over. Listeners run in capture. pointermove.altKey recovers if keydown was missed. Blur still clears the flag so the overlay cannot stick after Alt+Tab.
The new hook is packages/web-shared/src/components/trace-viewer/components/use-alt-held.ts. The only other change is wiring it in trace-viewer.tsx.
How did you test your changes?
No unit tests. The failure is Chrome stealing Alt after a click, which jsdom cannot reproduce. Manual check: select a span, keep the cursor in the timeline, hold Alt, hover another span. The delta overlay should appear without leaving the tab. Typing in the search box with Option on macOS should still compose characters.
PR Checklist - Required to merge
  •  📦 pnpm changeset was run to create a changelog for this PR

    • Use the correct semver bump type: patch for bug fixes, minor for new features, major for breaking changes.
    • Use pnpm changeset --empty if you are changing documentation or workbench apps
  •  🔒 DCO sign-off passes (run git commit --signoff on your commits)
  •  📝 Ping @vercel/workflow in a comment once the PR is ready, and the above checklist is complete
Open in WebOpen in Cursor
@cursoragent
fix(web-shared): keep Alt+hover working after selecting a span
be353e2
Chrome's Alt menu-bar handling blurred the page and cleared the overlay
flag, which also killed span hover until the window was refocused.
@cursoragent
test(web-shared): drop useAltHeld unit tests
4948af5
@cursoragent
refactor(web-shared): let useAltHeld own Alt tracking
11bb233
Drop the event union, reducer, and timeline mouse-move graft. The hook
listens for keys, blur, and window pointermove itself and returns only
altHeld.
@cursor
cursorBot
commented
Aug 27, 2026

Copy link


Copy Markdown

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents
@vercel
vercelBot
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, v0Aug 28, 2026 6:32pm
example-nextjs-workflow-webpackReadyReadyPreview, v0Aug 28, 2026 6:32pm
example-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-astro-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-express-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-fastify-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-hono-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-nestjs-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-nitro-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-nuxt-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-python-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-sveltekit-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-tanstack-start-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-vite-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workflow-docsReadyReadyPreview, v0Aug 28, 2026 6:32pm
workflow-swc-playgroundReadyReadyPreview, v0Aug 28, 2026 6:32pm
workflow-tarballsReadyReadyPreview, v0Aug 28, 2026 6:32pm
workflow-webReadyReadyPreview, v0Aug 28, 2026 6:32pm
@changeset-bot
changeset-botBot
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: a73a5ed
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/cliPatch
@workflow/nitroPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@mitul-s
mitul-s
marked this pull request as ready for review
August 27, 2026 22:44
@mitul-s
mitul-s
requested a review
from a team
as a code ownerAugust 27, 2026 22:44
@github-actions
github-actionsBot
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Sim World
Simulated world deterministic testing for races. Traces
🟠 world-sim scenario book — 1 fail of 41 total
fence=per-spec
scenariooutcomeeventsvirtreplayviolations
✅ smoke-no-stepscompleted30msok0
✅ smoke-one-stepcompleted60msok0
✅ hook-at-step-startedcompleted120msok0
✅ hook-at-step-completedcompleted120msok0
✅ hook-at-hook-createdcompleted120msok0
✅ deadline-hook-winscompleted71.0hok0
✅ deadline-expirescompleted71.0hok0
✅ long-sleepcompleted1130.0dok0
✅ hook-never-arrivesstalled30msskipped0
✅ step-retries-twicecompleted102.0sok0
✅ parallel-stepscompleted90msok0
✅ hook-on-execution-statecompleted120msok0
✅ peek-hook-before-branchcompleted120msok0
✅ peek-hook-after-branchcompleted120msok0
✅ peek-hook-at-registrationcompleted120msok0
✅ race-hook-before-probecompleted120msok0
✅ race-hook-after-probecompleted120msok0
✅ race-duplicate-deliverycompleted130msok0
✅ attr-hook-before-stepcompleted110msok0
✅ attr-hook-after-stepcompleted110msok0
✅ attr-from-step-bodycompleted130msok0
✅ fork-hook-after-timeoutcompleted141.0mok0
✅ fork-hook-before-timeoutcompleted141.0mok0
✅ count-hook-after-timeoutcompleted171.0mok0
✅ count-hook-before-timeoutcompleted201.0mok0
✅ stale-read-step-count-forkcompleted201.0mok0
✅ stale-read-equal-step-countscompleted141.0mok0
✅ step-vs-step-forkcompleted120msok0
✅ step-vs-step-fork-fencedcompleted120msok0
✅ fence-catches-benign-directioncompleted125msok0
✅ in-flight-before-decisioncompleted171.0mok0
❌ in-flight-before-decision-countedcompleted171.0mok0
✅ in-flight-after-decisioncompleted192.0mok0
✅ stale-read-step-count-fork-fencedcompleted201.0mok0
✅ fork-hook-winscompleted131.0mok0
✅ fork-timeout-winscompleted131.0mok0
✅ unclaimed-payload-under-forkcompleted171.0mok0
✅ claimed-payload-under-forkcompleted171.0mok0
✅ writers-independent-step-bodiescompleted120msok0
✅ writers-scripted-tempocompleted120msok0
✅ cancel-mid-stepcancelled70msskipped0
Full trace: world-sim.txt
@cursoragent
fix(web-shared): keep Alt gap overlay when nothing is selected
ba14290
pointermove was copying e.altKey, so Chrome's post-preventDefault
pointermove with altKey false cleared the flag on Alt press.
@mitul-s
mitul-s
enabled auto-merge (squash)
August 28, 2026 18:29
karthikscale3
karthikscale3
approved these changes
Aug 28, 2026
View reviewed changes
@karthikscale3karthikscale3
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice
@github-actions
github-actionsBot
commented
Aug 28, 2026

Copy link


Copy Markdown

Contributor
No backport to stable for 4d5852b (AI decision).
This fixes the trace viewer's Alt+hover delta overlay, but that functionality does not exist on stable: git grep altHeld|altKey origin/stable -- packages/web-shared returns nothing and origin/stable:packages/web-shared/src/components/trace-viewer/trace-viewer.tsx has no Alt handling at all. The commit therefore fixes a main-only feature and has nothing to repair on the maintenance line.
To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:
4d5852b901951b8cac3948e5478e8922dc60a8ce


This was referenced Aug 28, 2026
 Merged

 Open

 Open

 Open

 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@karthikscale3karthikscale3karthikscale3 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@mitul-s@karthikscale3@cursoragent

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Alt-click focus behavior - #3872
Merged
mitul-s merged 7 commits into
mainfrom 
c+ms/fix-alt-hover-c934
Aug 28, 2026
Merged
Alt-click focus behavior#3872
mitul-s merged 7 commits into
mainfrom 
c+ms/fix-alt-hover-c934
Conversation
@mitul-s
@mitul-smitul-s
commented
Aug 27, 2026•

edited by cursor
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
After you click a span in the trace, holding Alt no longer showed the selected-to-hovered delta. Other spans also lost hover until you switched out of Chrome and back.
Chrome treats Alt as a menu-bar shortcut. That blurs the page, which cleared altHeld and stopped hover from updating. useAltHeld now calls preventDefault on Alt (except in inputs, textareas, and contenteditable) so the menu bar does not take over. Listeners run in capture. pointermove.altKey recovers if keydown was missed. Blur still clears the flag so the overlay cannot stick after Alt+Tab.
The new hook is packages/web-shared/src/components/trace-viewer/components/use-alt-held.ts. The only other change is wiring it in trace-viewer.tsx.
How did you test your changes?
No unit tests. The failure is Chrome stealing Alt after a click, which jsdom cannot reproduce. Manual check: select a span, keep the cursor in the timeline, hold Alt, hover another span. The delta overlay should appear without leaving the tab. Typing in the search box with Option on macOS should still compose characters.
PR Checklist - Required to merge
  •  📦 pnpm changeset was run to create a changelog for this PR

    • Use the correct semver bump type: patch for bug fixes, minor for new features, major for breaking changes.
    • Use pnpm changeset --empty if you are changing documentation or workbench apps
  •  🔒 DCO sign-off passes (run git commit --signoff on your commits)
  •  📝 Ping @vercel/workflow in a comment once the PR is ready, and the above checklist is complete
Open in WebOpen in Cursor
@cursoragent
fix(web-shared): keep Alt+hover working after selecting a span
be353e2
Chrome's Alt menu-bar handling blurred the page and cleared the overlay
flag, which also killed span hover until the window was refocused.
@cursoragent
test(web-shared): drop useAltHeld unit tests
4948af5
@cursoragent
refactor(web-shared): let useAltHeld own Alt tracking
11bb233
Drop the event union, reducer, and timeline mouse-move graft. The hook
listens for keys, blur, and window pointermove itself and returns only
altHeld.
@cursor
cursorBot
commented
Aug 27, 2026

Copy link


Copy Markdown

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents
@vercel
vercelBot
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, v0Aug 28, 2026 6:32pm
example-nextjs-workflow-webpackReadyReadyPreview, v0Aug 28, 2026 6:32pm
example-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-astro-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-express-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-fastify-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-hono-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-nestjs-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-nitro-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-nuxt-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-python-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-sveltekit-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-tanstack-start-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-vite-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workflow-docsReadyReadyPreview, v0Aug 28, 2026 6:32pm
workflow-swc-playgroundReadyReadyPreview, v0Aug 28, 2026 6:32pm
workflow-tarballsReadyReadyPreview, v0Aug 28, 2026 6:32pm
workflow-webReadyReadyPreview, v0Aug 28, 2026 6:32pm
@changeset-bot
changeset-botBot
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: a73a5ed
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/cliPatch
@workflow/nitroPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@mitul-s
mitul-s
marked this pull request as ready for review
August 27, 2026 22:44
@mitul-s
mitul-s
requested a review
from a team
as a code ownerAugust 27, 2026 22:44
@github-actions
github-actionsBot
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Sim World
Simulated world deterministic testing for races. Traces
🟠 world-sim scenario book — 1 fail of 41 total
fence=per-spec
scenariooutcomeeventsvirtreplayviolations
✅ smoke-no-stepscompleted30msok0
✅ smoke-one-stepcompleted60msok0
✅ hook-at-step-startedcompleted120msok0
✅ hook-at-step-completedcompleted120msok0
✅ hook-at-hook-createdcompleted120msok0
✅ deadline-hook-winscompleted71.0hok0
✅ deadline-expirescompleted71.0hok0
✅ long-sleepcompleted1130.0dok0
✅ hook-never-arrivesstalled30msskipped0
✅ step-retries-twicecompleted102.0sok0
✅ parallel-stepscompleted90msok0
✅ hook-on-execution-statecompleted120msok0
✅ peek-hook-before-branchcompleted120msok0
✅ peek-hook-after-branchcompleted120msok0
✅ peek-hook-at-registrationcompleted120msok0
✅ race-hook-before-probecompleted120msok0
✅ race-hook-after-probecompleted120msok0
✅ race-duplicate-deliverycompleted130msok0
✅ attr-hook-before-stepcompleted110msok0
✅ attr-hook-after-stepcompleted110msok0
✅ attr-from-step-bodycompleted130msok0
✅ fork-hook-after-timeoutcompleted141.0mok0
✅ fork-hook-before-timeoutcompleted141.0mok0
✅ count-hook-after-timeoutcompleted171.0mok0
✅ count-hook-before-timeoutcompleted201.0mok0
✅ stale-read-step-count-forkcompleted201.0mok0
✅ stale-read-equal-step-countscompleted141.0mok0
✅ step-vs-step-forkcompleted120msok0
✅ step-vs-step-fork-fencedcompleted120msok0
✅ fence-catches-benign-directioncompleted125msok0
✅ in-flight-before-decisioncompleted171.0mok0
❌ in-flight-before-decision-countedcompleted171.0mok0
✅ in-flight-after-decisioncompleted192.0mok0
✅ stale-read-step-count-fork-fencedcompleted201.0mok0
✅ fork-hook-winscompleted131.0mok0
✅ fork-timeout-winscompleted131.0mok0
✅ unclaimed-payload-under-forkcompleted171.0mok0
✅ claimed-payload-under-forkcompleted171.0mok0
✅ writers-independent-step-bodiescompleted120msok0
✅ writers-scripted-tempocompleted120msok0
✅ cancel-mid-stepcancelled70msskipped0
Full trace: world-sim.txt
@cursoragent
fix(web-shared): keep Alt gap overlay when nothing is selected
ba14290
pointermove was copying e.altKey, so Chrome's post-preventDefault
pointermove with altKey false cleared the flag on Alt press.
@mitul-s
mitul-s
enabled auto-merge (squash)
August 28, 2026 18:29
karthikscale3
karthikscale3
approved these changes
Aug 28, 2026
View reviewed changes
@karthikscale3karthikscale3
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice
@github-actions
github-actionsBot
commented
Aug 28, 2026

Copy link


Copy Markdown

Contributor
No backport to stable for 4d5852b (AI decision).
This fixes the trace viewer's Alt+hover delta overlay, but that functionality does not exist on stable: git grep altHeld|altKey origin/stable -- packages/web-shared returns nothing and origin/stable:packages/web-shared/src/components/trace-viewer/trace-viewer.tsx has no Alt handling at all. The commit therefore fixes a main-only feature and has nothing to repair on the maintenance line.
To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:
4d5852b901951b8cac3948e5478e8922dc60a8ce


This was referenced Aug 28, 2026
 Merged

 Open

 Open

 Open

 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@karthikscale3karthikscale3karthikscale3 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@mitul-s@karthikscale3@cursoragent

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Alt-click focus behavior - #3872
Merged
mitul-s merged 7 commits into
mainfrom 
c+ms/fix-alt-hover-c934
Aug 28, 2026
Merged
Alt-click focus behavior#3872
mitul-s merged 7 commits into
mainfrom 
c+ms/fix-alt-hover-c934
Conversation
@mitul-s
@mitul-smitul-s
commented
Aug 27, 2026•

edited by cursor
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
After you click a span in the trace, holding Alt no longer showed the selected-to-hovered delta. Other spans also lost hover until you switched out of Chrome and back.
Chrome treats Alt as a menu-bar shortcut. That blurs the page, which cleared altHeld and stopped hover from updating. useAltHeld now calls preventDefault on Alt (except in inputs, textareas, and contenteditable) so the menu bar does not take over. Listeners run in capture. pointermove.altKey recovers if keydown was missed. Blur still clears the flag so the overlay cannot stick after Alt+Tab.
The new hook is packages/web-shared/src/components/trace-viewer/components/use-alt-held.ts. The only other change is wiring it in trace-viewer.tsx.
How did you test your changes?
No unit tests. The failure is Chrome stealing Alt after a click, which jsdom cannot reproduce. Manual check: select a span, keep the cursor in the timeline, hold Alt, hover another span. The delta overlay should appear without leaving the tab. Typing in the search box with Option on macOS should still compose characters.
PR Checklist - Required to merge
  •  📦 pnpm changeset was run to create a changelog for this PR

    • Use the correct semver bump type: patch for bug fixes, minor for new features, major for breaking changes.
    • Use pnpm changeset --empty if you are changing documentation or workbench apps
  •  🔒 DCO sign-off passes (run git commit --signoff on your commits)
  •  📝 Ping @vercel/workflow in a comment once the PR is ready, and the above checklist is complete
Open in WebOpen in Cursor
@cursoragent
fix(web-shared): keep Alt+hover working after selecting a span
be353e2
Chrome's Alt menu-bar handling blurred the page and cleared the overlay
flag, which also killed span hover until the window was refocused.
@cursoragent
test(web-shared): drop useAltHeld unit tests
4948af5
@cursoragent
refactor(web-shared): let useAltHeld own Alt tracking
11bb233
Drop the event union, reducer, and timeline mouse-move graft. The hook
listens for keys, blur, and window pointermove itself and returns only
altHeld.
@cursor
cursorBot
commented
Aug 27, 2026

Copy link


Copy Markdown

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents
@vercel
vercelBot
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, v0Aug 28, 2026 6:32pm
example-nextjs-workflow-webpackReadyReadyPreview, v0Aug 28, 2026 6:32pm
example-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-astro-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-express-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-fastify-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-hono-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-nestjs-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-nitro-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-nuxt-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-python-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-sveltekit-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-tanstack-start-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-vite-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workflow-docsReadyReadyPreview, v0Aug 28, 2026 6:32pm
workflow-swc-playgroundReadyReadyPreview, v0Aug 28, 2026 6:32pm
workflow-tarballsReadyReadyPreview, v0Aug 28, 2026 6:32pm
workflow-webReadyReadyPreview, v0Aug 28, 2026 6:32pm
@changeset-bot
changeset-botBot
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: a73a5ed
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/cliPatch
@workflow/nitroPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@mitul-s
mitul-s
marked this pull request as ready for review
August 27, 2026 22:44
@mitul-s
mitul-s
requested a review
from a team
as a code ownerAugust 27, 2026 22:44
@github-actions
github-actionsBot
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Sim World
Simulated world deterministic testing for races. Traces
🟠 world-sim scenario book — 1 fail of 41 total
fence=per-spec
scenariooutcomeeventsvirtreplayviolations
✅ smoke-no-stepscompleted30msok0
✅ smoke-one-stepcompleted60msok0
✅ hook-at-step-startedcompleted120msok0
✅ hook-at-step-completedcompleted120msok0
✅ hook-at-hook-createdcompleted120msok0
✅ deadline-hook-winscompleted71.0hok0
✅ deadline-expirescompleted71.0hok0
✅ long-sleepcompleted1130.0dok0
✅ hook-never-arrivesstalled30msskipped0
✅ step-retries-twicecompleted102.0sok0
✅ parallel-stepscompleted90msok0
✅ hook-on-execution-statecompleted120msok0
✅ peek-hook-before-branchcompleted120msok0
✅ peek-hook-after-branchcompleted120msok0
✅ peek-hook-at-registrationcompleted120msok0
✅ race-hook-before-probecompleted120msok0
✅ race-hook-after-probecompleted120msok0
✅ race-duplicate-deliverycompleted130msok0
✅ attr-hook-before-stepcompleted110msok0
✅ attr-hook-after-stepcompleted110msok0
✅ attr-from-step-bodycompleted130msok0
✅ fork-hook-after-timeoutcompleted141.0mok0
✅ fork-hook-before-timeoutcompleted141.0mok0
✅ count-hook-after-timeoutcompleted171.0mok0
✅ count-hook-before-timeoutcompleted201.0mok0
✅ stale-read-step-count-forkcompleted201.0mok0
✅ stale-read-equal-step-countscompleted141.0mok0
✅ step-vs-step-forkcompleted120msok0
✅ step-vs-step-fork-fencedcompleted120msok0
✅ fence-catches-benign-directioncompleted125msok0
✅ in-flight-before-decisioncompleted171.0mok0
❌ in-flight-before-decision-countedcompleted171.0mok0
✅ in-flight-after-decisioncompleted192.0mok0
✅ stale-read-step-count-fork-fencedcompleted201.0mok0
✅ fork-hook-winscompleted131.0mok0
✅ fork-timeout-winscompleted131.0mok0
✅ unclaimed-payload-under-forkcompleted171.0mok0
✅ claimed-payload-under-forkcompleted171.0mok0
✅ writers-independent-step-bodiescompleted120msok0
✅ writers-scripted-tempocompleted120msok0
✅ cancel-mid-stepcancelled70msskipped0
Full trace: world-sim.txt
@cursoragent
fix(web-shared): keep Alt gap overlay when nothing is selected
ba14290
pointermove was copying e.altKey, so Chrome's post-preventDefault
pointermove with altKey false cleared the flag on Alt press.
@mitul-s
mitul-s
enabled auto-merge (squash)
August 28, 2026 18:29
karthikscale3
karthikscale3
approved these changes
Aug 28, 2026
View reviewed changes
@karthikscale3karthikscale3
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice
@github-actions
github-actionsBot
commented
Aug 28, 2026

Copy link


Copy Markdown

Contributor
No backport to stable for 4d5852b (AI decision).
This fixes the trace viewer's Alt+hover delta overlay, but that functionality does not exist on stable: git grep altHeld|altKey origin/stable -- packages/web-shared returns nothing and origin/stable:packages/web-shared/src/components/trace-viewer/trace-viewer.tsx has no Alt handling at all. The commit therefore fixes a main-only feature and has nothing to repair on the maintenance line.
To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:
4d5852b901951b8cac3948e5478e8922dc60a8ce


This was referenced Aug 28, 2026
 Merged

 Open

 Open

 Open

 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@karthikscale3karthikscale3karthikscale3 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@mitul-s@karthikscale3@cursoragent

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Alt-click focus behavior - #3872
Merged
mitul-s merged 7 commits into
mainfrom 
c+ms/fix-alt-hover-c934
Aug 28, 2026
Merged
Alt-click focus behavior#3872
mitul-s merged 7 commits into
mainfrom 
c+ms/fix-alt-hover-c934
Conversation
@mitul-s
@mitul-smitul-s
commented
Aug 27, 2026•

edited by cursor
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
After you click a span in the trace, holding Alt no longer showed the selected-to-hovered delta. Other spans also lost hover until you switched out of Chrome and back.
Chrome treats Alt as a menu-bar shortcut. That blurs the page, which cleared altHeld and stopped hover from updating. useAltHeld now calls preventDefault on Alt (except in inputs, textareas, and contenteditable) so the menu bar does not take over. Listeners run in capture. pointermove.altKey recovers if keydown was missed. Blur still clears the flag so the overlay cannot stick after Alt+Tab.
The new hook is packages/web-shared/src/components/trace-viewer/components/use-alt-held.ts. The only other change is wiring it in trace-viewer.tsx.
How did you test your changes?
No unit tests. The failure is Chrome stealing Alt after a click, which jsdom cannot reproduce. Manual check: select a span, keep the cursor in the timeline, hold Alt, hover another span. The delta overlay should appear without leaving the tab. Typing in the search box with Option on macOS should still compose characters.
PR Checklist - Required to merge
  •  📦 pnpm changeset was run to create a changelog for this PR

    • Use the correct semver bump type: patch for bug fixes, minor for new features, major for breaking changes.
    • Use pnpm changeset --empty if you are changing documentation or workbench apps
  •  🔒 DCO sign-off passes (run git commit --signoff on your commits)
  •  📝 Ping @vercel/workflow in a comment once the PR is ready, and the above checklist is complete
Open in WebOpen in Cursor
@cursoragent
fix(web-shared): keep Alt+hover working after selecting a span
be353e2
Chrome's Alt menu-bar handling blurred the page and cleared the overlay
flag, which also killed span hover until the window was refocused.
@cursoragent
test(web-shared): drop useAltHeld unit tests
4948af5
@cursoragent
refactor(web-shared): let useAltHeld own Alt tracking
11bb233
Drop the event union, reducer, and timeline mouse-move graft. The hook
listens for keys, blur, and window pointermove itself and returns only
altHeld.
@cursor
cursorBot
commented
Aug 27, 2026

Copy link


Copy Markdown

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents
@vercel
vercelBot
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, v0Aug 28, 2026 6:32pm
example-nextjs-workflow-webpackReadyReadyPreview, v0Aug 28, 2026 6:32pm
example-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-astro-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-express-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-fastify-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-hono-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-nestjs-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-nitro-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-nuxt-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-python-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-sveltekit-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-tanstack-start-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-vite-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workflow-docsReadyReadyPreview, v0Aug 28, 2026 6:32pm
workflow-swc-playgroundReadyReadyPreview, v0Aug 28, 2026 6:32pm
workflow-tarballsReadyReadyPreview, v0Aug 28, 2026 6:32pm
workflow-webReadyReadyPreview, v0Aug 28, 2026 6:32pm
@changeset-bot
changeset-botBot
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: a73a5ed
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/cliPatch
@workflow/nitroPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@mitul-s
mitul-s
marked this pull request as ready for review
August 27, 2026 22:44
@mitul-s
mitul-s
requested a review
from a team
as a code ownerAugust 27, 2026 22:44
@github-actions
github-actionsBot
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Sim World
Simulated world deterministic testing for races. Traces
🟠 world-sim scenario book — 1 fail of 41 total
fence=per-spec
scenariooutcomeeventsvirtreplayviolations
✅ smoke-no-stepscompleted30msok0
✅ smoke-one-stepcompleted60msok0
✅ hook-at-step-startedcompleted120msok0
✅ hook-at-step-completedcompleted120msok0
✅ hook-at-hook-createdcompleted120msok0
✅ deadline-hook-winscompleted71.0hok0
✅ deadline-expirescompleted71.0hok0
✅ long-sleepcompleted1130.0dok0
✅ hook-never-arrivesstalled30msskipped0
✅ step-retries-twicecompleted102.0sok0
✅ parallel-stepscompleted90msok0
✅ hook-on-execution-statecompleted120msok0
✅ peek-hook-before-branchcompleted120msok0
✅ peek-hook-after-branchcompleted120msok0
✅ peek-hook-at-registrationcompleted120msok0
✅ race-hook-before-probecompleted120msok0
✅ race-hook-after-probecompleted120msok0
✅ race-duplicate-deliverycompleted130msok0
✅ attr-hook-before-stepcompleted110msok0
✅ attr-hook-after-stepcompleted110msok0
✅ attr-from-step-bodycompleted130msok0
✅ fork-hook-after-timeoutcompleted141.0mok0
✅ fork-hook-before-timeoutcompleted141.0mok0
✅ count-hook-after-timeoutcompleted171.0mok0
✅ count-hook-before-timeoutcompleted201.0mok0
✅ stale-read-step-count-forkcompleted201.0mok0
✅ stale-read-equal-step-countscompleted141.0mok0
✅ step-vs-step-forkcompleted120msok0
✅ step-vs-step-fork-fencedcompleted120msok0
✅ fence-catches-benign-directioncompleted125msok0
✅ in-flight-before-decisioncompleted171.0mok0
❌ in-flight-before-decision-countedcompleted171.0mok0
✅ in-flight-after-decisioncompleted192.0mok0
✅ stale-read-step-count-fork-fencedcompleted201.0mok0
✅ fork-hook-winscompleted131.0mok0
✅ fork-timeout-winscompleted131.0mok0
✅ unclaimed-payload-under-forkcompleted171.0mok0
✅ claimed-payload-under-forkcompleted171.0mok0
✅ writers-independent-step-bodiescompleted120msok0
✅ writers-scripted-tempocompleted120msok0
✅ cancel-mid-stepcancelled70msskipped0
Full trace: world-sim.txt
@cursoragent
fix(web-shared): keep Alt gap overlay when nothing is selected
ba14290
pointermove was copying e.altKey, so Chrome's post-preventDefault
pointermove with altKey false cleared the flag on Alt press.
@mitul-s
mitul-s
enabled auto-merge (squash)
August 28, 2026 18:29
karthikscale3
karthikscale3
approved these changes
Aug 28, 2026
View reviewed changes
@karthikscale3karthikscale3
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice
@github-actions
github-actionsBot
commented
Aug 28, 2026

Copy link


Copy Markdown

Contributor
No backport to stable for 4d5852b (AI decision).
This fixes the trace viewer's Alt+hover delta overlay, but that functionality does not exist on stable: git grep altHeld|altKey origin/stable -- packages/web-shared returns nothing and origin/stable:packages/web-shared/src/components/trace-viewer/trace-viewer.tsx has no Alt handling at all. The commit therefore fixes a main-only feature and has nothing to repair on the maintenance line.
To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:
4d5852b901951b8cac3948e5478e8922dc60a8ce


This was referenced Aug 28, 2026
 Merged

 Open

 Open

 Open

 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@karthikscale3karthikscale3karthikscale3 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@mitul-s@karthikscale3@cursoragent

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Alt-click focus behavior - #3872
Merged
mitul-s merged 7 commits into
mainfrom 
c+ms/fix-alt-hover-c934
Aug 28, 2026
Merged
Alt-click focus behavior#3872
mitul-s merged 7 commits into
mainfrom 
c+ms/fix-alt-hover-c934
Conversation
@mitul-s
@mitul-smitul-s
commented
Aug 27, 2026•

edited by cursor
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
After you click a span in the trace, holding Alt no longer showed the selected-to-hovered delta. Other spans also lost hover until you switched out of Chrome and back.
Chrome treats Alt as a menu-bar shortcut. That blurs the page, which cleared altHeld and stopped hover from updating. useAltHeld now calls preventDefault on Alt (except in inputs, textareas, and contenteditable) so the menu bar does not take over. Listeners run in capture. pointermove.altKey recovers if keydown was missed. Blur still clears the flag so the overlay cannot stick after Alt+Tab.
The new hook is packages/web-shared/src/components/trace-viewer/components/use-alt-held.ts. The only other change is wiring it in trace-viewer.tsx.
How did you test your changes?
No unit tests. The failure is Chrome stealing Alt after a click, which jsdom cannot reproduce. Manual check: select a span, keep the cursor in the timeline, hold Alt, hover another span. The delta overlay should appear without leaving the tab. Typing in the search box with Option on macOS should still compose characters.
PR Checklist - Required to merge
  •  📦 pnpm changeset was run to create a changelog for this PR

    • Use the correct semver bump type: patch for bug fixes, minor for new features, major for breaking changes.
    • Use pnpm changeset --empty if you are changing documentation or workbench apps
  •  🔒 DCO sign-off passes (run git commit --signoff on your commits)
  •  📝 Ping @vercel/workflow in a comment once the PR is ready, and the above checklist is complete
Open in WebOpen in Cursor
@cursoragent
fix(web-shared): keep Alt+hover working after selecting a span
be353e2
Chrome's Alt menu-bar handling blurred the page and cleared the overlay
flag, which also killed span hover until the window was refocused.
@cursoragent
test(web-shared): drop useAltHeld unit tests
4948af5
@cursoragent
refactor(web-shared): let useAltHeld own Alt tracking
11bb233
Drop the event union, reducer, and timeline mouse-move graft. The hook
listens for keys, blur, and window pointermove itself and returns only
altHeld.
@cursor
cursorBot
commented
Aug 27, 2026

Copy link


Copy Markdown

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents
@vercel
vercelBot
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, v0Aug 28, 2026 6:32pm
example-nextjs-workflow-webpackReadyReadyPreview, v0Aug 28, 2026 6:32pm
example-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-astro-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-express-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-fastify-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-hono-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-nestjs-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-nitro-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-nuxt-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-python-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-sveltekit-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-tanstack-start-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-vite-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workflow-docsReadyReadyPreview, v0Aug 28, 2026 6:32pm
workflow-swc-playgroundReadyReadyPreview, v0Aug 28, 2026 6:32pm
workflow-tarballsReadyReadyPreview, v0Aug 28, 2026 6:32pm
workflow-webReadyReadyPreview, v0Aug 28, 2026 6:32pm
@changeset-bot
changeset-botBot
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: a73a5ed
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/cliPatch
@workflow/nitroPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@mitul-s
mitul-s
marked this pull request as ready for review
August 27, 2026 22:44
@mitul-s
mitul-s
requested a review
from a team
as a code ownerAugust 27, 2026 22:44
@github-actions
github-actionsBot
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Sim World
Simulated world deterministic testing for races. Traces
🟠 world-sim scenario book — 1 fail of 41 total
fence=per-spec
scenariooutcomeeventsvirtreplayviolations
✅ smoke-no-stepscompleted30msok0
✅ smoke-one-stepcompleted60msok0
✅ hook-at-step-startedcompleted120msok0
✅ hook-at-step-completedcompleted120msok0
✅ hook-at-hook-createdcompleted120msok0
✅ deadline-hook-winscompleted71.0hok0
✅ deadline-expirescompleted71.0hok0
✅ long-sleepcompleted1130.0dok0
✅ hook-never-arrivesstalled30msskipped0
✅ step-retries-twicecompleted102.0sok0
✅ parallel-stepscompleted90msok0
✅ hook-on-execution-statecompleted120msok0
✅ peek-hook-before-branchcompleted120msok0
✅ peek-hook-after-branchcompleted120msok0
✅ peek-hook-at-registrationcompleted120msok0
✅ race-hook-before-probecompleted120msok0
✅ race-hook-after-probecompleted120msok0
✅ race-duplicate-deliverycompleted130msok0
✅ attr-hook-before-stepcompleted110msok0
✅ attr-hook-after-stepcompleted110msok0
✅ attr-from-step-bodycompleted130msok0
✅ fork-hook-after-timeoutcompleted141.0mok0
✅ fork-hook-before-timeoutcompleted141.0mok0
✅ count-hook-after-timeoutcompleted171.0mok0
✅ count-hook-before-timeoutcompleted201.0mok0
✅ stale-read-step-count-forkcompleted201.0mok0
✅ stale-read-equal-step-countscompleted141.0mok0
✅ step-vs-step-forkcompleted120msok0
✅ step-vs-step-fork-fencedcompleted120msok0
✅ fence-catches-benign-directioncompleted125msok0
✅ in-flight-before-decisioncompleted171.0mok0
❌ in-flight-before-decision-countedcompleted171.0mok0
✅ in-flight-after-decisioncompleted192.0mok0
✅ stale-read-step-count-fork-fencedcompleted201.0mok0
✅ fork-hook-winscompleted131.0mok0
✅ fork-timeout-winscompleted131.0mok0
✅ unclaimed-payload-under-forkcompleted171.0mok0
✅ claimed-payload-under-forkcompleted171.0mok0
✅ writers-independent-step-bodiescompleted120msok0
✅ writers-scripted-tempocompleted120msok0
✅ cancel-mid-stepcancelled70msskipped0
Full trace: world-sim.txt
@cursoragent
fix(web-shared): keep Alt gap overlay when nothing is selected
ba14290
pointermove was copying e.altKey, so Chrome's post-preventDefault
pointermove with altKey false cleared the flag on Alt press.
@mitul-s
mitul-s
enabled auto-merge (squash)
August 28, 2026 18:29
karthikscale3
karthikscale3
approved these changes
Aug 28, 2026
View reviewed changes
@karthikscale3karthikscale3
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice
@github-actions
github-actionsBot
commented
Aug 28, 2026

Copy link


Copy Markdown

Contributor
No backport to stable for 4d5852b (AI decision).
This fixes the trace viewer's Alt+hover delta overlay, but that functionality does not exist on stable: git grep altHeld|altKey origin/stable -- packages/web-shared returns nothing and origin/stable:packages/web-shared/src/components/trace-viewer/trace-viewer.tsx has no Alt handling at all. The commit therefore fixes a main-only feature and has nothing to repair on the maintenance line.
To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:
4d5852b901951b8cac3948e5478e8922dc60a8ce


This was referenced Aug 28, 2026
 Merged

 Open

 Open

 Open

 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@karthikscale3karthikscale3karthikscale3 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@mitul-s@karthikscale3@cursoragent

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Alt-click focus behavior - #3872
Merged
mitul-s merged 7 commits into
mainfrom 
c+ms/fix-alt-hover-c934
Aug 28, 2026
Merged
Alt-click focus behavior#3872
mitul-s merged 7 commits into
mainfrom 
c+ms/fix-alt-hover-c934
Conversation
@mitul-s
@mitul-smitul-s
commented
Aug 27, 2026•

edited by cursor
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
After you click a span in the trace, holding Alt no longer showed the selected-to-hovered delta. Other spans also lost hover until you switched out of Chrome and back.
Chrome treats Alt as a menu-bar shortcut. That blurs the page, which cleared altHeld and stopped hover from updating. useAltHeld now calls preventDefault on Alt (except in inputs, textareas, and contenteditable) so the menu bar does not take over. Listeners run in capture. pointermove.altKey recovers if keydown was missed. Blur still clears the flag so the overlay cannot stick after Alt+Tab.
The new hook is packages/web-shared/src/components/trace-viewer/components/use-alt-held.ts. The only other change is wiring it in trace-viewer.tsx.
How did you test your changes?
No unit tests. The failure is Chrome stealing Alt after a click, which jsdom cannot reproduce. Manual check: select a span, keep the cursor in the timeline, hold Alt, hover another span. The delta overlay should appear without leaving the tab. Typing in the search box with Option on macOS should still compose characters.
PR Checklist - Required to merge
  •  📦 pnpm changeset was run to create a changelog for this PR

    • Use the correct semver bump type: patch for bug fixes, minor for new features, major for breaking changes.
    • Use pnpm changeset --empty if you are changing documentation or workbench apps
  •  🔒 DCO sign-off passes (run git commit --signoff on your commits)
  •  📝 Ping @vercel/workflow in a comment once the PR is ready, and the above checklist is complete
Open in WebOpen in Cursor
@cursoragent
fix(web-shared): keep Alt+hover working after selecting a span
be353e2
Chrome's Alt menu-bar handling blurred the page and cleared the overlay
flag, which also killed span hover until the window was refocused.
@cursoragent
test(web-shared): drop useAltHeld unit tests
4948af5
@cursoragent
refactor(web-shared): let useAltHeld own Alt tracking
11bb233
Drop the event union, reducer, and timeline mouse-move graft. The hook
listens for keys, blur, and window pointermove itself and returns only
altHeld.
@cursor
cursorBot
commented
Aug 27, 2026

Copy link


Copy Markdown

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents
@vercel
vercelBot
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, v0Aug 28, 2026 6:32pm
example-nextjs-workflow-webpackReadyReadyPreview, v0Aug 28, 2026 6:32pm
example-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-astro-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-express-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-fastify-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-hono-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-nestjs-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-nitro-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-nuxt-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-python-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-sveltekit-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-tanstack-start-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-vite-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workflow-docsReadyReadyPreview, v0Aug 28, 2026 6:32pm
workflow-swc-playgroundReadyReadyPreview, v0Aug 28, 2026 6:32pm
workflow-tarballsReadyReadyPreview, v0Aug 28, 2026 6:32pm
workflow-webReadyReadyPreview, v0Aug 28, 2026 6:32pm
@changeset-bot
changeset-botBot
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: a73a5ed
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/cliPatch
@workflow/nitroPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@mitul-s
mitul-s
marked this pull request as ready for review
August 27, 2026 22:44
@mitul-s
mitul-s
requested a review
from a team
as a code ownerAugust 27, 2026 22:44
@github-actions
github-actionsBot
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Sim World
Simulated world deterministic testing for races. Traces
🟠 world-sim scenario book — 1 fail of 41 total
fence=per-spec
scenariooutcomeeventsvirtreplayviolations
✅ smoke-no-stepscompleted30msok0
✅ smoke-one-stepcompleted60msok0
✅ hook-at-step-startedcompleted120msok0
✅ hook-at-step-completedcompleted120msok0
✅ hook-at-hook-createdcompleted120msok0
✅ deadline-hook-winscompleted71.0hok0
✅ deadline-expirescompleted71.0hok0
✅ long-sleepcompleted1130.0dok0
✅ hook-never-arrivesstalled30msskipped0
✅ step-retries-twicecompleted102.0sok0
✅ parallel-stepscompleted90msok0
✅ hook-on-execution-statecompleted120msok0
✅ peek-hook-before-branchcompleted120msok0
✅ peek-hook-after-branchcompleted120msok0
✅ peek-hook-at-registrationcompleted120msok0
✅ race-hook-before-probecompleted120msok0
✅ race-hook-after-probecompleted120msok0
✅ race-duplicate-deliverycompleted130msok0
✅ attr-hook-before-stepcompleted110msok0
✅ attr-hook-after-stepcompleted110msok0
✅ attr-from-step-bodycompleted130msok0
✅ fork-hook-after-timeoutcompleted141.0mok0
✅ fork-hook-before-timeoutcompleted141.0mok0
✅ count-hook-after-timeoutcompleted171.0mok0
✅ count-hook-before-timeoutcompleted201.0mok0
✅ stale-read-step-count-forkcompleted201.0mok0
✅ stale-read-equal-step-countscompleted141.0mok0
✅ step-vs-step-forkcompleted120msok0
✅ step-vs-step-fork-fencedcompleted120msok0
✅ fence-catches-benign-directioncompleted125msok0
✅ in-flight-before-decisioncompleted171.0mok0
❌ in-flight-before-decision-countedcompleted171.0mok0
✅ in-flight-after-decisioncompleted192.0mok0
✅ stale-read-step-count-fork-fencedcompleted201.0mok0
✅ fork-hook-winscompleted131.0mok0
✅ fork-timeout-winscompleted131.0mok0
✅ unclaimed-payload-under-forkcompleted171.0mok0
✅ claimed-payload-under-forkcompleted171.0mok0
✅ writers-independent-step-bodiescompleted120msok0
✅ writers-scripted-tempocompleted120msok0
✅ cancel-mid-stepcancelled70msskipped0
Full trace: world-sim.txt
@cursoragent
fix(web-shared): keep Alt gap overlay when nothing is selected
ba14290
pointermove was copying e.altKey, so Chrome's post-preventDefault
pointermove with altKey false cleared the flag on Alt press.
@mitul-s
mitul-s
enabled auto-merge (squash)
August 28, 2026 18:29
karthikscale3
karthikscale3
approved these changes
Aug 28, 2026
View reviewed changes
@karthikscale3karthikscale3
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice
@github-actions
github-actionsBot
commented
Aug 28, 2026

Copy link


Copy Markdown

Contributor
No backport to stable for 4d5852b (AI decision).
This fixes the trace viewer's Alt+hover delta overlay, but that functionality does not exist on stable: git grep altHeld|altKey origin/stable -- packages/web-shared returns nothing and origin/stable:packages/web-shared/src/components/trace-viewer/trace-viewer.tsx has no Alt handling at all. The commit therefore fixes a main-only feature and has nothing to repair on the maintenance line.
To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:
4d5852b901951b8cac3948e5478e8922dc60a8ce


This was referenced Aug 28, 2026
 Merged

 Open

 Open

 Open

 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@karthikscale3karthikscale3karthikscale3 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@mitul-s@karthikscale3@cursoragent

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Alt-click focus behavior - #3872
Merged
mitul-s merged 7 commits into
mainfrom 
c+ms/fix-alt-hover-c934
Aug 28, 2026
Merged
Alt-click focus behavior#3872
mitul-s merged 7 commits into
mainfrom 
c+ms/fix-alt-hover-c934
Conversation
@mitul-s
@mitul-smitul-s
commented
Aug 27, 2026•

edited by cursor
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
After you click a span in the trace, holding Alt no longer showed the selected-to-hovered delta. Other spans also lost hover until you switched out of Chrome and back.
Chrome treats Alt as a menu-bar shortcut. That blurs the page, which cleared altHeld and stopped hover from updating. useAltHeld now calls preventDefault on Alt (except in inputs, textareas, and contenteditable) so the menu bar does not take over. Listeners run in capture. pointermove.altKey recovers if keydown was missed. Blur still clears the flag so the overlay cannot stick after Alt+Tab.
The new hook is packages/web-shared/src/components/trace-viewer/components/use-alt-held.ts. The only other change is wiring it in trace-viewer.tsx.
How did you test your changes?
No unit tests. The failure is Chrome stealing Alt after a click, which jsdom cannot reproduce. Manual check: select a span, keep the cursor in the timeline, hold Alt, hover another span. The delta overlay should appear without leaving the tab. Typing in the search box with Option on macOS should still compose characters.
PR Checklist - Required to merge
  •  📦 pnpm changeset was run to create a changelog for this PR

    • Use the correct semver bump type: patch for bug fixes, minor for new features, major for breaking changes.
    • Use pnpm changeset --empty if you are changing documentation or workbench apps
  •  🔒 DCO sign-off passes (run git commit --signoff on your commits)
  •  📝 Ping @vercel/workflow in a comment once the PR is ready, and the above checklist is complete
Open in WebOpen in Cursor
@cursoragent
fix(web-shared): keep Alt+hover working after selecting a span
be353e2
Chrome's Alt menu-bar handling blurred the page and cleared the overlay
flag, which also killed span hover until the window was refocused.
@cursoragent
test(web-shared): drop useAltHeld unit tests
4948af5
@cursoragent
refactor(web-shared): let useAltHeld own Alt tracking
11bb233
Drop the event union, reducer, and timeline mouse-move graft. The hook
listens for keys, blur, and window pointermove itself and returns only
altHeld.
@cursor
cursorBot
commented
Aug 27, 2026

Copy link


Copy Markdown

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents
@vercel
vercelBot
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
example-nextjs-workflow-turbopackReadyReadyPreview, v0Aug 28, 2026 6:32pm
example-nextjs-workflow-webpackReadyReadyPreview, v0Aug 28, 2026 6:32pm
example-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-astro-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-express-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-fastify-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-hono-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-nestjs-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-nitro-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-nuxt-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-python-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-sveltekit-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-tanstack-start-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workbench-vite-workflowReadyReadyPreview, v0Aug 28, 2026 6:32pm
workflow-docsReadyReadyPreview, v0Aug 28, 2026 6:32pm
workflow-swc-playgroundReadyReadyPreview, v0Aug 28, 2026 6:32pm
workflow-tarballsReadyReadyPreview, v0Aug 28, 2026 6:32pm
workflow-webReadyReadyPreview, v0Aug 28, 2026 6:32pm
@changeset-bot
changeset-botBot
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: a73a5ed
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 16 packages
NameType
@workflow/web-sharedPatch
@workflow/webPatch
@workflow/cliPatch
@workflow/nitroPatch
workflowPatch
@workflow/world-testingPatch
@workflow/nuxtPatch
@workflow/corePatch
@workflow/buildersPatch
@workflow/nextPatch
@workflow/vitestPatch
@workflow/astroPatch
@workflow/nestPatch
@workflow/rollupPatch
@workflow/sveltekitPatch
@workflow/vitePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@mitul-s
mitul-s
marked this pull request as ready for review
August 27, 2026 22:44
@mitul-s
mitul-s
requested a review
from a team
as a code ownerAugust 27, 2026 22:44
@github-actions
github-actionsBot
commented
Aug 27, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Sim World
Simulated world deterministic testing for races. Traces
🟠 world-sim scenario book — 1 fail of 41 total
fence=per-spec
scenariooutcomeeventsvirtreplayviolations
✅ smoke-no-stepscompleted30msok0
✅ smoke-one-stepcompleted60msok0
✅ hook-at-step-startedcompleted120msok0
✅ hook-at-step-completedcompleted120msok0
✅ hook-at-hook-createdcompleted120msok0
✅ deadline-hook-winscompleted71.0hok0
✅ deadline-expirescompleted71.0hok0
✅ long-sleepcompleted1130.0dok0
✅ hook-never-arrivesstalled30msskipped0
✅ step-retries-twicecompleted102.0sok0
✅ parallel-stepscompleted90msok0
✅ hook-on-execution-statecompleted120msok0
✅ peek-hook-before-branchcompleted120msok0
✅ peek-hook-after-branchcompleted120msok0
✅ peek-hook-at-registrationcompleted120msok0
✅ race-hook-before-probecompleted120msok0
✅ race-hook-after-probecompleted120msok0
✅ race-duplicate-deliverycompleted130msok0
✅ attr-hook-before-stepcompleted110msok0
✅ attr-hook-after-stepcompleted110msok0
✅ attr-from-step-bodycompleted130msok0
✅ fork-hook-after-timeoutcompleted141.0mok0
✅ fork-hook-before-timeoutcompleted141.0mok0
✅ count-hook-after-timeoutcompleted171.0mok0
✅ count-hook-before-timeoutcompleted201.0mok0
✅ stale-read-step-count-forkcompleted201.0mok0
✅ stale-read-equal-step-countscompleted141.0mok0
✅ step-vs-step-forkcompleted120msok0
✅ step-vs-step-fork-fencedcompleted120msok0
✅ fence-catches-benign-directioncompleted125msok0
✅ in-flight-before-decisioncompleted171.0mok0
❌ in-flight-before-decision-countedcompleted171.0mok0
✅ in-flight-after-decisioncompleted192.0mok0
✅ stale-read-step-count-fork-fencedcompleted201.0mok0
✅ fork-hook-winscompleted131.0mok0
✅ fork-timeout-winscompleted131.0mok0
✅ unclaimed-payload-under-forkcompleted171.0mok0
✅ claimed-payload-under-forkcompleted171.0mok0
✅ writers-independent-step-bodiescompleted120msok0
✅ writers-scripted-tempocompleted120msok0
✅ cancel-mid-stepcancelled70msskipped0
Full trace: world-sim.txt
@cursoragent
fix(web-shared): keep Alt gap overlay when nothing is selected
ba14290
pointermove was copying e.altKey, so Chrome's post-preventDefault
pointermove with altKey false cleared the flag on Alt press.
@mitul-s
mitul-s
enabled auto-merge (squash)
August 28, 2026 18:29
karthikscale3
karthikscale3
approved these changes
Aug 28, 2026
View reviewed changes
@karthikscale3karthikscale3
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice
@github-actions
github-actionsBot
commented
Aug 28, 2026

Copy link


Copy Markdown

Contributor
No backport to stable for 4d5852b (AI decision).
This fixes the trace viewer's Alt+hover delta overlay, but that functionality does not exist on stable: git grep altHeld|altKey origin/stable -- packages/web-shared returns nothing and origin/stable:packages/web-shared/src/components/trace-viewer/trace-viewer.tsx has no Alt handling at all. The commit therefore fixes a main-only feature and has nothing to repair on the maintenance line.
To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:
4d5852b901951b8cac3948e5478e8922dc60a8ce


This was referenced Aug 28, 2026
 Merged

 Open

 Open

 Open

 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@karthikscale3karthikscale3karthikscale3 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@mitul-s@karthikscale3@cursoragent