Uh oh!
There was an error while loading. Please reload this page.
fix: order the 429 check before the 4xx check in the workflow skill - #3915
Open
Nixxx19 wants to merge 1 commit into
Open
fix: order the 429 check before the 4xx check in the workflow skill#3915Nixxx19 wants to merge 1 commit into
Nixxx19 wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: b4eb17a The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
@Nixxx19 is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
Nixxx19force-pushed
the
fix/skill-429-unreachable
branch
from
September 1, 2026 06:24
1b53693 to
388234eCompareSigned-off-by: nityam <185968020+Nixxx19@users.noreply.github.com>
Nixxx19force-pushed
the
fix/skill-429-unreachable
branch
from
September 1, 2026 06:57
388234e to
b4eb17aCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes#3652
the error handling snippet in
skills/workflow/SKILL.mdchecks 4xx before 429, so theRetryableErrorbranch under it can never run.429 >= 400 && 429 < 500is true, theFatalErrorthrows first, and rate limits end up treated as permanent failures with no retry.swapping the two blocks is the whole fix.
this matters more than a normal docs typo because the file is the agent facing skill and gets autoloaded on workflow tasks, so the snippet is copied close to verbatim into generated code. it inverts the behaviour for the most common transient http failure there is.
also bumped the skill version to 1.12, matching how content changes to this file have been handled before (1.6 through 1.10 each bumped, the technical writing pass in #3704 did not since it changed no behaviour).
How did you test your changes?
no runtime code changed, so there is nothing to unit test. what i verified instead:
429satisfies>= 400 && < 500so the firstthrowalways winsskills/*,docs/app, and the workbench. every other occurrence already orders correctly, so this is the only wrong one.docs/content/docs/v5/api-reference/workflow/fetch.mdxhandles 429 inside the 4xx block, anderrors-and-retries.mdxandrate-limiting.mdxboth check 429 firstRetry-Afteroff the response likefetch.mdxdoes would be a nicer example but it widens the change beyond the bugPR Checklist - Required to merge
pnpm changesetwas run to create a changelog for this PR--empty, per the template note for documentation changes.skills/is not in the pnpm workspace so there is no package to version, and the bot confirms "changesets to release 0 packages"git commit --signoffon your commits)@vercel/workflowin a comment once the PR is ready, and the above checklist is complete