Uh oh!
There was an error while loading. Please reload this page.
Draft
Fix command injection vulnerability in CI workflow via untrusted fork PR#439
Conversation
|
Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…nt variables
Replace direct interpolation of ${{ matrix.app.name }} in shell commands with environment
variables passed via the env: section. All paths are now quoted to prevent command injection
from untrusted fork PRs.
Affected jobs:
- e2e-local-dev: Setup canary, Resolve symlinks, Run E2E Tests
- e2e-local-prod: Setup canary, Run E2E Tests
- e2e-local-postgres: Setup canary, Run E2E Tests
Co-authored-by: pranaygp <1797812+pranaygp@users.noreply.github.com>CopilotAI
changed the title
[WIP] Fix command injection in CI workflowFix command injection vulnerability in CI workflow via untrusted fork PRNov 26, 2025
VaguelySerious added a commit
that referenced
this pull request
May 21, 2026
Sets WORKFLOW_SERVER_URL_OVERRIDE in packages/world-vercel/src/utils.ts to https://workflow-server-git-peter-v4.vercel.sh so that e2e tests running off this SDK branch exercise the v4-enabled workflow-server preview instead of production. The override is the inline mechanism documented at the constant — when set, it wins over both the default (https://vercel-workflow.com) and the VERCEL_WORKFLOW_SERVER_URL env var. The same pattern is used in v4 testing on the workflow- server side: CI rewrites this string on PR branches. Reset to '' before merging to main. Companion to vercel/workflow-server#439. Updates four tests in utils.test.ts that previously assumed the override is empty. Each affected assertion gets a comment noting what the expectation looks like on main; flipping back to the main behavior is a one-line edit per test when the override is reset. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
VaguelySerious added a commit
that referenced
this pull request
May 21, 2026
The adapter's createWorkflowRunEvent / getEvent / getWorkflowRunEvents now call the v4 endpoints internally instead of v2/v3. Public function signatures and the EventResult / Event / PaginatedResponse<Event> shapes returned to the workflow runtime are unchanged — only the wire protocol switches. Wire-format changes the SDK now drives: - Event metadata rides in x-wf-* request/response headers. - User payload is CBOR-encoded by the SDK at the eventData[field] boundary and shipped as opaque body bytes; never parsed on the server. - POST event response carries the materialized EventResult as a CBOR body — see workflow-server PR #439's "Return materialized entity in POST event response body" commit for the matching server-side change. The SDK no longer needs a second round-trip after POST to read run/step state. - LIST events uses the v4 binary-frame stream (application/vnd.workflow.v4-frames). Per-event `/refs` calls are gone — payloads come back inline in each frame. What goes away: - packages/world-vercel/src/refs.ts (deleted) — the /refs ref- hydration path is no longer needed. - hydrateEventRefs / collectPendingRefs / eventDataRefFieldMap and the EventResultResolveWireSchema / EventResultLazyWireSchema / EventWithRefsSchema wire schemas (deleted). - The lazy-refs branching inside createWorkflowRunEvent — the server already respects `remoteRefBehavior` (still sent for `eventsNeedingResolve` types) and bakes the resolution decision into its CBOR response. What stays: - v1Compat path on `createWorkflowRunEvent` (runs.create.v1 / runs.cancel.v1) — still uses v1 endpoints for legacy migrations that haven't moved to event sourcing. - validateUlidTimestamp on run_created, the HookNotFoundError translation on hook_disposed/hook_received 404s, and the stripEventDataRefs path for resolveData='none'. Not yet covered: - listEventsByCorrelationId throws a clear error — v4 has no by-correlation-id list endpoint yet; callers in the hot path have been fetching hooks directly anyway. A future server PR can add /api/v4/events?correlationId= if needed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
6 tasks
VaguelySerious added a commit
that referenced
this pull request
May 25, 2026
…CBOR The matching server-side change (workflow-server PR #439, commit 5d79cf1) now returns: - GET single event: full event entity CBOR-encoded in the body (resolves refs server-side and bakes payload into eventData). - LIST events: each frame's meta is the full event entity (CBOR), payload stays as a RefDescriptor in eventData[field], resolved bytes ride in the frame body. This commit threads that through the world-vercel adapter: - events-v4.ts: * getEventV4 returns DecodedV4Event (CBOR-decode of response body). Drop the parseEventMetaFromHeaders / readHeader-driven reconstruction. * ListedEventV4 carries `{ event: DecodedV4Event, body: Uint8Array }` — the full entity plus the resolved payload bytes to splice in. - events.ts: * buildEventFromV4 takes (decoded entity, payload bytes) and splices the bytes into eventData[payloadField] for the LIST path. For the GET path the server already baked the bytes in, so buildEventFromV4 is called with an empty body. * CBOR-decode the payload bytes back into the original JS value on read. Matches the unconditional CBOR-encode on write (Uint8Array round-trips via cbor-x's binary type). Why this matters: the workflow runtime's replay path reads arbitrary fields off eventData (executionContext, hookToken, isWebhook, resumeAt, error shape, …). The previous cherry-picked-metadata shape dropped those fields, which is why every E2E Vercel Prod test on this branch was getting stuck after run_started with no further events — the runtime's invocation of the workflow function on the workbench deployment couldn't reconstruct state correctly. Companion to workflow-server PR #439 commit 5d79cf1. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
VaguelySerious added a commit
that referenced
this pull request
May 25, 2026
Companion to workflow-server PR #439 commit 2a55acd, which switched GET /api/v4/runs/:runId/events/:eventId from a CBOR-entity body to a single v4 frame (same wire shape as one LIST frame). - getEventV4 now returns `{ event: DecodedV4Event, body: Uint8Array }` by reading exactly one frame off the response body via `decodeFrames` — same reader the LIST path uses. No content-type branching, no separate CBOR decode path. - getEvent (the storage adapter wrapper) passes both pieces to `buildEventFromV4`, which splices the CBOR-decoded body into `eventData[payloadField]`. Same path LIST already uses, so no GET-specific shape exists anymore. - Drop the special-case fallback in `buildEventFromV4` that used to re-decode an in-eventData Uint8Array — only one input shape now. Net effect: server-side memory for GET single-event is now bounded by S3 chunk size (~64 KB) instead of full payload size. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
VaguelySerious added a commit
that referenced
this pull request
May 25, 2026
Companion to workflow-server PR #439 commit 5036b56, which added `GET /api/v4/events?correlationId=...`. The SDK adapter's `storage.events.listByCorrelationId` no longer throws. Implementation: - New `getEventsByCorrelationIdV4` wire helper alongside `getWorkflowRunEventsV4`. Both share a small `consumeListFrameStream(url, config, opName)` that drives the same frame-stream-to-page conversion — only the URL differs. - `events.ts`'s `getWorkflowRunEvents` dispatches between the two based on whether params carry `runId` or `correlationId`. Same return shape on either path. Changeset updated to drop the "not yet implemented" caveat. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct interpolation of
${{ matrix.app.name }}in shell commands allows command injection from fork PRs that modifyscripts/create-test-matrix.mjs.Changes
${{ matrix.app.name }}interpolation with environment variables in shell commandsBefore:
After:
Jobs fixed
e2e-local-dev: Setup canary, Resolve symlinks, Run E2E Testse2e-local-prod: Setup canary, Run E2E Testse2e-local-postgres: Setup canary, Run E2E TestsView original Slack conversation
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.